RFR: 8370800: Downgrade cant.attach.type.annotations diagnostics to warnings [v8]

[Liam Miller-Cushon]

On Sun, 9 Nov 2025 18:30:53 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

>> Hi, please consider this fix for [JDK-8370800: Downgrade cant.attach.type.annotations diagnostics to warnings](https://bugs.openjdk.org/browse/JDK-8370800).
>> 
>> As discussed in the, this reduces the compatibility impact of these diagnostics for builds that deliberately omit transitive annotation dependencies, for example if they are only referenced through javadoc `@link` tags, or by frameworks that conditionally load the classes.
>> 
>> The PR changes the existing error diagnostic to an unconditional warning. Another alternative would be to make it an optional xlint diagnostic, perhaps as part of `-Xlint:classfile`, or as another category.
>
> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Complete symbols returned by getAllMembers

I am leaning towards holding off on changes here until there's a clear consensus about which of the approaches in is best.

Are there any more thoughts on the approaches discussed in https://github.com/openjdk/jdk/pull/28018#issuecomment-3636033828?

I think using symbol completion has the most desirable behaviour, but completers have more implementation complexity and risk. Downgrading the diagnostics to warnings is easier to reason about, but doesn't as precisely address the problem.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28018#issuecomment-3742718157