RFR: 8375015: CompletionAPITest::testDocumentation failed - AssertionFailedError: expected: <null> but was: <jshelltest.JShellTest>
Jan Lahoda
jlahoda at openjdk.org
Tue Jan 20 12:19:49 UTC 2026
On Tue, 13 Jan 2026 16:07:03 GMT, Christian Stein <cstein at openjdk.org> wrote:
> Please review this change to allow the test do work on more machines.
>
> Prior to this change, the timeout was too tight and the busy-waiting loop to CPU greedy (on some machines) to let the underlying garbarge collector perform its work and release the referene in question. That led to an assertion that failed.
>
> This change increases the timeout by a flat 10x and also "yields" by invoking `Thread.sleep(100)` in the wait loop.
Looks OK.
-------------
Marked as reviewed by jlahoda (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29196#pullrequestreview-3681898940
More information about the compiler-dev
mailing list