RFR: 8375646: Some parser flags seem unused [v3]

[Jan Lahoda]

On Mon, 19 Jan 2026 20:25:42 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Some of the flags in `JavacParser` are never set, such as `TYPEARGS` and `NOPARAMS`.
>> 
>> Another flag, namely `NODIAMOND` can easily be avoided by looking ahead one token.
>> 
>> This PR removes all the three flags. The main issue with these changes had to do with removing the `boolean allowDiamon` parameter from the `typeArguments` method, as doing so makes it clash with another similarly named method.
>> For this reason, this PR distinguish between:
>> 
>> * `typeArguments` -- a method that parses a type argument list, returns a list of `JCExpression`s
>> * `typeApply` -- a method that parses and applies type arguments to an existing type (a `JCExpression). This returns a new `JCExpression` (typically a `JCTypeApply`).
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Address review comments

Looks good to me!

-------------

Marked as reviewed by jlahoda (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/29302#pullrequestreview-3687625194