RFR: 8371162: Compiler warns about implicit cast from long to int in shift operation [v4]

Vicente Romero vromero at openjdk.org
Thu Jan 29 19:36:31 UTC 2026


On Sun, 4 Jan 2026 18:40:25 GMT, Archie Cobbs <acobbs at openjdk.org> wrote:

>> Consider code like this:
>> 
>> int x = 1;
>> x <<= 1L;
>> 
>> The compiler currently emits this warning:
>> 
>> warning: [lossy-conversions] implicit cast from long to int in compound assignment is possibly lossy
>>         x <<= 1L;
>>               ^
>> 
>> By definition, bit shift operations only use the bottom 5 or 6 bits of the specified shift amount (in this example, `1L`), and the JLS does not require the shift amount to be any specific integral type, only that that it be some integral type. So as long all but the bottom 5 or 6 bits are zero, there is no loss of information and the warning is inappropriate.
>> 
>> The case where the bottom 5 or 6 bits are _not_ all zero is addressed separately in [JDK-5038439](https://bugs.openjdk.org/browse/JDK-5038439).
>
> Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Update copyrights to 2026.
>  - Merge branch 'master' into JDK-8371162
>  - Merge branch 'master' into JDK-8371162 to fix conflict.
>  - Use cleaner switch statement syntax.
>  - Avoid lossy conversion warnings for 64 bit shift amounts.

lgtm

-------------

Marked as reviewed by vromero (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28180#pullrequestreview-3724613124


More information about the compiler-dev mailing list