<div dir="ltr"><div dir="ltr"><div>Hi folks,</div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Sep 25, 2022 at 4:02 PM Archie Cobbs <<a href="mailto:archie.cobbs@gmail.com" target="_blank">archie.cobbs@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">then the good news is that this is an easy <a href="https://github.com/openjdk/jdk/pull/10381/files#diff-8973dfc1d0ee2ff1319d8753daec3f0be7e9bd0a63e9512c38a0eeed68e5bcaa" target="_blank">three line fix</a></div>
</blockquote></div><div><br></div><div><div dir="ltr"><div>I'm still looking for any thoughts or comments on this proposed fix for 8043179.</div><div><br></div><div>I'm also looking for someone who is willing to consider being a sponsor for me. I've got this PR and a couple of other fixes in the hopper. In return I promise to be a good listener and hopefully a net positive contributor.<br></div><div><br></div><div>Also, I have a question - is anyone else having trouble building the JDK on macos 12.6 and Xcode 14.0?</div><div><br></div><div>I'm getting two build failures  in the latest code jdk-20+17-23-g0d8e3ce6b6e, one in GTest and one in JniInvocationTest.</div><div><br></div><div>The GTest build errors start like this:<br></div><div><br></div><div style="margin-left:40px"><span style="font-family:monospace">Creating hotspot/variant-server/libjvm/</span><span style="font-family:monospace">gtest/gtestLauncher from 1 file(s)<br>In file included from /Users/archie/proj/googletest/</span><span style="font-family:monospace">googlemock/src/gmock-all.cc:</span><span style="font-family:monospace">39:<br>In file included from /Users/archie/proj/googletest/</span><span style="font-family:monospace">googlemock/include/gmock/</span><span style="font-family:monospace">gmock.h:59:<br>/Users/archie/proj/googletest/</span><span style="font-family:monospace">googlemock/include/gmock/</span><span style="font-family:monospace">gmock-actions.h:484:3: error: definition of implicit copy constructor for 'PolymorphicAction<testing::</span><span style="font-family:monospace">internal::ReturnNullAction>' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]<br>  GTEST_DISALLOW_ASSIGN_(</span><span style="font-family:monospace">PolymorphicAction);<br>  ^<br>/Users/archie/proj/googletest/</span><span style="font-family:monospace">googletest/include/gtest/</span><span style="font-family:monospace">internal/gtest-port.h:928:8: note: expanded from macro 'GTEST_DISALLOW_ASSIGN_'<br>  void operator=(type const &) GTEST_CXX11_EQUALS_DELETE_<br>       ^<br>/Users/archie/proj/googletest/</span><span style="font-family:monospace">googlemock/include/gmock/</span><span style="font-family:monospace">gmock-actions.h:1125:10: note: in implicit copy constructor for 'testing::PolymorphicAction<</span><span style="font-family:monospace">testing::internal::</span><span style="font-family:monospace">ReturnNullAction>' first required here<br>  return MakePolymorphicAction(</span><span style="font-family:monospace">internal::ReturnNullAction());<br>         ^</span></div><div><br></div><div>These are the JniInvocationTest errors:</div><div><br></div><div style="margin-left:40px"><span style="font-family:monospace">Creating support/test/jdk/jtreg/native/bin/JniInvocationTest from 1 file(s)<br>/Users/archie/proj/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132: error: parameter 'SizeOfTag' set but not used [-Werror,-Wunused-but-set-parameter]<br>void *Type_ProfileSequenceId_Read(struct _cms_typehandler_struct* self, cmsIOHANDLER* io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)<br>                                                                                                                                   ^<br>/Users/archie/proj/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:5137:125: error: parameter 'SizeOfTag' set but not used [-Werror,-Wunused-but-set-parameter]<br>void *Type_Dictionary_Read(struct _cms_typehandler_struct* self, cmsIOHANDLER* io, cmsUInt32Number* nItems, cmsUInt32Number SizeOfTag)<br>                                                                                                                            ^<br>2 errors generated.<br></span></div></div><div dir="ltr"><br></div><div>The latter error is easy to workaround. I haven't tried fixing the former.<br></div><div dir="ltr"><br><div>Thanks,</div><div>-Archie<br></div></div></div><br>-- <br><div dir="ltr">Archie L. Cobbs<br></div></div>