<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Hi Christoph,<br>
<br>
What are the performance benefits you get from this patch? My
understanding is that your patch reduces the memory footprint but it
seems like there are also performance benefits, I think. The patch
looks good and won't affect readability although some comments
should be added to the new `print` version to explain why it is a
better fit for printing chars,<br>
<br>
Thanks,<br>
Vicente<br>
<br>
<div class="moz-cite-prefix">On 2/20/23 13:54,
<a class="moz-txt-link-abbreviated" href="mailto:christoph.dreis@freenet.de">christoph.dreis@freenet.de</a> wrote:<br>
</div>
<blockquote type="cite" cite="mid:PAXP193MB1231663F650EC78BDE9737E8AFA49@PAXP193MB1231.EURP193.PROD.OUTLOOK.COM">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style>@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}span.E-MailFormatvorlage17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}.MsoChpDefault
{mso-style-type:export-only;
font-size:12.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}div.WordSection1
{page:WordSection1;}</style>
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">I’ve
been profiling some build pipelines of some customer
projects – including their compilation phase.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">And
while Lombok is a major contributor in these projects (it’s
not an option to drop it unfortunately), there are some
optimization opportunities in the JDK itself.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">I’ve
opened a draft PR where you can find more information:
<a href="https://github.com/openjdk/jdk/pull/12667" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/openjdk/jdk/pull/12667</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">If
someone finds the time to take a look, I’d highly appreciate
it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">Cheers,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt" lang="EN-US">Christoph<o:p></o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>