<div dir="ltr">Thanks! I have updated the PR with the 'not expected here' language.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 3, 2024 at 1:52 AM Maurizio Cimadamore <<a href="mailto:maurizio.cimadamore@oracle.com">maurizio.cimadamore@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u>
<div>
<p><br>
</p>
<div>On 02/05/2024 19:17, Liam Miller-Cushon
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">Thanks Maurizio,
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<p>* can this error only be issues when there is a bad type
annotation in a qualified type? If not, then the latter
part of the message might be reaching too far<br>
</p>
</blockquote>
<div>That is the intent. The diagnostic should only be emitted
on a JCAnnotatedType if the name is qualified and the type
can be resolved, and if the annotations are type
annotations.</div>
</div>
</div>
</blockquote>
Thanks for the explanation!<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p> * in other places we have messages like "XYZ not
expected here" - perhaps might be useful to provide more
consistent diagnostics<br>
* Not sure about seeing @TA in the error message after
"locaton: " - in the sense that the message seems to
suggest that what's coming next (after the colon) is a
location, not the actual annotation?</p>
</div>
</blockquote>
<div>Thanks, great points. Perhaps showing the specific
annotations inline would be clearer, combined with the 'not
expected here' language that could result in something like:</div>
<div><br>
</div>
<div> <span style="font-family:monospace">type annotation @TA
is not expected here</span></div>
</div>
</div>
</blockquote>
<p>Yes, that would address my concern.</p>
<p>Cheers<br>
Maurizio<br>
</p>
<br>
</div>
</blockquote></div>