<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for the confirmation. I will submit this finalized specification for CSR review.</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> javadoc-dev <javadoc-dev-retn@openjdk.org> on behalf of Alex Buckley <alex.buckley@oracle.com><br>
<b>Sent:</b> Friday, August 2, 2024 10:53 AM<br>
<b>To:</b> compiler-dev@openjdk.org <compiler-dev@openjdk.org>; core-libs-dev@openjdk.org <core-libs-dev@openjdk.org>; javadoc-dev@openjdk.org <javadoc-dev@openjdk.org><br>
<b>Subject:</b> Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation [v8]</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">In the annotation `@Foo(a=1)`, the left hand side `a` is an _element_
<br>
(as declared in the annotation interface Foo) and the right hand side <br>
`1` is an _element value_ (per the first line of JLS 9.7.1).<br>
<br>
Syntactically the `a` is an identifier but that's almost never relevant <br>
what discussing element-value pairs. In the text you quoted, "an array <br>
element of an array-valued element `value`" is the right way to say it.<br>
<br>
Alex<br>
<br>
On 8/2/2024 8:45 AM, Chen Liang wrote:<br>
> One specification question for Alex: we call an annotation interface's <br>
> element "element". What about the element-value pair that binds a value <br>
> to an interface element in an annotation? Can we call this element-value <br>
> pair an "element", or is there any other more proper name that is still <br>
> concise? For context:<br>
> > [This annotation] is an array element of an array-valued element <br>
> named {@code value} in a container annotation<br>
> <br>
> ------------------------------------------------------------------------<br>
> *From:* core-libs-dev <core-libs-dev-retn@openjdk.org> on behalf of Adam <br>
> Sotona <asotona@openjdk.org><br>
> *Sent:* Friday, August 2, 2024 8:55 AM<br>
> *To:* compiler-dev@openjdk.org <compiler-dev@openjdk.org>; <br>
> core-libs-dev@openjdk.org <core-libs-dev@openjdk.org>; <br>
> javadoc-dev@openjdk.org <javadoc-dev@openjdk.org><br>
> *Subject:* Re: RFR: 8336754: Remodel TypeAnnotation to "has" instead of <br>
> "be" an Annotation [v8]<br>
> On Fri, 2 Aug 2024 00:04:48 GMT, Chen Liang <liach@openjdk.org> wrote:<br>
> <br>
>>> `TypeAnnotation` is not an annotation, as it should not be used in places like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an annotation at a given location instead of to be an annotation.<br>
>>> <br>
>>> Depends on #20205.<br>
>><br>
>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:<br>
>> <br>
>> - remove compile, use element-value, break long sentences<br>
>> - Merge branch 'master' of <a href="https://github.com/openjdk/jdk">https://github.com/openjdk/jdk</a> <<a href="https://github.com/openjdk/jdk">https://github.com/openjdk/jdk</a>> into
<br>
> fix/typeanno-model<br>
>> - Improve docs for repeating, default, and value name<br>
>> - Merge branch 'master' of <a href="https://github.com/openjdk/jdk">https://github.com/openjdk/jdk</a> <<a href="https://github.com/openjdk/jdk">https://github.com/openjdk/jdk</a>> into
<br>
> fix/typeanno-model<br>
>> - Merge branch 'master' of <a href="https://github.com/openjdk/jdk">https://github.com/openjdk/jdk</a> <<a href="https://github.com/openjdk/jdk">https://github.com/openjdk/jdk</a>> into
<br>
> fix/typeanno-model<br>
>> - More refinements from alex<br>
>> - Artifact -> construct<br>
>> - More about Annotation, add equals note<br>
>> - Further refine wording<br>
>> - Refine the spec of TypeAnnotation per Alex feedback<br>
>> - ... and 2 more: <a href="https://git.openjdk.org/jdk/compare/f3707e9b...3a91a3a5">
https://git.openjdk.org/jdk/compare/f3707e9b...3a91a3a5</a> <br>
> <<a href="https://git.openjdk.org/jdk/compare/f3707e9b...3a91a3a5">https://git.openjdk.org/jdk/compare/f3707e9b...3a91a3a5</a>><br>
> <br>
> Marked as reviewed by asotona (Reviewer).<br>
> <br>
> -------------<br>
> <br>
> PR Review: <br>
> <a href="https://git.openjdk.org/jdk/pull/20247#pullrequestreview-2215642863">https://git.openjdk.org/jdk/pull/20247#pullrequestreview-2215642863</a>
<br>
> <<a href="https://git.openjdk.org/jdk/pull/20247#pullrequestreview-2215642863">https://git.openjdk.org/jdk/pull/20247#pullrequestreview-2215642863</a>><br>
</div>
</span></font></div>
</body>
</html>