From pavel.rappo at gmail.com Fri May 2 15:17:39 2025 From: pavel.rappo at gmail.com (Pavel Rappo) Date: Fri, 2 May 2025 16:17:39 +0100 Subject: Define "enabled" in ScheduledExecutorService Message-ID: I've recently re-read documentation for ScheduledExecutorService. I noticed that the documentation uses the term "enabled", but does not define it. The semantics of the term feels almost intuitive, but not quite. To check my intuitions, I searched through the package documentation and source comments. I found usages of "enabled" in similar context of the time-scheduled task execution. Some of those usages are descriptions that are close to a proper definition. However, those descriptions are scattered through implementations of SchedulledExecutorService. I wonder if it makes sense to properly define "enable"/"enabled" in SchedulledExecutorService. -Pavel From alan.bateman at oracle.com Fri May 2 17:04:19 2025 From: alan.bateman at oracle.com (Alan Bateman) Date: Fri, 2 May 2025 18:04:19 +0100 Subject: Define "enabled" in ScheduledExecutorService In-Reply-To: References: Message-ID: <5be277d1-bdc5-4b87-a043-b559bc3e6faa@oracle.com> On 02/05/2025 16:17, Pavel Rappo wrote: > I've recently re-read documentation for ScheduledExecutorService. I > noticed that the documentation uses the term "enabled", but does not > define it. The semantics of the term feels almost intuitive, but not > quite. > > To check my intuitions, I searched through the package documentation > and source comments. I found usages of "enabled" in similar context of > the time-scheduled task execution. Some of those usages are > descriptions that are close to a proper definition. However, those > descriptions are scattered through implementations of > SchedulledExecutorService. > > I wonder if it makes sense to properly define "enable"/"enabled" in > SchedulledExecutorService. > As it happens, this came up recently when updating ForkJoinPool to implement ScheduledExecutorService . FJP class description make it clear what "enabled" means. It could potentially copied into SES. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: From pavel.rappo at gmail.com Fri May 2 17:46:51 2025 From: pavel.rappo at gmail.com (Pavel Rappo) Date: Fri, 2 May 2025 18:46:51 +0100 Subject: Define "enabled" in ScheduledExecutorService In-Reply-To: <5be277d1-bdc5-4b87-a043-b559bc3e6faa@oracle.com> References: <5be277d1-bdc5-4b87-a043-b559bc3e6faa@oracle.com> Message-ID: Thanks, Alan. That sounds like a plan. Shall I create a corresponding JBS issue? On Fri 2 May 2025 at 18:04, Alan Bateman wrote: > On 02/05/2025 16:17, Pavel Rappo wrote:I've recently re-read documentation > for ScheduledExecutorService. I > > I've recently re-read documentation for ScheduledExecutorService. I > noticed that the documentation uses the term "enabled", but does not > define it. The semantics of the term feels almost intuitive, but not > quite. > > To check my intuitions, I searched through the package documentation > and source comments. I found usages of "enabled" in similar context of > the time-scheduled task execution. Some of those usages are > descriptions that are close to a proper definition. However, those > descriptions are scattered through implementations of > SchedulledExecutorService. > > I wonder if it makes sense to properly define "enable"/"enabled" in > SchedulledExecutorService. > > > As it happens, this came up recently when updating ForkJoinPool to > implement ScheduledExecutorService . FJP class description make it clear > what "enabled" means. It could potentially copied into SES. > > > -Alan > -------------- next part -------------- An HTML attachment was scrubbed... URL: From viktor.klang at oracle.com Mon May 5 08:35:48 2025 From: viktor.klang at oracle.com (Viktor Klang) Date: Mon, 5 May 2025 08:35:48 +0000 Subject: Define "enabled" in ScheduledExecutorService In-Reply-To: References: <5be277d1-bdc5-4b87-a043-b559bc3e6faa@oracle.com> Message-ID: Sounds good, thanks Pavel! Cheers, ? Viktor Klang Software Architect, Java Platform Group Oracle ________________________________ From: concurrency-discuss on behalf of Pavel Rappo Sent: Friday, 2 May 2025 19:46 To: Alan Bateman Cc: concurrency-discuss at openjdk.org Subject: Re: Define "enabled" in ScheduledExecutorService Thanks, Alan. That sounds like a plan. Shall I create a corresponding JBS issue? On Fri 2 May 2025 at 18:04, Alan Bateman > wrote: On 02/05/2025 16:17, Pavel Rappo wrote:I've recently re-read documentation for ScheduledExecutorService. I I've recently re-read documentation for ScheduledExecutorService. I noticed that the documentation uses the term "enabled", but does not define it. The semantics of the term feels almost intuitive, but not quite. To check my intuitions, I searched through the package documentation and source comments. I found usages of "enabled" in similar context of the time-scheduled task execution. Some of those usages are descriptions that are close to a proper definition. However, those descriptions are scattered through implementations of SchedulledExecutorService. I wonder if it makes sense to properly define "enable"/"enabled" in SchedulledExecutorService. As it happens, this came up recently when updating ForkJoinPool to implement ScheduledExecutorService . FJP class description make it clear what "enabled" means. It could potentially copied into SES. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: From pavel.rappo at gmail.com Tue May 6 17:05:14 2025 From: pavel.rappo at gmail.com (Pavel Rappo) Date: Tue, 6 May 2025 18:05:14 +0100 Subject: Define "enabled" in ScheduledExecutorService In-Reply-To: References: <5be277d1-bdc5-4b87-a043-b559bc3e6faa@oracle.com> Message-ID: Done: https://bugs.openjdk.org/browse/JDK-8356304 On Mon, May 5, 2025 at 9:35?AM Viktor Klang wrote: > > Sounds good, thanks Pavel! > > Cheers, > ? > > > Viktor Klang > Software Architect, Java Platform Group > Oracle > ________________________________ > From: concurrency-discuss on behalf of Pavel Rappo > Sent: Friday, 2 May 2025 19:46 > To: Alan Bateman > Cc: concurrency-discuss at openjdk.org > Subject: Re: Define "enabled" in ScheduledExecutorService > > Thanks, Alan. That sounds like a plan. Shall I create a corresponding JBS issue? > > On Fri 2 May 2025 at 18:04, Alan Bateman wrote: > > On 02/05/2025 16:17, Pavel Rappo wrote:I've recently re-read documentation for ScheduledExecutorService. I > > I've recently re-read documentation for ScheduledExecutorService. I > noticed that the documentation uses the term "enabled", but does not > define it. The semantics of the term feels almost intuitive, but not > quite. > > To check my intuitions, I searched through the package documentation > and source comments. I found usages of "enabled" in similar context of > the time-scheduled task execution. Some of those usages are > descriptions that are close to a proper definition. However, those > descriptions are scattered through implementations of > SchedulledExecutorService. > > I wonder if it makes sense to properly define "enable"/"enabled" in > SchedulledExecutorService. > > As it happens, this came up recently when updating ForkJoinPool to implement ScheduledExecutorService . FJP class description make it clear what "enabled" means. It could potentially copied into SES. > > > -Alan