From martinrb at google.com Fri Aug 1 00:58:13 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 31 Jul 2008 17:58:13 -0700 Subject: covariant returns for CharBuffer.subSequence Message-ID: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> We would like to have return types of methods be the most covariant as is reasonable. The only problem is compatibility. For classes that cannot be subclassed by users, changing covariant returns is almost 100% compatible. (We all know that no change is 100.000000% compatible) The spec for CharBuffer.CharSequence appears to guarantee that the returned object is itself a CharBuffer, so all we need to change is the return type: Hence: diff --git a/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java b/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java --- a/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java +++ b/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java @@ -186,7 +186,7 @@ // --- Methods to support CharSequence --- - public CharSequence subSequence(int start, int end) { + public CharBuffer subSequence(int start, int end) { int pos = position(); int lim = limit(); assert (pos <= lim); diff --git a/src/share/classes/java/nio/Direct-X-Buffer.java b/src/share/classes/java/nio/Direct-X-Buffer.java --- a/src/share/classes/java/nio/Direct-X-Buffer.java +++ b/src/share/classes/java/nio/Direct-X-Buffer.java @@ -391,7 +391,7 @@ // --- Methods to support CharSequence --- - public CharSequence subSequence(int start, int end) { + public CharBuffer subSequence(int start, int end) { int pos = position(); int lim = limit(); assert (pos <= lim); diff --git a/src/share/classes/java/nio/Heap-X-Buffer.java b/src/share/classes/java/nio/Heap-X-Buffer.java --- a/src/share/classes/java/nio/Heap-X-Buffer.java +++ b/src/share/classes/java/nio/Heap-X-Buffer.java @@ -566,7 +566,7 @@ // --- Methods to support CharSequence --- - public CharSequence subSequence(int start, int end) { + public CharBuffer subSequence(int start, int end) { if ((start < 0) || (end > length()) || (start > end)) diff --git a/src/share/classes/java/nio/StringCharBuffer.java b/src/share/classes/java/nio/StringCharBuffer.java --- a/src/share/classes/java/nio/StringCharBuffer.java +++ b/src/share/classes/java/nio/StringCharBuffer.java @@ -99,7 +99,7 @@ return str.toString().substring(start + offset, end + offset); } - public final CharSequence subSequence(int start, int end) { + public final CharBuffer subSequence(int start, int end) { try { int pos = position(); return new StringCharBuffer(str, -1, diff --git a/src/share/classes/java/nio/X-Buffer.java b/src/share/classes/java/nio/X-Buffer.java --- a/src/share/classes/java/nio/X-Buffer.java +++ b/src/share/classes/java/nio/X-Buffer.java @@ -1245,7 +1245,7 @@ * If the preconditions on start and end * do not hold */ - public abstract CharSequence subSequence(int start, int end); + public abstract CharBuffer subSequence(int start, int end); // --- Methods to support Appendable --- From martinrb at google.com Fri Aug 1 01:18:05 2008 From: martinrb at google.com (Martin Buchholz) Date: Thu, 31 Jul 2008 18:18:05 -0700 Subject: StringBuXXXX improvements Message-ID: <1ccfd1c10807311818r2861b906k529be9ccf7b7cbce@mail.gmail.com> Hello, String wranglers, I have updated my proposed StringBu.... changes. Find them at http://g.oswego.edu/dl/wwwtmp/jsr166/mq/String/patches/ The AbstractStringBuilder performance improvements are now dependent on the covariant return changes to CharBuffer.subSequence to be found in subSequenceCovariantReturns.patch. I have no more performance improvements (in StringPerformance.patch) in the pipeline. I reviewed my own spec changes and am tempted to make these further spec improvements: - currently the "offset" parameter of the insert(offset,....) overloaded methods has 3 different names: offset, dstOffset, and index! I would like to rename these so only one name "offset" is used consistently. - The paragraph describing offset should be moved into the @throws spec. * The {@code offset} argument must be greater than or equal to * {@code 0}, and less than or equal to the {@linkplain #length() length} * of this sequence. ................... ...... * @throws IndexOutOfBoundsException if the offset is invalid. since the constraints will be obvious and uninteresting to most readers. - all insert(offset ...) methods throw StringIndexOutOfBoundsException, except for one, which throws plain IndexOutOfBoundsException I'd like to make this consistent across all methods. If we have consensus on these changes, I will implement them. Martin From martinrb at google.com Fri Aug 1 07:48:39 2008 From: martinrb at google.com (martinrb at google.com) Date: Fri, 01 Aug 2008 07:48:39 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080801074908.67048DDAE@hg.openjdk.java.net> Changeset: 3a1325be2806 Author: martin Date: 2008-08-01 00:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3a1325be2806 6730380: java.util.Timer should use AtomicInteger Reviewed-by: dl, chegar ! src/share/classes/java/util/Timer.java Changeset: f33c3846cecb Author: dl Date: 2008-08-01 00:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f33c3846cecb 6725789: ScheduledExecutorService does not work as expected in jdk7/6/5 Reviewed-by: martin, dholmes, chegar ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java + test/java/util/concurrent/ScheduledThreadPoolExecutor/DelayOverflow.java From Alan.Bateman at Sun.COM Fri Aug 1 08:39:45 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Fri, 01 Aug 2008 09:39:45 +0100 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> Message-ID: <4892CBD1.8070907@sun.com> Martin Buchholz wrote: > We would like to have return types of methods be the most covariant > as is reasonable. The only problem is compatibility. > For classes that cannot be subclassed by users, > changing covariant returns is almost 100% compatible. > (We all know that no change is 100.000000% compatible) > > The spec for CharBuffer.CharSequence appears to guarantee that > the returned object is itself a CharBuffer, so all we need to > change is the return type: > Right, buffers are not extensible (no public or protected constructors, etc.) so it does seem safe to take advantage of covariant returns. There are a number of other "opportunities" in this package that Iris and I have chatted about for jdk7. In particular the Buffer flip/etc. methods come up quite often as the more specific return type would facilitate better method invocation chaining. Are you interested in doing those too? I ask because there are a couple of existing RFEs for this (4774077 is the main one)? If not, then we can create a specific bug for subSequence to let you get this done. I see your String updates have a dependency on this. I've only glanced at it so far but I assume by moving the casts you can separate this work if required. -Alan. > Hence: > > diff --git a/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java > b/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java > --- a/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java > +++ b/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java > @@ -186,7 +186,7 @@ > > // --- Methods to support CharSequence --- > > - public CharSequence subSequence(int start, int end) { > + public CharBuffer subSequence(int start, int end) { > int pos = position(); > int lim = limit(); > assert (pos <= lim); > diff --git a/src/share/classes/java/nio/Direct-X-Buffer.java > b/src/share/classes/java/nio/Direct-X-Buffer.java > --- a/src/share/classes/java/nio/Direct-X-Buffer.java > +++ b/src/share/classes/java/nio/Direct-X-Buffer.java > @@ -391,7 +391,7 @@ > > // --- Methods to support CharSequence --- > > - public CharSequence subSequence(int start, int end) { > + public CharBuffer subSequence(int start, int end) { > int pos = position(); > int lim = limit(); > assert (pos <= lim); > diff --git a/src/share/classes/java/nio/Heap-X-Buffer.java > b/src/share/classes/java/nio/Heap-X-Buffer.java > --- a/src/share/classes/java/nio/Heap-X-Buffer.java > +++ b/src/share/classes/java/nio/Heap-X-Buffer.java > @@ -566,7 +566,7 @@ > > // --- Methods to support CharSequence --- > > - public CharSequence subSequence(int start, int end) { > + public CharBuffer subSequence(int start, int end) { > if ((start < 0) > || (end > length()) > || (start > end)) > diff --git a/src/share/classes/java/nio/StringCharBuffer.java > b/src/share/classes/java/nio/StringCharBuffer.java > --- a/src/share/classes/java/nio/StringCharBuffer.java > +++ b/src/share/classes/java/nio/StringCharBuffer.java > @@ -99,7 +99,7 @@ > return str.toString().substring(start + offset, end + offset); > } > > - public final CharSequence subSequence(int start, int end) { > + public final CharBuffer subSequence(int start, int end) { > try { > int pos = position(); > return new StringCharBuffer(str, -1, > diff --git a/src/share/classes/java/nio/X-Buffer.java > b/src/share/classes/java/nio/X-Buffer.java > --- a/src/share/classes/java/nio/X-Buffer.java > +++ b/src/share/classes/java/nio/X-Buffer.java > @@ -1245,7 +1245,7 @@ > * If the preconditions on start and end > * do not hold > */ > - public abstract CharSequence subSequence(int start, int end); > + public abstract CharBuffer subSequence(int start, int end); > > > // --- Methods to support Appendable --- > From daniel.fuchs at sun.com Fri Aug 1 09:43:43 2008 From: daniel.fuchs at sun.com (daniel.fuchs at sun.com) Date: Fri, 01 Aug 2008 09:43:43 +0000 Subject: hg: jdk7/tl/jdk: 6732192: CORE_PKGS.gmk: need to declare javax.management.event in the CORE_PKGS variable Message-ID: <20080801094355.29194DDD5@hg.openjdk.java.net> Changeset: e0dc076d99b8 Author: dfuchs Date: 2008-08-01 11:41 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0dc076d99b8 6732192: CORE_PKGS.gmk: need to declare javax.management.event in the CORE_PKGS variable Reviewed-by: emcmanus ! make/docs/CORE_PKGS.gmk From martinrb at google.com Fri Aug 1 16:04:07 2008 From: martinrb at google.com (Martin Buchholz) Date: Fri, 1 Aug 2008 09:04:07 -0700 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <4892CBD1.8070907@sun.com> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> Message-ID: <1ccfd1c10808010904v28adc04hfbf2c45feaca725f@mail.gmail.com> On Fri, Aug 1, 2008 at 1:39 AM, Alan Bateman wrote: > Martin Buchholz wrote: >> >> We would like to have return types of methods be the most covariant >> as is reasonable. The only problem is compatibility. >> For classes that cannot be subclassed by users, >> changing covariant returns is almost 100% compatible. >> (We all know that no change is 100.000000% compatible) >> >> The spec for CharBuffer.CharSequence appears to guarantee that >> the returned object is itself a CharBuffer, so all we need to >> change is the return type: >> > > Right, buffers are not extensible (no public or protected constructors, > etc.) so it does seem safe to take advantage of covariant returns. There > are a number of other "opportunities" in this package that Iris and I have > chatted about for jdk7. In particular the Buffer flip/etc. methods come up > quite often as the more specific return type would facilitate better method > invocation chaining. Are you interested in doing those too? I ask because > there are a couple of existing RFEs for this (4774077 is the main one)? If > not, then we can create a specific bug for subSequence to let you get this > done. As often happens with me, this change is ever-expanding out of scope. If we have consensus on the covariant returns for other Buffers, I am willing to add these to the change. > I see your String updates have a dependency on this. I've only glanced at it > so far but I assume by moving the casts you can separate this work if > required. There is a dependency, but it is for performance only, and it's not actually obvious it's a good idea, since hotspot has gotten so much better at generating the equivalent of the same code on its own. Benchmarking required. Martin From david.lloyd at redhat.com Fri Aug 1 16:11:02 2008 From: david.lloyd at redhat.com (David M. Lloyd) Date: Fri, 01 Aug 2008 11:11:02 -0500 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <1ccfd1c10808010904v28adc04hfbf2c45feaca725f@mail.gmail.com> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> <1ccfd1c10808010904v28adc04hfbf2c45feaca725f@mail.gmail.com> Message-ID: <48933596.8040208@redhat.com> On 08/01/2008 11:04 AM, Martin Buchholz wrote: > As often happens with me, this change is ever-expanding out of scope. > If we have consensus on the covariant returns for other Buffers, > I am willing to add these to the change. You've got my vote! Not that it's worth anything. :-) - DML From Ulf.Zibis at gmx.de Fri Aug 1 18:21:15 2008 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Fri, 01 Aug 2008 20:21:15 +0200 Subject: java-nio-charset-enhanced -|- Milestone 1 is released Message-ID: <4893541B.2070405@gmx.de> Hi all, I'm proud to anounce, that I have released Milestone 1 of my .net-project: https://java-nio-charset-enhanced.dev.java.net/ 198 inner de/encoder classes have been removed in footprint's favor. The performance is somewhat better than the JDK 6 original. More is planned for the next releases. Regards, Ulf Zibis From Alan.Bateman at Sun.COM Fri Aug 1 20:11:00 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Fri, 01 Aug 2008 21:11:00 +0100 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <1ccfd1c10808010904v28adc04hfbf2c45feaca725f@mail.gmail.com> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> <1ccfd1c10808010904v28adc04hfbf2c45feaca725f@mail.gmail.com> Message-ID: <48936DD4.3080100@sun.com> Martin Buchholz wrote: > : > As often happens with me, this change is ever-expanding out of scope. > If we have consensus on the covariant returns for other Buffers, > I am willing to add these to the change. > I don't mean to twist your arm :-) As this is API change there is a bit of process work which is why I suggested we do it as one bugID rather than several. If you'd prefer I can do the updates to the buffer classes, get the process work started next week, and let you focus on the String updates. -Alan. From kelly.ohair at sun.com Fri Aug 1 20:55:51 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Fri, 01 Aug 2008 20:55:51 +0000 Subject: hg: jdk7/tl/corba: 6732815: CORBA_2_3 java sources not explicitly compiled Message-ID: <20080801205552.2DC26DE61@hg.openjdk.java.net> Changeset: e9dad83f035c Author: ohair Date: 2008-08-01 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/e9dad83f035c 6732815: CORBA_2_3 java sources not explicitly compiled Reviewed-by: tbell ! make/org/omg/CORBA/Makefile From jim.holmlund at sun.com Fri Aug 1 20:58:55 2008 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Fri, 01 Aug 2008 20:58:55 +0000 Subject: hg: jdk7/tl/jdk: 6730273: TEST: JDI_REGRESSION test Solaris32AndSolaris64Test.sh fails if -XX:+UseCompressedOops is used Message-ID: <20080801205907.9347FDE6A@hg.openjdk.java.net> Changeset: 3232179e24ae Author: jjh Date: 2008-08-01 13:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3232179e24ae 6730273: TEST: JDI_REGRESSION test Solaris32AndSolaris64Test.sh fails if -XX:+UseCompressedOops is used Summary: Fix test to not pass -XX:[+-]UseCompressedOops to the debuggee. Reviewed-by: tbell ! test/com/sun/jdi/Solaris32AndSolaris64Test.sh From jonathan.gibbons at sun.com Fri Aug 1 22:23:45 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 01 Aug 2008 22:23:45 +0000 Subject: hg: jdk7/tl/langtools: 6627362: javac generates code that uses array.clone, which is not available on JavaCard; ... Message-ID: <20080801222347.21DBCDE81@hg.openjdk.java.net> Changeset: 3437676858e3 Author: jjg Date: 2008-08-01 15:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3437676858e3 6627362: javac generates code that uses array.clone, which is not available on JavaCard 6627364: javac needs Float and Double on the bootclasspath even when not directly used 6627366: javac needs Cloneable and Serializable on the classpath even when not directly used Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! test/tools/javac/5045412/Bar.java ! test/tools/javac/5045412/Foo.java - test/tools/javac/5045412/out + test/tools/javac/6627362/T6627362.java + test/tools/javac/6627362/x/E.java + test/tools/javac/6627362/x/Object.java + test/tools/javac/synthesize/Boolean.java + test/tools/javac/synthesize/Byte.java + test/tools/javac/synthesize/Character.java + test/tools/javac/synthesize/Cloneable.java + test/tools/javac/synthesize/Double.java + test/tools/javac/synthesize/Float.java + test/tools/javac/synthesize/Integer.java + test/tools/javac/synthesize/Long.java + test/tools/javac/synthesize/Main.java + test/tools/javac/synthesize/Number.java + test/tools/javac/synthesize/Object.java + test/tools/javac/synthesize/Serializable.java + test/tools/javac/synthesize/Short.java + test/tools/javac/synthesize/Test.java + test/tools/javac/synthesize/Void.java From Ulf.Zibis at gmx.de Sat Aug 2 09:24:58 2008 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sat, 02 Aug 2008 11:24:58 +0200 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <48937456.4060907@gmx.de> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> <48937456.4060907@gmx.de> Message-ID: <489427EA.2040503@gmx.de> Another approach could be to implicitly allow method invocation chaining for all void methods. This would save the return statement, and its superfluous byte code. ... but I think, you know all this: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6373386 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6479372 -Ulf Am 01.08.2008 22:38, Ulf Zibis schrieb: > Am 01.08.2008 10:39, Alan Bateman schrieb: >> In particular the Buffer flip/etc. methods come up quite often as the >> more specific return type would facilitate better method invocation >> chaining. > > Some time ago I've discussed this with Neal Gafter. My conclusion is, > that those problems could be solved by a "this" return type. > > Example: > > public abstract class Buffer { > > public final this flip() { > ... > return this; > } > > } > > -Ulf > > From Ulf.Zibis at gmx.de Sat Aug 2 09:54:31 2008 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sat, 02 Aug 2008 11:54:31 +0200 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <4892CBD1.8070907@sun.com> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> Message-ID: <48942ED7.1040603@gmx.de> Am 01.08.2008 10:39, Alan Bateman schrieb: > In particular the Buffer flip/etc. methods come up quite often as the > more specific return type would facilitate better method invocation > chaining. Some time ago I've discussed this with Neal Gafter. My conclusion is, that those problems could be solved by a "this" return type. Example: public abstract class Buffer { public final this flip() { ... return this; } } -Ulf From Ulf.Zibis at gmx.de Sat Aug 2 10:00:40 2008 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sat, 02 Aug 2008 12:00:40 +0200 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <48942ED7.1040603@gmx.de> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> <48942ED7.1040603@gmx.de> Message-ID: <48943048.9090407@gmx.de> What about to distinguish chainable from unchainable methods by dropping the 'void' keyword for chainables? So there would be no need to think about a new type, which is not generally usable e.g. for parameters. OK, there would be some chance for confusion with constructors, but method names normally shouldn't start with a capital letter, but constructors should. -Ulf Am 02.08.2008 11:54, Ulf Zibis schrieb: > Am 01.08.2008 10:39, Alan Bateman schrieb: >> In particular the Buffer flip/etc. methods come up quite often as the >> more specific return type would facilitate better method invocation >> chaining. > > Some time ago I've discussed this with Neal Gafter. My conclusion is, > that those problems could be solved by a "this" return type. > > Example: > > public abstract class Buffer { > > public final this flip() { > ... > return this; > } > > } > > -Ulf > > > From david.lloyd at redhat.com Sat Aug 2 14:01:42 2008 From: david.lloyd at redhat.com (David M. Lloyd) Date: Sat, 02 Aug 2008 09:01:42 -0500 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <48942ED7.1040603@gmx.de> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> <48942ED7.1040603@gmx.de> Message-ID: <489468C6.2070600@redhat.com> On 08/02/2008 04:54 AM, Ulf Zibis wrote: > Am 01.08.2008 10:39, Alan Bateman schrieb: >> In particular the Buffer flip/etc. methods come up quite often as the >> more specific return type would facilitate better method invocation >> chaining. > > Some time ago I've discussed this with Neal Gafter. My conclusion is, > that those problems could be solved by a "this" return type. Or just by using covariant return types, which already exist in the language for this very purpose. Why is everyone so keen to tear up the language, in order to add solutions to problems that already have solutions? - DML From martinrb at google.com Sat Aug 2 23:05:11 2008 From: martinrb at google.com (Martin Buchholz) Date: Sat, 2 Aug 2008 16:05:11 -0700 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <4892CBD1.8070907@sun.com> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> Message-ID: <1ccfd1c10808021605v20e75126g6e6a94c52e976abb@mail.gmail.com> Hi Buffer Buddies, My changes for CharSequence are both easier and less controversial than changes for Buffer.mark,flip,clear. All one has to do in my proposal is change return types. For Buffer methods, on the other hand, one has to copy/paste/modify javadoc from Buffer into its subclasses, and more importantly, remove the "final" modifier on Buffer's methods, which is a noticeable incompatibility, that might perhaps have security or performance implications. So I am declining the invitation to work on those. The covariant CharSequence change can stand on its own. Martin On Fri, Aug 1, 2008 at 1:39 AM, Alan Bateman wrote: > Martin Buchholz wrote: >> >> We would like to have return types of methods be the most covariant >> as is reasonable. The only problem is compatibility. >> For classes that cannot be subclassed by users, >> changing covariant returns is almost 100% compatible. >> (We all know that no change is 100.000000% compatible) >> >> The spec for CharBuffer.CharSequence appears to guarantee that >> the returned object is itself a CharBuffer, so all we need to >> change is the return type: >> > > Right, buffers are not extensible (no public or protected constructors, > etc.) so it does seem safe to take advantage of covariant returns. There > are a number of other "opportunities" in this package that Iris and I have > chatted about for jdk7. In particular the Buffer flip/etc. methods come up > quite often as the more specific return type would facilitate better method > invocation chaining. Are you interested in doing those too? I ask because > there are a couple of existing RFEs for this (4774077 is the main one)? If > not, then we can create a specific bug for subSequence to let you get this > done. > > I see your String updates have a dependency on this. I've only glanced at it > so far but I assume by moving the casts you can separate this work if > required. > > -Alan. > > >> Hence: >> >> diff --git a/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java >> b/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java >> --- a/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java >> +++ b/src/share/classes/java/nio/ByteBufferAs-X-Buffer.java >> @@ -186,7 +186,7 @@ >> >> // --- Methods to support CharSequence --- >> >> - public CharSequence subSequence(int start, int end) { >> + public CharBuffer subSequence(int start, int end) { >> int pos = position(); >> int lim = limit(); >> assert (pos <= lim); >> diff --git a/src/share/classes/java/nio/Direct-X-Buffer.java >> b/src/share/classes/java/nio/Direct-X-Buffer.java >> --- a/src/share/classes/java/nio/Direct-X-Buffer.java >> +++ b/src/share/classes/java/nio/Direct-X-Buffer.java >> @@ -391,7 +391,7 @@ >> >> // --- Methods to support CharSequence --- >> >> - public CharSequence subSequence(int start, int end) { >> + public CharBuffer subSequence(int start, int end) { >> int pos = position(); >> int lim = limit(); >> assert (pos <= lim); >> diff --git a/src/share/classes/java/nio/Heap-X-Buffer.java >> b/src/share/classes/java/nio/Heap-X-Buffer.java >> --- a/src/share/classes/java/nio/Heap-X-Buffer.java >> +++ b/src/share/classes/java/nio/Heap-X-Buffer.java >> @@ -566,7 +566,7 @@ >> >> // --- Methods to support CharSequence --- >> >> - public CharSequence subSequence(int start, int end) { >> + public CharBuffer subSequence(int start, int end) { >> if ((start < 0) >> || (end > length()) >> || (start > end)) >> diff --git a/src/share/classes/java/nio/StringCharBuffer.java >> b/src/share/classes/java/nio/StringCharBuffer.java >> --- a/src/share/classes/java/nio/StringCharBuffer.java >> +++ b/src/share/classes/java/nio/StringCharBuffer.java >> @@ -99,7 +99,7 @@ >> return str.toString().substring(start + offset, end + offset); >> } >> >> - public final CharSequence subSequence(int start, int end) { >> + public final CharBuffer subSequence(int start, int end) { >> try { >> int pos = position(); >> return new StringCharBuffer(str, -1, >> diff --git a/src/share/classes/java/nio/X-Buffer.java >> b/src/share/classes/java/nio/X-Buffer.java >> --- a/src/share/classes/java/nio/X-Buffer.java >> +++ b/src/share/classes/java/nio/X-Buffer.java >> @@ -1245,7 +1245,7 @@ >> * If the preconditions on start and end >> * do not hold >> */ >> - public abstract CharSequence subSequence(int start, int end); >> + public abstract CharBuffer subSequence(int start, int end); >> >> >> // --- Methods to support Appendable --- >> > > From mr at sun.com Sun Aug 3 04:28:51 2008 From: mr at sun.com (Mark Reinhold) Date: Sat, 02 Aug 2008 21:28:51 -0700 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: david.lloyd@redhat.com; Sat, 02 Aug 2008 09:01:42 CDT; <489468C6.2070600@redhat.com> Message-ID: <20080803042851.78D042BF53@callebaut.niobe.net> > Date: Sat, 02 Aug 2008 09:01:42 -0500 > From: david.lloyd at redhat.com > On 08/02/2008 04:54 AM, Ulf Zibis wrote: >> Some time ago I've discussed this with Neal Gafter. My conclusion is, >> that those problems could be solved by a "this" return type. > > Or just by using covariant return types, which already exist in the > language for this very purpose. Why is everyone so keen to tear up the > language, in order to add solutions to problems that already have solutions? Excellent question! - Mark From kevinb at google.com Sun Aug 3 18:31:52 2008 From: kevinb at google.com (kevin bourrillion) Date: Sun, 3 Aug 2008 11:31:52 -0700 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <20080803042851.78D042BF53@callebaut.niobe.net> References: <489468C6.2070600@redhat.com> <20080803042851.78D042BF53@callebaut.niobe.net> Message-ID: <108fcdeb0808031131p43298faem3e9427819a4693ba@mail.gmail.com> On Sat, Aug 2, 2008 at 9:28 PM, Mark Reinhold wrote: > Or just by using covariant return types, which already exist in the > > language for this very purpose. Why is everyone so keen to tear up the > > language, in order to add solutions to problems that already have > solutions? > > Excellent question! I think most developers are way too quick to conclude that a language change is needed to solve any particular problem. Most of us can't even begin to understand all the mountainous ramifications and repercussions, nor the incredible effort to safely rev the JLS, etc. That said, I just want to address this idea of "adding solutions to problems that already have solutions." Because among the four language features (two existing and two proposed) - covariant return types - recursive bounds (Foo>) - 'this' type - void methods implicitly return 'this' No two of these solve exactly the same set of problems as each other. Each addresses at least some situations not addressed by any of the others. So we can't effectively dismiss any of them by simply pointing to the existence of another. And it's fair to have a discussion about what set of problems each of the latter two solves that don't have reasonable solutions already. (But that discussion doesn't belong in this list.) -- Kevin Bourrillion @ Google internal: go/javalibraries google-collections.googlecode.com google-guice.googlecode.com -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alan.Bateman at Sun.COM Mon Aug 4 11:17:21 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Mon, 04 Aug 2008 12:17:21 +0100 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <1ccfd1c10808021605v20e75126g6e6a94c52e976abb@mail.gmail.com> References: <1ccfd1c10807311758g6473da7fgf0d8a3e7d81c5407@mail.gmail.com> <4892CBD1.8070907@sun.com> <1ccfd1c10808021605v20e75126g6e6a94c52e976abb@mail.gmail.com> Message-ID: <4896E541.1040005@sun.com> Martin Buchholz wrote: > Hi Buffer Buddies, > > My changes for CharSequence are both easier and > less controversial than changes for Buffer.mark,flip,clear. > All one has to do in my proposal is change return types. > > For Buffer methods, on the other hand, one has to > copy/paste/modify javadoc from Buffer into its subclasses, > and more importantly, remove the "final" modifier on > Buffer's methods, which is a noticeable incompatibility, > that might perhaps have security or performance implications. > So I am declining the invitation to work on those. > The covariant CharSequence change can stand on its own. > Okay. I've created the following to track this: 6733145: (bf) CharBuffer.subSequence can be updated to take advantage of covariant returns -Alan. From jonathan.gibbons at sun.com Mon Aug 4 22:09:26 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Mon, 04 Aug 2008 22:09:26 +0000 Subject: hg: jdk7/tl/langtools: 4111861: static final field contents are not displayed Message-ID: <20080804220927.D4C81D07D@hg.openjdk.java.net> Changeset: fd1d361ae294 Author: jjg Date: 2008-08-04 15:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/fd1d361ae294 4111861: static final field contents are not displayed Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Options.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties + test/tools/javap/4111861/A.java + test/tools/javap/4111861/T4111861.java From jonathan.gibbons at sun.com Tue Aug 5 00:54:39 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 05 Aug 2008 00:54:39 +0000 Subject: hg: jdk7/tl/langtools: 4884240: additional option required for javap Message-ID: <20080805005441.9DE75D116@hg.openjdk.java.net> Changeset: 05684554f040 Author: jjg Date: 2008-08-04 17:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/05684554f040 4884240: additional option required for javap Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javap/ClassWriter.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! src/share/classes/com/sun/tools/javap/Options.java ! src/share/classes/com/sun/tools/javap/resources/javap.properties + test/tools/javap/T4884240.java ! test/tools/javap/T6622260.java From eamonn.mcmanus at sun.com Tue Aug 5 08:51:23 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Tue, 05 Aug 2008 08:51:23 +0000 Subject: hg: jdk7/tl/jdk: 6733589: Intermittent failure of test/javax/management/eventService/SharingThreadTest.java Message-ID: <20080805085135.7A83ED184@hg.openjdk.java.net> Changeset: 00c40e393a75 Author: emcmanus Date: 2008-08-05 10:49 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00c40e393a75 6733589: Intermittent failure of test/javax/management/eventService/SharingThreadTest.java Reviewed-by: sjiang ! test/javax/management/eventService/SharingThreadTest.java From maurizio.cimadamore at sun.com Tue Aug 5 11:54:54 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Tue, 05 Aug 2008 11:54:54 +0000 Subject: hg: jdk7/tl/langtools: 6730423: Diagnostic formatter should be an instance field of JCDiagnostic Message-ID: <20080805115456.3BF24D197@hg.openjdk.java.net> Changeset: b6d5f53b3b29 Author: mcimadamore Date: 2008-08-05 12:54 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b6d5f53b3b29 6730423: Diagnostic formatter should be an instance field of JCDiagnostic Summary: JCDiagnostic.fragment should be deprecated and the diagnostic factory should be used instead Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java From jonathan.gibbons at sun.com Wed Aug 6 00:07:53 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 06 Aug 2008 00:07:53 +0000 Subject: hg: jdk7/tl/langtools: 6733995: legal notice repair on langtools/src/share/classes/com/sun/tools/javap/JavapTask.java Message-ID: <20080806000755.7AE7AD27E@hg.openjdk.java.net> Changeset: 6be961ee2290 Author: jjg Date: 2008-08-05 17:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6be961ee2290 6733995: legal notice repair on langtools/src/share/classes/com/sun/tools/javap/JavapTask.java Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javap/JavapTask.java From eamonn.mcmanus at sun.com Wed Aug 6 16:31:22 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Wed, 06 Aug 2008 16:31:22 +0000 Subject: hg: jdk7/tl/jdk: 6734273: Minor updates to documentation of Custom MXBean Mappings Message-ID: <20080806163139.94DDCD2CF@hg.openjdk.java.net> Changeset: 13b8426bb0cd Author: emcmanus Date: 2008-08-06 18:28 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/13b8426bb0cd 6734273: Minor updates to documentation of Custom MXBean Mappings Reviewed-by: dfuchs ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/openmbean/MXBeanMapping.java ! src/share/classes/javax/management/openmbean/MXBeanMappingFactory.java From swamy.venkataramanappa at sun.com Wed Aug 6 17:53:04 2008 From: swamy.venkataramanappa at sun.com (swamy.venkataramanappa at sun.com) Date: Wed, 06 Aug 2008 17:53:04 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080806175328.EE541D2E0@hg.openjdk.java.net> Changeset: f8c58e72b807 Author: swamyv Date: 2008-08-06 10:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f8c58e72b807 6732441: TEST_BUG: ThreadMXBeanProxy test fails intermittently. Summary: Fixed the race condition in the test. Reviewed-by: jjh ! test/java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Changeset: 871c10d47f8d Author: swamyv Date: 2008-08-06 10:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/871c10d47f8d Merge From kelly.ohair at sun.com Wed Aug 6 21:59:10 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Wed, 06 Aug 2008 21:59:10 +0000 Subject: hg: jdk7/tl/corba: 6734545: Corrections to missing explicit corba sources on javac compile lines Message-ID: <20080806215911.6D6DCD318@hg.openjdk.java.net> Changeset: 6e0cf0dc59e5 Author: ohair Date: 2008-08-06 14:30 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/6e0cf0dc59e5 6734545: Corrections to missing explicit corba sources on javac compile lines Reviewed-by: tbell ! make/com/sun/corba/minclude/com_sun_corba_se_impl_dynamicany.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_encoding.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_ior.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_orbutil.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_impl_protocol.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_legacy_interceptor.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_monitoring.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_presentation_rmi.jmk ! make/com/sun/corba/minclude/com_sun_corba_se_spi_transport.jmk ! make/com/sun/corba/minclude/org_omg_CosNaming.jmk ! make/com/sun/corba/minclude/org_omg_DynamicAny.jmk ! make/com/sun/corba/minclude/org_omg_PortableInterceptor.jmk ! make/com/sun/corba/se/sources/Makefile ! make/javax/xa/Makefile ! make/org/omg/CORBA/Makefile From martinrb at google.com Thu Aug 7 13:41:03 2008 From: martinrb at google.com (martinrb at google.com) Date: Thu, 07 Aug 2008 13:41:03 +0000 Subject: hg: jdk7/tl/jdk: 6730507: java.util.Timer schedule delay Long.MAX_VALUE causes task to execute multiple times Message-ID: <20080807134115.6CDB6D53D@hg.openjdk.java.net> Changeset: 659b74b5373f Author: martin Date: 2008-08-07 06:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/659b74b5373f 6730507: java.util.Timer schedule delay Long.MAX_VALUE causes task to execute multiple times Reviewed-by: chegar ! src/share/classes/java/util/Timer.java + test/java/util/Timer/DelayOverflow.java From eamonn.mcmanus at sun.com Thu Aug 7 14:26:13 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Thu, 07 Aug 2008 14:26:13 +0000 Subject: hg: jdk7/tl/jdk: 6717257: MBeanServer doesn't describe RuntimeException for methods inherited from MBeanServerConnection Message-ID: <20080807142625.9D7BCD548@hg.openjdk.java.net> Changeset: afe18ad188a1 Author: emcmanus Date: 2008-08-07 16:25 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/afe18ad188a1 6717257: MBeanServer doesn't describe RuntimeException for methods inherited from MBeanServerConnection Reviewed-by: dfuchs ! src/share/classes/javax/management/MBeanServer.java From daniel.fuchs at sun.com Fri Aug 8 12:25:20 2008 From: daniel.fuchs at sun.com (daniel.fuchs at sun.com) Date: Fri, 08 Aug 2008 12:25:20 +0000 Subject: hg: jdk7/tl/jdk: 6733294: MBeans tab - UI issues with writable attributes Message-ID: <20080808122532.41BDCDA95@hg.openjdk.java.net> Changeset: 233f8854d8b4 Author: dfuchs Date: 2008-08-08 14:24 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/233f8854d8b4 6733294: MBeans tab - UI issues with writable attributes Reviewed-by: emcmanus ! make/netbeans/jconsole/build.properties ! make/netbeans/jconsole/build.xml ! src/share/classes/sun/tools/jconsole/inspector/TableSorter.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java ! src/share/classes/sun/tools/jconsole/inspector/XPlotter.java ! src/share/classes/sun/tools/jconsole/inspector/XSheet.java ! src/share/classes/sun/tools/jconsole/inspector/XTable.java ! src/share/classes/sun/tools/jconsole/inspector/XTextFieldEditor.java From eamonn.mcmanus at sun.com Fri Aug 8 13:11:25 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Fri, 08 Aug 2008 13:11:25 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080808131148.CDB8CDABC@hg.openjdk.java.net> Changeset: e9de9ae8c214 Author: emcmanus Date: 2008-08-08 15:08 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e9de9ae8c214 6334663: TabularDataSupport should be able to return values in the insertion order Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/share/classes/javax/management/openmbean/TabularDataSupport.java + test/javax/management/openmbean/TabularDataOrderTest.java Changeset: 4fac95ca002a Author: emcmanus Date: 2008-08-08 15:10 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4fac95ca002a Merge From eamonn.mcmanus at sun.com Fri Aug 8 16:37:02 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Fri, 08 Aug 2008 16:37:02 +0000 Subject: hg: jdk7/tl/jdk: 6610174: Improve CompositeDataSupport.toString when it includes arrays Message-ID: <20080808163714.D8020DB3C@hg.openjdk.java.net> Changeset: 343d63bb2609 Author: emcmanus Date: 2008-08-08 18:36 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/343d63bb2609 6610174: Improve CompositeDataSupport.toString when it includes arrays Reviewed-by: dfuchs ! src/share/classes/javax/management/openmbean/CompositeDataSupport.java + test/javax/management/openmbean/CompositeDataStringTest.java From maurizio.cimadamore at sun.com Fri Aug 8 17:16:42 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Fri, 08 Aug 2008 17:16:42 +0000 Subject: hg: jdk7/tl/langtools: 5 new changesets Message-ID: <20080808171650.33A1BDB4A@hg.openjdk.java.net> Changeset: d635feaf3747 Author: mcimadamore Date: 2008-08-08 15:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d635feaf3747 6695838: javac does not detect cyclic inheritance involving static inner classes after import clause Summary: Javac fails to detect some errors due to the order in which a class' static imports are entered Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/staticImport/6695838/T6695838.java + test/tools/javac/staticImport/6695838/a/Foo.java + test/tools/javac/staticImport/6695838/a/FooInterface.java Changeset: 30a415f8667f Author: mcimadamore Date: 2008-08-08 17:38 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/30a415f8667f 6718364: inference fails when a generic method is invoked with raw arguments Summary: Bug in the implementation of Types.isSubtypeUnchecked Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/inference/6718364/T6718364.java + test/tools/javac/generics/inference/6718364/T6718364.out Changeset: 6542933af8f4 Author: mcimadamore Date: 2008-08-08 17:43 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6542933af8f4 6676362: Spurious forward reference error with final var + instance variable initializer Summary: Some javac forward reference errors aren't compliant with the JLS Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/ForwardReference/T6676362a.java + test/tools/javac/ForwardReference/T6676362b.java ! test/tools/javac/enum/forwardRef/T6425594.out Changeset: fac6b1beaa5a Author: mcimadamore Date: 2008-08-08 17:48 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/fac6b1beaa5a 6734819: Javac performs flows analysis on already translated classes Summary: Regression in JavaCompiler.desugar introduced in 6726015 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/6734819/T6734819a.java + test/tools/javac/6734819/T6734819a.out + test/tools/javac/6734819/T6734819b.java + test/tools/javac/6734819/T6734819b.out + test/tools/javac/6734819/T6734819c.java + test/tools/javac/6734819/T6734819c.out Changeset: 938a80a47670 Author: mcimadamore Date: 2008-08-08 17:52 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/938a80a47670 6732461: broken message file for annotation processing Summary: Regression in sqe test introduced in 6720185 Reviewed-by: jjg ! src/share/classes/com/sun/tools/apt/util/Bark.java From tim.bell at sun.com Thu Aug 14 01:16:10 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 14 Aug 2008 01:16:10 +0000 Subject: hg: jdk7/tl: Added tag jdk7-b32 for changeset 64da805be725 Message-ID: <20080814011610.4A589DEEA@hg.openjdk.java.net> Changeset: 5ceaca28a876 Author: xdono Date: 2008-08-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/5ceaca28a876 Added tag jdk7-b32 for changeset 64da805be725 ! .hgtags From tim.bell at sun.com Thu Aug 14 01:16:31 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 14 Aug 2008 01:16:31 +0000 Subject: hg: jdk7/tl/corba: 3 new changesets Message-ID: <20080814011634.75A67DEEF@hg.openjdk.java.net> Changeset: f07251088084 Author: xdono Date: 2008-08-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/f07251088084 Added tag jdk7-b32 for changeset 80a0f46a6203 ! .hgtags Changeset: 41c585204e91 Author: tbell Date: 2008-08-07 09:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/41c585204e91 Merge Changeset: e0e03ab25da0 Author: tbell Date: 2008-08-07 18:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/e0e03ab25da0 Merge From tim.bell at sun.com Thu Aug 14 01:17:23 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 14 Aug 2008 01:17:23 +0000 Subject: hg: jdk7/tl/hotspot: 4 new changesets Message-ID: <20080814011731.0BF94DEF4@hg.openjdk.java.net> Changeset: 1fdb98a17101 Author: coleenp Date: 2008-07-19 17:38 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1fdb98a17101 6716785: implicit null checks not triggering with CompressedOops Summary: allocate alignment-sized page(s) below java heap so that memory accesses at heap_base+1page give signal and cause an implicit null check Reviewed-by: kvn, jmasa, phh, jcoomes ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/linux_sparc/vm/assembler_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86_32.cpp ! src/os_cpu/linux_x86/vm/assembler_linux_x86_64.cpp ! src/os_cpu/solaris_sparc/vm/assembler_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86_32.cpp ! src/os_cpu/solaris_x86/vm/assembler_solaris_x86_64.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86_32.cpp ! src/os_cpu/windows_x86/vm/assembler_windows_x86_64.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 3df2fe7c4451 Author: trims Date: 2008-07-25 11:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3df2fe7c4451 Merge Changeset: b727c32788a9 Author: trims Date: 2008-08-01 18:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b727c32788a9 6732819: Turn off compressed oops by default for now Summary: Workaround for CompOops bug Reviewed-by: coleenp ! src/share/vm/runtime/arguments.cpp Changeset: 585535ec8a14 Author: xdono Date: 2008-08-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/585535ec8a14 Added tag jdk7-b32 for changeset b727c32788a9 ! .hgtags From tim.bell at sun.com Thu Aug 14 01:18:54 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 14 Aug 2008 01:18:54 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b32 for changeset 400a5ee432cc Message-ID: <20080814011855.78246DEF9@hg.openjdk.java.net> Changeset: 95375835527f Author: xdono Date: 2008-08-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/95375835527f Added tag jdk7-b32 for changeset 400a5ee432cc ! .hgtags From tim.bell at sun.com Thu Aug 14 01:19:17 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 14 Aug 2008 01:19:17 +0000 Subject: hg: jdk7/tl/jaxws: Added tag jdk7-b32 for changeset e6daca2eced9 Message-ID: <20080814011919.528FFDEFE@hg.openjdk.java.net> Changeset: 6dcbcfb9551a Author: xdono Date: 2008-08-04 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/6dcbcfb9551a Added tag jdk7-b32 for changeset e6daca2eced9 ! .hgtags From tim.bell at sun.com Thu Aug 14 01:20:31 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 14 Aug 2008 01:20:31 +0000 Subject: hg: jdk7/tl/jdk: 21 new changesets Message-ID: <20080814012439.11B82DF03@hg.openjdk.java.net> Changeset: 89d30b258517 Author: ohair Date: 2008-07-16 09:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/89d30b258517 6548261: Use of SE in make/common/Defs-windows.gmk Reviewed-by: darcy ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/shared/Defs.gmk Changeset: 7754f0f4cf97 Author: xdono Date: 2008-07-25 08:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7754f0f4cf97 Merge Changeset: c51121419e30 Author: ohair Date: 2008-07-27 18:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c51121419e30 6727683: Cleanup use of COMPILER_WARNINGS_FATAL in makefiles Reviewed-by: tbell ! make/com/sun/java/pack/Makefile ! make/com/sun/security/auth/module/Makefile ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/shared/Compiler-gcc.gmk ! make/common/shared/Defs-java.gmk ! make/common/shared/Platform.gmk ! make/java/fdlibm/Makefile ! make/java/hpi/windows/Makefile ! make/java/java/Makefile ! make/java/java_crw_demo/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/jli/Makefile ! make/java/net/Makefile ! make/java/nio/Makefile ! make/java/npt/Makefile ! make/java/verify/Makefile ! make/java/zip/Makefile ! make/jpda/back/Makefile ! make/jpda/transport/shmem/Makefile ! make/jpda/transport/socket/Makefile ! make/sun/cmm/kcms/Makefile ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/jdbc/Makefile ! make/sun/jpeg/Makefile Changeset: 289bc9ca7556 Author: tbell Date: 2008-08-01 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/289bc9ca7556 Merge ! make/java/nio/Makefile Changeset: 12a0d0a1bb65 Author: xdono Date: 2008-08-04 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/12a0d0a1bb65 Added tag jdk7-b32 for changeset c51121419e30 ! .hgtags Changeset: 8f1a1b2f77a3 Author: igor Date: 2008-05-28 20:06 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8f1a1b2f77a3 6587560: OpenJDK problem handling bitmaps returned when LCD text is requested Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c Changeset: 3c4fc5111ff2 Author: lana Date: 2008-06-05 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3c4fc5111ff2 Merge Changeset: f0ede391c615 Author: prr Date: 2008-06-12 13:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f0ede391c615 6378099: RFE: Use libfontconfig to create/synthesise a fontconfig.properties Reviewed-by: tdv, igor ! make/sun/headless/mapfile-vers ! make/sun/xawt/mapfile-vers ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java + src/solaris/classes/sun/font/FcFontConfiguration.java ! src/solaris/native/sun/awt/fontconfig.h ! src/solaris/native/sun/awt/fontpath.c ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java Changeset: 9fae0ea75985 Author: srl Date: 2008-06-17 18:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9fae0ea75985 6711377: test/java/awt/font/TextLayout/VisibleAdvance.java missing GPL Reviewed-by: igor, prr ! test/java/awt/font/TextLayout/VisibleAdvance.java Changeset: 5755fe417a12 Author: jgodinez Date: 2008-06-23 13:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5755fe417a12 6708509: print dialog is not displayed when default paper is custom Reviewed-by: tdv, prr ! src/windows/native/sun/windows/awt_PrintJob.cpp + test/java/awt/print/PrinterJob/PrintAWTImage.java + test/java/awt/print/PrinterJob/duke.gif Changeset: c1e0755434eb Author: igor Date: 2008-07-15 16:04 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c1e0755434eb 6720240: IOB exception when getting font metrics of hershey font Reviewed-by: bae, prr ! src/share/classes/sun/font/NullFontScaler.java Changeset: 3efc003bf097 Author: tdv Date: 2008-07-18 10:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3efc003bf097 6725214: D3D: forward-port the new pipeline from 6u10 Summary: Forward port of the new Direct3D 9 rendering pipeline from 6u10. Also includes fixes for 6690659 6689025 6658398 6596234. Reviewed-by: campbell, prr ! make/common/shared/Platform.gmk ! make/common/shared/Sanity.gmk ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/FILES_export_windows.gmk ! make/sun/awt/Makefile ! make/sun/awt/make.depend ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/font/FILES_c.gmk ! make/sun/font/Makefile ! make/sun/headless/mapfile-vers ! make/sun/jawt/make.depend ! make/sun/xawt/mapfile-vers ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/Robot.java ! src/share/classes/java/awt/image/DataBuffer.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/javax/swing/BufferStrategyPaintManager.java ! src/share/classes/sun/awt/NullComponentPeer.java ! src/share/classes/sun/awt/SubRegionShowable.java ! src/share/classes/sun/awt/image/SunVolatileImage.java ! src/share/classes/sun/awt/image/SunWritableRaster.java + src/share/classes/sun/awt/image/VSyncedBSManager.java ! src/share/classes/sun/awt/image/VolatileSurfaceManager.java ! src/share/classes/sun/font/StrikeCache.java + src/share/classes/sun/java2d/DestSurfaceProvider.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java + src/share/classes/sun/java2d/Surface.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/SurfaceDataProxy.java ! src/share/classes/sun/java2d/loops/BlitBg.java ! src/share/classes/sun/java2d/loops/GeneralRenderer.java ! src/share/classes/sun/java2d/opengl/OGLBufImgOps.java ! src/share/classes/sun/java2d/opengl/OGLContext.java ! src/share/classes/sun/java2d/opengl/OGLGraphicsConfig.java ! src/share/classes/sun/java2d/opengl/OGLPaints.java ! src/share/classes/sun/java2d/opengl/OGLRenderer.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceData.java ! src/share/classes/sun/java2d/pipe/BufferedContext.java ! src/share/classes/sun/java2d/pipe/BufferedOpCodes.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java + src/share/classes/sun/java2d/pipe/ParallelogramPipe.java + src/share/classes/sun/java2d/pipe/PixelToParallelogramConverter.java + src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventListener.java + src/share/classes/sun/java2d/pipe/hw/AccelDeviceEventNotifier.java + src/share/classes/sun/java2d/pipe/hw/AccelGraphicsConfig.java + src/share/classes/sun/java2d/pipe/hw/AccelSurface.java + src/share/classes/sun/java2d/pipe/hw/AccelTypedVolatileImage.java + src/share/classes/sun/java2d/pipe/hw/BufferedContextProvider.java + src/share/classes/sun/java2d/pipe/hw/ContextCapabilities.java + src/share/classes/sun/java2d/pipe/hw/ExtendedBufferCapabilities.java ! src/share/native/sun/font/AccelGlyphCache.c ! src/share/native/sun/font/AccelGlyphCache.h ! src/share/native/sun/font/sunFont.c + src/share/native/sun/java2d/ShaderList.c + src/share/native/sun/java2d/ShaderList.h ! src/share/native/sun/java2d/Trace.h ! src/share/native/sun/java2d/loops/BlitBg.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.h ! src/share/native/sun/java2d/opengl/OGLContext.c ! src/share/native/sun/java2d/opengl/OGLContext.h ! src/share/native/sun/java2d/opengl/OGLFuncs.h ! src/share/native/sun/java2d/opengl/OGLRenderQueue.c ! src/share/native/sun/java2d/opengl/OGLRenderQueue.h ! src/share/native/sun/java2d/opengl/OGLRenderer.c ! src/share/native/sun/java2d/opengl/OGLRenderer.h ! src/share/native/sun/java2d/opengl/OGLSurfaceData.c ! src/share/native/sun/java2d/opengl/OGLSurfaceData.h ! src/share/native/sun/java2d/pipe/BufferedMaskBlit.c ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxyPeer.java ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/classes/sun/awt/motif/MComponentPeer.java + src/solaris/classes/sun/java2d/BackBufferCapsProvider.java ! src/solaris/classes/sun/java2d/opengl/GLXGraphicsConfig.java ! src/solaris/classes/sun/java2d/opengl/GLXSurfaceData.java ! src/solaris/classes/sun/java2d/opengl/GLXVolatileSurfaceManager.java ! src/solaris/classes/sun/java2d/x11/X11PMBlitBgLoops.java ! src/solaris/native/sun/java2d/opengl/GLXGraphicsConfig.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/windows/classes/sun/awt/Win32GraphicsConfig.java ! src/windows/classes/sun/awt/Win32GraphicsDevice.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java + src/windows/classes/sun/java2d/ScreenUpdateManager.java ! src/windows/classes/sun/java2d/WindowsSurfaceManagerFactory.java - src/windows/classes/sun/java2d/d3d/D3DBackBufferSurfaceData.java ! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java + src/windows/classes/sun/java2d/d3d/D3DBufImgOps.java ! src/windows/classes/sun/java2d/d3d/D3DContext.java ! src/windows/classes/sun/java2d/d3d/D3DDrawImage.java + src/windows/classes/sun/java2d/d3d/D3DGraphicsConfig.java + src/windows/classes/sun/java2d/d3d/D3DGraphicsDevice.java + src/windows/classes/sun/java2d/d3d/D3DMaskBlit.java ! src/windows/classes/sun/java2d/d3d/D3DMaskFill.java + src/windows/classes/sun/java2d/d3d/D3DPaints.java + src/windows/classes/sun/java2d/d3d/D3DRenderQueue.java ! src/windows/classes/sun/java2d/d3d/D3DRenderer.java + src/windows/classes/sun/java2d/d3d/D3DScreenUpdateManager.java ! src/windows/classes/sun/java2d/d3d/D3DSurfaceData.java + src/windows/classes/sun/java2d/d3d/D3DSurfaceDataProxy.java ! src/windows/classes/sun/java2d/d3d/D3DTextRenderer.java + src/windows/classes/sun/java2d/d3d/D3DVolatileSurfaceManager.java ! src/windows/classes/sun/java2d/opengl/WGLGraphicsConfig.java ! src/windows/classes/sun/java2d/opengl/WGLSurfaceData.java ! src/windows/classes/sun/java2d/opengl/WGLVolatileSurfaceManager.java - src/windows/classes/sun/java2d/windows/DDBlitLoops.java - src/windows/classes/sun/java2d/windows/DDRenderer.java - src/windows/classes/sun/java2d/windows/DDScaleLoops.java ! src/windows/classes/sun/java2d/windows/GDIBlitLoops.java + src/windows/classes/sun/java2d/windows/GDIWindowSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32OffScreenSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceDataProxy.java - src/windows/classes/sun/java2d/windows/WinBackBuffer.java - src/windows/classes/sun/java2d/windows/WinBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/WinVolatileSurfaceManager.java ! src/windows/classes/sun/java2d/windows/WindowsFlags.java + src/windows/native/sun/java2d/d3d/D3DBadHardware.h ! src/windows/native/sun/java2d/d3d/D3DBlitLoops.cpp + src/windows/native/sun/java2d/d3d/D3DBlitLoops.h + src/windows/native/sun/java2d/d3d/D3DBufImgOps.cpp + src/windows/native/sun/java2d/d3d/D3DBufImgOps.h ! src/windows/native/sun/java2d/d3d/D3DContext.cpp ! src/windows/native/sun/java2d/d3d/D3DContext.h + src/windows/native/sun/java2d/d3d/D3DGlyphCache.cpp + src/windows/native/sun/java2d/d3d/D3DGlyphCache.h + src/windows/native/sun/java2d/d3d/D3DGraphicsDevice.cpp + src/windows/native/sun/java2d/d3d/D3DGraphicsDevice.h + src/windows/native/sun/java2d/d3d/D3DMaskBlit.cpp + src/windows/native/sun/java2d/d3d/D3DMaskBlit.h + src/windows/native/sun/java2d/d3d/D3DMaskCache.cpp + src/windows/native/sun/java2d/d3d/D3DMaskCache.h ! src/windows/native/sun/java2d/d3d/D3DMaskFill.cpp + src/windows/native/sun/java2d/d3d/D3DMaskFill.h + src/windows/native/sun/java2d/d3d/D3DPaints.cpp + src/windows/native/sun/java2d/d3d/D3DPaints.h + src/windows/native/sun/java2d/d3d/D3DPipeline.cpp + src/windows/native/sun/java2d/d3d/D3DPipeline.h + src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp + src/windows/native/sun/java2d/d3d/D3DPipelineManager.h + src/windows/native/sun/java2d/d3d/D3DRenderQueue.cpp + src/windows/native/sun/java2d/d3d/D3DRenderQueue.h ! src/windows/native/sun/java2d/d3d/D3DRenderer.cpp + src/windows/native/sun/java2d/d3d/D3DRenderer.h + src/windows/native/sun/java2d/d3d/D3DResourceManager.cpp + src/windows/native/sun/java2d/d3d/D3DResourceManager.h - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.cpp - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.h + src/windows/native/sun/java2d/d3d/D3DShaderGen.c + src/windows/native/sun/java2d/d3d/D3DShaders.h ! src/windows/native/sun/java2d/d3d/D3DSurfaceData.cpp ! src/windows/native/sun/java2d/d3d/D3DSurfaceData.h - src/windows/native/sun/java2d/d3d/D3DTestRaster.h ! src/windows/native/sun/java2d/d3d/D3DTextRenderer.cpp + src/windows/native/sun/java2d/d3d/D3DTextRenderer.h - src/windows/native/sun/java2d/d3d/D3DTextRenderer_md.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.h + src/windows/native/sun/java2d/d3d/D3DVertexCacher.cpp + src/windows/native/sun/java2d/d3d/D3DVertexCacher.h ! src/windows/native/sun/java2d/opengl/WGLGraphicsConfig.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.h - src/windows/native/sun/java2d/windows/DDBlitLoops.cpp - src/windows/native/sun/java2d/windows/DDRenderer.cpp ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp + src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp + src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.h - src/windows/native/sun/java2d/windows/RegistryKey.cpp - src/windows/native/sun/java2d/windows/RegistryKey.h - src/windows/native/sun/java2d/windows/Win32OffScreenSurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.h - src/windows/native/sun/java2d/windows/WinBackBufferSurfaceData.cpp ! src/windows/native/sun/java2d/windows/WindowsFlags.cpp ! src/windows/native/sun/java2d/windows/WindowsFlags.h - src/windows/native/sun/java2d/windows/ddrawObject.cpp - src/windows/native/sun/java2d/windows/ddrawObject.h - src/windows/native/sun/java2d/windows/ddrawUtils.cpp - src/windows/native/sun/java2d/windows/ddrawUtils.h - src/windows/native/sun/java2d/windows/dxCapabilities.cpp - src/windows/native/sun/java2d/windows/dxCapabilities.h - src/windows/native/sun/java2d/windows/dxInit.cpp - src/windows/native/sun/java2d/windows/dxInit.h ! src/windows/native/sun/windows/Devices.cpp ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_DrawingSurface.cpp ! src/windows/native/sun/windows/awt_DrawingSurface.h ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.h ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h ! src/windows/native/sun/windows/awtmsg.h + test/java/awt/FullScreen/BufferStrategyExceptionTest/BufferStrategyExceptionTest.java + test/java/awt/FullScreen/MultimonFullscreenTest/MultimonFullscreenTest.java + test/java/awt/FullScreen/NoResizeEventOnDMChangeTest/NoResizeEventOnDMChangeTest.java + test/java/awt/FullScreen/SetFSWindow/FSFrame.java + test/java/awt/Multiscreen/DeviceIdentificationTest/DeviceIdentificationTest.java + test/java/awt/image/MemoryLeakTest/MemoryLeakTest.java + test/sun/java2d/DirectX/AccelPaintsTest/AccelPaintsTest.java + test/sun/java2d/DirectX/AcceleratedScaleTest/AcceleratedScaleTest.java + test/sun/java2d/DirectX/IAEforEmptyFrameTest/IAEforEmptyFrameTest.java + test/sun/java2d/DirectX/InfiniteValidationLoopTest/InfiniteValidationLoopTest.java + test/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java + test/sun/java2d/DirectX/OverriddenInsetsTest/OverriddenInsetsTest.java + test/sun/java2d/DirectX/RenderingToCachedGraphicsTest/RenderingToCachedGraphicsTest.java + test/sun/java2d/DirectX/StrikeDisposalCrashTest/StrikeDisposalCrashTest.java + test/sun/java2d/DirectX/SwingOnScreenScrollingTest/SwingOnScreenScrollingTest.java + test/sun/java2d/DirectX/TransformedPaintTest/TransformedPaintTest.java + test/sun/java2d/GdiRendering/InsetClipping.java + test/sun/java2d/OpenGL/DrawBufImgOp.java + test/sun/java2d/SunGraphics2D/DrawImageBilinear.java + test/sun/java2d/SunGraphics2D/PolyVertTest.java + test/sun/java2d/SunGraphics2D/SimplePrimQuality.java + test/sun/java2d/SunGraphics2D/SourceClippingBlitTest/SourceClippingBlitTest.java + test/sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.java + test/sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedMemoryPixmapsTest.sh + test/sun/java2d/pipe/MutableColorTest/MutableColorTest.java + test/sun/java2d/pipe/hw/RSLAPITest/RSLAPITest.java + test/sun/java2d/pipe/hw/VSyncedBufferStrategyTest/VSyncedBufferStrategyTest.java Changeset: 2d7068a03750 Author: tdv Date: 2008-07-22 11:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2d7068a03750 6728492: typo in copyrights in some files touched by the d3d pipeline port Reviewed-by: prr ! make/common/shared/Platform.gmk ! make/common/shared/Sanity.gmk ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/FILES_export_unix.gmk ! make/sun/awt/FILES_export_windows.gmk ! make/sun/awt/Makefile ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/font/FILES_c.gmk ! make/sun/font/Makefile ! make/sun/headless/mapfile-vers ! make/sun/xawt/mapfile-vers ! src/share/classes/java/awt/GraphicsDevice.java ! src/share/classes/java/awt/Robot.java ! src/share/classes/java/awt/image/DataBuffer.java ! src/share/classes/java/awt/peer/ComponentPeer.java ! src/share/classes/javax/swing/BufferStrategyPaintManager.java ! src/share/classes/sun/awt/NullComponentPeer.java ! src/share/classes/sun/awt/image/SunVolatileImage.java ! src/share/classes/sun/awt/image/SunWritableRaster.java ! src/share/classes/sun/awt/image/VolatileSurfaceManager.java ! src/share/classes/sun/font/StrikeCache.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/share/classes/sun/java2d/SurfaceData.java ! src/share/classes/sun/java2d/loops/BlitBg.java ! src/share/classes/sun/java2d/loops/GeneralRenderer.java ! src/share/classes/sun/java2d/opengl/OGLContext.java ! src/share/classes/sun/java2d/opengl/OGLGraphicsConfig.java ! src/share/classes/sun/java2d/opengl/OGLRenderer.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceData.java ! src/share/classes/sun/java2d/pipe/BufferedOpCodes.java ! src/share/classes/sun/java2d/pipe/BufferedRenderPipe.java ! src/share/classes/sun/java2d/pipe/DrawImage.java ! src/share/native/sun/font/AccelGlyphCache.c ! src/share/native/sun/font/AccelGlyphCache.h ! src/share/native/sun/java2d/Trace.h ! src/share/native/sun/java2d/loops/BlitBg.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.c ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.h ! src/share/native/sun/java2d/opengl/OGLContext.c ! src/share/native/sun/java2d/opengl/OGLContext.h ! src/share/native/sun/java2d/opengl/OGLFuncs.h ! src/share/native/sun/java2d/opengl/OGLRenderQueue.c ! src/share/native/sun/java2d/opengl/OGLRenderQueue.h ! src/share/native/sun/java2d/opengl/OGLRenderer.c ! src/share/native/sun/java2d/opengl/OGLRenderer.h ! src/share/native/sun/java2d/opengl/OGLSurfaceData.c ! src/share/native/sun/java2d/opengl/OGLSurfaceData.h ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/classes/sun/awt/motif/MComponentPeer.java ! src/solaris/classes/sun/java2d/opengl/GLXGraphicsConfig.java ! src/solaris/classes/sun/java2d/opengl/GLXSurfaceData.java ! src/solaris/classes/sun/java2d/opengl/GLXVolatileSurfaceManager.java ! src/solaris/classes/sun/java2d/x11/X11PMBlitBgLoops.java ! src/solaris/native/sun/java2d/opengl/GLXGraphicsConfig.c ! src/solaris/native/sun/java2d/opengl/GLXSurfaceData.c ! src/windows/classes/sun/awt/Win32GraphicsConfig.java ! src/windows/classes/sun/awt/Win32GraphicsDevice.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/java2d/opengl/WGLGraphicsConfig.java ! src/windows/classes/sun/java2d/opengl/WGLSurfaceData.java ! src/windows/classes/sun/java2d/opengl/WGLVolatileSurfaceManager.java ! src/windows/classes/sun/java2d/windows/GDIBlitLoops.java ! src/windows/classes/sun/java2d/windows/GDIWindowSurfaceData.java ! src/windows/classes/sun/java2d/windows/WindowsFlags.java ! src/windows/native/sun/java2d/opengl/WGLGraphicsConfig.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.c ! src/windows/native/sun/java2d/opengl/WGLSurfaceData.h ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp ! src/windows/native/sun/java2d/windows/GDIRenderer.cpp ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.cpp ! src/windows/native/sun/java2d/windows/GDIWindowSurfaceData.h ! src/windows/native/sun/java2d/windows/WindowsFlags.cpp ! src/windows/native/sun/java2d/windows/WindowsFlags.h ! src/windows/native/sun/windows/Devices.cpp ! src/windows/native/sun/windows/awt_Component.h ! src/windows/native/sun/windows/awt_DrawingSurface.cpp ! src/windows/native/sun/windows/awt_DrawingSurface.h ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.cpp ! src/windows/native/sun/windows/awt_Win32GraphicsDevice.h ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp ! src/windows/native/sun/windows/awtmsg.h Changeset: 5a9e7ac25d30 Author: lana Date: 2008-07-24 21:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5a9e7ac25d30 Merge ! make/common/shared/Platform.gmk ! make/common/shared/Sanity.gmk ! make/sun/font/FILES_c.gmk ! make/sun/font/Makefile ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/image/DataBuffer.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/image/SunVolatileImage.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/solaris/classes/sun/awt/X11GraphicsConfig.java ! src/solaris/classes/sun/awt/X11GraphicsDevice.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java ! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java - src/windows/classes/sun/java2d/d3d/D3DBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/DDBlitLoops.java - src/windows/classes/sun/java2d/windows/DDRenderer.java - src/windows/classes/sun/java2d/windows/DDScaleLoops.java - src/windows/classes/sun/java2d/windows/Win32OffScreenSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceDataProxy.java - src/windows/classes/sun/java2d/windows/WinBackBuffer.java - src/windows/classes/sun/java2d/windows/WinBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/WinVolatileSurfaceManager.java - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.cpp - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.h - src/windows/native/sun/java2d/d3d/D3DTestRaster.h - src/windows/native/sun/java2d/d3d/D3DTextRenderer_md.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.h - src/windows/native/sun/java2d/windows/DDBlitLoops.cpp - src/windows/native/sun/java2d/windows/DDRenderer.cpp - src/windows/native/sun/java2d/windows/RegistryKey.cpp - src/windows/native/sun/java2d/windows/RegistryKey.h - src/windows/native/sun/java2d/windows/Win32OffScreenSurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.h - src/windows/native/sun/java2d/windows/WinBackBufferSurfaceData.cpp - src/windows/native/sun/java2d/windows/ddrawObject.cpp - src/windows/native/sun/java2d/windows/ddrawObject.h - src/windows/native/sun/java2d/windows/ddrawUtils.cpp - src/windows/native/sun/java2d/windows/ddrawUtils.h - src/windows/native/sun/java2d/windows/dxCapabilities.cpp - src/windows/native/sun/java2d/windows/dxCapabilities.h - src/windows/native/sun/java2d/windows/dxInit.cpp - src/windows/native/sun/java2d/windows/dxInit.h ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h Changeset: 2776a8638537 Author: lana Date: 2008-08-05 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2776a8638537 Merge ! make/common/shared/Platform.gmk ! make/sun/font/Makefile Changeset: ab3508401ce4 Author: jtusla Date: 2008-08-01 01:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ab3508401ce4 6509039: Swedish localization has incorrect am/pm markers in FormatData_sv Summary: Added respective section Reviewed-by: peytoia, jenda ! src/share/classes/sun/text/resources/FormatData_sv.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java Changeset: 52f21df467b4 Author: jtusla Date: 2008-08-01 02:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/52f21df467b4 6608572: Currency change for Malta and Cyprus Summary: Change the respective currencies Reviewed-by: naoto, jenda ! src/share/classes/java/util/CurrencyData.properties ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Currency/tablea1.txt Changeset: 1d3a19f9a015 Author: jtusla Date: 2008-08-07 04:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d3a19f9a015 Merge Changeset: 7e10774d2a29 Author: tbell Date: 2008-08-07 09:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7e10774d2a29 Merge - src/windows/classes/sun/java2d/d3d/D3DBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/DDBlitLoops.java - src/windows/classes/sun/java2d/windows/DDRenderer.java - src/windows/classes/sun/java2d/windows/DDScaleLoops.java - src/windows/classes/sun/java2d/windows/Win32OffScreenSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceDataProxy.java - src/windows/classes/sun/java2d/windows/WinBackBuffer.java - src/windows/classes/sun/java2d/windows/WinBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/WinVolatileSurfaceManager.java - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.cpp - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.h - src/windows/native/sun/java2d/d3d/D3DTestRaster.h - src/windows/native/sun/java2d/d3d/D3DTextRenderer_md.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.h - src/windows/native/sun/java2d/windows/DDBlitLoops.cpp - src/windows/native/sun/java2d/windows/DDRenderer.cpp - src/windows/native/sun/java2d/windows/RegistryKey.cpp - src/windows/native/sun/java2d/windows/RegistryKey.h - src/windows/native/sun/java2d/windows/Win32OffScreenSurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.h - src/windows/native/sun/java2d/windows/WinBackBufferSurfaceData.cpp - src/windows/native/sun/java2d/windows/ddrawObject.cpp - src/windows/native/sun/java2d/windows/ddrawObject.h - src/windows/native/sun/java2d/windows/ddrawUtils.cpp - src/windows/native/sun/java2d/windows/ddrawUtils.h - src/windows/native/sun/java2d/windows/dxCapabilities.cpp - src/windows/native/sun/java2d/windows/dxCapabilities.h - src/windows/native/sun/java2d/windows/dxInit.cpp - src/windows/native/sun/java2d/windows/dxInit.h Changeset: 515175a26f49 Author: tbell Date: 2008-08-07 18:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/515175a26f49 Merge Changeset: c32e27a3c619 Author: tbell Date: 2008-08-10 18:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c32e27a3c619 Merge From tim.bell at sun.com Thu Aug 14 01:29:14 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 14 Aug 2008 01:29:14 +0000 Subject: hg: jdk7/tl/langtools: 4 new changesets Message-ID: <20080814012920.D25D0DF08@hg.openjdk.java.net> Changeset: 4af43632966c Author: xdono Date: 2008-08-04 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4af43632966c Added tag jdk7-b32 for changeset 13aee98cc0d8 ! .hgtags Changeset: 0a5f04fb7282 Author: tbell Date: 2008-08-07 09:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0a5f04fb7282 Merge Changeset: 7ec8d871eb8c Author: tbell Date: 2008-08-07 18:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7ec8d871eb8c Merge - test/tools/javac/5045412/out Changeset: eefde0421566 Author: tbell Date: 2008-08-10 18:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/eefde0421566 Merge From Alex.Buckley at Sun.COM Mon Aug 4 18:50:22 2008 From: Alex.Buckley at Sun.COM (Alex Buckley) Date: Mon, 04 Aug 2008 12:50:22 -0600 Subject: covariant returns for CharBuffer.subSequence In-Reply-To: <4895FBC0.30000@univ-mlv.fr> References: <20080803042851.78D042BF53@callebaut.niobe.net> <4895FBC0.30000@univ-mlv.fr> Message-ID: <48974F6E.9040303@sun.com> Hi Remi, R?mi Forax wrote: > Because in my opinion, there is a bug in the JLS3 regarding covariant > return type. No, there isn't. > Let us take an example, a library defines Buffer and SubBuffer > public class Buffer { > Buffer duplicate() { ... } > } > public class SubBuffer extends Buffer { > } > > And i've a code that use that library > public class MySubBuffer extends SubBuffer { > Buffer duplicate() { ... } > } > > If the developer of the library want to use covariant return type > introducing a method: > SubBuffer duplicate() > in SubBuffer, it will break my code. Naturally, because your code is now type-unsafe. > The weird thing is that if you generify Buffer and SubBuffer, > you can have a covariant return type in a backward compatible way : > class Buffer> { > T duplicate() { ... } > } > class SubBuffer> extends Buffer { > } > > Why ? > Because the JLS allows to override a generic method with > a method with the erased generic signature in order to allow to > generify a library even if code that use it is not generified > (see JLS section 8.4.2). To be precise, duplicate() is not a generic method, since it does not introduce its own type parameters. It is just a method which happens to use a type parameter from the class. But yes, override-equivalence allows such a method to be overridden by a method with an erased signature. However, that doesn't help MySubBuffer, since its duplicate() does not have return-type-substitutability with duplicate() in SubBuffer. If you declare 'T duplicate() {..}' in SubBuffer, you'll get an error when compiling MySubBuffer. I believe javac should actually give an error on MySubBuffer even without a duplicate() declaration in SubBuffer, since duplicate() is there by inheritance. In any case, if you go ahead and point a SubBuffer> variable at a raw MySubBuffer, there is no possibility of NoSuchMethodError. This is because javac is smart enough to call the duplicate() in SubBuffer, not MySubBuffer. But you'll get an unchecked warning, because the raw assignment could lead to ClassCastExceptions in general. > The problem is that there is no such rule for covariant return type, > so refactoring to use covariant return type in a library is impossible. If there was such a rule, it would be type-unsafe. Alex From Yulia.Novozhilova at Sun.COM Tue Aug 5 17:12:12 2008 From: Yulia.Novozhilova at Sun.COM (Yulia Novozhilova) Date: Tue, 05 Aug 2008 21:12:12 +0400 Subject: Is third party code included in langtools sources? Message-ID: <489889EC.3020003@sun.com> Hi, Could you please, help me to answer a question: Is third party code included in langtools sources? If "no" then _why_ the THIRD_PARTY_README and ASSEMBLY_EXCEPTION files are included into the repository? Actually I'm working on the Debian/Ubuntu native packaging for NetBeans IDE. NetBeans uses javac that is a fork of the langtools repository: http://hg.openjdk.java.net/jdk7/tl/langtools/ So I have to create a debian package for it. The problem is that Debian policy is strict about license: I must point the license for each file in the upstream source (files from langtools repository). Currently I can't explain why THIRD_PARTY_README and ASSEMBLY_EXCEPTION are in the upstream. Are there any files that need them? Thanks in advance, -Yulia -------------- next part -------------- An embedded message was scrubbed... From: Jan Lahoda Subject: Re: [nb-linux] The NetBeans Javaparser sources for NetBeans 6.1 Date: Tue, 05 Aug 2008 17:51:48 +0200 Size: 7827 URL: From gnu_andrew at member.fsf.org Fri Aug 15 18:15:19 2008 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 15 Aug 2008 19:15:19 +0100 Subject: Is third party code included in langtools sources? In-Reply-To: <489889EC.3020003@sun.com> References: <489889EC.3020003@sun.com> Message-ID: <17c6771e0808151115p47cfd40ak8e6bc1e483de3d25@mail.gmail.com> On 05/08/2008, Yulia Novozhilova wrote: > Hi, > > Could you please, help me to answer a question: > Is third party code included in langtools sources? > If "no" then _why_ the THIRD_PARTY_README and ASSEMBLY_EXCEPTION files are > included into the repository? > > Actually I'm working on the Debian/Ubuntu native packaging for NetBeans > IDE. > NetBeans uses javac that is a fork of the langtools repository: > http://hg.openjdk.java.net/jdk7/tl/langtools/ > > So I have to create a debian package for it. The problem is that Debian > policy is strict about license: > I must point the license for each file in the upstream source (files from > langtools repository). Currently I can't explain why > THIRD_PARTY_README and ASSEMBLY_EXCEPTION are in the upstream. Are there > any files that need them? > > Thanks in advance, > -Yulia > > Hi, > the NetBeans javac is a fork of the javac from the OpenJDK. More > precisely, we use a fork of the langtools repository: > http://hg.openjdk.java.net/jdk7/tl/langtools/ > > The THIRD_PARTY_README and ASSEMBLY_EXCEPTION files originate in this > repository. I am not sure if we can simply delete them. Better solution, in > my opinion, would be to ask the maintainers of OpenJDK/langtools repository > whether these files could be removed from the original langtools repository > (I do not think these are needed for langtools, but IANAL). We could adopt > the change in our fork easily. > > Jan > > Yulia Novozhilova wrote: > > > Hi, > > > > As nobody responds I think it is better to use the same license and > copyright files for packaging as we've used for javaparser-6.0: > > > http://java.netbeans.org/files/documents/25/1798/nb-javaparser-6.0-src.zip > > > > nb-javaparser-6.0-src.zip doesn't contain THIRD_PARTY_README and > ASSEMBLY_EXCEPTION, so > > > > Honza, could you please, ___remove___ these files from the > > > > > http://java.netbeans.org/files/documents/25/2033/nb-javaparser-6.1-src.zip > ? > > > > Thanks in advance, > > Yulia > > > > > > Yulia Novozhilova wrote: > > > > > Hi all, > > > > > > Could someone explain me how to determine what license .java file (for > example) is under? > > > I definitely don't understand why we need THIRD_PARTY_README and > ASSEMBLY_EXCEPTION for javaparser upstream. > > > Does third party code is included there? How can I check that? > > > I've looked through the source code in > http://java.netbeans.org/files/documents/25/2033/nb-javaparser-6.1-src.zip > > > and couldn't find any copyright mentioned in THIRD_PARTY_README. > > > > > > Furthermore for NetBeans we remove all license files from the upstream, > including THIRDPARTYLICENSEREADME.txt and leave > > > one LICENSE file with GNU and CDDL licenses. > > > > > > Thanks in advance, > > > Yulia > > > > > > Dalibor Topic wrote: > > > > > > > Marek Slama wrote: > > > > > > > > > Question: What is THIRD_PARTY_README good for? > > > > > > > > > > > > > In OpenJDK, we use that file to track licenses of third party code > included in the source code, > > > > so that downstream knows what the ingredients are. See > http://hg.openjdk.java.net/jdk7/jdk7/file/3300a35a0bd5/THIRD_PARTY_README > for an example. > > > > > > > > > It is necessary to include this? > > > > > > > > > It makes the life of the packager easier, in general, since Debian, > for example, wants to know what > > > > licenses all the code in a project is under, including third party > code that's included in the sources. > > > > > > > > cheers, > > > > dalibor topic > > > > > > > > > > > > > > > > > > > > > > > > > The more obvious question for me is why NetBeans needs a fork of this in the first place. The Debian OpenJDK team have already gone through the extensive task of verifying this code legally to package OpenJDK 6, which is now in unstable and testing: http://release.debian.org/migration/testing.pl?package=openjdk-6 Having another copy in another package seems ludicrous and a duplication of existing work. -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From jim.holmlund at sun.com Sat Aug 16 01:07:18 2008 From: jim.holmlund at sun.com (jim.holmlund at sun.com) Date: Sat, 16 Aug 2008 01:07:18 +0000 Subject: hg: jdk7/tl/jdk: 6737900: TEST: Some JDI regression tests timeout on slow machines Message-ID: <20080816010729.C0F8DD139@hg.openjdk.java.net> Changeset: cf403a69449a Author: jjh Date: 2008-08-15 18:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cf403a69449a 6737900: TEST: Some JDI regression tests timeout on slow machines Summary: Don't execute useless code, and split test into multiple @runs. Reviewed-by: tbell ! test/com/sun/jdi/ClassesByName2Test.java ! test/com/sun/jdi/ConnectedVMs.java ! test/com/sun/jdi/sde/MangleStepTest.java From kelly.ohair at sun.com Mon Aug 18 01:09:16 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Mon, 18 Aug 2008 01:09:16 +0000 Subject: hg: jdk7/tl/jdk: 6496269: Many warnings generated from com/sun/java/util/jar/pack/*.cpp when compiled on Linux Message-ID: <20080818010928.41FD1D18C@hg.openjdk.java.net> Changeset: e093efae8c5f Author: ohair Date: 2008-08-17 17:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e093efae8c5f 6496269: Many warnings generated from com/sun/java/util/jar/pack/*.cpp when compiled on Linux Summary: Removal of compiler warnings and fixing of assert logic. Reviewed-by: jrose, ksrini, bristor ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bytes.cpp ! src/share/native/com/sun/java/util/jar/pack/bytes.h ! src/share/native/com/sun/java/util/jar/pack/coding.cpp ! src/share/native/com/sun/java/util/jar/pack/coding.h ! src/share/native/com/sun/java/util/jar/pack/defines.h ! src/share/native/com/sun/java/util/jar/pack/jni.cpp ! src/share/native/com/sun/java/util/jar/pack/main.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.h ! src/share/native/com/sun/java/util/jar/pack/utils.cpp ! src/share/native/com/sun/java/util/jar/pack/utils.h ! src/share/native/com/sun/java/util/jar/pack/zip.cpp ! src/share/native/com/sun/java/util/jar/pack/zip.h From gnu_andrew at member.fsf.org Mon Aug 18 13:27:08 2008 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Mon, 18 Aug 2008 14:27:08 +0100 Subject: Is third party code included in langtools sources? In-Reply-To: <48A9645F.7070802@sun.com> References: <489889EC.3020003@sun.com> <17c6771e0808151115p47cfd40ak8e6bc1e483de3d25@mail.gmail.com> <48A9645F.7070802@sun.com> Message-ID: <17c6771e0808180627o13f332a9mf098e84df1d769d9@mail.gmail.com> On 18/08/2008, Yulia Novozhilova wrote: > Hi, > > Andrew John Hughes wrote: > > > The more obvious question for me is why NetBeans needs a fork of this > > in the first place. The Debian OpenJDK team have already gone through > > the extensive task of verifying this code legally to package OpenJDK > > 6, which is now in unstable and testing: > > > > > http://release.debian.org/migration/testing.pl?package=openjdk-6 > > > > Having another copy in another package seems ludicrous and a > > duplication of existing work. > > > > > There are users who want to use NetBeans but don't want to install openjdk. > (you can find an example here: > https://bugs.launchpad.net/ubuntu/+source/netbeans/+bug/258844) > They already have sun-java6-jdk installed and expect NetBeans to work on > it. > That is why NetBeans needs a fork of the code included into openjdk. > > Thanks, > Yulia > > > > > It doesn't explain why a fork is needed. It just says that NetBeans has to be able to work against either the langtools from OpenJDK or the proprietary Sun JDK. As I read it, a fork solution is suggesting a third alternative, namely to include another different copy of the langtools for NetBeans. In short, what is the reason NetBeans can't just work against the tools.zip in either JDK? -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Yulia.Novozhilova at Sun.COM Mon Aug 18 12:00:31 2008 From: Yulia.Novozhilova at Sun.COM (Yulia Novozhilova) Date: Mon, 18 Aug 2008 16:00:31 +0400 Subject: Is third party code included in langtools sources? In-Reply-To: <17c6771e0808151115p47cfd40ak8e6bc1e483de3d25@mail.gmail.com> References: <489889EC.3020003@sun.com> <17c6771e0808151115p47cfd40ak8e6bc1e483de3d25@mail.gmail.com> Message-ID: <48A9645F.7070802@sun.com> Hi, Andrew John Hughes wrote: > The more obvious question for me is why NetBeans needs a fork of this > in the first place. The Debian OpenJDK team have already gone through > the extensive task of verifying this code legally to package OpenJDK > 6, which is now in unstable and testing: > > http://release.debian.org/migration/testing.pl?package=openjdk-6 > > Having another copy in another package seems ludicrous and a > duplication of existing work. > There are users who want to use NetBeans but don't want to install openjdk. (you can find an example here: https://bugs.launchpad.net/ubuntu/+source/netbeans/+bug/258844) They already have sun-java6-jdk installed and expect NetBeans to work on it. That is why NetBeans needs a fork of the code included into openjdk. Thanks, Yulia From swamy.venkataramanappa at sun.com Mon Aug 18 22:33:17 2008 From: swamy.venkataramanappa at sun.com (swamy.venkataramanappa at sun.com) Date: Mon, 18 Aug 2008 22:33:17 +0000 Subject: hg: jdk7/tl/jdk: 6705893: javax.script tests should not require a js engine on OpenJDK Message-ID: <20080818223329.B71BED2D2@hg.openjdk.java.net> Changeset: 17527939e5b1 Author: swamyv Date: 2008-08-18 15:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/17527939e5b1 6705893: javax.script tests should not require a js engine on OpenJDK Summary: Fixed the tests to pass with open JDK. Reviewed-by: darcy ! test/javax/script/E4XErrorTest.java + test/javax/script/Helper.java ! test/javax/script/JavaScriptScopeTest.java ! test/javax/script/NullUndefinedVarTest.java ! test/javax/script/PluggableContextTest.java ! test/javax/script/ProviderTest.java ! test/javax/script/RhinoExceptionTest.java ! test/javax/script/Test1.java ! test/javax/script/Test2.java ! test/javax/script/Test3.java ! test/javax/script/Test4.java ! test/javax/script/Test5.java ! test/javax/script/Test6.java ! test/javax/script/Test7.java ! test/javax/script/Test8.java ! test/javax/script/VersionTest.java + test/sun/tools/jrunscript/CheckEngine.java ! test/sun/tools/jrunscript/common.sh ! test/sun/tools/jrunscript/jrunscript-DTest.sh ! test/sun/tools/jrunscript/jrunscript-argsTest.sh ! test/sun/tools/jrunscript/jrunscript-cpTest.sh ! test/sun/tools/jrunscript/jrunscript-eTest.sh ! test/sun/tools/jrunscript/jrunscript-fTest.sh ! test/sun/tools/jrunscript/jrunscriptTest.sh From swamy.venkataramanappa at sun.com Tue Aug 19 19:47:57 2008 From: swamy.venkataramanappa at sun.com (swamy.venkataramanappa at sun.com) Date: Tue, 19 Aug 2008 19:47:57 +0000 Subject: hg: jdk7/tl/jdk: 6736461: ThreadMXBean Locks.java fails intermittently. Message-ID: <20080819194808.C2DDAD3A1@hg.openjdk.java.net> Changeset: b6f746b0ecc4 Author: swamyv Date: 2008-08-19 12:46 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b6f746b0ecc4 6736461: ThreadMXBean Locks.java fails intermittently. Summary: Fixed the test to wait for the right state before calling check thread information. Reviewed-by: jjh ! test/java/lang/management/ThreadMXBean/Locks.java From tim.bell at sun.com Tue Aug 19 21:27:51 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 19 Aug 2008 21:27:51 +0000 Subject: hg: jdk7/tl: 5 new changesets Message-ID: <20080819212751.D162FD3B6@hg.openjdk.java.net> Changeset: 55b2666e52e1 Author: ohair Date: 2008-08-06 14:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/55b2666e52e1 6728161: Add SKIP_BOOT_CYCLE feature to create boot jdk and use it during build Reviewed-by: tbell ! Makefile ! make/Defs-internal.gmk ! make/jprt.config ! make/jprt.gmk Changeset: 844619bd3580 Author: ohair Date: 2008-08-06 16:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/844619bd3580 6724669: JDK7: Official change to Sun Studio 12 compilers on Solaris Reviewed-by: tbell ! README-builds.html ! make/jprt.config Changeset: 746ca6b12c56 Author: ohair Date: 2008-08-06 16:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/746ca6b12c56 Merge ! README-builds.html ! make/jprt.config Changeset: bb1ef4ee3d2c Author: xdono Date: 2008-08-12 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/bb1ef4ee3d2c Merge Changeset: 7aa4f433229a Author: xdono Date: 2008-08-14 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/7aa4f433229a Added tag jdk7-b33 for changeset bb1ef4ee3d2c ! .hgtags From tim.bell at sun.com Tue Aug 19 21:28:17 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 19 Aug 2008 21:28:17 +0000 Subject: hg: jdk7/tl/corba: 4 new changesets Message-ID: <20080819212820.F0314D3BB@hg.openjdk.java.net> Changeset: 33486187d718 Author: ohair Date: 2008-08-06 16:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/33486187d718 6724669: JDK7: Official change to Sun Studio 12 compilers on Solaris Reviewed-by: tbell ! make/common/shared/Compiler-sun.gmk ! make/jprt.config Changeset: 6a5b9d2f8b20 Author: xdono Date: 2008-08-12 15:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/6a5b9d2f8b20 Merge Changeset: 05bf6aacc874 Author: xdono Date: 2008-08-14 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/05bf6aacc874 Added tag jdk7-b33 for changeset 6a5b9d2f8b20 ! .hgtags Changeset: 0a812b9824e5 Author: tbell Date: 2008-08-14 22:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/0a812b9824e5 Merge From tim.bell at sun.com Tue Aug 19 21:29:15 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 19 Aug 2008 21:29:15 +0000 Subject: hg: jdk7/tl/hotspot: Added tag jdk7-b33 for changeset 585535ec8a14 Message-ID: <20080819212916.E4D4AD3C2@hg.openjdk.java.net> Changeset: 5b3b8a69f10f Author: xdono Date: 2008-08-14 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5b3b8a69f10f Added tag jdk7-b33 for changeset 585535ec8a14 ! .hgtags From tim.bell at sun.com Tue Aug 19 21:31:15 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 19 Aug 2008 21:31:15 +0000 Subject: hg: jdk7/tl/jaxp: Added tag jdk7-b33 for changeset 95375835527f Message-ID: <20080819213117.5E3CED3CD@hg.openjdk.java.net> Changeset: 01facdf8cabd Author: xdono Date: 2008-08-14 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/01facdf8cabd Added tag jdk7-b33 for changeset 95375835527f ! .hgtags From tim.bell at sun.com Tue Aug 19 21:31:44 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 19 Aug 2008 21:31:44 +0000 Subject: hg: jdk7/tl/jaxws: Added tag jdk7-b33 for changeset 6dcbcfb9551a Message-ID: <20080819213145.7BDB2D3D2@hg.openjdk.java.net> Changeset: 7a9f629cd957 Author: xdono Date: 2008-08-14 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/7a9f629cd957 Added tag jdk7-b33 for changeset 6dcbcfb9551a ! .hgtags From tim.bell at sun.com Tue Aug 19 21:34:19 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 19 Aug 2008 21:34:19 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20080819213422.7DBB8D3DB@hg.openjdk.java.net> Changeset: 1c4a97a661b9 Author: xdono Date: 2008-08-14 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1c4a97a661b9 Added tag jdk7-b33 for changeset 0a5f04fb7282 ! .hgtags Changeset: 4026dece07e8 Author: tbell Date: 2008-08-14 22:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4026dece07e8 Merge From tim.bell at sun.com Tue Aug 19 23:12:23 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 19 Aug 2008 23:12:23 +0000 Subject: hg: jdk7/tl/jdk: 11 new changesets Message-ID: <20080819231432.EE5C9D491@hg.openjdk.java.net> Changeset: e35680499077 Author: ohair Date: 2008-08-06 15:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e35680499077 6728161: Add SKIP_BOOT_CYCLE feature to create boot jdk and use it during build Summary: Needed BOOT_JAR_JFLAGS. Fixed PREVIOUS_RELEASE_IMAGE. Reviewed-by: tbell ! make/com/sun/crypto/provider/Makefile ! make/com/sun/inputmethods/indicim/Makefile ! make/com/sun/inputmethods/thaiim/Makefile ! make/common/BuildToolJar.gmk ! make/common/Demo.gmk ! make/common/Release.gmk ! make/common/internal/BinaryPlugs.gmk ! make/common/internal/ImportComponents.gmk ! make/common/shared/Defs-java.gmk ! make/java/management/Makefile ! make/javax/crypto/Makefile ! make/javax/swing/beaninfo/SwingBeans.gmk ! make/sun/jconsole/Makefile ! make/sun/net/spi/nameservice/dns/Makefile ! make/sun/nio/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/text/Makefile Changeset: b374f6174534 Author: ohair Date: 2008-07-30 19:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b374f6174534 6729772: 64-bit build with SS12 compiler: SIGSEGV (0xb) at pc=0x0000000000000048, pid=14826, tid=2 Reviewed-by: tbell ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/Library.gmk ! make/common/shared/Defs.gmk ! make/java/fdlibm/Makefile ! make/java/java_hprof_demo/Makefile ! make/sun/awt/Makefile ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/image/generic/Makefile ! make/sun/image/vis/Makefile ! make/sun/jpeg/Makefile Changeset: a140a5aa5f2c Author: ohair Date: 2008-08-06 16:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a140a5aa5f2c 6724669: JDK7: Official change to Sun Studio 12 compilers on Solaris Reviewed-by: tbell - make/README-builds.html - make/README.html ! make/common/shared/Compiler-sun.gmk ! make/jprt.config Changeset: a418b563ed63 Author: ohair Date: 2008-08-06 16:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a418b563ed63 Merge - make/README-builds.html - make/README.html ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk ! make/common/shared/Defs.gmk ! make/java/fdlibm/Makefile ! make/java/java_hprof_demo/Makefile ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/jpeg/Makefile Changeset: a5e641698d38 Author: ohair Date: 2008-08-08 08:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5e641698d38 6734977: Fix build failure regarding the now deleted file jdk/README.html Reviewed-by: xdono, tbell - make/ASSEMBLY_EXCEPTION - make/LICENSE - make/README - make/THIRD_PARTY_README ! make/common/Release.gmk Changeset: 32a4e56d5f68 Author: ohair Date: 2008-08-08 08:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/32a4e56d5f68 Merge - make/ASSEMBLY_EXCEPTION - make/LICENSE - make/README - make/THIRD_PARTY_README ! make/common/Release.gmk Changeset: fa4c0a6cdd25 Author: xdono Date: 2008-08-12 15:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa4c0a6cdd25 Merge - make/java/nio/spp.sh ! make/sun/awt/Makefile ! make/sun/font/Makefile - src/windows/classes/sun/java2d/d3d/D3DBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/DDBlitLoops.java - src/windows/classes/sun/java2d/windows/DDRenderer.java - src/windows/classes/sun/java2d/windows/DDScaleLoops.java - src/windows/classes/sun/java2d/windows/Win32OffScreenSurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceData.java - src/windows/classes/sun/java2d/windows/Win32SurfaceDataProxy.java - src/windows/classes/sun/java2d/windows/WinBackBuffer.java - src/windows/classes/sun/java2d/windows/WinBackBufferSurfaceData.java - src/windows/classes/sun/java2d/windows/WinVolatileSurfaceManager.java - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.cpp - src/windows/native/sun/java2d/d3d/D3DRuntimeTest.h - src/windows/native/sun/java2d/d3d/D3DTestRaster.h - src/windows/native/sun/java2d/d3d/D3DTextRenderer_md.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.cpp - src/windows/native/sun/java2d/d3d/D3DUtils.h - src/windows/native/sun/java2d/windows/DDBlitLoops.cpp - src/windows/native/sun/java2d/windows/DDRenderer.cpp - src/windows/native/sun/java2d/windows/RegistryKey.cpp - src/windows/native/sun/java2d/windows/RegistryKey.h - src/windows/native/sun/java2d/windows/Win32OffScreenSurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.cpp - src/windows/native/sun/java2d/windows/Win32SurfaceData.h - src/windows/native/sun/java2d/windows/WinBackBufferSurfaceData.cpp - src/windows/native/sun/java2d/windows/ddrawObject.cpp - src/windows/native/sun/java2d/windows/ddrawObject.h - src/windows/native/sun/java2d/windows/ddrawUtils.cpp - src/windows/native/sun/java2d/windows/ddrawUtils.h - src/windows/native/sun/java2d/windows/dxCapabilities.cpp - src/windows/native/sun/java2d/windows/dxCapabilities.h - src/windows/native/sun/java2d/windows/dxInit.cpp - src/windows/native/sun/java2d/windows/dxInit.h Changeset: 4c24def75deb Author: xdono Date: 2008-08-14 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4c24def75deb Added tag jdk7-b33 for changeset fa4c0a6cdd25 ! .hgtags Changeset: e7d93d1d2bf0 Author: tbell Date: 2008-08-14 22:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7d93d1d2bf0 Merge - make/ASSEMBLY_EXCEPTION - make/LICENSE - make/README - make/README-builds.html - make/README.html - make/THIRD_PARTY_README Changeset: 092985e71d9e Author: tbell Date: 2008-08-18 09:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/092985e71d9e Merge Changeset: 1b114828900b Author: tbell Date: 2008-08-19 16:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1b114828900b Merge From gnu_andrew at member.fsf.org Wed Aug 20 18:36:25 2008 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 20 Aug 2008 19:36:25 +0100 Subject: Is third party code included in langtools sources? In-Reply-To: <48AC4D19.7070204@sun.com> References: <489889EC.3020003@sun.com> <17c6771e0808151115p47cfd40ak8e6bc1e483de3d25@mail.gmail.com> <48A9645F.7070802@sun.com> <17c6771e0808180627o13f332a9mf098e84df1d769d9@mail.gmail.com> <48AC4D19.7070204@sun.com> Message-ID: <17c6771e0808201136n1b3ca436s9bd62a17edc1ddd9@mail.gmail.com> On 20/08/2008, Yulia Novozhilova wrote: > Hi, > sorry for not responding earlier. > Here is more qualified answer on your question: > > Jan Lahoda wrote: > > > Hi, > > the javac in the langtools repository is currently more a command line > tool than a Java parser suitable for an IDE. The NetBeans' fork contains a > lot of changes that make the parser more IDE friendly. An example for all: > the javac works in "phases" - it first parses the source, then attributes > classes/methods/fields declarations, then attributes the "bodies" of > methods, etc. The vanilla javac will not continue to another phase if there > was an compilation error in the previous phase. This behavior is > unacceptable for IDE, so we have patched the parser to execute "all" phases > even in presence of errors. > > > > The long-term intent is to merge (ideally all) NetBeans patches into the > vanilla javac, but the progress is quite slow. > > > > I think there are also "latency" problems - even if all the NetBeans > patches would be adopted into the JDK7 langtools today, it would still take > a long time before it would get into the packages (I think at least - if you > are producing package only for "releases", than the changes would be visible > either after OpenJDK7 would be released or after OpenJDK6 would adopt these > changes, which both would take some time). Something similar would be true > for any further change we would do. > > > > Hope this answers your question, > > Jan > > That does; it establishes that there is a third copy of langtools used for NetBeans that wasn't clear from your initial e-mail. > Anyway, my goal is to create a package for javaparser that is needed for > NetBeans. And I have an aggressive timetable. > So, could you please, provide me with information about third party code. > Is it difficult? I believe langtools repository doesn't contain any third > party code and THIRD_PARTY_README and ASSEMBLY_EXCEPTION > can be removed. > You should check with Sun legal -- IANAL. From the files in the OpenJDK7 tree, it would seem that all the Java files are under the GPL and copyrighted to Sun with the exception of one ( src/share/sample/javac/processing/src/CheckNamesProcessor.java) which appears to be BSD licensed. Most tests don't seem to include copyright information. There doesn't appear to be any third-party code mentioned by the THIRD_PARTY_README, which appears to largely be stuff from the JDK. I think you need to keep the ASSEMBLY_EXCEPTION as it allows pure GPL code to be linked with GPL+Classpath exception code, and most of the code uses the Classpath exception. 'it allows licensees and sublicensees of Sun's GPL2 OpenJDK Code to build an executable that includes those portions of necessary code that Sun could not provide under GPL2 (or that Sun has provided under GPL2 with the Classpath exception).' > Thanks, > Yulia > > > Andrew John Hughes wrote: > > > On 18/08/2008, Yulia Novozhilova wrote: > > > > > > > Hi, > > > > > > Andrew John Hughes wrote: > > > > > > > > > > > > > The more obvious question for me is why NetBeans needs a fork of this > > > > in the first place. The Debian OpenJDK team have already gone through > > > > the extensive task of verifying this code legally to package OpenJDK > > > > 6, which is now in unstable and testing: > > > > > > > > > > > > > > > > > > > > http://release.debian.org/migration/testing.pl?package=openjdk-6 > > > > > > > > > > Having another copy in another package seems ludicrous and a > > > > duplication of existing work. > > > > > > > > > > > > > > > > > > > There are users who want to use NetBeans but don't want to install > openjdk. > > > (you can find an example here: > > > > https://bugs.launchpad.net/ubuntu/+source/netbeans/+bug/258844) > > > They already have sun-java6-jdk installed and expect NetBeans to work > on > > > it. > > > That is why NetBeans needs a fork of the code included into openjdk. > > > > > > Thanks, > > > Yulia > > > > > > > > > > > > > > > > > > > > > > > > > It doesn't explain why a fork is needed. It just says that NetBeans > > has to be able to work against either the langtools from OpenJDK or > > the proprietary Sun JDK. As I read it, a fork solution is suggesting > > a third alternative, namely to include another different copy of the > > langtools for NetBeans. > > > > In short, what is the reason NetBeans can't just work against the > > tools.zip in either JDK? > > > > > > -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Ulf.Zibis at gmx.de Wed Aug 20 18:59:48 2008 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Wed, 20 Aug 2008 20:59:48 +0200 Subject: Is third party code included in langtools sources? In-Reply-To: <489889EC.3020003@sun.com> References: <489889EC.3020003@sun.com> Message-ID: <48AC69A4.5060802@gmx.de> This problem was also discussed from NetBeans side: http://www.nabble.com/-65cat---other--Installation-and-other-issues-with-openjdk-to19034100.html#a19063742 -Ulf Am 05.08.2008 19:12, Yulia Novozhilova schrieb: > Hi, > > Could you please, help me to answer a question: > Is third party code included in langtools sources? > If "no" then _why_ the THIRD_PARTY_README and ASSEMBLY_EXCEPTION > files are included into the repository? > > Actually I'm working on the Debian/Ubuntu native packaging for > NetBeans IDE. > NetBeans uses javac that is a fork of the langtools repository: > http://hg.openjdk.java.net/jdk7/tl/langtools/ > > So I have to create a debian package for it. The problem is that > Debian policy is strict about license: > I must point the license for each file in the upstream source (files > from langtools repository). Currently I can't explain why > THIRD_PARTY_README and ASSEMBLY_EXCEPTION are in the upstream. Are > there any files that need them? > > Thanks in advance, > -Yulia > > ------------------------------------------------------------------------ > > Betreff: > Re: [nb-linux] The NetBeans Javaparser sources for NetBeans 6.1 > Von: > Jan Lahoda > Datum: > Tue, 05 Aug 2008 17:51:48 +0200 > An: > Yulia Novozhilova > > An: > Yulia Novozhilova > CC: > Jan Becicka , > linux-packaging at installer.netbeans.org, Petr Hrebejk > , Alexei Mokeev > > > Hi, > the NetBeans javac is a fork of the javac from the OpenJDK. More > precisely, we use a fork of the langtools repository: > http://hg.openjdk.java.net/jdk7/tl/langtools/ > > The THIRD_PARTY_README and ASSEMBLY_EXCEPTION files originate in this > repository. I am not sure if we can simply delete them. Better > solution, in my opinion, would be to ask the maintainers of > OpenJDK/langtools repository whether these files could be removed from > the original langtools repository (I do not think these are needed for > langtools, but IANAL). We could adopt the change in our fork easily. > > Jan > > Yulia Novozhilova wrote: >> Hi, >> >> As nobody responds I think it is better to use the same license and >> copyright files for packaging as we've used for javaparser-6.0: >> http://java.netbeans.org/files/documents/25/1798/nb-javaparser-6.0-src.zip >> >> >> nb-javaparser-6.0-src.zip doesn't contain THIRD_PARTY_README and >> ASSEMBLY_EXCEPTION, so >> >> Honza, could you please, ___remove___ these files from the >> >> http://java.netbeans.org/files/documents/25/2033/nb-javaparser-6.1-src.zip >> ? >> >> Thanks in advance, >> Yulia >> >> >> Yulia Novozhilova wrote: >>> Hi all, >>> >>> Could someone explain me how to determine what license .java file >>> (for example) is under? >>> I definitely don't understand why we need THIRD_PARTY_README and >>> ASSEMBLY_EXCEPTION for javaparser upstream. >>> Does third party code is included there? How can I check that? >>> I've looked through the source code in >>> http://java.netbeans.org/files/documents/25/2033/nb-javaparser-6.1-src.zip >>> >>> and couldn't find any copyright mentioned in THIRD_PARTY_README. >>> >>> Furthermore for NetBeans we remove all license files from the >>> upstream, including THIRDPARTYLICENSEREADME.txt and leave >>> one LICENSE file with GNU and CDDL licenses. >>> >>> Thanks in advance, >>> Yulia >>> >>> Dalibor Topic wrote: >>>> Marek Slama wrote: >>>>> Question: What is THIRD_PARTY_README good for? >>>> >>>> In OpenJDK, we use that file to track licenses of third party code >>>> included in the source code, >>>> so that downstream knows what the ingredients are. See >>>> http://hg.openjdk.java.net/jdk7/jdk7/file/3300a35a0bd5/THIRD_PARTY_README >>>> for an example. >>>>> It is necessary to include this? >>>> It makes the life of the packager easier, in general, since Debian, >>>> for example, wants to know what >>>> licenses all the code in a project is under, including third party >>>> code that's included in the sources. >>>> >>>> cheers, >>>> dalibor topic >>>> >>>> >>> >> > From martinrb at google.com Wed Aug 20 22:08:15 2008 From: martinrb at google.com (martinrb at google.com) Date: Wed, 20 Aug 2008 22:08:15 +0000 Subject: hg: jdk7/tl/jdk: 6739302: Check that deserialization preserves EnumSet integrity Message-ID: <20080820220827.88742D6C6@hg.openjdk.java.net> Changeset: dc4067f914a2 Author: martin Date: 2008-08-20 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc4067f914a2 6739302: Check that deserialization preserves EnumSet integrity Reviewed-by: dl, chegar Contributed-by: jjb at google.com ! src/share/classes/java/util/EnumSet.java + test/java/util/EnumSet/BogusEnumSet.java From maurizio.cimadamore at sun.com Fri Aug 22 10:55:02 2008 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Fri, 22 Aug 2008 10:55:02 +0000 Subject: hg: jdk7/tl/langtools: 6733837: Recent work on javac diagnostic affected javac output Message-ID: <20080822105506.23896D936@hg.openjdk.java.net> Changeset: 37551dc0f591 Author: mcimadamore Date: 2008-08-22 11:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/37551dc0f591 6733837: Recent work on javac diagnostic affected javac output Summary: Problems with diagnostic path and tab character in the source code Reviewed-by: darcy, jjg ! src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java + test/tools/javac/api/6733837/T6733837.java From swamy.venkataramanappa at sun.com Fri Aug 22 17:38:41 2008 From: swamy.venkataramanappa at sun.com (swamy.venkataramanappa at sun.com) Date: Fri, 22 Aug 2008 17:38:41 +0000 Subject: hg: jdk7/tl/jdk: 6653883: jmap with no option should print mmap instead of heap information. Message-ID: <20080822173907.327F5D9A3@hg.openjdk.java.net> Changeset: 52fbd007f47b Author: swamyv Date: 2008-08-22 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/52fbd007f47b 6653883: jmap with no option should print mmap instead of heap information. Summary: Changed the default option of jmap to print mmap. Reviewed-by: jjh ! src/share/classes/sun/tools/jmap/JMap.java From kelly.ohair at sun.com Fri Aug 22 20:40:09 2008 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Fri, 22 Aug 2008 20:40:09 +0000 Subject: hg: jdk7/tl/jdk: 6732421: Removed old javavm and Classic VM files from the jdk7 sources Message-ID: <20080822204032.DBF2ED9B0@hg.openjdk.java.net> Changeset: 3a4370604bab Author: ohair Date: 2008-08-22 12:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3a4370604bab 6732421: Removed old javavm and Classic VM files from the jdk7 sources Reviewed-by: alanb ! make/common/Defs.gmk ! make/java/verify/Makefile ! make/netbeans/awt2d/README ! make/tools/GenerateCharacter/check_class.c.template ! src/share/back/debugDispatch.c ! src/share/back/error_messages.c ! src/share/back/inStream.c ! src/share/back/outStream.h ! src/share/instrument/InstrumentationImplNativeMethods.c ! src/share/instrument/JPLISAgent.c ! src/share/javavm/export/jvm.h - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h ! src/share/native/common/check_code.c ! src/share/native/common/check_format.c ! src/solaris/back/util_md.h ! src/solaris/instrument/FileSystemSupport_md.h ! src/solaris/javavm/export/jvm_md.h - src/solaris/javavm/include/typedefs_md.h ! src/solaris/native/common/gdefs_md.h ! src/solaris/native/common/jlong_md.h ! src/windows/back/util_md.h ! src/windows/hpi/src/socket_md.c ! src/windows/hpi/src/threads_md.c ! src/windows/instrument/FileSystemSupport_md.h ! src/windows/javavm/export/jvm_md.h - src/windows/javavm/include/typedefs_md.h ! src/windows/native/java/net/net_util_md.c From xueming.shen at sun.com Fri Aug 22 21:45:47 2008 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Fri, 22 Aug 2008 21:45:47 +0000 Subject: hg: jdk7/tl/jdk: 4486841: UTF-8 decoder should adhere to corrigendum to Unicode 3.0.1; ... Message-ID: <20080822214609.853B6D9B7@hg.openjdk.java.net> Changeset: 3dcc69147ff9 Author: sherman Date: 2008-08-22 14:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3dcc69147ff9 4486841: UTF-8 decoder should adhere to corrigendum to Unicode 3.0.1 6636317: Optimize UTF-8 coder for ASCII input Summary: re-write the UTF-8 charset to obey the standard and improve the performance Reviewed-by: alanb ! src/share/classes/sun/nio/cs/UTF_8.java + test/sun/nio/cs/TestUTF8.java From xueming.shen at sun.com Sat Aug 23 06:00:33 2008 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Sat, 23 Aug 2008 06:00:33 +0000 Subject: hg: jdk7/tl/jdk: 6740702: Comment tag update Message-ID: <20080823060059.82C21D9E9@hg.openjdk.java.net> Changeset: a33cf5828b82 Author: sherman Date: 2008-08-22 22:54 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a33cf5828b82 6740702: Comment tag update Summary: tag update Reviewed-by: mr ! src/share/classes/sun/nio/cs/UTF_8.java From bradford.wetmore at sun.com Tue Aug 26 00:02:44 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Tue, 26 Aug 2008 00:02:44 +0000 Subject: hg: jdk7/tl/jdk: 6 new changesets Message-ID: <20080826000420.9B32BDB32@hg.openjdk.java.net> Changeset: a4ff2fe5b5d9 Author: weijun Date: 2008-08-06 08:11 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a4ff2fe5b5d9 6731685: CertificateFactory.generateCertificates throws IOException on PKCS7 cert chain Reviewed-by: mullan ! src/share/classes/sun/security/util/DerIndefLenConverter.java + test/sun/security/util/DerValue/Indefinite.java Changeset: 97d08b2b4539 Author: chegar Date: 2008-08-06 07:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/97d08b2b4539 6734171: java.net.NetworkInterface reports XCheck:jni warnings Summary: Removed leading "L" or trailing ";" from FindClass classname param Reviewed-by: alanb ! src/windows/native/java/net/NetworkInterface.c Changeset: 874f4db252e3 Author: wetmore Date: 2008-08-20 00:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/874f4db252e3 Merge Changeset: afcf04c535da Author: michaelm Date: 2008-08-21 10:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/afcf04c535da 6258215: Num of backlog in ServerSocket(int, int) should be mentioned more explicitly Summary: updated javadoc Reviewed-by: chegar ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/javax/net/ssl/SSLServerSocket.java Changeset: f4289d75cd29 Author: jccollet Date: 2008-08-25 14:38 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4289d75cd29 6717876: Make java.net.NetworkInterface.getIndex() public Summary: Make getIndex() and getByIndex() public. Required a name change in native code Reviewed-by: alanb, chegar, michaelm ! make/java/net/mapfile-vers ! src/share/classes/java/net/NetworkInterface.java ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c ! src/windows/native/java/net/net_util_md.h + test/java/net/NetworkInterface/IndexTest.java Changeset: 872241636752 Author: wetmore Date: 2008-08-25 08:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/872241636752 Merge From alan.bateman at sun.com Tue Aug 26 10:51:31 2008 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Tue, 26 Aug 2008 10:51:31 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080826105203.9A4CCDBBD@hg.openjdk.java.net> Changeset: 2a5377a6492e Author: alanb Date: 2008-08-26 09:23 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a5377a6492e 6728542: (se) epoll based SelectorProvider should be portable to platforms other than x86 and x64 Reviewed-by: sherman ! make/java/nio/mapfile-linux ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c Changeset: ea45b0c72096 Author: alanb Date: 2008-08-26 10:21 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ea45b0c72096 6682020: (bf) Support monitoring of direct and mapped buffer usage Reviewed-by: mchung, iris ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk ! src/share/classes/java/lang/management/PlatformComponent.java ! src/share/classes/java/nio/Bits.java + src/share/classes/java/nio/BufferPoolMXBean.java ! src/share/classes/java/nio/Direct-X-Buffer.java + src/share/classes/sun/misc/JavaNioAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java + test/java/nio/BufferPoolMXBean/Basic.java From jonathan.gibbons at sun.com Tue Aug 26 21:53:30 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 26 Aug 2008 21:53:30 +0000 Subject: hg: jdk7/tl/langtools: 6508981: cleanup file separator handling in JavacFileManager Message-ID: <20080826215332.8D18BDC2A@hg.openjdk.java.net> Changeset: e571266ae14f Author: jjg Date: 2008-08-26 14:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e571266ae14f 6508981: cleanup file separator handling in JavacFileManager Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java + src/share/classes/com/sun/tools/javac/file/RelativePath.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/javax/tools/StandardLocation.java + test/tools/javac/6508981/TestInferBinaryName.java + test/tools/javac/6508981/p/A.java ! test/tools/javac/T6725036.java From eamonn.mcmanus at sun.com Wed Aug 27 09:06:14 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Wed, 27 Aug 2008 09:06:14 +0000 Subject: hg: jdk7/tl/jdk: 5041784: (reflect) generic signature methods needlessly return generic arrays Message-ID: <20080827090626.B31AEDC69@hg.openjdk.java.net> Changeset: 7afa7314d883 Author: emcmanus Date: 2008-08-27 11:03 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7afa7314d883 5041784: (reflect) generic signature methods needlessly return generic arrays Reviewed-by: darcy ! src/share/classes/sun/reflect/generics/factory/CoreReflectionFactory.java + test/java/lang/reflect/Generics/TestPlainArrayNotGeneric.java From kumar.srinivasan at sun.com Wed Aug 27 16:11:06 2008 From: kumar.srinivasan at sun.com (kumar.srinivasan at sun.com) Date: Wed, 27 Aug 2008 16:11:06 +0000 Subject: hg: jdk7/tl/jdk: 6685121: (launcher) make ReportErrorMessages accessible by other launcher subsystems Message-ID: <20080827161123.DCE2DDC99@hg.openjdk.java.net> Changeset: 2c65a59dd48d Author: ksrini Date: 2008-08-26 10:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2c65a59dd48d 6685121: (launcher) make ReportErrorMessages accessible by other launcher subsystems Summary: provided error reporting interfaces to other java subsystems that the launcher uses. Reviewed-by: darcy ! make/java/jli/Makefile ! make/java/jli/mapfile-vers ! src/share/bin/emessages.h ! src/share/bin/java.c ! src/share/bin/java.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c From xueming.shen at sun.com Wed Aug 27 17:35:36 2008 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Wed, 27 Aug 2008 17:35:36 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080827173601.444E2DCB5@hg.openjdk.java.net> Changeset: d6b41950987b Author: sherman Date: 2008-08-27 10:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d6b41950987b 4849617: (cs)Revise Charset spec to allow '+' in names Summary: Update the spec and code to accept '+' as a charset name character Reviewed-by: alanb ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/nio/cs/standard-charsets + test/sun/nio/cs/CheckICNE.java Changeset: 126760548921 Author: sherman Date: 2008-08-27 10:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/126760548921 Merge From tim.bell at sun.com Thu Aug 28 05:59:13 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 28 Aug 2008 05:59:13 +0000 Subject: hg: jdk7/tl: 6737659: debug bundles are empty Message-ID: <20080828055913.6BA49DDB7@hg.openjdk.java.net> Changeset: 46a989ab9329 Author: ohair Date: 2008-08-17 09:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/46a989ab9329 6737659: debug bundles are empty Summary: Build order issue with debug build, caused final debug bundle to be empty. Reviewed-by: tbell ! Makefile From christopher.hegarty at sun.com Fri Aug 29 16:49:16 2008 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Fri, 29 Aug 2008 16:49:16 +0000 Subject: hg: jdk7/tl/jdk: 6576763: Thread constructors throw undocumented NPE for null name Message-ID: <20080829164928.10887DEF6@hg.openjdk.java.net> Changeset: 5d278726f0dc Author: chegar Date: 2008-08-29 17:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5d278726f0dc 6576763: Thread constructors throw undocumented NPE for null name Summary: update javadoc to specify NPE as well as fix minor bug in implementation. Reviewed-by: alanb ! src/share/classes/java/lang/Thread.java + test/java/lang/ThreadGroup/NullThreadName.java From jonathan.gibbons at sun.com Fri Aug 29 18:10:47 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 29 Aug 2008 18:10:47 +0000 Subject: hg: jdk7/tl/langtools: 6597471: unused imports in javax.tools.JavaCompiler; ... Message-ID: <20080829181048.B62B8DF51@hg.openjdk.java.net> Changeset: 5e89c4ca637c Author: jjg Date: 2008-08-29 11:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5e89c4ca637c 6597471: unused imports in javax.tools.JavaCompiler 6597531: unused imports and unused private const. in com.sun.tools.javac.Server.java Reviewed-by: mcimadamore Contributed-by: davide.angelocola at gmail.com ! src/share/classes/com/sun/tools/javac/Server.java ! src/share/classes/com/sun/tools/javac/api/JavacScope.java ! src/share/classes/com/sun/tools/javac/api/WrappingJavaFileManager.java ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Env.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/model/FilteredMemberList.java ! src/share/classes/com/sun/tools/javac/parser/DocCommentScanner.java ! src/share/classes/com/sun/tools/javac/parser/EndPosParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacFiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java ! src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/Context.java From trenta at athabascau.ca Fri Aug 29 20:21:19 2008 From: trenta at athabascau.ca (Trenton D. Adams) Date: Fri, 29 Aug 2008 14:21:19 -0600 (MDT) Subject: RMI RemoteException Message-ID: <346090361.81901220041279835.JavaMail.root@avocado.cs.athabascau.ca> Hi Guys, Is this the right list to be discussing RMI topics? I saw some RMI related stuff when I did a site search on google. I'm curious what the reasoning is behind leaving RemoteException as a checked exception. It seems to me that it would be more relevant to have it as a RuntimeException, as there is not a whole lot one can do about it. Any ideas why it might be that way? If there is agreement that it should be an unchecked exception, any hope of moving toward it being unchecked? Thanks. Trenton D. Adams Systems Analyst/Web Software Engineer Navy Penguins at your service! Athabasca University (780) 675-6195 :wq! __ This communication is intended for the use of the recipient to whom it is addressed, and may contain confidential, personal, and or privileged information. Please contact us immediately if you are not the intended recipient of this communication, and do not copy, distribute, or take action relying on it. Any communications received in error, or subsequent reply, should be deleted or destroyed. --- From swamy.venkataramanappa at sun.com Fri Aug 29 21:36:19 2008 From: swamy.venkataramanappa at sun.com (swamy.venkataramanappa at sun.com) Date: Fri, 29 Aug 2008 21:36:19 +0000 Subject: hg: jdk7/tl/jdk: 6614052: jhat fails to read heap dump > 2GB. Message-ID: <20080829213631.73282DF66@hg.openjdk.java.net> Changeset: dc604a6da888 Author: swamyv Date: 2008-08-29 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc604a6da888 6614052: jhat fails to read heap dump > 2GB. Summary: Modified the jhat code to use long for unsigned int. This is a forward port of changes from Kevin Walls. Reviewed-by: jjh ! src/share/classes/com/sun/tools/hat/internal/parser/HprofReader.java From David.Holmes at Sun.COM Sat Aug 30 00:55:00 2008 From: David.Holmes at Sun.COM (David Holmes - Sun Microsystems) Date: Sat, 30 Aug 2008 10:55:00 +1000 Subject: RMI RemoteException In-Reply-To: <346090361.81901220041279835.JavaMail.root@avocado.cs.athabascau.ca> References: <346090361.81901220041279835.JavaMail.root@avocado.cs.athabascau.ca> Message-ID: <48B89A64.5010302@sun.com> HI Trenton, This might not be the right place for it but ... RemoteException is checked because you have to understand that it can happen (and occasionally will) and you have to think about what can be done to recover (even if you ultimately decide to just to "fail" by throwing some other exception). The "distributed computing can be transparent" myth was debunked years ago (I used to work with a system that tried it and nicely demonstrated why it didn't work!). Jim Waldo has a famous paper on this topic "Notes on Distributed Computing": http://research.sun.com/techrep/1994/abstract-29.html Cheers, David Holmes Senior Java Technologist Java SE VM Real-time and Embedded Group --------------------------------------- Trenton D. Adams said the following on 08/30/08 06:21: > Hi Guys, > > Is this the right list to be discussing RMI topics? I saw some RMI related stuff when I did a site search on google. > > I'm curious what the reasoning is behind leaving RemoteException as a checked exception. It seems to me that it would be more relevant to have it as a RuntimeException, as there is not a whole lot one can do about it. > > Any ideas why it might be that way? If there is agreement that it should be an unchecked exception, any hope of moving toward it being unchecked? > > Thanks. > > Trenton D. Adams > Systems Analyst/Web Software Engineer > Navy Penguins at your service! > Athabasca University > (780) 675-6195 > :wq! > > __ > This communication is intended for the use of the recipient to whom it > is addressed, and may contain confidential, personal, and or privileged > information. Please contact us immediately if you are not the intended > recipient of this communication, and do not copy, distribute, or take > action relying on it. Any communications received in error, or > subsequent reply, should be deleted or destroyed. > ---