From mr at sun.com Sat Mar 1 06:49:24 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:49:24 +0000 Subject: hg: jdk7/nio2: 2 new changesets Message-ID: <20080301064924.419B926086@hg.openjdk.java.net> Changeset: 0a5c5386a678 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/rev/0a5c5386a678 Added tag jdk7-b24 for changeset cfeea66a3fa8 + .hgtags Changeset: c57bef8dda9c Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/rev/c57bef8dda9c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 06:49:37 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:49:37 +0000 Subject: hg: jdk7/nio2/corba: 2 new changesets Message-ID: <20080301064939.92BCA2608D@hg.openjdk.java.net> Changeset: 474c23b174e9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/corba/rev/474c23b174e9 Added tag jdk7-b24 for changeset 55540e827aef + .hgtags Changeset: fec639c69db2 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/corba/rev/fec639c69db2 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 06:50:03 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:50:03 +0000 Subject: hg: jdk7/nio2/hotspot: 2 new changesets Message-ID: <20080301065009.4DE5D26094@hg.openjdk.java.net> Changeset: 92489cdc94d1 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/hotspot/rev/92489cdc94d1 Added tag jdk7-b24 for changeset a61af66fc99e + .hgtags Changeset: 7836be3e92d0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/hotspot/rev/7836be3e92d0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 06:50:55 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:50:55 +0000 Subject: hg: jdk7/nio2/jaxp: 2 new changesets Message-ID: <20080301065059.9FE432609B@hg.openjdk.java.net> Changeset: 9e3c1ad7cdb9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/jaxp/rev/9e3c1ad7cdb9 Added tag jdk7-b24 for changeset 6ce5f4757bde + .hgtags Changeset: 49a4bc7b0aa0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/jaxp/rev/49a4bc7b0aa0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 06:51:13 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:51:13 +0000 Subject: hg: jdk7/nio2/jaxws: 2 new changesets Message-ID: <20080301065116.C753D260A2@hg.openjdk.java.net> Changeset: 7d53d3bd7879 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/jaxws/rev/7d53d3bd7879 Added tag jdk7-b24 for changeset 0961a4a21176 + .hgtags Changeset: 018781e80410 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/jaxws/rev/018781e80410 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 06:51:31 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:51:31 +0000 Subject: hg: jdk7/nio2/jdk: 2 new changesets Message-ID: <20080301065212.25D1D260A9@hg.openjdk.java.net> Changeset: 99a06bc7fdb5 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/jdk/rev/99a06bc7fdb5 Added tag jdk7-b24 for changeset 37a05a11f281 + .hgtags Changeset: 8266cb7549d3 Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/jdk/rev/8266cb7549d3 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 06:53:53 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 06:53:53 +0000 Subject: hg: jdk7/nio2/langtools: 2 new changesets Message-ID: <20080301065357.535FE260B0@hg.openjdk.java.net> Changeset: e4dae1993f8b Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/langtools/rev/e4dae1993f8b Added tag jdk7-b24 for changeset 9a66ca7c79fa + .hgtags Changeset: e5e9fa6fa29c Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/nio2/langtools/rev/e5e9fa6fa29c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 07:01:06 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:01:06 +0000 Subject: hg: jdk7/tl: 2 new changesets Message-ID: <20080301070106.D21DF260EE@hg.openjdk.java.net> Changeset: 0a5c5386a678 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/0a5c5386a678 Added tag jdk7-b24 for changeset cfeea66a3fa8 + .hgtags Changeset: c57bef8dda9c Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/c57bef8dda9c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 07:01:20 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:01:20 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20080301070122.5C23C260F5@hg.openjdk.java.net> Changeset: 474c23b174e9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/474c23b174e9 Added tag jdk7-b24 for changeset 55540e827aef + .hgtags Changeset: fec639c69db2 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/fec639c69db2 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 07:01:48 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:01:48 +0000 Subject: hg: jdk7/tl/hotspot: 2 new changesets Message-ID: <20080301070153.C9D70260FC@hg.openjdk.java.net> Changeset: 92489cdc94d1 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/92489cdc94d1 Added tag jdk7-b24 for changeset a61af66fc99e + .hgtags Changeset: 7836be3e92d0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7836be3e92d0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 07:02:39 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:02:39 +0000 Subject: hg: jdk7/tl/jaxp: 2 new changesets Message-ID: <20080301070242.F009126103@hg.openjdk.java.net> Changeset: 9e3c1ad7cdb9 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/9e3c1ad7cdb9 Added tag jdk7-b24 for changeset 6ce5f4757bde + .hgtags Changeset: 49a4bc7b0aa0 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/49a4bc7b0aa0 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 07:02:58 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:02:58 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20080301070301.9CAA22610A@hg.openjdk.java.net> Changeset: 7d53d3bd7879 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/7d53d3bd7879 Added tag jdk7-b24 for changeset 0961a4a21176 + .hgtags Changeset: 018781e80410 Author: mr Date: 2008-02-29 20:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/018781e80410 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From eliasen at mindspring.com Sat Mar 1 07:03:26 2008 From: eliasen at mindspring.com (Alan Eliasen) Date: Sat, 01 Mar 2008 00:03:26 -0700 Subject: Regression tests for BigInteger In-Reply-To: <47BB539B.8090901@mindspring.com> References: <47A14D21.8020807@mindspring.com> <47BB539B.8090901@mindspring.com> Message-ID: <47C8FFBE.5070602@mindspring.com> Attached is the code for regression test for multiply() and pow() in BigInteger. It produces a lot of text (approximately 345 MB) to standard output. You will need to save this output and diff it against known good results. I have provided a file of known good results tested against a variety of platforms, including the Kaffe JVM using the GMP libraries for BigInteger. It tests a lot of different size arguments, including arguments around many powers of 2, which are the places that one would expect problems to occur. The known good results are available at: http://futureboy.us/temp/BigIntegerGood.txt.bz2 This is a 56 MB download compressed with bzip2. I'd appreciate it if others could test this on other platforms. I don't anticipate any problems, though. I haven't had much time to finish the changes to the pow() function, but there are some more optimizations I'd like to put in. -- Alan Eliasen | "Furious activity is no substitute eliasen at mindspring.com | for understanding." http://futureboy.us/ | --H.H. Williams -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: BigIntegerRegressionTest.java URL: From mr at sun.com Sat Mar 1 07:03:17 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:03:17 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080301070353.B6CF526111@hg.openjdk.java.net> Changeset: 99a06bc7fdb5 Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99a06bc7fdb5 Added tag jdk7-b24 for changeset 37a05a11f281 + .hgtags Changeset: 8266cb7549d3 Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8266cb7549d3 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From mr at sun.com Sat Mar 1 07:05:35 2008 From: mr at sun.com (mr at sun.com) Date: Sat, 01 Mar 2008 07:05:35 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20080301070539.3717326118@hg.openjdk.java.net> Changeset: e4dae1993f8b Author: xdono Date: 2007-12-04 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e4dae1993f8b Added tag jdk7-b24 for changeset 9a66ca7c79fa + .hgtags Changeset: e5e9fa6fa29c Author: mr Date: 2008-02-29 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e5e9fa6fa29c 6669216: Add jcheck configuration directories Reviewed-by: ohair, xdono + .jcheck/conf From fw at deneb.enyo.de Sat Mar 1 09:05:06 2008 From: fw at deneb.enyo.de (Florian Weimer) Date: Sat, 01 Mar 2008 10:05:06 +0100 Subject: Regression tests for BigInteger In-Reply-To: <47C8FFBE.5070602@mindspring.com> (Alan Eliasen's message of "Sat, 01 Mar 2008 00:03:26 -0700") References: <47A14D21.8020807@mindspring.com> <47BB539B.8090901@mindspring.com> <47C8FFBE.5070602@mindspring.com> Message-ID: <87ve46ak71.fsf@mid.deneb.enyo.de> * Alan Eliasen: > Attached is the code for regression test for multiply() and pow() in > BigInteger. It produces a lot of text (approximately 345 MB) to > standard output. You will need to save this output and diff it against > known good results. I have provided a file of known good results tested > against a variety of platforms, including the Kaffe JVM using the GMP > libraries for BigInteger. Can't you put MD5 hashes of the known-good results in the test? This way, you only need the 345 MB if something goes wrong. From daniel.fuchs at sun.com Mon Mar 3 13:45:05 2008 From: daniel.fuchs at sun.com (daniel.fuchs at sun.com) Date: Mon, 03 Mar 2008 13:45:05 +0000 Subject: hg: jdk7/tl/jdk: 6651382: The Java JVM SNMP provider reports incorrect stats when asked for multiple OIDs Message-ID: <20080303134518.1C27A26215@hg.openjdk.java.net> Changeset: d8b6af0f01f6 Author: dfuchs Date: 2008-03-03 12:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d8b6af0f01f6 6651382: The Java JVM SNMP provider reports incorrect stats when asked for multiple OIDs Summary: The JvmMemPoolEntryImpl must use the row index when caching data. Reviewed-by: jfdenise ! src/share/classes/sun/management/snmp/jvminstr/JvmMemPoolEntryImpl.java From eamonn.mcmanus at sun.com Mon Mar 3 09:33:10 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Mon, 03 Mar 2008 09:33:10 +0000 Subject: hg: jdk7/tl/jdk: 6602310: Extensions to Query API for JMX 2.0; ... Message-ID: <20080303093322.E41882620A@hg.openjdk.java.net> Changeset: 41d9c673dd9d Author: emcmanus Date: 2008-03-03 10:32 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/41d9c673dd9d 6602310: Extensions to Query API for JMX 2.0 6604768: IN queries require their arguments to be constants Summary: New JMX query language and support for dotted attributes in queries. Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java ! src/share/classes/javax/management/AndQueryExp.java ! src/share/classes/javax/management/AttributeValueExp.java ! src/share/classes/javax/management/BetweenQueryExp.java ! src/share/classes/javax/management/BinaryOpValueExp.java ! src/share/classes/javax/management/BinaryRelQueryExp.java ! src/share/classes/javax/management/BooleanValueExp.java ! src/share/classes/javax/management/InQueryExp.java ! src/share/classes/javax/management/MatchQueryExp.java ! src/share/classes/javax/management/NotQueryExp.java ! src/share/classes/javax/management/NumericValueExp.java ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/OrQueryExp.java ! src/share/classes/javax/management/QualifiedAttributeValueExp.java ! src/share/classes/javax/management/Query.java ! src/share/classes/javax/management/QueryEval.java ! src/share/classes/javax/management/QueryExp.java + src/share/classes/javax/management/QueryParser.java ! src/share/classes/javax/management/StringValueExp.java + src/share/classes/javax/management/ToQueryString.java ! src/share/classes/javax/management/monitor/Monitor.java + test/javax/management/query/QueryDottedAttrTest.java ! test/javax/management/query/QueryExpStringTest.java + test/javax/management/query/QueryParseTest.java From eamonn.mcmanus at sun.com Mon Mar 3 14:31:42 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Mon, 03 Mar 2008 14:31:42 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080303143206.D81432621A@hg.openjdk.java.net> Changeset: 10256bd4afcd Author: emcmanus Date: 2008-03-03 15:28 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/10256bd4afcd 6607114: Make JMXServiceURL reconstructible in MXBeans Summary: Add @ConstructorProperties tag to JMXServiceURL Reviewed-by: dfuchs ! src/share/classes/javax/management/remote/JMXServiceURL.java Changeset: 613f2c906b9d Author: emcmanus Date: 2008-03-03 15:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/613f2c906b9d Merge From eamonn.mcmanus at sun.com Mon Mar 3 14:45:25 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Mon, 03 Mar 2008 14:45:25 +0000 Subject: hg: jdk7/tl/jdk: 6670375: Missing unit test for 6607114 (Make JMXServiceURL reconstructible) Message-ID: <20080303144537.459EC2621F@hg.openjdk.java.net> Changeset: 302cbd0a8ace Author: emcmanus Date: 2008-03-03 15:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/302cbd0a8ace 6670375: Missing unit test for 6607114 (Make JMXServiceURL reconstructible) Summary: Current setup doesn't allow two pushes with same CR number Reviewed-by: dfuchs ! src/share/classes/javax/management/remote/JMXServiceURL.java + test/javax/management/mxbean/JMXServiceURLTest.java From mcimadamore at hg.openjdk.java.net Mon Mar 3 18:03:45 2008 From: mcimadamore at hg.openjdk.java.net (mcimadamore at hg.openjdk.java.net) Date: Mon, 03 Mar 2008 18:03:45 +0000 Subject: hg: jdk7/tl/langtools: 6614974: javac successfully compiles code that throws java.lang.VerifyError when run Message-ID: <20080303180347.2974D26284@hg.openjdk.java.net> Changeset: 3c2d13c42e0a Author: mcimadamore Date: 2008-03-03 16:03 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3c2d13c42e0a 6614974: javac successfully compiles code that throws java.lang.VerifyError when run Summary: synthetic cast missing when translating autoboxing expressions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/boxing/T6614974.java From iris at sun.com Tue Mar 4 02:02:43 2008 From: iris at sun.com (iris clark) Date: Mon, 3 Mar 2008 18:02:43 -0800 (PST) Subject: 6633613: (str) StringCoding optimizations to avoid unnecessary array copies with Charset arg In-Reply-To: <47C71EA7.5090406@sun.com> (message from Martin Buchholz on Thu, 28 Feb 2008 12:50:47 -0800) Message-ID: <200803040202.m2422h0S027019@ribbit.SFBay.Sun.COM> Hi, Martin. > 6633613: (str) StringCoding optimizations to avoid unnecessary array > copies with Charset arg Not necessarily your problem, but it would be nice if your "Subject:" line contained the word "review" or "review request" somewhere in it. It would make this message easier to find. I suppose I should come up with a recommendation, float it about, and get it written up in the appropriate section of the Guide. > with the patches below (a more ambitious patch will hopefully follow > later): Presumably I'll see that review later under one of the charset bugids? > First, warning suppression: I don't believe that StringCoding.java produces build warnings using the default javac options. Should I assume that you're talking about eliminating all build warnings produced using "-Xlint:all" for this file only (not all of the String* files)? > diff --git a/src/share/classes/java/lang/StringCoding.java > b/src/share/classes/java/lang/StringCoding.java These changes are fine. > second, actual fix: > > diff --git a/src/share/classes/java/lang/StringCoding.java > b/src/share/classes/java/lang/StringCoding.java The code you modified was added _extremely_ late during jdk6 development to fix another bug. There's a regression test for that bug. Hopefully you ran it? (Not that I expect it to fail... ) Speaking of regression tests, you didn't include one in these diffs and I don't see an appropriate "noreg-*" keyword in the bug. Please resolve this. See Step 6 ofthe Guide, "Change Planning and Guidelines" [1] for a list of possible keywords. The supplied fix is the minimal amount of change necessary to address this bug (as indicated in your evaluation). Assuming that you still intend to further modify code to improve performance in this area, please remember to add the relevant bugids to the evaluation (or at the very least, references to these bugs in the "See Also" section). Finally, I know that we don't have an externally-visible repository for webrevs yet, but we do need to keep a webrev of these changes as it would aid review should we need to backport this fix. Thanks, iris [1] http://openjdk.java.net/guide/changePlanning.html From mcimadamore at hg.openjdk.java.net Tue Mar 4 12:19:44 2008 From: mcimadamore at hg.openjdk.java.net (mcimadamore at hg.openjdk.java.net) Date: Tue, 04 Mar 2008 12:19:44 +0000 Subject: hg: jdk7/tl/langtools: 6611449: Internal Error thrown during generic method/constructor invocation Message-ID: <20080304121945.A7211262C2@hg.openjdk.java.net> Changeset: b45f8d4794b7 Author: mcimadamore Date: 2008-03-04 12:14 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b45f8d4794b7 6611449: Internal Error thrown during generic method/constructor invocation Summary: type-inference should fail since lub is not defined for primitive types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6611449/T6611449.java + test/tools/javac/generics/inference/6611449/T6611449.out From mcimadamore at hg.openjdk.java.net Tue Mar 4 13:23:46 2008 From: mcimadamore at hg.openjdk.java.net (mcimadamore at hg.openjdk.java.net) Date: Tue, 04 Mar 2008 13:23:46 +0000 Subject: hg: jdk7/tl/langtools: 6660289: declared bound in inner class referring a type variable of the outer class Message-ID: <20080304132348.43C05262C9@hg.openjdk.java.net> Changeset: 40813968849e Author: mcimadamore Date: 2008-03-04 13:00 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/40813968849e 6660289: declared bound in inner class referring a type variable of the outer class Summary: NPE caused by a defect in type-variable attribution Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/T6660289.java From mcimadamore at hg.openjdk.java.net Tue Mar 4 15:22:22 2008 From: mcimadamore at hg.openjdk.java.net (mcimadamore at hg.openjdk.java.net) Date: Tue, 04 Mar 2008 15:22:22 +0000 Subject: hg: jdk7/tl/langtools: 6608214: Exception throw while analysing a file with error Message-ID: <20080304152224.35AAE262F8@hg.openjdk.java.net> Changeset: d472e2fbcc39 Author: mcimadamore Date: 2008-03-04 15:19 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d472e2fbcc39 6608214: Exception throw while analysing a file with error Summary: bad error-recovery after bad type-variable bound is detected Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/api/6608214/T6608214.java From mcimadamore at hg.openjdk.java.net Tue Mar 4 15:57:31 2008 From: mcimadamore at hg.openjdk.java.net (mcimadamore at hg.openjdk.java.net) Date: Tue, 04 Mar 2008 15:57:31 +0000 Subject: hg: jdk7/tl/langtools: 6663588: Compiler goes into infinite loop for Cyclic Inheritance test case Message-ID: <20080304155733.5A694262FD@hg.openjdk.java.net> Changeset: 38bd6375f37d Author: mcimadamore Date: 2008-03-04 15:45 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/38bd6375f37d 6663588: Compiler goes into infinite loop for Cyclic Inheritance test case Summary: interplay between cyclic inheritance and tvar bounds hangs javac Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/T6663588.java From linuxhippy at gmail.com Thu Mar 6 11:18:38 2008 From: linuxhippy at gmail.com (Clemens Eisserer) Date: Thu, 6 Mar 2008 12:18:38 +0100 Subject: Early version of striding Deflater In-Reply-To: <47B62390.7040309@sun.com> References: <194f62550801090711q35d8a5f1wb5a4a29480b40f9b@mail.gmail.com> <4787D6B8.5030805@sun.com> <194f62550801131532v4a3b443bt550beb6bd34549cb@mail.gmail.com> <47B62390.7040309@sun.com> Message-ID: <194f62550803060318m272559cas967a0e1decc447a7@mail.gmail.com> Hi Dave, Thanks a lot for your detailed review, and for fixing the warnings and problems on solaris. Unfourtunatly I am quite busy for now (Math exam is coming and I am really bad in maths) - but I'll continue working on it as soon as times permits. Thanks a lot, lg Clemens > There's a slight change to the semantics of "finished". Current code sets > Deflater.finished only if setParams is false. Changed code may set it > regardlewss of setParams. I suspect this is OK: if client code changed > strategy or level and called Deflater.deflate(), it would invoke > deflateParams(), and not alter the value of finished. The client's subsequent > call to Deflater.deflate() would call deflate() which AFAICT would cause > finished to be set. What do you think? > > Why fall through from Z_OK to Z_BUF_ERROR? In Z_BUF_ERROR and default cases, > why continue execution of loop instead of returning 0 as does original code? > I changed this; see attached Deflater.c > > *** Deflater.java: OK > > *** DeflaterOutputStream.java: OK > > More inline below. > > Clemens Eisserer wrote: > > Hi Dave, > > > > Thanks a lot for your reply. > > To make it short: Of course I understand that this is low-priority > > (also for me, its a fun-only fix because someone in forums.java.net > > mentioned it) so don't hurry. > > Sorry that I wasted your time with my messy files, they were taken > > from my "playground" thats why they were in such a bad shape - they > > were only intended to give an idea which "road" I was taking. I > > attached the new files taken from the mercurial repositories and only > > modified at the affected places. > > > >> With a change of this sort, we really do need tests along with a fix. Have > >> you started writing any test cases? > > I completly agree - I have some simple test-cases which test more or > > less only very basic functionality of Deflater and they work well > > (also FlatterTest passes). > > I'll write some more tests which test exotic use-cases like changing > > compression-level, ... during compression. > > Great, thanks. It would be a Good Idea to have a test that checks my > assumption re finished (see above). > > > I have some open questions: > > 1.) Is the seperate structure approach to hold the stride-buffers ok? > > I think so. > > > 2.) Any suggestions for the following names: 1. strm-field in class > > (defAdr), 2. defAdr-parameter,3. defptr - long_to_ptr of defAdr, 4. > > def_data - name of the structure > > Those don't quite match what I see in the code; but what's in the code seems OK: > def_data for the struct, > def_adr as a param to deflateBytes, etc. etc. > defptr to reference a def_data in init and deflateBytes > > > 3.) I am not really used to program in C. Are the adress-operations ok > > which I used to get members of the new struct def_data? > > It seems OK. > > > Thanks for your patience, lg Clemens > > > > Some notes, and changes in ramdom order: > > * Changed deflate-bytes to the old behaviour to return after the call > > to deflateParams > > Good; AFAICT at maintains the existing semantics. > > > * Verified that its ok to call deflateParams when there's not enough > > space in the output-buffer to flush all "old" data out (thanks to Mark > > Adler) > > * I changed the method-signiture of the native method compared to > > original, because some variables were read from JNI-code, whereas they > > could have been passed simply down using method parameters. I think > > its "cleaner" to pass it. > > The long argument to deflateBytes is a bit cumbersome, but Ken Russell opined > that it provides better performance, so it's a Good Thing: > > > Kenneth Russell wrote: > > I strongly agree with the contributor's suggestion. Not only is passing > > the argument from Java less code, it is also faster since field access > > from Java can be optimized by the HotSpot compiler, where field accesses > > through the JNI must go through the same set of boilerplate > > C/C++/assembly every time. > > > * Allocation of the stride-buffers together with the z_stream > > structure. z_stream is really large, so the two stride-buffers should > > not add that much overhead. However this has the advantage of not > > mallocing/freeing and also beeing able to fill the input-stride-buffer > > once for several calls of the native method. > > Looks good. > > > * Renamed the strm-adress-parameter to defadr, because it no longer > > really points to a strm. I did not rename the java field "strm" > > because I did not have an idea for a proper name. > > It should have had a different name from day one. I'm slightly loathe to make > a name change, nor do I have (Friday afternoon) a Really Good Idea. > > > * Removed striding from DeflaterOutputStream, (looked how code looked in 1.4.2). > > Looks good. > > From your other email: > > > I also thought about implementing striding in the CRC32/Adler32 > > classes which basically suffer from the same block-the-gc behaviour as > > Inflater/Deflater did before they were "fixed" ;) > > I suspect these are not as much of an issue: presumably CRC32 and adler32 > calculations are faster than deflation (caveat: I haven't measured them). > Other have pointed out / shamed us because, hey, shouldn't these be in Java > anyway? > > > Furthermore do you have good ideas for regression tests? > > The usual compression/decompression works fine, can you imagine > > corner-cases which would be worth special testing? > > Should the tests written in the jtreg format? > > I'd like to see tests where there's a possibility of semantics having changed; > as noted above re "finished". > > I haven't done a performance analysis, but don't expect a regression. If > anything, since the striding is kept within native code, there should be fewer > Java -> native calls, and better performance (though that is perhaps not > measurable). > > My last comment is about this change in general. It seems like a reasonable > fix, though the corresponding bug: > http://bugs.sun.com/view_bug.do?bug_id=6399199 > is a low priority one for us, and this is code we generally feel is best left > alone when possible. We are still learning how best to work with > contributions from outside of Sun. I will check with other who've maintained > this code in the past, to get their opinion of making this kind of change. > While I'm currently responsible for jar/zip code, it's only one of the hats I > currently wear ;-) > > Thanks, > Dave > From jonathan.gibbons at sun.com Thu Mar 6 18:10:51 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 06 Mar 2008 18:10:51 +0000 Subject: hg: jdk7/tl/langtools: 4741726: allow Object += String Message-ID: <20080306181052.BE3A4263FA@hg.openjdk.java.net> Changeset: f09d6a3521b1 Author: jjg Date: 2008-03-06 10:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f09d6a3521b1 4741726: allow Object += String Summary: remove code in line with restriction removed from JLS Reviewed-by: mcimadamore Contributed-by: michaelbailey0 at gmail.com ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/StringConversion2.java - test/tools/javac/expression/ObjectAppend.java From jonathan.gibbons at sun.com Thu Mar 6 18:25:01 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 06 Mar 2008 18:25:01 +0000 Subject: hg: jdk7/tl/langtools: 6668802: javac handles diagnostics for last line badly, if line not terminated by newline Message-ID: <20080306182503.3BBDE263FF@hg.openjdk.java.net> Changeset: 508c01999047 Author: jjg Date: 2008-03-06 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/508c01999047 6668802: javac handles diagnostics for last line badly, if line not terminated by newline Summary: use CharBuffer.limit(), not the length of the backing array Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/T6668802.java From kumar.srinivasan at sun.com Thu Mar 6 21:30:28 2008 From: kumar.srinivasan at sun.com (kumar.srinivasan at sun.com) Date: Thu, 06 Mar 2008 21:30:28 +0000 Subject: hg: jdk7/tl/jdk: 6596475: (launcher) javaw should call InitCommonControls Message-ID: <20080306213040.4C4FF2640B@hg.openjdk.java.net> Changeset: 5aaa9902102b Author: ksrini Date: 2008-03-06 07:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5aaa9902102b 6596475: (launcher) javaw should call InitCommonControls Summary: javaw does not show error window after manifest changes. Reviewed-by: darcy ! make/java/jli/Makefile ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! src/share/bin/java.c ! src/share/bin/java.h ! src/share/bin/main.c ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c From Martin.Buchholz at Sun.COM Sun Mar 9 21:34:16 2008 From: Martin.Buchholz at Sun.COM (Martin Buchholz) Date: Sun, 09 Mar 2008 14:34:16 -0700 Subject: 6633613: (str) StringCoding optimizations to avoid unnecessary array copies with Charset arg In-Reply-To: <200803040202.m2422h0S027019@ribbit.SFBay.Sun.COM> References: <200803040202.m2422h0S027019@ribbit.SFBay.Sun.COM> Message-ID: <47D457D8.8050309@sun.com> iris clark wrote: > Hi, Martin. > >> 6633613: (str) StringCoding optimizations to avoid unnecessary array >> copies with Charset arg > >> First, warning suppression: > > I don't believe that StringCoding.java produces build warnings using > the default javac options. Should I assume that you're talking about > eliminating all build warnings produced using "-Xlint:all" for this > file only (not all of the String* files)? My personal development environment includes a private build system that recompiles all modified .java source files with -Xlint:all. I like to remove warnings when working on a source file. >> second, actual fix: >> >> diff --git a/src/share/classes/java/lang/StringCoding.java >> b/src/share/classes/java/lang/StringCoding.java > > The code you modified was added _extremely_ late during jdk6 > development to fix another bug. There's a regression test for that > bug. Hopefully you ran it? (Not that I expect it to fail... ) Yup. > Speaking of regression tests, you didn't include one in these diffs > and I don't see an appropriate "noreg-*" keyword in the bug. Please > resolve this. See Step 6 ofthe Guide, "Change Planning and > Guidelines" [1] for a list of possible keywords. I've added noreg-perf. Martin From martin at xemacs.org Mon Mar 10 07:23:14 2008 From: martin at xemacs.org (martin at xemacs.org) Date: Mon, 10 Mar 2008 07:23:14 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20080310072351.52F2626608@hg.openjdk.java.net> Changeset: 1be19881457e Author: martin Date: 2008-03-09 21:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1be19881457e 4499288: (cs spec) Charset terminology problems Reviewed-by: mr, iris ! src/share/classes/java/nio/charset/Charset.java Changeset: b5da6145b050 Author: martin Date: 2008-03-09 21:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b5da6145b050 6671834: (str) Eliminate StringCoding.java compile warnings Reviewed-by: iris ! src/share/classes/java/lang/StringCoding.java Changeset: 7fb2ca1b52c8 Author: martin Date: 2008-03-09 21:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7fb2ca1b52c8 6633613: (str) StringCoding optimizations to avoid unnecessary array copies with Charset arg Reviewed-by: iris ! src/share/classes/java/lang/StringCoding.java From roman.kennke at aicas.com Mon Mar 10 22:34:57 2008 From: roman.kennke at aicas.com (Roman Kennke) Date: Mon, 10 Mar 2008 23:34:57 +0100 Subject: Bug#6546113 StringCharBuffer fix In-Reply-To: <1192195487.6144.2.camel@mercury> References: <1190919030.7478.10.camel@mercury> <1190919093.7478.12.camel@mercury> <1192127441.2826.17.camel@mercury> <470F7028.6080607@sun.com> <1192195487.6144.2.camel@mercury> Message-ID: <1205188497.13416.97.camel@mercury> Hi, better late than never. Here's the revised patch for the StringCharBuffer, fixing the following bug: > > >>> http://bugs.sun.com/view_bug.do?bug_id=6546113 > > Unfortunately, the bug wasn't caught by existing tests > > so one thing that would be good to do as part of 6546113 is to add or > > improve the regression tests for char buffers that wrap a char sequence. > > Are you interested in doing that as part of the fix to this bug? I added a couple of tests. See the attached patch. > > Anyway, > > your changes look like a reasonable fix for the get methods. Did you > > check the toString, subSequence, and duplicate methods in case they have > > the same problem? I checked them (and added tests), and yes, they have the same problem. Fixed in this revised patch. -- Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Stra?e 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe Gesch?ftsf?hrer: Dr. James J. Hunt -------------- next part -------------- A non-text attachment was scrubbed... Name: stringcharbuffer.patch Type: text/x-patch Size: 4570 bytes Desc: not available URL: From luis-miguel.alventosa at sun.com Mon Mar 10 22:59:23 2008 From: luis-miguel.alventosa at sun.com (luis-miguel.alventosa at sun.com) Date: Mon, 10 Mar 2008 22:59:23 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20080310225959.249DB2663D@hg.openjdk.java.net> Changeset: 3c75107c46a4 Author: lmalvent Date: 2008-03-10 23:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3c75107c46a4 4981215: Publishing a port number for management console to access Reviewed-by: emcmanus, dfuchs ! src/share/classes/sun/management/ConnectorAddressLink.java ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java + test/sun/management/jmxremote/bootstrap/JvmstatCountersTest.java Changeset: c1a7b8f2c1bc Author: lmalvent Date: 2008-03-10 23:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c1a7b8f2c1bc Merge Changeset: 7618b0596aab Author: lmalvent Date: 2008-03-10 23:51 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7618b0596aab Merge From luis-miguel.alventosa at sun.com Tue Mar 11 00:38:59 2008 From: luis-miguel.alventosa at sun.com (luis-miguel.alventosa at sun.com) Date: Tue, 11 Mar 2008 00:38:59 +0000 Subject: hg: jdk7/tl/jdk: 6655515: MBeans tab: operation return values of type Component displayed as String; ... Message-ID: <20080311003911.B9EAC26684@hg.openjdk.java.net> Changeset: 32334945b32e Author: lmalvent Date: 2008-03-11 01:20 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/32334945b32e 6655515: MBeans tab: operation return values of type Component displayed as String 6439590: MBeans tab: jconsole mbean tree not correctly refreshed 6446434: MBeans tab: Not possible to view MBean content before all MBeans have been initially loaded 6520144: Hard to find MBean Attributes, Operations, and Notifications in Java 6 jconsole 6522091: VMPanel.java contains non-ASCII character 6608334: JConsole fails to display MBean operation with return type 6611445: MBeans tab: MBean tree algorithm wrongly removes intermediate nodes. Reviewed-by: dfuchs, jfdenise ! src/share/classes/sun/tools/jconsole/MBeansTab.java ! src/share/classes/sun/tools/jconsole/MemoryPoolStat.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/inspector/OperationEntry.java ! src/share/classes/sun/tools/jconsole/inspector/TableSorter.java ! src/share/classes/sun/tools/jconsole/inspector/ThreadDialog.java ! src/share/classes/sun/tools/jconsole/inspector/Utils.java ! src/share/classes/sun/tools/jconsole/inspector/XDataViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XMBean.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanInfo.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanNotifications.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanOperations.java ! src/share/classes/sun/tools/jconsole/inspector/XObject.java ! src/share/classes/sun/tools/jconsole/inspector/XOperations.java ! src/share/classes/sun/tools/jconsole/inspector/XPlotter.java ! src/share/classes/sun/tools/jconsole/inspector/XPlottingViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XSheet.java ! src/share/classes/sun/tools/jconsole/inspector/XTable.java ! src/share/classes/sun/tools/jconsole/inspector/XTextField.java ! src/share/classes/sun/tools/jconsole/inspector/XTextFieldEditor.java ! src/share/classes/sun/tools/jconsole/inspector/XTree.java From alan.bateman at sun.com Tue Mar 11 15:05:02 2008 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Tue, 11 Mar 2008 15:05:02 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080311150526.A7C1F26705@hg.openjdk.java.net> Changeset: 278e769f9123 Author: alanb Date: 2008-03-11 14:42 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/278e769f9123 6448457: (ch) Channels.newOutputStream().write() does not write all data Reviewed-by: iris, sherman ! src/share/classes/java/nio/channels/Channels.java + test/java/nio/channels/Channels/ShortWrite.java Changeset: c97ff189e490 Author: alanb Date: 2008-03-11 14:49 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c97ff189e490 6644607: (ch) test/java/nio/channels/SocketChannel/Connect.java throws UnknownHostException Reviewed-by: chegar ! test/java/nio/channels/TestUtil.java From martin at xemacs.org Mon Mar 10 21:58:59 2008 From: martin at xemacs.org (martin at xemacs.org) Date: Mon, 10 Mar 2008 21:58:59 +0000 Subject: hg: jdk7/tl/jdk: 8 new changesets Message-ID: <20080310220035.1DCD226621@hg.openjdk.java.net> Changeset: 1d12b16c7df9 Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d12b16c7df9 6631966: (process) Raise Windows pipe buffer size an extra 24 bytes (win) Reviewed-by: alanb, iris ! src/windows/native/java/lang/ProcessImpl_md.c Changeset: b8fc7b5498dd Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8fc7b5498dd 6632696: Writing to closed output files (writeBytes) leaks native memory (unix) Reviewed-by: alanb, iris ! src/share/native/java/io/io_util.c Changeset: 81f76ad22a63 Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81f76ad22a63 6631362: Nuke io_util_md.c:handleFileSizeFD (win) Reviewed-by: alanb, iris ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h Changeset: 307a6801a8e4 Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/307a6801a8e4 6631437: File{In,Out}putStream minor improvements to spec and stylistic improvements to code Reviewed-by: alanb, iris ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java Changeset: 73003d04c21f Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73003d04c21f 6631352: File{OutputStream,Writer} should implement atomic append mode using FILE_APPEND_DATA (win) Reviewed-by: alanb, iris ! make/java/java/mapfile-vers ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/share/native/java/io/io_util.c ! src/solaris/native/java/io/FileOutputStream_md.c ! src/windows/native/java/io/FileOutputStream_md.c ! src/windows/native/java/io/io_util_md.c + test/java/io/FileOutputStream/AtomicAppend.java Changeset: b5a587dd5af3 Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b5a587dd5af3 4960438: (process) Need IO redirection API for subprocesses Reviewed-by: alanb, iris ! src/share/classes/java/lang/Process.java ! src/share/classes/java/lang/ProcessBuilder.java ! src/share/classes/sun/misc/JavaIOFileDescriptorAccess.java ! src/solaris/classes/java/io/FileDescriptor.java ! src/solaris/classes/java/lang/ProcessImpl.java ! src/solaris/classes/java/lang/UNIXProcess.java.linux ! src/solaris/classes/java/lang/UNIXProcess.java.solaris ! src/solaris/native/java/lang/UNIXProcess_md.c ! src/windows/classes/java/io/FileDescriptor.java ! src/windows/classes/java/lang/ProcessImpl.java ! src/windows/native/java/lang/ProcessImpl_md.c ! test/java/lang/ProcessBuilder/Basic.java Changeset: a3ae216ca35d Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a3ae216ca35d 6642034: System.getProperty("os.name") returns Windows Vista on Windows Server 2008 (longhorn) Reviewed-by: iris ! src/windows/native/java/lang/java_props_md.c Changeset: bfed8f5f6345 Author: martin Date: 2008-03-10 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bfed8f5f6345 6671051: (process) Runtime.exec() hangs if signalled during fork/exec Reviewed-by: iris ! src/solaris/native/java/lang/UNIXProcess_md.c From martin at xemacs.org Mon Mar 10 22:28:09 2008 From: martin at xemacs.org (martin at xemacs.org) Date: Mon, 10 Mar 2008 22:28:09 +0000 Subject: hg: jdk7/tl/jdk: 6600143: Remove another 450 unnecessary casts Message-ID: <20080310222821.E11D026632@hg.openjdk.java.net> Changeset: 03fddaf59499 Author: martin Date: 2008-03-10 15:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/03fddaf59499 6600143: Remove another 450 unnecessary casts Reviewed-by: alanb, iris, lmalvent, bristor, peterjones, darcy, wetmore ! make/tools/src/build/tools/jdwpgen/CommandNode.java ! make/tools/src/build/tools/jdwpgen/ConstantSetNode.java ! make/tools/src/build/tools/jdwpgen/RepeatNode.java ! src/share/classes/com/sun/tools/example/debug/bdi/EventRequestSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/EventRequestSpecList.java ! src/share/classes/com/sun/tools/example/debug/bdi/ExecutionManager.java ! src/share/classes/com/sun/tools/example/debug/bdi/JDIEventSource.java ! src/share/classes/com/sun/tools/example/debug/bdi/LineBreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/MethodBreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/bdi/ThreadGroupIterator.java ! src/share/classes/com/sun/tools/example/debug/bdi/ThreadIterator.java ! src/share/classes/com/sun/tools/example/debug/expr/LValue.java ! src/share/classes/com/sun/tools/example/debug/gui/ClassTreeTool.java ! src/share/classes/com/sun/tools/example/debug/gui/CommandInterpreter.java ! src/share/classes/com/sun/tools/example/debug/gui/JDBFileFilter.java ! src/share/classes/com/sun/tools/example/debug/gui/LaunchTool.java ! src/share/classes/com/sun/tools/example/debug/gui/SearchPath.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceManager.java ! src/share/classes/com/sun/tools/example/debug/gui/SourceModel.java ! src/share/classes/com/sun/tools/example/debug/gui/StackTraceTool.java ! src/share/classes/com/sun/tools/example/debug/gui/ThreadTreeTool.java ! src/share/classes/com/sun/tools/example/debug/tty/BreakpointSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/Commands.java ! src/share/classes/com/sun/tools/example/debug/tty/Env.java ! src/share/classes/com/sun/tools/example/debug/tty/EventHandler.java ! src/share/classes/com/sun/tools/example/debug/tty/EventRequestSpec.java ! src/share/classes/com/sun/tools/example/debug/tty/EventRequestSpecList.java ! src/share/classes/com/sun/tools/example/debug/tty/SourceMapper.java ! src/share/classes/com/sun/tools/example/debug/tty/TTY.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadGroupIterator.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadInfo.java ! src/share/classes/com/sun/tools/example/debug/tty/ThreadIterator.java ! src/share/classes/com/sun/tools/example/debug/tty/VMConnection.java ! src/share/classes/com/sun/tools/hat/internal/server/ClassQuery.java ! src/share/classes/com/sun/tools/hat/internal/server/PlatformClasses.java ! src/share/classes/com/sun/tools/jdi/AbstractLauncher.java ! src/share/classes/com/sun/tools/jdi/ClassTypeImpl.java ! src/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/share/classes/com/sun/tools/jdi/EventSetImpl.java ! src/share/classes/com/sun/tools/jdi/JNITypeParser.java ! src/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/PacketStream.java ! src/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/share/classes/com/sun/tools/jdi/SDE.java ! src/share/classes/com/sun/tools/jdi/StackFrameImpl.java ! src/share/classes/com/sun/tools/jdi/TargetVM.java ! src/share/classes/com/sun/tools/jdi/ThreadGroupReferenceImpl.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java ! src/share/classes/com/sun/tools/jdi/VirtualMachineManagerImpl.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/lang/Compiler.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/Modifier.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/ServerSocket.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/nio/channels/spi/SelectorProvider.java ! src/share/classes/java/rmi/activation/ActivationGroupDesc.java ! src/share/classes/java/rmi/dgc/VMID.java ! src/share/classes/java/security/cert/TrustAnchor.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/EnumMap.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/Random.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/prefs/AbstractPreferences.java ! src/share/classes/java/util/regex/Matcher.java ! src/share/classes/javax/rmi/ssl/SslRMIClientSocketFactory.java ! src/share/classes/javax/rmi/ssl/SslRMIServerSocketFactory.java ! src/share/classes/javax/security/auth/kerberos/KerberosTicket.java ! src/share/classes/javax/security/auth/kerberos/KeyImpl.java ! src/share/classes/sun/misc/ClassFileTransformer.java ! src/share/classes/sun/misc/Cleaner.java ! src/share/classes/sun/misc/ExtensionDependency.java ! src/share/classes/sun/misc/GC.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/PerformanceLogger.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/misc/URLClassPath.java ! src/share/classes/sun/net/NetProperties.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/ftp/FtpClient.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/MimeTable.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/http/KeepAliveCache.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java ! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java ! src/share/classes/sun/net/www/protocol/ftp/FtpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/jar/URLJarFile.java ! src/share/classes/sun/nio/ch/Reflect.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/Util.java ! src/share/classes/sun/reflect/ClassDefiner.java ! src/share/classes/sun/reflect/MethodAccessorGenerator.java ! src/share/classes/sun/reflect/ReflectionFactory.java ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/rmi/log/ReliableLog.java ! src/share/classes/sun/rmi/registry/RegistryImpl.java ! src/share/classes/sun/rmi/rmic/RemoteClass.java ! src/share/classes/sun/rmi/rmic/newrmic/jrmp/RemoteClass.java ! src/share/classes/sun/rmi/runtime/Log.java ! src/share/classes/sun/rmi/server/LoaderHandler.java ! src/share/classes/sun/rmi/server/MarshalInputStream.java ! src/share/classes/sun/rmi/server/MarshalOutputStream.java ! src/share/classes/sun/rmi/server/Util.java ! src/share/classes/sun/rmi/server/WeakClassHashMap.java ! src/share/classes/sun/rmi/transport/DGCClient.java ! src/share/classes/sun/rmi/transport/Target.java ! src/share/classes/sun/rmi/transport/Transport.java ! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java ! src/share/classes/sun/rmi/transport/proxy/HttpSendSocket.java ! src/share/classes/sun/rmi/transport/proxy/RMIMasterSocketFactory.java ! src/share/classes/sun/rmi/transport/tcp/ConnectionMultiplexer.java ! src/share/classes/sun/security/jgss/GSSManagerImpl.java ! src/share/classes/sun/security/jgss/krb5/InitSecContextToken.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/DHCrypt.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SessionId.java ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java ! src/share/classes/sun/security/x509/CertificatePolicySet.java ! src/share/classes/sun/security/x509/X509Cert.java ! src/share/classes/sun/tools/jar/JarVerifierStream.java ! src/share/classes/sun/tools/native2ascii/N2AFilter.java ! src/solaris/classes/java/util/prefs/FileSystemPreferences.java ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java ! src/solaris/classes/sun/security/provider/NativePRNG.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java From martin at xemacs.org Tue Mar 11 06:25:54 2008 From: martin at xemacs.org (martin at xemacs.org) Date: Tue, 11 Mar 2008 06:25:54 +0000 Subject: hg: jdk7/tl/jdk: 10 new changesets Message-ID: <20080311062753.C1F4B266A3@hg.openjdk.java.net> Changeset: 7ddbf4c837b9 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7ddbf4c837b9 5080227: (coll spec) Bug in documentation for WeakHashMap Reviewed-by: dholmes ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/WeakHashMap.java Changeset: 72b9e96ddbe9 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/72b9e96ddbe9 6595669: regtest LinkedBlockingQueue/OfferRemoveLoops.java fails Reviewed-by: dholmes ! test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: 3654a4ce7d54 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3654a4ce7d54 6612102: (coll) IdentityHashMap.iterator().remove() might decrement size twice Reviewed-by: dholmes ! src/share/classes/java/util/IdentityHashMap.java + test/java/util/Map/LockStep.java Changeset: 9f7046dbd9ab Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f7046dbd9ab 6602600: Fast removal of cancelled scheduled thread pool tasks Reviewed-by: alanb Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java + test/java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java + test/java/util/concurrent/ScheduledThreadPoolExecutor/Stress.java Changeset: 944d0faa0c50 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/944d0faa0c50 6609775: Reduce context switches in DelayQueue due to signalAll Reviewed-by: alanb Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/DelayQueue.java + test/java/util/concurrent/DelayQueue/Stress.java Changeset: ef7047a30d91 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ef7047a30d91 6620549: ExecutorService#shutdown should clearly state that it does not block Reviewed-by: dholmes Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/ExecutorService.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/ThreadPoolExecutor.java Changeset: da49dce73a07 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/da49dce73a07 6625723: Excessive ThreadLocal storage used by ReentrantReadWriteLock Reviewed-by: dholmes Contributed-by: Doug Lea
! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java ! test/java/util/concurrent/locks/ReentrantReadWriteLock/Count.java Changeset: e34975f797fc Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e34975f797fc 6633113: test/java/util/concurrent/SynchronousQueue/Fairness.java fails intermittently Reviewed-by: dholmes ! test/java/util/concurrent/SynchronousQueue/Fairness.java Changeset: f330b7834288 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f330b7834288 6583872: (coll) Direct uninformed users away from Vector/Hashtable Reviewed-by: dholmes ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/Vector.java Changeset: 0487ce0465d6 Author: martin Date: 2008-03-10 23:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0487ce0465d6 6625725: (coll) modCount should not be volatile Reviewed-by: dholmes ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/WeakHashMap.java From Alan.Bateman at Sun.COM Tue Mar 11 17:04:08 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 11 Mar 2008 17:04:08 +0000 Subject: Bug#6546113 StringCharBuffer fix In-Reply-To: <1205188497.13416.97.camel@mercury> References: <1190919030.7478.10.camel@mercury> <1190919093.7478.12.camel@mercury> <1192127441.2826.17.camel@mercury> <470F7028.6080607@sun.com> <1192195487.6144.2.camel@mercury> <1205188497.13416.97.camel@mercury> Message-ID: <47D6BB88.2040704@sun.com> Roman Kennke wrote: > Hi, > > better late than never. Here's the revised patch for the > StringCharBuffer, fixing the following bug: > Thanks for completing it and addressing my comments. The updated patch looks good. I'll get a second reviewer, run the tests, and we can push a change set. -Alan. From jonathan.gibbons at sun.com Tue Mar 11 20:15:24 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 11 Mar 2008 20:15:24 +0000 Subject: hg: jdk7/tl/langtools: 6307187: clean up code for -Xlint:options Message-ID: <20080311201525.9CE03267E7@hg.openjdk.java.net> Changeset: b66d15dfd001 Author: jjg Date: 2008-03-11 13:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b66d15dfd001 6307187: clean up code for -Xlint:options Summary: introduce common code for handling one-of and any-of options Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/main/JavacOption.java ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! test/tools/javac/6341866/T6341866.java From jonathan.gibbons at sun.com Wed Mar 12 20:05:32 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 12 Mar 2008 20:05:32 +0000 Subject: hg: jdk7/tl/langtools: 6668794: javac puts localized text in raw diagnostics; ... Message-ID: <20080312200533.E3E4D2687F@hg.openjdk.java.net> Changeset: 7366066839bb Author: jjg Date: 2008-03-12 13:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7366066839bb 6668794: javac puts localized text in raw diagnostics 6668796: bad diagnostic "bad class file" given for source files Summary: Replace internal use of localized text with JCDiagnostic fragments; fix diagnostic for bad source file Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/6668794/badClass/A.java + test/tools/javac/6668794/badClass/B.java + test/tools/javac/6668794/badClass/Test.java + test/tools/javac/6668794/badSource/Test.java + test/tools/javac/6668794/badSource/Test.out + test/tools/javac/6668794/badSource/p/A.java From alan.bateman at sun.com Thu Mar 13 19:59:54 2008 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Thu, 13 Mar 2008 19:59:54 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20080313200018.375CC269B6@hg.openjdk.java.net> Changeset: 7b28e857d36c Author: alanb Date: 2008-03-13 19:29 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b28e857d36c 6628575: (fc) lock/tryLock methods do not work with NFS servers that limit lock range to max file size Reviewed-by: sherman ! src/solaris/native/sun/nio/ch/FileChannelImpl.c Changeset: c73cb47fe250 Author: alanb Date: 2008-03-13 19:34 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c73cb47fe250 6546113: (bf) CharSequence.slice() on wrapped CharSequence doesn't start at buffer position Reviewed-by: iris Contributed-by: roman.kennke at aicas.com ! src/share/classes/java/nio/StringCharBuffer.java ! test/java/nio/Buffer/StringCharBufferSliceTest.java From jonathan.gibbons at sun.com Thu Mar 13 20:42:09 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 13 Mar 2008 20:42:09 +0000 Subject: hg: jdk7/tl/langtools: 6559315: Inconsistent non-standard Sun copyright in src/share/opensource/javac/doc/document.css Message-ID: <20080313204211.8EE7B269BB@hg.openjdk.java.net> Changeset: 6beca695cfae Author: jjg Date: 2008-03-13 13:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6beca695cfae 6559315: Inconsistent non-standard Sun copyright in src/share/opensource/javac/doc/document.css Summary: Remove obsolete files Reviewed-by: mcimadamore - src/share/opensource/javac/Makefile - src/share/opensource/javac/README-template.html - src/share/opensource/javac/build.properties - src/share/opensource/javac/build.xml - src/share/opensource/javac/doc/document.css - src/share/opensource/javac/doc/javac_lifecycle/Context.html - src/share/opensource/javac/doc/javac_lifecycle/Enter.html - src/share/opensource/javac/doc/javac_lifecycle/JavaCompiler.html - src/share/opensource/javac/doc/javac_lifecycle/Main.html - src/share/opensource/javac/doc/javac_lifecycle/ToDo.html - src/share/opensource/javac/doc/javac_lifecycle/contents.html - src/share/opensource/javac/doc/javac_lifecycle/index.html - src/share/opensource/javac/doc/javac_lifecycle/packages.html - src/share/opensource/javac/doc/javac_lifecycle/style.css - src/share/opensource/javac/nbproject/project.xml - src/share/opensource/javac/src/bin/javac.sh From xueming.shen at sun.com Fri Mar 14 21:22:58 2008 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Fri, 14 Mar 2008 21:22:58 +0000 Subject: hg: jdk7/tl/jdk: 6514993: (prefs)prefs should use java.util.ServiceLoader to lookup service providers Message-ID: <20080314212310.39BA126B70@hg.openjdk.java.net> Changeset: 547c14448b74 Author: sherman Date: 2008-03-14 14:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/547c14448b74 6514993: (prefs)prefs should use java.util.ServiceLoader to lookup service providers Reviewed-by: iris Contributed-by: xueming.shen at sun.com ! src/share/classes/java/util/prefs/Preferences.java From jonathan.gibbons at sun.com Fri Mar 14 23:09:04 2008 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 14 Mar 2008 23:09:04 +0000 Subject: hg: jdk7/tl/langtools: 6638501: Regression with Javac in JDK6 U4 b03? Message-ID: <20080314230906.8B15A26B94@hg.openjdk.java.net> Changeset: 58039502942e Author: jjg Date: 2008-03-14 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/58039502942e 6638501: Regression with Javac in JDK6 U4 b03? Summary: replace some String paths with File paths in Paths.java Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/util/Paths.java + test/tools/javac/Paths/6638501/HelloLib/test/HelloImpl.java + test/tools/javac/Paths/6638501/JarFromManifestFailure.java + test/tools/javac/Paths/6638501/WsCompileExample.java + test/tools/javac/Paths/6638501/test/SayHello.java + test/tools/javac/Paths/6638501/test1/SayHelloToo.java From bradford.wetmore at sun.com Tue Mar 18 01:54:48 2008 From: bradford.wetmore at sun.com (bradford.wetmore at sun.com) Date: Tue, 18 Mar 2008 01:54:48 +0000 Subject: hg: jdk7/tl/jdk: 32 new changesets Message-ID: <20080318020120.7435726DBD@hg.openjdk.java.net> Changeset: e1b99dfabb04 Author: chegar Date: 2008-03-04 17:09 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e1b99dfabb04 6638560: APPCRASH in "SPNEGO_HTTP_AUTH/PROXY_FALLBACK" test case with 64 bit JDK on Win2008 x64, VinVista x64 Summary: Remove incorrect free from native code Reviewed-by: jccollet ! src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c Changeset: 02e18782ebe1 Author: weijun Date: 2008-03-05 09:52 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/02e18782ebe1 6641312: Fix krb5 codes indentation problems Reviewed-by: xuelei, valeriep, wetmore ! src/share/classes/sun/security/krb5/KrbTgsReq.java ! src/share/classes/sun/security/krb5/internal/APRep.java ! src/share/classes/sun/security/krb5/internal/APReq.java ! src/share/classes/sun/security/krb5/internal/ASRep.java ! src/share/classes/sun/security/krb5/internal/ASReq.java ! src/share/classes/sun/security/krb5/internal/Authenticator.java ! src/share/classes/sun/security/krb5/internal/AuthorizationData.java ! src/share/classes/sun/security/krb5/internal/AuthorizationDataEntry.java ! src/share/classes/sun/security/krb5/internal/EncAPRepPart.java ! src/share/classes/sun/security/krb5/internal/EncASRepPart.java ! src/share/classes/sun/security/krb5/internal/EncKDCRepPart.java ! src/share/classes/sun/security/krb5/internal/EncKrbCredPart.java ! src/share/classes/sun/security/krb5/internal/EncKrbPrivPart.java ! src/share/classes/sun/security/krb5/internal/EncTGSRepPart.java ! src/share/classes/sun/security/krb5/internal/EncTicketPart.java ! src/share/classes/sun/security/krb5/internal/KDCRep.java ! src/share/classes/sun/security/krb5/internal/KDCReq.java ! src/share/classes/sun/security/krb5/internal/KRBCred.java ! src/share/classes/sun/security/krb5/internal/KrbCredInfo.java ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java ! src/windows/native/sun/security/krb5/NativeCreds.c Changeset: 6baf10020bb3 Author: jccollet Date: 2008-03-05 11:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6baf10020bb3 6641309: Wrong Cookie separator used in HttpURLConnection Summary: Added a space to cookie separator. Generified the code and added tags. Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/java/net/CookieHandler/CookieManagerTest.java + test/sun/net/www/protocol/http/B6641309.java Changeset: 7360321c37e3 Author: weijun Date: 2008-03-05 21:55 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7360321c37e3 6648972: KDCReq.init always read padata Summary: PA-DATA is optional, only read it when it exists Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ETypeInfo2.java ! src/share/classes/sun/security/krb5/internal/KDCReq.java + test/sun/security/krb5/OptionPADataInKDCReq.java Changeset: d842462572a9 Author: weijun Date: 2008-03-05 22:15 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d842462572a9 6590930: reed/write does not match for ccache Summary: Add null-awareness to ccache read Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ccache/CCacheInputStream.java ! src/share/classes/sun/security/krb5/internal/ccache/Credentials.java + test/sun/security/krb5/TimeInCCache.java Changeset: 66d2a8a11d59 Author: weijun Date: 2008-03-05 22:16 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/66d2a8a11d59 6664612: debug output leaked Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ccache/CCacheInputStream.java ! src/share/classes/sun/security/krb5/internal/crypto/dk/AesDkCrypto.java ! src/share/classes/sun/security/krb5/internal/crypto/dk/ArcFourCrypto.java Changeset: b6f7db7d8648 Author: jccollet Date: 2008-03-05 17:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b6f7db7d8648 6660405: HttpURLConnection returns the wrong InputStream Summary: Set inputStream back to null in disconnectInternal(). Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/net/www/protocol/http/B6660405.java Changeset: 7ce5e8238b53 Author: jccollet Date: 2008-03-05 18:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7ce5e8238b53 6651717: Debug output statement left in MailToURLConnection Summary: Removed output statement, removed unused imports, added override tags. Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/mailto/MailToURLConnection.java Changeset: fa6948bdc4b0 Author: wetmore Date: 2008-03-06 10:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa6948bdc4b0 6623830: SCCS cleanup has broken two regression tests. Reviewed-by: chegar ! test/java/net/ResponseCache/file2.1 Changeset: a100f699c155 Author: chegar Date: 2008-03-07 09:57 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a100f699c155 6667108: typo in javadoc for java.net.Socket.getRemoteSocketAddress() Summary: Simple typo in method specification. Reviewed-by: jccollet ! src/share/classes/java/net/Socket.java Changeset: 328415dfe347 Author: chegar Date: 2008-03-07 11:30 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/328415dfe347 6615656: Removed unimplemented java.net methods Reviewed-by: jccollet ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/NetworkInterface.java ! src/solaris/classes/java/net/PlainSocketImpl.java ! src/windows/classes/java/net/DualStackPlainSocketImpl.java ! src/windows/classes/java/net/TwoStacksPlainSocketImpl.java Changeset: 10d5be3e1fa8 Author: chegar Date: 2008-03-07 11:51 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/10d5be3e1fa8 6591358: documentation error in URLConnection.setRequestProperty("accept", ...) Summary: Simple doc change, "accept" -> "Accept" Reviewed-by: jccollet ! src/share/classes/java/net/URLConnection.java Changeset: 50a8b5ca8f39 Author: chegar Date: 2008-03-07 13:00 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/50a8b5ca8f39 6628576: InterfaceAddress.equals() NPE when broadcast field == null Summary: Update logic in equals to correctly handle nulls. Reviewed-by: michaelm ! src/share/classes/java/net/InterfaceAddress.java + test/java/net/InterfaceAddress/Equals.java Changeset: 1143fe7be725 Author: chegar Date: 2008-03-07 15:15 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1143fe7be725 6672682: Forgotten file from CR 6615656. Reviewed-by: michaelm ! src/windows/classes/java/net/PlainSocketImpl.java Changeset: 0bce46885f3a Author: chegar Date: 2008-03-07 07:25 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bce46885f3a 6628661: NTLM-authentication doesn't work with non-ASCII letters Summary: Use JNU_GetStringPlatformChars to convert jstrings to the locale specific native C strings Reviewed-by: michaelm ! src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c Changeset: 1b597b0efded Author: chegar Date: 2008-03-07 07:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1b597b0efded Merge Changeset: 67d13a20483a Author: chegar Date: 2008-03-07 17:17 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/67d13a20483a 6631048: Problem when writing on output stream of HttpURLConnection Summary: Fix up logic in ChunkedOutputStream.write Reviewed-by: jccollet ! src/share/classes/sun/net/www/http/ChunkedOutputStream.java ! test/sun/net/www/http/ChunkedOutputStream/Test.java Changeset: 344b9b281048 Author: chegar Date: 2008-03-07 17:18 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/344b9b281048 Merge Changeset: ac695089ccc5 Author: weijun Date: 2008-03-08 22:49 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ac695089ccc5 6634644: broken fragment, should use @link Reviewed-by: mullan ! src/share/classes/javax/security/cert/X509Certificate.java Changeset: 2c37083730b1 Author: weijun Date: 2008-03-08 22:51 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2c37083730b1 6643094: Test on keytool -startdate forgets about December Reviewed-by: xuelei ! test/sun/security/tools/keytool/StartDateTest.java Changeset: 06eb4d224a6b Author: weijun Date: 2008-03-08 22:52 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/06eb4d224a6b 6597349: KeyStore.getCertificateChain() may not return the full chain Reviewed-by: mullan ! src/share/classes/java/security/KeyStore.java Changeset: f6f456d2fabf Author: weijun Date: 2008-03-12 09:32 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f6f456d2fabf 6673164: dns_fallback parse error Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/Config.java + test/sun/security/krb5/DnsFallback.java Changeset: a43ebfd8915a Author: wetmore Date: 2008-03-11 23:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a43ebfd8915a Merge ! src/share/classes/java/net/Socket.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 6068b786e186 Author: mullan Date: 2008-03-13 13:29 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6068b786e186 6611991: Add support for parsing RFC4514 DNs to X500Principal Summary: Added new test and made one code change to escape null characters. Reviewed-by: vinnie ! src/share/classes/sun/security/x509/AVA.java + test/javax/security/auth/x500/X500Principal/RFC4514.java Changeset: 32e7ba670b0e Author: mullan Date: 2008-03-14 10:33 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/32e7ba670b0e Merge Changeset: 7dc3b56f220f Author: xuelei Date: 2008-03-15 13:43 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dc3b56f220f 6648816: REGRESSION: setting -Djava.security.debug=failure result in NPE in ACC Summary: unchecking the null pointer of the debug handle Reviewed-by: mullan, weijun ! src/share/classes/java/security/AccessControlContext.java + test/java/security/AccessControlContext/FailureDebugOption.java Changeset: d69e411f0711 Author: xuelei Date: 2008-03-16 01:37 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d69e411f0711 6618387: SSL client sessions do not close cleanly. A TCP reset occurs instead of a close_notify alert. Summary: closeIdelConnection() does not query the cached connection correctly. Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/https/HttpsClient.java + test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java Changeset: 73f50a1c8634 Author: xuelei Date: 2008-03-16 23:46 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/73f50a1c8634 6542796: CPU issue with JSSE and tomcat Summary: record length count error Reviewed-by: weijun ! src/share/classes/sun/security/ssl/InputRecord.java Changeset: 280a7b75cd39 Author: xuelei Date: 2008-03-17 03:11 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/280a7b75cd39 6447412: Issue with socket.close() for ssl sockets when poweroff on other system Summary: Support SSL sockets SOLINGER Reviewed-by: chegar ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java Changeset: f6905d8eee6e Author: wetmore Date: 2008-03-06 16:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f6905d8eee6e 6578538: com.sun.crypto.provider.SunJCE instance leak using KRB5 and LoginContext Reviewed-by: valeriep ! src/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java + test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java Changeset: 1cb78400acce Author: wetmore Date: 2008-03-17 11:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1cb78400acce Merge Changeset: 0f030deba7df Author: wetmore Date: 2008-03-17 12:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f030deba7df Merge From mandy.chung at sun.com Wed Mar 19 18:23:03 2008 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Wed, 19 Mar 2008 18:23:03 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20080319182339.8A62F26EDE@hg.openjdk.java.net> Changeset: f5853d8dab12 Author: mchung Date: 2008-03-18 11:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5853d8dab12 6658779: Regression: HotspotDiagnosticMXBean.getDiagnosticOptions() throws NullPointerException Summary: Add a null check for the VM option string Reviewed-by: alanb, tbell ! src/share/classes/sun/management/Flag.java + test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticOptions.java Changeset: b413d5d6cedc Author: mchung Date: 2008-03-18 12:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b413d5d6cedc 6672804: First line in com/sun/management/package.html is broken Summary: Fixed the typo in package.html Reviewed-by: jjh ! src/share/classes/com/sun/management/package.html Changeset: 3e2a5ab9c131 Author: mchung Date: 2008-03-19 11:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3e2a5ab9c131 Merge From eamonn.mcmanus at sun.com Wed Mar 19 14:18:18 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Wed, 19 Mar 2008 14:18:18 +0000 Subject: hg: jdk7/tl/jdk: 6675768: NoSuchElementException thrown in RequiredModelMBean when tracing enabled Message-ID: <20080319141830.4A15A26E97@hg.openjdk.java.net> Changeset: 0d4923ce2707 Author: emcmanus Date: 2008-03-19 15:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0d4923ce2707 6675768: NoSuchElementException thrown in RequiredModelMBean when tracing enabled Summary: Rewrite logging in RequiredModelMBean.addAttributeChangeNotificationListener Reviewed-by: dfuchs ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java + test/javax/management/modelmbean/LoggingExceptionTest.java From kumar.srinivasan at sun.com Thu Mar 20 20:56:00 2008 From: kumar.srinivasan at sun.com (kumar.srinivasan at sun.com) Date: Thu, 20 Mar 2008 20:56:00 +0000 Subject: hg: jdk7/tl/langtools: 6618930: (javac) fix test after whitespace normalization Message-ID: <20080320205602.3E29F26F41@hg.openjdk.java.net> Changeset: 058bdd3ca02e Author: ksrini Date: 2008-03-20 08:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/058bdd3ca02e 6618930: (javac) fix test after whitespace normalization Summary: whitespace normalization left the test unusable, back to service Reviewed-by: jjg ! test/tools/javac/6304921/T6304921.java ! test/tools/javac/6304921/T6304921.out From eamonn.mcmanus at sun.com Fri Mar 21 08:50:22 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Fri, 21 Mar 2008 08:50:22 +0000 Subject: hg: jdk7/tl/jdk: 6649542: Document explicitly in registerMBean etc that MBeanServerNotification is emitted Message-ID: <20080321085034.19AB026F4B@hg.openjdk.java.net> Changeset: 9a97ca4eb8b7 Author: emcmanus Date: 2008-03-21 09:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a97ca4eb8b7 6649542: Document explicitly in registerMBean etc that MBeanServerNotification is emitted Summary: Make spec more readable by adding cross-references. Suggested by Andrew Haley. Reviewed-by: dfuchs ! src/share/classes/javax/management/MBeanServer.java From eamonn.mcmanus at sun.com Fri Mar 21 17:08:37 2008 From: eamonn.mcmanus at sun.com (eamonn.mcmanus at sun.com) Date: Fri, 21 Mar 2008 17:08:37 +0000 Subject: hg: jdk7/tl/jdk: 6643627: JMX source code includes incorrect Java code Message-ID: <20080321170849.60B2026F50@hg.openjdk.java.net> Changeset: 01f7eeea81f1 Author: emcmanus Date: 2008-03-21 18:07 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/01f7eeea81f1 6643627: JMX source code includes incorrect Java code Summary: javac compiler bug accepts incorrect code; JMX code inadvertently has such code Reviewed-by: dfuchs ! src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java ! src/share/classes/java/beans/MetaData.java From eliasen at mindspring.com Tue Mar 25 06:46:59 2008 From: eliasen at mindspring.com (Alan Eliasen) Date: Tue, 25 Mar 2008 00:46:59 -0600 Subject: Further BigInteger performance improvements In-Reply-To: <47BCAD9C.1030002@mindspring.com> References: <47A14D21.8020807@mindspring.com> <47BB539B.8090901@mindspring.com> <87skzo6l5r.fsf@mid.deneb.enyo.de> <47BCAD9C.1030002@mindspring.com> Message-ID: <47E89FE3.6080203@mindspring.com> A few weeks ago, I posted some performance numbers for the improvements I'm making to the BigInteger class. Those performance numbers were for the Karatsuba multiplication algorithm that I implemented. I've now implemented 3-way Toom-Cook multiplication (and Toom-Cook squaring) which has better asymptotic performance than Karatsuba multiplication. (Karatsuba is O(n^1.585), 3-way Toom Cook is O(n^1.465). Compare this to Java 1.6 which used only O(n^2) algorithms.) One of the three algorithms are then chosen according to the size of the numbers. There's also a lot of room for doing asymmetrical Toom-Cook multiplication, with, say, one side being broken into 4 parts, and the other into 2 parts, but that's lower on my priority list. Since I haven't heard of any progress on including my previous patch, I'll be submitting a revised patch with Toom-Cook multiplication included soon. Below, interspersed among my previous statements, are some updated performance numbers with the Toom-Cook algorithm: Alan Eliasen wrote: > But some numbers. For multiplying the numbers 3^1000000 * 3^1000001, > (with my fixes to do the exponentiation hundreds of thousands of times > faster factored out; without these, JDK 1.6 would be thousands of times > slower,) the times for 20 iterations are: > > JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP > 292987 ms 28650 ms 866 ms With Toom/Cook: 18054 ms Performance improvement over Java 1.6: 16.2x > For multiplying numbers 3^14000000 * 3^14000001, the time for 1 > iteration is: > > JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP > 3499115 ms 89505 ms 910 ms With Toom/Cook: 43636 ms Performance improvement over Java 1.6: 80.18x -- Alan Eliasen | "Furious activity is no substitute eliasen at mindspring.com | for understanding." http://futureboy.us/ | --H.H. Williams From rdojdk at arcor.de Thu Mar 20 21:25:52 2008 From: rdojdk at arcor.de (rdojdk at arcor.de) Date: Thu, 20 Mar 2008 22:25:52 +0100 (CET) Subject: concatenated block serialization Message-ID: <15906731.1206048352983.JavaMail.ngmail@webmail11> Hi! A few years ago we had the problem that loading levels into the 3D game we where developing (in C++ but this part was plain C) was way to slow. There where just by far too many small objects that had to be loaded. We came up with a solution that I think might be applicable to serialization in the Java platform as well, although mainly for RMI and not so much for startup times. We wrote a tool that first loaded those small objects into one continuous block of memory. Second it made all pointers relative to the start of this memory block (effectively rendering them invalid) and recorded the address of those pointers in a list. Finally it wrote the block and the list to a file. Now loading was a snap: First we loaded the list into one block and the data block into another. Second we iterated over the list and added these pointer offsets to the base address of the data block to find the addresses of the pointers. Third we added the base address of the data block to them. This restored a completely working data block and we could release the pointer list block. The performance increase was stunning. In the Java world the JVM would have to do all of this itself. Possibly for all Serializable objects... and in fact it could be that it already does, making this post quite embarrassing for me ;-) If Java bytecode allowed for relative references, things where even easier! The main problem that I can see is about how to store the references to the classes that the objects are instances of. A straight forward solution would be to have a third block stored to disk: A map of class names to a list of these pointers' offsets. When deserializing, another loop would resolve the classes' address (maybe loading the class) and then assign that address to all pointers in the according list. BTW: Especially mobile devices could have flash memory mapped into address space. When data is stored there, then it may even be possible to use the data block directly: The relative pointers can already be correct as well as references to classes that are stored there as well. Actually there would be almost no deserialization any more! I would really appreciate any comment! Even if you think it's plain ridiculous or just the wrong list (I didn't find any more appropriate). Kind regards! R?diger zu Dohna Jetzt komfortabel bei Arcor-Digital TV einsteigen: Mehr Happy Ends, mehr Herzschmerz, mehr Fernsehen! Erleben Sie 50 digitale TV Programme und optional 60 Pay TV Sender, einen elektronischen Programmf?hrer mit Movie Star Bewertungen von TV Movie. Au?erdem, aktuelle Filmhits und prickelnde Erotik in der Arcor-Videothek. Infos unter www.arcor.de/tv From iris at sun.com Tue Mar 25 08:07:06 2008 From: iris at sun.com (iris clark) Date: Tue, 25 Mar 2008 00:07:06 -0800 (PST) Subject: CFV: Doug Lea to Membership in the Core Libraries Group Message-ID: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> Greetings, voting members of the Core Libraries Group! I hereby nominate Doug Lea to Membership in the Core Libraries Group. Please cast your vote by replying, publicly, to this message with either Vote: yes or Vote: no as the first line of the message body. You may, at your option, indicate the reason for your decision on subsequent lines. Votes must be cast in the open; votes sent as private replies will not be counted. Votes are due by midnight UTC next Monday, 31 March, after which time the votes will be tallied and reported to this list. Only Members of the Core Libraries are eligible to vote on this decision. The current Members are: Alan Bateman Christopher Hegarty David Bristor Iris Clark Jeff Nisewanger Joe Darcy Mark Reinhold Martin Buchholz Pete Soper Peter Jones Xueming Shen [1] http://blogs.sun.com/mr/entry/cosmology From Pete.Soper at Sun.COM Tue Mar 25 14:19:44 2008 From: Pete.Soper at Sun.COM (Pete Soper) Date: Tue, 25 Mar 2008 10:19:44 -0400 Subject: CFV: Doug Lea to Membership in the Core Libraries Group In-Reply-To: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> References: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> Message-ID: <47E90A00.9030701@sun.com> Vote: yes "We've been waiting for this for hundreds of years!" -Pete From martinrb at google.com Tue Mar 25 15:36:46 2008 From: martinrb at google.com (Martin Buchholz) Date: Tue, 25 Mar 2008 08:36:46 -0700 Subject: CFV: Doug Lea to Membership in the Core Libraries Group In-Reply-To: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> References: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> Message-ID: <1ccfd1c10803250836o2f13b698yb986fec1f2dd6102@mail.gmail.com> Vote: yes Martin -------------- next part -------------- An HTML attachment was scrubbed... URL: From David.Bristor at Sun.COM Tue Mar 25 16:45:52 2008 From: David.Bristor at Sun.COM (Dave Bristor) Date: Tue, 25 Mar 2008 09:45:52 -0700 Subject: CFV: Doug Lea to Membership in the Core Libraries Group In-Reply-To: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> References: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> Message-ID: <47E92C40.1030403@sun.com> Vote: yes Dave iris clark wrote: > Greetings, voting members of the Core Libraries Group! > > I hereby nominate Doug Lea to Membership in the Core Libraries Group. > > Please cast your vote by replying, publicly, to this message with > either > > Vote: yes > > or > > Vote: no > > as the first line of the message body. > > You may, at your option, indicate the reason for your decision on > subsequent lines. > > Votes must be cast in the open; votes sent as private replies will > not be counted. > > Votes are due by midnight UTC next Monday, 31 March, after which time > the votes will be tallied and reported to this list. > > Only Members of the Core Libraries are eligible to vote on this > decision. The current Members are: > > Alan Bateman > Christopher Hegarty > David Bristor > Iris Clark > Jeff Nisewanger > Joe Darcy > Mark Reinhold > Martin Buchholz > Pete Soper > Peter Jones > Xueming Shen > > [1] http://blogs.sun.com/mr/entry/cosmology From mr at sun.com Tue Mar 25 19:55:10 2008 From: mr at sun.com (Mark Reinhold) Date: Tue, 25 Mar 2008 12:55:10 -0700 Subject: CFV: Doug Lea to Membership in the Core Libraries Group In-Reply-To: iris@sun.com; Tue, 25 Mar 2008 00:07:06 -0800; <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> Message-ID: <20080325195510.B09B25B656@eggemoggin.niobe.net> Vote: yes (Duh!) - Mark From martinrb at google.com Tue Mar 25 21:08:37 2008 From: martinrb at google.com (Martin Buchholz) Date: Tue, 25 Mar 2008 14:08:37 -0700 Subject: JNI-performance - Is it really that fast? In-Reply-To: <194f62550803251257w64670b87v421d9ad1c9ddf182@mail.gmail.com> References: <194f62550803210525q64f47512p293d3227583ce2d6@mail.gmail.com> <47E82C3D.3030106@Sun.COM> <47E8FE5A.5020605@sun.com> <194f62550803251257w64670b87v421d9ad1c9ddf182@mail.gmail.com> Message-ID: <1ccfd1c10803251408u1f4e3ab8i6b2f60255d897b87@mail.gmail.com> BTW, The implementation of ReentrantReadWriteLock is being changed significantly by the not-yet-integrated changes for *Synopsis* Excessive ThreadLocal storage used by ReentrantReadWriteLock http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6625723 which may make your particular workload faster (hopefully!) or slower. Martin On Tue, Mar 25, 2008 at 12:57 PM, Clemens Eisserer wrote: > Hi again, > > Thanks a lot for the valueable feedback :) > > > Biased locking is enabled 4 seconds after startup. > Thanks a lot Christian and greetings from Austria! > With your suggested flag the synchronization-overhead with > BiasedLocking shrinks to about 10-20% on my Dual-Core machine down > from a few hundred percent. > Do you know wether ReentrantLock could also be optimized to use > BiasedLocking? In my use-case most likely one thread will > aquire/release the lock again and again, maybe from time to time > another thread will aquire it, but rather seldom. > > > Our per primitive cost is still mostly > > consists of jni overhead for small primitives (think > > fillRect(1x1)). > For my fillRect(1x1) test the locking of AWT's ReentrantLock was far > more expensive than the JNI overhead even with almost no contention. > That was for a VolatileImage, on a Dual-Core machine, on a single-core > machine I tested on the hit was much smaller. > > > In the meantime the people who believe jni performance is very good > > please continue to speak up as I'm sure the vm engineers who have > > worked > > to improve this path over the years will appreciate the feedback. :-) > Its really impressive, congratulations and thanks to the vm engineers > who made that possible :) ;) > > Thanks a lot, lg Clemens > -------------- next part -------------- An HTML attachment was scrubbed... URL: From peter.jones at sun.com Wed Mar 26 03:54:13 2008 From: peter.jones at sun.com (Peter Jones) Date: Tue, 25 Mar 2008 23:54:13 -0400 Subject: CFV: Doug Lea to Membership in the Core Libraries Group In-Reply-To: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> References: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> Message-ID: <20080326035413.GC26654@east> Vote: yes -- Peter From tim.bell at sun.com Thu Mar 27 19:18:21 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 27 Mar 2008 19:18:21 +0000 Subject: hg: jdk7/tl: 4 new changesets Message-ID: <20080327191821.504452721A@hg.openjdk.java.net> Changeset: be0ea51b2743 Author: ohair Date: 2008-03-05 18:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/be0ea51b2743 6662830: OpenJDK build testing results Summary: Small corrections in the README. Reviewed-by: xdono ! README-builds.html Changeset: d83470fdf495 Author: ohair Date: 2008-03-09 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d83470fdf495 6649270: Change by-default openjdk building in control/make/makefile to use open source tree Summary: Change build rules to allow for openjdk builds by default when building the closed or production build. Reviewed-by: xdono ! Makefile ! make/Defs-internal.gmk Changeset: d6b08bdb9a54 Author: ohair Date: 2008-03-09 15:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d6b08bdb9a54 6649672: Adjustments to OUTPUTDIR default and mkdirs to avoid empty directory clutter Summary: Cleanup of OUTPUTDIR handling Reviewed-by: xdono ! Makefile Changeset: f769c64f71ac Author: ohair Date: 2008-03-13 16:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/f769c64f71ac 6675289: Make default production build NOT include an openjdk build Summary: SKIP_OPENJDK_BUILD now set to true. Reviewed-by: xdono ! make/Defs-internal.gmk From tim.bell at sun.com Thu Mar 27 19:18:42 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 27 Mar 2008 19:18:42 +0000 Subject: hg: jdk7/tl/corba: 6624808: corba makefiles not using langtools compiler Message-ID: <20080327191844.1A77E2721F@hg.openjdk.java.net> Changeset: a51017b6ba6d Author: ohair Date: 2008-03-06 13:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a51017b6ba6d 6624808: corba makefiles not using langtools compiler Summary: If supplied, the langtools javac should be used. Reviewed-by: xdono ! make/common/shared/Defs.gmk From tim.bell at sun.com Thu Mar 27 19:20:20 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 27 Mar 2008 19:20:20 +0000 Subject: hg: jdk7/tl/jaxp: 6652588: Fix broken JPRT makefile target, no bundle saved Message-ID: <20080327192022.D7C5627226@hg.openjdk.java.net> Changeset: a3b3ba7d6034 Author: ohair Date: 2008-03-04 10:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/a3b3ba7d6034 6652588: Fix broken JPRT makefile target, no bundle saved Summary: jprt make rules missing the bundle up of the output Reviewed-by: xdono ! make/Makefile From tim.bell at sun.com Thu Mar 27 19:20:45 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 27 Mar 2008 19:20:45 +0000 Subject: hg: jdk7/tl/jaxws: 6652588: Fix broken JPRT makefile target, no bundle saved Message-ID: <20080327192047.4DED22722B@hg.openjdk.java.net> Changeset: 59fd8224ba2d Author: ohair Date: 2008-03-04 10:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/59fd8224ba2d 6652588: Fix broken JPRT makefile target, no bundle saved Summary: jprt make rules were missing the bundle logic Reviewed-by: xdono ! make/Makefile From tim.bell at sun.com Thu Mar 27 19:21:32 2008 From: tim.bell at sun.com (tim.bell at sun.com) Date: Thu, 27 Mar 2008 19:21:32 +0000 Subject: hg: jdk7/tl/jdk: 43 new changesets Message-ID: <20080327193020.6425427232@hg.openjdk.java.net> Changeset: e4f19efd20b4 Author: ohair Date: 2008-03-04 09:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4f19efd20b4 6654456: OpenJDK build problem with freetype makefiles Summary: ifdef test on OPENJDK before it gets set based on source tree contents Reviewed-by: xdono ! make/common/shared/Platform.gmk Changeset: 80486f9d9221 Author: ohair Date: 2008-03-04 09:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/80486f9d9221 6637583: Build failure on latest Solaris, source missing include of resource.h? Summary: The include of sys/resource.h must be explicit Reviewed-by: xdono ! src/solaris/hpi/native_threads/src/sys_api_td.c Changeset: 929222887724 Author: ohair Date: 2008-03-04 09:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/929222887724 6638571: Fix freetype sanity check to work on solaris 64bit Summary: Missing -xarch options to build for 64bit Reviewed-by: xdono ! make/tools/freetypecheck/Makefile Changeset: 12b0d64c4953 Author: ohair Date: 2008-03-04 09:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/12b0d64c4953 6638060: Build failed with GNU make 3.81 (part of latest Solaris 'gmake') Summary: Changes to the way GNU make 3.81 deals with the env variable SHELL Reviewed-by: xdono ! make/java/nio/Makefile ! make/java/nio/genCharsetProvider.sh ! make/java/nio/genExceptions.sh Changeset: 82c85cfd8402 Author: ohair Date: 2008-03-04 09:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/82c85cfd8402 6668781: Openjdk windows cygwin build failure: no rule to make linker_md.obj target Summary: Use of GNU make vpath breaks on windows with C:/ style fullpaths Reviewed-by: xdono ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk Changeset: 65c8fd93d01c Author: ohair Date: 2008-03-06 11:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/65c8fd93d01c 6628146: Exclude the .hgignore and .hgtags files from the source bundles Summary: Just add to list of SCM files. Reviewed-by: xdono ! make/common/shared/Platform.gmk Changeset: 48d06b4c6460 Author: ohair Date: 2008-03-09 14:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48d06b4c6460 6672777: Broken deploy build from jdk fix 6668781 for cygwin windows Summary: deploy workspace does not set BUILDDIR, uses it, assumes it is jdk/make. Reviewed-by: xdono ! make/common/Defs.gmk Changeset: 8ef9fd5c28fd Author: ohair Date: 2008-03-10 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8ef9fd5c28fd 6649672: Adjustments to OUTPUTDIR default and mkdirs to avoid empty directory clutter Summary: OUTPUTDIR changes to make sure absolute path is correct. Reviewed-by: xdono ! make/common/Defs.gmk ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs.gmk Changeset: dd6765f87558 Author: tbell Date: 2008-03-17 22:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dd6765f87558 Merge Changeset: 9ae056d2cffd Author: tbell Date: 2008-03-17 23:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9ae056d2cffd Merge Changeset: e0d783c556fc Author: son Date: 2008-03-13 15:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0d783c556fc 6595651: Focus transfers broken for applications embedding AWT across processes Summary: Now we allow cross-process focus requests if focus is in embedder's process. Reviewed-by: ant ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h Changeset: 367edeff526e Author: son Date: 2008-03-13 16:12 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/367edeff526e 6616095: AWT's WindowDisposerRecord keeps AppContext alive too long Summary: WindowDisposerRecord should not keep strong reference to AppContext. Reviewed-by: art ! src/share/classes/java/awt/Window.java Changeset: e4e71142754b Author: son Date: 2008-03-13 16:19 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4e71142754b 6632140: minor refactoring for XWM Summary: code cleanup and generificaion for XWM Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWM.java Changeset: dc7dfc7d15ba Author: son Date: 2008-03-13 16:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc7dfc7d15ba 6592751: EmbeddedFrame disposal is fragile and breaks clean AppContext termination Summary: AppContext.dispose() should be ready to get exceptions during disposal of toplevels. Also now we mark windows peers as destroyed when native object has been destroyed. Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java ! src/windows/classes/sun/awt/windows/WObjectPeer.java ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Object.cpp ! src/windows/native/sun/windows/awt_Object.h Changeset: 619d2d592b88 Author: son Date: 2008-03-13 16:32 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/619d2d592b88 6603256: Startup: Defer initialization of DropTarget's flavorMap Summary: SystemFlavorMap is lazily initialized now. Reviewed-by: uta ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/java/awt/dnd/DropTarget.java Changeset: f3377ab93ee8 Author: son Date: 2008-03-13 16:42 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3377ab93ee8 6607163: Linux: Cannot copy image from Java to OpenOffice Summary: TARGETS should have type ATOM Reviewed-by: denis ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: bbd8e20d5052 Author: son Date: 2008-03-13 16:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbd8e20d5052 6636369: sun.awt.datatransfer.DataTransferer contains double-check idiom Summary: double-check has been removed Reviewed-by: dav ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: c9ee9428aea9 Author: son Date: 2008-03-13 16:51 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c9ee9428aea9 6636331: ConcurrentModificationException in AppContext code Summary: Added synchronization to AppContext.getAppContexts() Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java Changeset: 86a5780cad99 Author: son Date: 2008-03-13 16:54 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86a5780cad99 6636370: minor corrections and simplification of code in AppContext Summary: mainAppContext, isDisposed, and numAppContexts has beem made volatile. mostRecentThreadAppContext has been rewritten using ThreadLocal. Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java Changeset: 026144f0d26a Author: son Date: 2008-03-13 16:56 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/026144f0d26a 6636368: XAtom contains unused code Summary: unused code has been removed Reviewed-by: dcherepanov ! src/solaris/classes/sun/awt/X11/XAtom.java Changeset: 63f02cc8ff3d Author: son Date: 2008-03-13 17:04 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63f02cc8ff3d 6645885: small refactoring for XContentWindow Summary: move createContent() method from XDecoratedPeer to XContentWindow, so only XContentWindow keep information about the way we position it. Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java Changeset: d9fb87af8b07 Author: son Date: 2008-03-13 17:08 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9fb87af8b07 6645856: static field XWindowPeer.defaultFont hides XWindow.defaultFont Summary: unnedded code has been removed. Added getter for XWindow.defaultFont to initialize it lazily. Reviewed-by: dav ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XMenuItemPeer.java ! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: 176e1fe7dead Author: son Date: 2008-03-13 17:14 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/176e1fe7dead 6538066: XSelection should be more passive Summary: Now only XClipboard know about XSelection, and XSelection knows nothing about XClipboard. Reviewed-by: uta, denis ! src/solaris/classes/sun/awt/X11/MotifDnDConstants.java ! src/solaris/classes/sun/awt/X11/MotifDnDDropTargetProtocol.java + src/solaris/classes/sun/awt/X11/OwnershipListener.java ! src/solaris/classes/sun/awt/X11/XClipboard.java ! src/solaris/classes/sun/awt/X11/XDnDConstants.java ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: fa0dc97ef9a0 Author: dcherepanov Date: 2008-03-14 17:23 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa0dc97ef9a0 6522731: Location of the frame changes,when the frame is resized & non-resized. Summary: XMoveWindow() should use shell's location Reviewed-by: son ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java Changeset: 296b6e29a99d Author: dcherepanov Date: 2008-03-14 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/296b6e29a99d 6612497: api/java_awt/Container/index.html#isAncestorOf Container2019 hangs since JDK 7 b15 Summary: Partial rollback changes for 6567564 in the Component.getGC method Reviewed-by: art, son ! src/share/classes/java/awt/Component.java Changeset: 5ac897d182a6 Author: dcherepanov Date: 2008-03-14 18:50 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5ac897d182a6 6603010: Out-of-process Java Plug-In non-functional or barely functional on X11 platforms Summary: AWT XEmbed shouldn't use _SUN_XEMBED_START message Reviewed-by: art, son ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java Changeset: 92e3f57c933b Author: dcherepanov Date: 2008-03-14 20:40 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92e3f57c933b 6524352: support for high-resolution mouse wheel Summary: added support for high-resolution mouse wheel Reviewed-by: dav, son ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/event/MouseWheelEvent.java ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h + test/java/awt/event/MouseEvent/SmoothWheel/SmoothWheel.java Changeset: 15ba7093f8e6 Author: dcherepanov Date: 2008-03-14 22:00 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15ba7093f8e6 6578583: Regression: Modality is broken in windows vista home premium from jdk1.7 b02 onwards. Summary: WS_DISABLED style should be used to fix some modality bugs Reviewed-by: art, son ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h + test/java/awt/Modal/WsDisabledStyle/CloseBlocker/CloseBlocker.java + test/java/awt/Modal/WsDisabledStyle/OverBlocker/OverBlocker.java + test/java/awt/Modal/WsDisabledStyle/Winkey/Winkey.java Changeset: 9f51e4e1251e Author: anthony Date: 2008-03-18 12:04 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f51e4e1251e 6608764: PropertyChangeListeners machinery should have a better locking scheme Summary: Change to use a private final object java.awt.Component.changeSupportLock for locking purposes instead of using this Reviewed-by: son, ant ! src/share/classes/java/awt/Component.java Changeset: 9b6848cf363c Author: anthony Date: 2008-03-18 13:53 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b6848cf363c 6613927: Compilation of splashscreen png library failed on Ubuntu 7.04 (64bit) Summary: The macro PNG_NO_MMX_CODE should be defined when compiling on 64bit Linux Reviewed-by: yan, avu ! make/sun/splashscreen/Makefile Changeset: fd7f2562ea00 Author: anthony Date: 2008-03-18 14:10 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd7f2562ea00 6607660: java.awt.Container.getMouseEventTargetImpl should be invoked while holding the TreeLock Summary: The body of the method has been wrapped into the synchronized (getTreeLock()) { } block. Reviewed-by: son, art ! src/share/classes/java/awt/Container.java Changeset: e8b40b676b89 Author: anthony Date: 2008-03-18 14:20 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8b40b676b89 6637796: setBounds doesn't enlarge Component Summary: Added the areBoundsValid() method that verifies whether the current bounds of the component are valid. Using the isValid() method for this purpose previously was incorrect. Reviewed-by: son, art ! src/share/classes/java/awt/Component.java + test/java/awt/Mixing/ValidBounds.java Changeset: 9306c5d6344f Author: anthony Date: 2008-03-18 14:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9306c5d6344f 6304277: PIT: Adding a TrayIcon closes a SplashScreen on Solaris but not on Win32 Summary: The Window.closeSplashScreen() method now verified the boolean flag isTrayIconWindow, and returns if it is true. Reviewed-by: son, dcherepanov ! src/share/classes/java/awt/Window.java Changeset: fc0164db7a3b Author: anthony Date: 2008-03-18 15:07 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc0164db7a3b 6581927: REG : Non focusable frame can be minimized to very small & Frame icon can be seen on frame buttons. Summary: The SWP_NOSENDCHANGING flag should not be passed to the ::SetWindowPos() WinAPI function when we receive the WM_MOUSEMOVE message while manually handling the resizing of non-focusable frames. Reviewed-by: son, ant ! src/windows/native/sun/windows/awt_Frame.cpp + test/java/awt/Focus/NonFocusableResizableTooSmall/NonFocusableResizableTooSmall.java Changeset: 8a57a0be2a97 Author: anthony Date: 2008-03-18 16:19 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8a57a0be2a97 6589527: Window and Frame instances can hide their "Applet Warning" Summary: Additional constraints have been added for the setBounds() operation. Reviewed-by: son, art ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDialogPeer.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/motif/MDialogPeer.java ! src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/motif/MFramePeer.java ! src/solaris/classes/sun/awt/motif/MWindowPeer.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h Changeset: 241fd18949db Author: anthony Date: 2008-03-20 11:09 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/241fd18949db 4993545: NativeInLightFixer adds asynchronousity Summary: All the hooks related to the NativeInLightFixer have been moved to the HW/LW mixing handling methods. The NativeInLightFixer itself has been removed. Reviewed-by: son, alexp ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java Changeset: 51c761339b1c Author: ant Date: 2008-03-19 16:23 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/51c761339b1c 6567410: PIT : java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java fails Summary: A filter flag has been added to the HCBT focus hook. Reviewed-by: dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 810904060acf Author: ant Date: 2008-03-20 14:26 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/810904060acf Merge Changeset: 92e9ac30618a Author: son Date: 2008-03-20 16:21 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92e9ac30618a 6630878: clean target in sun/xawt is incomplete Summary: clean target should remove .gen_icons Reviewed-by: yan ! make/sun/xawt/Makefile Changeset: 82233ac3d09f Author: ant Date: 2008-03-20 18:06 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/82233ac3d09f 6598089: JDK 7: AWT often goes into busy loop when showing dialog Summary: Preventing focus from getting in an endless loop. Reviewed-by: son ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java + test/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java Changeset: dbff1fcf1767 Author: ant Date: 2008-03-21 09:54 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dbff1fcf1767 6599270: Using EmbeddedFrame in SWT leads to a hang Summary: Excluding EmbeddedFrame from the workaround of activating a toplevel in not foreground process. Reviewed-by: son ! src/windows/native/sun/windows/awt_Frame.cpp Changeset: 0f955581dc0b Author: yan Date: 2008-03-24 06:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f955581dc0b Merge Changeset: 75b405bff406 Author: tbell Date: 2008-03-27 10:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75b405bff406 Merge From eliasen at mindspring.com Fri Mar 28 07:14:35 2008 From: eliasen at mindspring.com (Alan Eliasen) Date: Fri, 28 Mar 2008 01:14:35 -0600 Subject: [UPDATED PATCH] 4837946: Implement Karatsuba multiplication algorithm in BigInteger In-Reply-To: <47BB539B.8090901@mindspring.com> References: <47A14D21.8020807@mindspring.com> <47BB539B.8090901@mindspring.com> Message-ID: <47EC9ADB.5000301@mindspring.com> Attached is an UPDATED patch for bug 4837946, for implementing asymptotically faster algorithms for multiplication of large numbers in the BigInteger class: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4837946 The difference between this patch and the one posted earlier are: * This patch now also implements 3-way Toom-Cook multiplication and 3-way Toom-Cook squaring in addition to the Karatsuba squaring. 3-way Toom-Cook multiplication has an asymptotic efficiency of O(n^1.465), compared to O(n^1.585) for Karatsuba and O(n^2) for the "grade-school" algorithm, making it significantly faster for very large numbers. * Thresholds for various multiplications were slightly modified for better performance. The lower limit for Karatsuba multiplication is now 45 ints (1440 bits), and the lower limit for 3-way Toom-Cook multiplication is now 85 ints (2720 bits). * Threshholds for squaring were changed. Karatsuba squaring is used at 100 ints (3200 bits) and 3-way Toom-Cook squaring is at 190 ints (6080 bits.) This has been extensively tested. My regression tests are probably significant overkill for Sun's purposes. They take about 30 hours to run and produce about 232 gigabytes of output. (Multiply each of those numbers by 2 because you have to run it twice to compare the outputs of different VMs, and then compare output.) Again, my question is: how much time and space is acceptable for regression tests? I posed this before, but didn't get an answer. This patch contains only multiplication- and squaring-related patches. I will be submitting another patch of my changes to make the pow() function very much faster, but that will be a separate patch. For those who'd rather just replace their BigInteger with my much faster version, that also contains my patches for pow(), it's available at: http://futureboy.us/temp/BigInteger.java Note that my version of pow() will probably change somewhat before submission, but this current version works perfectly and is faster for most arguments. It's gotten slightly slower for some mid-size arguments, which is what I will be fixing. Previous patch report follows: > This patch implements Karatsuba multiplication and Karatsuba squaring > for numbers above a certain size (found by experimentation). These > patches are designed to be as easy to read as possible, and are > implemented in terms of already-existing methods in BigInteger. Some > more performance might be squeezed out of them by doing more low-level > bit-fiddling, but I wanted to get a working version in and tested. > > This is quite a bit faster for large arguments. The crossover point > between the "grade-school" algorithm and the Karatsuba algorithm for > multiplication is set at 35 "ints" or about 1120 bits, which was found > to give the best crossover in timing tests, so you won't see improvement > below that. Above that, it's asymptotically faster. (O(n^1.585), > compared to O(n^2)) for the grade-school algorithm. Double the number > of digits, and the "grade school" algorithm takes about 4 times as long, > Karatsuba takes about 3 times as long. It's vastly superior for very > large arguments. > > I'd also like to create another RFE for implementing even faster > multiplication algorithms for yet larger numbers, such as Toom-Cook. > > Previously, I had indicated that I'd submit faster algorithms for > pow() at the same time, but the number of optimizations for pow() has > grown rather large, and I plan on working on it a bit more and > submitting it separately. Many/most combinations of operands for pow() > are now vastly faster (some hundreds of thousands of times,) but I'd > like to make it faster (or, at the least, the same performance for all > arguments, a few of which have gotten slightly slower.) Unfortunately, > these optimizations add to the size and complexity of that patch, which > is why I'm submitting it separately. > > I have created regression tests that may or may not be what you want; > they simply multiply a very large bunch of numbers together and output > their results to a very large file, which you then "diff" against known > correct values. (My tests produce 345 MB of output per run!) I > validated the results by comparing them to the output of both JDK 1.6 > and the Kaffe JVM, which was compiled to use the well-known and > widely-tested GMP libraries for its BigInteger work. All tests pass. I > haven't submitted these tests, but am awaiting getting a copy of the > existing regression tests that Joseph Darcy discussed on this list. > > Please let me know if there's a problem with the patch. I had to > hand-edit a few lines to remove the work I'm doing for pow(). -- Alan Eliasen | "Furious activity is no substitute eliasen at mindspring.com | for understanding." http://futureboy.us/ | --H.H. Williams -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: BigInteger.diff URL: From Joe.Darcy at Sun.COM Fri Mar 28 08:08:19 2008 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Fri, 28 Mar 2008 01:08:19 -0700 Subject: Further BigInteger performance improvements In-Reply-To: <47E89FE3.6080203@mindspring.com> References: <47A14D21.8020807@mindspring.com> <47BB539B.8090901@mindspring.com> <87skzo6l5r.fsf@mid.deneb.enyo.de> <47BCAD9C.1030002@mindspring.com> <47E89FE3.6080203@mindspring.com> Message-ID: <47ECA773.60108@sun.com> Alan Eliasen wrote: [snip] > Since I haven't heard of any progress on including my previous patch, Sorry, still saturated with OpenJDK 6, -Joe From Alan.Bateman at Sun.COM Fri Mar 28 11:08:14 2008 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Fri, 28 Mar 2008 11:08:14 +0000 Subject: CFV: Doug Lea to Membership in the Core Libraries Group In-Reply-To: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> References: <200803250807.m2P87622008357@ribbit.SFBay.Sun.COM> Message-ID: <47ECD19E.5040302@sun.com> Vote: yes -Alan From daniel.daugherty at sun.com Thu Mar 27 23:07:16 2008 From: daniel.daugherty at sun.com (daniel.daugherty at sun.com) Date: Thu, 27 Mar 2008 23:07:16 +0000 Subject: hg: jdk7/tl/jdk: 17 new changesets Message-ID: <20080327231045.067E5272A2@hg.openjdk.java.net> Changeset: 7dd94e5bbec4 Author: dcubed Date: 2008-03-24 14:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dd94e5bbec4 6239043: 4/4 TransformerManagementThreadAddTests.java failed Summary: Clear fCheckedTransformers in order to properly record transformer() call data. Reviewed-by: sspitsyn ! test/java/lang/instrument/TransformerManagementThreadAddTests.java Changeset: d3dc2ede62ed Author: dcubed Date: 2008-03-24 14:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3dc2ede62ed 4926961: 4/4 TransformerManagementThreadRemoveTests hangs Summary: Changes motivated by Effective Java - Item 48 & Item 51. Reviewed-by: sspitsyn ! test/java/lang/instrument/TransformerManagementThreadAddTests.java ! test/java/lang/instrument/TransformerManagementThreadRemoveTests.java Changeset: bca8bf23ac59 Author: dcubed Date: 2008-03-24 15:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bca8bf23ac59 5088398: 3/2 java.lang.instrument TCK test deadlock (test11) Summary: Add regression test for single-threaded bootstrap classloader. Reviewed-by: sspitsyn + test/java/lang/instrument/ParallelTransformerLoader.sh + test/java/lang/instrument/ParallelTransformerLoaderAgent.java + test/java/lang/instrument/ParallelTransformerLoaderApp.java + test/java/lang/instrument/TestClass1.java + test/java/lang/instrument/TestClass2.java + test/java/lang/instrument/TestClass3.java Changeset: 114854ebaa21 Author: dcubed Date: 2008-03-24 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/114854ebaa21 6274276: 3/2 java.lang.instrument JAR manifest processing does not remove spaces from class names Summary: Attribute values should be extracted without leading or trailing whitespace. Reviewed-by: ohair, sspitsyn ! src/share/instrument/JarFacade.c + test/java/lang/instrument/ManifestTest.sh + test/java/lang/instrument/ManifestTestAgent.java + test/java/lang/instrument/ManifestTestApp.java Changeset: d4cd9e6a72da Author: dcubed Date: 2008-03-24 15:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d4cd9e6a72da 6289149: 4/4 Java Agent will pick wrong execution path while attaching Summary: Check for a declared premain() or agentmain() method before an inherited one Reviewed-by: sspitsyn ! src/share/classes/sun/instrument/InstrumentationImpl.java ! test/java/lang/instrument/PremainClass/DummyMain.java + test/java/lang/instrument/PremainClass/InheritAgent0001.java + test/java/lang/instrument/PremainClass/InheritAgent0010.java + test/java/lang/instrument/PremainClass/InheritAgent0011.java + test/java/lang/instrument/PremainClass/InheritAgent0100.java + test/java/lang/instrument/PremainClass/InheritAgent0101.java + test/java/lang/instrument/PremainClass/InheritAgent0110.java + test/java/lang/instrument/PremainClass/InheritAgent0111.java + test/java/lang/instrument/PremainClass/InheritAgent1000.java + test/java/lang/instrument/PremainClass/InheritAgent1001.java + test/java/lang/instrument/PremainClass/InheritAgent1010.java + test/java/lang/instrument/PremainClass/InheritAgent1011.java + test/java/lang/instrument/PremainClass/InheritAgent1100.java + test/java/lang/instrument/PremainClass/InheritAgent1101.java + test/java/lang/instrument/PremainClass/InheritAgent1110.java + test/java/lang/instrument/PremainClass/InheritAgent1111.java + test/java/lang/instrument/PremainClass/NoPremainAgent.java + test/java/lang/instrument/PremainClass/NoPremainAgent.sh + test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.java + test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh Changeset: 8c1c6c50dd36 Author: dcubed Date: 2008-03-24 15:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c1c6c50dd36 6487488: 3/5 TEST_BUG: Something in test/java/lang/instrument creates a copy of an SCCS dir Summary: Only copy Java source files from ilib and bootreporter. Reviewed-by: sspitsyn ! test/java/lang/instrument/MakeJAR2.sh Changeset: e6e301984a4a Author: dcubed Date: 2008-03-24 15:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e6e301984a4a 6491461: 3/3 TEST: java/lang/instrument .sh tests need to use $TESTVMOPTS in their java commands Summary: Add ${TESTVMOPTS} to java test execution command(s). Reviewed-by: sspitsyn ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/PremainClass/PremainClassTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh Changeset: ebe8adae32b9 Author: dcubed Date: 2008-03-24 16:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ebe8adae32b9 6528548: 4/4 NativeMethodPrefixAgent.java times out intermittently in nightly Summary: Increase timeouts for tasks that take > 10 seconds on a 4-way Ultra-80 with all local resources. Reviewed-by: sspitsyn ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/NativeMethodPrefixAgent.java ! test/java/lang/instrument/RetransformAgent.java ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh Changeset: 31959ddaf501 Author: dcubed Date: 2008-03-24 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31959ddaf501 6545149: 4/4 JLI Instrumentation.redefineClasses SIGSEGVs on java/lang/Thread Summary: Add regression test for redefining class with native methods. Reviewed-by: sspitsyn + test/java/lang/instrument/RedefineClassWithNativeMethod.sh + test/java/lang/instrument/RedefineClassWithNativeMethodAgent.java + test/java/lang/instrument/RedefineClassWithNativeMethodApp.java Changeset: 719789c7132c Author: dcubed Date: 2008-03-24 16:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/719789c7132c 6547358: 2/2 j.l.i.: manifest attribute 'Can-Retransform-Classes' is ignored by isRetransformClassesSupported() Summary: isRetransformClassesSupported() should return the capability rather than give the agent the capability Reviewed-by: ohair, sspitsyn ! src/share/instrument/JPLISAgent.c Changeset: ba825e4b1b8b Author: dcubed Date: 2008-03-24 16:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ba825e4b1b8b 6547500: 2/2 j.l.i.: .retransformClasses throws unexpected InternalError Summary: retransformClasses() should catch both an empty classes array and a classes array that contains a NULL element. Reviewed-by: ohair, sspitsyn ! src/share/instrument/JPLISAgent.c Changeset: 823abb444593 Author: dcubed Date: 2008-03-24 16:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/823abb444593 6642405: 4/4 src/share/instrument/JPLISAgent.c line 286: "==" found where assignment "=" expected Summary: Fix incorrect variable assignment in initializeJPLISAgent(). Reviewed-by: ohair, sspitsyn ! src/share/instrument/JPLISAgent.c Changeset: 9f75a46fad8b Author: dcubed Date: 2008-03-24 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f75a46fad8b 6572160: 3/3 Instrumentation.getObjectSize triggers JVM crash in JPLISAssert in shutdown Summary: Tolerate JVMTI_ERROR_WRONG_PHASE return codes so that JLI methods can be called to the end of VM's life. Reviewed-by: ohair, sspitsyn ! src/share/instrument/InvocationAdapter.c ! src/share/instrument/JPLISAgent.c ! src/share/instrument/JPLISAgent.h ! src/share/instrument/Reentrancy.c ! src/share/instrument/Utilities.c + test/java/lang/instrument/StressGetObjectSizeApp.java + test/java/lang/instrument/StressGetObjectSizeTest.sh Changeset: 9a804b6297c3 Author: dcubed Date: 2008-03-24 17:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a804b6297c3 6655234: 4/4 j.l.i.: setNativeMethodPrefix does not document that prefix string can be null Summary: Clarify wording for 'prefix' parameter to setNativeMethodPrefix(). Reviewed-by: sspitsyn ! src/share/classes/java/lang/instrument/Instrumentation.java Changeset: 1f45ae5ea94a Author: dcubed Date: 2008-03-24 17:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f45ae5ea94a 6667089: 3/3 multiple redefinitions of a class break reflection Summary: Add regression test for multiple redefinitions of a class break reflection. Reviewed-by: sspitsyn + test/java/lang/instrument/RedefineMethodAddInvoke.sh + test/java/lang/instrument/RedefineMethodAddInvokeAgent.java + test/java/lang/instrument/RedefineMethodAddInvokeApp.java + test/java/lang/instrument/RedefineMethodAddInvokeTarget.java + test/java/lang/instrument/RedefineMethodAddInvokeTarget_1.java + test/java/lang/instrument/RedefineMethodAddInvokeTarget_2.java Changeset: 7bf5f01e419d Author: dcubed Date: 2008-03-26 20:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7bf5f01e419d 6679866: 3/2 portability issues with JLI-batch-200803 on Win* Summary: Make minor tweaks to the fix for 6274276 to make the Win* compiler happy... Reviewed-by: sspitsyn, ohair ! src/share/instrument/JarFacade.c Changeset: 52c76fc0a3a9 Author: dcubed Date: 2008-03-27 14:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/52c76fc0a3a9 Merge