[PATCH 3/3] RFC: Adding Closeable to various JDK classes

David M. Lloyd david.lloyd at redhat.com
Thu May 1 15:09:41 UTC 2008


Add Closeable to MIDI and sound channel classes.  Though the close() method 
on these classes don't throw an exception, they still could implement this 
interface.

- DML

--

diff -r 92ea0ac77d2f src/share/classes/javax/sound/midi/MidiDevice.java
--- a/src/share/classes/javax/sound/midi/MidiDevice.java	Tue Apr 22 
18:58:40 2008 +0200
+++ b/src/share/classes/javax/sound/midi/MidiDevice.java	Thu May 01 
09:58:43 2008 -0500
@@ -26,6 +26,7 @@ package javax.sound.midi;
  package javax.sound.midi;

  import java.util.List;
+import java.io.Closeable;

   /**
   * <code>MidiDevice</code> is the base interface for all MIDI devices.
@@ -107,7 +108,7 @@ import java.util.List;
   * @author Florian Bomers
   */

-public interface MidiDevice {
+public interface MidiDevice extends Closeable {


      /**
diff -r 92ea0ac77d2f src/share/classes/javax/sound/midi/Receiver.java
--- a/src/share/classes/javax/sound/midi/Receiver.java	Tue Apr 22 18:58:40 
2008 +0200
+++ b/src/share/classes/javax/sound/midi/Receiver.java	Thu May 01 09:58:43 
2008 -0500
@@ -25,6 +25,8 @@

  package javax.sound.midi;

+import java.io.Closeable;
+

  /**
   * A <code>Receiver</code> receives <code>{@link MidiEvent}</code> 
objects and
@@ -38,7 +40,7 @@ package javax.sound.midi;
   *
   * @author Kara Kytle
   */
-public interface Receiver {
+public interface Receiver extends Closeable {


      //$$fb 2002-04-12: fix for 4662090: Contradiction in Receiver 
specification
diff -r 92ea0ac77d2f src/share/classes/javax/sound/midi/Transmitter.java
--- a/src/share/classes/javax/sound/midi/Transmitter.java	Tue Apr 22 
18:58:40 2008 +0200
+++ b/src/share/classes/javax/sound/midi/Transmitter.java	Thu May 01 
09:58:43 2008 -0500
@@ -25,6 +25,8 @@

  package javax.sound.midi;

+import java.io.Closeable;
+

  /**
   * A <code>Transmitter</code> sends <code>{@link MidiEvent}</code> 
objects to one or more
@@ -35,7 +37,7 @@ package javax.sound.midi;
   *
   * @author Kara Kytle
   */
-public interface Transmitter {
+public interface Transmitter extends Closeable {


      /**
diff -r 92ea0ac77d2f src/share/classes/javax/sound/sampled/Line.java
--- a/src/share/classes/javax/sound/sampled/Line.java	Tue Apr 22 18:58:40 
2008 +0200
+++ b/src/share/classes/javax/sound/sampled/Line.java	Thu May 01 09:58:43 
2008 -0500
@@ -24,6 +24,8 @@
   */

  package javax.sound.sampled;
+
+import java.io.Closeable;

  /**
   * The <code>Line</code> interface represents a mono or multi-channel
@@ -70,7 +72,7 @@ package javax.sound.sampled;
   * @see LineEvent
   * @since 1.3
   */
-public interface Line {
+public interface Line extends Closeable {

      /**
       * Obtains the <code>Line.Info</code> object describing this




More information about the core-libs-dev mailing list