Technical review was: [PATCH] Enhance ServiceLoader to understand factory methods
Alan Bateman
Alan.Bateman at Sun.COM
Tue Oct 21 14:25:29 UTC 2008
Jaroslav Tulach wrote:
> OK, so now, after Mark's reply, we know that it is possible to include such
> little, compatible extensions of an existing APIs into the Maintenance JSR.
> Good. Now please tell me, what shall I do to make it happen[1]?
>
> Will Mark or someone else from core-libs@ do a technical review of my patch?
> By when?
> -jst
>
> [1] I'd like my patch to not be dropped just because, we wait and wait and
> wait and then it will be "too late".
>
If it goes ahead then I'm happen to help get it to the finish line. One
thing I didn't see in the patch is the proposed spec updates -- ie:
updates to the class description to allow for the configuration file to
contain the names of static factory methods that create instances of the
service type. I also suspect we might have to re-visit other places that
make use of this facility. The reason is that most usages were
originally users of sun.misc.Service and so have their own descriptions
as to how their respective providers are loaded. Rather than duplicating
the description then it might be better to change them to reference
ServiceLoader.
-Alan.
More information about the core-libs-dev
mailing list