Logger.log should call getHandlers

swamy Swamy.Venkataramanappa at Sun.COM
Tue Apr 14 22:43:26 UTC 2009


Martin,

Good catch! Your fix looks good to me.
Bug id for this issue is:6830220).

-Swamy

Martin Buchholz wrote:
> Hi Swamy
>
> Our recent change
>
> changeset:   810:6eac3829cb41
> user:        martin
> date:        Tue Jan 27 15:04:30 2009 -0800
> summary:     6797480: Remove synchronization bottleneck in logger
>
> unfortunately introduced a serious bug.
>
> Logger.log should call Logger.getHandlers(), not Logger.handlers,
> because getHandlers may be overriden in a subclass.
> Notably, the root logger is such a subclass with a
> non-trivial getHandlers method.
>
> Here's the obvious fix, with a regression test that
> includes "penance" for our having broken j.u.l.
> by adding some much-needed  tests for never-before-exercised code.
>
> Please review and file a bug.
>
> PATCH is here:
> http://cr.openjdk.java.net/~martin/getHandlers
>
> Martin
>   




More information about the core-libs-dev mailing list