[PATCH FOR APPROVAL]: ReflectiveOperationException missing from FILES_java.gmk

Joseph D. Darcy Joe.Darcy at Sun.COM
Fri Aug 7 16:13:49 UTC 2009


Andrew John Hughes wrote:
> When java.lang.ReflectiveOperationException was added in:
>
> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/aaf0cb20646e
>
> it wasn't added to make/java/java/FILES_java.gmk.  Although it still
> seems to end up in rt.jar when building with IcedTea as the bootstrap
> JDK, it fails when using gcj+ecj (which we use in a full bootstrap).
>
> Is there any reason not to explicitly add the file like the others,
> rather than relying on the compiler to do so (or not as the case may
> be)?
>
> There's a webrev here:
> http://cr.openjdk.java.net/~andrew/roe/webrev.01/ with the 1 line fix.
>   

Hmm, curious.  Yes, it does seem the file belongs be on the list in 
FILES_java.gmk; the new class is a superclass of some of the exception 
classes on the list so it gets pulled in, at least by javac.

However, I'm a bit surprised at the use of such a list in the current build.

Kelly, I thought specifying files was generally done at a 
package/directory level now?  What kind of files need to go into 
FILES_java.gmk?

-Joe



More information about the core-libs-dev mailing list