zlib1.2.3

[Martin Buchholz]

On Tue, Aug 25, 2009 at 12:10, Xueming Shen<Xueming.Shen at sun.com> wrote:
> Thanks Martin1
>
> We are very close:-)
>
> Here is the latest webrev, compared to the last one, the only changes are
>
> (1)zcrc.c, the "compromised" change you approved.
> (2)undo any change in crc.h
> (3)a final tweak in zlib.h, this one is used by nobody and never exported.
> Just to make compile happy
>
>  21 -ZEXTERN const unsigned long FAR * ZEXPORT get_crc_table    OF((void));
>  22 +ZEXTERN const uLongf * ZEXPORT get_crc_table    OF((void));
>
> http://cr.openjdk.java.net/~sherman/zlib123/webrev
>
> Tests (all related jar/zip/pack/unpack tests, LargZip, jar c/x/t of
> large(>6g) zip, pack200/unpack200 of rt.jar,
> ZlibTest on all standard jdk jar lirbraries) have been done on Solaris
> sparc/i586 32-bit &64-bit, Linux 64-bit,
> Windows XpVista 32-bit and 2003 Server 64-bit. One last test is still
> running on a sparc 32-bit (jar up single > 6G file).
>
> Let me know if you guys are OK with  the latest one.

Yes, except one detail - the diffs are reversed.

Fix that and feel free to commit.

Regarding the timing - changes to jar/zip are always high risk,
so it is quite reasonable for this change to go in at the beginning of
a milestone cycle.

Martin