review request for 6798511/6860431: Include functionality of Surrogate in Character

Ulf Zibis Ulf.Zibis at gmx.de
Thu Aug 27 13:49:33 UTC 2009


Am 26.08.2009 21:01, Xueming Shen schrieb:
>
> > - Fixed ugly output of make/tools/src/build.tools.spp.Spp; (see 
> jdk1.7.0/src.zip)
>
> Ulf, those buf.append(LNSEP) lines serve the purpose of keeping the 
> code in the
> generated source file have exactly the same line number as they appear 
> in the
> original source file.

I have thought that before, but I _don't understand_ the *real value* 
against having "nice" code in externally delivered src.zip.
Some time ago it was always annoying to me when debugger ran in that 
code, or I was just looking, how it works. (endless scrolling and often 
I oversaw the tail behind numbers of blank lines (I don't have line 
numbers on in my editor)).
In contrast in generator output of SingleByte-X.java you don't care 
about line numbers, although it's in private sun package.

-Ulf





More information about the core-libs-dev mailing list