From martinrb at google.com Tue Dec 1 00:16:55 2009 From: martinrb at google.com (Martin Buchholz) Date: Mon, 30 Nov 2009 16:16:55 -0800 Subject: Gap Buffer based AbstractStringBuilder implementation In-Reply-To: References: <1ccfd1c10911252124n4d552126pd06df06b8ae77965@mail.gmail.com> <1ccfd1c10911252202sb58f917mbdfe45687fbf112f@mail.gmail.com> Message-ID: <1ccfd1c10911301616hed3bbe8u16f41273b9ce688f@mail.gmail.com> On Thu, Nov 26, 2009 at 00:57, Goktug Gokdogan wrote: > I think, we can overcome the slowdown. The point of my prototype is to check > the general performance characteristics. Slowdown is more likely due to the > poorly optimized extra method call to keep all logic in one place. Normally > the gap buffer algorithm should add only one comparison overhead to the > common case which will not to be observable in benchmarks. I am coming to like the gap buffer idea. You can optimize for append mode - append methods do not have to check for the existence or length of an internal gap. An extra comparison overhead is likely to be cheap, but it is nevertheless likely to be a measurable slowdown. But as I said, it more and more seems to me the right thing to do. If done right, StringBuilder can start to strongly resemble an Emacs buffer, and be useful for largish amounts of data with internal modifications. > I have?previously thought about implementing a similar?behavior?in other > array-based growing structures, but it is not worth it. You can easily use > your previous data structures for pre-appending algorithms - just by > appending to end and iterating from reverse. But you can't do that in a > StringBuilder because StringBuilder itself is the composed data. So, in my > opinion,?ArrayList is not a good analogy for this case. > StringBuilder, as its name suggests, is for building strings and building > string by appending to end is only one of the ways of doing it. > I think we should go for this if we can do it without an observable > slowdown. I didn't understand this argument. StringBuilder and ArrayList still seem to me conceptually similar. Martin > > On Thu, Nov 26, 2009 at 1:02 AM, Martin Buchholz > wrote: >> >> On Wed, Nov 25, 2009 at 21:24, Martin Buchholz >> wrote: >> > On Mon, Nov 23, 2009 at 22:51, Goktug Gokdogan >> > wrote: >> >> Nobody is interested or everybody is busy? >> > >> > I think there's a place for a StringBuilder-like >> > abstraction that uses a gap buffer, >> > but it shouldn't replace StringBuilder. >> >> Let me qualify that. >> >> It is hard to sell the small slowdown in the common case >> to make other (rare?) operations much faster. >> ArrayList should have been implemented to allow >> O(1) insert at both ends, like ArrayDeque, >> but it is hard to persuade the maintainers >> that such a change is worth making today, >> when the benchmarks all exercise only the common case. >> Similarily for a hypothetical GapArrayList. >> On the other hand, on modern cpus >> arithmetic is ever closer to being "free", >> so it is easier to justify the extra computation. >> >> Martin > > From kumar.srinivasan at sun.com Tue Dec 1 03:02:23 2009 From: kumar.srinivasan at sun.com (kumar.srinivasan at sun.com) Date: Tue, 01 Dec 2009 03:02:23 +0000 Subject: hg: jdk7/tl/jdk: 6367077: Purge LD_LIBRARY_PATH usage from the launcher; ... Message-ID: <20091201030307.06F7841932@hg.openjdk.java.net> Changeset: de45eac5670e Author: ksrini Date: 2009-11-20 11:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de45eac5670e 6367077: Purge LD_LIBRARY_PATH usage from the launcher 6899834: (launcher) remove the solaris libjvm.so symlink Summary: Fixes other related issues as well. Reviewed-by: darcy, ohair, xlu, martin ! make/java/jli/Makefile ! make/java/main/java/Makefile ! make/java/redist/Makefile ! src/share/bin/java.c ! src/solaris/bin/java_md.c ! test/tools/launcher/Arrrghs.java + test/tools/launcher/ExecutionEnvironment.java - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh ! test/tools/launcher/TestHelper.java - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java From kelly.ohair at sun.com Tue Dec 1 20:55:55 2009 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Tue, 01 Dec 2009 20:55:55 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20091201205705.6125841A57@hg.openjdk.java.net> Changeset: 026e0baaef90 Author: ohair Date: 2009-11-30 14:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/026e0baaef90 6903197: Some java template files need to be renamed to .java.template Reviewed-by: alanb ! make/java/java/Makefile ! make/java/java/genlocales.gmk ! make/java/java/localegen.sh ! make/java/nio/Makefile ! make/netbeans/README ! make/sun/nio/Makefile - make/tools/CharsetMapping/DoubleByte-X.java + make/tools/CharsetMapping/DoubleByte-X.java.template - make/tools/CharsetMapping/SingleByte-X.java + make/tools/CharsetMapping/SingleByte-X.java.template ! make/tools/src/build/tools/charsetmapping/GenerateDBCS.java ! make/tools/src/build/tools/charsetmapping/GenerateSBCS.java - src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java + src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java.template - src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java + src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java.template - test/java/util/Formatter/Basic-X.java + test/java/util/Formatter/Basic-X.java.template ! test/java/util/Formatter/genBasic.sh Changeset: 44ad385143a8 Author: ohair Date: 2009-12-01 08:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44ad385143a8 6905705: Fix broken exit code values in jdk/test/Makefile Reviewed-by: tbell ! test/Makefile ! test/ProblemList.txt ! test/com/sun/jdi/BadHandshakeTest.java ! test/com/sun/jdi/DoubleAgentTest.java ! test/com/sun/jdi/ExclusiveBind.java ! test/com/sun/jdi/RunToExit.java ! test/com/sun/jdi/connect/spi/SimpleLaunchingConnector.java Changeset: f07f6eb5d597 Author: ohair Date: 2009-12-01 08:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f07f6eb5d597 Merge - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java From vincent.ryan at sun.com Wed Dec 2 18:08:50 2009 From: vincent.ryan at sun.com (vincent.ryan at sun.com) Date: Wed, 02 Dec 2009 18:08:50 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20091202181000.38EAD41BB0@hg.openjdk.java.net> Changeset: 561186928899 Author: vinnie Date: 2009-12-02 17:06 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/561186928899 6906510: Fix testcase for 6894643: Separate out dependency on Kerberos Reviewed-by: weijun ! test/sun/security/krb5/auto/SSL.java Changeset: 79d91585d7d7 Author: vinnie Date: 2009-12-02 17:34 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/79d91585d7d7 Merge - make/tools/CharsetMapping/DoubleByte-X.java - make/tools/CharsetMapping/SingleByte-X.java - src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java - src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java - test/java/util/Formatter/Basic-X.java - test/sun/tools/native2ascii/test2 - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java From pcj at roundroom.net Thu Dec 3 07:34:17 2009 From: pcj at roundroom.net (Peter Jones) Date: Thu, 3 Dec 2009 02:34:17 -0500 Subject: final transient fields serialization In-Reply-To: References: <4AF8ABCA.8090505@sun.com> Message-ID: Pawel, I agree that the current reflection approach is unwieldy and otherwise problematic. Regarding a language solution, though, I don't see how to avoid making a mess of the definite assignment/unassignment semantics for final fields. (Of course deserialization itself effectively subverts that DA at runtime, and reflection DU, but at least the language is unaware.) It's hard to say much without a specific proposal. But I think that a language solution that includes detailed knowledge of serialization semantics[*] would be highly undesirable, not only for language purity reasons but also so that any needed evolution of those library semantics is not locked with evolution of the language spec. I could imagine some general way to let a (private) method be declared to have constructor-like final field setting ability. But readObject methods couldn't be required to have constructor-like DA semantics, because a OIS.defaultReadObject invocation reflectively sets non- transient final instance fields. So it would need to have constructor- like DU semantics but not DA-- again, seems messy. And practically speaking, I suspect that even a workable proposal would likely be deemed too esoteric to fit within the necessarily-constrained budgets for future language changes (that's only personal speculation). So I think that the best hope is an improved reflective library solution. Thinking out loud: say, a factory method that looks up a field in the immediate caller's class with no permission requirement, throws unchecked NoSuchFieldError instead of NoSuchFieldException, and produces an object that can be used to set the field even if it's final. Might be nice if the object were type-parameterized, but that would rule out actually using java.lang.reflect.Field-- could be sort of like the java.util.concurrent.atomic.Atomic*FieldUpdater APIs (hmm...). It would not address your string lookup issue (field literals would be helpful), but I doubt that the performance overhead of the reflective field set is much of a concern. Note that, as far as I know, pursuing something like this is not in current JDK plans. Cheers, -- Peter [*] As described in the RFEs referenced below, the problem is more nuanced than just with "transient" fields, such as if the serializable class declares serialPersistentFields and/or uses the GetField API. On Nov 29, 2009, at 5:12 PM, Pawel Veselov wrote: > > Hi Peter, > > not at all, I was late on replying to all the answers I've got myself. > > Anyway, my thoughts around this were that I wouldn't consider it > reasonable to put that much, and that kind of code around re- > instantiation of final transient fields, at least for the sheer sake > of them being final. Reflection means referencing fields using > string values, and also places significant overhead in the > instructions that need to be executed (comparing to what it took to > create an object), the code that needs to be written (makes for poor > templating), and the kind of the operations that need to be > performed (needing security access, reflection itself is a shady > operation for a high level user code). > > However, I don't really see any good way out of this situation, as > final fields are guaranteed instantiation during object > construction, but there is effectively no limit on how it can get > assigned, and what other objects would it use during such. > > I would think that it would be reasonable to then allow the > readObject() to re-assign final transient fields under the same > rules that currently apply to setting final fields by constructors. > I understand that this is as bad of an idea, because readObject() > can be called by other means, however, this can be made into a > compiler warning, or something, and throw some VM errors if a final > field is ever modified outside of the instantiation or > deserialization process. I know this is somewhat lame, but I'm not > the VM engineer :) But I still believe that the current state of > things with final and transient modifiers is somewhat troublesome. > > Thanks, > Pawel. > > On Sun, Nov 29, 2009 at 1:05 PM, Peter Jones > wrote: > Pawel, > > Sorry for the late followup, but you might also want to read these > RFEs: > > http://bugs.sun.com/view_bug.do?bug_id=6379948 > http://bugs.sun.com/view_bug.do?bug_id=6252102 > > -- Peter > > > > On Nov 9, 2009, at 6:54 PM, David Holmes - Sun Microsystems wrote: > > Pawel, > > Pawel Veselov said the following on 11/10/09 07:30: > it again caught my attention, and I though that may be there is > something that can be done about this. > The issue is obvious -- having 'final transient' instance fields > makes little sense if the object is ever serialized. > Logically, there may be perfect reasoning behind making an instance > field final, as well as transient, in which case there is then no > mechanism to reinitialize this field on object deserialization. > > Not quite true. This problem - that final fields can only be set > during true construction and not during the pseudo-construction that > occurs during deserialization - has been realized for a long time. > As part of the Java 5 update we (I think it was done JSR-133) put in > place the mechanism whereby you can use reflection to set a final > field provided that setAccessible(true) has been invoked for that > field. This is of course a limited solution as you must have the > security capability to invoke setAccessible(true). > > JSR-133 also addresses the Java Memory Model issues concerning > deserialization of objects with final fields - see Section 17.5.3 of > the Java Language Specification. (The notion of a "freeze action" on > a final field was in part motivated by the deserialization issue). > > David Holmes > > It seems that it would be nice if either the final fields were > initialized in a separate block that would be executed on > deserialization, or if readObject() could set them. After all you > can have a code block that sets the final fields. Not sure how > feasible that is, but IMHO, that is a short coming. > -- > With best of best regards > Pawel S. Veselov > > > > > -- > With best of best regards > Pawel S. Veselov From Thomas.Hawtin at Sun.COM Thu Dec 3 10:57:28 2009 From: Thomas.Hawtin at Sun.COM (Tom Hawtin) Date: Thu, 03 Dec 2009 10:57:28 +0000 Subject: final transient fields serialization In-Reply-To: References: <4AF8ABCA.8090505@sun.com> Message-ID: <4B179998.6050204@sun.com> Peter Jones wrote: > Regarding a language solution, though, I don't see how to avoid making a > [...] `readObject` is a `psuedo-constructor`. Ideally it would be a real constructor (with choice of defaultReadObject/readFields similar to super), but that would require significant changes to the JLS. Similar problems appear for JAXB, ORMs, etc. Dependency Inject also has problems with construction. Construction often involves way too much boilerplate. There are lots of issues here, most I have little experience with. > So I think that the best hope is an improved reflective library > solution. Thinking out loud: say, a factory method that looks up a > [...] I guess something like class MyClass implements Serializable { private final transient Thing thing; private static final FieldRead THING_READER = FieldRead.newInstance("thing"); ... private void readObject(...) ... { in.defaultReadObject(); Thing thing = (Thing)in.readObject(); THING_READER.set(thing); } } Gratuitous use of immediate caller. I just know people will attempt to take client supplied arguments. Best we can do is put a few static checks in javac and static analysis tools, and runtime checks into the serialisation mechanism. (Notes: FieldRead.newInstance - must be called by static initialiser (dynamic and perhaps static check). - static analysis (inc. javac) can check field name, type and assignment). - errors by unchecked exception FieldRead.read - Dynamic check that called from readObject on this instance (can cheat). - Dynamic check for no reassignment. - Dynamic check after readObject call for definite assignment. - Could also add static checks as well. ) Tom Hawtin From gokdogan at gmail.com Thu Dec 3 15:28:43 2009 From: gokdogan at gmail.com (Goktug Gokdogan) Date: Thu, 3 Dec 2009 17:28:43 +0200 Subject: Gap Buffer based AbstractStringBuilder implementation In-Reply-To: <1ccfd1c10911301616hed3bbe8u16f41273b9ce688f@mail.gmail.com> References: <1ccfd1c10911252124n4d552126pd06df06b8ae77965@mail.gmail.com> <1ccfd1c10911252202sb58f917mbdfe45687fbf112f@mail.gmail.com> <1ccfd1c10911301616hed3bbe8u16f41273b9ce688f@mail.gmail.com> Message-ID: On Tue, Dec 1, 2009 at 2:16 AM, Martin Buchholz wrote: > On Thu, Nov 26, 2009 at 00:57, Goktug Gokdogan wrote: > > I think, we can overcome the slowdown. The point of my prototype is to > check > > the general performance characteristics. Slowdown is more likely due to > the > > poorly optimized extra method call to keep all logic in one place. > Normally > > the gap buffer algorithm should add only one comparison overhead to the > > common case which will not to be observable in benchmarks. > > I am coming to like the gap buffer idea. > > You can optimize for append mode - append methods do not have to > check for the existence or length of an internal gap. > > An extra comparison overhead is likely to be cheap, but it is nevertheless > likely to be a measurable slowdown. > But as I said, it more and more seems to me the right thing to do. > > If done right, StringBuilder can start to strongly resemble an Emacs > buffer, > and be useful for largish amounts of data with internal modifications. > > > I have previously thought about implementing a similar behavior in other > > array-based growing structures, but it is not worth it. You can easily > use > > your previous data structures for pre-appending algorithms - just by > > appending to end and iterating from reverse. But you can't do that in a > > StringBuilder because StringBuilder itself is the composed data. So, in > my > > opinion, ArrayList is not a good analogy for this case. > > StringBuilder, as its name suggests, is for building strings and building > > string by appending to end is only one of the ways of doing it. > > I think we should go for this if we can do it without an observable > > slowdown. > > I didn't understand this argument. StringBuilder and ArrayList still > seem to me conceptually similar. > > Martin > > Let me try to explain my argument in another way. StringBuilder, similar to the other builder pattern implementations, is for constructing an object, not to collect some data. When append/insert/delete etc. called on a StringBuilder object, the goal is to shape the final state of the resulting String. At the end, you call toString method and you are done. But ArrayList is more flexible in a way that you are able to reinterpret the result. For example, you can iterate the items in reverse order or skip some of them etc.. So, with this point of view, I believe that StringBuilder and ArrayList are conceptually different. While building a String with StringBuilder, as it is the builder class for String, I expect it to provide good performance for different building scenarios. If I was designing it in the first place, I would start with an implementation that performs well in general (e.g. gap buffer), then I would check the performance for the common case (ie. appending to end) . If it does not perform well and can not be optimized, then I would consider adding another builder class to API that performs well on the common case before replacing the original. But in our case, as the previous codes already depends on the current performance characteristics of StringBuilder, I totally agree that we are good to replace it, iff it still performs as good as the previous one. This is why I suggested the change in the first place. Goktug. > > > > On Thu, Nov 26, 2009 at 1:02 AM, Martin Buchholz > > wrote: > >> > >> On Wed, Nov 25, 2009 at 21:24, Martin Buchholz > >> wrote: > >> > On Mon, Nov 23, 2009 at 22:51, Goktug Gokdogan > >> > wrote: > >> >> Nobody is interested or everybody is busy? > >> > > >> > I think there's a place for a StringBuilder-like > >> > abstraction that uses a gap buffer, > >> > but it shouldn't replace StringBuilder. > >> > >> Let me qualify that. > >> > >> It is hard to sell the small slowdown in the common case > >> to make other (rare?) operations much faster. > >> ArrayList should have been implemented to allow > >> O(1) insert at both ends, like ArrayDeque, > >> but it is hard to persuade the maintainers > >> that such a change is worth making today, > >> when the benchmarks all exercise only the common case. > >> Similarily for a hypothetical GapArrayList. > >> On the other hand, on modern cpus > >> arithmetic is ever closer to being "free", > >> so it is easier to justify the extra computation. > >> > >> Martin > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From david.lloyd at redhat.com Thu Dec 3 15:41:41 2009 From: david.lloyd at redhat.com (David M. Lloyd) Date: Thu, 03 Dec 2009 09:41:41 -0600 Subject: final transient fields serialization In-Reply-To: <4B179998.6050204@sun.com> References: <4AF8ABCA.8090505@sun.com> <4B179998.6050204@sun.com> Message-ID: <4B17DC35.4090308@redhat.com> This is exactly the solution I present to users of JBoss Marshalling. The access check performed verifies that the field being updated is a non-static instance field (final or otherwise, any access level) of the caller's class; IllegalAccessException is then not thrown at "runtime" when the field is changed. Setting the field can be done via the same assortment of set methods found on Field (set, setByte, setBoolean, ...). - DML On 12/03/2009 04:57 AM, Tom Hawtin wrote: > Peter Jones wrote: > >> Regarding a language solution, though, I don't see how to avoid making >> a [...] > > `readObject` is a `psuedo-constructor`. Ideally it would be a real > constructor (with choice of defaultReadObject/readFields similar to > super), but that would require significant changes to the JLS. > > Similar problems appear for JAXB, ORMs, etc. Dependency Inject also has > problems with construction. Construction often involves way too much > boilerplate. There are lots of issues here, most I have little > experience with. > >> So I think that the best hope is an improved reflective library >> solution. Thinking out loud: say, a factory method that looks up a [...] > > I guess something like > > class MyClass implements Serializable { > private final transient Thing thing; > private static final FieldRead THING_READER = > FieldRead.newInstance("thing"); > ... > private void readObject(...) ... { > in.defaultReadObject(); > Thing thing = (Thing)in.readObject(); > THING_READER.set(thing); > } > } > > Gratuitous use of immediate caller. I just know people will attempt to > take client supplied arguments. Best we can do is put a few static > checks in javac and static analysis tools, and runtime checks into the > serialisation mechanism. > > (Notes: > FieldRead.newInstance > - must be called by static initialiser > (dynamic and perhaps static check). > - static analysis (inc. javac) can check field name, type and assignment). > - errors by unchecked exception > FieldRead.read > - Dynamic check that called from readObject on this instance (can cheat). > - Dynamic check for no reassignment. > - Dynamic check after readObject call for definite assignment. > - Could also add static checks as well. > ) > > Tom Hawtin From vincent.ryan at sun.com Thu Dec 3 21:29:30 2009 From: vincent.ryan at sun.com (vincent.ryan at sun.com) Date: Thu, 03 Dec 2009 21:29:30 +0000 Subject: hg: jdk7/tl/jdk: 6906854: SSL/Krb5 testcase should not use a fixed port number Message-ID: <20091203213018.BD75041D8E@hg.openjdk.java.net> Changeset: bc12627832e0 Author: vinnie Date: 2009-12-03 21:30 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bc12627832e0 6906854: SSL/Krb5 testcase should not use a fixed port number Reviewed-by: alanb ! test/ProblemList.txt ! test/sun/security/krb5/auto/SSL.java From joe.darcy at sun.com Thu Dec 3 22:00:20 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 03 Dec 2009 22:00:20 +0000 Subject: hg: jdk7/tl/langtools: 6906748: Project Coin: Minor strings in switch cleanup Message-ID: <20091203220027.6D1F641D97@hg.openjdk.java.net> Changeset: 121e0ebf1658 Author: darcy Date: 2009-12-03 14:03 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/121e0ebf1658 6906748: Project Coin: Minor strings in switch cleanup Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java From Joe.Darcy at Sun.COM Fri Dec 4 00:56:31 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Thu, 03 Dec 2009 16:56:31 -0800 Subject: Code review request for 6907177 "Update jdk tests to remove unncessary -source and -target options" Message-ID: <4B185E3F.2090602@sun.com> Hello. The fix for 6907177 "Update jdk tests to remove unncessary -source and -target options" alters about 100 regression tests in the jdk repository that have inappropriate "-source" options to compile code to earlier source levels. Often these directives were created in JDK 5 before the default source level was raised to 5 in that release; therefore, such directives were necessary in those tests to enable the new language features to be used at the time. Generally, such directives should be removed so that the latest source level is exercised. In a few cases, the directives are just updated to allow a test to keep passing; the test/java/security/cert/PKIX* tests have not been been generified so they stay at -source 4 and test/java/util/Locale/Bug4175998Test.java won't compile with javac higher than -source 5 since the file contains an encoding error and starting with -source 6 javac treats encoding errors as fatal. Patch below; webrev at http://cr.openjdk.java.net/~darcy/6907177.0/ Thanks, -Joe --- old/test/demo/jvmti/hprof/CpuOldTest.java 2009-12-03 16:44:34.000000000 -0800 +++ new/test/demo/jvmti/hprof/CpuOldTest.java 2009-12-03 16:44:34.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5012882 6299047 * @summary Test jvmti hprof * - * @compile -source 1.5 -g HelloWorld.java ../DemoRun.java + * @compile -g HelloWorld.java ../DemoRun.java * @build CpuOldTest * @run main CpuOldTest HelloWorld */ --- old/test/demo/jvmti/hprof/CpuSamplesTest.java 2009-12-03 16:44:35.000000000 -0800 +++ new/test/demo/jvmti/hprof/CpuSamplesTest.java 2009-12-03 16:44:35.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5012882 * @summary Test jvmti hprof * - * @compile -source 1.5 -g:lines HelloWorld.java ../DemoRun.java + * @compile -g:lines HelloWorld.java ../DemoRun.java * @build CpuSamplesTest * @run main CpuSamplesTest HelloWorld */ --- old/test/demo/jvmti/hprof/CpuTimesDefineClassTest.java 2009-12-03 16:44:36.000000000 -0800 +++ new/test/demo/jvmti/hprof/CpuTimesDefineClassTest.java 2009-12-03 16:44:36.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5097131 6299047 * @summary Test jvmti hprof * - * @compile -source 1.5 -g HelloWorld.java DefineClass.java ../DemoRun.java + * @compile -g HelloWorld.java DefineClass.java ../DemoRun.java * @build CpuTimesDefineClassTest * @run main CpuTimesDefineClassTest DefineClass * --- old/test/demo/jvmti/hprof/CpuTimesTest.java 2009-12-03 16:44:37.000000000 -0800 +++ new/test/demo/jvmti/hprof/CpuTimesTest.java 2009-12-03 16:44:37.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5012882 6299047 * @summary Test jvmti hprof * - * @compile -source 1.5 -g HelloWorld.java ../DemoRun.java + * @compile -g HelloWorld.java ../DemoRun.java * @build CpuTimesTest * @run main CpuTimesTest HelloWorld */ --- old/test/demo/jvmti/hprof/HeapAllTest.java 2009-12-03 16:44:38.000000000 -0800 +++ new/test/demo/jvmti/hprof/HeapAllTest.java 2009-12-03 16:44:38.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5012882 6299047 * @summary Test jvmti hprof * - * @compile -source 1.5 -g HelloWorld.java ../DemoRun.java + * @compile -g HelloWorld.java ../DemoRun.java * @build HeapAllTest * @run main HeapAllTest HelloWorld */ --- old/test/demo/jvmti/hprof/HeapBinaryFormatTest.java 2009-12-03 16:44:39.000000000 -0800 +++ new/test/demo/jvmti/hprof/HeapBinaryFormatTest.java 2009-12-03 16:44:39.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 4965057 6313381 * @summary Test jvmti hprof format=b * - * @compile -source 1.5 -g:source HelloWorld.java ../DemoRun.java + * @compile -g:source HelloWorld.java ../DemoRun.java * @build HeapBinaryFormatTest * @run main HeapBinaryFormatTest HelloWorld */ --- old/test/demo/jvmti/hprof/HeapDumpTest.java 2009-12-03 16:44:40.000000000 -0800 +++ new/test/demo/jvmti/hprof/HeapDumpTest.java 2009-12-03 16:44:40.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5012882 6299047 * @summary Test jvmti hprof * - * @compile -source 1.5 -g:source HelloWorld.java ../DemoRun.java + * @compile -g:source HelloWorld.java ../DemoRun.java * @build HeapDumpTest * @run main HeapDumpTest HelloWorld */ --- old/test/demo/jvmti/hprof/HeapSitesTest.java 2009-12-03 16:44:41.000000000 -0800 +++ new/test/demo/jvmti/hprof/HeapSitesTest.java 2009-12-03 16:44:40.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5012882 6299047 * @summary Test jvmti hprof * - * @compile -source 1.5 -g:vars HelloWorld.java ../DemoRun.java + * @compile -g:vars HelloWorld.java ../DemoRun.java * @build HeapSitesTest * @run main HeapSitesTest HelloWorld */ --- old/test/demo/jvmti/hprof/OptionsTest.java 2009-12-03 16:44:42.000000000 -0800 +++ new/test/demo/jvmti/hprof/OptionsTest.java 2009-12-03 16:44:41.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 5083441 6299047 * @summary Test jvmti hprof * - * @compile -source 1.5 -g:lines HelloWorld.java ../DemoRun.java + * @compile -g:lines HelloWorld.java ../DemoRun.java * @build OptionsTest * @run main OptionsTest HelloWorld */ --- old/test/java/io/Serializable/enum/array/Test.java 2009-12-03 16:44:43.000000000 -0800 +++ new/test/java/io/Serializable/enum/array/Test.java 2009-12-03 16:44:42.000000000 -0800 @@ -25,9 +25,6 @@ * @bug 4838379 * @summary Verify that serialization of enum constant arrays functions * properly. - * - * @compile -source 1.5 Test.java - * @run main Test */ import java.io.*; --- old/test/java/io/Serializable/enum/badResolve/Write.java 2009-12-03 16:44:44.000000000 -0800 +++ new/test/java/io/Serializable/enum/badResolve/Write.java 2009-12-03 16:44:43.000000000 -0800 @@ -26,10 +26,10 @@ * @summary Verify that enum classes present in a serialization stream cannot * be resolved by the receiver to non-enum classes, and vice-versa. * - * @compile -source 1.5 Write.java + * @compile Write.java * @run main Write * @clean Write - * @compile -source 1.5 Read.java + * @compile Read.java * @run main Read * @clean Read */ --- old/test/java/io/Serializable/enum/basic/Test.java 2009-12-03 16:44:45.000000000 -0800 +++ new/test/java/io/Serializable/enum/basic/Test.java 2009-12-03 16:44:44.000000000 -0800 @@ -25,9 +25,6 @@ * @bug 4838379 * @summary Verify that basic serialization of non-specialized enum constants * functions properly. - * - * @compile -source 1.5 Test.java - * @run main Test */ import java.io.*; --- old/test/java/io/Serializable/enum/classObject/Test.java 2009-12-03 16:44:46.000000000 -0800 +++ new/test/java/io/Serializable/enum/classObject/Test.java 2009-12-03 16:44:45.000000000 -0800 @@ -25,9 +25,6 @@ * @bug 4838379 * @summary Verify that serialization of Class objects for enum types works * properly. - * - * @compile -source 1.5 Test.java - * @run main Test */ import java.io.*; --- old/test/java/io/Serializable/enum/constantSubclasses/Write.java 2009-12-03 16:44:46.000000000 -0800 +++ new/test/java/io/Serializable/enum/constantSubclasses/Write.java 2009-12-03 16:44:46.000000000 -0800 @@ -26,10 +26,10 @@ * @summary Verify that serialization of enum constants that are instances of * constant-specific subclasses functions properly. * - * @compile -source 1.5 Write.java + * @compile Write.java * @run main Write * @clean Write - * @compile -source 1.5 Read.java + * @compile Read.java * @run main Read * @clean Read */ --- old/test/java/io/Serializable/enum/ignoreSerializationFields/Test.java 2009-12-03 16:44:47.000000000 -0800 +++ new/test/java/io/Serializable/enum/ignoreSerializationFields/Test.java 2009-12-03 16:44:47.000000000 -0800 @@ -25,9 +25,6 @@ * @bug 4838379 * @summary Verify that serialVersionUID and serialPersistentFields * declarations made by enum types and constants are ignored. - * - * @compile -source 1.5 Test.java - * @run main Test */ import java.io.*; --- old/test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java 2009-12-03 16:44:48.000000000 -0800 +++ new/test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java 2009-12-03 16:44:48.000000000 -0800 @@ -25,9 +25,6 @@ * @bug 4838379 * @summary Verify that custom serialization methods defined by enum types are * not invoked during serialization or deserialization. - * - * @compile -source 1.5 Test.java - * @run main Test */ import java.io.*; --- old/test/java/io/Serializable/enum/mismatchedTypecode/Test.java 2009-12-03 16:44:49.000000000 -0800 +++ new/test/java/io/Serializable/enum/mismatchedTypecode/Test.java 2009-12-03 16:44:49.000000000 -0800 @@ -26,9 +26,6 @@ * @summary Verify that TC_OBJECT followed by a class descriptor for an enum * class results in an InvalidClassException, as does TC_ENUM followed * by a class descriptor for a non-enum class. - * - * @compile -source 1.5 Test.java - * @run main Test */ import java.io.*; --- old/test/java/io/Serializable/enum/missingConstant/Write.java 2009-12-03 16:44:50.000000000 -0800 +++ new/test/java/io/Serializable/enum/missingConstant/Write.java 2009-12-03 16:44:50.000000000 -0800 @@ -26,10 +26,10 @@ * @summary Verify that deserialization of an enum constant that does not exist * on the receiving side results in an InvalidObjectException. * - * @compile -source 1.5 Write.java + * @compile Write.java * @run main Write * @clean Write - * @compile -source 1.5 Read.java + * @compile Read.java * @run main Read * @clean Read */ --- old/test/java/io/Serializable/enum/unshared/Test.java 2009-12-03 16:44:51.000000000 -0800 +++ new/test/java/io/Serializable/enum/unshared/Test.java 2009-12-03 16:44:51.000000000 -0800 @@ -25,9 +25,6 @@ * @bug 4838379 * @summary Verify that unshared write and read operations work properly with * enum constants. - * - * @compile -source 1.5 Test.java - * @run main Test */ import java.io.*; --- old/test/java/lang/Boolean/MakeBooleanComparable.java 2009-12-03 16:44:52.000000000 -0800 +++ new/test/java/lang/Boolean/MakeBooleanComparable.java 2009-12-03 16:44:52.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4329937 * @summary Basic test for making Boolean implement Comparable * @author Josh Bloch - * - * @compile -source 1.5 MakeBooleanComparable.java - * @run main MakeBooleanComparable */ import java.util.*; --- old/test/java/lang/Class/Cast.java 2009-12-03 16:44:53.000000000 -0800 +++ new/test/java/lang/Class/Cast.java 2009-12-03 16:44:53.000000000 -0800 @@ -25,9 +25,6 @@ * @test * @bug 4881275 * @summary (reflect) Class.cast() - typesafe cast desired - * - * @compile -source 1.5 Cast.java - * @run main Cast */ public class Cast { --- old/test/java/lang/Class/IsEnum.java 2009-12-03 16:44:54.000000000 -0800 +++ new/test/java/lang/Class/IsEnum.java 2009-12-03 16:44:54.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4891872 4989735 4990789 5020490 * @summary Check isEnum() method * @author Joseph D. Darcy - * @compile -source 1.5 IsEnum.java - * @run main IsEnum */ import java.lang.annotation.*; --- old/test/java/lang/Class/asSubclass/BasicUnit.java 2009-12-03 16:44:55.000000000 -0800 +++ new/test/java/lang/Class/asSubclass/BasicUnit.java 2009-12-03 16:44:55.000000000 -0800 @@ -27,7 +27,7 @@ * @summary please add a typesafe cast for Class types * @author gafter * - * @compile -Xlint:unchecked -Werror -source 1.5 BasicUnit.java + * @compile -Xlint:unchecked -Werror BasicUnit.java * @run main BasicUnit */ --- old/test/java/lang/ClassLoader/Assert.sh 2009-12-03 16:44:56.000000000 -0800 +++ new/test/java/lang/ClassLoader/Assert.sh 2009-12-03 16:44:56.000000000 -0800 @@ -47,7 +47,7 @@ cp -R ${TESTSRC}/package1 . cp -R ${TESTSRC}/package2 . -${TESTJAVA}/bin/javac -source 1.4 Assert.java +${TESTJAVA}/bin/javac Assert.java ${TESTJAVA}/bin/java Assert --- old/test/java/lang/Integer/BitTwiddle.java 2009-12-03 16:44:57.000000000 -0800 +++ new/test/java/lang/Integer/BitTwiddle.java 2009-12-03 16:44:56.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4495754 * @summary Basic test for int bit twiddling * @author Josh Bloch - * - * @compile -source 1.5 BitTwiddle.java - * @run main BitTwiddle */ import java.util.Random; --- old/test/java/lang/Long/BitTwiddle.java 2009-12-03 16:44:58.000000000 -0800 +++ new/test/java/lang/Long/BitTwiddle.java 2009-12-03 16:44:57.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4495754 * @summary Basic test for long bit twiddling * @author Josh Bloch - * - * @compile -source 1.5 BitTwiddle.java - * @run main BitTwiddle */ import java.util.Random; --- old/test/java/lang/Math/Atan2Tests.java 2009-12-03 16:44:59.000000000 -0800 +++ new/test/java/lang/Math/Atan2Tests.java 2009-12-03 16:44:58.000000000 -0800 @@ -25,8 +25,6 @@ * @test * @bug 4984407 * @summary Tests for {Math, StrictMath}.atan2 - * @compile -source 1.5 Atan2Tests.java - * @run main Atan2Tests * @author Joseph D. Darcy */ --- old/test/java/lang/Math/IeeeRecommendedTests.java 2009-12-03 16:45:00.000000000 -0800 +++ new/test/java/lang/Math/IeeeRecommendedTests.java 2009-12-03 16:44:59.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4860891 4826732 4780454 4939441 4826652 * @summary Tests for IEEE 754[R] recommended functions and similar methods * @author Joseph D. Darcy - * @compile -source 1.5 IeeeRecommendedTests.java - * @run main IeeeRecommendedTests */ import sun.misc.FpUtils; --- old/test/java/lang/Math/PowTests.java 2009-12-03 16:45:01.000000000 -0800 +++ new/test/java/lang/Math/PowTests.java 2009-12-03 16:45:00.000000000 -0800 @@ -25,8 +25,6 @@ * @test * @bug 4984407 5033578 * @summary Tests for {Math, StrictMath}.pow - * @compile -source 1.5 PowTests.java - * @run main PowTests * @author Joseph D. Darcy */ --- old/test/java/lang/Math/TanTests.java 2009-12-03 16:45:02.000000000 -0800 +++ new/test/java/lang/Math/TanTests.java 2009-12-03 16:45:01.000000000 -0800 @@ -25,8 +25,6 @@ * @test * @bug 5033578 * @summary Tests for {Math, StrictMath}.tan - * @compile -source 1.5 TanTests.java - * @run main TanTests * @author Joseph D. Darcy */ --- old/test/java/lang/Runtime/exec/WinCommand.java 2009-12-03 16:45:03.000000000 -0800 +++ new/test/java/lang/Runtime/exec/WinCommand.java 2009-12-03 16:45:02.000000000 -0800 @@ -25,9 +25,6 @@ * @bug 5006520 * @summary Check many different ways to run Windows programs * @author Martin Buchholz - * - * @compile -source 1.5 WinCommand.java - * @run main WinCommand */ import java.io.*; --- old/test/java/lang/Thread/GenerifyStackTraces.java 2009-12-03 16:45:04.000000000 -0800 +++ new/test/java/lang/Thread/GenerifyStackTraces.java 2009-12-03 16:45:03.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4919105 * @summary Generified basic unit test of Thread.getAllStackTraces() * @author Mandy Chung - * - * @compile -source 1.5 GenerifyStackTraces.java - * @run main GenerifyStackTraces */ import java.util.*; --- old/test/java/lang/Thread/UncaughtExceptions.sh 2009-12-03 16:45:04.000000000 -0800 +++ new/test/java/lang/Thread/UncaughtExceptions.sh 2009-12-03 16:45:04.000000000 -0800 @@ -121,7 +121,7 @@ } EOJAVA - Sys "$javac" "-source" "1.5" "Seppuku.java" + Sys "$javac" "Seppuku.java" CheckCommandResults "$expectedRC" "$expectedOut" "$expectedErr" \ "$java" "Seppuku" Cleanup --- old/test/java/lang/annotation/UnitTest.java 2009-12-03 16:45:05.000000000 -0800 +++ new/test/java/lang/annotation/UnitTest.java 2009-12-03 16:45:05.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4906359 4963461 4965058 4965039 4986770 * @summary Unit test for annotation reading * @author Josh Bloch - * @compile -source 1.5 UnitTest.java - * @run main UnitTest */ import static java.lang.annotation.RetentionPolicy.RUNTIME; --- old/test/java/lang/annotation/package-info.java 2009-12-03 16:45:07.000000000 -0800 +++ new/test/java/lang/annotation/package-info.java 2009-12-03 16:45:06.000000000 -0800 @@ -27,7 +27,7 @@ * @summary Package annotations * @author gafter * - * @compile -source 1.5 package-info.java PackageMain.java + * @compile package-info.java PackageMain.java * @run main PackageMain */ --- old/test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java 2009-12-03 16:45:08.000000000 -0800 +++ new/test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java 2009-12-03 16:45:07.000000000 -0800 @@ -29,7 +29,7 @@ * the input CompositeData is invalid. * @author Mandy Chung * - * @compile -source 1.5 OpenTypeConverter.java + * @compile OpenTypeConverter.java * @build MemoryNotifInfoCompositeData * @run main MemoryNotifInfoCompositeData */ --- old/test/java/lang/management/CompositeData/ThreadInfoCompositeData.java 2009-12-03 16:45:08.000000000 -0800 +++ new/test/java/lang/management/CompositeData/ThreadInfoCompositeData.java 2009-12-03 16:45:08.000000000 -0800 @@ -29,7 +29,7 @@ * the input CompositeData is invalid. * @author Mandy Chung * - * @compile -source 1.5 OpenTypeConverter.java + * @compile OpenTypeConverter.java * @build ThreadInfoCompositeData * @run main ThreadInfoCompositeData */ --- old/test/java/lang/management/ManagementFactory/MXBeanProxyTest.java 2009-12-03 16:45:09.000000000 -0800 +++ new/test/java/lang/management/ManagementFactory/MXBeanProxyTest.java 2009-12-03 16:45:09.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 5024531 * @summary Basic Test for ManagementFactory.newPlatformMXBean(). * @author Mandy Chung - * - * @compile -source 1.5 MXBeanProxyTest.java - * @run main MXBeanProxyTest */ import javax.management.*; import java.lang.management.ClassLoadingMXBean; --- old/test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java 2009-12-03 16:45:10.000000000 -0800 +++ new/test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java 2009-12-03 16:45:10.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4947536 * @summary Basic unit test of ManagementFactory.getPlatformMBeanServer() * @author Mandy Chung - * - * @compile -source 1.5 PlatformMBeanServerTest.java - * @run main PlatformMBeanServerTest */ import java.lang.management.*; --- old/test/java/lang/management/ManagementFactory/ProxyExceptions.java 2009-12-03 16:45:11.000000000 -0800 +++ new/test/java/lang/management/ManagementFactory/ProxyExceptions.java 2009-12-03 16:45:11.000000000 -0800 @@ -27,9 +27,6 @@ * @summary Test type mapping of the platform MXBean proxy * returned from Management.newPlatformMXBeanProxy(). * @author Mandy Chung - * - * @compile -source 1.5 ProxyExceptions.java - * @run main ProxyExceptions */ import java.lang.management.*; import javax.management.*; --- old/test/java/lang/management/ManagementFactory/ProxyTypeMapping.java 2009-12-03 16:45:12.000000000 -0800 +++ new/test/java/lang/management/ManagementFactory/ProxyTypeMapping.java 2009-12-03 16:45:12.000000000 -0800 @@ -28,7 +28,7 @@ * returned from Management.newPlatformMXBeanProxy(). * @author Mandy Chung * - * @compile -source 1.5 ProxyTypeMapping.java + * @compile ProxyTypeMapping.java * @run main/othervm -verbose:gc ProxyTypeMapping */ import java.lang.management.*; --- old/test/java/lang/management/ManagementFactory/ValidateOpenTypes.java 2009-12-03 16:45:13.000000000 -0800 +++ new/test/java/lang/management/ManagementFactory/ValidateOpenTypes.java 2009-12-03 16:45:13.000000000 -0800 @@ -28,7 +28,7 @@ * MBeanServer. * @author Mandy Chung * - * @compile -source 1.5 ValidateOpenTypes.java + * @compile ValidateOpenTypes.java * @run main/othervm -verbose:gc ValidateOpenTypes */ import java.lang.management.*; --- old/test/java/lang/management/RuntimeMXBean/GetSystemProperties.java 2009-12-03 16:45:14.000000000 -0800 +++ new/test/java/lang/management/RuntimeMXBean/GetSystemProperties.java 2009-12-03 16:45:14.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4990512 * @summary Basic Test for RuntimeMXBean.getSystemProperties(). * @author Mandy Chung - * - * @compile -source 1.5 GetSystemProperties.java - * @run main GetSystemProperties */ import java.lang.management.ManagementFactory; --- old/test/java/lang/management/RuntimeMXBean/TestInputArgument.sh 2009-12-03 16:45:15.000000000 -0800 +++ new/test/java/lang/management/RuntimeMXBean/TestInputArgument.sh 2009-12-03 16:45:15.000000000 -0800 @@ -27,7 +27,7 @@ # @summary # @author Mandy Chung # -# @run compile -source 1.5 InputArgument.java +# @run compile InputArgument.java # @run shell TestInputArgument.sh # --- old/test/java/lang/reflect/Constructor/GenericStringTest.java 2009-12-03 16:45:16.000000000 -0800 +++ new/test/java/lang/reflect/Constructor/GenericStringTest.java 2009-12-03 16:45:16.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 5033583 6316717 6470106 * @summary Check toGenericString() and toString() methods * @author Joseph D. Darcy - * @compile -source 1.5 GenericStringTest.java - * @run main GenericStringTest */ import java.lang.reflect.*; --- old/test/java/lang/reflect/Field/GenericStringTest.java 2009-12-03 16:45:17.000000000 -0800 +++ new/test/java/lang/reflect/Field/GenericStringTest.java 2009-12-03 16:45:17.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 5033583 * @summary Check toGenericString() method * @author Joseph D. Darcy - * @compile -source 1.5 GenericStringTest.java - * @run main GenericStringTest */ import java.lang.reflect.*; --- old/test/java/lang/reflect/Generics/StringsAndBounds.java 2009-12-03 16:45:18.000000000 -0800 +++ new/test/java/lang/reflect/Generics/StringsAndBounds.java 2009-12-03 16:45:18.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 5015676 4987888 4997464 * @summary Testing upper bounds and availability of toString methods * @author Joseph D. Darcy - * @compile -source 1.5 StringsAndBounds.java - * @run main StringsAndBounds */ import java.lang.reflect.*; --- old/test/java/lang/reflect/Generics/TestC1.java 2009-12-03 16:45:19.000000000 -0800 +++ new/test/java/lang/reflect/Generics/TestC1.java 2009-12-03 16:45:19.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 4891872 * @summary Some tests for the generic core reflection api. * @author Gilad Bracha -* @compile -source 1.5 TestC1.java +* @compile TestC1.java * @run main/othervm -ea TestC1 */ --- old/test/java/lang/reflect/Generics/TestC2.java 2009-12-03 16:45:20.000000000 -0800 +++ new/test/java/lang/reflect/Generics/TestC2.java 2009-12-03 16:45:19.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 4891872 * @summary Some tests for the generic core reflection api. * @author Gilad Bracha -* @compile -source 1.5 TestC2.java +* @compile TestC2.java * @run main/othervm -ea TestC2 */ --- old/test/java/lang/reflect/Generics/TestN1.java 2009-12-03 16:45:21.000000000 -0800 +++ new/test/java/lang/reflect/Generics/TestN1.java 2009-12-03 16:45:20.000000000 -0800 @@ -26,7 +26,7 @@ * @bug 4891872 * @summary Some tests for the generic core reflection api. * @author Gilad Bracha -* @compile -source 1.5 TestN1.java +* @compile TestN1.java * @run main/othervm -ea TestN1 */ --- old/test/java/lang/reflect/Generics/exceptionCauseTest.java 2009-12-03 16:45:22.000000000 -0800 +++ new/test/java/lang/reflect/Generics/exceptionCauseTest.java 2009-12-03 16:45:21.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4981727 * @summary * @author Joseph D. Darcy - * @compile -source 1.5 exceptionCauseTest.java - * @run main exceptionCauseTest */ import java.io.PrintStream; --- old/test/java/lang/reflect/Generics/getAnnotationTest.java 2009-12-03 16:45:23.000000000 -0800 +++ new/test/java/lang/reflect/Generics/getAnnotationTest.java 2009-12-03 16:45:22.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4979440 * @summary Test for signature parsing corner case * @author Joseph D. Darcy - * @compile -source 1.5 getAnnotationTest.java - * @run main getAnnotationTest */ import java.lang.reflect.*; --- old/test/java/lang/reflect/Method/Equals.java 2009-12-03 16:45:24.000000000 -0800 +++ new/test/java/lang/reflect/Method/Equals.java 2009-12-03 16:45:23.000000000 -0800 @@ -27,7 +27,7 @@ * @summary Generic framework to test Method.equals. * * @clean A - * @compile -source 1.5 Equals.java + * @compile Equals.java * @run main Equals */ --- old/test/java/lang/reflect/Method/GenericStringTest.java 2009-12-03 16:45:25.000000000 -0800 +++ new/test/java/lang/reflect/Method/GenericStringTest.java 2009-12-03 16:45:24.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 5033583 6316717 6470106 * @summary Check toGenericString() and toString() methods * @author Joseph D. Darcy - * @compile -source 1.5 GenericStringTest.java - * @run main GenericStringTest */ import java.lang.reflect.*; --- old/test/java/math/BigDecimal/DivideTests.java 2009-12-03 16:45:26.000000000 -0800 +++ new/test/java/math/BigDecimal/DivideTests.java 2009-12-03 16:45:25.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4851776 4907265 6177836 6876282 * @summary Some tests for the divide methods. * @author Joseph D. Darcy - * @compile -source 1.5 DivideTests.java - * @run main DivideTests */ import java.math.*; --- old/test/java/math/BigDecimal/IntegralDivisionTests.java 2009-12-03 16:45:26.000000000 -0800 +++ new/test/java/math/BigDecimal/IntegralDivisionTests.java 2009-12-03 16:45:26.000000000 -0800 @@ -25,8 +25,6 @@ * @bug 4904082 4917089 6337226 * @summary Tests that integral division and related methods return the proper result and scale. * @author Joseph D. Darcy - * @compile -source 1.5 IntegralDivisionTests.java - * @run main IntegralDivisionTests */ import java.math.*; public class IntegralDivisionTests { --- old/test/java/math/BigDecimal/PowTests.java 2009-12-03 16:45:27.000000000 -0800 +++ new/test/java/math/BigDecimal/PowTests.java 2009-12-03 16:45:27.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4916097 * @summary Some exponent over/undeflow tests for the pow method * @author Joseph D. Darcy - * @compile -source 1.5 PowTests.java - * @run main PowTests */ import java.math.*; --- old/test/java/math/BigDecimal/ToPlainStringTests.java 2009-12-03 16:45:28.000000000 -0800 +++ new/test/java/math/BigDecimal/ToPlainStringTests.java 2009-12-03 16:45:28.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4984872 * @summary Basic tests of toPlainString method * @author Joseph D. Darcy - * @compile -source 1.5 ToPlainStringTests.java - * @run main ToPlainStringTests */ import java.math.*; --- old/test/java/math/BigDecimal/ZeroScalingTests.java 2009-12-03 16:45:29.000000000 -0800 +++ new/test/java/math/BigDecimal/ZeroScalingTests.java 2009-12-03 16:45:29.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4902952 4905407 4916149 * @summary Tests that the scale of zero is propagated properly and has the proper effect. * @author Joseph D. Darcy - * @compile -source 1.5 ZeroScalingTests.java - * @run main ZeroScalingTests */ import java.math.*; --- old/test/java/math/RoundingMode/RoundingModeTests.java 2009-12-03 16:45:30.000000000 -0800 +++ new/test/java/math/RoundingMode/RoundingModeTests.java 2009-12-03 16:45:30.000000000 -0800 @@ -26,8 +26,6 @@ * @bug 4851776 4891522 4905335 * @summary Basic tests for the RoundingMode class. * @author Joseph D. Darcy - * @compile -source 1.5 RoundingModeTests.java - * @run main RoundingModeTests */ import java.math.RoundingMode; --- old/test/java/net/ProxySelector/ProxyTest.java 2009-12-03 16:45:31.000000000 -0800 +++ new/test/java/net/ProxySelector/ProxyTest.java 2009-12-03 16:45:31.000000000 -0800 @@ -27,7 +27,7 @@ * @summary HTTP client: Improve proxy server configuration and selection * @library ../../../sun/net/www/httptest/ * @build ClosedChannelList HttpServer HttpTransaction HttpCallback - * @compile -source 1.5 ProxyTest.java + * @compile ProxyTest.java * @run main/othervm -Dhttp.proxyHost=inexistant -Dhttp.proxyPort=8080 ProxyTest */ --- old/test/java/net/URL/PerConnectionProxy.java 2009-12-03 16:45:32.000000000 -0800 +++ new/test/java/net/URL/PerConnectionProxy.java 2009-12-03 16:45:32.000000000 -0800 @@ -26,7 +26,7 @@ * @summary Needs per connection proxy support for URLs * @library ../../../sun/net/www/httptest/ * @build ClosedChannelList HttpServer HttpTransaction HttpCallback - * @compile -source 1.5 PerConnectionProxy.java + * @compile PerConnectionProxy.java * @run main/othervm -Dhttp.proxyHost=inexistant -Dhttp.proxyPort=8080 PerConnectionProxy */ --- old/test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java 2009-12-03 16:45:33.000000000 -0800 +++ new/test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java 2009-12-03 16:45:33.000000000 -0800 @@ -24,7 +24,7 @@ /** * @test * @test 4422738 - * @compile -source 1.4 -target 1.4 InvalidParameters.java + * @compile -source 1.4 InvalidParameters.java * @run main InvalidParameters * @summary Make sure PKIXBuilderParameters(Set) detects invalid * parameters and throws correct exceptions --- old/test/java/security/cert/PKIXParameters/InvalidParameters.java 2009-12-03 16:45:34.000000000 -0800 +++ new/test/java/security/cert/PKIXParameters/InvalidParameters.java 2009-12-03 16:45:34.000000000 -0800 @@ -24,7 +24,7 @@ /** * @test * @test 4422738 - * @compile -source 1.4 -target 1.4 InvalidParameters.java + * @compile -source 1.4 InvalidParameters.java * @run main InvalidParameters * @summary Make sure PKIXParameters(Set) and setTrustAnchors() detects invalid * parameters and throws correct exceptions --- old/test/java/util/AbstractList/CheckForComodification.java 2009-12-03 16:45:35.000000000 -0800 +++ new/test/java/util/AbstractList/CheckForComodification.java 2009-12-03 16:45:35.000000000 -0800 @@ -28,8 +28,6 @@ * @author Josh Bloch * * @ignore Bug fix temporarily removed as it uncovered other bugs (4992226) - * @compile -source 1.5 CheckForComodification.java - * @run main CheckForComodification */ import java.util.*; --- old/test/java/util/Collections/AddAll.java 2009-12-03 16:45:36.000000000 -0800 +++ new/test/java/util/Collections/AddAll.java 2009-12-03 16:45:36.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4822887 * @summary Basic test for Collections.addAll * @author Josh Bloch - * - * @compile -source 1.5 AddAll.java - * @run main AddAll */ import java.util.*; --- old/test/java/util/Collections/Disjoint.java 2009-12-03 16:45:37.000000000 -0800 +++ new/test/java/util/Collections/Disjoint.java 2009-12-03 16:45:37.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4339792 * @summary Basic test for Collections.disjoint * @author Josh Bloch - * - * @compile -source 1.5 Disjoint.java - * @run main Disjoint */ import java.util.*; --- old/test/java/util/Collections/Frequency.java 2009-12-03 16:45:38.000000000 -0800 +++ new/test/java/util/Collections/Frequency.java 2009-12-03 16:45:38.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4193200 * @summary Basic test for Collections.frequency * @author Josh Bloch - * - * @compile -source 1.5 Frequency.java - * @run main Frequency */ import java.util.*; --- old/test/java/util/EnumMap/EnumMapBash.java 2009-12-03 16:45:39.000000000 -0800 +++ new/test/java/util/EnumMap/EnumMapBash.java 2009-12-03 16:45:39.000000000 -0800 @@ -27,9 +27,6 @@ * @summary Unit test for EnumMap * @author Josh Bloch * @author Yo Yo Ma - * - * @compile -source 1.5 EnumMapBash.java - * @run main EnumMapBash */ import java.util.*; --- old/test/java/util/EnumSet/AllOf.java 2009-12-03 16:45:40.000000000 -0800 +++ new/test/java/util/EnumSet/AllOf.java 2009-12-03 16:45:39.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4946090 * @summary AllOf static factory is broken in Regular and Jumbo enum set * @author Josh Bloch - * - * @compile -source 1.5 AllOf.java - * @run main AllOf */ import java.util.*; --- old/test/java/util/EnumSet/ComplementOf.java 2009-12-03 16:45:41.000000000 -0800 +++ new/test/java/util/EnumSet/ComplementOf.java 2009-12-03 16:45:40.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4946096 * @summary ComplementOf static factory is broken in Regular and Jumbo enum set * @author Josh Bloch - * - * @compile -source 1.5 ComplementOf.java - * @run main ComplementOf */ import java.util.*; --- old/test/java/util/EnumSet/EnumSetBash.java 2009-12-03 16:45:42.000000000 -0800 +++ new/test/java/util/EnumSet/EnumSetBash.java 2009-12-03 16:45:41.000000000 -0800 @@ -28,9 +28,6 @@ * @author Josh Bloch * @author Neal Gafter * @author Yo Ma Ma - * - * @compile -source 1.5 EnumSetBash.java - * @run main EnumSetBash */ import java.util.*; --- old/test/java/util/EnumSet/JumboRange.java 2009-12-03 16:45:43.000000000 -0800 +++ new/test/java/util/EnumSet/JumboRange.java 2009-12-03 16:45:42.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4958003 * @summary Range static factory fails to compute size in Jumbo enum set * @author Josh Bloch - * - * @compile -source 1.5 JumboRange.java - * @run main JumboRange */ import java.util.*; --- old/test/java/util/EnumSet/Range.java 2009-12-03 16:45:44.000000000 -0800 +++ new/test/java/util/EnumSet/Range.java 2009-12-03 16:45:43.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4952736 * @summary Range static factory is broken in Regular and Jumbo enum set * @author Josh Bloch - * - * @compile -source 1.5 Range.java - * @run main Range */ import java.util.*; --- old/test/java/util/Formattable/StockName.java 2009-12-03 16:45:45.000000000 -0800 +++ new/test/java/util/Formattable/StockName.java 2009-12-03 16:45:44.000000000 -0800 @@ -21,11 +21,9 @@ * have any questions. */ -/** +/* * @test * @bug 4965770 4992540 5030716 - * @compile -source 1.5 StockName.java - * @run main StockName */ import java.nio.CharBuffer; --- old/test/java/util/IdentityHashMap/ToString.java 2009-12-03 16:45:45.000000000 -0800 +++ new/test/java/util/IdentityHashMap/ToString.java 2009-12-03 16:45:45.000000000 -0800 @@ -26,9 +26,6 @@ * @bug 4973432 * @summary Test that toString on entrySet Iterator/Entry behaves reasonably * @author Josh Bloch - * - * @compile -source 1.5 ToString.java - * @run main ToString */ --- old/test/java/util/Locale/Bug4175998Test.java 2009-12-03 16:45:46.000000000 -0800 +++ new/test/java/util/Locale/Bug4175998Test.java 2009-12-03 16:45:46.000000000 -0800 @@ -23,7 +23,7 @@ /* @test @summary test ISO639-2 language codes - @compile -encoding ascii -source 1.4 -target 1.4 Bug4175998Test.java + @compile -encoding ascii -source 5 Bug4175998Test.java @run main Bug4175998Test @bug 4175998 */ --- old/test/java/util/UUID/UUIDTest.java 2009-12-03 16:45:47.000000000 -0800 +++ new/test/java/util/UUID/UUIDTest.java 2009-12-03 16:45:47.000000000 -0800 @@ -23,8 +23,6 @@ /* @test * @bug 4173528 5068772 - * @compile -source 1.4 -target 1.4 UUIDTest.java - * @run main UUIDTest * @summary Unit tests for java.util.UUID */ --- old/test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java 2009-12-03 16:45:48.000000000 -0800 +++ new/test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java 2009-12-03 16:45:48.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 CancelledProducerConsumerLoops.java + * @compile CancelledProducerConsumerLoops.java * @run main/timeout=7000 CancelledProducerConsumerLoops * @summary Checks for responsiveness of blocking queues to cancellation. * Runs under the assumption that ITERS computations require more than --- old/test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java 2009-12-03 16:45:50.000000000 -0800 +++ new/test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java 2009-12-03 16:45:49.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 MultipleProducersSingleConsumerLoops.java + * @compile MultipleProducersSingleConsumerLoops.java * @run main/timeout=3600 MultipleProducersSingleConsumerLoops * @summary multiple producers and single consumer using blocking queues */ --- old/test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java 2009-12-03 16:45:51.000000000 -0800 +++ new/test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java 2009-12-03 16:45:51.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 ProducerConsumerLoops.java + * @compile ProducerConsumerLoops.java * @run main/timeout=3600 ProducerConsumerLoops * @summary multiple producers and consumers using blocking queues */ --- old/test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java 2009-12-03 16:45:52.000000000 -0800 +++ new/test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java 2009-12-03 16:45:52.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 SingleProducerMultipleConsumerLoops.java + * @compile SingleProducerMultipleConsumerLoops.java * @run main/timeout=600 SingleProducerMultipleConsumerLoops * @summary check ordering for blocking queues with 1 producer and multiple consumers */ --- old/test/java/util/concurrent/ConcurrentHashMap/MapCheck.java 2009-12-03 16:45:53.000000000 -0800 +++ new/test/java/util/concurrent/ConcurrentHashMap/MapCheck.java 2009-12-03 16:45:53.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 MapCheck.java + * @compile MapCheck.java * @run main/timeout=240 MapCheck * @summary Times and checks basic map operations */ --- old/test/java/util/concurrent/ConcurrentHashMap/MapLoops.java 2009-12-03 16:45:54.000000000 -0800 +++ new/test/java/util/concurrent/ConcurrentHashMap/MapLoops.java 2009-12-03 16:45:54.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 MapLoops.java + * @compile MapLoops.java * @run main/timeout=1600 MapLoops * @summary Exercise multithreaded maps, by default ConcurrentHashMap. * Multithreaded hash table test. Each thread does a random walk --- old/test/java/util/concurrent/Exchanger/ExchangeLoops.java 2009-12-03 16:45:55.000000000 -0800 +++ new/test/java/util/concurrent/Exchanger/ExchangeLoops.java 2009-12-03 16:45:55.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 ExchangeLoops.java + * @compile ExchangeLoops.java * @run main/timeout=720 ExchangeLoops * @summary checks to make sure a pipeline of exchangers passes data. */ --- old/test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java 2009-12-03 16:45:56.000000000 -0800 +++ new/test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java 2009-12-03 16:45:56.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4965960 - * @compile -source 1.5 ExecutorCompletionServiceLoops.java + * @compile ExecutorCompletionServiceLoops.java * @run main/timeout=3600 ExecutorCompletionServiceLoops * @summary Exercise ExecutorCompletionServiceLoops */ --- old/test/java/util/concurrent/FutureTask/CancelledFutureLoops.java 2009-12-03 16:45:57.000000000 -0800 +++ new/test/java/util/concurrent/FutureTask/CancelledFutureLoops.java 2009-12-03 16:45:57.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 CancelledFutureLoops.java + * @compile CancelledFutureLoops.java * @run main/timeout=2000 CancelledFutureLoops * @summary Checks for responsiveness of futures to cancellation. * Runs under the assumption that ITERS computations require more than --- old/test/java/util/concurrent/atomic/VMSupportsCS8.java 2009-12-03 16:45:58.000000000 -0800 +++ new/test/java/util/concurrent/atomic/VMSupportsCS8.java 2009-12-03 16:45:58.000000000 -0800 @@ -24,8 +24,6 @@ /* * @test * @bug 4992443 4994819 - * @compile -source 1.5 VMSupportsCS8.java - * @run main VMSupportsCS8 * @summary Checks that the value of VMSupportsCS8 matches system properties. */ --- old/test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java 2009-12-03 16:45:59.000000000 -0800 +++ new/test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java 2009-12-03 16:45:59.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 CancelledLockLoops.java + * @compile CancelledLockLoops.java * @run main/timeout=2800 CancelledLockLoops * @summary tests lockInterruptibly. * Checks for responsiveness of locks to interrupts. Runs under that --- old/test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java 2009-12-03 16:46:00.000000000 -0800 +++ new/test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java 2009-12-03 16:46:00.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 LockOncePerThreadLoops.java + * @compile LockOncePerThreadLoops.java * @run main/timeout=15000 LockOncePerThreadLoops * @summary Checks for missed signals by locking and unlocking each of an array of locks once per thread */ --- old/test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java 2009-12-03 16:46:01.000000000 -0800 +++ new/test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java 2009-12-03 16:46:01.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 SimpleReentrantLockLoops.java + * @compile SimpleReentrantLockLoops.java * @run main/timeout=4500 SimpleReentrantLockLoops * @summary multiple threads using a single lock */ --- old/test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java 2009-12-03 16:46:02.000000000 -0800 +++ new/test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java 2009-12-03 16:46:02.000000000 -0800 @@ -34,8 +34,6 @@ /* * @test * @bug 4486658 5031862 - * @compile -source 1.5 TimeoutLockLoops.java - * @run main TimeoutLockLoops * @summary Checks for responsiveness of locks to timeouts. * Runs under the assumption that ITERS computations require more than * TIMEOUT msecs to complete, which seems to be a safe assumption for --- old/test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java 2009-12-03 16:46:03.000000000 -0800 +++ new/test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java 2009-12-03 16:46:03.000000000 -0800 @@ -34,7 +34,7 @@ /* * @test * @bug 4486658 - * @compile -source 1.5 MapLoops.java + * @compile MapLoops.java * @run main/timeout=4700 MapLoops * @summary Exercise multithreaded maps, by default ConcurrentHashMap. * Multithreaded hash table test. Each thread does a random walk --- old/test/sun/management/AgentCheckTest.java 2009-12-03 16:46:04.000000000 -0800 +++ new/test/sun/management/AgentCheckTest.java 2009-12-03 16:46:03.000000000 -0800 @@ -27,9 +27,6 @@ * @summary Localize log messages from the management agents * * @author Tim Bell - * - * @run compile -source 1.5 -g AgentCheckTest.java - * @run main AgentCheckTest */ import sun.management.Agent; --- old/test/sun/security/util/Oid/S11N.sh 2009-12-03 16:46:05.000000000 -0800 +++ new/test/sun/security/util/Oid/S11N.sh 2009-12-03 16:46:04.000000000 -0800 @@ -99,7 +99,7 @@ # the test code -${TESTJAVA}${FS}bin${FS}javac -source 1.3 -target 1.3 -d . ${TESTSRC}${FS}SerialTest.java || exit 10 +${TESTJAVA}${FS}bin${FS}javac -d . ${TESTSRC}${FS}SerialTest.java || exit 10 OLDJAVA=" /java/re/j2se/1.6.0/latest/binaries/${PF} --- old/test/sun/tools/jconsole/ResourceCheckTest.sh 2009-12-03 16:46:06.000000000 -0800 +++ new/test/sun/tools/jconsole/ResourceCheckTest.sh 2009-12-03 16:46:05.000000000 -0800 @@ -98,7 +98,7 @@ set -vx # #Compile. jconsole.jar is required on the classpath. -${TESTJAVA}/bin/javac -source 1.5 -d "${TESTCLASSES}" ${CP} -g \ +${TESTJAVA}/bin/javac -d "${TESTCLASSES}" ${CP} -g \ "${TESTSRC}"/"${TARGETCLASS}".java # #Run the test class, again with the classpath we need: From Kelly.Ohair at Sun.COM Fri Dec 4 02:04:55 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 03 Dec 2009 18:04:55 -0800 Subject: Code review request for 6907177 "Update jdk tests to remove unncessary -source and -target options" In-Reply-To: <4B185E3F.2090602@sun.com> References: <4B185E3F.2090602@sun.com> Message-ID: <4B186E47.5010006@sun.com> Looks fine Joe. I also have some of these same changes, on the jvmti demo tests but they should merge fine when I get your changeset. -kto Joe Darcy wrote: > Hello. > > The fix for 6907177 "Update jdk tests to remove unncessary -source and > -target options" alters about 100 regression tests in the jdk repository > that have inappropriate "-source" options to compile code to earlier > source levels. Often these directives were created in JDK 5 before the > default source level was raised to 5 in that release; therefore, such > directives were necessary in those tests to enable the new language > features to be used at the time. Generally, such directives should be > removed so that the latest source level is exercised. In a few cases, > the directives are just updated to allow a test to keep passing; the > test/java/security/cert/PKIX* tests have not been been generified so > they stay at -source 4 and test/java/util/Locale/Bug4175998Test.java > won't compile with javac higher than -source 5 since the file contains > an encoding error and starting with -source 6 javac treats encoding > errors as fatal. > > Patch below; webrev at > http://cr.openjdk.java.net/~darcy/6907177.0/ > > Thanks, > > -Joe > > --- old/test/demo/jvmti/hprof/CpuOldTest.java 2009-12-03 > 16:44:34.000000000 -0800 > +++ new/test/demo/jvmti/hprof/CpuOldTest.java 2009-12-03 > 16:44:34.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5012882 6299047 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g HelloWorld.java ../DemoRun.java > + * @compile -g HelloWorld.java ../DemoRun.java > * @build CpuOldTest > * @run main CpuOldTest HelloWorld > */ > --- old/test/demo/jvmti/hprof/CpuSamplesTest.java 2009-12-03 > 16:44:35.000000000 -0800 > +++ new/test/demo/jvmti/hprof/CpuSamplesTest.java 2009-12-03 > 16:44:35.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5012882 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g:lines HelloWorld.java ../DemoRun.java > + * @compile -g:lines HelloWorld.java ../DemoRun.java > * @build CpuSamplesTest > * @run main CpuSamplesTest HelloWorld > */ > --- old/test/demo/jvmti/hprof/CpuTimesDefineClassTest.java 2009-12-03 > 16:44:36.000000000 -0800 > +++ new/test/demo/jvmti/hprof/CpuTimesDefineClassTest.java 2009-12-03 > 16:44:36.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5097131 6299047 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g HelloWorld.java DefineClass.java > ../DemoRun.java > + * @compile -g HelloWorld.java DefineClass.java ../DemoRun.java > * @build CpuTimesDefineClassTest > * @run main CpuTimesDefineClassTest DefineClass > * > --- old/test/demo/jvmti/hprof/CpuTimesTest.java 2009-12-03 > 16:44:37.000000000 -0800 > +++ new/test/demo/jvmti/hprof/CpuTimesTest.java 2009-12-03 > 16:44:37.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5012882 6299047 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g HelloWorld.java ../DemoRun.java > + * @compile -g HelloWorld.java ../DemoRun.java > * @build CpuTimesTest > * @run main CpuTimesTest HelloWorld > */ > --- old/test/demo/jvmti/hprof/HeapAllTest.java 2009-12-03 > 16:44:38.000000000 -0800 > +++ new/test/demo/jvmti/hprof/HeapAllTest.java 2009-12-03 > 16:44:38.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5012882 6299047 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g HelloWorld.java ../DemoRun.java > + * @compile -g HelloWorld.java ../DemoRun.java > * @build HeapAllTest > * @run main HeapAllTest HelloWorld > */ > --- old/test/demo/jvmti/hprof/HeapBinaryFormatTest.java 2009-12-03 > 16:44:39.000000000 -0800 > +++ new/test/demo/jvmti/hprof/HeapBinaryFormatTest.java 2009-12-03 > 16:44:39.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 4965057 6313381 > * @summary Test jvmti hprof format=b > * > - * @compile -source 1.5 -g:source HelloWorld.java ../DemoRun.java > + * @compile -g:source HelloWorld.java ../DemoRun.java > * @build HeapBinaryFormatTest > * @run main HeapBinaryFormatTest HelloWorld > */ > --- old/test/demo/jvmti/hprof/HeapDumpTest.java 2009-12-03 > 16:44:40.000000000 -0800 > +++ new/test/demo/jvmti/hprof/HeapDumpTest.java 2009-12-03 > 16:44:40.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5012882 6299047 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g:source HelloWorld.java ../DemoRun.java > + * @compile -g:source HelloWorld.java ../DemoRun.java > * @build HeapDumpTest > * @run main HeapDumpTest HelloWorld > */ > --- old/test/demo/jvmti/hprof/HeapSitesTest.java 2009-12-03 > 16:44:41.000000000 -0800 > +++ new/test/demo/jvmti/hprof/HeapSitesTest.java 2009-12-03 > 16:44:40.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5012882 6299047 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g:vars HelloWorld.java ../DemoRun.java > + * @compile -g:vars HelloWorld.java ../DemoRun.java > * @build HeapSitesTest > * @run main HeapSitesTest HelloWorld > */ > --- old/test/demo/jvmti/hprof/OptionsTest.java 2009-12-03 > 16:44:42.000000000 -0800 > +++ new/test/demo/jvmti/hprof/OptionsTest.java 2009-12-03 > 16:44:41.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 5083441 6299047 > * @summary Test jvmti hprof > * > - * @compile -source 1.5 -g:lines HelloWorld.java ../DemoRun.java > + * @compile -g:lines HelloWorld.java ../DemoRun.java > * @build OptionsTest > * @run main OptionsTest HelloWorld > */ > --- old/test/java/io/Serializable/enum/array/Test.java 2009-12-03 > 16:44:43.000000000 -0800 > +++ new/test/java/io/Serializable/enum/array/Test.java 2009-12-03 > 16:44:42.000000000 -0800 > @@ -25,9 +25,6 @@ > * @bug 4838379 > * @summary Verify that serialization of enum constant arrays functions > * properly. > - * > - * @compile -source 1.5 Test.java > - * @run main Test > */ > > import java.io.*; > --- old/test/java/io/Serializable/enum/badResolve/Write.java > 2009-12-03 16:44:44.000000000 -0800 > +++ new/test/java/io/Serializable/enum/badResolve/Write.java > 2009-12-03 16:44:43.000000000 -0800 > @@ -26,10 +26,10 @@ > * @summary Verify that enum classes present in a serialization stream > cannot > * be resolved by the receiver to non-enum classes, and > vice-versa. > * > - * @compile -source 1.5 Write.java > + * @compile Write.java > * @run main Write > * @clean Write > - * @compile -source 1.5 Read.java > + * @compile Read.java > * @run main Read > * @clean Read > */ > --- old/test/java/io/Serializable/enum/basic/Test.java 2009-12-03 > 16:44:45.000000000 -0800 > +++ new/test/java/io/Serializable/enum/basic/Test.java 2009-12-03 > 16:44:44.000000000 -0800 > @@ -25,9 +25,6 @@ > * @bug 4838379 > * @summary Verify that basic serialization of non-specialized enum > constants > * functions properly. > - * > - * @compile -source 1.5 Test.java > - * @run main Test > */ > > import java.io.*; > --- old/test/java/io/Serializable/enum/classObject/Test.java > 2009-12-03 16:44:46.000000000 -0800 > +++ new/test/java/io/Serializable/enum/classObject/Test.java > 2009-12-03 16:44:45.000000000 -0800 > @@ -25,9 +25,6 @@ > * @bug 4838379 > * @summary Verify that serialization of Class objects for enum types works > * properly. > - * > - * @compile -source 1.5 Test.java > - * @run main Test > */ > > import java.io.*; > --- old/test/java/io/Serializable/enum/constantSubclasses/Write.java > 2009-12-03 16:44:46.000000000 -0800 > +++ new/test/java/io/Serializable/enum/constantSubclasses/Write.java > 2009-12-03 16:44:46.000000000 -0800 > @@ -26,10 +26,10 @@ > * @summary Verify that serialization of enum constants that are > instances of > * constant-specific subclasses functions properly. > * > - * @compile -source 1.5 Write.java > + * @compile Write.java > * @run main Write > * @clean Write > - * @compile -source 1.5 Read.java > + * @compile Read.java > * @run main Read > * @clean Read > */ > --- > old/test/java/io/Serializable/enum/ignoreSerializationFields/Test.java > 2009-12-03 16:44:47.000000000 -0800 > +++ > new/test/java/io/Serializable/enum/ignoreSerializationFields/Test.java > 2009-12-03 16:44:47.000000000 -0800 > @@ -25,9 +25,6 @@ > * @bug 4838379 > * @summary Verify that serialVersionUID and serialPersistentFields > * declarations made by enum types and constants are ignored. > - * > - * @compile -source 1.5 Test.java > - * @run main Test > */ > > import java.io.*; > --- > old/test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java > 2009-12-03 16:44:48.000000000 -0800 > +++ > new/test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java > 2009-12-03 16:44:48.000000000 -0800 > @@ -25,9 +25,6 @@ > * @bug 4838379 > * @summary Verify that custom serialization methods defined by enum > types are > * not invoked during serialization or deserialization. > - * > - * @compile -source 1.5 Test.java > - * @run main Test > */ > > import java.io.*; > --- old/test/java/io/Serializable/enum/mismatchedTypecode/Test.java > 2009-12-03 16:44:49.000000000 -0800 > +++ new/test/java/io/Serializable/enum/mismatchedTypecode/Test.java > 2009-12-03 16:44:49.000000000 -0800 > @@ -26,9 +26,6 @@ > * @summary Verify that TC_OBJECT followed by a class descriptor for an > enum > * class results in an InvalidClassException, as does TC_ENUM > followed > * by a class descriptor for a non-enum class. > - * > - * @compile -source 1.5 Test.java > - * @run main Test > */ > > import java.io.*; > --- old/test/java/io/Serializable/enum/missingConstant/Write.java > 2009-12-03 16:44:50.000000000 -0800 > +++ new/test/java/io/Serializable/enum/missingConstant/Write.java > 2009-12-03 16:44:50.000000000 -0800 > @@ -26,10 +26,10 @@ > * @summary Verify that deserialization of an enum constant that does > not exist > * on the receiving side results in an InvalidObjectException. > * > - * @compile -source 1.5 Write.java > + * @compile Write.java > * @run main Write > * @clean Write > - * @compile -source 1.5 Read.java > + * @compile Read.java > * @run main Read > * @clean Read > */ > --- old/test/java/io/Serializable/enum/unshared/Test.java 2009-12-03 > 16:44:51.000000000 -0800 > +++ new/test/java/io/Serializable/enum/unshared/Test.java 2009-12-03 > 16:44:51.000000000 -0800 > @@ -25,9 +25,6 @@ > * @bug 4838379 > * @summary Verify that unshared write and read operations work properly > with > * enum constants. > - * > - * @compile -source 1.5 Test.java > - * @run main Test > */ > > import java.io.*; > --- old/test/java/lang/Boolean/MakeBooleanComparable.java 2009-12-03 > 16:44:52.000000000 -0800 > +++ new/test/java/lang/Boolean/MakeBooleanComparable.java 2009-12-03 > 16:44:52.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4329937 > * @summary Basic test for making Boolean implement Comparable > * @author Josh Bloch > - * > - * @compile -source 1.5 MakeBooleanComparable.java > - * @run main MakeBooleanComparable > */ > > import java.util.*; > --- old/test/java/lang/Class/Cast.java 2009-12-03 16:44:53.000000000 > -0800 > +++ new/test/java/lang/Class/Cast.java 2009-12-03 16:44:53.000000000 > -0800 > @@ -25,9 +25,6 @@ > * @test > * @bug 4881275 > * @summary (reflect) Class.cast() - typesafe cast desired > - * > - * @compile -source 1.5 Cast.java > - * @run main Cast > */ > > public class Cast { > --- old/test/java/lang/Class/IsEnum.java 2009-12-03 > 16:44:54.000000000 -0800 > +++ new/test/java/lang/Class/IsEnum.java 2009-12-03 > 16:44:54.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4891872 4989735 4990789 5020490 > * @summary Check isEnum() method > * @author Joseph D. Darcy > - * @compile -source 1.5 IsEnum.java > - * @run main IsEnum > */ > > import java.lang.annotation.*; > --- old/test/java/lang/Class/asSubclass/BasicUnit.java 2009-12-03 > 16:44:55.000000000 -0800 > +++ new/test/java/lang/Class/asSubclass/BasicUnit.java 2009-12-03 > 16:44:55.000000000 -0800 > @@ -27,7 +27,7 @@ > * @summary please add a typesafe cast for Class types > * @author gafter > * > - * @compile -Xlint:unchecked -Werror -source 1.5 BasicUnit.java > + * @compile -Xlint:unchecked -Werror BasicUnit.java > * @run main BasicUnit > */ > > --- old/test/java/lang/ClassLoader/Assert.sh 2009-12-03 > 16:44:56.000000000 -0800 > +++ new/test/java/lang/ClassLoader/Assert.sh 2009-12-03 > 16:44:56.000000000 -0800 > @@ -47,7 +47,7 @@ > cp -R ${TESTSRC}/package1 . > cp -R ${TESTSRC}/package2 . > > -${TESTJAVA}/bin/javac -source 1.4 Assert.java +${TESTJAVA}/bin/javac > Assert.java > ${TESTJAVA}/bin/java Assert > > --- old/test/java/lang/Integer/BitTwiddle.java 2009-12-03 > 16:44:57.000000000 -0800 > +++ new/test/java/lang/Integer/BitTwiddle.java 2009-12-03 > 16:44:56.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4495754 > * @summary Basic test for int bit twiddling > * @author Josh Bloch > - * > - * @compile -source 1.5 BitTwiddle.java > - * @run main BitTwiddle > */ > > import java.util.Random; > --- old/test/java/lang/Long/BitTwiddle.java 2009-12-03 > 16:44:58.000000000 -0800 > +++ new/test/java/lang/Long/BitTwiddle.java 2009-12-03 > 16:44:57.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4495754 > * @summary Basic test for long bit twiddling > * @author Josh Bloch > - * > - * @compile -source 1.5 BitTwiddle.java > - * @run main BitTwiddle > */ > > import java.util.Random; > --- old/test/java/lang/Math/Atan2Tests.java 2009-12-03 > 16:44:59.000000000 -0800 > +++ new/test/java/lang/Math/Atan2Tests.java 2009-12-03 > 16:44:58.000000000 -0800 > @@ -25,8 +25,6 @@ > * @test > * @bug 4984407 > * @summary Tests for {Math, StrictMath}.atan2 > - * @compile -source 1.5 Atan2Tests.java > - * @run main Atan2Tests > * @author Joseph D. Darcy > */ > > --- old/test/java/lang/Math/IeeeRecommendedTests.java 2009-12-03 > 16:45:00.000000000 -0800 > +++ new/test/java/lang/Math/IeeeRecommendedTests.java 2009-12-03 > 16:44:59.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4860891 4826732 4780454 4939441 4826652 > * @summary Tests for IEEE 754[R] recommended functions and similar methods > * @author Joseph D. Darcy > - * @compile -source 1.5 IeeeRecommendedTests.java > - * @run main IeeeRecommendedTests > */ > > import sun.misc.FpUtils; > --- old/test/java/lang/Math/PowTests.java 2009-12-03 > 16:45:01.000000000 -0800 > +++ new/test/java/lang/Math/PowTests.java 2009-12-03 > 16:45:00.000000000 -0800 > @@ -25,8 +25,6 @@ > * @test > * @bug 4984407 5033578 > * @summary Tests for {Math, StrictMath}.pow > - * @compile -source 1.5 PowTests.java > - * @run main PowTests > * @author Joseph D. Darcy > */ > > --- old/test/java/lang/Math/TanTests.java 2009-12-03 > 16:45:02.000000000 -0800 > +++ new/test/java/lang/Math/TanTests.java 2009-12-03 > 16:45:01.000000000 -0800 > @@ -25,8 +25,6 @@ > * @test > * @bug 5033578 > * @summary Tests for {Math, StrictMath}.tan > - * @compile -source 1.5 TanTests.java > - * @run main TanTests > * @author Joseph D. Darcy > */ > > --- old/test/java/lang/Runtime/exec/WinCommand.java 2009-12-03 > 16:45:03.000000000 -0800 > +++ new/test/java/lang/Runtime/exec/WinCommand.java 2009-12-03 > 16:45:02.000000000 -0800 > @@ -25,9 +25,6 @@ > * @bug 5006520 > * @summary Check many different ways to run Windows programs > * @author Martin Buchholz > - * > - * @compile -source 1.5 WinCommand.java > - * @run main WinCommand > */ > > import java.io.*; > --- old/test/java/lang/Thread/GenerifyStackTraces.java 2009-12-03 > 16:45:04.000000000 -0800 > +++ new/test/java/lang/Thread/GenerifyStackTraces.java 2009-12-03 > 16:45:03.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4919105 > * @summary Generified basic unit test of Thread.getAllStackTraces() > * @author Mandy Chung > - * > - * @compile -source 1.5 GenerifyStackTraces.java > - * @run main GenerifyStackTraces > */ > > import java.util.*; > --- old/test/java/lang/Thread/UncaughtExceptions.sh 2009-12-03 > 16:45:04.000000000 -0800 > +++ new/test/java/lang/Thread/UncaughtExceptions.sh 2009-12-03 > 16:45:04.000000000 -0800 > @@ -121,7 +121,7 @@ > } > EOJAVA > > - Sys "$javac" "-source" "1.5" "Seppuku.java" > + Sys "$javac" "Seppuku.java" > CheckCommandResults "$expectedRC" "$expectedOut" "$expectedErr" \ > "$java" "Seppuku" > Cleanup > --- old/test/java/lang/annotation/UnitTest.java 2009-12-03 > 16:45:05.000000000 -0800 > +++ new/test/java/lang/annotation/UnitTest.java 2009-12-03 > 16:45:05.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4906359 4963461 4965058 4965039 4986770 > * @summary Unit test for annotation reading > * @author Josh Bloch > - * @compile -source 1.5 UnitTest.java > - * @run main UnitTest > */ > > import static java.lang.annotation.RetentionPolicy.RUNTIME; > --- old/test/java/lang/annotation/package-info.java 2009-12-03 > 16:45:07.000000000 -0800 > +++ new/test/java/lang/annotation/package-info.java 2009-12-03 > 16:45:06.000000000 -0800 > @@ -27,7 +27,7 @@ > * @summary Package annotations > * @author gafter > * > - * @compile -source 1.5 package-info.java PackageMain.java > + * @compile package-info.java PackageMain.java > * @run main PackageMain > */ > > --- > old/test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java > 2009-12-03 16:45:08.000000000 -0800 > +++ > new/test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java > 2009-12-03 16:45:07.000000000 -0800 > @@ -29,7 +29,7 @@ > * the input CompositeData is invalid. > * @author Mandy Chung > * > - * @compile -source 1.5 OpenTypeConverter.java > + * @compile OpenTypeConverter.java > * @build MemoryNotifInfoCompositeData > * @run main MemoryNotifInfoCompositeData > */ > --- > old/test/java/lang/management/CompositeData/ThreadInfoCompositeData.java > 2009-12-03 16:45:08.000000000 -0800 > +++ > new/test/java/lang/management/CompositeData/ThreadInfoCompositeData.java > 2009-12-03 16:45:08.000000000 -0800 > @@ -29,7 +29,7 @@ > * the input CompositeData is invalid. > * @author Mandy Chung > * > - * @compile -source 1.5 OpenTypeConverter.java > + * @compile OpenTypeConverter.java > * @build ThreadInfoCompositeData > * @run main ThreadInfoCompositeData > */ > --- > old/test/java/lang/management/ManagementFactory/MXBeanProxyTest.java > 2009-12-03 16:45:09.000000000 -0800 > +++ > new/test/java/lang/management/ManagementFactory/MXBeanProxyTest.java > 2009-12-03 16:45:09.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 5024531 > * @summary Basic Test for ManagementFactory.newPlatformMXBean(). > * @author Mandy Chung > - * > - * @compile -source 1.5 MXBeanProxyTest.java > - * @run main MXBeanProxyTest > */ > import javax.management.*; > import java.lang.management.ClassLoadingMXBean; > --- > old/test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java > 2009-12-03 16:45:10.000000000 -0800 > +++ > new/test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java > 2009-12-03 16:45:10.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4947536 > * @summary Basic unit test of ManagementFactory.getPlatformMBeanServer() > * @author Mandy Chung > - * > - * @compile -source 1.5 PlatformMBeanServerTest.java > - * @run main PlatformMBeanServerTest > */ > > import java.lang.management.*; > --- > old/test/java/lang/management/ManagementFactory/ProxyExceptions.java > 2009-12-03 16:45:11.000000000 -0800 > +++ > new/test/java/lang/management/ManagementFactory/ProxyExceptions.java > 2009-12-03 16:45:11.000000000 -0800 > @@ -27,9 +27,6 @@ > * @summary Test type mapping of the platform MXBean proxy > * returned from Management.newPlatformMXBeanProxy(). > * @author Mandy Chung > - * > - * @compile -source 1.5 ProxyExceptions.java > - * @run main ProxyExceptions > */ > import java.lang.management.*; > import javax.management.*; > --- > old/test/java/lang/management/ManagementFactory/ProxyTypeMapping.java > 2009-12-03 16:45:12.000000000 -0800 > +++ > new/test/java/lang/management/ManagementFactory/ProxyTypeMapping.java > 2009-12-03 16:45:12.000000000 -0800 > @@ -28,7 +28,7 @@ > * returned from Management.newPlatformMXBeanProxy(). > * @author Mandy Chung > * > - * @compile -source 1.5 ProxyTypeMapping.java > + * @compile ProxyTypeMapping.java > * @run main/othervm -verbose:gc ProxyTypeMapping > */ > import java.lang.management.*; > --- > old/test/java/lang/management/ManagementFactory/ValidateOpenTypes.java > 2009-12-03 16:45:13.000000000 -0800 > +++ > new/test/java/lang/management/ManagementFactory/ValidateOpenTypes.java > 2009-12-03 16:45:13.000000000 -0800 > @@ -28,7 +28,7 @@ > * MBeanServer. > * @author Mandy Chung > * > - * @compile -source 1.5 ValidateOpenTypes.java > + * @compile ValidateOpenTypes.java > * @run main/othervm -verbose:gc ValidateOpenTypes > */ > import java.lang.management.*; > --- > old/test/java/lang/management/RuntimeMXBean/GetSystemProperties.java > 2009-12-03 16:45:14.000000000 -0800 > +++ > new/test/java/lang/management/RuntimeMXBean/GetSystemProperties.java > 2009-12-03 16:45:14.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4990512 > * @summary Basic Test for RuntimeMXBean.getSystemProperties(). > * @author Mandy Chung > - * > - * @compile -source 1.5 GetSystemProperties.java > - * @run main GetSystemProperties > */ > > import java.lang.management.ManagementFactory; > --- old/test/java/lang/management/RuntimeMXBean/TestInputArgument.sh > 2009-12-03 16:45:15.000000000 -0800 > +++ new/test/java/lang/management/RuntimeMXBean/TestInputArgument.sh > 2009-12-03 16:45:15.000000000 -0800 > @@ -27,7 +27,7 @@ > # @summary # @author Mandy Chung > # > -# @run compile -source 1.5 InputArgument.java > +# @run compile InputArgument.java > # @run shell TestInputArgument.sh > # > > --- old/test/java/lang/reflect/Constructor/GenericStringTest.java > 2009-12-03 16:45:16.000000000 -0800 > +++ new/test/java/lang/reflect/Constructor/GenericStringTest.java > 2009-12-03 16:45:16.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 5033583 6316717 6470106 > * @summary Check toGenericString() and toString() methods > * @author Joseph D. Darcy > - * @compile -source 1.5 GenericStringTest.java > - * @run main GenericStringTest > */ > > import java.lang.reflect.*; > --- old/test/java/lang/reflect/Field/GenericStringTest.java > 2009-12-03 16:45:17.000000000 -0800 > +++ new/test/java/lang/reflect/Field/GenericStringTest.java > 2009-12-03 16:45:17.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 5033583 > * @summary Check toGenericString() method > * @author Joseph D. Darcy > - * @compile -source 1.5 GenericStringTest.java > - * @run main GenericStringTest > */ > > import java.lang.reflect.*; > --- old/test/java/lang/reflect/Generics/StringsAndBounds.java > 2009-12-03 16:45:18.000000000 -0800 > +++ new/test/java/lang/reflect/Generics/StringsAndBounds.java > 2009-12-03 16:45:18.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 5015676 4987888 4997464 > * @summary Testing upper bounds and availability of toString methods > * @author Joseph D. Darcy > - * @compile -source 1.5 StringsAndBounds.java > - * @run main StringsAndBounds > */ > > import java.lang.reflect.*; > --- old/test/java/lang/reflect/Generics/TestC1.java 2009-12-03 > 16:45:19.000000000 -0800 > +++ new/test/java/lang/reflect/Generics/TestC1.java 2009-12-03 > 16:45:19.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 4891872 > * @summary Some tests for the generic core reflection api. > * @author Gilad Bracha > -* @compile -source 1.5 TestC1.java > +* @compile TestC1.java > * @run main/othervm -ea TestC1 > */ > > --- old/test/java/lang/reflect/Generics/TestC2.java 2009-12-03 > 16:45:20.000000000 -0800 > +++ new/test/java/lang/reflect/Generics/TestC2.java 2009-12-03 > 16:45:19.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 4891872 > * @summary Some tests for the generic core reflection api. > * @author Gilad Bracha > -* @compile -source 1.5 TestC2.java > +* @compile TestC2.java > * @run main/othervm -ea TestC2 > */ > > --- old/test/java/lang/reflect/Generics/TestN1.java 2009-12-03 > 16:45:21.000000000 -0800 > +++ new/test/java/lang/reflect/Generics/TestN1.java 2009-12-03 > 16:45:20.000000000 -0800 > @@ -26,7 +26,7 @@ > * @bug 4891872 > * @summary Some tests for the generic core reflection api. > * @author Gilad Bracha > -* @compile -source 1.5 TestN1.java > +* @compile TestN1.java > * @run main/othervm -ea TestN1 > */ > > --- old/test/java/lang/reflect/Generics/exceptionCauseTest.java > 2009-12-03 16:45:22.000000000 -0800 > +++ new/test/java/lang/reflect/Generics/exceptionCauseTest.java > 2009-12-03 16:45:21.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4981727 > * @summary > * @author Joseph D. Darcy > - * @compile -source 1.5 exceptionCauseTest.java > - * @run main exceptionCauseTest > */ > > import java.io.PrintStream; > --- old/test/java/lang/reflect/Generics/getAnnotationTest.java > 2009-12-03 16:45:23.000000000 -0800 > +++ new/test/java/lang/reflect/Generics/getAnnotationTest.java > 2009-12-03 16:45:22.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4979440 > * @summary Test for signature parsing corner case > * @author Joseph D. Darcy > - * @compile -source 1.5 getAnnotationTest.java > - * @run main getAnnotationTest > */ > > import java.lang.reflect.*; > --- old/test/java/lang/reflect/Method/Equals.java 2009-12-03 > 16:45:24.000000000 -0800 > +++ new/test/java/lang/reflect/Method/Equals.java 2009-12-03 > 16:45:23.000000000 -0800 > @@ -27,7 +27,7 @@ > * @summary Generic framework to test Method.equals. > * > * @clean A > - * @compile -source 1.5 Equals.java > + * @compile Equals.java > * @run main Equals > */ > > --- old/test/java/lang/reflect/Method/GenericStringTest.java > 2009-12-03 16:45:25.000000000 -0800 > +++ new/test/java/lang/reflect/Method/GenericStringTest.java > 2009-12-03 16:45:24.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 5033583 6316717 6470106 > * @summary Check toGenericString() and toString() methods > * @author Joseph D. Darcy > - * @compile -source 1.5 GenericStringTest.java > - * @run main GenericStringTest > */ > > import java.lang.reflect.*; > --- old/test/java/math/BigDecimal/DivideTests.java 2009-12-03 > 16:45:26.000000000 -0800 > +++ new/test/java/math/BigDecimal/DivideTests.java 2009-12-03 > 16:45:25.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4851776 4907265 6177836 6876282 > * @summary Some tests for the divide methods. > * @author Joseph D. Darcy > - * @compile -source 1.5 DivideTests.java > - * @run main DivideTests > */ > > import java.math.*; > --- old/test/java/math/BigDecimal/IntegralDivisionTests.java > 2009-12-03 16:45:26.000000000 -0800 > +++ new/test/java/math/BigDecimal/IntegralDivisionTests.java > 2009-12-03 16:45:26.000000000 -0800 > @@ -25,8 +25,6 @@ > * @bug 4904082 4917089 6337226 > * @summary Tests that integral division and related methods return the > proper result and scale. > * @author Joseph D. Darcy > - * @compile -source 1.5 IntegralDivisionTests.java > - * @run main IntegralDivisionTests > */ > import java.math.*; > public class IntegralDivisionTests { > --- old/test/java/math/BigDecimal/PowTests.java 2009-12-03 > 16:45:27.000000000 -0800 > +++ new/test/java/math/BigDecimal/PowTests.java 2009-12-03 > 16:45:27.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4916097 > * @summary Some exponent over/undeflow tests for the pow method > * @author Joseph D. Darcy > - * @compile -source 1.5 PowTests.java > - * @run main PowTests > */ > > import java.math.*; > --- old/test/java/math/BigDecimal/ToPlainStringTests.java 2009-12-03 > 16:45:28.000000000 -0800 > +++ new/test/java/math/BigDecimal/ToPlainStringTests.java 2009-12-03 > 16:45:28.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4984872 > * @summary Basic tests of toPlainString method > * @author Joseph D. Darcy > - * @compile -source 1.5 ToPlainStringTests.java > - * @run main ToPlainStringTests > */ > > import java.math.*; > --- old/test/java/math/BigDecimal/ZeroScalingTests.java 2009-12-03 > 16:45:29.000000000 -0800 > +++ new/test/java/math/BigDecimal/ZeroScalingTests.java 2009-12-03 > 16:45:29.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4902952 4905407 4916149 > * @summary Tests that the scale of zero is propagated properly and has > the proper effect. > * @author Joseph D. Darcy > - * @compile -source 1.5 ZeroScalingTests.java > - * @run main ZeroScalingTests > */ > > import java.math.*; > --- old/test/java/math/RoundingMode/RoundingModeTests.java 2009-12-03 > 16:45:30.000000000 -0800 > +++ new/test/java/math/RoundingMode/RoundingModeTests.java 2009-12-03 > 16:45:30.000000000 -0800 > @@ -26,8 +26,6 @@ > * @bug 4851776 4891522 4905335 > * @summary Basic tests for the RoundingMode class. > * @author Joseph D. Darcy > - * @compile -source 1.5 RoundingModeTests.java > - * @run main RoundingModeTests > */ > > import java.math.RoundingMode; > --- old/test/java/net/ProxySelector/ProxyTest.java 2009-12-03 > 16:45:31.000000000 -0800 > +++ new/test/java/net/ProxySelector/ProxyTest.java 2009-12-03 > 16:45:31.000000000 -0800 > @@ -27,7 +27,7 @@ > * @summary HTTP client: Improve proxy server configuration and selection > * @library ../../../sun/net/www/httptest/ > * @build ClosedChannelList HttpServer HttpTransaction HttpCallback > - * @compile -source 1.5 ProxyTest.java > + * @compile ProxyTest.java > * @run main/othervm -Dhttp.proxyHost=inexistant -Dhttp.proxyPort=8080 > ProxyTest > */ > > --- old/test/java/net/URL/PerConnectionProxy.java 2009-12-03 > 16:45:32.000000000 -0800 > +++ new/test/java/net/URL/PerConnectionProxy.java 2009-12-03 > 16:45:32.000000000 -0800 > @@ -26,7 +26,7 @@ > * @summary Needs per connection proxy support for URLs > * @library ../../../sun/net/www/httptest/ > * @build ClosedChannelList HttpServer HttpTransaction HttpCallback > - * @compile -source 1.5 PerConnectionProxy.java > + * @compile PerConnectionProxy.java > * @run main/othervm -Dhttp.proxyHost=inexistant -Dhttp.proxyPort=8080 > PerConnectionProxy > */ > > --- > old/test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java > 2009-12-03 16:45:33.000000000 -0800 > +++ > new/test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java > 2009-12-03 16:45:33.000000000 -0800 > @@ -24,7 +24,7 @@ > /** > * @test > * @test 4422738 > - * @compile -source 1.4 -target 1.4 InvalidParameters.java > + * @compile -source 1.4 InvalidParameters.java > * @run main InvalidParameters > * @summary Make sure PKIXBuilderParameters(Set) detects invalid > * parameters and throws correct exceptions > --- old/test/java/security/cert/PKIXParameters/InvalidParameters.java > 2009-12-03 16:45:34.000000000 -0800 > +++ new/test/java/security/cert/PKIXParameters/InvalidParameters.java > 2009-12-03 16:45:34.000000000 -0800 > @@ -24,7 +24,7 @@ > /** > * @test > * @test 4422738 > - * @compile -source 1.4 -target 1.4 InvalidParameters.java > + * @compile -source 1.4 InvalidParameters.java > * @run main InvalidParameters > * @summary Make sure PKIXParameters(Set) and setTrustAnchors() detects > invalid > * parameters and throws correct exceptions > --- old/test/java/util/AbstractList/CheckForComodification.java > 2009-12-03 16:45:35.000000000 -0800 > +++ new/test/java/util/AbstractList/CheckForComodification.java > 2009-12-03 16:45:35.000000000 -0800 > @@ -28,8 +28,6 @@ > * @author Josh Bloch > * > * @ignore Bug fix temporarily removed as it uncovered other bugs (4992226) > - * @compile -source 1.5 CheckForComodification.java > - * @run main CheckForComodification > */ > > import java.util.*; > --- old/test/java/util/Collections/AddAll.java 2009-12-03 > 16:45:36.000000000 -0800 > +++ new/test/java/util/Collections/AddAll.java 2009-12-03 > 16:45:36.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4822887 > * @summary Basic test for Collections.addAll > * @author Josh Bloch > - * > - * @compile -source 1.5 AddAll.java > - * @run main AddAll > */ > > import java.util.*; > --- old/test/java/util/Collections/Disjoint.java 2009-12-03 > 16:45:37.000000000 -0800 > +++ new/test/java/util/Collections/Disjoint.java 2009-12-03 > 16:45:37.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4339792 > * @summary Basic test for Collections.disjoint > * @author Josh Bloch > - * > - * @compile -source 1.5 Disjoint.java > - * @run main Disjoint > */ > > import java.util.*; > --- old/test/java/util/Collections/Frequency.java 2009-12-03 > 16:45:38.000000000 -0800 > +++ new/test/java/util/Collections/Frequency.java 2009-12-03 > 16:45:38.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4193200 > * @summary Basic test for Collections.frequency > * @author Josh Bloch > - * > - * @compile -source 1.5 Frequency.java > - * @run main Frequency > */ > > import java.util.*; > --- old/test/java/util/EnumMap/EnumMapBash.java 2009-12-03 > 16:45:39.000000000 -0800 > +++ new/test/java/util/EnumMap/EnumMapBash.java 2009-12-03 > 16:45:39.000000000 -0800 > @@ -27,9 +27,6 @@ > * @summary Unit test for EnumMap > * @author Josh Bloch > * @author Yo Yo Ma > - * > - * @compile -source 1.5 EnumMapBash.java > - * @run main EnumMapBash > */ > > import java.util.*; > --- old/test/java/util/EnumSet/AllOf.java 2009-12-03 > 16:45:40.000000000 -0800 > +++ new/test/java/util/EnumSet/AllOf.java 2009-12-03 > 16:45:39.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4946090 > * @summary AllOf static factory is broken in Regular and Jumbo enum set > * @author Josh Bloch > - * > - * @compile -source 1.5 AllOf.java > - * @run main AllOf > */ > > import java.util.*; > --- old/test/java/util/EnumSet/ComplementOf.java 2009-12-03 > 16:45:41.000000000 -0800 > +++ new/test/java/util/EnumSet/ComplementOf.java 2009-12-03 > 16:45:40.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4946096 > * @summary ComplementOf static factory is broken in Regular and Jumbo > enum set > * @author Josh Bloch > - * > - * @compile -source 1.5 ComplementOf.java > - * @run main ComplementOf > */ > > import java.util.*; > --- old/test/java/util/EnumSet/EnumSetBash.java 2009-12-03 > 16:45:42.000000000 -0800 > +++ new/test/java/util/EnumSet/EnumSetBash.java 2009-12-03 > 16:45:41.000000000 -0800 > @@ -28,9 +28,6 @@ > * @author Josh Bloch > * @author Neal Gafter > * @author Yo Ma Ma > - * > - * @compile -source 1.5 EnumSetBash.java > - * @run main EnumSetBash > */ > > import java.util.*; > --- old/test/java/util/EnumSet/JumboRange.java 2009-12-03 > 16:45:43.000000000 -0800 > +++ new/test/java/util/EnumSet/JumboRange.java 2009-12-03 > 16:45:42.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4958003 > * @summary Range static factory fails to compute size in Jumbo enum set > * @author Josh Bloch > - * > - * @compile -source 1.5 JumboRange.java > - * @run main JumboRange > */ > > import java.util.*; > --- old/test/java/util/EnumSet/Range.java 2009-12-03 > 16:45:44.000000000 -0800 > +++ new/test/java/util/EnumSet/Range.java 2009-12-03 > 16:45:43.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4952736 > * @summary Range static factory is broken in Regular and Jumbo enum set > * @author Josh Bloch > - * > - * @compile -source 1.5 Range.java > - * @run main Range > */ > > import java.util.*; > --- old/test/java/util/Formattable/StockName.java 2009-12-03 > 16:45:45.000000000 -0800 > +++ new/test/java/util/Formattable/StockName.java 2009-12-03 > 16:45:44.000000000 -0800 > @@ -21,11 +21,9 @@ > * have any questions. > */ > > -/** > +/* > * @test > * @bug 4965770 4992540 5030716 > - * @compile -source 1.5 StockName.java > - * @run main StockName > */ > > import java.nio.CharBuffer; > --- old/test/java/util/IdentityHashMap/ToString.java 2009-12-03 > 16:45:45.000000000 -0800 > +++ new/test/java/util/IdentityHashMap/ToString.java 2009-12-03 > 16:45:45.000000000 -0800 > @@ -26,9 +26,6 @@ > * @bug 4973432 > * @summary Test that toString on entrySet Iterator/Entry behaves > reasonably > * @author Josh Bloch > - * > - * @compile -source 1.5 ToString.java > - * @run main ToString > */ > > > --- old/test/java/util/Locale/Bug4175998Test.java 2009-12-03 > 16:45:46.000000000 -0800 > +++ new/test/java/util/Locale/Bug4175998Test.java 2009-12-03 > 16:45:46.000000000 -0800 > @@ -23,7 +23,7 @@ > /* > @test > @summary test ISO639-2 language codes > - @compile -encoding ascii -source 1.4 -target 1.4 Bug4175998Test.java > + @compile -encoding ascii -source 5 Bug4175998Test.java > @run main Bug4175998Test > @bug 4175998 > */ > --- old/test/java/util/UUID/UUIDTest.java 2009-12-03 > 16:45:47.000000000 -0800 > +++ new/test/java/util/UUID/UUIDTest.java 2009-12-03 > 16:45:47.000000000 -0800 > @@ -23,8 +23,6 @@ > > /* @test > * @bug 4173528 5068772 > - * @compile -source 1.4 -target 1.4 UUIDTest.java > - * @run main UUIDTest > * @summary Unit tests for java.util.UUID > */ > > --- > old/test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java > 2009-12-03 16:45:48.000000000 -0800 > +++ > new/test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java > 2009-12-03 16:45:48.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 CancelledProducerConsumerLoops.java > + * @compile CancelledProducerConsumerLoops.java > * @run main/timeout=7000 CancelledProducerConsumerLoops > * @summary Checks for responsiveness of blocking queues to cancellation. > * Runs under the assumption that ITERS computations require more than > --- > old/test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java > 2009-12-03 16:45:50.000000000 -0800 > +++ > new/test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java > 2009-12-03 16:45:49.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 MultipleProducersSingleConsumerLoops.java > + * @compile MultipleProducersSingleConsumerLoops.java > * @run main/timeout=3600 MultipleProducersSingleConsumerLoops > * @summary multiple producers and single consumer using blocking queues > */ > --- > old/test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java > 2009-12-03 16:45:51.000000000 -0800 > +++ > new/test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java > 2009-12-03 16:45:51.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 ProducerConsumerLoops.java > + * @compile ProducerConsumerLoops.java > * @run main/timeout=3600 ProducerConsumerLoops > * @summary multiple producers and consumers using blocking queues > */ > --- > old/test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java > 2009-12-03 16:45:52.000000000 -0800 > +++ > new/test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java > 2009-12-03 16:45:52.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 SingleProducerMultipleConsumerLoops.java > + * @compile SingleProducerMultipleConsumerLoops.java > * @run main/timeout=600 SingleProducerMultipleConsumerLoops > * @summary check ordering for blocking queues with 1 producer and > multiple consumers > */ > --- old/test/java/util/concurrent/ConcurrentHashMap/MapCheck.java > 2009-12-03 16:45:53.000000000 -0800 > +++ new/test/java/util/concurrent/ConcurrentHashMap/MapCheck.java > 2009-12-03 16:45:53.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 MapCheck.java > + * @compile MapCheck.java > * @run main/timeout=240 MapCheck > * @summary Times and checks basic map operations > */ > --- old/test/java/util/concurrent/ConcurrentHashMap/MapLoops.java > 2009-12-03 16:45:54.000000000 -0800 > +++ new/test/java/util/concurrent/ConcurrentHashMap/MapLoops.java > 2009-12-03 16:45:54.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 MapLoops.java > + * @compile MapLoops.java > * @run main/timeout=1600 MapLoops > * @summary Exercise multithreaded maps, by default ConcurrentHashMap. > * Multithreaded hash table test. Each thread does a random walk > --- old/test/java/util/concurrent/Exchanger/ExchangeLoops.java > 2009-12-03 16:45:55.000000000 -0800 > +++ new/test/java/util/concurrent/Exchanger/ExchangeLoops.java > 2009-12-03 16:45:55.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 ExchangeLoops.java > + * @compile ExchangeLoops.java > * @run main/timeout=720 ExchangeLoops > * @summary checks to make sure a pipeline of exchangers passes data. > */ > --- > old/test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java > 2009-12-03 16:45:56.000000000 -0800 > +++ > new/test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java > 2009-12-03 16:45:56.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4965960 > - * @compile -source 1.5 ExecutorCompletionServiceLoops.java > + * @compile ExecutorCompletionServiceLoops.java > * @run main/timeout=3600 ExecutorCompletionServiceLoops > * @summary Exercise ExecutorCompletionServiceLoops > */ > --- > old/test/java/util/concurrent/FutureTask/CancelledFutureLoops.java > 2009-12-03 16:45:57.000000000 -0800 > +++ > new/test/java/util/concurrent/FutureTask/CancelledFutureLoops.java > 2009-12-03 16:45:57.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 CancelledFutureLoops.java > + * @compile CancelledFutureLoops.java > * @run main/timeout=2000 CancelledFutureLoops > * @summary Checks for responsiveness of futures to cancellation. > * Runs under the assumption that ITERS computations require more than > --- old/test/java/util/concurrent/atomic/VMSupportsCS8.java > 2009-12-03 16:45:58.000000000 -0800 > +++ new/test/java/util/concurrent/atomic/VMSupportsCS8.java > 2009-12-03 16:45:58.000000000 -0800 > @@ -24,8 +24,6 @@ > /* > * @test > * @bug 4992443 4994819 > - * @compile -source 1.5 VMSupportsCS8.java > - * @run main VMSupportsCS8 > * @summary Checks that the value of VMSupportsCS8 matches system > properties. > */ > > --- > old/test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java > 2009-12-03 16:45:59.000000000 -0800 > +++ > new/test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java > 2009-12-03 16:45:59.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 CancelledLockLoops.java > + * @compile CancelledLockLoops.java > * @run main/timeout=2800 CancelledLockLoops > * @summary tests lockInterruptibly. > * Checks for responsiveness of locks to interrupts. Runs under that > --- > old/test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java > 2009-12-03 16:46:00.000000000 -0800 > +++ > new/test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java > 2009-12-03 16:46:00.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 LockOncePerThreadLoops.java > + * @compile LockOncePerThreadLoops.java > * @run main/timeout=15000 LockOncePerThreadLoops > * @summary Checks for missed signals by locking and unlocking each of > an array of locks once per thread > */ > --- > old/test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java > 2009-12-03 16:46:01.000000000 -0800 > +++ > new/test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java > 2009-12-03 16:46:01.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 SimpleReentrantLockLoops.java > + * @compile SimpleReentrantLockLoops.java > * @run main/timeout=4500 SimpleReentrantLockLoops > * @summary multiple threads using a single lock > */ > --- > old/test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java > 2009-12-03 16:46:02.000000000 -0800 > +++ > new/test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java > 2009-12-03 16:46:02.000000000 -0800 > @@ -34,8 +34,6 @@ > /* > * @test > * @bug 4486658 5031862 > - * @compile -source 1.5 TimeoutLockLoops.java > - * @run main TimeoutLockLoops > * @summary Checks for responsiveness of locks to timeouts. > * Runs under the assumption that ITERS computations require more than > * TIMEOUT msecs to complete, which seems to be a safe assumption for > --- > old/test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java > 2009-12-03 16:46:03.000000000 -0800 > +++ > new/test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java > 2009-12-03 16:46:03.000000000 -0800 > @@ -34,7 +34,7 @@ > /* > * @test > * @bug 4486658 > - * @compile -source 1.5 MapLoops.java > + * @compile MapLoops.java > * @run main/timeout=4700 MapLoops > * @summary Exercise multithreaded maps, by default ConcurrentHashMap. > * Multithreaded hash table test. Each thread does a random walk > --- old/test/sun/management/AgentCheckTest.java 2009-12-03 > 16:46:04.000000000 -0800 > +++ new/test/sun/management/AgentCheckTest.java 2009-12-03 > 16:46:03.000000000 -0800 > @@ -27,9 +27,6 @@ > * @summary Localize log messages from the management agents > * > * @author Tim Bell > - * > - * @run compile -source 1.5 -g AgentCheckTest.java > - * @run main AgentCheckTest > */ > import sun.management.Agent; > > --- old/test/sun/security/util/Oid/S11N.sh 2009-12-03 > 16:46:05.000000000 -0800 > +++ new/test/sun/security/util/Oid/S11N.sh 2009-12-03 > 16:46:04.000000000 -0800 > @@ -99,7 +99,7 @@ > > # the test code > > -${TESTJAVA}${FS}bin${FS}javac -source 1.3 -target 1.3 -d . > ${TESTSRC}${FS}SerialTest.java || exit 10 > +${TESTJAVA}${FS}bin${FS}javac -d . ${TESTSRC}${FS}SerialTest.java || > exit 10 > > OLDJAVA=" > /java/re/j2se/1.6.0/latest/binaries/${PF} > --- old/test/sun/tools/jconsole/ResourceCheckTest.sh 2009-12-03 > 16:46:06.000000000 -0800 > +++ new/test/sun/tools/jconsole/ResourceCheckTest.sh 2009-12-03 > 16:46:05.000000000 -0800 > @@ -98,7 +98,7 @@ > set -vx > # > #Compile. jconsole.jar is required on the classpath. > -${TESTJAVA}/bin/javac -source 1.5 -d "${TESTCLASSES}" ${CP} -g \ > +${TESTJAVA}/bin/javac -d "${TESTCLASSES}" ${CP} -g \ > "${TESTSRC}"/"${TARGETCLASS}".java > # > #Run the test class, again with the classpath we need: > > From joe.darcy at sun.com Fri Dec 4 02:14:04 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 04 Dec 2009 02:14:04 +0000 Subject: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options Message-ID: <20091204021457.0028341DDC@hg.openjdk.java.net> Changeset: 1755493c5774 Author: darcy Date: 2009-12-03 18:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 6907177: Update jdk tests to remove unncessary -source and -target options Reviewed-by: ohair ! test/demo/jvmti/hprof/CpuOldTest.java ! test/demo/jvmti/hprof/CpuSamplesTest.java ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java ! test/demo/jvmti/hprof/CpuTimesTest.java ! test/demo/jvmti/hprof/HeapAllTest.java ! test/demo/jvmti/hprof/HeapBinaryFormatTest.java ! test/demo/jvmti/hprof/HeapDumpTest.java ! test/demo/jvmti/hprof/HeapSitesTest.java ! test/demo/jvmti/hprof/OptionsTest.java ! test/java/io/Serializable/enum/array/Test.java ! test/java/io/Serializable/enum/badResolve/Write.java ! test/java/io/Serializable/enum/basic/Test.java ! test/java/io/Serializable/enum/classObject/Test.java ! test/java/io/Serializable/enum/constantSubclasses/Write.java ! test/java/io/Serializable/enum/ignoreSerializationFields/Test.java ! test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java ! test/java/io/Serializable/enum/mismatchedTypecode/Test.java ! test/java/io/Serializable/enum/missingConstant/Write.java ! test/java/io/Serializable/enum/unshared/Test.java ! test/java/lang/Boolean/MakeBooleanComparable.java ! test/java/lang/Class/Cast.java ! test/java/lang/Class/IsEnum.java ! test/java/lang/Class/asSubclass/BasicUnit.java ! test/java/lang/ClassLoader/Assert.sh ! test/java/lang/Integer/BitTwiddle.java ! test/java/lang/Long/BitTwiddle.java ! test/java/lang/Math/Atan2Tests.java ! test/java/lang/Math/IeeeRecommendedTests.java ! test/java/lang/Math/PowTests.java ! test/java/lang/Math/TanTests.java ! test/java/lang/Runtime/exec/WinCommand.java ! test/java/lang/Thread/GenerifyStackTraces.java ! test/java/lang/Thread/UncaughtExceptions.sh ! test/java/lang/annotation/UnitTest.java ! test/java/lang/annotation/package-info.java ! test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java ! test/java/lang/management/CompositeData/ThreadInfoCompositeData.java ! test/java/lang/management/ManagementFactory/MXBeanProxyTest.java ! test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java ! test/java/lang/management/ManagementFactory/ProxyExceptions.java ! test/java/lang/management/ManagementFactory/ProxyTypeMapping.java ! test/java/lang/management/ManagementFactory/ValidateOpenTypes.java ! test/java/lang/management/RuntimeMXBean/GetSystemProperties.java ! test/java/lang/management/RuntimeMXBean/TestInputArgument.sh ! test/java/lang/reflect/Constructor/GenericStringTest.java ! test/java/lang/reflect/Field/GenericStringTest.java ! test/java/lang/reflect/Generics/StringsAndBounds.java ! test/java/lang/reflect/Generics/TestC1.java ! test/java/lang/reflect/Generics/TestC2.java ! test/java/lang/reflect/Generics/TestN1.java ! test/java/lang/reflect/Generics/exceptionCauseTest.java ! test/java/lang/reflect/Generics/getAnnotationTest.java ! test/java/lang/reflect/Method/Equals.java ! test/java/lang/reflect/Method/GenericStringTest.java ! test/java/math/BigDecimal/DivideTests.java ! test/java/math/BigDecimal/IntegralDivisionTests.java ! test/java/math/BigDecimal/PowTests.java ! test/java/math/BigDecimal/ToPlainStringTests.java ! test/java/math/BigDecimal/ZeroScalingTests.java ! test/java/math/RoundingMode/RoundingModeTests.java ! test/java/net/ProxySelector/ProxyTest.java ! test/java/net/URL/PerConnectionProxy.java ! test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java ! test/java/security/cert/PKIXParameters/InvalidParameters.java ! test/java/util/AbstractList/CheckForComodification.java ! test/java/util/Collections/AddAll.java ! test/java/util/Collections/Disjoint.java ! test/java/util/Collections/Frequency.java ! test/java/util/EnumMap/EnumMapBash.java ! test/java/util/EnumSet/AllOf.java ! test/java/util/EnumSet/ComplementOf.java ! test/java/util/EnumSet/EnumSetBash.java ! test/java/util/EnumSet/JumboRange.java ! test/java/util/EnumSet/Range.java ! test/java/util/Formattable/StockName.java ! test/java/util/IdentityHashMap/ToString.java ! test/java/util/Locale/Bug4175998Test.java ! test/java/util/UUID/UUIDTest.java ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java ! test/java/util/concurrent/ConcurrentHashMap/MapCheck.java ! test/java/util/concurrent/ConcurrentHashMap/MapLoops.java ! test/java/util/concurrent/Exchanger/ExchangeLoops.java ! test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java ! test/java/util/concurrent/FutureTask/CancelledFutureLoops.java ! test/java/util/concurrent/atomic/VMSupportsCS8.java ! test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java ! test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java ! test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java ! test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java ! test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java ! test/sun/management/AgentCheckTest.java ! test/sun/security/util/Oid/S11N.sh ! test/sun/tools/jconsole/ResourceCheckTest.sh From gnu_andrew at member.fsf.org Fri Dec 4 12:21:45 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 4 Dec 2009 12:21:45 +0000 Subject: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options In-Reply-To: <20091204021457.0028341DDC@hg.openjdk.java.net> References: <20091204021457.0028341DDC@hg.openjdk.java.net> Message-ID: <17c6771e0912040421h37edd759xcbeac94fde7fb126@mail.gmail.com> 2009/12/4 : > Changeset: 1755493c5774 > Author: ? ?darcy > Date: ? ? ?2009-12-03 18:19 -0800 > URL: ? ? ? http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 > > 6907177: Update jdk tests to remove unncessary -source and -target options > Reviewed-by: ohair > > ! test/demo/jvmti/hprof/CpuOldTest.java > ! test/demo/jvmti/hprof/CpuSamplesTest.java > ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java > ! test/demo/jvmti/hprof/CpuTimesTest.java > ! test/demo/jvmti/hprof/HeapAllTest.java > ! test/demo/jvmti/hprof/HeapBinaryFormatTest.java > ! test/demo/jvmti/hprof/HeapDumpTest.java > ! test/demo/jvmti/hprof/HeapSitesTest.java > ! test/demo/jvmti/hprof/OptionsTest.java > ! test/java/io/Serializable/enum/array/Test.java > ! test/java/io/Serializable/enum/badResolve/Write.java > ! test/java/io/Serializable/enum/basic/Test.java > ! test/java/io/Serializable/enum/classObject/Test.java > ! test/java/io/Serializable/enum/constantSubclasses/Write.java > ! test/java/io/Serializable/enum/ignoreSerializationFields/Test.java > ! test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java > ! test/java/io/Serializable/enum/mismatchedTypecode/Test.java > ! test/java/io/Serializable/enum/missingConstant/Write.java > ! test/java/io/Serializable/enum/unshared/Test.java > ! test/java/lang/Boolean/MakeBooleanComparable.java > ! test/java/lang/Class/Cast.java > ! test/java/lang/Class/IsEnum.java > ! test/java/lang/Class/asSubclass/BasicUnit.java > ! test/java/lang/ClassLoader/Assert.sh > ! test/java/lang/Integer/BitTwiddle.java > ! test/java/lang/Long/BitTwiddle.java > ! test/java/lang/Math/Atan2Tests.java > ! test/java/lang/Math/IeeeRecommendedTests.java > ! test/java/lang/Math/PowTests.java > ! test/java/lang/Math/TanTests.java > ! test/java/lang/Runtime/exec/WinCommand.java > ! test/java/lang/Thread/GenerifyStackTraces.java > ! test/java/lang/Thread/UncaughtExceptions.sh > ! test/java/lang/annotation/UnitTest.java > ! test/java/lang/annotation/package-info.java > ! test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java > ! test/java/lang/management/CompositeData/ThreadInfoCompositeData.java > ! test/java/lang/management/ManagementFactory/MXBeanProxyTest.java > ! test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java > ! test/java/lang/management/ManagementFactory/ProxyExceptions.java > ! test/java/lang/management/ManagementFactory/ProxyTypeMapping.java > ! test/java/lang/management/ManagementFactory/ValidateOpenTypes.java > ! test/java/lang/management/RuntimeMXBean/GetSystemProperties.java > ! test/java/lang/management/RuntimeMXBean/TestInputArgument.sh > ! test/java/lang/reflect/Constructor/GenericStringTest.java > ! test/java/lang/reflect/Field/GenericStringTest.java > ! test/java/lang/reflect/Generics/StringsAndBounds.java > ! test/java/lang/reflect/Generics/TestC1.java > ! test/java/lang/reflect/Generics/TestC2.java > ! test/java/lang/reflect/Generics/TestN1.java > ! test/java/lang/reflect/Generics/exceptionCauseTest.java > ! test/java/lang/reflect/Generics/getAnnotationTest.java > ! test/java/lang/reflect/Method/Equals.java > ! test/java/lang/reflect/Method/GenericStringTest.java > ! test/java/math/BigDecimal/DivideTests.java > ! test/java/math/BigDecimal/IntegralDivisionTests.java > ! test/java/math/BigDecimal/PowTests.java > ! test/java/math/BigDecimal/ToPlainStringTests.java > ! test/java/math/BigDecimal/ZeroScalingTests.java > ! test/java/math/RoundingMode/RoundingModeTests.java > ! test/java/net/ProxySelector/ProxyTest.java > ! test/java/net/URL/PerConnectionProxy.java > ! test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java > ! test/java/security/cert/PKIXParameters/InvalidParameters.java > ! test/java/util/AbstractList/CheckForComodification.java > ! test/java/util/Collections/AddAll.java > ! test/java/util/Collections/Disjoint.java > ! test/java/util/Collections/Frequency.java > ! test/java/util/EnumMap/EnumMapBash.java > ! test/java/util/EnumSet/AllOf.java > ! test/java/util/EnumSet/ComplementOf.java > ! test/java/util/EnumSet/EnumSetBash.java > ! test/java/util/EnumSet/JumboRange.java > ! test/java/util/EnumSet/Range.java > ! test/java/util/Formattable/StockName.java > ! test/java/util/IdentityHashMap/ToString.java > ! test/java/util/Locale/Bug4175998Test.java > ! test/java/util/UUID/UUIDTest.java > ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java > ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java > ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java > ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java > ! test/java/util/concurrent/ConcurrentHashMap/MapCheck.java > ! test/java/util/concurrent/ConcurrentHashMap/MapLoops.java > ! test/java/util/concurrent/Exchanger/ExchangeLoops.java > ! test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java > ! test/java/util/concurrent/FutureTask/CancelledFutureLoops.java > ! test/java/util/concurrent/atomic/VMSupportsCS8.java > ! test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java > ! test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java > ! test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java > ! test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java > ! test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java > ! test/sun/management/AgentCheckTest.java > ! test/sun/security/util/Oid/S11N.sh > ! test/sun/tools/jconsole/ResourceCheckTest.sh > > Was this really necessary? The options, as far as I can see, were doing no harm but this change means that a compiler that defaults to a version < 1.5 (e.g. ecj) will now fail to compile the tests. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Jonathan.Gibbons at Sun.COM Fri Dec 4 17:22:24 2009 From: Jonathan.Gibbons at Sun.COM (Jonathan Gibbons) Date: Fri, 04 Dec 2009 09:22:24 -0800 Subject: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options In-Reply-To: <17c6771e0912040421h37edd759xcbeac94fde7fb126@mail.gmail.com> References: <20091204021457.0028341DDC@hg.openjdk.java.net> <17c6771e0912040421h37edd759xcbeac94fde7fb126@mail.gmail.com> Message-ID: <4B194550.9070507@sun.com> Andrew John Hughes wrote: > 2009/12/4 : > >> Changeset: 1755493c5774 >> Author: darcy >> Date: 2009-12-03 18:19 -0800 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 >> >> 6907177: Update jdk tests to remove unncessary -source and -target options >> Reviewed-by: ohair >> >> ! test/demo/jvmti/hprof/CpuOldTest.java >> ! test/demo/jvmti/hprof/CpuSamplesTest.java >> ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java >> ! test/demo/jvmti/hprof/CpuTimesTest.java >> ! test/demo/jvmti/hprof/HeapAllTest.java >> ! test/demo/jvmti/hprof/HeapBinaryFormatTest.java >> ! test/demo/jvmti/hprof/HeapDumpTest.java >> ! test/demo/jvmti/hprof/HeapSitesTest.java >> ! test/demo/jvmti/hprof/OptionsTest.java >> ! test/java/io/Serializable/enum/array/Test.java >> ! test/java/io/Serializable/enum/badResolve/Write.java >> ! test/java/io/Serializable/enum/basic/Test.java >> ! test/java/io/Serializable/enum/classObject/Test.java >> ! test/java/io/Serializable/enum/constantSubclasses/Write.java >> ! test/java/io/Serializable/enum/ignoreSerializationFields/Test.java >> ! test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java >> ! test/java/io/Serializable/enum/mismatchedTypecode/Test.java >> ! test/java/io/Serializable/enum/missingConstant/Write.java >> ! test/java/io/Serializable/enum/unshared/Test.java >> ! test/java/lang/Boolean/MakeBooleanComparable.java >> ! test/java/lang/Class/Cast.java >> ! test/java/lang/Class/IsEnum.java >> ! test/java/lang/Class/asSubclass/BasicUnit.java >> ! test/java/lang/ClassLoader/Assert.sh >> ! test/java/lang/Integer/BitTwiddle.java >> ! test/java/lang/Long/BitTwiddle.java >> ! test/java/lang/Math/Atan2Tests.java >> ! test/java/lang/Math/IeeeRecommendedTests.java >> ! test/java/lang/Math/PowTests.java >> ! test/java/lang/Math/TanTests.java >> ! test/java/lang/Runtime/exec/WinCommand.java >> ! test/java/lang/Thread/GenerifyStackTraces.java >> ! test/java/lang/Thread/UncaughtExceptions.sh >> ! test/java/lang/annotation/UnitTest.java >> ! test/java/lang/annotation/package-info.java >> ! test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java >> ! test/java/lang/management/CompositeData/ThreadInfoCompositeData.java >> ! test/java/lang/management/ManagementFactory/MXBeanProxyTest.java >> ! test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java >> ! test/java/lang/management/ManagementFactory/ProxyExceptions.java >> ! test/java/lang/management/ManagementFactory/ProxyTypeMapping.java >> ! test/java/lang/management/ManagementFactory/ValidateOpenTypes.java >> ! test/java/lang/management/RuntimeMXBean/GetSystemProperties.java >> ! test/java/lang/management/RuntimeMXBean/TestInputArgument.sh >> ! test/java/lang/reflect/Constructor/GenericStringTest.java >> ! test/java/lang/reflect/Field/GenericStringTest.java >> ! test/java/lang/reflect/Generics/StringsAndBounds.java >> ! test/java/lang/reflect/Generics/TestC1.java >> ! test/java/lang/reflect/Generics/TestC2.java >> ! test/java/lang/reflect/Generics/TestN1.java >> ! test/java/lang/reflect/Generics/exceptionCauseTest.java >> ! test/java/lang/reflect/Generics/getAnnotationTest.java >> ! test/java/lang/reflect/Method/Equals.java >> ! test/java/lang/reflect/Method/GenericStringTest.java >> ! test/java/math/BigDecimal/DivideTests.java >> ! test/java/math/BigDecimal/IntegralDivisionTests.java >> ! test/java/math/BigDecimal/PowTests.java >> ! test/java/math/BigDecimal/ToPlainStringTests.java >> ! test/java/math/BigDecimal/ZeroScalingTests.java >> ! test/java/math/RoundingMode/RoundingModeTests.java >> ! test/java/net/ProxySelector/ProxyTest.java >> ! test/java/net/URL/PerConnectionProxy.java >> ! test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java >> ! test/java/security/cert/PKIXParameters/InvalidParameters.java >> ! test/java/util/AbstractList/CheckForComodification.java >> ! test/java/util/Collections/AddAll.java >> ! test/java/util/Collections/Disjoint.java >> ! test/java/util/Collections/Frequency.java >> ! test/java/util/EnumMap/EnumMapBash.java >> ! test/java/util/EnumSet/AllOf.java >> ! test/java/util/EnumSet/ComplementOf.java >> ! test/java/util/EnumSet/EnumSetBash.java >> ! test/java/util/EnumSet/JumboRange.java >> ! test/java/util/EnumSet/Range.java >> ! test/java/util/Formattable/StockName.java >> ! test/java/util/IdentityHashMap/ToString.java >> ! test/java/util/Locale/Bug4175998Test.java >> ! test/java/util/UUID/UUIDTest.java >> ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java >> ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java >> ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java >> ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java >> ! test/java/util/concurrent/ConcurrentHashMap/MapCheck.java >> ! test/java/util/concurrent/ConcurrentHashMap/MapLoops.java >> ! test/java/util/concurrent/Exchanger/ExchangeLoops.java >> ! test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java >> ! test/java/util/concurrent/FutureTask/CancelledFutureLoops.java >> ! test/java/util/concurrent/atomic/VMSupportsCS8.java >> ! test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java >> ! test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java >> ! test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java >> ! test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java >> ! test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java >> ! test/sun/management/AgentCheckTest.java >> ! test/sun/security/util/Oid/S11N.sh >> ! test/sun/tools/jconsole/ResourceCheckTest.sh >> >> >> > > Was this really necessary? The options, as far as I can see, were > doing no harm but this change means that a compiler that defaults to a > version < 1.5 (e.g. ecj) will now fail to compile the tests. > This is a JDK test suite and there is no guarantee that any other compiler can be used. All sorts of JDK-specific options may be passed to the compiler, runtime and other tools in these tests. -- Jon -------------- next part -------------- An HTML attachment was scrubbed... URL: From Kelly.Ohair at Sun.COM Fri Dec 4 17:24:49 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 04 Dec 2009 09:24:49 -0800 Subject: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options In-Reply-To: <17c6771e0912040421h37edd759xcbeac94fde7fb126@mail.gmail.com> References: <20091204021457.0028341DDC@hg.openjdk.java.net> <17c6771e0912040421h37edd759xcbeac94fde7fb126@mail.gmail.com> Message-ID: <4B1945E1.5030303@sun.com> Andrew John Hughes wrote: > 2009/12/4 : >> Changeset: 1755493c5774 >> Author: darcy >> Date: 2009-12-03 18:19 -0800 >> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 >> >> 6907177: Update jdk tests to remove unncessary -source and -target options >> Reviewed-by: ohair >> >> ! test/demo/jvmti/hprof/CpuOldTest.java >> ! test/demo/jvmti/hprof/CpuSamplesTest.java >> ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java >> ! test/demo/jvmti/hprof/CpuTimesTest.java >> ! test/demo/jvmti/hprof/HeapAllTest.java >> ! test/demo/jvmti/hprof/HeapBinaryFormatTest.java >> ! test/demo/jvmti/hprof/HeapDumpTest.java >> ! test/demo/jvmti/hprof/HeapSitesTest.java >> ! test/demo/jvmti/hprof/OptionsTest.java >> ! test/java/io/Serializable/enum/array/Test.java >> ! test/java/io/Serializable/enum/badResolve/Write.java >> ! test/java/io/Serializable/enum/basic/Test.java >> ! test/java/io/Serializable/enum/classObject/Test.java >> ! test/java/io/Serializable/enum/constantSubclasses/Write.java >> ! test/java/io/Serializable/enum/ignoreSerializationFields/Test.java >> ! test/java/io/Serializable/enum/ignoreSerializationMethods/Test.java >> ! test/java/io/Serializable/enum/mismatchedTypecode/Test.java >> ! test/java/io/Serializable/enum/missingConstant/Write.java >> ! test/java/io/Serializable/enum/unshared/Test.java >> ! test/java/lang/Boolean/MakeBooleanComparable.java >> ! test/java/lang/Class/Cast.java >> ! test/java/lang/Class/IsEnum.java >> ! test/java/lang/Class/asSubclass/BasicUnit.java >> ! test/java/lang/ClassLoader/Assert.sh >> ! test/java/lang/Integer/BitTwiddle.java >> ! test/java/lang/Long/BitTwiddle.java >> ! test/java/lang/Math/Atan2Tests.java >> ! test/java/lang/Math/IeeeRecommendedTests.java >> ! test/java/lang/Math/PowTests.java >> ! test/java/lang/Math/TanTests.java >> ! test/java/lang/Runtime/exec/WinCommand.java >> ! test/java/lang/Thread/GenerifyStackTraces.java >> ! test/java/lang/Thread/UncaughtExceptions.sh >> ! test/java/lang/annotation/UnitTest.java >> ! test/java/lang/annotation/package-info.java >> ! test/java/lang/management/CompositeData/MemoryNotifInfoCompositeData.java >> ! test/java/lang/management/CompositeData/ThreadInfoCompositeData.java >> ! test/java/lang/management/ManagementFactory/MXBeanProxyTest.java >> ! test/java/lang/management/ManagementFactory/PlatformMBeanServerTest.java >> ! test/java/lang/management/ManagementFactory/ProxyExceptions.java >> ! test/java/lang/management/ManagementFactory/ProxyTypeMapping.java >> ! test/java/lang/management/ManagementFactory/ValidateOpenTypes.java >> ! test/java/lang/management/RuntimeMXBean/GetSystemProperties.java >> ! test/java/lang/management/RuntimeMXBean/TestInputArgument.sh >> ! test/java/lang/reflect/Constructor/GenericStringTest.java >> ! test/java/lang/reflect/Field/GenericStringTest.java >> ! test/java/lang/reflect/Generics/StringsAndBounds.java >> ! test/java/lang/reflect/Generics/TestC1.java >> ! test/java/lang/reflect/Generics/TestC2.java >> ! test/java/lang/reflect/Generics/TestN1.java >> ! test/java/lang/reflect/Generics/exceptionCauseTest.java >> ! test/java/lang/reflect/Generics/getAnnotationTest.java >> ! test/java/lang/reflect/Method/Equals.java >> ! test/java/lang/reflect/Method/GenericStringTest.java >> ! test/java/math/BigDecimal/DivideTests.java >> ! test/java/math/BigDecimal/IntegralDivisionTests.java >> ! test/java/math/BigDecimal/PowTests.java >> ! test/java/math/BigDecimal/ToPlainStringTests.java >> ! test/java/math/BigDecimal/ZeroScalingTests.java >> ! test/java/math/RoundingMode/RoundingModeTests.java >> ! test/java/net/ProxySelector/ProxyTest.java >> ! test/java/net/URL/PerConnectionProxy.java >> ! test/java/security/cert/PKIXBuilderParameters/InvalidParameters.java >> ! test/java/security/cert/PKIXParameters/InvalidParameters.java >> ! test/java/util/AbstractList/CheckForComodification.java >> ! test/java/util/Collections/AddAll.java >> ! test/java/util/Collections/Disjoint.java >> ! test/java/util/Collections/Frequency.java >> ! test/java/util/EnumMap/EnumMapBash.java >> ! test/java/util/EnumSet/AllOf.java >> ! test/java/util/EnumSet/ComplementOf.java >> ! test/java/util/EnumSet/EnumSetBash.java >> ! test/java/util/EnumSet/JumboRange.java >> ! test/java/util/EnumSet/Range.java >> ! test/java/util/Formattable/StockName.java >> ! test/java/util/IdentityHashMap/ToString.java >> ! test/java/util/Locale/Bug4175998Test.java >> ! test/java/util/UUID/UUIDTest.java >> ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java >> ! test/java/util/concurrent/BlockingQueue/MultipleProducersSingleConsumerLoops.java >> ! test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java >> ! test/java/util/concurrent/BlockingQueue/SingleProducerMultipleConsumerLoops.java >> ! test/java/util/concurrent/ConcurrentHashMap/MapCheck.java >> ! test/java/util/concurrent/ConcurrentHashMap/MapLoops.java >> ! test/java/util/concurrent/Exchanger/ExchangeLoops.java >> ! test/java/util/concurrent/ExecutorCompletionService/ExecutorCompletionServiceLoops.java >> ! test/java/util/concurrent/FutureTask/CancelledFutureLoops.java >> ! test/java/util/concurrent/atomic/VMSupportsCS8.java >> ! test/java/util/concurrent/locks/ReentrantLock/CancelledLockLoops.java >> ! test/java/util/concurrent/locks/ReentrantLock/LockOncePerThreadLoops.java >> ! test/java/util/concurrent/locks/ReentrantLock/SimpleReentrantLockLoops.java >> ! test/java/util/concurrent/locks/ReentrantLock/TimeoutLockLoops.java >> ! test/java/util/concurrent/locks/ReentrantReadWriteLock/MapLoops.java >> ! test/sun/management/AgentCheckTest.java >> ! test/sun/security/util/Oid/S11N.sh >> ! test/sun/tools/jconsole/ResourceCheckTest.sh >> >> > > Was this really necessary? The options, as far as I can see, were > doing no harm but this change means that a compiler that defaults to a > version < 1.5 (e.g. ecj) will now fail to compile the tests. I thought these tests were primarily for the jdk we are building, a jdk6 jdk, containing a jdk6 javac. Are you saying that some openjdk6 builds out there do not contain the langtools version of javac? Or are you just requesting that we provide tests in openjdk6 for all javac compilers? -kto From Joe.Darcy at Sun.COM Fri Dec 4 18:03:17 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Fri, 04 Dec 2009 10:03:17 -0800 Subject: hg: jdk7/tl/jdk: 6907177: Update jdk tests to remove unncessary -source and -target options In-Reply-To: <4B194550.9070507@sun.com> References: <20091204021457.0028341DDC@hg.openjdk.java.net> <17c6771e0912040421h37edd759xcbeac94fde7fb126@mail.gmail.com> <4B194550.9070507@sun.com> Message-ID: <4B194EE5.9040005@sun.com> Jonathan Gibbons wrote: > Andrew John Hughes wrote: >> 2009/12/4 : >> >>> Changeset: 1755493c5774 >>> Author: darcy >>> Date: 2009-12-03 18:19 -0800 >>> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1755493c5774 >>> >>> 6907177: Update jdk tests to remove unncessary -source and -target options >>> Reviewed-by: ohair >>> >>> ! test/demo/jvmti/hprof/CpuOldTest.java >>> >>> [snip] >>> ! test/sun/tools/jconsole/ResourceCheckTest.sh >>> >>> >>> >> >> Was this really necessary? The options, as far as I can see, were >> doing no harm but this change means that a compiler that defaults to a >> version < 1.5 (e.g. ecj) will now fail to compile the tests. >> > This is a JDK test suite and there is no guarantee that any other > compiler can be used. All sorts of JDK-specific options may be passed > to the compiler, runtime and other tools in these tests. > Yes, these tests are part of the JDK 7 regression test suite. Interoperability with other compilers, even other compilers from related code bases like OpenJDK 6, is a non-goal. Having the old -source options in the tests was at least in a small way reducing the effectiveness of the test suite since the default -source setting is now 7. Using of new language features in tests, even tests not targeting those language features is certainly encouraged. As explained in my code review request on corelib-dev, many of the -source directives dated to back in JDK 5 before the default sourced was upped from 1.4 to 5. Tests written later in JDK 5 that use JDK 5 language features didn't have explicit -source settings. While the build environment for most programs should explicitly set source, target, and encoding, "Build Advice: Set Source, Target, and Encoding" http://blogs.sun.com/darcy/entry/build_advice_set_source_target the regressions tests of the JDK itself are (usually) an exception. -Joe From Ulf.Zibis at gmx.de Mon Dec 7 01:11:32 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 07 Dec 2009 02:11:32 +0100 Subject: package javax.lang missing in OpenJDK sources Message-ID: <4B1C5644.80109@gmx.de> Hi, in class java.lang.Character in javadoc of method isJavaIdentifierStart(char ch) I find reference: @see javax.lang.model.SourceVersion#isIdentifier(CharSequence) But there is no package javax.lang in OpenJDK sources. =-O -Ulf From Joe.Darcy at Sun.COM Mon Dec 7 01:16:38 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Sun, 06 Dec 2009 17:16:38 -0800 Subject: package javax.lang missing in OpenJDK sources In-Reply-To: <4B1C5644.80109@gmx.de> References: <4B1C5644.80109@gmx.de> Message-ID: <4B1C5776.7020400@sun.com> Ulf Zibis wrote: > Hi, > > in class java.lang.Character in javadoc of method > isJavaIdentifierStart(char ch) I find reference: > @see javax.lang.model.SourceVersion#isIdentifier(CharSequence) > > But there is no package javax.lang in OpenJDK sources. =-O Yes there is, but is lives in the langtools repository rather than the jdk repo. -Joe From Ulf.Zibis at gmx.de Mon Dec 7 02:18:03 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 07 Dec 2009 03:18:03 +0100 Subject: package javax.lang missing in OpenJDK sources In-Reply-To: <4B1C5776.7020400@sun.com> References: <4B1C5644.80109@gmx.de> <4B1C5776.7020400@sun.com> Message-ID: <4B1C65DB.8050009@gmx.de> Thanks, OK, but it's too missing here: http://www.java.net/download/openjdk/jdk7/promoted/b76/openjdk-7-ea-src-b76-12_nov_2009.zip http://www.java.net/download/jdk7/archive/b76/jdk-7-ea-src-b76-jrl-12_nov_2009.jar -Ulf Am 07.12.2009 02:16, Joseph D. Darcy schrieb: > Ulf Zibis wrote: >> Hi, >> >> in class java.lang.Character in javadoc of method >> isJavaIdentifierStart(char ch) I find reference: >> @see javax.lang.model.SourceVersion#isIdentifier(CharSequence) >> >> But there is no package javax.lang in OpenJDK sources. =-O > > Yes there is, but is lives in the langtools repository rather than the > jdk repo. > > -Joe > > From weijun.wang at sun.com Mon Dec 7 07:32:12 2009 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Mon, 07 Dec 2009 07:32:12 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20091207073425.5B99C416B6@hg.openjdk.java.net> Changeset: 0f494453cd0a Author: weijun Date: 2009-12-07 15:27 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f494453cd0a 6879540: enable empty password for kerberos 5 Reviewed-by: valeriep, wetmore ! src/share/classes/com/sun/crypto/provider/HmacCore.java ! src/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java Changeset: 17be46c2f853 Author: weijun Date: 2009-12-07 15:29 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/17be46c2f853 6886058: JNDI LDAP InitialLdapContext SECURITY_CREDENTIALS byte[] can be corrupted, then LDAP referral fails Reviewed-by: vinnie, xuelei ! src/share/classes/javax/naming/InitialContext.java ! src/share/classes/javax/naming/directory/InitialDirContext.java ! src/share/classes/javax/naming/ldap/InitialLdapContext.java From Christian.Thalinger at Sun.COM Mon Dec 7 10:19:56 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Mon, 07 Dec 2009 11:19:56 +0100 Subject: Character.java methods are slower than Surrogate.java's In-Reply-To: <4AE8BB55.30506@gmx.de> References: <4AE8BB55.30506@gmx.de> Message-ID: <1260181196.7680.27.camel@macbook> On Wed, 2009-10-28 at 22:44 +0100, Ulf Zibis wrote: > Hi Christian, > > for a benchmark test I have replaced all sun.nio.cs.Surrogate methods in > sun.nio.cs.ext.EUC_TW with corresponding ones from java.lang.Character. > > As result, the overall encoding performance was 10 % worse, so > java.lang.Character's methods must be much worser. > > Can you have a look, if there is a chance to better optimize > java.lang.Character methods from HotSpot compiler side. I think you're already looking into this yourself. -- Christian From Ulf.Zibis at gmx.de Mon Dec 7 13:48:10 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 07 Dec 2009 14:48:10 +0100 Subject: Character.java methods are slower than Surrogate.java's In-Reply-To: <1260181196.7680.27.camel@macbook> References: <4AE8BB55.30506@gmx.de> <1260181196.7680.27.camel@macbook> Message-ID: <4B1D079A.7070209@gmx.de> Am 07.12.2009 11:19, Christian Thalinger schrieb: > On Wed, 2009-10-28 at 22:44 +0100, Ulf Zibis wrote: > >> Hi Christian, >> >> for a benchmark test I have replaced all sun.nio.cs.Surrogate methods in >> sun.nio.cs.ext.EUC_TW with corresponding ones from java.lang.Character. >> >> As result, the overall encoding performance was 10 % worse, so >> java.lang.Character's methods must be much worser. >> >> Can you have a look, if there is a chance to better optimize >> java.lang.Character methods from HotSpot compiler side. >> > > I think you're already looking into this yourself. -- Christian > > > Yes, correct, I'm trying... -Ulf From vincent.ryan at sun.com Mon Dec 7 18:21:14 2009 From: vincent.ryan at sun.com (vincent.ryan at sun.com) Date: Mon, 07 Dec 2009 18:21:14 +0000 Subject: hg: jdk7/tl/jdk: 6876158: Remove dependencies on Signer, Certificate, Identity, IdentityScope classes from java.security pkg Message-ID: <20091207182211.98F7F41409@hg.openjdk.java.net> Changeset: 327adb1c2224 Author: vinnie Date: 2009-12-07 17:06 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/327adb1c2224 6876158: Remove dependencies on Signer, Certificate, Identity, IdentityScope classes from java.security pkg Reviewed-by: alanb, mullan ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/sun/security/pkcs/PKCS10.java - src/share/classes/sun/security/provider/IdentityDatabase.java ! src/share/classes/sun/security/provider/PolicyFile.java - src/share/classes/sun/security/provider/SystemIdentity.java - src/share/classes/sun/security/provider/SystemSigner.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/x509/CertAndKeyGen.java - src/share/classes/sun/security/x509/X500Signer.java - src/share/classes/sun/security/x509/X509Cert.java - src/share/classes/sun/tools/jar/JarVerifierStream.java From Dalibor.Topic at Sun.COM Mon Dec 7 18:56:07 2009 From: Dalibor.Topic at Sun.COM (Dalibor Topic) Date: Mon, 07 Dec 2009 19:56:07 +0100 Subject: package javax.lang missing in OpenJDK sources In-Reply-To: <4B1C65DB.8050009@gmx.de> References: <4B1C5644.80109@gmx.de> <4B1C5776.7020400@sun.com> <4B1C65DB.8050009@gmx.de> Message-ID: <4B1D4FC7.9030909@sun.com> Ulf Zibis wrote: > Thanks, OK, but it's too missing here: > http://www.java.net/download/openjdk/jdk7/promoted/b76/openjdk-7-ea-src-b76-12_nov_2009.zip I think I found it for you: $ unzip -l openjdk-7-ea-src-b76-12_nov_2009.zip | grep javax.lang 0 11-12-09 14:05 openjdk/langtools/src/share/classes/javax/lang/ 0 11-12-09 14:05 openjdk/langtools/src/share/classes/javax/lang/model/ 8660 11-12-09 09:48 openjdk/langtools/src/share/classes/javax/lang/model/SourceVersion.java [snip] cheers, dalibor topic -- ******************************************************************* Dalibor Topic Tel: (+49 40) 23 646 738 Java F/OSS Ambassador AIM: robiladonaim Sun Microsystems GmbH Mobile: (+49 177) 2664 192 Nagelsweg 55 http://openjdk.java.net D-20097 Hamburg mailto:Dalibor.Topic at sun.com Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht M?nchen: HRB 161028 Gesch?ftsf?hrer: Thomas Schr?der, Wolfgang Engels, Wolf Frenkel Vorsitzender des Aufsichtsrates: Martin H?ring From Ulf.Zibis at gmx.de Mon Dec 7 20:07:17 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 07 Dec 2009 21:07:17 +0100 Subject: package javax.lang missing in OpenJDK sources In-Reply-To: <4B1D4FC7.9030909@sun.com> References: <4B1C5644.80109@gmx.de> <4B1C5776.7020400@sun.com> <4B1C65DB.8050009@gmx.de> <4B1D4FC7.9030909@sun.com> Message-ID: <4B1D6075.4060904@gmx.de> Am 07.12.2009 19:56, Dalibor Topic schrieb: > Ulf Zibis wrote: > >> Thanks, OK, but it's too missing here: >> http://www.java.net/download/openjdk/jdk7/promoted/b76/openjdk-7-ea-src-b76-12_nov_2009.zip >> > > I think I found it for you: > > $ unzip -l openjdk-7-ea-src-b76-12_nov_2009.zip | grep javax.lang > 0 11-12-09 14:05 openjdk/langtools/src/share/classes/javax/lang/ > 0 11-12-09 14:05 openjdk/langtools/src/share/classes/javax/lang/model/ > 8660 11-12-09 09:48 openjdk/langtools/src/share/classes/javax/lang/model/SourceVersion.java > [snip] > > cheers, > dalibor topic > Oops, I was in the assumption, that all sources, found in src.zip must come from jdk tree. Much thanks Dalibor. Cheers to Hamburg, -Ulf From Kelly.Ohair at Sun.COM Mon Dec 7 20:15:49 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Mon, 07 Dec 2009 12:15:49 -0800 Subject: Need reviewers, jdk7 testing changes Message-ID: <4B1D6275.1060704@sun.com> Need reviewer for JDK7 testing changes, e.g. testing via: cd jdk/make && gmake all images && cd ../test && gmake jdk_all 6906210: Fix another minor typo in test/Makefile http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ Dan had pointed out my typo in the jdk/test/Makefile ($->$$) but when I started running and re-running the tests I ran into more unstable tests. This webrev includes fixes to 3 tests and unfortuntately more additions to the ProblemList file. Tests added to the ProblemList: javax/management/remote/mandatory/connection/ReconnectTest.java sun/net/www/protocol/http/DigestTest.java java/net/ProxySelector/B6737819.java java/io/File/SetLastModified.java java/nio/channels/DatagramChannel/SRTest.java java/nio/channels/DatagramChannel/Sender.java java/nio/channels/Selector/SelectWrite.java java/nio/channels/DatagramChannel/EmptyBuffer.java java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java java/util/Collection/MOAT.java java/nio/channels/AsynchronousSocketChannel/Basic.java java/nio/channels/AsynchronousChannelGroup/Unbounded.java java/nio/channels/FileChannel/Transfer.java sun/security/krb5/auto/HttpNegotiateServer.java sun/security/util/Oid/S11N.sh sun/security/krb5/auto/NonMutualSpnego.java sun/security/krb5/auto/ok-as-delegate.sh sun/security/krb5/auto/ok-as-delegate-xrealm.sh sun/security/mscapi/AccessKeyStore.sh sun/security/pkcs11/KeyAgreement/TestDH.java sun/security/pkcs11/fips/ClientJSSEServerJSSE.java sun/security/krb5/auto/basic.sh sun/security/pkcs11/KeyAgreement/TestDH.java sun/tools/jstatd/jstatdDefaults.sh sun/tools/jstatd/jstatdExternalRegistry.sh sun/tools/jps/jps-v_1.sh java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java Some of this is 'as expected' in that the testcases may rely on using the same filename or port number, and until two tests using the same filename or port collide at runtime, you just don't know. If I got it wrong, let me know, I will correct the list. -kto From jjb at google.com Mon Dec 7 20:32:45 2009 From: jjb at google.com (Joshua Bloch) Date: Mon, 7 Dec 2009 12:32:45 -0800 Subject: Yet another DPQ update Message-ID: <17b2302a0912071232u2509c87drc4a8f337305cdf31@mail.gmail.com> Folks, Hi. Here's another update for Dual Partition Quicksort: http://cr.openjdk.java.net/~alanb/6905046/webrev/ Summary of changes: * Improved comments throughout * Minor code changes for clarity (e.g., swapped order of some comparisons) * Further optimized partitioning performance * Restored sentinel optimization in "pivots are equal" case that was accidentally deleted. Added comment so it won't be deleted again. This version (12i) is about 3% faster than version 12a on random data, 10-30% faster on duplicate-rich data, and 1-3% slower on pre-sorted (ascending/descending) data: http://spreadsheets.google.com/pub?key=tHOi6AmWiKOyaX4qqg5VrAg&single=true&gid=0&output=html The DPQ team (Vladimir, Jon, and Josh) -------------- next part -------------- An HTML attachment was scrubbed... URL: From alan.bateman at sun.com Mon Dec 7 20:53:43 2009 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Mon, 07 Dec 2009 20:53:43 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20091207205439.EDF6A41434@hg.openjdk.java.net> Changeset: c68f6b6b47fd Author: alanb Date: 2009-12-07 12:24 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c68f6b6b47fd 6903753: (se) Selector should implement Closeable Reviewed-by: chegar, forax ! src/share/classes/java/nio/channels/Selector.java Changeset: 587fa61c0f07 Author: alanb Date: 2009-12-07 12:29 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/587fa61c0f07 6902010: (cl) Delay initialization of ClassLoader.parallelLoaders Reviewed-by: forax, mchung, valeriep ! src/share/classes/java/lang/ClassLoader.java Changeset: 63cab9078ac2 Author: alanb Date: 2009-12-07 20:25 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63cab9078ac2 Merge - src/share/classes/sun/security/provider/IdentityDatabase.java - src/share/classes/sun/security/provider/SystemIdentity.java - src/share/classes/sun/security/provider/SystemSigner.java - src/share/classes/sun/security/x509/X500Signer.java - src/share/classes/sun/security/x509/X509Cert.java - src/share/classes/sun/tools/jar/JarVerifierStream.java From Tim.Bell at Sun.COM Mon Dec 7 21:43:53 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Mon, 07 Dec 2009 13:43:53 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <4B1D6275.1060704@sun.com> References: <4B1D6275.1060704@sun.com> Message-ID: <4B1D7719.9000606@sun.com> Hi Kelly See below: > Need reviewer for JDK7 testing changes, e.g. testing via: > cd jdk/make && gmake all images && cd ../test && gmake jdk_all > > 6906210: Fix another minor typo in test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ > > Dan had pointed out my typo in the jdk/test/Makefile ($->$$) > but when I started running and re-running the tests I ran into > more unstable tests. This webrev includes fixes to 3 tests > and unfortuntately more additions to the ProblemList file. > > Tests added to the ProblemList: > javax/management/remote/mandatory/connection/ReconnectTest.java > sun/net/www/protocol/http/DigestTest.java > java/net/ProxySelector/B6737819.java > java/io/File/SetLastModified.java > java/nio/channels/DatagramChannel/SRTest.java > java/nio/channels/DatagramChannel/Sender.java > java/nio/channels/Selector/SelectWrite.java > java/nio/channels/DatagramChannel/EmptyBuffer.java > java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java > java/util/Collection/MOAT.java It is a shame we have to exclude Martin's MOAT.java (Mother Of All Tests) The comment shows the test failing on Solaris 10 x86, but you exclude it on generic-all Would it be a separate project to go through the excluded tests and tighten up the exclusions by (for example) moving MOAT.java to solaris-x64? Approved otherwise. Tim > java/nio/channels/AsynchronousSocketChannel/Basic.java > java/nio/channels/AsynchronousChannelGroup/Unbounded.java > java/nio/channels/FileChannel/Transfer.java > sun/security/krb5/auto/HttpNegotiateServer.java > sun/security/util/Oid/S11N.sh > sun/security/krb5/auto/NonMutualSpnego.java > sun/security/krb5/auto/ok-as-delegate.sh > sun/security/krb5/auto/ok-as-delegate-xrealm.sh > sun/security/mscapi/AccessKeyStore.sh > sun/security/pkcs11/KeyAgreement/TestDH.java > sun/security/pkcs11/fips/ClientJSSEServerJSSE.java > sun/security/krb5/auto/basic.sh > sun/security/pkcs11/KeyAgreement/TestDH.java > sun/tools/jstatd/jstatdDefaults.sh > sun/tools/jstatd/jstatdExternalRegistry.sh > sun/tools/jps/jps-v_1.sh > java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java > java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java > > Some of this is 'as expected' in that the testcases may rely on > using the same filename or port number, and until two tests using > the same filename or port collide at runtime, you just don't know. > > If I got it wrong, let me know, I will correct the list. > > -kto > From jonathan.gibbons at sun.com Mon Dec 7 22:37:14 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Mon, 07 Dec 2009 22:37:14 +0000 Subject: hg: jdk7/tl/langtools: 6907660: stupid typo in ZipFileIndex guarantees NPE Message-ID: <20091207223721.E1AEF41451@hg.openjdk.java.net> Changeset: ea89c5d4af08 Author: jjg Date: 2009-12-07 14:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ea89c5d4af08 6907660: stupid typo in ZipFileIndex guarantees NPE Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java From martinrb at google.com Mon Dec 7 23:58:24 2009 From: martinrb at google.com (martinrb at google.com) Date: Mon, 07 Dec 2009 23:58:24 +0000 Subject: hg: jdk7/tl/jdk: 6905029: Broken links in Deflater and DeflaterOutputStream javadoc Message-ID: <20091207235843.3CA6D4146A@hg.openjdk.java.net> Changeset: e47e55b6ecf6 Author: martin Date: 2009-12-07 15:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e47e55b6ecf6 6905029: Broken links in Deflater and DeflaterOutputStream javadoc Summary: Fix syntax errors in @links Reviewed-by: alanb ! src/share/classes/java/util/zip/Deflater.java ! src/share/classes/java/util/zip/DeflaterOutputStream.java From martinrb at google.com Tue Dec 8 00:45:55 2009 From: martinrb at google.com (martinrb at google.com) Date: Tue, 08 Dec 2009 00:45:55 +0000 Subject: hg: jdk7/tl/jdk: 6900043: Add method to return line.separator property Message-ID: <20091208004614.9120341480@hg.openjdk.java.net> Changeset: 0dcdb13ab6d0 Author: martin Date: 2009-12-07 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0dcdb13ab6d0 6900043: Add method to return line.separator property Summary: Add System.lineSeparator(), returning getProperty("line.separator") Reviewed-by: darcy ! src/share/classes/java/lang/System.java ! src/share/classes/java/util/Formatter.java From martinrb at google.com Tue Dec 8 07:30:43 2009 From: martinrb at google.com (Martin Buchholz) Date: Mon, 7 Dec 2009 23:30:43 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <4B1D7719.9000606@sun.com> References: <4B1D6275.1060704@sun.com> <4B1D7719.9000606@sun.com> Message-ID: <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> On Mon, Dec 7, 2009 at 13:43, Tim Bell wrote: >> ? ?java/util/Collection/MOAT.java > > It is a shame we have to exclude Martin's MOAT.java (Mother Of All Tests) > The comment shows the test failing on Solaris 10 x86, but you exclude > it on generic-all You cannot exclude the Mother Of All Tests. This is non-negotiable. Martin From alan.bateman at sun.com Tue Dec 8 12:43:31 2009 From: alan.bateman at sun.com (alan.bateman at sun.com) Date: Tue, 08 Dec 2009 12:43:31 +0000 Subject: hg: jdk7/tl/jdk: 6905046: More Dual-pivot quicksort improvements Message-ID: <20091208124350.568E341552@hg.openjdk.java.net> Changeset: 146c8921267f Author: jjb Date: 2009-12-08 12:40 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/146c8921267f 6905046: More Dual-pivot quicksort improvements Summary: More improvements from the DPQ team Reviewed-by: alanb ! src/share/classes/java/util/DualPivotQuicksort.java From Alan.Bateman at Sun.COM Tue Dec 8 12:50:11 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 08 Dec 2009 12:50:11 +0000 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <4B1D6275.1060704@sun.com> References: <4B1D6275.1060704@sun.com> Message-ID: <4B1E4B83.7010308@sun.com> Kelly O'Hair wrote: > > : > > Dan had pointed out my typo in the jdk/test/Makefile ($->$$) > but when I started running and re-running the tests I ran into > more unstable tests. This webrev includes fixes to 3 tests > and unfortuntately more additions to the ProblemList file. It would be good to create a bug (or ensure there is an existing bug) for any tests that you add to the list. > > : > java/io/File/SetLastModified.java I tried to duplicate this without success. Is the test directory on a SAMBA drive when it fails? > java/nio/channels/DatagramChannel/SRTest.java > java/nio/channels/DatagramChannel/Sender.java > java/nio/channels/Selector/SelectWrite.java > java/nio/channels/DatagramChannel/EmptyBuffer.java The older NIO test uses a fixed port which is problematic when tests run in parallel. One of these days/weeks I will fix all these issues (they manifest in various forms including hangs during initialization, or address already in use errors). > java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java This is an important test and I'd like to track down the reason it failed for you rather than excluding it. > java/util/Collection/MOAT.java Over Martin's dead body :-) > java/nio/channels/AsynchronousSocketChannel/Basic.java Excluding this test will eliminate almost all test coverage of AsynchronousSocketChannel so I don't think we should exclude it. I see that the issue is a connection to a non-existent host is failing immediately whereas the test expects it to timeout. I'll fix the test to handle this case in b79. > java/nio/channels/AsynchronousChannelGroup/Unbounded.java As Windows 2000 Pro was EOL'ed eons ago we didn't put any effort into the asynchronous I/O implementation to support that edition (it needs Windows XP or newer). Can you just exclude this with windows-5.0 rather than generic-all so that it continues to run on other platforms? > java/nio/channels/FileChannel/Transfer.java This test does take a long time on Windows. I'd be interested to see the log as the right solution might be to increase the timeout or else just exclude it on windows-5.0 (not generic-all as the test provides important coverage). -Alan. From Kelly.Ohair at Sun.COM Tue Dec 8 19:19:48 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 08 Dec 2009 11:19:48 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> References: <4B1D6275.1060704@sun.com> <4B1D7719.9000606@sun.com> <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> Message-ID: <4B1EA6D4.8060304@sun.com> Martin Buchholz wrote: > On Mon, Dec 7, 2009 at 13:43, Tim Bell wrote: >>> java/util/Collection/MOAT.java >> It is a shame we have to exclude Martin's MOAT.java (Mother Of All Tests) >> The comment shows the test failing on Solaris 10 x86, but you exclude >> it on generic-all > > You cannot exclude the Mother Of All Tests. > This is non-negotiable. > > Martin This is a problem list, and although I'm using it to exclude tests from the jdk/test/Makefile jdk_* targets, there are multiple reasons why a test is listed. If I'm wrong, I'll fix it. I don't want to pick on your Mother test, and I will try and see why it failed and de-list it if at all possible. Alan had similar issues and so far we can't reproduce some of the nio test failures either. I have to admit that it could have been "system fuzz" that caused the failures in some cases. :^( My initial attitude had been pretty strict, if a test failed when all the other tests in it's batch passed, I had little mercy on it. But from now on, I will see if I can reproduce the failure. If I can reproduce the failure, and it appears to be a testcase issue, I will be filing a bug. I'll also be going back over the tests in the ProblemList and either filing testcase bugs or jdk bugs, perhaps for batches of tests, not one bug per testcase, my fellow developers might do me great bodily harm if I filed hundreds of testcase bugs. :^( -kto From martinrb at google.com Tue Dec 8 20:59:11 2009 From: martinrb at google.com (martinrb at google.com) Date: Tue, 08 Dec 2009 20:59:11 +0000 Subject: hg: jdk7/tl/jdk: 6903754: (bf) Improve floating-point buffer comparison Message-ID: <20091208205934.8F53B41600@hg.openjdk.java.net> Changeset: a0f6963b1618 Author: martin Date: 2009-12-08 12:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a0f6963b1618 6903754: (bf) Improve floating-point buffer comparison Summary: Describe the exact behavior of {Double,Float}Buffer.{equals,compareTo}; fix non-anti-symmetric behavior of compareTo Reviewed-by: alanb Contributed-by: jessewilson at google.com ! make/java/nio/genBuffer.sh ! src/share/classes/java/nio/X-Buffer.java.template ! test/java/nio/Buffer/Basic-X.java.template ! test/java/nio/Buffer/BasicByte.java ! test/java/nio/Buffer/BasicChar.java ! test/java/nio/Buffer/BasicDouble.java ! test/java/nio/Buffer/BasicFloat.java ! test/java/nio/Buffer/BasicInt.java ! test/java/nio/Buffer/BasicLong.java ! test/java/nio/Buffer/BasicShort.java ! test/java/nio/Buffer/genBasic.sh From Joe.Darcy at Sun.COM Tue Dec 8 21:41:17 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Tue, 08 Dec 2009 13:41:17 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <4B1D6275.1060704@sun.com> References: <4B1D6275.1060704@sun.com> Message-ID: <4B1EC7FD.4090704@sun.com> Kelly O'Hair wrote: > > Need reviewer for JDK7 testing changes, e.g. testing via: > cd jdk/make && gmake all images && cd ../test && gmake jdk_all > > 6906210: Fix another minor typo in test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ > > Dan had pointed out my typo in the jdk/test/Makefile ($->$$) > but when I started running and re-running the tests I ran into > more unstable tests. This webrev includes fixes to 3 tests > and unfortuntately more additions to the ProblemList file. > > Tests added to the ProblemList: A few comments on problem list membership: 366 # Need to be marked othervm, or changed to be samevm safe 367 java/lang/annotation/ParameterAnnotations.java generic-all This test uses a security manager. 499 # Problems with rounding add failures on solaris-sparcv9 and -server 500 java/math/BigDecimal/AddTests.java solaris-sparcv9 If this test is failing on a particular platform, that is indicative of a HotSpot bug on that platform. 502 # Problems on windows with samevm, missing inputstream close()? 503 # Also times out on solaris-sparcv9 -server 504 java/math/BigInteger/BigIntegerTest.java generic-all Some uses of input/output are not guarded by the try-finally {close resource} structure. I've filed 6908541 "Bad resource management in java/math/BigInteger/BigIntegerTest.java" for this. 505 506 # Should be samevm? But seems problematic with samevm on windows 507 java/math/BigInteger/ModPow65537.java From a quick look, the test uses some security infrastructure, but there is nothing that would seem problematic for samevm operation. From martinrb at google.com Tue Dec 8 23:35:29 2009 From: martinrb at google.com (Martin Buchholz) Date: Tue, 8 Dec 2009 15:35:29 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> References: <4B1D6275.1060704@sun.com> <4B1D7719.9000606@sun.com> <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> Message-ID: <1ccfd1c10912081535m408711cbma9f003465e984a7d@mail.gmail.com> On Mon, Dec 7, 2009 at 23:30, Martin Buchholz wrote: > You cannot exclude the Mother Of All Tests. > This is non-negotiable. More seriously... It's very difficult to manage creeping failures in regression tests. In theory, the process is supposed to prevent regression test failures from ever creeping in - that's the whole point. When they do (inevitably) creep in, they are supposed to be aggressively targeted. A gatekeeper demonstrates the failure to a developer, and the developer is given X time units to fix the test breakage, or face reversion of the breakage-inducing change. I would like to see more effort devoted to fixing the tests (or the code!) rather than adding infrastructure that might have the effect of hiding the test failures. BTW, I run regtests on java.util collections regularly, but only on Linux. Martin From Kelly.Ohair at Sun.COM Wed Dec 9 00:42:32 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 08 Dec 2009 16:42:32 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <1ccfd1c10912081535m408711cbma9f003465e984a7d@mail.gmail.com> References: <4B1D6275.1060704@sun.com> <4B1D7719.9000606@sun.com> <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> <1ccfd1c10912081535m408711cbma9f003465e984a7d@mail.gmail.com> Message-ID: <4B1EF278.3040809@sun.com> Martin Buchholz wrote: > On Mon, Dec 7, 2009 at 23:30, Martin Buchholz wrote: > >> You cannot exclude the Mother Of All Tests. >> This is non-negotiable. > > More seriously... > It's very difficult to manage creeping failures in regression tests. Tell me about it. :^( > > In theory, the process is supposed to prevent > regression test failures from ever creeping in - that's the whole point. > When they do (inevitably) creep in, > they are supposed to be aggressively targeted. > A gatekeeper demonstrates the failure to a developer, > and the developer is given X time units to fix the test breakage, > or face reversion of the breakage-inducing change. But it's not that simple. In some cases the cause of the failure is a change made to a different repository, by a different team, or even to the base system software via an update. The ProblemList.txt file was meant to deal with that situation, and also tests that are spuriously failing for unknown reasons. When the gatekeeper can do what you say, that is great, and ideal. But I just don't see it happening that way in all situations. > I would like to see more effort devoted to fixing the tests > (or the code!) rather than adding infrastructure that might > have the effect of hiding the test failures. Sigh... I'm not trying to hide the failures, and if you haven't noticed, I have fixed quite a few tests myself. If anything, I'm making the fact that we have test failures more public, and the ultimate goal is to fix the tests. But I needed a baseline, a line in the sand, an expectation of what tests should always pass. And an ability to run all the tests in a timely manner. Now it's time to go through the ProblemList.txt and do a little triage, file a few bugs, fix what tests can be fixed, and/or correct my ProblemList.txt file if I got it wrong. > > BTW, I run regtests on java.util collections regularly, > but only on Linux. I think it is an expected situation that many developers can only run the tests on one platform. But do you expect the gatekeeper to run all the tests on all the platforms? And if for example, your tests fail on Windows you would be given X time units to fix it? Could you? -kto > > Martin From martinrb at google.com Wed Dec 9 01:38:43 2009 From: martinrb at google.com (Martin Buchholz) Date: Tue, 8 Dec 2009 17:38:43 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <4B1EF278.3040809@sun.com> References: <4B1D6275.1060704@sun.com> <4B1D7719.9000606@sun.com> <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> <1ccfd1c10912081535m408711cbma9f003465e984a7d@mail.gmail.com> <4B1EF278.3040809@sun.com> Message-ID: <1ccfd1c10912081738p3c45a78cif81add2f7c538bbf@mail.gmail.com> On Tue, Dec 8, 2009 at 16:42, Kelly O'Hair wrote: >> In theory, the process is supposed to prevent >> regression test failures from ever creeping in - that's the whole point. >> When they do (inevitably) creep in, >> they are supposed to be aggressively targeted. >> A gatekeeper demonstrates the failure to a developer, >> and the developer is given X time units to fix the test breakage, >> or face reversion of the breakage-inducing change. > > But it's not that simple. In some cases the cause of the failure is > a change made to a different repository, by a different team, Changes that get in this way are signs of process failure. E.g. failing tests in java.util caused by hotspot commits are signs the hotspot commit was inadequately tested. > or even to the base system software via an update. > The ProblemList.txt file was meant to deal with that situation, > and also tests that are spuriously failing for unknown reasons. I agree that flaky and platform-dependent failures are a big problem. > When the gatekeeper can do what you say, that is great, and ideal. > But I just don't see it happening that way in all situations. > >> I would like to see more effort devoted to fixing the tests >> (or the code!) rather than adding infrastructure that might >> have the effect of hiding the test failures. > > Sigh... I'm not trying to hide the failures, and if you haven't > noticed, I have fixed quite a few tests myself. I have noticed, and I do appreciate it. I do some flaky test fixing myself. > If anything, I'm making the fact that we have test failures more > public, and the ultimate goal is to fix the tests. > But I needed a baseline, a line in the sand, an expectation > of what tests should always pass. And an ability to run all > the tests in a timely manner. I prefer the approach taken by my diff-javatest tool of not caring about how many tests failed with the reference jdk. Just run them twice, and look for *new* failures. > Now it's time to go through the ProblemList.txt and do a little > triage, file a few bugs, fix what tests can be fixed, and/or > correct my ProblemList.txt file if I got it wrong. > >> >> BTW, I run regtests on java.util collections regularly, >> but only on Linux. > > I think it is an expected situation that many developers can only > run the tests on one platform. > > But do you expect the gatekeeper to run all the tests on all the > platforms? > And if for example, your tests fail on Windows you would be > given X time units to fix it? Could you? Of course, you want the perfect combination of nasty and nice. For some test failures, it's unreasonable to expect the guilty party to fix them. But they should be prepared to be helpful. Martin From weijun.wang at sun.com Wed Dec 9 03:16:09 2009 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Wed, 09 Dec 2009 03:16:09 +0000 Subject: hg: jdk7/tl/jdk: 6908628: ObjectIdentifier s11n test fails Message-ID: <20091209031701.1C8EA4168F@hg.openjdk.java.net> Changeset: db5c77621c6b Author: weijun Date: 2009-12-09 11:15 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/db5c77621c6b 6908628: ObjectIdentifier s11n test fails Reviewed-by: xuelei ! test/sun/security/util/Oid/S11N.sh From Kelly.Ohair at Sun.COM Wed Dec 9 18:30:48 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 09 Dec 2009 10:30:48 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <1ccfd1c10912081738p3c45a78cif81add2f7c538bbf@mail.gmail.com> References: <4B1D6275.1060704@sun.com> <4B1D7719.9000606@sun.com> <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> <1ccfd1c10912081535m408711cbma9f003465e984a7d@mail.gmail.com> <4B1EF278.3040809@sun.com> <1ccfd1c10912081738p3c45a78cif81add2f7c538bbf@mail.gmail.com> Message-ID: <4B1FECD8.2000903@sun.com> Martin Buchholz wrote: > On Tue, Dec 8, 2009 at 16:42, Kelly O'Hair wrote: > >>> In theory, the process is supposed to prevent >>> regression test failures from ever creeping in - that's the whole point. >>> When they do (inevitably) creep in, >>> they are supposed to be aggressively targeted. >>> A gatekeeper demonstrates the failure to a developer, >>> and the developer is given X time units to fix the test breakage, >>> or face reversion of the breakage-inducing change. >> But it's not that simple. In some cases the cause of the failure is >> a change made to a different repository, by a different team, > > Changes that get in this way are signs of process failure. > E.g. failing tests in java.util caused by hotspot commits Deja Vu... we have had this discussion before. ;^) How can any team possibly run ALL the tests? We would all grind to a halt. And what is this "signs of process failure", are you some kind of manager now? ;^) "Hurumph... Every failure is a result of poor planning..." (just yanking your chain. ;^) Testing has become a balancing act for everyone, we do what we can given the constraints we have. When things fall through the cracks, we try and patch the cracks so it doesn't happen again. We use what we can to automate, but there are limits. > are signs the hotspot commit was inadequately tested. I'll let you arm wrestle the hotspot guys over that comment. ;^) > >> or even to the base system software via an update. >> The ProblemList.txt file was meant to deal with that situation, >> and also tests that are spuriously failing for unknown reasons. > > I agree that flaky and platform-dependent failures are a big problem. > >> When the gatekeeper can do what you say, that is great, and ideal. >> But I just don't see it happening that way in all situations. >> >>> I would like to see more effort devoted to fixing the tests >>> (or the code!) rather than adding infrastructure that might >>> have the effect of hiding the test failures. >> Sigh... I'm not trying to hide the failures, and if you haven't >> noticed, I have fixed quite a few tests myself. > > I have noticed, and I do appreciate it. > > I do some flaky test fixing myself. Well to your credit, tests you have worked on in the past are typically not on my flaky list. Unfortunately, some of your tests are damn good tests, and cut a larger swath through the jdk logic than what I suspect your original test focus was. So your tests may come under more scrutiny as bugs in various areas get filed, pointing at your tests and the nasty little test that found their bug. ;^) > >> If anything, I'm making the fact that we have test failures more >> public, and the ultimate goal is to fix the tests. >> But I needed a baseline, a line in the sand, an expectation >> of what tests should always pass. And an ability to run all >> the tests in a timely manner. > > I prefer the approach taken by my diff-javatest tool > of not caring about how many tests failed with the > reference jdk. Just run them twice, and look for > *new* failures. What a pain... and what a loss, so many of these tests can become healthy functioning members of society, given a little support and a helping hand. And if they are just bad tests, I agree with Mr. Scrooge let's 'decrease the surplus population'. ;^) On diff-javatest, what if the moon is full, and the reference jdk passed a test but your jdk didn't? For no good reason. I hate that. > >> Now it's time to go through the ProblemList.txt and do a little >> triage, file a few bugs, fix what tests can be fixed, and/or >> correct my ProblemList.txt file if I got it wrong. >> >>> BTW, I run regtests on java.util collections regularly, >>> but only on Linux. >> I think it is an expected situation that many developers can only >> run the tests on one platform. >> >> But do you expect the gatekeeper to run all the tests on all the >> platforms? >> And if for example, your tests fail on Windows you would be >> given X time units to fix it? Could you? > > Of course, you want the perfect combination of nasty and nice. > For some test failures, it's unreasonable to expect the guilty party > to fix them. But they should be prepared to be helpful. Agreed, but both helpful and pro-active in preventing it from happening again. We want "good citizen" developers. Which in general I think we have, I'm just trying to make sure there are lots of tools and mechanisms to allow everyone to be "good citizens". ;^) -kto > > Martin From Joe.Darcy at Sun.COM Thu Dec 10 00:11:07 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Wed, 09 Dec 2009 16:11:07 -0800 Subject: Need reviewers, jdk7 testing changes In-Reply-To: <4B1FECD8.2000903@sun.com> References: <4B1D6275.1060704@sun.com> <4B1D7719.9000606@sun.com> <1ccfd1c10912072330j78c16700i43abc5d6f7449218@mail.gmail.com> <1ccfd1c10912081535m408711cbma9f003465e984a7d@mail.gmail.com> <4B1EF278.3040809@sun.com> <1ccfd1c10912081738p3c45a78cif81add2f7c538bbf@mail.gmail.com> <4B1FECD8.2000903@sun.com> Message-ID: <4B203C9B.90700@sun.com> Kelly O'Hair wrote: > > Martin Buchholz wrote: >> On Tue, Dec 8, 2009 at 16:42, Kelly O'Hair wrote: >> >>>> In theory, the process is supposed to prevent >>>> regression test failures from ever creeping in - that's the whole >>>> point. >>>> When they do (inevitably) creep in, >>>> they are supposed to be aggressively targeted. >>>> A gatekeeper demonstrates the failure to a developer, >>>> and the developer is given X time units to fix the test breakage, >>>> or face reversion of the breakage-inducing change. >>> But it's not that simple. In some cases the cause of the failure is >>> a change made to a different repository, by a different team, >> >> Changes that get in this way are signs of process failure. >> E.g. failing tests in java.util caused by hotspot commits > > Deja Vu... we have had this discussion before. ;^) > > How can any team possibly run ALL the tests? > We would all grind to a halt. > And what is this "signs of process failure", are you some kind > of manager now? ;^) "Hurumph... Every failure is a result of poor > planning..." > (just yanking your chain. ;^) > > Testing has become a balancing act for everyone, we do what > we can given the constraints we have. When things fall through > the cracks, we try and patch the cracks so it doesn't happen > again. We use what we can to automate, but there are limits. There is a weeks-long process separating when a change gets pushed into a JDK 7 integration workspace, like TL, and when the promoted bits are available for download. The closer a changeset gets to the master, the most tests should be run against it. An individual developer should not be expected to run all the tests, but if at least the regression tests in the code base are not all run on multiple platform by the time the change hits the master, I'd argue there is a process problem. Of course, it is also a problem if the tests are run and the results aren't examined adequately. -Joe From joe.darcy at sun.com Thu Dec 10 01:49:30 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 10 Dec 2009 01:49:30 +0000 Subject: hg: jdk7/tl/jdk: 6909057: @see Arrays#hashCode missing particular method specification in j.u.Objects.hash Message-ID: <20091210015017.E056C4180E@hg.openjdk.java.net> Changeset: c2f83e13bbe5 Author: darcy Date: 2009-12-09 17:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2f83e13bbe5 6909057: @see Arrays#hashCode missing particular method specification in j.u.Objects.hash Reviewed-by: ksrini ! src/share/classes/java/util/Objects.java From Joe.Darcy at Sun.COM Thu Dec 10 03:08:31 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Wed, 09 Dec 2009 19:08:31 -0800 Subject: Code review request for 4891262 "API spec, javax/accessibility: few invalid javadoc tags" Message-ID: <4B20662F.6070805@sun.com> Hello. While doing a coredocs build, I noticed once again some javadoc warnings coming out of the javax.accessibility package and I decided to fix them; the patch is below and the full webrev is at http://cr.openjdk.java.net/~darcy/4891262.0/ The changes in AccessibleContext.java were to fix clear typos of the desired type name. In AccessibleExtendedText, the "chunk" method doesn't seem to exist so I just deleted the reference. The AccessibleKeyBinding javadoc makes repeated reference to the non-existent method AccessibleContext#getAccessibleKeyBinding so I deleted the references to and discussion of that method. -Joe --- old/src/share/classes/javax/accessibility/AccessibleContext.java 2009-12-09 19:00:44.000000000 -0800 +++ new/src/share/classes/javax/accessibility/AccessibleContext.java 2009-12-09 19:00:44.000000000 -0800 @@ -296,7 +296,7 @@ * * @see #getAccessibleText * @see #addPropertyChangeListener - * @see #AccessibleText.AccessibleTextSequence + * @see AccessibleTextSequence */ public static final String ACCESSIBLE_TEXT_PROPERTY = "AccessibleText"; @@ -311,7 +311,7 @@ * * @see #getAccessibleText * @see #addPropertyChangeListener - * @see #AccessibleText.AccessibleTextSequence + * @see AccessibleTextSequence * * @since 1.5 */ @@ -334,7 +334,7 @@ * * @see #getAccessibleText * @see #addPropertyChangeListener - * @see #AccessibleText.AccessibleAttributeSequence + * @see AccessibleAttributeSequence * * @since 1.5 */ --- old/src/share/classes/javax/accessibility/AccessibleExtendedText.java 2009-12-09 19:00:45.000000000 -0800 +++ new/src/share/classes/javax/accessibility/AccessibleExtendedText.java 2009-12-09 19:00:45.000000000 -0800 @@ -45,7 +45,6 @@ * @see Accessible#getAccessibleContext * @see AccessibleContext * @see AccessibleContext#getAccessibleText - * @see AccessibleText.AccessibleTextChunk * * @author Peter Korn * @author Lynn Monsanto --- old/src/share/classes/javax/accessibility/AccessibleKeyBinding.java 2009-12-09 19:00:46.000000000 -0800 +++ new/src/share/classes/javax/accessibility/AccessibleKeyBinding.java 2009-12-09 19:00:45.000000000 -0800 @@ -32,16 +32,11 @@ * the standard mechanism for an assistive technology to determine the * key bindings which exist for this object. * Any object that has such key bindings should support this - * interface. Applications can determine if an object supports the - * AccessibleKeyBinding interface by first obtaining its AccessibleContext - * (see @link Accessible} and then calling the - * {@link AccessibleContext#getAccessibleKeyBinding} method. If the return - * value is not null, the object supports this interface. + * interface. * * @see Accessible * @see Accessible#getAccessibleContext * @see AccessibleContext - * @see AccessibleContext#getAccessibleKeyBinding * * @author Lynn Monsanto * @since 1.4 @@ -58,21 +53,7 @@ /** * Returns a key binding for this object. The value returned is an * java.lang.Object which must be cast to appropriate type depending - * on the underlying implementation of the key. For example, if the - * Object returned is a javax.swing.KeyStroke, the user of this - * method should do the following: - * - * Component c = - * AccessibleContext ac = c.getAccessibleContext(); - * AccessibleKeyBinding akb = ac.getAccessibleKeyBinding(); - * for (int i = 0; i < akb.getAccessibleKeyBindingCount(); i++) { - * Object o = akb.getAccessibleKeyBinding(i); - * if (o instanceof javax.swing.KeyStroke) { - * javax.swing.KeyStroke keyStroke = (javax.swing.KeyStroke)o; - * - * } - * } - * + * on the underlying implementation of the key. * * @param i zero-based index of the key bindings * @return a javax.lang.Object which specifies the key binding From mandy.chung at sun.com Thu Dec 10 07:07:12 2009 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Thu, 10 Dec 2009 07:07:12 +0000 Subject: hg: jdk7/tl/jdk: 6909082: Docs warning from java.util.logging.PlatformLoggingMXBean Message-ID: <20091210070731.6C34241867@hg.openjdk.java.net> Changeset: 0f8f624ddcb4 Author: mchung Date: 2009-12-09 21:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f8f624ddcb4 6909082: Docs warning from java.util.logging.PlatformLoggingMXBean Summary: Fix incorrect tag @See with @see. Reviewed-by: darcy ! src/share/classes/java/util/logging/PlatformLoggingMXBean.java From sean.mullan at sun.com Thu Dec 10 16:44:46 2009 From: sean.mullan at sun.com (sean.mullan at sun.com) Date: Thu, 10 Dec 2009 16:44:46 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20091210164527.887C341908@hg.openjdk.java.net> Changeset: 7c9be6c9385a Author: mullan Date: 2009-12-10 11:31 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7c9be6c9385a 6867348: Digest Value of References inside Manifest - calculation order problem Reviewed-by: xuelei ! src/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! test/javax/xml/crypto/dsig/GenerationTests.java Changeset: 421e652f00c7 Author: mullan Date: 2009-12-10 11:34 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/421e652f00c7 Merge From christopher.hegarty at sun.com Thu Dec 10 19:08:32 2009 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Thu, 10 Dec 2009 19:08:32 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20091210190922.2F8954192F@hg.openjdk.java.net> Changeset: ae944611249f Author: chegar Date: 2009-12-10 15:52 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ae944611249f 6909089: Memory leak occurs by lack of free for read buffer in SocketInputStream#read() Reviewed-by: alanb, jccollet ! src/windows/native/java/net/SocketInputStream.c Changeset: 59221d9e0c1c Author: chegar Date: 2009-12-10 09:08 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59221d9e0c1c Merge From Peter.Korn at Sun.COM Thu Dec 10 20:00:15 2009 From: Peter.Korn at Sun.COM (Peter Korn) Date: Thu, 10 Dec 2009 12:00:15 -0800 Subject: Code review request for 4891262 "API spec, javax/accessibility: few invalid javadoc tags" In-Reply-To: <4B20662F.6070805@sun.com> References: <4B20662F.6070805@sun.com> Message-ID: <4B21534F.9000600@sun.com> Joe, Great, thanks! Peter > Hello. > > While doing a coredocs build, I noticed once again some javadoc > warnings coming out of the javax.accessibility package and I decided > to fix them; the patch is below and the full webrev is at > > http://cr.openjdk.java.net/~darcy/4891262.0/ > > The changes in AccessibleContext.java were to fix clear typos of the > desired type name. In AccessibleExtendedText, the "chunk" method > doesn't seem to exist so I just deleted the reference. The > AccessibleKeyBinding javadoc makes repeated reference to the > non-existent method AccessibleContext#getAccessibleKeyBinding so I > deleted the references to and discussion of that method. > > -Joe > > --- > old/src/share/classes/javax/accessibility/AccessibleContext.java > 2009-12-09 19:00:44.000000000 -0800 > +++ > new/src/share/classes/javax/accessibility/AccessibleContext.java > 2009-12-09 19:00:44.000000000 -0800 > @@ -296,7 +296,7 @@ > * > * @see #getAccessibleText > * @see #addPropertyChangeListener > - * @see #AccessibleText.AccessibleTextSequence > + * @see AccessibleTextSequence > */ > public static final String ACCESSIBLE_TEXT_PROPERTY > = "AccessibleText"; > @@ -311,7 +311,7 @@ > * > * @see #getAccessibleText > * @see #addPropertyChangeListener > - * @see #AccessibleText.AccessibleTextSequence > + * @see AccessibleTextSequence > * > * @since 1.5 > */ > @@ -334,7 +334,7 @@ > * > * @see #getAccessibleText > * @see #addPropertyChangeListener > - * @see #AccessibleText.AccessibleAttributeSequence > + * @see AccessibleAttributeSequence > * > * @since 1.5 > */ > --- > old/src/share/classes/javax/accessibility/AccessibleExtendedText.java > 2009-12-09 19:00:45.000000000 -0800 > +++ > new/src/share/classes/javax/accessibility/AccessibleExtendedText.java > 2009-12-09 19:00:45.000000000 -0800 > @@ -45,7 +45,6 @@ > * @see Accessible#getAccessibleContext > * @see AccessibleContext > * @see AccessibleContext#getAccessibleText > - * @see AccessibleText.AccessibleTextChunk > * > * @author Peter Korn > * @author Lynn Monsanto > --- > old/src/share/classes/javax/accessibility/AccessibleKeyBinding.java > 2009-12-09 19:00:46.000000000 -0800 > +++ > new/src/share/classes/javax/accessibility/AccessibleKeyBinding.java > 2009-12-09 19:00:45.000000000 -0800 > @@ -32,16 +32,11 @@ > * the standard mechanism for an assistive technology to determine the > * key bindings which exist for this object. > * Any object that has such key bindings should support this > - * interface. Applications can determine if an object supports the > - * AccessibleKeyBinding interface by first obtaining its > AccessibleContext > - * (see @link Accessible} and then calling the > - * {@link AccessibleContext#getAccessibleKeyBinding} method. If the > return > - * value is not null, the object supports this interface. > + * interface. > * > * @see Accessible > * @see Accessible#getAccessibleContext > * @see AccessibleContext > - * @see AccessibleContext#getAccessibleKeyBinding > * > * @author Lynn Monsanto > * @since 1.4 > @@ -58,21 +53,7 @@ > /** > * Returns a key binding for this object. The value returned is an > * java.lang.Object which must be cast to appropriate type depending > - * on the underlying implementation of the key. For example, if the > - * Object returned is a javax.swing.KeyStroke, the user of this > - * method should do the following: > - * > - * Component c = > - * AccessibleContext ac = c.getAccessibleContext(); > - * AccessibleKeyBinding akb = ac.getAccessibleKeyBinding(); > - * for (int i = 0; i < akb.getAccessibleKeyBindingCount(); i++) { > - * Object o = akb.getAccessibleKeyBinding(i); > - * if (o instanceof javax.swing.KeyStroke) { > - * javax.swing.KeyStroke keyStroke = > (javax.swing.KeyStroke)o; > - * > - * } > - * } > - * > + * on the underlying implementation of the key. > * > * @param i zero-based index of the key bindings > * @return a javax.lang.Object which specifies the key binding > > From joe.darcy at sun.com Thu Dec 10 21:05:37 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 10 Dec 2009 21:05:37 +0000 Subject: hg: jdk7/tl/jdk: 6909070: Missing package statements in java.text.Bidi @see links Message-ID: <20091210210601.E958E41950@hg.openjdk.java.net> Changeset: f9c9c2b726a0 Author: darcy Date: 2009-12-10 13:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f9c9c2b726a0 6909070: Missing package statements in java.text.Bidi @see links Reviewed-by: anthony ! src/share/classes/java/text/Bidi.java From gnu_andrew at member.fsf.org Thu Dec 10 21:07:42 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 10 Dec 2009 21:07:42 +0000 Subject: Code review request for 4891262 "API spec, javax/accessibility: few invalid javadoc tags" In-Reply-To: <4B20662F.6070805@sun.com> References: <4B20662F.6070805@sun.com> Message-ID: <17c6771e0912101307y36419d26lb6553131af02bb95@mail.gmail.com> 2009/12/10 Joe Darcy : > Hello. > > While doing a coredocs build, I noticed once again some javadoc warnings > coming out of the javax.accessibility package and I decided to fix them; the > patch is below and the full webrev is at > > http://cr.openjdk.java.net/~darcy/4891262.0/ > Again, good to see these being fixed. What do you think to the idea of backporting these fixes to OpenJDK6 for the next release (b19)? It's not a major issue, but would improve the documentation packages being installed by GNU/Linux distros. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From joe.darcy at sun.com Thu Dec 10 21:28:47 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 10 Dec 2009 21:28:47 +0000 Subject: hg: jdk7/tl/jdk: 4891262: API spec, javax/accessibility: few invalid javadoc tags Message-ID: <20091210212915.2BE8741955@hg.openjdk.java.net> Changeset: aa0d374b40a5 Author: darcy Date: 2009-12-10 13:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/aa0d374b40a5 4891262: API spec, javax/accessibility: few invalid javadoc tags Reviewed-by: jjg ! src/share/classes/javax/accessibility/AccessibleContext.java ! src/share/classes/javax/accessibility/AccessibleExtendedText.java ! src/share/classes/javax/accessibility/AccessibleKeyBinding.java From Joe.Darcy at Sun.COM Thu Dec 10 21:37:29 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Thu, 10 Dec 2009 13:37:29 -0800 Subject: Code review request for 4891262 "API spec, javax/accessibility: few invalid javadoc tags" In-Reply-To: <17c6771e0912101307y36419d26lb6553131af02bb95@mail.gmail.com> References: <4B20662F.6070805@sun.com> <17c6771e0912101307y36419d26lb6553131af02bb95@mail.gmail.com> Message-ID: <4B216A19.10909@sun.com> Andrew John Hughes wrote: > 2009/12/10 Joe Darcy : > >> Hello. >> >> While doing a coredocs build, I noticed once again some javadoc warnings >> coming out of the javax.accessibility package and I decided to fix them; the >> patch is below and the full webrev is at >> >> http://cr.openjdk.java.net/~darcy/4891262.0/ >> >> > > Again, good to see these being fixed. What do you think to the idea > of backporting these fixes to OpenJDK6 for the next release (b19)? > It's not a major issue, but would improve the documentation packages > being installed by GNU/Linux distros. > Andrew, if you wish, you have my approval to apply the fix for 4891262 (just pushed into JDK 7 TL) and also 6909070 "Missing package statements in java.text.Bidi @see links" to OpenJDK 6 build 18, the current build. -Joe From gnu_andrew at member.fsf.org Thu Dec 10 21:58:01 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 10 Dec 2009 21:58:01 +0000 Subject: Code review request for 4891262 "API spec, javax/accessibility: few invalid javadoc tags" In-Reply-To: <4B216A19.10909@sun.com> References: <4B20662F.6070805@sun.com> <17c6771e0912101307y36419d26lb6553131af02bb95@mail.gmail.com> <4B216A19.10909@sun.com> Message-ID: <17c6771e0912101358i6654222y636cc1a30fe95e66@mail.gmail.com> 2009/12/10 Joseph D. Darcy : > Andrew John Hughes wrote: >> >> 2009/12/10 Joe Darcy : >> >>> >>> Hello. >>> >>> While doing a coredocs build, I noticed once again some javadoc warnings >>> coming out of the javax.accessibility package and I decided to fix them; >>> the >>> patch is below and the full webrev is at >>> >>> http://cr.openjdk.java.net/~darcy/4891262.0/ >>> >>> >> >> Again, good to see these being fixed. ?What do you think to the idea >> of backporting these fixes to OpenJDK6 for the next release (b19)? >> It's not a major issue, but would improve the documentation packages >> being installed by GNU/Linux distros. >> > > Andrew, if you wish, you have my approval to apply the fix for 4891262 (just > pushed into JDK 7 TL) and also > > 6909070 "Missing package statements in java.text.Bidi @see links" > > to OpenJDK 6 build 18, the current build. > > -Joe > Thanks. I'll do that once I get the current timezone patch off my stack. I suggest we leave a full blitz of such warnings until b19 though, otherwise b18 has the potential to go on for ever :) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Joe.Darcy at Sun.COM Thu Dec 10 22:39:14 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Thu, 10 Dec 2009 14:39:14 -0800 Subject: Code review request for 4891262 "API spec, javax/accessibility: few invalid javadoc tags" In-Reply-To: <17c6771e0912101358i6654222y636cc1a30fe95e66@mail.gmail.com> References: <4B20662F.6070805@sun.com> <17c6771e0912101307y36419d26lb6553131af02bb95@mail.gmail.com> <4B216A19.10909@sun.com> <17c6771e0912101358i6654222y636cc1a30fe95e66@mail.gmail.com> Message-ID: <4B217892.3000006@sun.com> Andrew John Hughes wrote: > 2009/12/10 Joseph D. Darcy : > >> Andrew John Hughes wrote: >> >>> 2009/12/10 Joe Darcy : >>> >>> >>>> Hello. >>>> >>>> While doing a coredocs build, I noticed once again some javadoc warnings >>>> coming out of the javax.accessibility package and I decided to fix them; >>>> the >>>> patch is below and the full webrev is at >>>> >>>> http://cr.openjdk.java.net/~darcy/4891262.0/ >>>> >>>> >>>> >>> Again, good to see these being fixed. What do you think to the idea >>> of backporting these fixes to OpenJDK6 for the next release (b19)? >>> It's not a major issue, but would improve the documentation packages >>> being installed by GNU/Linux distros. >>> >>> >> Andrew, if you wish, you have my approval to apply the fix for 4891262 (just >> pushed into JDK 7 TL) and also >> >> 6909070 "Missing package statements in java.text.Bidi @see links" >> >> to OpenJDK 6 build 18, the current build. >> >> -Joe >> >> > > Thanks. I'll do that once I get the current timezone patch off my > stack. I suggest we leave a full blitz of such warnings until b19 > though, otherwise b18 has the potential to go on for ever :) > Build 19 would be fine too, but at least for now there will be at most one or two more doc warnings patches from me in the near future :-) -Joe From joe.darcy at sun.com Fri Dec 11 04:35:52 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 11 Dec 2009 04:35:52 +0000 Subject: hg: jdk7/tl/langtools: 6909538: Clarify meaning of "element" in javax.lang.model.element API Message-ID: <20091211043555.B787C419C9@hg.openjdk.java.net> Changeset: ff823a039e16 Author: darcy Date: 2009-12-10 20:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ff823a039e16 6909538: Clarify meaning of "element" in javax.lang.model.element API Reviewed-by: ahe ! src/share/classes/javax/lang/model/element/package-info.java From Joe.Darcy at Sun.COM Fri Dec 11 06:15:53 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Thu, 10 Dec 2009 22:15:53 -0800 Subject: Code review request to fix more javadoc build warnings, 6909563: Javadoc build warnings in rmi, security, management Message-ID: <4B21E399.7030806@sun.com> Hello. Another round of javadoc build warnings fixes for review; this time mostly in rmi, but one in security and another in management. Patch below; webrev at http://cr.openjdk.java.net/~darcy/6909563.0/ -Joe --- old/src/share/classes/java/lang/management/PlatformManagedObject.java 2009-12-10 21:30:19.000000000 -0800 +++ new/src/share/classes/java/lang/management/PlatformManagedObject.java 2009-12-10 21:30:19.000000000 -0800 @@ -32,7 +32,7 @@ * for monitoring and managing a component in the Java platform. * Each platform managed object has a unique * object name - * for the {@linkplain ManagementFactory.getPlatformMBeanServer + * for the {@linkplain ManagementFactory#getPlatformMBeanServer * platform MBeanServer} access. * All platform MXBeans will implement this interface. * --- old/src/share/classes/java/rmi/activation/Activatable.java 2009-12-10 21:30:20.000000000 -0800 +++ new/src/share/classes/java/rmi/activation/Activatable.java 2009-12-10 21:30:20.000000000 -0800 @@ -73,7 +73,7 @@ * can be handled properly. * *

This method invokes the {@link - * exportObject(Remote,String,MarshalledObject,boolean,port) + * #exportObject(Remote,String,MarshalledObject,boolean,int) * exportObject} method with this object, and the specified location, * data, restart mode, and port. Subsequent calls to {@link #getID} * will return the activation identifier returned from the call to @@ -120,7 +120,7 @@ * can be handled properly. * *

This method invokes the {@link - * exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) + * #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) * exportObject} method with this object, and the specified location, * data, restart mode, port, and client and server socket factories. * Subsequent calls to {@link #getID} will return the activation @@ -312,7 +312,7 @@ * separately, so that exceptions can be handled properly. * *

This method invokes the {@link - * exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) + * #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) * exportObject} method with the specified object, location, data, * restart mode, and port, and null for both client and * server socket factories, and then returns the resulting activation --- old/src/share/classes/java/rmi/registry/LocateRegistry.java 2009-12-10 21:30:21.000000000 -0800 +++ new/src/share/classes/java/rmi/registry/LocateRegistry.java 2009-12-10 21:30:21.000000000 -0800 @@ -187,7 +187,7 @@ * host that accepts requests on the specified port. * *

The Registry instance is exported as if the static - * {@link UnicastRemoteObject.exportObject(Remote,int) + * {@link UnicastRemoteObject#exportObject(Remote,int) * UnicastRemoteObject.exportObject} method is invoked, passing the * Registry instance and the specified port as * arguments, except that the Registry instance is @@ -213,7 +213,7 @@ * *

The Registry instance is exported as if * the static {@link - * UnicastRemoteObject.exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) + * UnicastRemoteObject#exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) * UnicastRemoteObject.exportObject} method is invoked, passing the * Registry instance, the specified port, the * specified RMIClientSocketFactory, and the specified --- old/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java 2009-12-10 21:30:22.000000000 -0800 +++ new/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java 2009-12-10 21:30:22.000000000 -0800 @@ -138,7 +138,6 @@ * instance * @throws Throwable the exception to throw from the method invocation * on the proxy instance - * @see **/ public Object invoke(Object proxy, Method method, Object[] args) throws Throwable --- old/src/share/classes/java/security/cert/CertPathValidatorException.java 2009-12-10 21:30:23.000000000 -0800 +++ new/src/share/classes/java/security/cert/CertPathValidatorException.java 2009-12-10 21:30:22.000000000 -0800 @@ -216,7 +216,7 @@ /** * Returns the reason that the validation failed. The reason is * associated with the index of the certificate returned by - * {@link getIndex}. + * {@link #getIndex}. * * @return the reason that the validation failed, or * BasicReason.UNSPECIFIED if a reason has not been From Mandy.Chung at Sun.COM Fri Dec 11 06:24:49 2009 From: Mandy.Chung at Sun.COM (Mandy Chung) Date: Thu, 10 Dec 2009 22:24:49 -0800 Subject: Code review request to fix more javadoc build warnings, 6909563: Javadoc build warnings in rmi, security, management In-Reply-To: <4B21E399.7030806@sun.com> References: <4B21E399.7030806@sun.com> Message-ID: <4B21E5B1.6010607@sun.com> Looks good. Mandy Joseph D. Darcy wrote: > Hello. > > Another round of javadoc build warnings fixes for review; this time > mostly in rmi, but one in security and another in management. > > Patch below; webrev at > http://cr.openjdk.java.net/~darcy/6909563.0/ > > -Joe > > --- > old/src/share/classes/java/lang/management/PlatformManagedObject.java > 2009-12-10 21:30:19.000000000 -0800 > +++ > new/src/share/classes/java/lang/management/PlatformManagedObject.java > 2009-12-10 21:30:19.000000000 -0800 > @@ -32,7 +32,7 @@ > * for monitoring and managing a component in the Java platform. > * Each platform managed object has a unique > * object name > - * for the {@linkplain ManagementFactory.getPlatformMBeanServer > + * for the {@linkplain ManagementFactory#getPlatformMBeanServer > * platform MBeanServer} access. > * All platform MXBeans will implement this interface. > * > --- old/src/share/classes/java/rmi/activation/Activatable.java > 2009-12-10 21:30:20.000000000 -0800 > +++ new/src/share/classes/java/rmi/activation/Activatable.java > 2009-12-10 21:30:20.000000000 -0800 > @@ -73,7 +73,7 @@ > * can be handled properly. > * > *

This method invokes the {@link > - * exportObject(Remote,String,MarshalledObject,boolean,port) > + * #exportObject(Remote,String,MarshalledObject,boolean,int) > * exportObject} method with this object, and the specified location, > * data, restart mode, and port. Subsequent calls to {@link #getID} > * will return the activation identifier returned from the call to > @@ -120,7 +120,7 @@ > * can be handled properly. > * > *

This method invokes the {@link > - * > exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) > > + * > #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) > > * exportObject} method with this object, and the specified location, > * data, restart mode, port, and client and server socket factories. > * Subsequent calls to {@link #getID} will return the activation > @@ -312,7 +312,7 @@ > * separately, so that exceptions can be handled properly. > * > *

This method invokes the {@link > - * > exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) > > + * > #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) > > * exportObject} method with the specified object, location, data, > * restart mode, and port, and null for both client and > * server socket factories, and then returns the resulting activation > --- old/src/share/classes/java/rmi/registry/LocateRegistry.java > 2009-12-10 21:30:21.000000000 -0800 > +++ new/src/share/classes/java/rmi/registry/LocateRegistry.java > 2009-12-10 21:30:21.000000000 -0800 > @@ -187,7 +187,7 @@ > * host that accepts requests on the specified port. > * > *

The Registry instance is exported as if the static > - * {@link UnicastRemoteObject.exportObject(Remote,int) > + * {@link UnicastRemoteObject#exportObject(Remote,int) > * UnicastRemoteObject.exportObject} method is invoked, passing the > * Registry instance and the specified > port as > * arguments, except that the Registry instance is > @@ -213,7 +213,7 @@ > * > *

The Registry instance is exported as if > * the static {@link > - * > UnicastRemoteObject.exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) > > + * > UnicastRemoteObject#exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) > > * UnicastRemoteObject.exportObject} method is invoked, passing the > * Registry instance, the specified > port, the > * specified RMIClientSocketFactory, and the specified > --- > old/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java > 2009-12-10 21:30:22.000000000 -0800 > +++ > new/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java > 2009-12-10 21:30:22.000000000 -0800 > @@ -138,7 +138,6 @@ > * instance > * @throws Throwable the exception to throw from the method > invocation > * on the proxy instance > - * @see > **/ > public Object invoke(Object proxy, Method method, Object[] args) > throws Throwable > --- > old/src/share/classes/java/security/cert/CertPathValidatorException.java > 2009-12-10 21:30:23.000000000 -0800 > +++ > new/src/share/classes/java/security/cert/CertPathValidatorException.java > 2009-12-10 21:30:22.000000000 -0800 > @@ -216,7 +216,7 @@ > /** > * Returns the reason that the validation failed. The reason is > * associated with the index of the certificate returned by > - * {@link getIndex}. > + * {@link #getIndex}. > * > * @return the reason that the validation failed, or > * BasicReason.UNSPECIFIED if a reason has not been > From Sean.Mullan at Sun.COM Fri Dec 11 14:22:17 2009 From: Sean.Mullan at Sun.COM (Sean Mullan) Date: Fri, 11 Dec 2009 09:22:17 -0500 Subject: Code review request to fix more javadoc build warnings, 6909563: Javadoc build warnings in rmi, security, management In-Reply-To: <4B21E399.7030806@sun.com> References: <4B21E399.7030806@sun.com> Message-ID: <4B225599.10102@sun.com> The security fix looks fine. --Sean Joseph D. Darcy wrote: > Hello. > > Another round of javadoc build warnings fixes for review; this time > mostly in rmi, but one in security and another in management. > > Patch below; webrev at > http://cr.openjdk.java.net/~darcy/6909563.0/ > > -Joe > > --- > old/src/share/classes/java/lang/management/PlatformManagedObject.java > 2009-12-10 21:30:19.000000000 -0800 > +++ > new/src/share/classes/java/lang/management/PlatformManagedObject.java > 2009-12-10 21:30:19.000000000 -0800 > @@ -32,7 +32,7 @@ > * for monitoring and managing a component in the Java platform. > * Each platform managed object has a unique > * object name > - * for the {@linkplain ManagementFactory.getPlatformMBeanServer > + * for the {@linkplain ManagementFactory#getPlatformMBeanServer > * platform MBeanServer} access. > * All platform MXBeans will implement this interface. > * > --- old/src/share/classes/java/rmi/activation/Activatable.java > 2009-12-10 21:30:20.000000000 -0800 > +++ new/src/share/classes/java/rmi/activation/Activatable.java > 2009-12-10 21:30:20.000000000 -0800 > @@ -73,7 +73,7 @@ > * can be handled properly. > * > *

This method invokes the {@link > - * exportObject(Remote,String,MarshalledObject,boolean,port) > + * #exportObject(Remote,String,MarshalledObject,boolean,int) > * exportObject} method with this object, and the specified location, > * data, restart mode, and port. Subsequent calls to {@link #getID} > * will return the activation identifier returned from the call to > @@ -120,7 +120,7 @@ > * can be handled properly. > * > *

This method invokes the {@link > - * > exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) > > + * > #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) > > * exportObject} method with this object, and the specified location, > * data, restart mode, port, and client and server socket factories. > * Subsequent calls to {@link #getID} will return the activation > @@ -312,7 +312,7 @@ > * separately, so that exceptions can be handled properly. > * > *

This method invokes the {@link > - * > exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) > > + * > #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) > > * exportObject} method with the specified object, location, data, > * restart mode, and port, and null for both client and > * server socket factories, and then returns the resulting activation > --- old/src/share/classes/java/rmi/registry/LocateRegistry.java > 2009-12-10 21:30:21.000000000 -0800 > +++ new/src/share/classes/java/rmi/registry/LocateRegistry.java > 2009-12-10 21:30:21.000000000 -0800 > @@ -187,7 +187,7 @@ > * host that accepts requests on the specified port. > * > *

The Registry instance is exported as if the static > - * {@link UnicastRemoteObject.exportObject(Remote,int) > + * {@link UnicastRemoteObject#exportObject(Remote,int) > * UnicastRemoteObject.exportObject} method is invoked, passing the > * Registry instance and the specified > port as > * arguments, except that the Registry instance is > @@ -213,7 +213,7 @@ > * > *

The Registry instance is exported as if > * the static {@link > - * > UnicastRemoteObject.exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) > > + * > UnicastRemoteObject#exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) > > * UnicastRemoteObject.exportObject} method is invoked, passing the > * Registry instance, the specified port, the > * specified RMIClientSocketFactory, and the specified > --- > old/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java > 2009-12-10 21:30:22.000000000 -0800 > +++ > new/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java > 2009-12-10 21:30:22.000000000 -0800 > @@ -138,7 +138,6 @@ > * instance > * @throws Throwable the exception to throw from the method invocation > * on the proxy instance > - * @see > **/ > public Object invoke(Object proxy, Method method, Object[] args) > throws Throwable > --- > old/src/share/classes/java/security/cert/CertPathValidatorException.java > 2009-12-10 21:30:23.000000000 -0800 > +++ > new/src/share/classes/java/security/cert/CertPathValidatorException.java > 2009-12-10 21:30:22.000000000 -0800 > @@ -216,7 +216,7 @@ > /** > * Returns the reason that the validation failed. The reason is > * associated with the index of the certificate returned by > - * {@link getIndex}. > + * {@link #getIndex}. > * > * @return the reason that the validation failed, or > * BasicReason.UNSPECIFIED if a reason has not been > From joe.darcy at sun.com Fri Dec 11 18:41:36 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 11 Dec 2009 18:41:36 +0000 Subject: hg: jdk7/tl/jdk: 6909563: Javadoc build warnings in rmi, security, management Message-ID: <20091211184212.7A9AC41AB1@hg.openjdk.java.net> Changeset: 3267ca7afe95 Author: darcy Date: 2009-12-11 10:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3267ca7afe95 6909563: Javadoc build warnings in rmi, security, management Reviewed-by: mchung, mullan ! src/share/classes/java/lang/management/PlatformManagedObject.java ! src/share/classes/java/rmi/activation/Activatable.java ! src/share/classes/java/rmi/registry/LocateRegistry.java ! src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java ! src/share/classes/java/security/cert/CertPathValidatorException.java From Mandy.Chung at Sun.COM Fri Dec 11 18:55:18 2009 From: Mandy.Chung at Sun.COM (Mandy Chung) Date: Fri, 11 Dec 2009 10:55:18 -0800 Subject: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present Message-ID: <4B229596.2070302@sun.com> The JNDI cosnaming provider currently has a static dependency on java.applet.Applet that is only needed in an applet environment. This fix will allow JNDI cosnaming provider to be used when java.applet is not present. Webrev: http://cr.openjdk.java.net/~mchung/6898747/webrev.00/ Thanks Mandy From Kelly.Ohair at Sun.COM Fri Dec 11 19:20:53 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Fri, 11 Dec 2009 11:20:53 -0800 Subject: Need reviewer - adding -ea -esa to testing via jdk/test/Makefile Message-ID: <4B229B95.4030203@sun.com> Need reviewer - adding -ea -esa to testing via jdk/test/Makefile 6909373: Add -ea to the testing done by jdk/test/Makefile http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-6909373/webrev/ Also put select jtreg options into separate make variables for easier experimentation without modifying the actual Makefile. Added a few tests to ProblemList.txt, failures with assertions and some problems with a java/util/concurrent test. +# Dies on Solaris 10 sparc and sparcv9, Linux -ea -esa with +# Interrupted or IO exception, maybe writing to non-unique named file? +com/sun/net/httpserver/bugs/B6373555.java generic-all +# Dies on pretty much all platforms when run with -ea -esa, Assertion error +java/net/CookieHandler/TestHttpCookie.java generic-all +java/net/URLClassLoader/closetest/CloseTest.java generic-all +# Fails with -ea -esa, Assertion error, but only on Solaris 10 machines? +com/sun/nio/sctp/SctpChannel/Send.java generic-all +com/sun/nio/sctp/SctpChannel/Shutdown.java generic-all +# Fails with -ea -esa, but only on Solaris sparc? Suspect it is timing out +sun/security/tools/keytool/standard.sh generic-all +# Fails with -ea -esa on Solaris, Assertion error (Solaris specific test) +com/sun/tracing/BasicFunctionality.java generic-all +# Fails with -ea -esa on all platforms with Assertion error +java/util/ResourceBundle/Test4300693.java generic-all +# Failing on all -client 32bit platforms starting with b77? See 6908348. +java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java generic-all --- I will file bugs on these tests failing. -kto From Joe.Darcy at Sun.COM Fri Dec 11 20:11:25 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Fri, 11 Dec 2009 12:11:25 -0800 Subject: Need reviewer - adding -ea -esa to testing via jdk/test/Makefile In-Reply-To: <4B229B95.4030203@sun.com> References: <4B229B95.4030203@sun.com> Message-ID: <4B22A76D.5060000@sun.com> Looks good; approved, -Joe On 12/11/09 11:20 AM, Kelly O'Hair wrote: > Need reviewer - adding -ea -esa to testing via jdk/test/Makefile > > 6909373: Add -ea to the testing done by jdk/test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-6909373/webrev/ > > Also put select jtreg options into separate make variables for easier > experimentation without modifying the actual Makefile. > > Added a few tests to ProblemList.txt, failures with assertions and > some problems with a java/util/concurrent test. > > +# Dies on Solaris 10 sparc and sparcv9, Linux -ea -esa with > +# Interrupted or IO exception, maybe writing to non-unique named file? > +com/sun/net/httpserver/bugs/B6373555.java generic-all > > +# Dies on pretty much all platforms when run with -ea -esa, Assertion > error > +java/net/CookieHandler/TestHttpCookie.java generic-all > +java/net/URLClassLoader/closetest/CloseTest.java generic-all > > +# Fails with -ea -esa, Assertion error, but only on Solaris 10 machines? > +com/sun/nio/sctp/SctpChannel/Send.java generic-all > +com/sun/nio/sctp/SctpChannel/Shutdown.java generic-all > > +# Fails with -ea -esa, but only on Solaris sparc? Suspect it is > timing out > +sun/security/tools/keytool/standard.sh generic-all > > +# Fails with -ea -esa on Solaris, Assertion error (Solaris specific > test) > +com/sun/tracing/BasicFunctionality.java generic-all > > +# Fails with -ea -esa on all platforms with Assertion error > +java/util/ResourceBundle/Test4300693.java generic-all > > +# Failing on all -client 32bit platforms starting with b77? See 6908348. > +java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java > generic-all > > --- > > I will file bugs on these tests failing. > > -kto From jason_mehrens at hotmail.com Fri Dec 11 22:10:16 2009 From: jason_mehrens at hotmail.com (Jason Mehrens) Date: Fri, 11 Dec 2009 16:10:16 -0600 Subject: Need reviewer - adding -ea -esa to testing via jdk/test/Makefile In-Reply-To: <4B229B95.4030203@sun.com> References: <4B229B95.4030203@sun.com> Message-ID: Kelly, Are any of the tests run with "-Xcheck:jni"? If not, it might be something to consider. Jason Mehrens > Date: Fri, 11 Dec 2009 11:20:53 -0800 > From: Kelly.Ohair at Sun.COM > Subject: Need reviewer - adding -ea -esa to testing via jdk/test/Makefile > To: core-libs-dev at openjdk.java.net > > Need reviewer - adding -ea -esa to testing via jdk/test/Makefile > > 6909373: Add -ea to the testing done by jdk/test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-6909373/webrev/ > > Also put select jtreg options into separate make variables for easier > experimentation without modifying the actual Makefile. _________________________________________________________________ Hotmail: Free, trusted and rich email service. http://clk.atdmt.com/GBL/go/171222984/direct/01/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.gibbons at sun.com Fri Dec 11 22:27:34 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 11 Dec 2009 22:27:34 +0000 Subject: hg: jdk7/tl/langtools: 6906175: bridge JSR199 and JSR 203 APIs Message-ID: <20091211222741.F18A941AEF@hg.openjdk.java.net> Changeset: 4011f49b4af8 Author: jjg Date: 2009-12-11 14:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4011f49b4af8 6906175: bridge JSR199 and JSR 203 APIs Reviewed-by: darcy, alanb ! make/build.properties ! make/build.xml ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java - src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Paths.java + src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java + src/share/classes/com/sun/tools/javac/nio/PathFileManager.java + src/share/classes/com/sun/tools/javac/nio/PathFileObject.java + src/share/classes/com/sun/tools/javac/util/BaseFileManager.java + src/share/classes/com/sun/tools/javac/util/CloseableURLClassLoader.java ! src/share/classes/javax/tools/StandardJavaFileManager.java + test/tools/javac/nio/compileTest/CompileTest.java + test/tools/javac/nio/compileTest/HelloPathWorld.java From ahughes at redhat.com Fri Dec 11 23:47:24 2009 From: ahughes at redhat.com (ahughes at redhat.com) Date: Fri, 11 Dec 2009 23:47:24 +0000 Subject: hg: jdk7/tl/jdk: 6909442: Fix comments in test/sun/tools/jhat/HatRun.java Message-ID: <20091211234743.2759F41B0C@hg.openjdk.java.net> Changeset: 5434b2585a08 Author: andrew Date: 2009-12-11 23:47 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5434b2585a08 6909442: Fix comments in test/sun/tools/jhat/HatRun.java Summary: Update the comments in this test to match the changes in 6902325 Reviewed-by: ohair ! test/sun/tools/jhat/HatRun.java From kelly.ohair at sun.com Sat Dec 12 03:29:05 2009 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Sat, 12 Dec 2009 03:29:05 +0000 Subject: hg: jdk7/tl/jdk: 6 new changesets Message-ID: <20091212033058.7FD4B41B4B@hg.openjdk.java.net> Changeset: 2d53da2c4764 Author: ohair Date: 2009-12-09 09:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2d53da2c4764 6906210: Fix another minor typo in test/Makefile Reviewed-by: tbell, dcubed ! test/Makefile ! test/ProblemList.txt ! test/com/sun/jdi/NoLaunchOptionTest.java ! test/com/sun/jdi/OptionTest.java ! test/sun/tools/jhat/HatRun.java Changeset: a5ee97f72245 Author: ohair Date: 2009-12-09 09:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5ee97f72245 Merge Changeset: 8d42b2bd25fe Author: ohair Date: 2009-12-10 16:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8d42b2bd25fe Merge Changeset: c84d8b9be5c6 Author: ohair Date: 2009-12-11 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c84d8b9be5c6 6909373: Add -ea to the testing done by jdk/test/Makefile Reviewed-by: darcy ! test/Makefile ! test/ProblemList.txt Changeset: 623c22f00e49 Author: ohair Date: 2009-12-11 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/623c22f00e49 Merge Changeset: 15568b6998f4 Author: ohair Date: 2009-12-11 17:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15568b6998f4 Merge ! test/sun/tools/jhat/HatRun.java From jonathan.gibbons at sun.com Sat Dec 12 17:33:24 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Sat, 12 Dec 2009 17:33:24 +0000 Subject: hg: jdk7/tl/langtools: 6907575: [classfile] add support for classfile dependency analysis Message-ID: <20091212173336.E31C741C2B@hg.openjdk.java.net> Changeset: fbeb560f39e7 Author: jjg Date: 2009-12-12 09:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/fbeb560f39e7 6907575: [classfile] add support for classfile dependency analysis Reviewed-by: ksrini + src/share/classes/com/sun/tools/classfile/Dependencies.java + src/share/classes/com/sun/tools/classfile/Dependency.java + test/tools/javap/classfile/deps/GetDeps.java + test/tools/javap/classfile/deps/T6907575.java + test/tools/javap/classfile/deps/T6907575.out + test/tools/javap/classfile/deps/p/C1.java From Joe.Darcy at Sun.COM Mon Dec 14 09:31:31 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Mon, 14 Dec 2009 01:31:31 -0800 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) Message-ID: <4B2605F3.4070502@sun.com> Hello. Please review my fix for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) http://cr.openjdk.java.net/~darcy/6908131.0/ I've asked Doug Priest, one of Sun's numerical experts, to review the floor/ceil algorithm and testing. I've incorporated his feedback and he has approved those aspects of the changes. The JDK integration has not yet been looked over. Thanks, -Joe From Christian.Thalinger at Sun.COM Mon Dec 14 09:42:54 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Mon, 14 Dec 2009 10:42:54 +0100 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B2605F3.4070502@sun.com> References: <4B2605F3.4070502@sun.com> Message-ID: <1260783774.1076.81.camel@macbook> On Mon, 2009-12-14 at 01:31 -0800, Joseph D. Darcy wrote: > Hello. > > Please review my fix for > > 6908131 Pure Java implementations of StrictMath.floor(double) > &StrictMath.ceil(double) > http://cr.openjdk.java.net/~darcy/6908131.0/ > > I've asked Doug Priest, one of Sun's numerical experts, to review the > floor/ceil algorithm and testing. I've incorporated his feedback and he > has approved those aspects of the changes. The JDK integration has not > yet been looked over. Not a review, but did you think about implementing the whole FDLIBM in Java, as done here: http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-August/001970.html -- Christian From Alan.Bateman at Sun.COM Mon Dec 14 09:58:55 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Mon, 14 Dec 2009 09:58:55 +0000 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B2605F3.4070502@sun.com> References: <4B2605F3.4070502@sun.com> Message-ID: <4B260C5F.9090604@sun.com> Joseph D. Darcy wrote: > Hello. > > Please review my fix for > > 6908131 Pure Java implementations of StrictMath.floor(double) > &StrictMath.ceil(double) > http://cr.openjdk.java.net/~darcy/6908131.0/ > > I've asked Doug Priest, one of Sun's numerical experts, to review the > floor/ceil algorithm and testing. I've incorporated his feedback and > he has approved those aspects of the changes. The JDK integration has > not yet been looked over. > > Thanks, > > -Joe For the JDK integration you'll need to remove the symbols from make/java/java/mapfile-vers. Also, there are probably references in the reorder-* files that can be removed (although they aren't maintained now). -Alan. From Alan.Bateman at Sun.COM Mon Dec 14 10:30:02 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Mon, 14 Dec 2009 10:30:02 +0000 Subject: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present In-Reply-To: <4B229596.2070302@sun.com> References: <4B229596.2070302@sun.com> Message-ID: <4B2613AA.4090800@sun.com> Mandy Chung wrote: > The JNDI cosnaming provider currently has a static dependency on > java.applet.Applet that is only needed in an applet environment. This > fix will allow JNDI cosnaming provider to be used when java.applet is > not present. > > Webrev: > http://cr.openjdk.java.net/~mchung/6898747/webrev.00/ Mandy - what is the existing behavior for when the environment property is null or a non-Applet type? I don't know the COS Naming Service Provider but I assume it will throw CCE if the property value is not an Applet. With the proposed change it looks like it will throw an AssertionError if the module containing Applet is not installed. If not installed it means the value cannot be an Applet so you could thrown whatever exception is thrown today. Minor comment is that you can probably replace "java.naming.applet" with Context.APPLET. -Alan. From Joe.Darcy at Sun.COM Mon Dec 14 18:16:54 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Mon, 14 Dec 2009 10:16:54 -0800 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <1260783774.1076.81.camel@macbook> References: <4B2605F3.4070502@sun.com> <1260783774.1076.81.camel@macbook> Message-ID: <4B268116.50904@sun.com> Christian Thalinger wrote: > On Mon, 2009-12-14 at 01:31 -0800, Joseph D. Darcy wrote: > >> Hello. >> >> Please review my fix for >> >> 6908131 Pure Java implementations of StrictMath.floor(double) >> &StrictMath.ceil(double) >> http://cr.openjdk.java.net/~darcy/6908131.0/ >> >> I've asked Doug Priest, one of Sun's numerical experts, to review the >> floor/ceil algorithm and testing. I've incorporated his feedback and he >> has approved those aspects of the changes. The JDK integration has not >> yet been looked over. >> > > Not a review, but did you think about implementing the whole FDLIBM in > Java, as done here: > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-August/001970.html > Yes, porting FDLIBM to Java has been an oft-delayed "nice to have" project of mine. It is not obvious from looking at my ceil/floor code, but it started with the FDLIBM versions of those algorithms. The tests are new and greatly outnumber the code changes, as it typical in this line of work :-) I think getting an all-java StrictMath library would be best done as a series of small batches so floor/ceil could be a start. -Joe From Mandy.Chung at Sun.COM Mon Dec 14 18:26:46 2009 From: Mandy.Chung at Sun.COM (Mandy Chung) Date: Mon, 14 Dec 2009 10:26:46 -0800 Subject: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present In-Reply-To: <4B2613AA.4090800@sun.com> References: <4B229596.2070302@sun.com> <4B2613AA.4090800@sun.com> Message-ID: <4B268366.9060209@sun.com> Alan Bateman wrote: > Mandy - what is the existing behavior for when the environment > property is null or a non-Applet type? I don't know the COS Naming > Service Provider but I assume it will throw CCE if the property value > is not an Applet. With the proposed change it looks like it will throw > an AssertionError if the module containing Applet is not installed. If > not installed it means the value cannot be an Applet so you could > thrown whatever exception is thrown today. Good catch. I have an assumption that when the property value is non-null, java.applet.Applet must exist and the appletClass.isInstance(applet) check will take care of the case when the property value is the non-Applet type and throw CCE. You are right that the non-Applet object could be set in the env property regardless of whether java.applet.Applet exists or not. I will fix the CCFE catch clause to throw CCE if java.applet.Applet class doesn't exist. > Minor comment is that you can probably replace "java.naming.applet" > with Context.APPLET. > Sure. Thanks Mandy From Christian.Thalinger at Sun.COM Mon Dec 14 18:54:18 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Mon, 14 Dec 2009 19:54:18 +0100 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B268116.50904@sun.com> References: <4B2605F3.4070502@sun.com> <1260783774.1076.81.camel@macbook> <4B268116.50904@sun.com> Message-ID: <1260816858.1076.182.camel@macbook> On Mon, 2009-12-14 at 10:16 -0800, Joseph D. Darcy wrote: > > Not a review, but did you think about implementing the whole FDLIBM in > > Java, as done here: > > > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2009-August/001970.html > > > > Yes, porting FDLIBM to Java has been an oft-delayed "nice to have" > project of mine. It is not obvious from looking at my ceil/floor code, > but it started with the FDLIBM versions of those algorithms. The tests > are new and greatly outnumber the code changes, as it typical in this > line of work :-) I think getting an all-java StrictMath library would > be best done as a series of small batches so floor/ceil could be a start. All in all sounds good :-) -- Christian From Joe.Darcy at Sun.COM Mon Dec 14 22:03:17 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Mon, 14 Dec 2009 14:03:17 -0800 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B260C5F.9090604@sun.com> References: <4B2605F3.4070502@sun.com> <4B260C5F.9090604@sun.com> Message-ID: <4B26B625.3020705@sun.com> Alan Bateman wrote: > Joseph D. Darcy wrote: >> Hello. >> >> Please review my fix for >> >> 6908131 Pure Java implementations of StrictMath.floor(double) >> &StrictMath.ceil(double) >> http://cr.openjdk.java.net/~darcy/6908131.0/ >> >> I've asked Doug Priest, one of Sun's numerical experts, to review the >> floor/ceil algorithm and testing. I've incorporated his feedback and >> he has approved those aspects of the changes. The JDK integration >> has not yet been looked over. >> >> Thanks, >> >> -Joe > For the JDK integration you'll need to remove the symbols from > make/java/java/mapfile-vers. Also, there are probably references in > the reorder-* files that can be removed (although they aren't > maintained now). > Webrev so updated: http://cr.openjdk.java.net/~darcy/6908131.1 Thanks, -Joe From Alan.Bateman at Sun.COM Mon Dec 14 22:15:16 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Mon, 14 Dec 2009 22:15:16 +0000 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B26B625.3020705@sun.com> References: <4B2605F3.4070502@sun.com> <4B260C5F.9090604@sun.com> <4B26B625.3020705@sun.com> Message-ID: <4B26B8F4.90509@sun.com> Joseph D. Darcy wrote: > : > Webrev so updated: > http://cr.openjdk.java.net/~darcy/6908131.1 I'm not an expert on floating point but this implementation looks good to me. The test looks good too. I agree with your previous comment to transition to pure-java implementations in steps - that should help build up the test coverage in the regression test suite. -Alan. From Dmitry.Nadezhin at Sun.COM Mon Dec 14 22:19:48 2009 From: Dmitry.Nadezhin at Sun.COM (Dmitry Nadezhin) Date: Tue, 15 Dec 2009 01:19:48 +0300 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B268116.50904@sun.com> References: <4B2605F3.4070502@sun.com> <1260783774.1076.81.camel@macbook> <4B268116.50904@sun.com> Message-ID: <4B26BA04.6030904@sun.com> Joseph D. Darcy wrote: > Yes, porting FDLIBM to Java has been an oft-delayed "nice to have" > project of mine. It is not obvious from looking at my ceil/floor > code, but it started with the FDLIBM versions of those algorithms. > The tests are new and greatly outnumber the code changes, as it > typical in this line of work :-) I think getting an all-java > StrictMath library would be best done as a series of small batches so > floor/ceil could be a start. Floating-point algorithms are difficult to test. Maybe, the new StrictMath.java can be verified by formal methods (in addition to tests) ? We would be more confident, if we obtain machine-checked proof that the result of method execution by JVM differs from exact mathematical result no more than 1 ulp in for all Float/Double inputs. I googled some papers on verification of floating-point: http://www-lipn.univ-paris13.fr/CerPAN/files/ARITH.pdf http://shemesh.larc.nasa.gov/fm/papers/Boldo-CR-2006-214298-Floating-Point.pdf http://www.cl.cam.ac.uk/~jrh13/papers/fparith.pdf What do you think about such perspective ? From Joe.Darcy at Sun.COM Mon Dec 14 23:31:58 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Mon, 14 Dec 2009 15:31:58 -0800 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B26BA04.6030904@sun.com> References: <4B2605F3.4070502@sun.com> <1260783774.1076.81.camel@macbook> <4B268116.50904@sun.com> <4B26BA04.6030904@sun.com> Message-ID: <4B26CAEE.8040903@sun.com> Dmitry Nadezhin wrote: > Joseph D. Darcy wrote: >> Yes, porting FDLIBM to Java has been an oft-delayed "nice to have" >> project of mine. It is not obvious from looking at my ceil/floor >> code, but it started with the FDLIBM versions of those algorithms. >> The tests are new and greatly outnumber the code changes, as it >> typical in this line of work :-) I think getting an all-java >> StrictMath library would be best done as a series of small batches so >> floor/ceil could be a start. > Floating-point algorithms are difficult to test. > Maybe, the new StrictMath.java can be verified by formal methods (in > addition to tests) ? > We would be more confident, if we obtain machine-checked proof that > the result of method execution by JVM differs from exact mathematical > result no more than 1 ulp in for all Float/Double inputs. > > I googled some papers on verification of floating-point: > http://www-lipn.univ-paris13.fr/CerPAN/files/ARITH.pdf > http://shemesh.larc.nasa.gov/fm/papers/Boldo-CR-2006-214298-Floating-Point.pdf > > http://www.cl.cam.ac.uk/~jrh13/papers/fparith.pdf > > What do you think about such perspective ? > > The current specification of the "interesting" methods in StrictMath, such as sin/cos, log, etc. are to use the FDLIBM algorithms. Another approach would be to specify that "correctly rounded" algorithms be used. Such a specification would constrain the result according to the method's behavior (i.e. define a mathematically "correct" result) rather than defining the correct result based on matching a particular implementation. Developing and testing correctly rounded algorithms remains a research area with Jean-Michel Muller and associates doing good work. That said, while there is certainly value in formal methods, I think they would be overkill for the regression testing needs of the JDK. -Joe From Dmitry.Nadezhin at Sun.COM Tue Dec 15 06:08:16 2009 From: Dmitry.Nadezhin at Sun.COM (Dmitry Nadezhin) Date: Tue, 15 Dec 2009 09:08:16 +0300 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B26CAEE.8040903@sun.com> References: <4B2605F3.4070502@sun.com> <1260783774.1076.81.camel@macbook> <4B268116.50904@sun.com> <4B26BA04.6030904@sun.com> <4B26CAEE.8040903@sun.com> Message-ID: <4B2727D0.4010900@sun.com> > The current specification of the "interesting" methods in StrictMath, such as sin/cos, log, > etc. are to use the FDLIBM algorithms. Thank you. I forgot about these lines in java.lang.StrictMath . *

To help ensure portability of Java programs, the definitions of * some of the numeric functions in this package require that they * produce the same results as certain published algorithms. These * algorithms are available from the well-known network library * {@code netlib} as the package "Freely Distributable Math * Library," {@code fdlibm}. These * algorithms, which are written in the C programming language, are * then to be understood as executed with all floating-point * operations following the rules of Java floating-point arithmetic. * *

The Java math library is defined with respect to * {@code fdlibm} version 5.3. As specification of java.lang.StrictMath is in terms of reference fdlibm C library and algorithms in new java.lang.StrictMath are expected similar to fdlibm algorithms, the task of formal verification becomes easier. The comment 3 in fdlibm's readme file warns about --- 3. Compiler failure on non-standard code Statements like *(1+(int*)&t1) = 0; are not standard C and cause some optimizing compilers (e.g. GCC) to generate bad code under optimization. These cases are to be addressed in the next release. --- Nevertheless, I hope that for some additional assumptions about C pointers, the meaning of fdlibm C code can be used as the specification. However, there is a question. Many methods of java.lang.StrictMath are used in a reference implementation of java.lang.Math methods. java.lang.Math specifies methods in terms of accuracy of the returned result and monotonicity of the methods. Suppose that there is still a bug in fdlibm 5.3 and some fdlibm function fails to satisfy one ulp accuracy or monotonicity. What will be the specification of corresponding java.lang.StrictMath method in such a case ? Joseph D. Darcy wrote: > Dmitry Nadezhin wrote: >> Joseph D. Darcy wrote: >>> Yes, porting FDLIBM to Java has been an oft-delayed "nice to have" >>> project of mine. It is not obvious from looking at my ceil/floor >>> code, but it started with the FDLIBM versions of those algorithms. >>> The tests are new and greatly outnumber the code changes, as it >>> typical in this line of work :-) I think getting an all-java >>> StrictMath library would be best done as a series of small batches >>> so floor/ceil could be a start. >> Floating-point algorithms are difficult to test. >> Maybe, the new StrictMath.java can be verified by formal methods (in >> addition to tests) ? >> We would be more confident, if we obtain machine-checked proof that >> the result of method execution by JVM differs from exact mathematical >> result no more than 1 ulp in for all Float/Double inputs. >> >> I googled some papers on verification of floating-point: >> http://www-lipn.univ-paris13.fr/CerPAN/files/ARITH.pdf >> http://shemesh.larc.nasa.gov/fm/papers/Boldo-CR-2006-214298-Floating-Point.pdf >> >> http://www.cl.cam.ac.uk/~jrh13/papers/fparith.pdf >> >> What do you think about such perspective ? >> >> > > The current specification of the "interesting" methods in StrictMath, > such as sin/cos, log, etc. are to use the FDLIBM algorithms. Another > approach would be to specify that "correctly rounded" algorithms be > used. Such a specification would constrain the result according to > the method's behavior (i.e. define a mathematically "correct" result) > rather than defining the correct result based on matching a particular > implementation. Developing and testing correctly rounded algorithms > remains a research area with Jean-Michel Muller and associates doing > good work. > > That said, while there is certainly value in formal methods, I think > they would be overkill for the regression testing needs of the JDK. > > -Joe From Joe.Darcy at Sun.COM Tue Dec 15 19:16:34 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Tue, 15 Dec 2009 11:16:34 -0800 Subject: Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double) In-Reply-To: <4B2727D0.4010900@sun.com> References: <4B2605F3.4070502@sun.com> <1260783774.1076.81.camel@macbook> <4B268116.50904@sun.com> <4B26BA04.6030904@sun.com> <4B26CAEE.8040903@sun.com> <4B2727D0.4010900@sun.com> Message-ID: <4B27E092.9000708@sun.com> Dmitry Nadezhin wrote: > > The current specification of the "interesting" methods in > StrictMath, such as sin/cos, log, > etc. are to use the FDLIBM > algorithms. > > Thank you. I forgot about these lines in java.lang.StrictMath . [snip] > As specification of java.lang.StrictMath is in terms of reference > fdlibm C library > and algorithms in new java.lang.StrictMath are expected similar to > fdlibm algorithms, > the task of formal verification becomes easier. > > The comment 3 in fdlibm's readme file warns about > --- > 3. Compiler failure on non-standard code > Statements like > *(1+(int*)&t1) = 0; > are not standard C and cause some optimizing compilers (e.g. GCC) > to generate bad code under optimization. These cases > are to be addressed in the next release. > --- > Nevertheless, I hope that for some additional assumptions about C > pointers, the meaning > of fdlibm C code can be used as the specification. The C language does not really define an operational semantics for these operations. In contrast, with the tighter specification of Java's integral and floating-point types and expressions using those values, it is really well-posed to discuss the meaning of Java versions of these algorithms. > However, there is a question. Many methods of java.lang.StrictMath are > used in a reference implementation of java.lang.Math methods. > java.lang.Math specifies methods in terms of accuracy of the returned > result > and monotonicity of the methods. > Suppose that there is still a bug in fdlibm 5.3 and some fdlibm > function fails to > satisfy one ulp accuracy or monotonicity. What will be the > specification of > corresponding java.lang.StrictMath method in such a case ? The FDLIBM functions are believed to follow the stated quality of implementation criteria in java.lang.Math. When that turns out not to be the case, there are a variety of remedies including fixing the bug in FDLIBM. Fixing bugs I had independently found in pow and tan prompted raising the required FDLIBM version from 5.2 to 5.3, see 5033578 "Java should require use of latest fdlibm 5.3." Cheers, -Joe From jonathan.gibbons at sun.com Tue Dec 15 21:28:20 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 15 Dec 2009 21:28:20 +0000 Subject: hg: jdk7/tl/langtools: 6910317: [classfile] typo and other issues in Dependency classes Message-ID: <20091215212823.7D353420FD@hg.openjdk.java.net> Changeset: 0666a8f87661 Author: jjg Date: 2009-12-15 13:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0666a8f87661 6910317: [classfile] typo and other issues in Dependency classes Reviewed-by: ksrini ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Dependency.java ! test/tools/javap/classfile/deps/GetDeps.java From joe.darcy at sun.com Tue Dec 15 21:52:12 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Tue, 15 Dec 2009 21:52:12 +0000 Subject: hg: jdk7/tl/jdk: 6908131: Pure Java implementations of StrictMath.floor(double) & StrictMath.ceil(double) Message-ID: <20091215215249.56B1642107@hg.openjdk.java.net> Changeset: ad1e30930c6c Author: darcy Date: 2009-12-15 13:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ad1e30930c6c 6908131: Pure Java implementations of StrictMath.floor(double) & StrictMath.ceil(double) Reviewed-by: alanb ! make/java/java/mapfile-vers ! make/java/java/reorder-i586 ! make/java/java/reorder-sparc ! make/java/java/reorder-sparcv9 ! src/share/classes/java/lang/StrictMath.java ! src/share/native/java/lang/StrictMath.c + test/java/lang/Math/CeilAndFloorTests.java From Mandy.Chung at Sun.COM Tue Dec 15 21:57:38 2009 From: Mandy.Chung at Sun.COM (Mandy Chung) Date: Tue, 15 Dec 2009 13:57:38 -0800 Subject: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present In-Reply-To: <4B268366.9060209@sun.com> References: <4B229596.2070302@sun.com> <4B2613AA.4090800@sun.com> <4B268366.9060209@sun.com> Message-ID: <4B280652.7070206@sun.com> The revised webrev: http://cr.openjdk.java.net/~mchung/6898747/webrev.01/ Thanks Mandy Mandy Chung wrote: > Alan Bateman wrote: >> Mandy - what is the existing behavior for when the environment >> property is null or a non-Applet type? I don't know the COS Naming >> Service Provider but I assume it will throw CCE if the property value >> is not an Applet. With the proposed change it looks like it will >> throw an AssertionError if the module containing Applet is not >> installed. If not installed it means the value cannot be an Applet so >> you could thrown whatever exception is thrown today. > Good catch. > > I have an assumption that when the property value is non-null, > java.applet.Applet must exist and the appletClass.isInstance(applet) > check will take care of the case when the property value is the > non-Applet type and throw CCE. You are right that the non-Applet > object could be set in the env property regardless of whether > java.applet.Applet exists or not. > > I will fix the CCFE catch clause to throw CCE if java.applet.Applet > class doesn't exist. >> Minor comment is that you can probably replace "java.naming.applet" >> with Context.APPLET. >> > Sure. > > Thanks > Mandy > > From Alan.Bateman at Sun.COM Tue Dec 15 22:05:05 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 15 Dec 2009 22:05:05 +0000 Subject: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present In-Reply-To: <4B280652.7070206@sun.com> References: <4B229596.2070302@sun.com> <4B2613AA.4090800@sun.com> <4B268366.9060209@sun.com> <4B280652.7070206@sun.com> Message-ID: <4B280811.3040103@sun.com> Mandy Chung wrote: > The revised webrev: > http://cr.openjdk.java.net/~mchung/6898747/webrev.01/ This looks okay to me except one thing - I think it's for possible for ORB.init to throw an org.omg.CORBA.SystemException in which case you should probably propogate the cause of the InvocationTargetException if it's a RuntimeException (or Error). -Alan. From Mandy.Chung at Sun.COM Tue Dec 15 22:35:02 2009 From: Mandy.Chung at Sun.COM (Mandy Chung) Date: Tue, 15 Dec 2009 14:35:02 -0800 Subject: Review request for 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present In-Reply-To: <4B280811.3040103@sun.com> References: <4B229596.2070302@sun.com> <4B2613AA.4090800@sun.com> <4B268366.9060209@sun.com> <4B280652.7070206@sun.com> <4B280811.3040103@sun.com> Message-ID: <4B280F16.8020808@sun.com> Alan Bateman wrote: > Mandy Chung wrote: >> The revised webrev: >> http://cr.openjdk.java.net/~mchung/6898747/webrev.01/ > This looks okay to me except one thing - I think it's for possible for > ORB.init to throw an org.omg.CORBA.SystemException in which case you > should probably propogate the cause of the InvocationTargetException > if it's a RuntimeException (or Error). > Updated. http://cr.openjdk.java.net/~mchung/6898747/webrev.02/ Thanks Mandy From Kelly.Ohair at Sun.COM Wed Dec 16 01:42:40 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 15 Dec 2009 17:42:40 -0800 Subject: Testing your jdk builds, both jdk7/tl/jdk and jdk6/jdk6/jdk Message-ID: <4B283B10.9000008@sun.com> The jdk/test/Makefile should be in both jdk7/tl and jdk6/jdk6 repositories now. The jtreg tool is needed, so to download and install the latest jtreg tool do the following: wget http://www.java.net/download/openjdk/jtreg/promoted/b03/jtreg-4_0-bin-b03-31_mar_2009.zip unzip jtreg-4_0-bin-b03-31_mar_2009.zip export JT_HOME=`pwd`/jtreg Build your jdk image, e.g. cd jdk/make && gnumake all images Then run all the stable jdk tests: cd jdk/test && gnumake -k jdk_all If you have a 2 CPU machine and are feeling brave, try: cd jdk/test && gnumake -k -j 4 jdk_all If you do try this out, please let me know how it went. I'm still refining what tests are considered "stable" and I haven't completed my testing of Windows&CYGWIN, so I know the set of tests run will be changing a little. -kto From assembling.signals at yandex.ru Thu Dec 17 02:21:49 2009 From: assembling.signals at yandex.ru (assembling signals) Date: Thu, 17 Dec 2009 05:21:49 +0300 Subject: NIO2's Path.moveTo(...) needs renameTo(...) aequivalent, or at least javadoc clarification. Message-ID: <3091261016509@webmail114.yandex.ru> Hello, everyone! It seems to be complicated/confusing to rename (not move) a file (a Path) using NIO2's Path.moveTo(...). Following code is necessary: Path dir = oldFile.getParent(); Path fn = oldFile.getFileSystem().getPath(newNameString); Path target = (dir == null) ? fn : dir.resolve(fn); oldFile.moveTo(target); Got the problem and the code from here: http://stackoverflow.com/questions/1914474/how-do-i-rename-not-move-a-file-in-jdk7 Wouldn't it be good, to create a Path.renameTo(String newName) method? Or at least clarification in javadoc? (Which is far less appropriate, an API has to "talk" to the user by classes and methods names) I'm afraid, most people will start using File.renameTo(File newFile), which would fail to handle symbolic-link correctly. Or, what is even worse, people will try to cut-and-slice some string around, and create a destination Path of the result. Something like: Path newName = Paths.get(name.getParent().toString()+File.pathSeparator+"newName"); What do you think about the problem? Best regards, Ivan G Shevchenko -- assembling dot signals at yandex dot ru From Alan.Bateman at Sun.COM Thu Dec 17 08:15:08 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 17 Dec 2009 08:15:08 +0000 Subject: NIO2's Path.moveTo(...) needs renameTo(...) aequivalent, or at least javadoc clarification. In-Reply-To: <3091261016509@webmail114.yandex.ru> References: <3091261016509@webmail114.yandex.ru> Message-ID: <4B29E88C.3030505@sun.com> assembling signals wrote: > Hello, everyone! > > It seems to be complicated/confusing to rename (not move) a file (a Path) using NIO2's Path.moveTo(...). > I'd suggest bringing this up on the nio-dev as there was a recent discussion on this. In summary source.moveTo(target) will always attempt a rename by default but it isn't clear from the javadoc (and that will be fixed). See also http://bugs.sun.com/view_bug.do?bug_id=6878283 where that discussion was looking for another option that will prevent moveTo moving the file across file systems/volumes. -Alan. From opinali at gmail.com Thu Dec 17 14:08:04 2009 From: opinali at gmail.com (Osvaldo Doederlein) Date: Thu, 17 Dec 2009 12:08:04 -0200 Subject: Collection.synchronizedXxx() : deadlocks, javadocs Message-ID: Hi, I just suffered the following deadlock, stress-testing my app in a JavaEE application server: Thread 1: at java.util.Collections$SynchronizedSet.hashCode(Collections.java:1658) - waiting to lock <0xfffffd7fdd8ce548> (a java.util.Collections$SynchronizedSet) Thread 2: at java.util.Collections$SynchronizedCollection.size(Collections.java:1557) - waiting to lock <0xfffffd7fde2bb1a0> (a java.util.Collections$SynchronizedSet) at java.util.AbstractSet.equals(AbstractSet.java:75) at java.util.Collections$SynchronizedSet.equals(Collections.java:1655) - locked <0xfffffd7fdd8ce548> (a java.util.Collections$SynchronizedSet) Thread 3: at java.util.Collections$SynchronizedCollection.size(Collections.java:1557) - waiting to lock <0xfffffd7fdd8ce548> (a java.util.Collections$SynchronizedSet) at java.util.AbstractSet.equals(AbstractSet.java:75) at java.util.Collections$SynchronizedSet.equals(Collections.java:1655) - locked <0xfffffd7fde2bb1a0> (a java.util.Collections$SynchronizedSet) This appserver has some internal Sets containing credentials information, protected by Collections.synchronizedSet(). It seems the credentials sets are often compared to each other, by just calling set1.equals(set2). This causes a deadlock because equals() will invoke methods on set2, that are also synchronized, but the appserver does this concurrently in many threads for each application transaction. (My JVM dump reveals no less than 20 app threads involved in this dealock: 18 of these waiting on 0xfffffd7fdd8ce548 to call hashCode(), 1 waiting on the same lock to call size(), and 1 waiting on 0xfffffd7fde2bb1a0 also to call size().) Now this is obviously a bug in the appserver, it should be using a lock on the entire group of such Sets, at least for operations that involve more than one Set like equals(). The javadocs already make clear that the synchronized wrappers are not safe in some cases: "It is imperative that the user manually synchronize on the returned sorted set when iterating over it or any of its subSet, headSet, or tailSet views." But this documentation doesn't cover other methods that may take another synchronized collection as a parameters and may iterate it ("implementation detail" although easy to guess), like containsAll(), retainAll(), etc. The size() method is another special case, equals() could deadlock even when comparing two empty Sets, because it needs minimally to invoke size() in the other collection and this is sufficient to deadlock. I wonder if we should have even more warnings in the javadocs, covering all 'dangerous' methods. This is not a stupid n00b bug, it's code from one of the leading commercial application servers and I suppose its developers are very skilled, still this bug is there (I'm going to report it today). Generally, the synchronized wrappers are a pretty bad options, remarkably since J2SE 5.0. I'd even go as far as suggesting that we just deprecate all the Collections.synchronizedXxx() methods; besides deadlocks, it's way too easy to have races by sequentially invoking multiple methods in the same collections. The synchronizedXxx() APIs send the wrong message that locking individual methods of the collection objects is adequate, which in my experience is a bad (or at least fragile) assumption in 99% of the cases - collections are just too fine-grained. There are other pitfalls, like hashCode/equals() not delegating to the backing collection only for synchronizedCollection(). In a separate issue, the collections returned by synchronizedXxx() are synchronized using the original collection's monitor, so that this is safe: Set sync1 = Collections.synchronizedSet(set1); Set sync2 = Collections.synchronizedSet(set2); synchronized (set1) { synchronized (set2) { if (sync1.equals(sync2) {...} } } In the equals() call above, no deadlock is possible, even with other threads that invoke methods in sync1 or sync2, as long as any threads that use both will perform the same explicit locking in the same order set1->set2. Encapsulating a mutex is a common practice, but in this case I wonder if it's a good idea, at least as implemented (there is no public method to provide the mutex, allowing the user to trade some scalability for code that's simple and guaranteed deadlock-free). The user may decide to write synchronized(sync1)... to prevent deadlocks like the one I reported, and this is dangerous precisely because it would work most of the time - only really convoluted code would still deadlock. The javadocs don't give any clue of how the returned collections are synchronized, which is also bad because I cannot rely that the code above will always work - I just know it works for the particular Sun JDK release which sources I inspected. Some code out there should certainly use this implementation knowledge to safely synchronize groups of synchronizedXxx()'s collections, so this implementation cannot be changed for good or bad. Once again, I suggest additional documentation, to make the synchronization strategy explicit and contractual. P.S.: I also noticed some optimization opportunities along the collections hierarchy. For example, AbstractSet.equals(other) could be redefined in sorted sets, when other is also sorted, to not require lookups of each value - just iterate both in the same direction comparing each pair of values, so the cost is O(N) on size (the generic implementation is O(N log(N)) for SortedSet.equals(SortedSet)). Even more optimization is often possible for exact classes: for TreeSet.equals(TreeSet), we can visit both internal trees recursively, without the allocation and indirection costs of a Iterator, without initially finding the first entry, and without the complication of successor(). It's a matter of finding the sweet spot between extra performance and extra code size and maintenance - I suggest that at least, those cases with demonstrably Big-O advantage are considered. The current implementation still carries many size/speed tradeoff decisions made back in J2SE 1.2, and I'm all against bloat but collections are something really core, and improvements (especially of Big-O scale) can mean a lot. Notice that the special case of mixed operations with several collections of the same general kind, or even exact class - for equals(), containsAll() etc. - is a very common case, one that's very worth of optimizing for. A+ Osvaldo -------------- next part -------------- An HTML attachment was scrubbed... URL: From kelly.ohair at sun.com Fri Dec 18 02:24:17 2009 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Fri, 18 Dec 2009 02:24:17 +0000 Subject: hg: jdk7/tl/jdk: 6558110: tmp/java/jli/obj_g/static is not deleted automatically Message-ID: <20091218022447.57AFD4247E@hg.openjdk.java.net> Changeset: c6d3ca281660 Author: ohair Date: 2009-12-16 12:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6d3ca281660 6558110: tmp/java/jli/obj_g/static is not deleted automatically Reviewed-by: ksrini ! make/java/jli/Makefile From ptisnovs at redhat.com Fri Dec 18 11:11:01 2009 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Fri, 18 Dec 2009 12:11:01 +0100 Subject: Please review changes in regression test java/util/jar/JarFile/TurkCert.java Message-ID: <4B2B6345.70905@redhat.com> Hi, please review changes in regression test java/util/jar/JarFile/TurkCert.java. Webrev is available at http://cr.openjdk.java.net/~ptisnovs/TurkCert/ We discussed this issue on jdk6-dev mailing list, concretely in this thread: http://mail.openjdk.java.net/pipermail/jdk6-dev/2009-December/thread.html#1056 Thanks in advance Pavel Tisnovsky Red Hat QA From Christopher.Hegarty at Sun.COM Fri Dec 18 14:57:52 2009 From: Christopher.Hegarty at Sun.COM (Christopher Hegarty -Sun Microsystems Ireland) Date: Fri, 18 Dec 2009 14:57:52 +0000 Subject: Please review changes in regression test java/util/jar/JarFile/TurkCert.java In-Reply-To: <4B2B6345.70905@redhat.com> References: <4B2B6345.70905@redhat.com> Message-ID: <4B2B9870.6090206@sun.com> This change seems reasonable. -Chris. Pavel Tisnovsky wrote: > Hi, > > please review changes in regression test > java/util/jar/JarFile/TurkCert.java. > > Webrev is available at http://cr.openjdk.java.net/~ptisnovs/TurkCert/ > > We discussed this issue on jdk6-dev mailing list, concretely in this > thread: > http://mail.openjdk.java.net/pipermail/jdk6-dev/2009-December/thread.html#1056 > > > Thanks in advance > Pavel Tisnovsky > Red Hat QA From mandy.chung at sun.com Fri Dec 18 16:55:58 2009 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Fri, 18 Dec 2009 16:55:58 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20091218165643.300CD4256F@hg.openjdk.java.net> Changeset: a368ebcfeeb6 Author: mchung Date: 2009-12-17 08:11 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a368ebcfeeb6 6898747: Allow JNDI cosnaming provider to be used when java.applet is not present Summary: Check if java.applet.Applet is present before accessing the type Reviewed-by: alanb, vinnie ! src/share/classes/com/sun/jndi/toolkit/corba/CorbaUtils.java Changeset: de776cd139aa Author: mchung Date: 2009-12-18 07:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de776cd139aa Merge From joe.darcy at sun.com Fri Dec 18 19:15:41 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 18 Dec 2009 19:15:41 +0000 Subject: hg: jdk7/tl/langtools: 6911854: Update TestElementsAnnotatedWith.java to use @compile/proc Message-ID: <20091218191549.4A099425A3@hg.openjdk.java.net> Changeset: 96c71cbc544b Author: darcy Date: 2009-12-18 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/96c71cbc544b 6911854: Update TestElementsAnnotatedWith.java to use @compile/proc Reviewed-by: jjg ! test/tools/javac/processing/environment/round/TestElementsAnnotatedWith.java From mandy.chung at sun.com Fri Dec 18 20:48:44 2009 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Fri, 18 Dec 2009 20:48:44 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20091218204909.B2971425CA@hg.openjdk.java.net> Changeset: da43f2e977ac Author: mchung Date: 2009-12-18 11:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/da43f2e977ac 6909572: Add a new target for building modules Summary: Add a new "modules" build target that builds jdk and jre module image Reviewed-by: alanb, ohair ! make/Makefile + make/common/Modules.gmk + make/modules/Makefile + make/modules/bootmodule.roots + make/modules/jdk7.depconfig + make/modules/modules.config + make/modules/modules.group + make/modules/optional.depconfig + make/modules/tools/Makefile + make/modules/tools/build.xml + make/modules/tools/nbproject/project.properties + make/modules/tools/nbproject/project.xml + make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java + make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java + make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java + make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java + make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java + make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java + make/modules/tools/src/com/sun/classanalyzer/ClassPath.java + make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java + make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java + make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java + make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java + make/modules/tools/src/com/sun/classanalyzer/Klass.java + make/modules/tools/src/com/sun/classanalyzer/Module.java + make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java + make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java + make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java + make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: b8d1e718ea6d Author: mchung Date: 2009-12-18 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8d1e718ea6d 6909573: Temporary launcher support to add modules in the bootclasspath Summary: Add the list of modules to the bootclasspath if lib/rt.jar and classes don't exist Reviewed-by: alanb, ohair, ksrini ! src/share/bin/java.c From tim.bell at sun.com Sun Dec 20 18:43:31 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 20 Dec 2009 18:43:31 +0000 Subject: hg: jdk7/tl: 5 new changesets Message-ID: <20091220184332.62950428B7@hg.openjdk.java.net> Changeset: 721c1696c124 Author: mikejwre Date: 2009-12-03 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/721c1696c124 Added tag jdk7-b77 for changeset 1f17ca8353ba ! .hgtags Changeset: 80161484b6b1 Author: tbell Date: 2009-12-08 09:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/80161484b6b1 Merge Changeset: ea77a8b9b028 Author: ohair Date: 2009-12-16 12:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/ea77a8b9b028 6909462: Fix nbproject/private references in .hgignore Summary: See bugzilla issue 100097 Reviewed-by: tbell Contributed-by: Jesse Glick ! .hgignore Changeset: ab4ae8f45146 Author: mikejwre Date: 2009-12-16 23:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/ab4ae8f45146 Merge Changeset: 20aeeb517139 Author: mikejwre Date: 2009-12-17 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/20aeeb517139 Added tag jdk7-b78 for changeset ab4ae8f45146 ! .hgtags From tim.bell at sun.com Sun Dec 20 18:43:37 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 20 Dec 2009 18:43:37 +0000 Subject: hg: jdk7/tl/corba: 5 new changesets Message-ID: <20091220184342.B2875428B8@hg.openjdk.java.net> Changeset: 28b983e5bb5f Author: gbenson Date: 2009-11-23 10:04 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/28b983e5bb5f 6903453: Zero build on ARM and IA-64 Summary: Correctly set uname on ARM, and correctly build fdlibm on IA-64 Reviewed-by: ohair ! make/common/shared/Platform.gmk Changeset: 6881f0383f62 Author: ohair Date: 2009-11-25 11:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/6881f0383f62 Merge Changeset: 6977ccc8827e Author: mikejwre Date: 2009-12-03 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/6977ccc8827e Added tag jdk7-b77 for changeset 6881f0383f62 ! .hgtags Changeset: a7f7276b48cd Author: ohair Date: 2009-12-16 12:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a7f7276b48cd 6909462: Fix nbproject/private references in .hgignore Summary: See bugzilla issue 100097 Reviewed-by: tbell Contributed-by: Jesse Glick ! .hgignore Changeset: ec0421b5703b Author: mikejwre Date: 2009-12-17 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/ec0421b5703b Added tag jdk7-b78 for changeset a7f7276b48cd ! .hgtags From tim.bell at sun.com Sun Dec 20 18:45:17 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 20 Dec 2009 18:45:17 +0000 Subject: hg: jdk7/tl/hotspot: 3 new changesets Message-ID: <20091220184528.DC0EC428BA@hg.openjdk.java.net> Changeset: 7589c1b72907 Author: mikejwre Date: 2009-12-03 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7589c1b72907 Added tag jdk7-b77 for changeset 455105fc81d9 ! .hgtags Changeset: e703499b4b51 Author: ohair Date: 2009-12-16 12:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e703499b4b51 6909462: Fix nbproject/private references in .hgignore Summary: See bugzilla issue 100097 Reviewed-by: tbell Contributed-by: Jesse Glick ! .hgignore Changeset: 1cf572922ff1 Author: mikejwre Date: 2009-12-17 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1cf572922ff1 Added tag jdk7-b78 for changeset e703499b4b51 ! .hgtags From tim.bell at sun.com Sun Dec 20 18:47:32 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 20 Dec 2009 18:47:32 +0000 Subject: hg: jdk7/tl/jaxp: 3 new changesets Message-ID: <20091220184732.CFFA4428BD@hg.openjdk.java.net> Changeset: 90bbdc1a6258 Author: mikejwre Date: 2009-12-03 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/90bbdc1a6258 Added tag jdk7-b77 for changeset bfadab8c7b1b ! .hgtags Changeset: 7a12d3789e1b Author: ohair Date: 2009-12-16 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/7a12d3789e1b 6909462: Fix nbproject/private references in .hgignore Summary: See bugzilla issue 100097 Reviewed-by: tbell Contributed-by: Jesse Glick ! .hgignore Changeset: b1005c504358 Author: mikejwre Date: 2009-12-17 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/b1005c504358 Added tag jdk7-b78 for changeset 7a12d3789e1b ! .hgtags From tim.bell at sun.com Sun Dec 20 18:47:39 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 20 Dec 2009 18:47:39 +0000 Subject: hg: jdk7/tl/jaxws: 3 new changesets Message-ID: <20091220184739.F1465428BE@hg.openjdk.java.net> Changeset: 96e510caa8e7 Author: mikejwre Date: 2009-12-03 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/96e510caa8e7 Added tag jdk7-b77 for changeset 5b4968c11047 ! .hgtags Changeset: fc1c72d1dfbb Author: ohair Date: 2009-12-16 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/fc1c72d1dfbb 6909462: Fix nbproject/private references in .hgignore Summary: See bugzilla issue 100097 Reviewed-by: tbell Contributed-by: Jesse Glick ! .hgignore Changeset: c08894f5b6e5 Author: mikejwre Date: 2009-12-17 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/c08894f5b6e5 Added tag jdk7-b78 for changeset fc1c72d1dfbb ! .hgtags From tim.bell at sun.com Sun Dec 20 18:51:20 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 20 Dec 2009 18:51:20 +0000 Subject: hg: jdk7/tl/jdk: 47 new changesets Message-ID: <20091220190116.F05FF428C2@hg.openjdk.java.net> Changeset: ad1c88142958 Author: gbenson Date: 2009-11-23 10:04 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ad1c88142958 6903453: Zero build on ARM and IA-64 Summary: Correctly set uname on ARM, and correctly build fdlibm on IA-64 Reviewed-by: ohair ! make/common/shared/Platform.gmk ! src/share/native/java/lang/fdlibm/include/fdlibm.h Changeset: e6a5d095c356 Author: ohair Date: 2009-11-25 11:08 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e6a5d095c356 Merge - src/share/classes/com/sun/jmx/event/DaemonThreadFactory.java - src/share/classes/com/sun/jmx/event/EventBuffer.java - src/share/classes/com/sun/jmx/event/EventClientFactory.java - src/share/classes/com/sun/jmx/event/EventConnection.java - src/share/classes/com/sun/jmx/event/EventParams.java - src/share/classes/com/sun/jmx/event/LeaseManager.java - src/share/classes/com/sun/jmx/event/LeaseRenewer.java - src/share/classes/com/sun/jmx/event/ReceiverBuffer.java - src/share/classes/com/sun/jmx/event/RepeatedSingletonJob.java - src/share/classes/com/sun/jmx/interceptor/DispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/DomainDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/MBeanServerInterceptorSupport.java - src/share/classes/com/sun/jmx/interceptor/NamespaceDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java - src/share/classes/com/sun/jmx/mbeanserver/MBeanInjector.java - src/share/classes/com/sun/jmx/mbeanserver/NotificationMBeanSupport.java - src/share/classes/com/sun/jmx/mbeanserver/NotifySupport.java - src/share/classes/com/sun/jmx/mbeanserver/PerThreadGroupPool.java - src/share/classes/com/sun/jmx/namespace/DomainInterceptor.java - src/share/classes/com/sun/jmx/namespace/HandlerInterceptor.java - src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java - src/share/classes/com/sun/jmx/namespace/ObjectNameRouter.java - src/share/classes/com/sun/jmx/namespace/RoutingConnectionProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingMBeanServerConnection.java - src/share/classes/com/sun/jmx/namespace/RoutingProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingServerProxy.java - src/share/classes/com/sun/jmx/namespace/package.html - src/share/classes/com/sun/jmx/namespace/serial/DefaultRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/IdentityProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/JMXNamespaceContext.java - src/share/classes/com/sun/jmx/namespace/serial/RewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/RoutingOnlyProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/SerialRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/package.html - src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java - src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java - src/share/classes/javax/management/ClientContext.java - src/share/classes/javax/management/Description.java - src/share/classes/javax/management/DescriptorFields.java - src/share/classes/javax/management/DynamicWrapperMBean.java - src/share/classes/javax/management/GenericMBeanException.java - src/share/classes/javax/management/Impact.java - src/share/classes/javax/management/MBean.java - src/share/classes/javax/management/ManagedAttribute.java - src/share/classes/javax/management/ManagedOperation.java - src/share/classes/javax/management/NotificationInfo.java - src/share/classes/javax/management/NotificationInfos.java - src/share/classes/javax/management/ObjectNameTemplate.java - src/share/classes/javax/management/QueryNotificationFilter.java - src/share/classes/javax/management/QueryParser.java - src/share/classes/javax/management/SendNotification.java - src/share/classes/javax/management/event/EventClient.java - src/share/classes/javax/management/event/EventClientDelegate.java - src/share/classes/javax/management/event/EventClientDelegateMBean.java - src/share/classes/javax/management/event/EventClientNotFoundException.java - src/share/classes/javax/management/event/EventConsumer.java - src/share/classes/javax/management/event/EventForwarder.java - src/share/classes/javax/management/event/EventReceiver.java - src/share/classes/javax/management/event/EventRelay.java - src/share/classes/javax/management/event/EventSubscriber.java - src/share/classes/javax/management/event/FetchingEventForwarder.java - src/share/classes/javax/management/event/FetchingEventRelay.java - src/share/classes/javax/management/event/ListenerInfo.java - src/share/classes/javax/management/event/NotificationManager.java - src/share/classes/javax/management/event/RMIPushEventForwarder.java - src/share/classes/javax/management/event/RMIPushEventRelay.java - src/share/classes/javax/management/event/RMIPushServer.java - src/share/classes/javax/management/event/package-info.java - src/share/classes/javax/management/namespace/JMXDomain.java - src/share/classes/javax/management/namespace/JMXNamespace.java - src/share/classes/javax/management/namespace/JMXNamespaceMBean.java - src/share/classes/javax/management/namespace/JMXNamespacePermission.java - src/share/classes/javax/management/namespace/JMXNamespaceView.java - src/share/classes/javax/management/namespace/JMXNamespaces.java - src/share/classes/javax/management/namespace/JMXRemoteNamespace.java - src/share/classes/javax/management/namespace/JMXRemoteNamespaceMBean.java - src/share/classes/javax/management/namespace/MBeanServerConnectionWrapper.java - src/share/classes/javax/management/namespace/MBeanServerSupport.java - src/share/classes/javax/management/namespace/VirtualEventManager.java - src/share/classes/javax/management/namespace/package-info.java - src/share/classes/javax/management/openmbean/MXBeanMapping.java - src/share/classes/javax/management/openmbean/MXBeanMappingClass.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactory.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactoryClass.java - src/share/classes/javax/management/remote/IdentityMBeanServerForwarder.java - src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java - src/share/classes/sun/net/www/protocol/http/NegotiateCallbackHandler.java - src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java - src/share/classes/sun/security/ssl/KerberosPreMasterSecret.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthSequence.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c - test/javax/management/Introspector/AnnotatedMBeanTest.java - test/javax/management/Introspector/AnnotatedNotificationInfoTest.java - test/javax/management/Introspector/ExceptionsDescriptorTest.java - test/javax/management/Introspector/MBeanDescriptionTest.java - test/javax/management/Introspector/ObjectNameTemplateTest.java - test/javax/management/Introspector/ParameterNameTest.java - test/javax/management/Introspector/ResourceInjectionTest.java - test/javax/management/MBeanServer/AttributeListMapTest.java - test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java - test/javax/management/MBeanServer/InstanceNotFoundExceptionTest.java - test/javax/management/MBeanServerFactory/NamedMBeanServerTest.java - test/javax/management/ObjectName/ValueOfTest.java - test/javax/management/context/ContextForwarderTest.java - test/javax/management/context/ContextTest.java - test/javax/management/context/LocaleAwareBroadcasterTest.java - test/javax/management/context/LocaleTest.java - test/javax/management/context/LocalizableTest.java - test/javax/management/context/RemoteContextTest.java - test/javax/management/context/localizable/MBeanDescriptions.properties - test/javax/management/context/localizable/MBeanDescriptions_fr.java - test/javax/management/context/localizable/Whatsit.java - test/javax/management/context/localizable/WhatsitMBean.java - test/javax/management/descriptor/DescriptorConstructorTest.java - test/javax/management/eventService/AddRemoveListenerTest.java - test/javax/management/eventService/CustomForwarderTest.java - test/javax/management/eventService/EventClientExecutorTest.java - test/javax/management/eventService/EventClientThreadTest.java - test/javax/management/eventService/EventDelegateSecurityTest.java - test/javax/management/eventService/EventManagerTest.java - test/javax/management/eventService/FetchingTest.java - test/javax/management/eventService/LeaseManagerDeadlockTest.java - test/javax/management/eventService/LeaseTest.java - test/javax/management/eventService/ListenerTest.java - test/javax/management/eventService/MyFetchingEventForwarder.java - test/javax/management/eventService/NotSerializableNotifTest.java - test/javax/management/eventService/PublishTest.java - test/javax/management/eventService/ReconnectableConnectorTest.java - test/javax/management/eventService/SharingThreadTest.java - test/javax/management/eventService/SubUnsubTest.java - test/javax/management/eventService/SubscribeTest.java - test/javax/management/eventService/UsingEventService.java - test/javax/management/interop/MBeanExceptionInteropTest.java - test/javax/management/modelmbean/DefaultDescriptorFieldTest.java - test/javax/management/monitor/InstantiateMonitorNotificationTest.java - test/javax/management/mxbean/CustomTypeTest.java - test/javax/management/mxbean/JMXServiceURLTest.java - test/javax/management/mxbean/customtypes/CustomLongMXBean.java - test/javax/management/mxbean/customtypes/CustomMXBean.java - test/javax/management/mxbean/customtypes/IntegerIsLongFactory.java - test/javax/management/mxbean/customtypes/IntegerIsStringFactory.java - test/javax/management/mxbean/customtypes/package-info.java - test/javax/management/namespace/DomainCreationTest.java - test/javax/management/namespace/EventWithNamespaceControlTest.java - test/javax/management/namespace/EventWithNamespaceTest.java - test/javax/management/namespace/ExportNamespaceTest.java - test/javax/management/namespace/JMXDomainTest.java - test/javax/management/namespace/JMXNamespaceSecurityTest.java - test/javax/management/namespace/JMXNamespaceTest.java - test/javax/management/namespace/JMXNamespaceViewTest.java - test/javax/management/namespace/JMXNamespacesTest.java - test/javax/management/namespace/JMXRemoteNamespaceTest.java - test/javax/management/namespace/JMXRemoteTargetNamespace.java - test/javax/management/namespace/LazyDomainTest.java - test/javax/management/namespace/LeadingSeparatorsTest.java - test/javax/management/namespace/MXBeanRefTest.java - test/javax/management/namespace/NamespaceController.java - test/javax/management/namespace/NamespaceControllerMBean.java - test/javax/management/namespace/NamespaceCreationTest.java - test/javax/management/namespace/NamespaceNotificationsTest.java - test/javax/management/namespace/NullDomainObjectNameTest.java - test/javax/management/namespace/NullObjectNameTest.java - test/javax/management/namespace/QueryNamesTest.java - test/javax/management/namespace/RemoveNotificationListenerTest.java - test/javax/management/namespace/RoutingServerProxyTest.java - test/javax/management/namespace/SerialParamProcessorTest.java - test/javax/management/namespace/SourceNamespaceTest.java - test/javax/management/namespace/VirtualMBeanNotifTest.java - test/javax/management/namespace/VirtualMBeanTest.java - test/javax/management/namespace/VirtualNamespaceQueryTest.java - test/javax/management/namespace/VirtualPropsTest.java - test/javax/management/namespace/Wombat.java - test/javax/management/namespace/WombatMBean.java - test/javax/management/namespace/namespace.policy - test/javax/management/notification/SupportClearTest.java - test/javax/management/openmbean/CompositeDataToMapTest.java - test/javax/management/openmbean/GenericMBeanExceptionTest.java - test/javax/management/query/QueryDottedAttrTest.java - test/javax/management/query/QueryNotifFilterTest.java - test/javax/management/query/QueryParseTest.java - test/javax/management/remote/mandatory/connectorServer/CloseConnectionTest.java - test/javax/management/remote/mandatory/connectorServer/ForwarderChainTest.java - test/javax/management/remote/mandatory/connectorServer/StandardForwardersTest.java - test/javax/management/remote/mandatory/version/JMXSpecVersionTest.java - test/javax/management/standardmbean/FindMethodTest.java - test/javax/management/standardmbean/RegistrationTest.java Changeset: c4752fd11cf0 Author: mikejwre Date: 2009-12-03 12:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c4752fd11cf0 Added tag jdk7-b77 for changeset e6a5d095c356 ! .hgtags Changeset: d7c07e9258a9 Author: tbell Date: 2009-12-08 09:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d7c07e9258a9 Merge - make/tools/CharsetMapping/DoubleByte-X.java - make/tools/CharsetMapping/SingleByte-X.java - src/share/classes/sun/security/provider/IdentityDatabase.java - src/share/classes/sun/security/provider/SystemIdentity.java - src/share/classes/sun/security/provider/SystemSigner.java - src/share/classes/sun/security/x509/X500Signer.java - src/share/classes/sun/security/x509/X509Cert.java - src/share/classes/sun/tools/jar/JarVerifierStream.java - src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java - src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java - test/java/util/Formatter/Basic-X.java - test/sun/tools/native2ascii/test2 - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java Changeset: 479c14bec7f1 Author: prr Date: 2009-11-30 14:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/479c14bec7f1 6904962: GlyphVector.getVisualBounds should not be affected by leading or trailing white space. Reviewed-by: igor, dougfelt ! src/share/classes/sun/font/StandardGlyphVector.java + test/java/awt/font/GlyphVector/VisualBounds.java Changeset: 92fa88af9467 Author: lana Date: 2009-12-02 16:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92fa88af9467 Merge - make/tools/fontchecker/Makefile - make/tools/src/build/tools/fontchecker/FontCheckDummy.java - make/tools/src/build/tools/fontchecker/FontChecker.java - make/tools/src/build/tools/fontchecker/FontCheckerConstants.java - make/tools/src/build/tools/fontchecker/FontFileFilter.java - make/tools/src/build/tools/fontchecker/README.txt - src/share/classes/com/sun/jmx/event/DaemonThreadFactory.java - src/share/classes/com/sun/jmx/event/EventBuffer.java - src/share/classes/com/sun/jmx/event/EventClientFactory.java - src/share/classes/com/sun/jmx/event/EventConnection.java - src/share/classes/com/sun/jmx/event/EventParams.java - src/share/classes/com/sun/jmx/event/LeaseManager.java - src/share/classes/com/sun/jmx/event/LeaseRenewer.java - src/share/classes/com/sun/jmx/event/ReceiverBuffer.java - src/share/classes/com/sun/jmx/event/RepeatedSingletonJob.java - src/share/classes/com/sun/jmx/interceptor/DispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/DomainDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/MBeanServerInterceptorSupport.java - src/share/classes/com/sun/jmx/interceptor/NamespaceDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java - src/share/classes/com/sun/jmx/mbeanserver/MBeanInjector.java - src/share/classes/com/sun/jmx/mbeanserver/NotificationMBeanSupport.java - src/share/classes/com/sun/jmx/mbeanserver/NotifySupport.java - src/share/classes/com/sun/jmx/mbeanserver/PerThreadGroupPool.java - src/share/classes/com/sun/jmx/namespace/DomainInterceptor.java - src/share/classes/com/sun/jmx/namespace/HandlerInterceptor.java - src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java - src/share/classes/com/sun/jmx/namespace/ObjectNameRouter.java - src/share/classes/com/sun/jmx/namespace/RoutingConnectionProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingMBeanServerConnection.java - src/share/classes/com/sun/jmx/namespace/RoutingProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingServerProxy.java - src/share/classes/com/sun/jmx/namespace/package.html - src/share/classes/com/sun/jmx/namespace/serial/DefaultRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/IdentityProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/JMXNamespaceContext.java - src/share/classes/com/sun/jmx/namespace/serial/RewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/RoutingOnlyProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/SerialRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/package.html - src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java - src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java - src/share/classes/java/nio/ByteBufferAs-X-Buffer.java - src/share/classes/java/nio/Direct-X-Buffer-bin.java - src/share/classes/java/nio/Direct-X-Buffer.java - src/share/classes/java/nio/Heap-X-Buffer.java - src/share/classes/java/nio/X-Buffer-bin.java - src/share/classes/java/nio/X-Buffer.java - src/share/classes/java/nio/charset/Charset-X-Coder.java - src/share/classes/javax/management/ClientContext.java - src/share/classes/javax/management/Description.java - src/share/classes/javax/management/DescriptorFields.java - src/share/classes/javax/management/DynamicWrapperMBean.java - src/share/classes/javax/management/GenericMBeanException.java - src/share/classes/javax/management/Impact.java - src/share/classes/javax/management/MBean.java - src/share/classes/javax/management/ManagedAttribute.java - src/share/classes/javax/management/ManagedOperation.java - src/share/classes/javax/management/NotificationInfo.java - src/share/classes/javax/management/NotificationInfos.java - src/share/classes/javax/management/ObjectNameTemplate.java - src/share/classes/javax/management/QueryNotificationFilter.java - src/share/classes/javax/management/QueryParser.java - src/share/classes/javax/management/SendNotification.java - src/share/classes/javax/management/event/EventClient.java - src/share/classes/javax/management/event/EventClientDelegate.java - src/share/classes/javax/management/event/EventClientDelegateMBean.java - src/share/classes/javax/management/event/EventClientNotFoundException.java - src/share/classes/javax/management/event/EventConsumer.java - src/share/classes/javax/management/event/EventForwarder.java - src/share/classes/javax/management/event/EventReceiver.java - src/share/classes/javax/management/event/EventRelay.java - src/share/classes/javax/management/event/EventSubscriber.java - src/share/classes/javax/management/event/FetchingEventForwarder.java - src/share/classes/javax/management/event/FetchingEventRelay.java - src/share/classes/javax/management/event/ListenerInfo.java - src/share/classes/javax/management/event/NotificationManager.java - src/share/classes/javax/management/event/RMIPushEventForwarder.java - src/share/classes/javax/management/event/RMIPushEventRelay.java - src/share/classes/javax/management/event/RMIPushServer.java - src/share/classes/javax/management/event/package-info.java - src/share/classes/javax/management/namespace/JMXDomain.java - src/share/classes/javax/management/namespace/JMXNamespace.java - src/share/classes/javax/management/namespace/JMXNamespaceMBean.java - src/share/classes/javax/management/namespace/JMXNamespacePermission.java - src/share/classes/javax/management/namespace/JMXNamespaceView.java - src/share/classes/javax/management/namespace/JMXNamespaces.java - src/share/classes/javax/management/namespace/JMXRemoteNamespace.java - src/share/classes/javax/management/namespace/JMXRemoteNamespaceMBean.java - src/share/classes/javax/management/namespace/MBeanServerConnectionWrapper.java - src/share/classes/javax/management/namespace/MBeanServerSupport.java - src/share/classes/javax/management/namespace/VirtualEventManager.java - src/share/classes/javax/management/namespace/package-info.java - src/share/classes/javax/management/openmbean/MXBeanMapping.java - src/share/classes/javax/management/openmbean/MXBeanMappingClass.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactory.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactoryClass.java - src/share/classes/javax/management/remote/IdentityMBeanServerForwarder.java - src/share/classes/sun/misc/Version-template.java - src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java - src/share/classes/sun/net/www/protocol/http/NegotiateCallbackHandler.java - src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java - src/share/classes/sun/security/provider/certpath/LDAPCertStore.java - src/share/classes/sun/security/ssl/KerberosPreMasterSecret.java - src/share/classes/sun/tools/jconsole/Version-template.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthSequence.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c - test/java/nio/Buffer/Basic-X.java - test/java/nio/Buffer/CopyDirect-X-Memory.java - test/javax/management/Introspector/AnnotatedMBeanTest.java - test/javax/management/Introspector/AnnotatedNotificationInfoTest.java - test/javax/management/Introspector/ExceptionsDescriptorTest.java - test/javax/management/Introspector/MBeanDescriptionTest.java - test/javax/management/Introspector/ObjectNameTemplateTest.java - test/javax/management/Introspector/ParameterNameTest.java - test/javax/management/Introspector/ResourceInjectionTest.java - test/javax/management/MBeanServer/AttributeListMapTest.java - test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java - test/javax/management/MBeanServer/InstanceNotFoundExceptionTest.java - test/javax/management/MBeanServerFactory/NamedMBeanServerTest.java - test/javax/management/ObjectName/ValueOfTest.java - test/javax/management/context/ContextForwarderTest.java - test/javax/management/context/ContextTest.java - test/javax/management/context/LocaleAwareBroadcasterTest.java - test/javax/management/context/LocaleTest.java - test/javax/management/context/LocalizableTest.java - test/javax/management/context/RemoteContextTest.java - test/javax/management/context/localizable/MBeanDescriptions.properties - test/javax/management/context/localizable/MBeanDescriptions_fr.java - test/javax/management/context/localizable/Whatsit.java - test/javax/management/context/localizable/WhatsitMBean.java - test/javax/management/descriptor/DescriptorConstructorTest.java - test/javax/management/eventService/AddRemoveListenerTest.java - test/javax/management/eventService/CustomForwarderTest.java - test/javax/management/eventService/EventClientExecutorTest.java - test/javax/management/eventService/EventClientThreadTest.java - test/javax/management/eventService/EventDelegateSecurityTest.java - test/javax/management/eventService/EventManagerTest.java - test/javax/management/eventService/FetchingTest.java - test/javax/management/eventService/LeaseManagerDeadlockTest.java - test/javax/management/eventService/LeaseTest.java - test/javax/management/eventService/ListenerTest.java - test/javax/management/eventService/MyFetchingEventForwarder.java - test/javax/management/eventService/NotSerializableNotifTest.java - test/javax/management/eventService/PublishTest.java - test/javax/management/eventService/ReconnectableConnectorTest.java - test/javax/management/eventService/SharingThreadTest.java - test/javax/management/eventService/SubUnsubTest.java - test/javax/management/eventService/SubscribeTest.java - test/javax/management/eventService/UsingEventService.java - test/javax/management/interop/MBeanExceptionInteropTest.java - test/javax/management/modelmbean/DefaultDescriptorFieldTest.java - test/javax/management/monitor/InstantiateMonitorNotificationTest.java - test/javax/management/mxbean/CustomTypeTest.java - test/javax/management/mxbean/JMXServiceURLTest.java - test/javax/management/mxbean/customtypes/CustomLongMXBean.java - test/javax/management/mxbean/customtypes/CustomMXBean.java - test/javax/management/mxbean/customtypes/IntegerIsLongFactory.java - test/javax/management/mxbean/customtypes/IntegerIsStringFactory.java - test/javax/management/mxbean/customtypes/package-info.java - test/javax/management/namespace/DomainCreationTest.java - test/javax/management/namespace/EventWithNamespaceControlTest.java - test/javax/management/namespace/EventWithNamespaceTest.java - test/javax/management/namespace/ExportNamespaceTest.java - test/javax/management/namespace/JMXDomainTest.java - test/javax/management/namespace/JMXNamespaceSecurityTest.java - test/javax/management/namespace/JMXNamespaceTest.java - test/javax/management/namespace/JMXNamespaceViewTest.java - test/javax/management/namespace/JMXNamespacesTest.java - test/javax/management/namespace/JMXRemoteNamespaceTest.java - test/javax/management/namespace/JMXRemoteTargetNamespace.java - test/javax/management/namespace/LazyDomainTest.java - test/javax/management/namespace/LeadingSeparatorsTest.java - test/javax/management/namespace/MXBeanRefTest.java - test/javax/management/namespace/NamespaceController.java - test/javax/management/namespace/NamespaceControllerMBean.java - test/javax/management/namespace/NamespaceCreationTest.java - test/javax/management/namespace/NamespaceNotificationsTest.java - test/javax/management/namespace/NullDomainObjectNameTest.java - test/javax/management/namespace/NullObjectNameTest.java - test/javax/management/namespace/QueryNamesTest.java - test/javax/management/namespace/RemoveNotificationListenerTest.java - test/javax/management/namespace/RoutingServerProxyTest.java - test/javax/management/namespace/SerialParamProcessorTest.java - test/javax/management/namespace/SourceNamespaceTest.java - test/javax/management/namespace/VirtualMBeanNotifTest.java - test/javax/management/namespace/VirtualMBeanTest.java - test/javax/management/namespace/VirtualNamespaceQueryTest.java - test/javax/management/namespace/VirtualPropsTest.java - test/javax/management/namespace/Wombat.java - test/javax/management/namespace/WombatMBean.java - test/javax/management/namespace/namespace.policy - test/javax/management/notification/SupportClearTest.java - test/javax/management/openmbean/CompositeDataToMapTest.java - test/javax/management/openmbean/GenericMBeanExceptionTest.java - test/javax/management/query/QueryDottedAttrTest.java - test/javax/management/query/QueryNotifFilterTest.java - test/javax/management/query/QueryParseTest.java - test/javax/management/remote/mandatory/connectorServer/CloseConnectionTest.java - test/javax/management/remote/mandatory/connectorServer/ForwarderChainTest.java - test/javax/management/remote/mandatory/connectorServer/StandardForwardersTest.java - test/javax/management/remote/mandatory/version/JMXSpecVersionTest.java - test/javax/management/standardmbean/FindMethodTest.java - test/javax/management/standardmbean/RegistrationTest.java Changeset: 9f220ed252d9 Author: lana Date: 2009-12-10 09:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f220ed252d9 Merge Changeset: 6286daeb7d5a Author: anthony Date: 2009-11-20 19:11 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6286daeb7d5a 6863566: Java should support the freedesktop.org startup notification specification Summary: The startup notification gets removed as soon as a Java top-level window is shown Reviewed-by: anthony, art, dcherepanov Contributed-by: Damjan Jovanovic ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: 84b4935285c8 Author: denis Date: 2009-11-24 18:46 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/84b4935285c8 5098433: REG: DnD of File-List between JVM is broken for non ASCII file names - Win32 Reviewed-by: uta, dav ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/windows/native/sun/windows/awt_DnDDS.cpp + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/AbsoluteComponentCenterCalculator.java + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.java + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/FileListTransferable.java + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/InterprocessMessages.java + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/NextFramePositionCalculator.java + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/SourcePanel.java + test/java/awt/datatransfer/DragUnicodeBetweenJVMTest/TargetPanel.java Changeset: b62c74b1772e Author: denis Date: 2009-11-25 21:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b62c74b1772e 4899516: Transferable has no DataFlavors when dragging from Gnome window to Swing Reviewed-by: uta, dav Contributed-by: Damjan Jovanovic ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/solaris/classes/sun/awt/X11/XDataTransferer.java ! src/solaris/lib/flavormap.properties ! src/windows/classes/sun/awt/windows/WDataTransferer.java + test/java/awt/dnd/URIListBetweenJVMsTest/FileListTransferable.java + test/java/awt/dnd/URIListBetweenJVMsTest/InterprocessMessages.java + test/java/awt/dnd/URIListBetweenJVMsTest/SourceFileListFrame.java + test/java/awt/dnd/URIListBetweenJVMsTest/TargetFileListFrame.java + test/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html + test/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.java ! test/java/awt/regtesthelpers/process/ProcessCommunicator.java Changeset: 6fd07b903478 Author: lana Date: 2009-11-25 22:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6fd07b903478 Merge - make/tools/fontchecker/Makefile - make/tools/src/build/tools/fontchecker/FontCheckDummy.java - make/tools/src/build/tools/fontchecker/FontChecker.java - make/tools/src/build/tools/fontchecker/FontCheckerConstants.java - make/tools/src/build/tools/fontchecker/FontFileFilter.java - make/tools/src/build/tools/fontchecker/README.txt - src/share/classes/com/sun/jmx/event/DaemonThreadFactory.java - src/share/classes/com/sun/jmx/event/EventBuffer.java - src/share/classes/com/sun/jmx/event/EventClientFactory.java - src/share/classes/com/sun/jmx/event/EventConnection.java - src/share/classes/com/sun/jmx/event/EventParams.java - src/share/classes/com/sun/jmx/event/LeaseManager.java - src/share/classes/com/sun/jmx/event/LeaseRenewer.java - src/share/classes/com/sun/jmx/event/ReceiverBuffer.java - src/share/classes/com/sun/jmx/event/RepeatedSingletonJob.java - src/share/classes/com/sun/jmx/interceptor/DispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/DomainDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/MBeanServerInterceptorSupport.java - src/share/classes/com/sun/jmx/interceptor/NamespaceDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java - src/share/classes/com/sun/jmx/mbeanserver/MBeanInjector.java - src/share/classes/com/sun/jmx/mbeanserver/NotificationMBeanSupport.java - src/share/classes/com/sun/jmx/mbeanserver/NotifySupport.java - src/share/classes/com/sun/jmx/mbeanserver/PerThreadGroupPool.java - src/share/classes/com/sun/jmx/namespace/DomainInterceptor.java - src/share/classes/com/sun/jmx/namespace/HandlerInterceptor.java - src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java - src/share/classes/com/sun/jmx/namespace/ObjectNameRouter.java - src/share/classes/com/sun/jmx/namespace/RoutingConnectionProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingMBeanServerConnection.java - src/share/classes/com/sun/jmx/namespace/RoutingProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingServerProxy.java - src/share/classes/com/sun/jmx/namespace/package.html - src/share/classes/com/sun/jmx/namespace/serial/DefaultRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/IdentityProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/JMXNamespaceContext.java - src/share/classes/com/sun/jmx/namespace/serial/RewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/RoutingOnlyProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/SerialRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/package.html - src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java - src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java - src/share/classes/java/nio/ByteBufferAs-X-Buffer.java - src/share/classes/java/nio/Direct-X-Buffer-bin.java - src/share/classes/java/nio/Direct-X-Buffer.java - src/share/classes/java/nio/Heap-X-Buffer.java - src/share/classes/java/nio/X-Buffer-bin.java - src/share/classes/java/nio/X-Buffer.java - src/share/classes/java/nio/charset/Charset-X-Coder.java - src/share/classes/javax/management/ClientContext.java - src/share/classes/javax/management/Description.java - src/share/classes/javax/management/DescriptorFields.java - src/share/classes/javax/management/DynamicWrapperMBean.java - src/share/classes/javax/management/GenericMBeanException.java - src/share/classes/javax/management/Impact.java - src/share/classes/javax/management/MBean.java - src/share/classes/javax/management/ManagedAttribute.java - src/share/classes/javax/management/ManagedOperation.java - src/share/classes/javax/management/NotificationInfo.java - src/share/classes/javax/management/NotificationInfos.java - src/share/classes/javax/management/ObjectNameTemplate.java - src/share/classes/javax/management/QueryNotificationFilter.java - src/share/classes/javax/management/QueryParser.java - src/share/classes/javax/management/SendNotification.java - src/share/classes/javax/management/event/EventClient.java - src/share/classes/javax/management/event/EventClientDelegate.java - src/share/classes/javax/management/event/EventClientDelegateMBean.java - src/share/classes/javax/management/event/EventClientNotFoundException.java - src/share/classes/javax/management/event/EventConsumer.java - src/share/classes/javax/management/event/EventForwarder.java - src/share/classes/javax/management/event/EventReceiver.java - src/share/classes/javax/management/event/EventRelay.java - src/share/classes/javax/management/event/EventSubscriber.java - src/share/classes/javax/management/event/FetchingEventForwarder.java - src/share/classes/javax/management/event/FetchingEventRelay.java - src/share/classes/javax/management/event/ListenerInfo.java - src/share/classes/javax/management/event/NotificationManager.java - src/share/classes/javax/management/event/RMIPushEventForwarder.java - src/share/classes/javax/management/event/RMIPushEventRelay.java - src/share/classes/javax/management/event/RMIPushServer.java - src/share/classes/javax/management/event/package-info.java - src/share/classes/javax/management/namespace/JMXDomain.java - src/share/classes/javax/management/namespace/JMXNamespace.java - src/share/classes/javax/management/namespace/JMXNamespaceMBean.java - src/share/classes/javax/management/namespace/JMXNamespacePermission.java - src/share/classes/javax/management/namespace/JMXNamespaceView.java - src/share/classes/javax/management/namespace/JMXNamespaces.java - src/share/classes/javax/management/namespace/JMXRemoteNamespace.java - src/share/classes/javax/management/namespace/JMXRemoteNamespaceMBean.java - src/share/classes/javax/management/namespace/MBeanServerConnectionWrapper.java - src/share/classes/javax/management/namespace/MBeanServerSupport.java - src/share/classes/javax/management/namespace/VirtualEventManager.java - src/share/classes/javax/management/namespace/package-info.java - src/share/classes/javax/management/openmbean/MXBeanMapping.java - src/share/classes/javax/management/openmbean/MXBeanMappingClass.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactory.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactoryClass.java - src/share/classes/javax/management/remote/IdentityMBeanServerForwarder.java - src/share/classes/sun/misc/Version-template.java - src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java - src/share/classes/sun/net/www/protocol/http/NegotiateCallbackHandler.java - src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java - src/share/classes/sun/security/provider/certpath/LDAPCertStore.java - src/share/classes/sun/security/ssl/KerberosPreMasterSecret.java - src/share/classes/sun/tools/jconsole/Version-template.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthSequence.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c - test/java/nio/Buffer/Basic-X.java - test/java/nio/Buffer/CopyDirect-X-Memory.java - test/javax/management/Introspector/AnnotatedMBeanTest.java - test/javax/management/Introspector/AnnotatedNotificationInfoTest.java - test/javax/management/Introspector/ExceptionsDescriptorTest.java - test/javax/management/Introspector/MBeanDescriptionTest.java - test/javax/management/Introspector/ObjectNameTemplateTest.java - test/javax/management/Introspector/ParameterNameTest.java - test/javax/management/Introspector/ResourceInjectionTest.java - test/javax/management/MBeanServer/AttributeListMapTest.java - test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java - test/javax/management/MBeanServer/InstanceNotFoundExceptionTest.java - test/javax/management/MBeanServerFactory/NamedMBeanServerTest.java - test/javax/management/ObjectName/ValueOfTest.java - test/javax/management/context/ContextForwarderTest.java - test/javax/management/context/ContextTest.java - test/javax/management/context/LocaleAwareBroadcasterTest.java - test/javax/management/context/LocaleTest.java - test/javax/management/context/LocalizableTest.java - test/javax/management/context/RemoteContextTest.java - test/javax/management/context/localizable/MBeanDescriptions.properties - test/javax/management/context/localizable/MBeanDescriptions_fr.java - test/javax/management/context/localizable/Whatsit.java - test/javax/management/context/localizable/WhatsitMBean.java - test/javax/management/descriptor/DescriptorConstructorTest.java - test/javax/management/eventService/AddRemoveListenerTest.java - test/javax/management/eventService/CustomForwarderTest.java - test/javax/management/eventService/EventClientExecutorTest.java - test/javax/management/eventService/EventClientThreadTest.java - test/javax/management/eventService/EventDelegateSecurityTest.java - test/javax/management/eventService/EventManagerTest.java - test/javax/management/eventService/FetchingTest.java - test/javax/management/eventService/LeaseManagerDeadlockTest.java - test/javax/management/eventService/LeaseTest.java - test/javax/management/eventService/ListenerTest.java - test/javax/management/eventService/MyFetchingEventForwarder.java - test/javax/management/eventService/NotSerializableNotifTest.java - test/javax/management/eventService/PublishTest.java - test/javax/management/eventService/ReconnectableConnectorTest.java - test/javax/management/eventService/SharingThreadTest.java - test/javax/management/eventService/SubUnsubTest.java - test/javax/management/eventService/SubscribeTest.java - test/javax/management/eventService/UsingEventService.java - test/javax/management/interop/MBeanExceptionInteropTest.java - test/javax/management/modelmbean/DefaultDescriptorFieldTest.java - test/javax/management/monitor/InstantiateMonitorNotificationTest.java - test/javax/management/mxbean/CustomTypeTest.java - test/javax/management/mxbean/JMXServiceURLTest.java - test/javax/management/mxbean/customtypes/CustomLongMXBean.java - test/javax/management/mxbean/customtypes/CustomMXBean.java - test/javax/management/mxbean/customtypes/IntegerIsLongFactory.java - test/javax/management/mxbean/customtypes/IntegerIsStringFactory.java - test/javax/management/mxbean/customtypes/package-info.java - test/javax/management/namespace/DomainCreationTest.java - test/javax/management/namespace/EventWithNamespaceControlTest.java - test/javax/management/namespace/EventWithNamespaceTest.java - test/javax/management/namespace/ExportNamespaceTest.java - test/javax/management/namespace/JMXDomainTest.java - test/javax/management/namespace/JMXNamespaceSecurityTest.java - test/javax/management/namespace/JMXNamespaceTest.java - test/javax/management/namespace/JMXNamespaceViewTest.java - test/javax/management/namespace/JMXNamespacesTest.java - test/javax/management/namespace/JMXRemoteNamespaceTest.java - test/javax/management/namespace/JMXRemoteTargetNamespace.java - test/javax/management/namespace/LazyDomainTest.java - test/javax/management/namespace/LeadingSeparatorsTest.java - test/javax/management/namespace/MXBeanRefTest.java - test/javax/management/namespace/NamespaceController.java - test/javax/management/namespace/NamespaceControllerMBean.java - test/javax/management/namespace/NamespaceCreationTest.java - test/javax/management/namespace/NamespaceNotificationsTest.java - test/javax/management/namespace/NullDomainObjectNameTest.java - test/javax/management/namespace/NullObjectNameTest.java - test/javax/management/namespace/QueryNamesTest.java - test/javax/management/namespace/RemoveNotificationListenerTest.java - test/javax/management/namespace/RoutingServerProxyTest.java - test/javax/management/namespace/SerialParamProcessorTest.java - test/javax/management/namespace/SourceNamespaceTest.java - test/javax/management/namespace/VirtualMBeanNotifTest.java - test/javax/management/namespace/VirtualMBeanTest.java - test/javax/management/namespace/VirtualNamespaceQueryTest.java - test/javax/management/namespace/VirtualPropsTest.java - test/javax/management/namespace/Wombat.java - test/javax/management/namespace/WombatMBean.java - test/javax/management/namespace/namespace.policy - test/javax/management/notification/SupportClearTest.java - test/javax/management/openmbean/CompositeDataToMapTest.java - test/javax/management/openmbean/GenericMBeanExceptionTest.java - test/javax/management/query/QueryDottedAttrTest.java - test/javax/management/query/QueryNotifFilterTest.java - test/javax/management/query/QueryParseTest.java - test/javax/management/remote/mandatory/connectorServer/CloseConnectionTest.java - test/javax/management/remote/mandatory/connectorServer/ForwarderChainTest.java - test/javax/management/remote/mandatory/connectorServer/StandardForwardersTest.java - test/javax/management/remote/mandatory/version/JMXSpecVersionTest.java - test/javax/management/standardmbean/FindMethodTest.java - test/javax/management/standardmbean/RegistrationTest.java Changeset: e6b46fc235b0 Author: art Date: 2009-11-27 15:26 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e6b46fc235b0 4913324: Deadlock when using two event queues Reviewed-by: anthony, ant, dcherepanov ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/EventQueue/PushPopDeadlock2/PushPopTest.java Changeset: ca34cfff70a4 Author: anthony Date: 2009-11-27 16:07 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ca34cfff70a4 6402325: Swing toolbars vs native toolbars on Windows Summary: Introduce support for different window types: NORMAL, UTILITY, POPUP Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Window.java ! src/share/classes/javax/swing/Popup.java ! src/share/classes/sun/awt/SunToolkit.java ! src/solaris/classes/sun/awt/X11/InfoWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h + test/java/awt/Window/WindowType/WindowType.java Changeset: 6ffb01da29ce Author: anthony Date: 2009-12-02 14:51 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6ffb01da29ce 6901021: Security Warning Icon not getting displayed properly when frame loses focus Summary: Make sure the gray icon is selected when hiding the security warning Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 35d43184687d Author: ant Date: 2009-12-02 17:26 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/35d43184687d 6566375: PIT : test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html Reviewed-by: art, dcherepanov ! test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.java Changeset: 44f04b551d8f Author: ant Date: 2009-12-04 15:07 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/44f04b551d8f 6903354: deadlock involving Component.show & SunToolkit.getImageFromHash Reviewed-by: art, bae ! src/share/classes/sun/awt/SunToolkit.java Changeset: 4ff2fe6c2738 Author: yan Date: 2009-12-07 13:32 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4ff2fe6c2738 5099725: AWT doesn't seem to handle MappingNotify events under X11. 5036807: Pressing action keys "STOP/AGAIN/COMPOSE" generates keycode of F11/F12 keys. 4787377: VK_STOP key on Solaris generates wrong Key Code Summary: Added an event processing lumped with similar native code for similar bugs. Reviewed-by: art ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/XEmbedHelper.java ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XlibWrapper.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h ! src/solaris/native/sun/xawt/XlibWrapper.c Changeset: e4c0c37f6ad5 Author: dcherepanov Date: 2009-12-07 13:43 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4c0c37f6ad5 6823138: Need to replace ComponentAccessor with AWTAccessor Reviewed-by: art, anthony ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Window.java ! src/share/classes/sun/awt/AWTAccessor.java - src/share/classes/sun/awt/ComponentAccessor.java ! src/share/classes/sun/awt/GlobalCursorManager.java ! src/share/classes/sun/awt/SunToolkit.java - src/share/classes/sun/awt/WindowAccessor.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDialogPeer.java ! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedChildProxy.java ! src/solaris/classes/sun/awt/X11/XGlobalCursorManager.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/windows/classes/sun/awt/windows/WCanvasPeer.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java Changeset: 5ab49c5b9423 Author: dcherepanov Date: 2009-12-07 14:07 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5ab49c5b9423 Merge ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 384659657472 Author: ant Date: 2009-12-07 16:38 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/384659657472 6903890: SWT_AWT focus issues when a dialog is shown/disposed, on X11 Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java Changeset: 725bf9c81f86 Author: mchung Date: 2009-12-08 09:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/725bf9c81f86 6907568: java/awt/KeyboardFocusManager.java inproperly merged and lost a changeset Summary: Reapply fix for 6879044 in java.awt.KeyboardFocusManager Reviewed-by: dcherepanov, asaha ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: 624683dd9066 Author: anthony Date: 2009-12-09 14:02 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/624683dd9066 6900622: Security warning icon is not getting displayed properly for tooltip Summary: Pass a correct value for the hWndInsertAfter argument to the ::SetWindowPos() function Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h Changeset: e5ed96d088dd Author: dav Date: 2009-12-09 14:33 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e5ed96d088dd 6903893: Fix failed for CR 6834576: RemoveChild/ test fail with deadlock on rhel and sles Reviewed-by: dcherepanov, art ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: fb57c1bd637a Author: lana Date: 2009-12-10 09:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fb57c1bd637a Merge - src/share/classes/sun/awt/ComponentAccessor.java - src/share/classes/sun/awt/WindowAccessor.java Changeset: 7bcb1864f424 Author: rupashka Date: 2009-11-23 20:57 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7bcb1864f424 6823603: Generics: JList Reviewed-by: peterz, alexp Contributed-by: fbrunnerlist at gmx.ch ! src/share/classes/javax/swing/AbstractListModel.java ! src/share/classes/javax/swing/DefaultListCellRenderer.java ! src/share/classes/javax/swing/DefaultListModel.java ! src/share/classes/javax/swing/JList.java ! src/share/classes/javax/swing/ListCellRenderer.java ! src/share/classes/javax/swing/ListModel.java + test/javax/swing/JList/6823603/bug6823603.java Changeset: 496c2f20dfac Author: peterz Date: 2009-11-25 20:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/496c2f20dfac 6888156: With GTK Look and Feel Icons cannot be rendered in Jtable Cells Reviewed-by: rupashka ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/Test6888156.java Changeset: bb05c76b5c2f Author: lana Date: 2009-11-25 14:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bb05c76b5c2f Merge - make/tools/fontchecker/Makefile - make/tools/src/build/tools/fontchecker/FontCheckDummy.java - make/tools/src/build/tools/fontchecker/FontChecker.java - make/tools/src/build/tools/fontchecker/FontCheckerConstants.java - make/tools/src/build/tools/fontchecker/FontFileFilter.java - make/tools/src/build/tools/fontchecker/README.txt - src/share/classes/com/sun/jmx/event/DaemonThreadFactory.java - src/share/classes/com/sun/jmx/event/EventBuffer.java - src/share/classes/com/sun/jmx/event/EventClientFactory.java - src/share/classes/com/sun/jmx/event/EventConnection.java - src/share/classes/com/sun/jmx/event/EventParams.java - src/share/classes/com/sun/jmx/event/LeaseManager.java - src/share/classes/com/sun/jmx/event/LeaseRenewer.java - src/share/classes/com/sun/jmx/event/ReceiverBuffer.java - src/share/classes/com/sun/jmx/event/RepeatedSingletonJob.java - src/share/classes/com/sun/jmx/interceptor/DispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/DomainDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/MBeanServerInterceptorSupport.java - src/share/classes/com/sun/jmx/interceptor/NamespaceDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java - src/share/classes/com/sun/jmx/mbeanserver/MBeanInjector.java - src/share/classes/com/sun/jmx/mbeanserver/NotificationMBeanSupport.java - src/share/classes/com/sun/jmx/mbeanserver/NotifySupport.java - src/share/classes/com/sun/jmx/mbeanserver/PerThreadGroupPool.java - src/share/classes/com/sun/jmx/namespace/DomainInterceptor.java - src/share/classes/com/sun/jmx/namespace/HandlerInterceptor.java - src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java - src/share/classes/com/sun/jmx/namespace/ObjectNameRouter.java - src/share/classes/com/sun/jmx/namespace/RoutingConnectionProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingMBeanServerConnection.java - src/share/classes/com/sun/jmx/namespace/RoutingProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingServerProxy.java - src/share/classes/com/sun/jmx/namespace/package.html - src/share/classes/com/sun/jmx/namespace/serial/DefaultRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/IdentityProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/JMXNamespaceContext.java - src/share/classes/com/sun/jmx/namespace/serial/RewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/RoutingOnlyProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/SerialRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/package.html - src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java - src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java - src/share/classes/java/nio/ByteBufferAs-X-Buffer.java - src/share/classes/java/nio/Direct-X-Buffer-bin.java - src/share/classes/java/nio/Direct-X-Buffer.java - src/share/classes/java/nio/Heap-X-Buffer.java - src/share/classes/java/nio/X-Buffer-bin.java - src/share/classes/java/nio/X-Buffer.java - src/share/classes/java/nio/charset/Charset-X-Coder.java - src/share/classes/javax/management/ClientContext.java - src/share/classes/javax/management/Description.java - src/share/classes/javax/management/DescriptorFields.java - src/share/classes/javax/management/DynamicWrapperMBean.java - src/share/classes/javax/management/GenericMBeanException.java - src/share/classes/javax/management/Impact.java - src/share/classes/javax/management/MBean.java - src/share/classes/javax/management/ManagedAttribute.java - src/share/classes/javax/management/ManagedOperation.java - src/share/classes/javax/management/NotificationInfo.java - src/share/classes/javax/management/NotificationInfos.java - src/share/classes/javax/management/ObjectNameTemplate.java - src/share/classes/javax/management/QueryNotificationFilter.java - src/share/classes/javax/management/QueryParser.java - src/share/classes/javax/management/SendNotification.java - src/share/classes/javax/management/event/EventClient.java - src/share/classes/javax/management/event/EventClientDelegate.java - src/share/classes/javax/management/event/EventClientDelegateMBean.java - src/share/classes/javax/management/event/EventClientNotFoundException.java - src/share/classes/javax/management/event/EventConsumer.java - src/share/classes/javax/management/event/EventForwarder.java - src/share/classes/javax/management/event/EventReceiver.java - src/share/classes/javax/management/event/EventRelay.java - src/share/classes/javax/management/event/EventSubscriber.java - src/share/classes/javax/management/event/FetchingEventForwarder.java - src/share/classes/javax/management/event/FetchingEventRelay.java - src/share/classes/javax/management/event/ListenerInfo.java - src/share/classes/javax/management/event/NotificationManager.java - src/share/classes/javax/management/event/RMIPushEventForwarder.java - src/share/classes/javax/management/event/RMIPushEventRelay.java - src/share/classes/javax/management/event/RMIPushServer.java - src/share/classes/javax/management/event/package-info.java - src/share/classes/javax/management/namespace/JMXDomain.java - src/share/classes/javax/management/namespace/JMXNamespace.java - src/share/classes/javax/management/namespace/JMXNamespaceMBean.java - src/share/classes/javax/management/namespace/JMXNamespacePermission.java - src/share/classes/javax/management/namespace/JMXNamespaceView.java - src/share/classes/javax/management/namespace/JMXNamespaces.java - src/share/classes/javax/management/namespace/JMXRemoteNamespace.java - src/share/classes/javax/management/namespace/JMXRemoteNamespaceMBean.java - src/share/classes/javax/management/namespace/MBeanServerConnectionWrapper.java - src/share/classes/javax/management/namespace/MBeanServerSupport.java - src/share/classes/javax/management/namespace/VirtualEventManager.java - src/share/classes/javax/management/namespace/package-info.java - src/share/classes/javax/management/openmbean/MXBeanMapping.java - src/share/classes/javax/management/openmbean/MXBeanMappingClass.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactory.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactoryClass.java - src/share/classes/javax/management/remote/IdentityMBeanServerForwarder.java - src/share/classes/sun/misc/Version-template.java - src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java - src/share/classes/sun/net/www/protocol/http/NegotiateCallbackHandler.java - src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java - src/share/classes/sun/security/provider/certpath/LDAPCertStore.java - src/share/classes/sun/security/ssl/KerberosPreMasterSecret.java - src/share/classes/sun/tools/jconsole/Version-template.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthSequence.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c - test/java/nio/Buffer/Basic-X.java - test/java/nio/Buffer/CopyDirect-X-Memory.java - test/javax/management/Introspector/AnnotatedMBeanTest.java - test/javax/management/Introspector/AnnotatedNotificationInfoTest.java - test/javax/management/Introspector/ExceptionsDescriptorTest.java - test/javax/management/Introspector/MBeanDescriptionTest.java - test/javax/management/Introspector/ObjectNameTemplateTest.java - test/javax/management/Introspector/ParameterNameTest.java - test/javax/management/Introspector/ResourceInjectionTest.java - test/javax/management/MBeanServer/AttributeListMapTest.java - test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java - test/javax/management/MBeanServer/InstanceNotFoundExceptionTest.java - test/javax/management/MBeanServerFactory/NamedMBeanServerTest.java - test/javax/management/ObjectName/ValueOfTest.java - test/javax/management/context/ContextForwarderTest.java - test/javax/management/context/ContextTest.java - test/javax/management/context/LocaleAwareBroadcasterTest.java - test/javax/management/context/LocaleTest.java - test/javax/management/context/LocalizableTest.java - test/javax/management/context/RemoteContextTest.java - test/javax/management/context/localizable/MBeanDescriptions.properties - test/javax/management/context/localizable/MBeanDescriptions_fr.java - test/javax/management/context/localizable/Whatsit.java - test/javax/management/context/localizable/WhatsitMBean.java - test/javax/management/descriptor/DescriptorConstructorTest.java - test/javax/management/eventService/AddRemoveListenerTest.java - test/javax/management/eventService/CustomForwarderTest.java - test/javax/management/eventService/EventClientExecutorTest.java - test/javax/management/eventService/EventClientThreadTest.java - test/javax/management/eventService/EventDelegateSecurityTest.java - test/javax/management/eventService/EventManagerTest.java - test/javax/management/eventService/FetchingTest.java - test/javax/management/eventService/LeaseManagerDeadlockTest.java - test/javax/management/eventService/LeaseTest.java - test/javax/management/eventService/ListenerTest.java - test/javax/management/eventService/MyFetchingEventForwarder.java - test/javax/management/eventService/NotSerializableNotifTest.java - test/javax/management/eventService/PublishTest.java - test/javax/management/eventService/ReconnectableConnectorTest.java - test/javax/management/eventService/SharingThreadTest.java - test/javax/management/eventService/SubUnsubTest.java - test/javax/management/eventService/SubscribeTest.java - test/javax/management/eventService/UsingEventService.java - test/javax/management/interop/MBeanExceptionInteropTest.java - test/javax/management/modelmbean/DefaultDescriptorFieldTest.java - test/javax/management/monitor/InstantiateMonitorNotificationTest.java - test/javax/management/mxbean/CustomTypeTest.java - test/javax/management/mxbean/JMXServiceURLTest.java - test/javax/management/mxbean/customtypes/CustomLongMXBean.java - test/javax/management/mxbean/customtypes/CustomMXBean.java - test/javax/management/mxbean/customtypes/IntegerIsLongFactory.java - test/javax/management/mxbean/customtypes/IntegerIsStringFactory.java - test/javax/management/mxbean/customtypes/package-info.java - test/javax/management/namespace/DomainCreationTest.java - test/javax/management/namespace/EventWithNamespaceControlTest.java - test/javax/management/namespace/EventWithNamespaceTest.java - test/javax/management/namespace/ExportNamespaceTest.java - test/javax/management/namespace/JMXDomainTest.java - test/javax/management/namespace/JMXNamespaceSecurityTest.java - test/javax/management/namespace/JMXNamespaceTest.java - test/javax/management/namespace/JMXNamespaceViewTest.java - test/javax/management/namespace/JMXNamespacesTest.java - test/javax/management/namespace/JMXRemoteNamespaceTest.java - test/javax/management/namespace/JMXRemoteTargetNamespace.java - test/javax/management/namespace/LazyDomainTest.java - test/javax/management/namespace/LeadingSeparatorsTest.java - test/javax/management/namespace/MXBeanRefTest.java - test/javax/management/namespace/NamespaceController.java - test/javax/management/namespace/NamespaceControllerMBean.java - test/javax/management/namespace/NamespaceCreationTest.java - test/javax/management/namespace/NamespaceNotificationsTest.java - test/javax/management/namespace/NullDomainObjectNameTest.java - test/javax/management/namespace/NullObjectNameTest.java - test/javax/management/namespace/QueryNamesTest.java - test/javax/management/namespace/RemoveNotificationListenerTest.java - test/javax/management/namespace/RoutingServerProxyTest.java - test/javax/management/namespace/SerialParamProcessorTest.java - test/javax/management/namespace/SourceNamespaceTest.java - test/javax/management/namespace/VirtualMBeanNotifTest.java - test/javax/management/namespace/VirtualMBeanTest.java - test/javax/management/namespace/VirtualNamespaceQueryTest.java - test/javax/management/namespace/VirtualPropsTest.java - test/javax/management/namespace/Wombat.java - test/javax/management/namespace/WombatMBean.java - test/javax/management/namespace/namespace.policy - test/javax/management/notification/SupportClearTest.java - test/javax/management/openmbean/CompositeDataToMapTest.java - test/javax/management/openmbean/GenericMBeanExceptionTest.java - test/javax/management/query/QueryDottedAttrTest.java - test/javax/management/query/QueryNotifFilterTest.java - test/javax/management/query/QueryParseTest.java - test/javax/management/remote/mandatory/connectorServer/CloseConnectionTest.java - test/javax/management/remote/mandatory/connectorServer/ForwarderChainTest.java - test/javax/management/remote/mandatory/connectorServer/StandardForwardersTest.java - test/javax/management/remote/mandatory/version/JMXSpecVersionTest.java - test/javax/management/standardmbean/FindMethodTest.java - test/javax/management/standardmbean/RegistrationTest.java Changeset: d505826eabca Author: okutsu Date: 2009-11-27 16:20 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d505826eabca 6904997: (tz) Windows-only: tzmappings needs update for KB976098 Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: 76b887e939d4 Author: malenkov Date: 2009-11-27 15:24 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76b887e939d4 5102804: Memory leak in Introspector.getBeanInfo(Class) for custom BeanInfo: Class param Reviewed-by: peterz ! src/share/classes/com/sun/beans/WeakCache.java ! src/share/classes/java/beans/Introspector.java + test/java/beans/Introspector/Test5102804.java Changeset: 965ffc33d9a2 Author: amenkov Date: 2009-11-06 19:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/965ffc33d9a2 6744801: JCK api/javax_sound/interactive/RecordSoundTest.html#RecordSoundTest fails on Solaris10 x64 for -d64 Reviewed-by: dav ! make/javax/sound/Makefile Changeset: fe03ca4901a4 Author: amenkov Date: 2009-11-06 19:48 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe03ca4901a4 6887318: Incorrect constant used in DirectSound Mixer implementation Reviewed-by: uta ! src/windows/native/com/sun/media/sound/PLATFORM_API_WinOS_DirectSound.cpp Changeset: 1d7b87d34cf8 Author: kalli Date: 2009-11-27 17:13 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d7b87d34cf8 6833357: Improve time-stamp support in Gervill to reduce jitter Reviewed-by: amenkov + src/share/classes/com/sun/media/sound/MidiDeviceReceiver.java ! src/share/classes/com/sun/media/sound/SoftAudioBuffer.java ! src/share/classes/com/sun/media/sound/SoftChannel.java ! src/share/classes/com/sun/media/sound/SoftLimiter.java ! src/share/classes/com/sun/media/sound/SoftMainMixer.java ! src/share/classes/com/sun/media/sound/SoftReceiver.java ! src/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/share/classes/com/sun/media/sound/SoftVoice.java + test/javax/sound/midi/Gervill/SoftReceiver/GetMidiDevice.java + test/javax/sound/midi/Gervill/SoftSynthesizer/TestPreciseTimestampRendering.java Changeset: e7483b15706f Author: kalli Date: 2009-11-27 17:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e7483b15706f 6823449: Gervill: ArrayIndexOutOfBoundsException thrown when trying to play too may voices at same time Reviewed-by: amenkov ! src/share/classes/com/sun/media/sound/SoftChannel.java + test/javax/sound/midi/Gervill/SoftChannel/NoteOverFlowTest2.java Changeset: c5cefcfdac9a Author: amenkov Date: 2009-11-27 17:54 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c5cefcfdac9a 6832063: OpenJDK fails to open the default ALSA device when PulseAudio is enabled Reviewed-by: amenkov Contributed-by: omajid at redhat.com ! src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c Changeset: f20c9e76c3e0 Author: amenkov Date: 2009-11-27 18:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f20c9e76c3e0 Merge ! make/javax/sound/Makefile - make/tools/fontchecker/Makefile - make/tools/src/build/tools/fontchecker/FontCheckDummy.java - make/tools/src/build/tools/fontchecker/FontChecker.java - make/tools/src/build/tools/fontchecker/FontCheckerConstants.java - make/tools/src/build/tools/fontchecker/FontFileFilter.java - make/tools/src/build/tools/fontchecker/README.txt - src/share/classes/com/sun/jmx/event/DaemonThreadFactory.java - src/share/classes/com/sun/jmx/event/EventBuffer.java - src/share/classes/com/sun/jmx/event/EventClientFactory.java - src/share/classes/com/sun/jmx/event/EventConnection.java - src/share/classes/com/sun/jmx/event/EventParams.java - src/share/classes/com/sun/jmx/event/LeaseManager.java - src/share/classes/com/sun/jmx/event/LeaseRenewer.java - src/share/classes/com/sun/jmx/event/ReceiverBuffer.java - src/share/classes/com/sun/jmx/event/RepeatedSingletonJob.java - src/share/classes/com/sun/jmx/interceptor/DispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/DomainDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/MBeanServerInterceptorSupport.java - src/share/classes/com/sun/jmx/interceptor/NamespaceDispatchInterceptor.java - src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java - src/share/classes/com/sun/jmx/mbeanserver/MBeanInjector.java - src/share/classes/com/sun/jmx/mbeanserver/NotificationMBeanSupport.java - src/share/classes/com/sun/jmx/mbeanserver/NotifySupport.java - src/share/classes/com/sun/jmx/mbeanserver/PerThreadGroupPool.java - src/share/classes/com/sun/jmx/namespace/DomainInterceptor.java - src/share/classes/com/sun/jmx/namespace/HandlerInterceptor.java - src/share/classes/com/sun/jmx/namespace/NamespaceInterceptor.java - src/share/classes/com/sun/jmx/namespace/ObjectNameRouter.java - src/share/classes/com/sun/jmx/namespace/RoutingConnectionProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingMBeanServerConnection.java - src/share/classes/com/sun/jmx/namespace/RoutingProxy.java - src/share/classes/com/sun/jmx/namespace/RoutingServerProxy.java - src/share/classes/com/sun/jmx/namespace/package.html - src/share/classes/com/sun/jmx/namespace/serial/DefaultRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/IdentityProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/JMXNamespaceContext.java - src/share/classes/com/sun/jmx/namespace/serial/RewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/RoutingOnlyProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/SerialRewritingProcessor.java - src/share/classes/com/sun/jmx/namespace/serial/package.html - src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java - src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java - src/share/classes/java/nio/ByteBufferAs-X-Buffer.java - src/share/classes/java/nio/Direct-X-Buffer-bin.java - src/share/classes/java/nio/Direct-X-Buffer.java - src/share/classes/java/nio/Heap-X-Buffer.java - src/share/classes/java/nio/X-Buffer-bin.java - src/share/classes/java/nio/X-Buffer.java - src/share/classes/java/nio/charset/Charset-X-Coder.java - src/share/classes/javax/management/ClientContext.java - src/share/classes/javax/management/Description.java - src/share/classes/javax/management/DescriptorFields.java - src/share/classes/javax/management/DynamicWrapperMBean.java - src/share/classes/javax/management/GenericMBeanException.java - src/share/classes/javax/management/Impact.java - src/share/classes/javax/management/MBean.java - src/share/classes/javax/management/ManagedAttribute.java - src/share/classes/javax/management/ManagedOperation.java - src/share/classes/javax/management/NotificationInfo.java - src/share/classes/javax/management/NotificationInfos.java - src/share/classes/javax/management/ObjectNameTemplate.java - src/share/classes/javax/management/QueryNotificationFilter.java - src/share/classes/javax/management/QueryParser.java - src/share/classes/javax/management/SendNotification.java - src/share/classes/javax/management/event/EventClient.java - src/share/classes/javax/management/event/EventClientDelegate.java - src/share/classes/javax/management/event/EventClientDelegateMBean.java - src/share/classes/javax/management/event/EventClientNotFoundException.java - src/share/classes/javax/management/event/EventConsumer.java - src/share/classes/javax/management/event/EventForwarder.java - src/share/classes/javax/management/event/EventReceiver.java - src/share/classes/javax/management/event/EventRelay.java - src/share/classes/javax/management/event/EventSubscriber.java - src/share/classes/javax/management/event/FetchingEventForwarder.java - src/share/classes/javax/management/event/FetchingEventRelay.java - src/share/classes/javax/management/event/ListenerInfo.java - src/share/classes/javax/management/event/NotificationManager.java - src/share/classes/javax/management/event/RMIPushEventForwarder.java - src/share/classes/javax/management/event/RMIPushEventRelay.java - src/share/classes/javax/management/event/RMIPushServer.java - src/share/classes/javax/management/event/package-info.java - src/share/classes/javax/management/namespace/JMXDomain.java - src/share/classes/javax/management/namespace/JMXNamespace.java - src/share/classes/javax/management/namespace/JMXNamespaceMBean.java - src/share/classes/javax/management/namespace/JMXNamespacePermission.java - src/share/classes/javax/management/namespace/JMXNamespaceView.java - src/share/classes/javax/management/namespace/JMXNamespaces.java - src/share/classes/javax/management/namespace/JMXRemoteNamespace.java - src/share/classes/javax/management/namespace/JMXRemoteNamespaceMBean.java - src/share/classes/javax/management/namespace/MBeanServerConnectionWrapper.java - src/share/classes/javax/management/namespace/MBeanServerSupport.java - src/share/classes/javax/management/namespace/VirtualEventManager.java - src/share/classes/javax/management/namespace/package-info.java - src/share/classes/javax/management/openmbean/MXBeanMapping.java - src/share/classes/javax/management/openmbean/MXBeanMappingClass.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactory.java - src/share/classes/javax/management/openmbean/MXBeanMappingFactoryClass.java - src/share/classes/javax/management/remote/IdentityMBeanServerForwarder.java - src/share/classes/sun/misc/Version-template.java - src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java - src/share/classes/sun/net/www/protocol/http/NegotiateCallbackHandler.java - src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java - src/share/classes/sun/security/provider/certpath/LDAPCertStore.java - src/share/classes/sun/security/ssl/KerberosPreMasterSecret.java - src/share/classes/sun/tools/jconsole/Version-template.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthSequence.java - src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c - test/java/nio/Buffer/Basic-X.java - test/java/nio/Buffer/CopyDirect-X-Memory.java - test/javax/management/Introspector/AnnotatedMBeanTest.java - test/javax/management/Introspector/AnnotatedNotificationInfoTest.java - test/javax/management/Introspector/ExceptionsDescriptorTest.java - test/javax/management/Introspector/MBeanDescriptionTest.java - test/javax/management/Introspector/ObjectNameTemplateTest.java - test/javax/management/Introspector/ParameterNameTest.java - test/javax/management/Introspector/ResourceInjectionTest.java - test/javax/management/MBeanServer/AttributeListMapTest.java - test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java - test/javax/management/MBeanServer/InstanceNotFoundExceptionTest.java - test/javax/management/MBeanServerFactory/NamedMBeanServerTest.java - test/javax/management/ObjectName/ValueOfTest.java - test/javax/management/context/ContextForwarderTest.java - test/javax/management/context/ContextTest.java - test/javax/management/context/LocaleAwareBroadcasterTest.java - test/javax/management/context/LocaleTest.java - test/javax/management/context/LocalizableTest.java - test/javax/management/context/RemoteContextTest.java - test/javax/management/context/localizable/MBeanDescriptions.properties - test/javax/management/context/localizable/MBeanDescriptions_fr.java - test/javax/management/context/localizable/Whatsit.java - test/javax/management/context/localizable/WhatsitMBean.java - test/javax/management/descriptor/DescriptorConstructorTest.java - test/javax/management/eventService/AddRemoveListenerTest.java - test/javax/management/eventService/CustomForwarderTest.java - test/javax/management/eventService/EventClientExecutorTest.java - test/javax/management/eventService/EventClientThreadTest.java - test/javax/management/eventService/EventDelegateSecurityTest.java - test/javax/management/eventService/EventManagerTest.java - test/javax/management/eventService/FetchingTest.java - test/javax/management/eventService/LeaseManagerDeadlockTest.java - test/javax/management/eventService/LeaseTest.java - test/javax/management/eventService/ListenerTest.java - test/javax/management/eventService/MyFetchingEventForwarder.java - test/javax/management/eventService/NotSerializableNotifTest.java - test/javax/management/eventService/PublishTest.java - test/javax/management/eventService/ReconnectableConnectorTest.java - test/javax/management/eventService/SharingThreadTest.java - test/javax/management/eventService/SubUnsubTest.java - test/javax/management/eventService/SubscribeTest.java - test/javax/management/eventService/UsingEventService.java - test/javax/management/interop/MBeanExceptionInteropTest.java - test/javax/management/modelmbean/DefaultDescriptorFieldTest.java - test/javax/management/monitor/InstantiateMonitorNotificationTest.java - test/javax/management/mxbean/CustomTypeTest.java - test/javax/management/mxbean/JMXServiceURLTest.java - test/javax/management/mxbean/customtypes/CustomLongMXBean.java - test/javax/management/mxbean/customtypes/CustomMXBean.java - test/javax/management/mxbean/customtypes/IntegerIsLongFactory.java - test/javax/management/mxbean/customtypes/IntegerIsStringFactory.java - test/javax/management/mxbean/customtypes/package-info.java - test/javax/management/namespace/DomainCreationTest.java - test/javax/management/namespace/EventWithNamespaceControlTest.java - test/javax/management/namespace/EventWithNamespaceTest.java - test/javax/management/namespace/ExportNamespaceTest.java - test/javax/management/namespace/JMXDomainTest.java - test/javax/management/namespace/JMXNamespaceSecurityTest.java - test/javax/management/namespace/JMXNamespaceTest.java - test/javax/management/namespace/JMXNamespaceViewTest.java - test/javax/management/namespace/JMXNamespacesTest.java - test/javax/management/namespace/JMXRemoteNamespaceTest.java - test/javax/management/namespace/JMXRemoteTargetNamespace.java - test/javax/management/namespace/LazyDomainTest.java - test/javax/management/namespace/LeadingSeparatorsTest.java - test/javax/management/namespace/MXBeanRefTest.java - test/javax/management/namespace/NamespaceController.java - test/javax/management/namespace/NamespaceControllerMBean.java - test/javax/management/namespace/NamespaceCreationTest.java - test/javax/management/namespace/NamespaceNotificationsTest.java - test/javax/management/namespace/NullDomainObjectNameTest.java - test/javax/management/namespace/NullObjectNameTest.java - test/javax/management/namespace/QueryNamesTest.java - test/javax/management/namespace/RemoveNotificationListenerTest.java - test/javax/management/namespace/RoutingServerProxyTest.java - test/javax/management/namespace/SerialParamProcessorTest.java - test/javax/management/namespace/SourceNamespaceTest.java - test/javax/management/namespace/VirtualMBeanNotifTest.java - test/javax/management/namespace/VirtualMBeanTest.java - test/javax/management/namespace/VirtualNamespaceQueryTest.java - test/javax/management/namespace/VirtualPropsTest.java - test/javax/management/namespace/Wombat.java - test/javax/management/namespace/WombatMBean.java - test/javax/management/namespace/namespace.policy - test/javax/management/notification/SupportClearTest.java - test/javax/management/openmbean/CompositeDataToMapTest.java - test/javax/management/openmbean/GenericMBeanExceptionTest.java - test/javax/management/query/QueryDottedAttrTest.java - test/javax/management/query/QueryNotifFilterTest.java - test/javax/management/query/QueryParseTest.java - test/javax/management/remote/mandatory/connectorServer/CloseConnectionTest.java - test/javax/management/remote/mandatory/connectorServer/ForwarderChainTest.java - test/javax/management/remote/mandatory/connectorServer/StandardForwardersTest.java - test/javax/management/remote/mandatory/version/JMXSpecVersionTest.java - test/javax/management/standardmbean/FindMethodTest.java - test/javax/management/standardmbean/RegistrationTest.java Changeset: fd3f28151089 Author: amenkov Date: 2009-11-27 18:38 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd3f28151089 Merge Changeset: efab4331ec26 Author: malenkov Date: 2009-11-30 18:26 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/efab4331ec26 6905515: Test failed: java/beans/XMLEncoder/6329581/Test6329581.java Reviewed-by: peterz ! test/java/beans/XMLEncoder/6329581/Test6329581.java Changeset: 31fac6705b41 Author: malenkov Date: 2009-11-30 18:30 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31fac6705b41 6905516: Test failed: java/beans/EventHandler/Test6788531.java Reviewed-by: peterz ! test/java/beans/EventHandler/Test6788531.java Changeset: 931cfd3ba5b6 Author: malenkov Date: 2009-12-09 11:34 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/931cfd3ba5b6 4638075: DOC: Doc for java.beans.PropertyDescriptor.getPropertyType() is incorrect. Reviewed-by: gsm ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java Changeset: d72275039339 Author: malenkov Date: 2009-12-09 11:38 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d72275039339 6905574: DOC: Introspector's javadoc contains wrong statement Reviewed-by: gsm ! src/share/classes/java/beans/Introspector.java Changeset: f012e2c094ff Author: peterz Date: 2009-12-10 12:08 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f012e2c094ff 6827653: Make Synth UI classes public Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/gtk/GTKPainter.java ! src/share/classes/javax/swing/plaf/ComponentUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxEditor.java ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicLabelUI.java ! src/share/classes/javax/swing/plaf/basic/BasicListUI.java ! src/share/classes/javax/swing/plaf/basic/BasicMenuItemUI.java ! src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSliderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSpinnerUI.java ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTableHeaderUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTextUI.java ! src/share/classes/javax/swing/plaf/basic/BasicToolBarUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/plaf/basic/DefaultMenuLayout.java ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java ! src/share/classes/javax/swing/plaf/nimbus/package.html - src/share/classes/javax/swing/plaf/synth/DefaultMenuLayout.java ! src/share/classes/javax/swing/plaf/synth/SynthBorder.java ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthCheckBoxMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthCheckBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDefaultLookup.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopIconUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthFormattedTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameTitlePane.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthListUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java + src/share/classes/javax/swing/plaf/synth/SynthMenuLayout.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthOptionPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPainter.java ! src/share/classes/javax/swing/plaf/synth/SynthPanelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPasswordFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPopupMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthProgressBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRadioButtonMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRadioButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSeparatorUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthStyle.java ! src/share/classes/javax/swing/plaf/synth/SynthStyleFactory.java ! src/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableHeaderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToggleButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java + src/share/classes/javax/swing/plaf/synth/SynthUI.java ! src/share/classes/javax/swing/plaf/synth/SynthViewportUI.java - src/share/classes/sun/swing/plaf/synth/SynthUI.java Changeset: d2680a125e32 Author: lana Date: 2009-12-10 09:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d2680a125e32 Merge - src/share/classes/javax/swing/plaf/synth/DefaultMenuLayout.java - src/share/classes/sun/swing/plaf/synth/SynthUI.java Changeset: be6bc681579a Author: lana Date: 2009-12-16 00:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be6bc681579a Merge - src/share/classes/javax/swing/plaf/synth/DefaultMenuLayout.java - src/share/classes/sun/awt/ComponentAccessor.java - src/share/classes/sun/awt/WindowAccessor.java - src/share/classes/sun/swing/plaf/synth/SynthUI.java Changeset: 447726d0daff Author: ohair Date: 2009-12-16 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/447726d0daff 6909462: Fix nbproject/private references in .hgignore Summary: See bugzilla issue 100097 Reviewed-by: tbell Contributed-by: Jesse Glick ! .hgignore Changeset: 1143e498f813 Author: mikejwre Date: 2009-12-16 23:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1143e498f813 Merge Changeset: e4dcfb35ee68 Author: mikejwre Date: 2009-12-17 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4dcfb35ee68 Added tag jdk7-b78 for changeset 1143e498f813 ! .hgtags Changeset: 3b896fcc7806 Author: tbell Date: 2009-12-19 10:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3b896fcc7806 Merge From tim.bell at sun.com Sun Dec 20 19:08:06 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sun, 20 Dec 2009 19:08:06 +0000 Subject: hg: jdk7/tl/langtools: 6 new changesets Message-ID: <20091220190819.E8BCE428C4@hg.openjdk.java.net> Changeset: 45bd41dcb614 Author: mikejwre Date: 2009-12-03 12:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/45bd41dcb614 Added tag jdk7-b77 for changeset 0398ae15b90a ! .hgtags Changeset: ceb2857fce7d Author: tbell Date: 2009-12-08 09:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ceb2857fce7d Merge Changeset: 381399872958 Author: ohair Date: 2009-12-16 12:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/381399872958 6909462: Fix nbproject/private references in .hgignore Summary: See bugzilla issue 100097 Reviewed-by: tbell Contributed-by: Jesse Glick ! .hgignore Changeset: acc1e40a5874 Author: mikejwre Date: 2009-12-16 23:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/acc1e40a5874 Merge Changeset: 44022ba69c2f Author: mikejwre Date: 2009-12-17 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/44022ba69c2f Added tag jdk7-b78 for changeset acc1e40a5874 ! .hgtags Changeset: ac5b4c5644ce Author: tbell Date: 2009-12-19 10:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ac5b4c5644ce Merge - src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java From Joe.Darcy at Sun.COM Mon Dec 21 05:24:53 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Sun, 20 Dec 2009 21:24:53 -0800 Subject: Code review request for 6908541 "Bad resource management in java/math/BigInteger/BigIntegerTest.java" Message-ID: <4B2F06A5.3020508@sun.com> Hi Kelly. Can you verify the changes I've made to BigIntegerTest.java in my fix for 6908541 "Bad resource management in java/math/BigInteger/BigIntegerTest.java" http://cr.openjdk.java.net/~darcy/6908541.0/ get the test off the bad test list? Thanks, -Joe From Ulf.Zibis at gmx.de Mon Dec 21 15:43:01 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Mon, 21 Dec 2009 16:43:01 +0100 Subject: fastdebug binaries on Windows Vista ? Message-ID: <4B2F9785.3050004@gmx.de> I got following message in trying to install JDK7 fastdebug on Windows Vista. Any ideas, why this doesn't work ? Seems, that java installer has no write access on "C:\Program Files\Java\" tree, even from administrator login. -Ulf See attachment -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: OpenJDK - Cannot install jdk1.7.0_fastdebug on Vista.png Type: image/png Size: 70682 bytes Desc: not available URL: From ptisnovs at redhat.com Tue Dec 22 10:53:16 2009 From: ptisnovs at redhat.com (Pavel Tisnovsky) Date: Tue, 22 Dec 2009 11:53:16 +0100 Subject: Please review changes in regression test java/util/jar/JarFile/TurkCert.java In-Reply-To: <4B2B9870.6090206@sun.com> References: <4B2B6345.70905@redhat.com> <4B2B9870.6090206@sun.com> Message-ID: <4B30A51C.9020705@redhat.com> Hi Chris, Can I push TurkCert regression test changes mentioned below to tl? Till now I've received only one review (from you :-), probably because of Christmas holidays. Or should I wait for another review? Thanks Pavel Christopher Hegarty -Sun Microsystems Ireland wrote: > This change seems reasonable. > > -Chris. > > Pavel Tisnovsky wrote: >> Hi, >> >> please review changes in regression test >> java/util/jar/JarFile/TurkCert.java. >> >> Webrev is available at http://cr.openjdk.java.net/~ptisnovs/TurkCert/ >> >> We discussed this issue on jdk6-dev mailing list, concretely in this >> thread: >> http://mail.openjdk.java.net/pipermail/jdk6-dev/2009-December/thread.html#1056 >> >> >> Thanks in advance >> Pavel Tisnovsky >> Red Hat QA From Alan.Bateman at Sun.COM Tue Dec 22 14:22:52 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 22 Dec 2009 14:22:52 +0000 Subject: Please review changes in regression test java/util/jar/JarFile/TurkCert.java In-Reply-To: <4B30A51C.9020705@redhat.com> References: <4B2B6345.70905@redhat.com> <4B2B9870.6090206@sun.com> <4B30A51C.9020705@redhat.com> Message-ID: <4B30D63C.5050107@sun.com> Pavel Tisnovsky wrote: > Hi Chris, > > Can I push TurkCert regression test changes mentioned below to tl? > Till now I've received only one review (from you :-), probably because > of Christmas holidays. Or should I wait for another review? > > Thanks > Pavel Pavel - it looks good to me too. You only need one reviewer so you should be all set. -Alan. From Kelly.Ohair at Sun.COM Wed Dec 23 04:46:31 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Tue, 22 Dec 2009 20:46:31 -0800 Subject: Need reviewer - fixing tests to work with CYGWIN Message-ID: <4B31A0A7.3020001@sun.com> Need reviewer - fixing tests to work with CYGWIN No hurry on this. I think it's final, but need to run the tests a few times with both MKS and cygwin, and on all platforms to verify I haven't broken anything. 6910834: TEST: java/io/File/Basic.java fails on Windows CYGWIN environment 6910835: TESTS: 3 java/io run.sh tests fail when run on Windows XP CYGWIN 6911104: Tests do not work with CYGWIN: tools, sun/tools, and com/sun/tools 6911108: These tests do not work with CYGWIN: java/util 6911112: Tests do not work with CYGWIN: javax/imageio/, javax/script/, and sun/misc/ 6911113: These tests do not work with CYGWIN: java/nio 6911117: These tests do not work with CYGWIN: com/sun/jdi 6911129: These tests do not work with CYGWIN: java/lang 6911131: Test does not work with CYGWIN: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-tests/webrev/ -kto From joe.darcy at sun.com Wed Dec 23 05:48:42 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Wed, 23 Dec 2009 05:48:42 +0000 Subject: hg: jdk7/tl/jdk: 6908541: Bad resource management in java/math/BigInteger/BigIntegerTest.java Message-ID: <20091223054920.A8F5A42C89@hg.openjdk.java.net> Changeset: f7e4cda33734 Author: darcy Date: 2009-12-22 21:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f7e4cda33734 6908541: Bad resource management in java/math/BigInteger/BigIntegerTest.java Reviewed-by: alanb ! test/ProblemList.txt ! test/java/math/BigInteger/BigIntegerTest.java From Nicolay.Haustov at Sun.COM Wed Dec 23 10:27:37 2009 From: Nicolay.Haustov at Sun.COM (Nicolay Haustov) Date: Wed, 23 Dec 2009 13:27:37 +0300 Subject: Need reviewer - fixing tests to work with CYGWIN In-Reply-To: <4B31A0A7.3020001@sun.com> References: <4B31A0A7.3020001@sun.com> Message-ID: <4B31F099.7020605@sun.com> Kelly, The changes look fine. It would be great if you could take this opportunity to unify platform setup and other common tasks in shell tests. There is lots of duplicate code dealing with it in each test. It would be good if all of it was moved to common script. Then each test can import it and use necessary functions (see example below). It would also remove lots of code and make adding common setup or porting to new platform much easier if need arises. In addition, some tests use PS and some PATHSEP, same with FS and FILESEP. Some unification and guidelines are needed here. Note that there are already tests that attempt use common framework (e.g. see test/sun/tools/common/CommonSetup.sh, sun/jvmstat/testlibrary/utils.sh). Am I dreaming here? :) In common/common.sh: set_platform() { # Set platform specific variables OS=`uname -s` case "$OS" in SunOS|Linux) PS=":" FS="/" DIFF="diff" SANITIZE_STR="cat" ;; Windows* | CYGWIN* ) PS=";" FS="\\" DIFF="diff -w" SANITIZE_STR="sed -e 's/@\\r@@g'" ;; *) echo "Unrecognized system: $OS" exit 1; ;; esac } And then in test script . "$TESTSRC/../../common/common.sh" set_platform .... or $DIFF .... ... or CLASS_NAME=`"$JAVA" UnicodeTest " | $SANITIZE_STR` Thanks Kelly O'Hair wrote: > Need reviewer - fixing tests to work with CYGWIN > > No hurry on this. I think it's final, but need to run the tests > a few times with both MKS and cygwin, and on all platforms to verify > I haven't broken anything. > > 6910834: TEST: java/io/File/Basic.java fails on Windows CYGWIN environment > 6910835: TESTS: 3 java/io run.sh tests fail when run on Windows XP CYGWIN > 6911104: Tests do not work with CYGWIN: tools, sun/tools, and com/sun/tools > 6911108: These tests do not work with CYGWIN: java/util > 6911112: Tests do not work with CYGWIN: javax/imageio/, javax/script/, > and sun/misc/ > 6911113: These tests do not work with CYGWIN: java/nio > 6911117: These tests do not work with CYGWIN: com/sun/jdi > 6911129: These tests do not work with CYGWIN: java/lang > 6911131: Test does not work with CYGWIN: > sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh > > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-tests/webrev/ > > -kto From ptisnovs at redhat.com Wed Dec 23 10:33:49 2009 From: ptisnovs at redhat.com (ptisnovs at redhat.com) Date: Wed, 23 Dec 2009 10:33:49 +0000 Subject: hg: jdk7/tl/jdk: 6912628: test/java/util/jar/JarFile/TurkCert.java cannot be run in samevm mode Message-ID: <20091223103454.17EAE42CD8@hg.openjdk.java.net> Changeset: 94feb5bd31bd Author: ptisnovs Date: 2009-12-23 11:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94feb5bd31bd 6912628: test/java/util/jar/JarFile/TurkCert.java cannot be run in samevm mode Summary: Added tag to run this test in othervm Reviewed-by: chegar ! test/java/util/jar/JarFile/TurkCert.java From Kelly.Ohair at Sun.COM Wed Dec 23 18:03:17 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Wed, 23 Dec 2009 10:03:17 -0800 Subject: Need reviewer - fixing tests to work with CYGWIN In-Reply-To: <4B31F099.7020605@sun.com> References: <4B31A0A7.3020001@sun.com> <4B31F099.7020605@sun.com> Message-ID: <4B325B65.6040706@sun.com> Nicolay Haustov wrote: > Kelly, > > The changes look fine. Thanks. Unfortunately I need an openjdk name to put in the Changeset comment. > > It would be great if you could take this opportunity to unify platform > setup and other common tasks in shell tests. All that you say below is true, and unification and guidelines on variable names would be great. But trying to keep it that way is another story. I have tried to create the least disturbance to the style of these tests, micro surgery fixes for the time being. To spend 10X longer on the problem just doesn't make sense to me at this time, too many other eggs to crack. ;^) Also, I feel that some of these tests could probably be re-written in java and avoid the shell completely, but again, no time right now. I appreciate the review and observations. -kto > > There is lots of duplicate code dealing with it in each test. It would > be good if all of it was moved to common script. Then each test can > import it and use necessary functions (see example below). It would also > remove lots of code and make adding common setup or porting to new > platform much easier if need arises. > > In addition, some tests use PS and some PATHSEP, same with FS and > FILESEP. Some unification and guidelines are needed here. > > Note that there are already tests that attempt use common framework > (e.g. see test/sun/tools/common/CommonSetup.sh, > sun/jvmstat/testlibrary/utils.sh). > > Am I dreaming here? :) > > > In common/common.sh: > > set_platform() { > # Set platform specific variables > OS=`uname -s` > case "$OS" in > SunOS|Linux) > PS=":" > FS="/" > DIFF="diff" > SANITIZE_STR="cat" > ;; > Windows* | CYGWIN* ) > PS=";" > FS="\\" > DIFF="diff -w" > SANITIZE_STR="sed -e 's/@\\r@@g'" > ;; > *) > echo "Unrecognized system: $OS" > exit 1; > ;; > esac > } > > And then in test script > > . "$TESTSRC/../../common/common.sh" > > set_platform > > .... or > > $DIFF .... > > ... or > > CLASS_NAME=`"$JAVA" UnicodeTest " | $SANITIZE_STR` > > Thanks > > Kelly O'Hair wrote: >> Need reviewer - fixing tests to work with CYGWIN >> >> No hurry on this. I think it's final, but need to run the tests >> a few times with both MKS and cygwin, and on all platforms to verify >> I haven't broken anything. >> >> 6910834: TEST: java/io/File/Basic.java fails on Windows CYGWIN >> environment >> 6910835: TESTS: 3 java/io run.sh tests fail when run on Windows XP CYGWIN >> 6911104: Tests do not work with CYGWIN: tools, sun/tools, and >> com/sun/tools >> 6911108: These tests do not work with CYGWIN: java/util >> 6911112: Tests do not work with CYGWIN: javax/imageio/, javax/script/, >> and sun/misc/ >> 6911113: These tests do not work with CYGWIN: java/nio >> 6911117: These tests do not work with CYGWIN: com/sun/jdi >> 6911129: These tests do not work with CYGWIN: java/lang >> 6911131: Test does not work with CYGWIN: >> sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh >> >> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-tests/webrev/ >> >> -kto From ahughes at redhat.com Wed Dec 23 18:09:30 2009 From: ahughes at redhat.com (ahughes at redhat.com) Date: Wed, 23 Dec 2009 18:09:30 +0000 Subject: hg: jdk7/tl/jdk: 6912893: (build) make/java/nio/FILES_java.gmk doesn't list sun.nio.cs.Unicode Message-ID: <20091223180943.6496C42D58@hg.openjdk.java.net> Changeset: 4a062158d2c5 Author: andrew Date: 2009-12-23 17:17 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a062158d2c5 6912893: (build) make/java/nio/FILES_java.gmk doesn't list sun.nio.cs.Unicode Summary: Add missing Java source file Reviewed-by: alanb ! make/java/nio/FILES_java.gmk From Tim.Bell at Sun.COM Wed Dec 23 19:03:48 2009 From: Tim.Bell at Sun.COM (Tim Bell) Date: Wed, 23 Dec 2009 11:03:48 -0800 Subject: Need reviewer - fixing tests to work with CYGWIN In-Reply-To: <4B31A0A7.3020001@sun.com> References: <4B31A0A7.3020001@sun.com> Message-ID: <4B326994.8030104@sun.com> Hi Kelly- > Need reviewer - fixing tests to work with CYGWIN > > No hurry on this. I think it's final, but need to run the tests > a few times with both MKS and cygwin, and on all platforms to verify > I haven't broken anything. That's good. The changes look fine to me: > 6910834: TEST: java/io/File/Basic.java fails on Windows CYGWIN environment > 6910835: TESTS: 3 java/io run.sh tests fail when run on Windows XP CYGWIN > 6911104: Tests do not work with CYGWIN: tools, sun/tools, and com/sun/tools > 6911108: These tests do not work with CYGWIN: java/util > 6911112: Tests do not work with CYGWIN: javax/imageio/, javax/script/, and sun/misc/ > 6911113: These tests do not work with CYGWIN: java/nio > 6911117: These tests do not work with CYGWIN: com/sun/jdi > 6911129: These tests do not work with CYGWIN: java/lang > 6911131: Test does not work with CYGWIN: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh > > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-tests/webrev/ Tim From martinrb at google.com Thu Dec 24 00:04:12 2009 From: martinrb at google.com (martinrb at google.com) Date: Thu, 24 Dec 2009 00:04:12 +0000 Subject: hg: jdk7/tl/jdk: 6908348: java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java get OOME for unbounded queues Message-ID: <20091224000429.F211442DB8@hg.openjdk.java.net> Changeset: 49bc2b443eca Author: dl Date: 2009-12-23 15:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/49bc2b443eca 6908348: java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java get OOME for unbounded queues Reviewed-by: martin, dholmes ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java From weijun.wang at sun.com Thu Dec 24 05:58:03 2009 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Thu, 24 Dec 2009 05:58:03 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20091224055828.6182342E1B@hg.openjdk.java.net> Changeset: 6a80c535f02e Author: weijun Date: 2009-12-24 13:56 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a80c535f02e 6843127: krb5 should not try to access unavailable kdc too often Reviewed-by: valeriep, mullan ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KrbKdcReq.java ! src/share/lib/security/java.security + test/sun/security/krb5/auto/BadKdc.java + test/sun/security/krb5/auto/BadKdc1.java + test/sun/security/krb5/auto/BadKdc2.java + test/sun/security/krb5/auto/BadKdc3.java + test/sun/security/krb5/auto/BadKdc4.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/OneKDC.java Changeset: 91c3cabb3d32 Author: weijun Date: 2009-12-24 13:56 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/91c3cabb3d32 6907425: JCK Kerberos tests fail since b77 Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/EncryptionKey.java ! test/sun/security/krb5/auto/KDC.java ! test/sun/security/krb5/auto/MoreKvno.java From Alan.Bateman at Sun.COM Thu Dec 24 21:03:45 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 24 Dec 2009 21:03:45 +0000 Subject: Need reviewer - fixing tests to work with CYGWIN In-Reply-To: <4B31A0A7.3020001@sun.com> References: <4B31A0A7.3020001@sun.com> Message-ID: <4B33D731.3010809@sun.com> Kelly O'Hair wrote: > > Need reviewer - fixing tests to work with CYGWIN > > No hurry on this. I think it's final, but need to run the tests > a few times with both MKS and cygwin, and on all platforms to verify > I haven't broken anything. > > 6910834: TEST: java/io/File/Basic.java fails on Windows CYGWIN > environment > 6910835: TESTS: 3 java/io run.sh tests fail when run on Windows XP CYGWIN > 6911104: Tests do not work with CYGWIN: tools, sun/tools, and > com/sun/tools > 6911108: These tests do not work with CYGWIN: java/util > 6911112: Tests do not work with CYGWIN: javax/imageio/, javax/script/, > and sun/misc/ > 6911113: These tests do not work with CYGWIN: java/nio > 6911117: These tests do not work with CYGWIN: com/sun/jdi > 6911129: These tests do not work with CYGWIN: java/lang > 6911131: Test does not work with CYGWIN: > sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.sh > > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-tests/webrev/ > > -kto > > Looks good to me too, -Alan. From i30817 at gmail.com Sun Dec 27 01:19:12 2009 From: i30817 at gmail.com (Paulo Levi) Date: Sun, 27 Dec 2009 01:19:12 +0000 Subject: Is JSR308 Type Annotations and the Checker Framework going to be used anywhere in the jdk? Message-ID: <212322090912261719v44e85e46x561fbc1f2d6ceb1d@mail.gmail.com> This would be useful if it was used in some places where passing a null is illegal (instead of manually checking inside the method). On one hand, code that would be annotated thus would already specify that null values are illegal , and throw a exception if passed them. On the other hand the programmer that uses that code correctly nowadays structures is code so that the variable can't be null. But the checker framework can't know that right? So marking code that way would percolate up like a domino chain (making transition a nightmare). So i guess that answers the case of the existing code. Would sun consider to make any new code use those annotations ? -------------- next part -------------- An HTML attachment was scrubbed... URL: