Code review request to fix more javadoc build warnings, 6909563: Javadoc build warnings in rmi, security, management

Sean Mullan Sean.Mullan at Sun.COM
Fri Dec 11 14:22:17 UTC 2009


The security fix looks fine.

--Sean

Joseph D. Darcy wrote:
> Hello.
> 
> Another round of javadoc build warnings fixes for review; this time 
> mostly in rmi, but one in security and another in management.
> 
> Patch below; webrev at
> http://cr.openjdk.java.net/~darcy/6909563.0/
> 
> -Joe
> 
> --- 
> old/src/share/classes/java/lang/management/PlatformManagedObject.java    
> 2009-12-10 21:30:19.000000000 -0800
> +++ 
> new/src/share/classes/java/lang/management/PlatformManagedObject.java    
> 2009-12-10 21:30:19.000000000 -0800
> @@ -32,7 +32,7 @@
>  * for monitoring and managing a component in the Java platform.
>  * Each platform managed object has a unique
>  * <a href="ManagementFactory.html#MXBean">object name</a>
> - * for the {@linkplain ManagementFactory.getPlatformMBeanServer
> + * for the {@linkplain ManagementFactory#getPlatformMBeanServer
>  * platform MBeanServer} access.
>  * All platform MXBeans will implement this interface.
>  *
> --- old/src/share/classes/java/rmi/activation/Activatable.java    
> 2009-12-10 21:30:20.000000000 -0800
> +++ new/src/share/classes/java/rmi/activation/Activatable.java    
> 2009-12-10 21:30:20.000000000 -0800
> @@ -73,7 +73,7 @@
>      * can be handled properly.
>      *
>      * <p>This method invokes the {@link
> -     * exportObject(Remote,String,MarshalledObject,boolean,port)
> +     * #exportObject(Remote,String,MarshalledObject,boolean,int)
>      * exportObject} method with this object, and the specified location,
>      * data, restart mode, and port.  Subsequent calls to {@link #getID}
>      * will return the activation identifier returned from the call to
> @@ -120,7 +120,7 @@
>      * can be handled properly.
>      *
>      * <p>This method invokes the {@link
> -     * 
> exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) 
> 
> +     * 
> #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) 
> 
>      * exportObject} method with this object, and the specified location,
>      * data, restart mode, port, and client and server socket factories.
>      * Subsequent calls to {@link #getID} will return the activation
> @@ -312,7 +312,7 @@
>      * separately, so that exceptions can be handled properly.
>      *
>      * <p>This method invokes the {@link
> -     * 
> exportObject(Remote,String,MarshalledObject,boolean,port,RMIClientSocketFactory,RMIServerSocketFactory) 
> 
> +     * 
> #exportObject(Remote,String,MarshalledObject,boolean,int,RMIClientSocketFactory,RMIServerSocketFactory) 
> 
>      * exportObject} method with the specified object, location, data,
>      * restart mode, and port, and <code>null</code> for both client and
>      * server socket factories, and then returns the resulting activation
> --- old/src/share/classes/java/rmi/registry/LocateRegistry.java    
> 2009-12-10 21:30:21.000000000 -0800
> +++ new/src/share/classes/java/rmi/registry/LocateRegistry.java    
> 2009-12-10 21:30:21.000000000 -0800
> @@ -187,7 +187,7 @@
>      * host that accepts requests on the specified <code>port</code>.
>      *
>      * <p>The <code>Registry</code> instance is exported as if the static
> -     * {@link UnicastRemoteObject.exportObject(Remote,int)
> +     * {@link UnicastRemoteObject#exportObject(Remote,int)
>      * UnicastRemoteObject.exportObject} method is invoked, passing the
>      * <code>Registry</code> instance and the specified 
> <code>port</code> as
>      * arguments, except that the <code>Registry</code> instance is
> @@ -213,7 +213,7 @@
>      *
>      * <p>The <code>Registry</code> instance is exported as if
>      * the static {@link
> -     * 
> UnicastRemoteObject.exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) 
> 
> +     * 
> UnicastRemoteObject#exportObject(Remote,int,RMIClientSocketFactory,RMIServerSocketFactory) 
> 
>      * UnicastRemoteObject.exportObject} method is invoked, passing the
>      * <code>Registry</code> instance, the specified <code>port</code>, the
>      * specified <code>RMIClientSocketFactory</code>, and the specified
> --- 
> old/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java    
> 2009-12-10 21:30:22.000000000 -0800
> +++ 
> new/src/share/classes/java/rmi/server/RemoteObjectInvocationHandler.java    
> 2009-12-10 21:30:22.000000000 -0800
> @@ -138,7 +138,6 @@
>      * instance
>      * @throws  Throwable the exception to throw from the method invocation
>      * on the proxy instance
> -     * @see
>      **/
>     public Object invoke(Object proxy, Method method, Object[] args)
>         throws Throwable
> --- 
> old/src/share/classes/java/security/cert/CertPathValidatorException.java    
> 2009-12-10 21:30:23.000000000 -0800
> +++ 
> new/src/share/classes/java/security/cert/CertPathValidatorException.java    
> 2009-12-10 21:30:22.000000000 -0800
> @@ -216,7 +216,7 @@
>     /**
>      * Returns the reason that the validation failed. The reason is
>      * associated with the index of the certificate returned by
> -     * {@link getIndex}.
> +     * {@link #getIndex}.
>      *
>      * @return the reason that the validation failed, or
>      *    <code>BasicReason.UNSPECIFIED</code> if a reason has not been
> 




More information about the core-libs-dev mailing list