Code review request for 6908131 Pure Java implementations of StrictMath.floor(double) &StrictMath.ceil(double)

Joseph D. Darcy Joe.Darcy at Sun.COM
Mon Dec 14 22:03:17 UTC 2009


Alan Bateman wrote:
> Joseph D. Darcy wrote:
>> Hello.
>>
>> Please review my fix for
>>
>> 6908131 Pure Java implementations of StrictMath.floor(double) 
>> &StrictMath.ceil(double)
>> http://cr.openjdk.java.net/~darcy/6908131.0/
>>
>> I've asked Doug Priest, one of Sun's numerical experts, to review the 
>> floor/ceil algorithm and testing.  I've incorporated his feedback and 
>> he has approved those aspects of the changes.  The JDK integration 
>> has not yet been looked over.
>>
>> Thanks,
>>
>> -Joe
> For the JDK integration you'll need to remove the symbols from 
> make/java/java/mapfile-vers. Also, there are probably references in 
> the reorder-* files that can be removed (although they aren't 
> maintained now).
>

Webrev so updated:
http://cr.openjdk.java.net/~darcy/6908131.1

Thanks,

-Joe




More information about the core-libs-dev mailing list