From Ulf.Zibis at gmx.de Sun Jan 4 01:19:02 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sun, 04 Jan 2009 02:19:02 +0100 Subject: Speed-up FastCharsetProvider Message-ID: <49600E86.7040800@gmx.de> Hi Sherman, hi Martin, I took a closer look to sun.io.cs.FastCharsetProvider, and found out, that there are some possibilities to enhance it. I have filed a bug. See Review ID: 1425597 and: https://java-nio-charset-enhanced.dev.java.net/source/browse/java-nio-charset-enhanced/trunk/src/sun/nio/cs/FastCharsetProvider.java?diff_format=s&rev=551&view=markup -Ulf From gbenson at redhat.com Tue Jan 6 16:38:06 2009 From: gbenson at redhat.com (Gary Benson) Date: Tue, 6 Jan 2009 16:38:06 +0000 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> Message-ID: <20090106163806.GF3238@redhat.com> Hi Martin, I like your method of avoiding the overflow, it's a nice idea. I've attached an updated version of my original patch, with that, and with an expanded comment too, to make sure the fix doesn't get reverted later on in the interests of readability or whatever. Can I ask that you file a seperate bug for your other changes? They're not specifically related to 6788196, and I feel it confuses the issue somewhat having a bunch of unrelated changes in the patch. Cheers, Gary Martin Buchholz wrote: > I have sympathy for Gary's reluctance to use jlong, > even though we all know that here the performance of 64-bit > operands doesn't matter. > > I propose an alternate patch, which avoids the overflow problem > by simply rearranging the operands, and adds other pedantic > improvements. > > I believe it may not be 100% portable to replace > (len < 0) || (off < 0) > with > ((len | off) < 0) > I'll leave that optimization to the compiler. > > diff --git a/src/share/native/java/io/io_util.c > b/src/share/native/java/io/io_util.c > --- a/src/share/native/java/io/io_util.c > +++ b/src/share/native/java/io/io_util.c > @@ -25,6 +25,7 @@ > > #include > #include > +#include > > #include "jni.h" > #include "jni_util.h" > @@ -34,9 +35,9 @@ > > /* IO helper functions */ > > -int > +jint > readSingle(JNIEnv *env, jobject this, jfieldID fid) { > - int nread; > + jint nread; > char ret; > FD fd = GET_FD(this, fid); > if (fd == -1) { > @@ -59,13 +60,14 @@ readSingle(JNIEnv *env, jobject this, jf > #define BUF_SIZE 8192 > > > -int > +jint > readBytes(JNIEnv *env, jobject this, jbyteArray bytes, > jint off, jint len, jfieldID fid) > { > - int nread, datalen; > + jint nread; > + jsize datalen; > char stackBuf[BUF_SIZE]; > - char *buf = 0; > + char *buf = NULL; > FD fd; > > if (IS_NULL(bytes)) { > @@ -74,8 +76,10 @@ readBytes(JNIEnv *env, jobject this, jby > } > datalen = (*env)->GetArrayLength(env, bytes); > > - if ((off < 0) || (off > datalen) || > - (len < 0) || ((off + len) > datalen) || ((off + len) < 0)) { > + if ((off < 0) || > + (len < 0) || > + /* Avoid undefined signed integer overflow. */ > + (datalen - off < len)) { > JNU_ThrowByName(env, "java/lang/IndexOutOfBoundsException", 0); > return -1; > } > @@ -84,7 +88,7 @@ readBytes(JNIEnv *env, jobject this, jby > return 0; > } else if (len > BUF_SIZE) { > buf = malloc(len); > - if (buf == 0) { > + if (buf == NULL) { > JNU_ThrowOutOfMemoryError(env, 0); > return 0; > } > @@ -118,7 +122,7 @@ void > void > writeSingle(JNIEnv *env, jobject this, jint byte, jfieldID fid) { > char c = byte; > - int n; > + jint n; > FD fd = GET_FD(this, fid); > if (fd == -1) { > JNU_ThrowIOException(env, "Stream Closed"); > @@ -134,11 +138,12 @@ writeSingle(JNIEnv *env, jobject this, j > > void > writeBytes(JNIEnv *env, jobject this, jbyteArray bytes, > - jint off, jint len, jfieldID fid) > + jint off, jint len, jfieldID fid) > { > - int n, datalen; > + jint n; > + jsize datalen; > char stackBuf[BUF_SIZE]; > - char *buf = 0; > + char *buf = NULL; > FD fd; > > if (IS_NULL(bytes)) { > @@ -147,8 +152,10 @@ writeBytes(JNIEnv *env, jobject this, jb > } > datalen = (*env)->GetArrayLength(env, bytes); > > - if ((off < 0) || (off > datalen) || > - (len < 0) || ((off + len) > datalen) || ((off + len) < 0)) { > + if ((off < 0) || > + (len < 0) || > + /* Avoid undefined signed integer overflow. */ > + (datalen - off < len)) { > JNU_ThrowByName(env, "java/lang/IndexOutOfBoundsException", 0); > return; > } > @@ -157,7 +164,7 @@ writeBytes(JNIEnv *env, jobject this, jb > return; > } else if (len > BUF_SIZE) { > buf = malloc(len); > - if (buf == 0) { > + if (buf == NULL) { > JNU_ThrowOutOfMemoryError(env, 0); > return; > } > @@ -196,19 +203,19 @@ throwFileNotFoundException(JNIEnv *env, > throwFileNotFoundException(JNIEnv *env, jstring path) > { > char buf[256]; > - int n; > + jint n; > jobject x; > jstring why = NULL; > > n = JVM_GetLastErrorString(buf, sizeof(buf)); > if (n > 0) { > - why = JNU_NewStringPlatform(env, buf); > + why = JNU_NewStringPlatform(env, buf); > } > x = JNU_NewObjectByName(env, > "java/io/FileNotFoundException", > "(Ljava/lang/String;Ljava/lang/String;)V", > path, why); > if (x != NULL) { > - (*env)->Throw(env, x); > + (*env)->Throw(env, x); > } > } > diff --git a/src/share/native/java/io/io_util.h > b/src/share/native/java/io/io_util.h > --- a/src/share/native/java/io/io_util.h > +++ b/src/share/native/java/io/io_util.h > @@ -38,9 +38,9 @@ extern jfieldID IO_handle_fdID; > * IO helper functions > */ > > -int readSingle(JNIEnv *env, jobject this, jfieldID fid); > -int readBytes(JNIEnv *env, jobject this, jbyteArray bytes, jint off, > - jint len, jfieldID fid); > +jint readSingle(JNIEnv *env, jobject this, jfieldID fid); > +jint readBytes(JNIEnv *env, jobject this, jbyteArray bytes, jint off, > + jint len, jfieldID fid); > void writeSingle(JNIEnv *env, jobject this, jint byte, jfieldID fid); > void writeBytes(JNIEnv *env, jobject this, jbyteArray bytes, jint off, > jint len, jfieldID fid); > > Martin -------------- next part -------------- diff -r 201a75db9b35 openjdk/jdk/src/share/native/java/io/io_util.c --- openjdk/jdk/src/share/native/java/io/io_util.c Mon Dec 22 12:32:44 2008 +0000 +++ openjdk/jdk/src/share/native/java/io/io_util.c Mon Dec 22 12:48:49 2008 +0000 @@ -25,6 +25,7 @@ #include #include +#include #include "jni.h" #include "jni_util.h" @@ -73,9 +74,13 @@ return -1; } datalen = (*env)->GetArrayLength(env, bytes); + assert(datalen >= 0); - if ((off < 0) || (off > datalen) || - (len < 0) || ((off + len) > datalen) || ((off + len) < 0)) { + // If you modify this check be very careful to avoid signed + // integer overflow, the result of which is undefined in C. + // For more details see bug 6788196, and the thread starting at + // http://mail.openjdk.java.net/pipermail/core-libs-dev/2008-December/000955.html + if ((off < 0) || (len < 0) || (datalen - off < len)) { JNU_ThrowByName(env, "java/lang/IndexOutOfBoundsException", 0); return -1; } @@ -146,9 +151,13 @@ return; } datalen = (*env)->GetArrayLength(env, bytes); + assert(datalen >= 0); - if ((off < 0) || (off > datalen) || - (len < 0) || ((off + len) > datalen) || ((off + len) < 0)) { + // If you modify this check be very careful to avoid signed + // integer overflow, the result of which is undefined in C. + // For more details see bug 6788196, and the thread starting at + // http://mail.openjdk.java.net/pipermail/core-libs-dev/2008-December/000955.html + if ((off < 0) || (len < 0) || (datalen - off < len)) { JNU_ThrowByName(env, "java/lang/IndexOutOfBoundsException", 0); return; } From aph at redhat.com Tue Jan 6 16:44:28 2009 From: aph at redhat.com (Andrew Haley) Date: Tue, 06 Jan 2009 16:44:28 +0000 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <20090106163806.GF3238@redhat.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> <20090106163806.GF3238@redhat.com> Message-ID: <49638A6C.6070908@redhat.com> Gary Benson wrote: > Hi Martin, > > I like your method of avoiding the overflow, it's a nice idea. > I've attached an updated version of my original patch, with that, > and with an expanded comment too, to make sure the fix doesn't > get reverted later on in the interests of readability or whatever. > > Can I ask that you file a seperate bug for your other changes? > They're not specifically related to 6788196, and I feel it > confuses the issue somewhat having a bunch of unrelated changes > in the patch. > Martin Buchholz wrote: There are some indentation SNAFUs here. Maybe due to tab width set to 4? >> @@ -196,19 +203,19 @@ throwFileNotFoundException(JNIEnv *env, >> throwFileNotFoundException(JNIEnv *env, jstring path) >> { >> char buf[256]; >> - int n; >> + jint n; >> jobject x; >> jstring why = NULL; >> >> n = JVM_GetLastErrorString(buf, sizeof(buf)); >> if (n > 0) { >> - why = JNU_NewStringPlatform(env, buf); >> + why = JNU_NewStringPlatform(env, buf); ^ here >> } >> x = JNU_NewObjectByName(env, >> "java/io/FileNotFoundException", >> "(Ljava/lang/String;Ljava/lang/String;)V", >> path, why); >> if (x != NULL) { >> - (*env)->Throw(env, x); >> + (*env)->Throw(env, x); ^ here >> } >> } From Alan.Bateman at Sun.COM Tue Jan 6 17:01:40 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Tue, 06 Jan 2009 17:01:40 +0000 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <20090106163806.GF3238@redhat.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> <20090106163806.GF3238@redhat.com> Message-ID: <49638E74.9070605@sun.com> Gary Benson wrote: > Hi Martin, > > I like your method of avoiding the overflow, it's a nice idea. > I agree, and also better matches the method specification. > I've attached an updated version of my original patch, with that, > and with an expanded comment too, to make sure the fix doesn't > get reverted later on in the interests of readability or whatever. > I checked the pre-OpenJDK history and this bounds check has been so since 1.2 (10+ years old). It's kinda surprising this hasn't been noticed with other ports. Did you run into this with an existing test (JCK or regression/unit)? Ideally we should have more tests to catch these issues (one existing test that we could update is java/io/readBytes/ReadBytesBounds.java). > Can I ask that you file a seperate bug for your other changes? > They're not specifically related to 6788196, and I feel it > confuses the issue somewhat having a bunch of unrelated changes > in the patch. > Speaking of, is there a related HotSpot issue that lead to the assert datalen >= 0? It's likely many things would break if GetArrayLength return a negative value so just curious. -Alan. From gbenson at redhat.com Tue Jan 6 18:10:55 2009 From: gbenson at redhat.com (Gary Benson) Date: Tue, 6 Jan 2009 18:10:55 +0000 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <49638E74.9070605@sun.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> <20090106163806.GF3238@redhat.com> <49638E74.9070605@sun.com> Message-ID: <20090106181055.GG3238@redhat.com> Alan Bateman wrote: > I checked the pre-OpenJDK history and this bounds check has been so > since 1.2 (10+ years old). It's kinda surprising this hasn't been > noticed with other ports. Did you run into this with an existing > test (JCK or regression/unit)? Ideally we should have more tests to > catch these issues (one existing test that we could update is > java/io/readBytes/ReadBytesBounds.java). The JCK caught it. There's a testcase attached to my original mail too, but it could be extended perhaps to test more values. > Speaking of, is there a related HotSpot issue that lead to the > assert datalen >= 0? It's likely many things would break if > GetArrayLength return a negative value so just curious. If datalen is negative then the bounds check can overflow: all three values need to be positive to avoid this. I've not come across a situation where datalen was negative, but it didn't feel right to check the other two without also checking datalen. Cheers, Gary -- http://gbenson.net/ From gbenson at redhat.com Tue Jan 6 18:11:56 2009 From: gbenson at redhat.com (Gary Benson) Date: Tue, 6 Jan 2009 18:11:56 +0000 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <49638A6C.6070908@redhat.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> <20090106163806.GF3238@redhat.com> <49638A6C.6070908@redhat.com> Message-ID: <20090106181156.GH3238@redhat.com> Andrew Haley wrote: > There are some indentation SNAFUs here. Maybe due to tab width set > to 4? That's Martin's patch, which got inlined in the reply. My patch is the attachment. Cheers, Gary -- http://gbenson.net/ From aph at redhat.com Tue Jan 6 18:18:19 2009 From: aph at redhat.com (Andrew Haley) Date: Tue, 06 Jan 2009 18:18:19 +0000 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <20090106181156.GH3238@redhat.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> <20090106163806.GF3238@redhat.com> <49638A6C.6070908@redhat.com> <20090106181156.GH3238@redhat.com> Message-ID: <4963A06B.3000102@redhat.com> Gary Benson wrote: > Andrew Haley wrote: >> There are some indentation SNAFUs here. Maybe due to tab width set >> to 4? > > That's Martin's patch, which got inlined in the reply. My patch is > the attachment. Ahh, the evils of top-posting. Just Say No... :-) Andrew. From martinrb at google.com Wed Jan 7 01:02:38 2009 From: martinrb at google.com (Martin Buchholz) Date: Tue, 6 Jan 2009 17:02:38 -0800 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <20090106163806.GF3238@redhat.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> <20090106163806.GF3238@redhat.com> Message-ID: <1ccfd1c10901061702t1707264cp726f4f21f6537df6@mail.gmail.com> Hi Gary, I will be your submitter for this fix. I don't think it's worth adding checks for array length being non-negative. We can add tests to the existing test case jdk/test/java/io/readBytes/ReadBytesBounds.java I am providing a patch which has a revised patch and test. Please forgive me for having refactored everything. I created an outOfBounds function, suitable for copying and pasting. I propose to commit this, if Gary and Alan give me thumbs up. The patch to the test is hard to read. public class ReadBytesBounds { static final FileInputStream fis; static final RandomAccessFile raf; static final byte[] b = new byte[32]; static { try { String dir = System.getProperty("test.src", "."); File testFile = new File(dir, "input.txt"); fis = new FileInputStream(testFile); raf = new RandomAccessFile(testFile , "r"); } catch (Throwable t) { throw new Error(t); } } public static void main(String argv[]) throws Throwable { byte b[] = new byte[32]; testRead(-1, -1, false); testRead(-1, 0, false); testRead( 0, -1, false); testRead( 0, 33, false); testRead(33, 0, false); testRead(33, 4, false); testRead( 0, 32, true); testRead(32, 0, true); testRead(32, 4, false); testRead( 4, 16, true); testRead( 1, 31, true); testRead( 0, 0, true); testRead(31, Integer.MAX_VALUE, false); testRead( 0, Integer.MAX_VALUE, false); testRead(-1, Integer.MAX_VALUE, false); testRead(-4, Integer.MIN_VALUE, false); testRead( 0, Integer.MIN_VALUE, false); } static void testRead(int off, int len, boolean expected) throws Throwable { System.err.printf("off=%d len=%d expected=%b%n", off, len, expected); boolean result; try { fis.read(b, off, len); raf.read(b, off, len); result = true; } catch (IndexOutOfBoundsException e) { result = false; } if (result != expected) { throw new RuntimeException (String.format("Unexpected result off=%d len=%d expected=%b", off, len, expected)); } } } Martin On Tue, Jan 6, 2009 at 08:38, Gary Benson wrote: > Hi Martin, > > I like your method of avoiding the overflow, it's a nice idea. > I've attached an updated version of my original patch, with that, > and with an expanded comment too, to make sure the fix doesn't > get reverted later on in the interests of readability or whatever. > > Can I ask that you file a seperate bug for your other changes? > They're not specifically related to 6788196, and I feel it > confuses the issue somewhat having a bunch of unrelated changes > in the patch. > > Cheers, > Gary > > Martin Buchholz wrote: >> I have sympathy for Gary's reluctance to use jlong, >> even though we all know that here the performance of 64-bit >> operands doesn't matter. >> >> I propose an alternate patch, which avoids the overflow problem >> by simply rearranging the operands, and adds other pedantic >> improvements. >> >> I believe it may not be 100% portable to replace >> (len < 0) || (off < 0) >> with >> ((len | off) < 0) >> I'll leave that optimization to the compiler. >> >> diff --git a/src/share/native/java/io/io_util.c >> b/src/share/native/java/io/io_util.c >> --- a/src/share/native/java/io/io_util.c >> +++ b/src/share/native/java/io/io_util.c >> @@ -25,6 +25,7 @@ >> >> #include >> #include >> +#include >> >> #include "jni.h" >> #include "jni_util.h" >> @@ -34,9 +35,9 @@ >> >> /* IO helper functions */ >> >> -int >> +jint >> readSingle(JNIEnv *env, jobject this, jfieldID fid) { >> - int nread; >> + jint nread; >> char ret; >> FD fd = GET_FD(this, fid); >> if (fd == -1) { >> @@ -59,13 +60,14 @@ readSingle(JNIEnv *env, jobject this, jf >> #define BUF_SIZE 8192 >> >> >> -int >> +jint >> readBytes(JNIEnv *env, jobject this, jbyteArray bytes, >> jint off, jint len, jfieldID fid) >> { >> - int nread, datalen; >> + jint nread; >> + jsize datalen; >> char stackBuf[BUF_SIZE]; >> - char *buf = 0; >> + char *buf = NULL; >> FD fd; >> >> if (IS_NULL(bytes)) { >> @@ -74,8 +76,10 @@ readBytes(JNIEnv *env, jobject this, jby >> } >> datalen = (*env)->GetArrayLength(env, bytes); >> >> - if ((off < 0) || (off > datalen) || >> - (len < 0) || ((off + len) > datalen) || ((off + len) < 0)) { >> + if ((off < 0) || >> + (len < 0) || >> + /* Avoid undefined signed integer overflow. */ >> + (datalen - off < len)) { >> JNU_ThrowByName(env, "java/lang/IndexOutOfBoundsException", 0); >> return -1; >> } >> @@ -84,7 +88,7 @@ readBytes(JNIEnv *env, jobject this, jby >> return 0; >> } else if (len > BUF_SIZE) { >> buf = malloc(len); >> - if (buf == 0) { >> + if (buf == NULL) { >> JNU_ThrowOutOfMemoryError(env, 0); >> return 0; >> } >> @@ -118,7 +122,7 @@ void >> void >> writeSingle(JNIEnv *env, jobject this, jint byte, jfieldID fid) { >> char c = byte; >> - int n; >> + jint n; >> FD fd = GET_FD(this, fid); >> if (fd == -1) { >> JNU_ThrowIOException(env, "Stream Closed"); >> @@ -134,11 +138,12 @@ writeSingle(JNIEnv *env, jobject this, j >> >> void >> writeBytes(JNIEnv *env, jobject this, jbyteArray bytes, >> - jint off, jint len, jfieldID fid) >> + jint off, jint len, jfieldID fid) >> { >> - int n, datalen; >> + jint n; >> + jsize datalen; >> char stackBuf[BUF_SIZE]; >> - char *buf = 0; >> + char *buf = NULL; >> FD fd; >> >> if (IS_NULL(bytes)) { >> @@ -147,8 +152,10 @@ writeBytes(JNIEnv *env, jobject this, jb >> } >> datalen = (*env)->GetArrayLength(env, bytes); >> >> - if ((off < 0) || (off > datalen) || >> - (len < 0) || ((off + len) > datalen) || ((off + len) < 0)) { >> + if ((off < 0) || >> + (len < 0) || >> + /* Avoid undefined signed integer overflow. */ >> + (datalen - off < len)) { >> JNU_ThrowByName(env, "java/lang/IndexOutOfBoundsException", 0); >> return; >> } >> @@ -157,7 +164,7 @@ writeBytes(JNIEnv *env, jobject this, jb >> return; >> } else if (len > BUF_SIZE) { >> buf = malloc(len); >> - if (buf == 0) { >> + if (buf == NULL) { >> JNU_ThrowOutOfMemoryError(env, 0); >> return; >> } >> @@ -196,19 +203,19 @@ throwFileNotFoundException(JNIEnv *env, >> throwFileNotFoundException(JNIEnv *env, jstring path) >> { >> char buf[256]; >> - int n; >> + jint n; >> jobject x; >> jstring why = NULL; >> >> n = JVM_GetLastErrorString(buf, sizeof(buf)); >> if (n > 0) { >> - why = JNU_NewStringPlatform(env, buf); >> + why = JNU_NewStringPlatform(env, buf); >> } >> x = JNU_NewObjectByName(env, >> "java/io/FileNotFoundException", >> "(Ljava/lang/String;Ljava/lang/String;)V", >> path, why); >> if (x != NULL) { >> - (*env)->Throw(env, x); >> + (*env)->Throw(env, x); >> } >> } >> diff --git a/src/share/native/java/io/io_util.h >> b/src/share/native/java/io/io_util.h >> --- a/src/share/native/java/io/io_util.h >> +++ b/src/share/native/java/io/io_util.h >> @@ -38,9 +38,9 @@ extern jfieldID IO_handle_fdID; >> * IO helper functions >> */ >> >> -int readSingle(JNIEnv *env, jobject this, jfieldID fid); >> -int readBytes(JNIEnv *env, jobject this, jbyteArray bytes, jint off, >> - jint len, jfieldID fid); >> +jint readSingle(JNIEnv *env, jobject this, jfieldID fid); >> +jint readBytes(JNIEnv *env, jobject this, jbyteArray bytes, jint off, >> + jint len, jfieldID fid); >> void writeSingle(JNIEnv *env, jobject this, jint byte, jfieldID fid); >> void writeBytes(JNIEnv *env, jobject this, jbyteArray bytes, jint off, >> jint len, jfieldID fid); >> >> Martin > -------------- next part -------------- A non-text attachment was scrubbed... Name: SignedIntegerOverflow.patch Type: text/x-patch Size: 6963 bytes Desc: not available URL: From gbenson at redhat.com Wed Jan 7 10:31:42 2009 From: gbenson at redhat.com (Gary Benson) Date: Wed, 7 Jan 2009 10:31:42 +0000 Subject: [PATCH] 6788196: Array bounds checks in io_util.c rely on undefined behaviour In-Reply-To: <1ccfd1c10901061702t1707264cp726f4f21f6537df6@mail.gmail.com> References: <20081223102119.GB3241@redhat.com> <1ccfd1c10812231242o458a2b06k4db729f7c72dc71c@mail.gmail.com> <20081224102543.GC3229@redhat.com> <1ccfd1c10812241441m76667f0dk97f51621b732081b@mail.gmail.com> <20090106163806.GF3238@redhat.com> <1ccfd1c10901061702t1707264cp726f4f21f6537df6@mail.gmail.com> Message-ID: <20090107103142.GC3240@redhat.com> Martin Buchholz wrote: > I propose to commit this, if Gary and Alan give me thumbs up. Thumbs up, thank you :) Cheers, Gary -- http://gbenson.net/ From tomas.hurka at sun.com Wed Jan 7 13:10:18 2009 From: tomas.hurka at sun.com (tomas.hurka at sun.com) Date: Wed, 07 Jan 2009 13:10:18 +0000 Subject: hg: jdk7/tl/jdk: 6790467: Add test for setInterval() for local MonitoredHost and local MonitoredVm Message-ID: <20090107131032.CA69DD1AB@hg.openjdk.java.net> Changeset: 0bd360988b3a Author: thurka Date: 2009-01-07 14:06 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bd360988b3a 6790467: Add test for setInterval() for local MonitoredHost and local MonitoredVm Summary: test for MonitoredHost.setInterval() and MonitoredVm.setInterval() added Reviewed-by: swamyv + test/sun/jvmstat/monitor/MonitoredVm/CR6672135.java From martinrb at google.com Wed Jan 7 19:59:15 2009 From: martinrb at google.com (martinrb at google.com) Date: Wed, 07 Jan 2009 19:59:15 +0000 Subject: hg: jdk7/tl/jdk: 6788196: (porting) Bounds checks in io_util.c rely on undefined behaviour Message-ID: <20090107195932.6C8A1D264@hg.openjdk.java.net> Changeset: ff572b4f1ca4 Author: martin Date: 2009-01-07 11:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff572b4f1ca4 6788196: (porting) Bounds checks in io_util.c rely on undefined behaviour Reviewed-by: alanb Contributed-by: gbenson at redhat.com ! src/share/native/java/io/io_util.c ! test/java/io/readBytes/ReadBytesBounds.java From jonathan.gibbons at sun.com Wed Jan 7 22:50:36 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 07 Jan 2009 22:50:36 +0000 Subject: hg: jdk7/tl/langtools: 6512707: "incompatible types" after (unrelated) annotation processing Message-ID: <20090107225038.5A5FAD281@hg.openjdk.java.net> Changeset: 7a595d92e252 Author: jjg Date: 2009-01-07 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7a595d92e252 6512707: "incompatible types" after (unrelated) annotation processing Reviewed-by: darcy Contributed-by: prunge at velocitynet.com.au ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java + test/tools/javac/processing/6512707/T6512707.java + test/tools/javac/processing/6512707/TestAnnotation.java + test/tools/javac/processing/6512707/TestEnum.java From martinrb at google.com Thu Jan 8 02:53:43 2009 From: martinrb at google.com (Martin Buchholz) Date: Wed, 7 Jan 2009 18:53:43 -0800 Subject: memory leak in io_util.c Message-ID: <1ccfd1c10901071853p414f8b55ibe9797857aced3ed@mail.gmail.com> This is a followup to our previous io_util.c fixing. Alan, please file a bug: Description: When a user reads from a closed FileInputStream or RandomAccessFile into a byte array (or a region thereof) larger than 8k, an internal native buffer created for the read is leaked. io_util.c has been bugging me for years, so please file another cleanup bug: Description: Code cleanups in io_util.c Here's the fix for the memory leak (Alan, please review) # HG changeset patch # User martin # Date 1231382910 28800 # Node ID 8a60a49c60087170f6af565285b59eacb0cdb731 # Parent ff572b4f1ca45416b053a5ef37dbf27361199909 6666666: Reading from closed input files leaks native memory Reviewed-by: alanb Contributed-by: jeremymanson at google.com diff --git a/src/share/native/java/io/io_util.c b/src/share/native/java/io/io_util.c --- a/src/share/native/java/io/io_util.c +++ b/src/share/native/java/io/io_util.c @@ -90,6 +90,12 @@ return -1; } + fd = GET_FD(this, fid); + if (fd == -1) { + JNU_ThrowIOException(env, "Stream Closed"); + return -1; + } + if (len == 0) { return 0; } else if (len > BUF_SIZE) { @@ -100,12 +106,6 @@ } } else { buf = stackBuf; - } - - fd = GET_FD(this, fid); - if (fd == -1) { - JNU_ThrowIOException(env, "Stream Closed"); - return -1; } nread = IO_Read(fd, buf, len); diff --git a/test/java/io/readBytes/MemoryLeak.java b/test/java/io/readBytes/MemoryLeak.java new file mode 100644 --- /dev/null +++ b/test/java/io/readBytes/MemoryLeak.java @@ -0,0 +1,51 @@ +/* + * Copyright 2008 Sun Microsystems, Inc. All Rights Reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, + * CA 95054 USA or visit www.sun.com if you need additional information or + * have any questions. + */ + +/* + * @test + * @bug 6666666 + * @summary Reading from closed input files leaks native memory + */ + +import java.io.*; + +public class MemoryLeak { + public static void main(String[] args) throws Throwable { + byte[] bytes = new byte[1 << 20]; + String dir = System.getProperty("test.src", "."); + File testFile = new File(dir, "input.txt"); + FileInputStream s = new FileInputStream(testFile); + s.close(); + for (int i = 0; i < 10000; i++) { + try { + s.read(bytes); + throw new Error("expected IOException"); + } catch (IOException _) { + /* OK */ + } catch (OutOfMemoryError oome) { + System.out.printf("Got OutOfMemoryError, i=%d%n", i); + throw oome; + } + } + } +} From Bradford.Wetmore at Sun.COM Thu Jan 8 03:01:12 2009 From: Bradford.Wetmore at Sun.COM (Brad Wetmore) Date: Wed, 07 Jan 2009 19:01:12 -0800 Subject: hg: jdk7/tl/jdk: 6642323: Speeding up Single Byte Decoders; ... In-Reply-To: <494BDE94.9010806@gmx.de> References: <20081210221115.6881DD5DA@hg.openjdk.java.net> <494B9FAD.9050808@gmx.de> <494BD3FB.3060705@sun.com> <494BDE94.9010806@gmx.de> Message-ID: <49656C78.8080009@sun.com> Ulf, Sorry for the delay, I've been working on other projects, and my OpenJDK folder is now overflowing. > So as I understand right, looking for posts like "Added tag jdk7-b40 for > changeset 44be42de6693" doesn't make much sense in my case. I'm not sure I completely understand the question. We're currently using tags to signify each build (jdk7-b42). If you look at the MASTER repository: http://hg.openjdk.java.net/jdk7/jdk7/jdk/shortlog All the changesets that appear after that entry should be in that build. Regarding 6642323, looks like it's now in the MASTER, but there hasn't been a promotion yet. I'd guess it'll be b43. I don't know if there is a list of bug fixes for each promotion. Someone in RE might know. Brad > Regards and happy holidays, > > Ulf > > > > Am 19.12.2008 18:03, Brad Wetmore schrieb: >> >> If you want to see the source change now, check out the changeset: >> >> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b89ba9a6d9a6 >> >> This change will not be seen immediately in the JDK7 snapshot source >> and binaries. As you may know, we use a series of subgates to make >> development and testing easier, and to prevent breakage in one area >> from seriously impacting everyone in unrelated areas. >> >> For way too much info: >> >> http://blogs.sun.com/wetmore/entry/you_re_a_gatekeeper_uh >> >> To your question, this change was just putback into the TL gate. >> Generally, changes from the TL gate a putback migrate in the MASTER >> gate once every two weeks. This follows roughly a week of testing by >> our quality team. Our release engineering then does builds every two >> weeks. So depending on where we in are in the TL and RE cycles when >> the engineer does his/her putback, it could be 1 week to 1 month >> before the change appears at: >> >> http://jdk7.dev.java.net/ >> >> The integration and build schedule is at: >> >> http://openjdk.java.net/projects/jdk7/builds/ >> >> The holiday isn't helping! ;) >> >> So I'm guessing it will be available in b44 around 22 Jan 09, assuming >> TL integrates and there are no hiccups. >> >> Hope this helps. >> >> Brad >> >> >> >> >> Ulf Zibis wrote: >>> Hi Sherman, >>> >>> where can I get information, if this changeset is included in JDK7 >>> snapshot source bundle + snapshot binaries? >>> >>> Regards, >>> Ulf >>> >>> >>> Am 10.12.2008 23:10, xueming.shen at sun.com schrieb: >>>> Changeset: b89ba9a6d9a6 >>>> Author: sherman >>>> Date: 2008-12-10 14:03 -0800 >>>> URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b89ba9a6d9a6 >>>> >>>> 6642323: Speeding up Single Byte Decoders >>>> 6642328: Speeding up Single Byte Encoders >>>> Summary: re-implementation of mapping based sbcs charts >>>> Reviewed-by: alanb >>>> >>>> >>> >> >> > From forax at univ-mlv.fr Thu Jan 8 03:02:48 2009 From: forax at univ-mlv.fr (=?ISO-8859-15?Q?R=E9mi_Forax?=) Date: Thu, 08 Jan 2009 04:02:48 +0100 Subject: hg: jdk7/tl/jdk: 6642323: Speeding up Single Byte Decoders; ... In-Reply-To: <49656C78.8080009@sun.com> References: <20081210221115.6881DD5DA@hg.openjdk.java.net> <494B9FAD.9050808@gmx.de> <494BD3FB.3060705@sun.com> <494BDE94.9010806@gmx.de> <49656C78.8080009@sun.com> Message-ID: <49656CD8.7050303@univ-mlv.fr> Brad Wetmore a ?crit : > > Ulf, > > Sorry for the delay, I've been working on other projects, and my > OpenJDK folder is now overflowing. > >> So as I understand right, looking for posts like "Added tag jdk7-b40 >> for changeset 44be42de6693" doesn't make much sense in my case. > > I'm not sure I completely understand the question. > > We're currently using tags to signify each build (jdk7-b42). If you > look at the MASTER repository: > > http://hg.openjdk.java.net/jdk7/jdk7/jdk/shortlog > > All the changesets that appear after that entry should be in that build. > > Regarding 6642323, looks like it's now in the MASTER, but there hasn't > been a promotion yet. I'd guess it'll be b43. > > I don't know if there is a list of bug fixes for each promotion. > Someone in RE might know. http://download.java.net/jdk7/changes/jdk7-b42.html > > Brad regards, R?mi From Ulf.Zibis at gmx.de Thu Jan 8 12:00:52 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Thu, 08 Jan 2009 13:00:52 +0100 Subject: hg: jdk7/tl/jdk: 6642323: Speeding up Single Byte Decoders; ... In-Reply-To: <49656C78.8080009@sun.com> References: <20081210221115.6881DD5DA@hg.openjdk.java.net> <494B9FAD.9050808@gmx.de> <494BD3FB.3060705@sun.com> <494BDE94.9010806@gmx.de> <49656C78.8080009@sun.com> Message-ID: <4965EAF4.1020607@gmx.de> Hi Brad, Am 08.01.2009 04:01, Brad Wetmore schrieb: > > Ulf, > > Sorry for the delay, I've been working on other projects, and my > OpenJDK folder is now overflowing. No worry about, I became earlier answer from Sherman (Xueming Shen). > >> So as I understand right, looking for posts like "Added tag jdk7-b40 >> for changeset 44be42de6693" doesn't make much sense in my case. > > I'm not sure I completely understand the question. > > We're currently using tags to signify each build (jdk7-b42). If you > look at the MASTER repository: > > http://hg.openjdk.java.net/jdk7/jdk7/jdk/shortlog > > All the changesets that appear after that entry should be in that build. Tag jdk7-b41 was added 2008/12/08 in this list, and jdk7-b42 _2 weeks ago_, so according your rule above, changeset b89ba9a6d9a6, which was published 2008/12/10, should be in b41, at least in b42, but it isn't. That was the reason for my question. > > Regarding 6642323, looks like it's now in the MASTER, but there hasn't > been a promotion yet. I'd guess it'll be b43. I guess too, according Sherman's answer, Thanks for your time, -Ulf From Alan.Bateman at Sun.COM Thu Jan 8 12:38:12 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Thu, 08 Jan 2009 12:38:12 +0000 Subject: memory leak in io_util.c In-Reply-To: <1ccfd1c10901071853p414f8b55ibe9797857aced3ed@mail.gmail.com> References: <1ccfd1c10901071853p414f8b55ibe9797857aced3ed@mail.gmail.com> Message-ID: <4965F3B4.6010700@sun.com> Martin Buchholz wrote: > This is a followup to our previous io_util.c fixing. > > Alan, please file a bug: > Good catch, I've created: 6791458: FileInputStream/RandomAccessFile.read leaks memory if invoked on closed stream with len > 8k The change looks fine. One minor comment on the test is that it probably doesn't need to catch OOME. -Alan. From Bradford.Wetmore at Sun.COM Thu Jan 8 18:03:22 2009 From: Bradford.Wetmore at Sun.COM (Brad Wetmore) Date: Thu, 08 Jan 2009 10:03:22 -0800 Subject: hg: jdk7/tl/jdk: 6642323: Speeding up Single Byte Decoders; ... In-Reply-To: <4965EAF4.1020607@gmx.de> References: <20081210221115.6881DD5DA@hg.openjdk.java.net> <494B9FAD.9050808@gmx.de> <494BD3FB.3060705@sun.com> <494BDE94.9010806@gmx.de> <49656C78.8080009@sun.com> <4965EAF4.1020607@gmx.de> Message-ID: <49663FEA.5080807@sun.com> > Tag jdk7-b41 was added 2008/12/08 in this list, and jdk7-b42 _2 weeks > ago_, so according your rule above, changeset b89ba9a6d9a6, which was > published 2008/12/10, should be in b41, at least in b42, but it isn't. > That was the reason for my question. There are two orderings that may be confusing the situation. There is the ordering of the changesets, and the dates a particular changeset was created. The dates listed by mercurial are the dates that the change set was created. Recall that changesets are first introduced in a subgate, and then has to go through testing before it hits the MASTER gate, which is where the releases are built from. If you look at the log now, there are several client changesets done 5 months ago that just hit the MASTER gate yesterday, but haven't yet appeared in a JDK build. Eventually, there will be a tag for b43 created when that build is done and everything following it in changeset order should be contained in that build. http://hg.openjdk.java.net/jdk7/jdk7/jdk/shortlog ...deleted... 5 months ago igor 4356282: RFE: T2K should be used to rasterize CID/CFF fonts changeset | manifest 5 months ago bae 6687968: PNGImageReader leaks native memory through an Inflater. changeset | manifest 2 weeks ago tbell Merge changeset | manifest 4 weeks ago sherman 6642323: Speeding up Single Byte Decoders changeset | manifest ...deleted... The "tbell merge" was the last integration to the gate before Lana's Client integration yesterday. If you look at the current build schedule: http://openjdk.java.net/projects/jdk7/builds/ you'll see that b43 should be done next Thursday, and the tag added accordingly. Hope that's clearer, and more importantly, that I didn't say anything incorrect. ;) Brad > >> >> Regarding 6642323, looks like it's now in the MASTER, but there hasn't >> been a promotion yet. I'd guess it'll be b43. > > I guess too, according Sherman's answer, > > Thanks for your time, > > -Ulf > > From Kelly.Ohair at Sun.COM Thu Jan 8 19:25:11 2009 From: Kelly.Ohair at Sun.COM (Kelly O'Hair) Date: Thu, 08 Jan 2009 11:25:11 -0800 Subject: hg: jdk7/tl/jdk: 6642323: Speeding up Single Byte Decoders; ... In-Reply-To: <4965EAF4.1020607@gmx.de> References: <20081210221115.6881DD5DA@hg.openjdk.java.net> <494B9FAD.9050808@gmx.de> <494BD3FB.3060705@sun.com> <494BDE94.9010806@gmx.de> <49656C78.8080009@sun.com> <4965EAF4.1020607@gmx.de> Message-ID: <49665317.2000300@sun.com> Be careful about the "2 weeks ago" stuff... That refers to when the changeset was created, not necessarily when it was 'pushed' into the repository. We need a better online way to browse the changesets. You can try 'hg view' on your own repository, took me a while to get that to work on my Mac, but it lets you see the changeset graph. This blog might help: http://blogs.sun.com/kto/entry/openjdk_mercurial_and_the_changeset -kto Ulf Zibis wrote: > Hi Brad, > > > Am 08.01.2009 04:01, Brad Wetmore schrieb: >> >> Ulf, >> >> Sorry for the delay, I've been working on other projects, and my >> OpenJDK folder is now overflowing. > > No worry about, I became earlier answer from Sherman (Xueming Shen). > >> >>> So as I understand right, looking for posts like "Added tag jdk7-b40 >>> for changeset 44be42de6693" doesn't make much sense in my case. >> >> I'm not sure I completely understand the question. >> >> We're currently using tags to signify each build (jdk7-b42). If you >> look at the MASTER repository: >> >> http://hg.openjdk.java.net/jdk7/jdk7/jdk/shortlog >> >> All the changesets that appear after that entry should be in that build. > > > Tag jdk7-b41 was added 2008/12/08 in this list, and jdk7-b42 _2 weeks > ago_, so according your rule above, changeset b89ba9a6d9a6, which was > published 2008/12/10, should be in b41, at least in b42, but it isn't. > That was the reason for my question. > > >> >> Regarding 6642323, looks like it's now in the MASTER, but there hasn't >> been a promotion yet. I'd guess it'll be b43. > > I guess too, according Sherman's answer, > > Thanks for your time, > > -Ulf > > From martinrb at google.com Thu Jan 8 22:34:16 2009 From: martinrb at google.com (martinrb at google.com) Date: Thu, 08 Jan 2009 22:34:16 +0000 Subject: hg: jdk7/tl/jdk: 6791458: FileInputStream/RandomAccessFile.read leaks memory if invoked on closed stream with len > 8k Message-ID: <20090108223441.3C59CD2C1@hg.openjdk.java.net> Changeset: 0272e442cc5b Author: martin Date: 2009-01-08 14:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0272e442cc5b 6791458: FileInputStream/RandomAccessFile.read leaks memory if invoked on closed stream with len > 8k Reviewed-by: alanb Contributed-by: jeremymanson at google.com ! src/share/native/java/io/io_util.c + test/java/io/readBytes/MemoryLeak.java From kelly.ohair at sun.com Thu Jan 8 23:14:11 2009 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Thu, 08 Jan 2009 23:14:11 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20090108231446.4BE31D2CE@hg.openjdk.java.net> Changeset: f6c105e60186 Author: bpatel Date: 2009-01-07 16:39 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f6c105e60186 6790217: Javadoc HTML WCAG 2.0 accessibility issues in jdk docs makefile - Bold tags should be strong Reviewed-by: jjg ! make/docs/Makefile Changeset: 71a6cd33d365 Author: bpatel Date: 2009-01-08 14:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/71a6cd33d365 Merge Changeset: f5062c0ae8d5 Author: bpatel Date: 2009-01-08 15:10 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5062c0ae8d5 Merge From Joe.Darcy at Sun.COM Fri Jan 9 21:38:58 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Fri, 09 Jan 2009 13:38:58 -0800 Subject: Interest in support for saturated casts? In-Reply-To: <194f62550812221251w19d2c55aye53c19476275bbce@mail.gmail.com> References: <194f62550812221251w19d2c55aye53c19476275bbce@mail.gmail.com> Message-ID: <4967C3F2.7020202@sun.com> Hello. Clemens Eisserer wrote: > Hi, > > I currently use an utility-class heavily for the XRender Java2D > backend, which performs saturated casts: > > 1.) return (short) (x > Short.MAX_VALUE ? Short.MAX_VALUE : (x < > Short.MIN_VALUE ? Short.MIN_VALUE : x)); > 2.) return (short) (x > 65535 ? 65535 : (x < 0) ? 0 : x); > > I spent quite some time benchmarking/tuning the > protocol-generation-methods, and a lot of cycles are spent in those > saturated casts, even if the utility methods are static. > E.g. XRenderFillRectangle takes 40 cycles without clamping, but > already 70 cycles with on my core2duo with hotspot-server/jdk 14.0. > Hotspot seems to solve the problem always with conditional jumps, > although well predictable ones. > > Modern processors seem to have support for this kind of operation, in > x86 there's packssdw in MMX/SSE2. > I think something like a saturated cast could be quite useful, there > are already cast-methods in Long/Integer/Short - what do you think > about adding saturated casts to that API? > Those could be instrified to use MMX/SSE2 if available. > > If that would be too specific how hard would it be to add this kind of > optimization to hotspot? > How far does SIMD support in hotspot go (I read some time ago there've > been some optimizations), if SIMD would be supported 4 casts could be > done in a single cycle :) > > Thanks, Clemens > One of the libraries enhancements I'd like to implement in JDK 7 is support for unsigned integer arithmetic, 4504839 "Java libraries should provide support for unsigned integer arithmetic" and related bugs. That would include methods to do conversions like Short.toUnsignedInt(myShort) Short.toUnsignedLong(myShort) Perhaps there could also be methods for saturating conversions, Integer.toSaturatedShort(int) etc. The presence of such standard methods would make it easier for HotSpot to intrinsify them on platforms with direct hardware support. -Joe From kelly.ohair at sun.com Fri Jan 9 23:09:36 2009 From: kelly.ohair at sun.com (kelly.ohair at sun.com) Date: Fri, 09 Jan 2009 23:09:36 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20090109230939.B0221D33B@hg.openjdk.java.net> Changeset: 47a62d8d98b4 Author: bpatel Date: 2009-01-08 16:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/47a62d8d98b4 6786028: Javadoc HTML WCAG 2.0 accessibility issues in standard doclet - Bold tags should be strong Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java ! test/com/sun/javadoc/AccessAsciiArt/AccessAsciiArt.java ! test/com/sun/javadoc/AuthorDD/AuthorDD.java ! test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java ! test/com/sun/javadoc/testClassTree/TestClassTree.java ! test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java ! test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java ! test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java ! test/com/sun/javadoc/testHeadings/TestHeadings.java ! test/com/sun/javadoc/testHelpOption/TestHelpOption.java ! test/com/sun/javadoc/testHref/TestHref.java + test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java + test/com/sun/javadoc/testHtmlStrongTag/pkg1/C1.java + test/com/sun/javadoc/testHtmlStrongTag/pkg2/C2.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testInterface/TestInterface.java ! test/com/sun/javadoc/testJavascript/TestJavascript.java ! test/com/sun/javadoc/testLinkOption/TestLinkOption.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java ! test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java ! test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java ! test/com/sun/javadoc/testPackagePage/TestPackagePage.java ! test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java ! test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java ! test/com/sun/javadoc/testSerializedForm/TestSerializedForm.java ! test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java ! test/com/sun/javadoc/testSummaryHeading/TestSummaryHeading.java ! test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java ! test/com/sun/javadoc/testValueTag/TestValueTag.java Changeset: dbe9e82f9d25 Author: bpatel Date: 2009-01-08 16:34 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/dbe9e82f9d25 Merge ! test/com/sun/javadoc/AuthorDD/AuthorDD.java From Ulf.Zibis at gmx.de Fri Jan 9 23:19:53 2009 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Sat, 10 Jan 2009 00:19:53 +0100 Subject: Speed-up FastCharsetProvider - Update In-Reply-To: <49600E86.7040800@gmx.de> References: <49600E86.7040800@gmx.de> Message-ID: <4967DB99.2040201@gmx.de> The bug report is online: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6790402 I includes *8* items, to speed-up FastCharsetProvider, and 1 real bug concerning thread-safety. -Ulf Am 04.01.2009 02:19, Ulf Zibis schrieb: > Hi Sherman, hi Martin, > > I took a closer look to sun.io.cs.FastCharsetProvider, and found out, > that there are some possibilities to enhance it. > > I have filed a bug. See Review ID: 1425597 and: > https://java-nio-charset-enhanced.dev.java.net/source/browse/java-nio-charset-enhanced/trunk/src/sun/nio/cs/FastCharsetProvider.java?diff_format=s&rev=551&view=markup > > > -Ulf > > > > > From martinrb at google.com Sat Jan 10 01:09:02 2009 From: martinrb at google.com (martinrb at google.com) Date: Sat, 10 Jan 2009 01:09:02 +0000 Subject: hg: jdk7/tl/jdk: 6792066: src/share/native/java/io/io_util.c clean-ups Message-ID: <20090110010920.AA3DBD342@hg.openjdk.java.net> Changeset: 961ea5a46a0c Author: martin Date: 2009-01-09 16:48 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/961ea5a46a0c 6792066: src/share/native/java/io/io_util.c clean-ups Reviewed-by: alanb ! src/share/native/java/io/io_util.c ! src/share/native/java/io/io_util.h From jodastephen at gmail.com Sat Jan 10 00:37:31 2009 From: jodastephen at gmail.com (Stephen Colebourne) Date: Sat, 10 Jan 2009 00:37:31 +0000 Subject: Interest in support for saturated casts? In-Reply-To: <4967C3F2.7020202@sun.com> References: <194f62550812221251w19d2c55aye53c19476275bbce@mail.gmail.com> <4967C3F2.7020202@sun.com> Message-ID: <4967EDCB.8070006@gmail.com> Joseph D. Darcy wrote: > One of the libraries enhancements I'd like to implement in JDK 7 is > support for unsigned integer arithmetic, 4504839 "Java libraries > should provide support for unsigned integer arithmetic" and related > bugs. That would include methods to do conversions like > > Short.toUnsignedInt(myShort) > Short.toUnsignedLong(myShort) > > Perhaps there could also be methods for saturating conversions, > > Integer.toSaturatedShort(int) > etc. > > The presence of such standard methods would make it easier for HotSpot > to intrinsify them on platforms with direct hardware support. > > -Joe In a similar vein, the libraries could do with methods like: Numbers.safeAdd(int, int) Numbers.safeSubtract(int, int) Numbers.safeMultiply(int, int) Numbers.safeCompare(int, int) which throw ArithmeticException rather than silently overflowing like (int + int) and friends do. Weve had to develop these kinds of methods for JSR-310. Stephen From tim.bell at sun.com Mon Jan 12 02:05:33 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 12 Jan 2009 02:05:33 +0000 Subject: hg: jdk7/tl/hotspot: 31 new changesets Message-ID: <20090112020632.AD546D418@hg.openjdk.java.net> Changeset: 7b920868b475 Author: coleenp Date: 2008-12-08 15:50 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7b920868b475 6773838: There is no calling stack for Compiler thread in hs_err file on x86 Summary: On solaris, the inline assembly wasn't being processed. Added volatile to il file fixed it. Reviewed-by: phh, kvn ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.il ! src/os_cpu/solaris_x86/vm/solaris_x86_64.il Changeset: 3ad2b8576c4a Author: coleenp Date: 2008-12-09 09:55 -0500 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3ad2b8576c4a 6689685: Hotspot crash error message should include libraries version Summary: Print out JDK/JRE version that hotspot knows about. Reviewed-by: kamg, blacklion, acorn, alanb ! src/share/vm/utilities/vmError.cpp Changeset: 7a018855d2f0 Author: jrose Date: 2008-12-08 17:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7a018855d2f0 6779339: turn off LinkWellKnownClasses by default pending further testing Summary: temporarily turn off LinkWellKnownClasses optimization Reviewed-by: never, kvn ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/runtime/globals.hpp Changeset: 284d0af00d53 Author: jrose Date: 2008-12-09 12:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/284d0af00d53 6771309: debugging AD files is difficult without #line directives in generated code Summary: more and better #line and #define directives in the generated code; ADLC itself accepts #line directives Reviewed-by: never, kvn ! make/linux/adlc_updater ! make/linux/makefiles/adlc.make ! make/solaris/adlc_updater ! make/solaris/makefiles/adlc.make ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/dfa.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/formssel.cpp Changeset: 7b75310e57e2 Author: kvn Date: 2008-12-11 17:20 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7b75310e57e2 Merge ! src/share/vm/runtime/globals.hpp Changeset: 24fda36852ce Author: coleenp Date: 2008-12-10 15:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/24fda36852ce 6727377: VM stack guard pages on Windows should PAGE_READWRITE not PAGE_EXECUTE_READWRITE Summary: Make reguard_stack change access to RW, not execute and use os::protect_memory with the new parameter when change needed to X. Reviewed-by: acorn, jcoomes ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: a7fac4381b50 Author: blacklion Date: 2008-12-11 03:22 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a7fac4381b50 6639341: sometimes contended-exit event comes after contended-entered on another thread Summary: DTrace probe "contended-exit" should be fired before unparking object, or context could be lost. Probe firing was moved to proper place. Reviewed-by: coleenp, kamg ! src/share/vm/runtime/synchronizer.cpp Changeset: 06d2c3204df4 Author: blacklion Date: 2008-12-12 10:19 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/06d2c3204df4 Merge Changeset: d249b360e026 Author: ysr Date: 2008-12-10 23:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d249b360e026 6782457: CMS: Livelock in CompactibleFreeListSpace::block_size() 6736295: SIGSEGV in product jvm, assertion "these are the only valid states during a mark sweep" in fastdebug Summary: Restructured the code in the perm gen allocation retry loop so as to avoid "safepoint-blocking" on locks, in this case the Heap_lock, while holding uninitialized allocated heap storage. Reviewed-by: apetrusenko, iveresov, jcoomes, jmasa, poonam ! src/share/vm/memory/permGen.cpp Changeset: 7d7a7c599c17 Author: jcoomes Date: 2008-12-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7d7a7c599c17 6578152: fill_region_with_object has usability and safety issues Reviewed-by: apetrusenko, ysr ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweepDecorator.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/includeDB_gc ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/memory/space.cpp ! src/share/vm/memory/tenuredGeneration.cpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/runtime/globals.hpp Changeset: 7c2386d67889 Author: jcoomes Date: 2008-12-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7c2386d67889 6765745: par compact - allow young gen spaces to be split Reviewed-by: jmasa ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: 0f773163217d Author: jcoomes Date: 2008-12-11 12:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0f773163217d 6765954: par compact - stress mode for splitting young gen spaces Reviewed-by: jmasa ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: ffe19141e312 Author: jmasa Date: 2008-12-12 15:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ffe19141e312 Merge ! src/share/vm/runtime/globals.hpp Changeset: ac8fe14c93e4 Author: never Date: 2008-12-12 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ac8fe14c93e4 6767587: missing call to make_not_entrant after deoptimizing for patching volatiles Reviewed-by: rasbold, kvn ! src/share/vm/c1/c1_Runtime1.cpp Changeset: a738a625039a Author: never Date: 2008-12-12 19:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a738a625039a 6757316: load_constant() produces a wrong long constant, with high a low words swapped Reviewed-by: rasbold, jrose, kvn ! src/share/vm/c1/c1_LIRGenerator.cpp + test/compiler/6757316/Test6757316.java Changeset: 80206b8a9128 Author: never Date: 2008-12-12 19:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/80206b8a9128 6758234: if (k cond (a ? : b: c)) returns reversed answer if k is constant and b and c are longs Reviewed-by: kvn, jrose ! src/share/vm/c1/c1_Optimizer.cpp + test/compiler/6758234/Test6758234.java Changeset: 569b3b226089 Author: trims Date: 2008-12-20 09:57 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/569b3b226089 Merge ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/adlparse.hpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp Changeset: 2494ab195856 Author: swamyv Date: 2008-12-15 13:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2494ab195856 6653214: MemoryPoolMXBean.setUsageThreshold() does not support large heap sizes. Reviewed-by: ysr, mchung ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/services/management.cpp Changeset: dd70dd4c91de Author: kvn Date: 2008-12-16 12:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/dd70dd4c91de 6782820: Server VM fails with "unhandled implicit exception in compiled code" Summary: Restore the code which sets a control edge for a klass load node. Reviewed-by: never ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/macro.cpp Changeset: 6c345e1c5992 Author: kvn Date: 2008-12-17 14:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6c345e1c5992 Merge Changeset: 5496e074077f Author: kvn Date: 2008-12-18 11:26 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5496e074077f 6787050: assert(n->in(0) == 0L,"no control") with UseCompressedOops on sparcv9 Summary: Relax the assert for Sparc. Reviewed-by: never ! src/share/vm/opto/compile.cpp Changeset: eb811d2ef72e Author: kvn Date: 2008-12-18 13:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/eb811d2ef72e Merge Changeset: d593294016c3 Author: jcoomes Date: 2008-12-18 01:27 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d593294016c3 6786195: many nsk.monitoring tests fail with -server -Xcomp Summary: remove Universe::_fillerArrayKlassObj and associated code Reviewed-by: jmasa, tonyp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp Changeset: 234c22e54b98 Author: jcoomes Date: 2008-12-18 10:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/234c22e54b98 6784849: par compact - can fail when to_space is non-empty Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: b27c885f75f9 Author: jcoomes Date: 2008-12-18 10:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b27c885f75f9 6786188: par compact - "SplitALot" stress mode should fill to_space Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp Changeset: 7aadaf46ecd7 Author: jmasa Date: 2008-12-19 12:15 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7aadaf46ecd7 Merge Changeset: c6065343356f Author: poonam Date: 2008-12-18 17:28 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c6065343356f 6786340: hs14b09a pit: a lot of tests failed in "-server -Xcomp" on solaris-amd64 using fastdebug bits Summary: Fixes the nsk-jdi PIT failures introduced by fix for 6739363 Reviewed-by: kvn, coleenp ! src/share/vm/runtime/javaCalls.cpp Changeset: 8a25d96bcf08 Author: xlu Date: 2008-12-19 14:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8a25d96bcf08 6784100: getTimeNanos - CAS reduction Summary: Get rid of the CAS loop in getTimeNanos to reduce coherence traffic on Solaris. Reviewed-by: acorn, kvn, ysr ! src/os/solaris/vm/os_solaris.cpp Changeset: ca7d48236048 Author: xlu Date: 2008-12-20 00:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ca7d48236048 Merge Changeset: 26bc4770e671 Author: trims Date: 2008-12-20 09:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/26bc4770e671 Merge ! src/share/vm/runtime/javaCalls.cpp Changeset: fc6a5ae3fef5 Author: trims Date: 2008-12-20 09:59 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/fc6a5ae3fef5 6787832: Bump Hotspot build number to 08 Summary: Update the HS14 build number to 08 Reviewed-by: jcoomes ! make/hotspot_version From tim.bell at sun.com Mon Jan 12 02:13:26 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 12 Jan 2009 02:13:26 +0000 Subject: hg: jdk7/tl/jdk: 31 new changesets Message-ID: <20090112021929.490E8D442@hg.openjdk.java.net> Changeset: 94bcd3503668 Author: bae Date: 2008-07-25 14:46 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/94bcd3503668 6687968: PNGImageReader leaks native memory through an Inflater. Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java Changeset: e62bc7b05b8a Author: igor Date: 2008-08-04 18:50 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e62bc7b05b8a 4356282: RFE: T2K should be used to rasterize CID/CFF fonts Reviewed-by: bae, prr ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/windows/native/sun/font/fontpath.c Changeset: a56641c1f54e Author: tdv Date: 2008-08-04 11:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a56641c1f54e 6728834: D3D/OGL: LCD AA text becomes bold and blurred when rendering to a non-opaque destination Reviewed-by: campbell ! src/share/classes/sun/java2d/opengl/OGLSurfaceData.java ! src/windows/classes/sun/java2d/d3d/D3DSurfaceData.java + test/sun/java2d/DirectX/NonOpaqueDestLCDAATest/NonOpaqueDestLCDAATest.java Changeset: b2413144d908 Author: tdv Date: 2008-08-04 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b2413144d908 6717988: D3D: rendering problems with JConsole on [Nvidia FX 5200] Reviewed-by: campbell ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: 06a02adcba4e Author: tdv Date: 2008-08-05 09:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/06a02adcba4e 6733718: test /java/awt/FullScreen/UninitializedDisplayModeChangeTest/ fails Reviewed-by: igor + test/java/awt/FullScreen/UninitializedDisplayModeChangeTest/DisplayModeChanger.java Changeset: 15be3e891e97 Author: jgodinez Date: 2008-08-07 11:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15be3e891e97 6731937: javax/print/CheckDupFlavor.java fails Reviewed-by: campbell, tdv ! src/solaris/classes/sun/print/IPPPrintService.java + test/javax/print/CheckDupFlavor.java Changeset: 3c4561f955f3 Author: lana Date: 2008-08-07 22:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3c4561f955f3 Merge - make/tools/winver/Makefile - make/tools/winver/bin/winver.exe - make/tools/winver/src/StdAfx.cpp - make/tools/winver/src/StdAfx.h - make/tools/winver/src/winver.cpp - src/share/classes/com/sun/jmx/mbeanserver/OpenConverter.java - src/share/classes/javax/management/ToQueryString.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/solaris/classes/sun/print/IPPPrintService.java - test/javax/management/Introspector/LegacyIntrospectorTest.java Changeset: 3d3ef4073bdd Author: jgodinez Date: 2008-08-19 16:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3d3ef4073bdd 6731826: race condition in UnixPrintServiceLookup Reviewed-by: campbell, tdv ! src/solaris/classes/sun/print/IPPPrintService.java + test/javax/print/TestRaceCond.java Changeset: cd88b4ad7f25 Author: tdv Date: 2008-08-28 11:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cd88b4ad7f25 6739267: D3D/OGL: add missing ThreeByteBgr to texture upload blit loop Reviewed-by: campbell, flar ! src/share/classes/sun/java2d/opengl/OGLBlitLoops.java ! src/share/classes/sun/java2d/opengl/OGLSurfaceData.java ! src/share/demo/java2d/J2DBench/src/j2dbench/tests/ImageTests.java ! src/share/native/sun/java2d/opengl/OGLBlitLoops.c ! src/share/native/sun/java2d/opengl/OGLSurfaceData.c ! src/windows/classes/sun/java2d/d3d/D3DBlitLoops.java ! src/windows/classes/sun/java2d/d3d/D3DSurfaceData.java ! src/windows/native/sun/java2d/d3d/D3DBlitLoops.cpp ! src/windows/native/sun/java2d/d3d/D3DSurfaceData.h Changeset: b8f91ea2fb33 Author: tdv Date: 2008-09-12 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8f91ea2fb33 6748082: remove platform-specific code from SwingUtilities2.isDisplayLocal Reviewed-by: prr, tdv Contributed-by: rkennke at kennke.org ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/native/sun/awt/fontpath.c ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java Changeset: 41ff3f84cd96 Author: prr Date: 2008-09-24 11:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/41ff3f84cd96 6751621: TextLayout.getBounds() doesn't account for strike through Reviewed-by: igor, dougfelt ! src/share/classes/sun/font/Decoration.java ! src/share/classes/sun/font/Underline.java + test/java/awt/font/TextLayout/DecorationBoundsTest.java Changeset: 3bc4d79d8123 Author: tdv Date: 2008-10-09 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3bc4d79d8123 6749060: LCD AA text rendered incorrectly when destination is non opaque (sw pipeline only) Reviewed-by: campbell, prr ! src/share/classes/sun/java2d/SurfaceData.java ! test/sun/java2d/DirectX/NonOpaqueDestLCDAATest/NonOpaqueDestLCDAATest.java Changeset: 9a6094d65d28 Author: jgodinez Date: 2008-10-13 15:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a6094d65d28 6732647: isAttributeValueSupported() is not consistant with getSupportedValues() for Copies, TEXT flavor Reviewed-by: tdv, prr ! src/solaris/classes/sun/print/IPPPrintService.java ! src/solaris/classes/sun/print/UnixPrintService.java ! test/javax/print/attribute/PSCopiesFlavorTest.java Changeset: 22d965ed3b93 Author: prr Date: 2008-10-16 06:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/22d965ed3b93 6751616: outline for underline in TextLayout with underline is off rasterized underline Reviewed-by: dougfelt, igor ! src/share/classes/sun/font/Decoration.java + test/java/awt/font/TextLayout/UnderlinePositionTest.java Changeset: 665850610378 Author: lana Date: 2008-10-20 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/665850610378 Merge - make/ASSEMBLY_EXCEPTION - make/LICENSE - make/README - make/README-builds.html - make/README.html - make/THIRD_PARTY_README - make/java/nio/spp.sh - make/tools/auto_multi/Makefile - make/tools/src/build/tools/automulti/AutoMulti.java - make/tools/src/build/tools/automulti/README.txt - make/tools/src/build/tools/automulti/TestALFGenerator.java - make/tools/src/build/tools/automulti/TestALFLookAndFeel.java - src/share/classes/java/nio/channels/package.html - src/share/classes/javax/swing/colorchooser/DefaultHSBChooserPanel.java - src/share/classes/javax/swing/colorchooser/DefaultRGBChooserPanel.java - src/share/classes/javax/swing/colorchooser/SyntheticImage.java - src/share/classes/org/jcp/xml/dsig/internal/package.html - src/share/classes/sun/launcher/LauncherHelp.java - src/share/classes/sun/nio/ch/OptionAdaptor.java - src/share/classes/sun/nio/ch/SocketOpts.java - src/share/classes/sun/nio/ch/SocketOptsImpl.java - src/share/classes/sun/nio/ch/exceptions ! src/share/classes/sun/swing/SwingUtilities2.java - src/share/javavm/include/opcodes.h - src/share/javavm/include/opcodes.length - src/share/javavm/include/opcodes.list - src/share/javavm/include/opcodes.weight - src/share/javavm/include/opcodes.wide - src/share/javavm/include/sys_api.h - src/share/javavm/include/typedefs.h - src/solaris/classes/sun/awt/motif/MButtonPeer.java - src/solaris/classes/sun/awt/motif/MCanvasPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MCheckboxPeer.java - src/solaris/classes/sun/awt/motif/MChoicePeer.java - src/solaris/classes/sun/awt/motif/MComponentPeer.java - src/solaris/classes/sun/awt/motif/MCustomCursor.java - src/solaris/classes/sun/awt/motif/MDataTransferer.java - src/solaris/classes/sun/awt/motif/MDialogPeer.java - src/solaris/classes/sun/awt/motif/MDragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/MDropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/MEmbedCanvasPeer.java - src/solaris/classes/sun/awt/motif/MEmbeddedFrame.java - src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java - src/solaris/classes/sun/awt/motif/MFileDialogPeer.java - src/solaris/classes/sun/awt/motif/MFramePeer.java - src/solaris/classes/sun/awt/motif/MGlobalCursorManager.java - src/solaris/classes/sun/awt/motif/MInputMethod.java - src/solaris/classes/sun/awt/motif/MInputMethodControl.java - src/solaris/classes/sun/awt/motif/MInputMethodDescriptor.java - src/solaris/classes/sun/awt/motif/MLabelPeer.java - src/solaris/classes/sun/awt/motif/MListPeer.java - src/solaris/classes/sun/awt/motif/MMenuBarPeer.java - src/solaris/classes/sun/awt/motif/MMenuItemPeer.java - src/solaris/classes/sun/awt/motif/MMenuPeer.java - src/solaris/classes/sun/awt/motif/MMouseDragGestureRecognizer.java - src/solaris/classes/sun/awt/motif/MPanelPeer.java - src/solaris/classes/sun/awt/motif/MPopupMenuPeer.java - src/solaris/classes/sun/awt/motif/MRobotPeer.java - src/solaris/classes/sun/awt/motif/MScrollPanePeer.java - src/solaris/classes/sun/awt/motif/MScrollbarPeer.java - src/solaris/classes/sun/awt/motif/MTextAreaPeer.java - src/solaris/classes/sun/awt/motif/MTextFieldPeer.java - src/solaris/classes/sun/awt/motif/MWindowPeer.java - src/solaris/classes/sun/awt/motif/X11Clipboard.java - src/solaris/classes/sun/awt/motif/X11DragSourceContextPeer.java - src/solaris/classes/sun/awt/motif/X11DropTargetContextPeer.java - src/solaris/classes/sun/awt/motif/X11Selection.java - src/solaris/classes/sun/awt/motif/X11SelectionHolder.java - src/solaris/javavm/include/typedefs_md.h - src/solaris/native/sun/awt/awt_Button.c - src/solaris/native/sun/awt/awt_Canvas.c - src/solaris/native/sun/awt/awt_Checkbox.c - src/solaris/native/sun/awt/awt_Choice12.c - src/solaris/native/sun/awt/awt_Choice21.c - src/solaris/native/sun/awt/awt_Component.c - src/solaris/native/sun/awt/awt_Cursor.c - src/solaris/native/sun/awt/awt_DataTransferer.c - src/solaris/native/sun/awt/awt_DataTransferer.h - src/solaris/native/sun/awt/awt_FileDialog.c - src/solaris/native/sun/awt/awt_GlobalCursorManager.c - src/solaris/native/sun/awt/awt_KeyboardFocusManager.c - src/solaris/native/sun/awt/awt_Label.c - src/solaris/native/sun/awt/awt_List.c - src/solaris/native/sun/awt/awt_Menu.c - src/solaris/native/sun/awt/awt_Menu.h - src/solaris/native/sun/awt/awt_MenuBar.c - src/solaris/native/sun/awt/awt_MenuBar.h - src/solaris/native/sun/awt/awt_MenuComponent.c - src/solaris/native/sun/awt/awt_MenuItem.c - src/solaris/native/sun/awt/awt_PopupMenu.c - src/solaris/native/sun/awt/awt_ScrollPane.c - src/solaris/native/sun/awt/awt_Scrollbar.c - src/solaris/native/sun/awt/awt_Selection.c - src/solaris/native/sun/awt/awt_TextArea.c - src/solaris/native/sun/awt/awt_TextArea.h - src/solaris/native/sun/awt/awt_TextField.c - src/solaris/native/sun/awt/awt_TextField.h - src/solaris/native/sun/awt/awt_TopLevel.c - src/solaris/native/sun/awt/awt_XmDnD.c - src/solaris/native/sun/awt/awt_XmDnD.h - src/solaris/native/sun/awt/awt_dnd.c - src/solaris/native/sun/awt/awt_dnd.h - src/solaris/native/sun/awt/awt_dnd_ds.c - src/solaris/native/sun/awt/awt_dnd_dt.c - src/solaris/native/sun/awt/awt_motif.c - src/solaris/native/sun/awt/awt_motif12.c - src/solaris/native/sun/awt/awt_motif21.c - src/solaris/native/sun/awt/awt_xembed.c - src/solaris/native/sun/awt/canvas.c - src/solaris/native/sun/awt/cursor.c - src/windows/javavm/include/typedefs_md.h - test/javax/swing/JFileChooser/4252173/bug4252173.java - test/javax/swing/JFileChooser/6524424/bug6524424.html - test/javax/swing/JFileChooser/6524424/bug6524424.java - test/sun/net/www/http/ChunkedInputStream/test.txt - test/tools/launcher/Arrrghs.sh Changeset: 452c58b2f533 Author: tdv Date: 2008-10-21 08:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/452c58b2f533 6755274: 6u10b33 2d tests fails on sles10x64 with jvm crash Reviewed-by: campbell ! src/solaris/classes/sun/java2d/opengl/GLXGraphicsConfig.java ! src/windows/classes/sun/java2d/opengl/WGLGraphicsConfig.java Changeset: c739feb28074 Author: prr Date: 2008-10-28 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c739feb28074 6764543: SIGSEGV in libfontconfig.so starting from jdk7b33 Reviewed-by: campbell, igor ! src/solaris/native/sun/awt/fontpath.c Changeset: 594c52582b21 Author: tdv Date: 2008-10-28 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/594c52582b21 6764257: D3D/OGL: color is not reset properly after save/restoreState() [RSL] Reviewed-by: campbell ! src/share/classes/sun/java2d/pipe/BufferedContext.java + test/sun/java2d/pipe/hw/RSLContextInvalidationTest/RSLContextInvalidationTest.java Changeset: 9cdababf6179 Author: igor Date: 2008-10-29 01:52 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9cdababf6179 6761856: OpenJDK: vertical text metrics may be significanly different from those returned by Sun JDK Reviewed-by: bae, prr ! src/share/native/sun/font/freetypeScaler.c ! test/java/awt/font/TextLayout/TextLayoutBounds.java Changeset: 3a9d06af8830 Author: bae Date: 2008-11-01 20:42 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3a9d06af8830 6541476: PNG imageio plugin incorrectly handles iTXt chunk Reviewed-by: igor, prr ! src/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java ! src/share/classes/com/sun/imageio/plugins/png/PNGImageWriter.java ! src/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java + test/javax/imageio/plugins/png/ITXtTest.java Changeset: 8eb24fc88242 Author: tdv Date: 2008-11-18 17:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8eb24fc88242 6758179: D3D: AlphaComposite is applied incorrectly for uncached opaque BufferedImage Reviewed-by: campbell, flar ! src/windows/native/sun/java2d/d3d/D3DBlitLoops.cpp + test/sun/java2d/DirectX/OpaqueImageToSurfaceBlitTest/OpaqueImageToSurfaceBlitTest.java Changeset: 3fea7e660a8f Author: tdv Date: 2008-11-18 18:32 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3fea7e660a8f 6757527: D3D: serious rendering issues on Nvidia boards with driver version 178.13 on Vista Reviewed-by: campbell ! src/windows/native/sun/java2d/d3d/D3DBlitLoops.cpp ! src/windows/native/sun/java2d/d3d/D3DContext.cpp Changeset: be363ea85cb4 Author: jgodinez Date: 2008-11-25 14:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/be363ea85cb4 6653384: Variable "initialized" in class CUPSPrinter is static by mistake Reviewed-by: tdv, prr ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/solaris/classes/sun/print/IPPPrintService.java + test/java/awt/print/PrinterJob/GetMediasTest.java Changeset: c8eea39734e8 Author: jgodinez Date: 2008-12-04 10:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c8eea39734e8 6587245: Import declaration not used in sun.print.* Reviewed-by: tdv, prr ! src/share/classes/javax/print/Doc.java ! src/share/classes/javax/print/DocFlavor.java ! src/share/classes/javax/print/DocPrintJob.java ! src/share/classes/javax/print/MultiDocPrintService.java ! src/share/classes/javax/print/PrintServiceLookup.java ! src/share/classes/javax/print/attribute/URISyntax.java ! src/share/classes/javax/print/event/PrintServiceAttributeEvent.java ! src/share/classes/sun/print/PSPathGraphics.java ! src/share/classes/sun/print/PrintJobAttributeException.java ! src/share/classes/sun/print/SunMinMaxPage.java ! src/share/classes/sun/print/SunPageSelection.java Changeset: 15435c60c751 Author: tdv Date: 2008-12-04 11:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15435c60c751 6708580: Java applications slow when EXA enabled Reviewed-by: prr, tdv Contributed-by: ceisserer ! make/sun/awt/mapfile-mawt-vers ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/java2d/x11/X11SurfaceData.java ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c Changeset: b0c446712fae Author: jgodinez Date: 2008-12-08 10:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b0c446712fae 6665212: PrinterJob class, method lookupStreamPrintServices(), "fos" in docs is unknown Reviewed-by: tdv, prr ! src/share/classes/java/awt/print/PrinterJob.java Changeset: b163d898f83f Author: tdv Date: 2008-12-08 17:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b163d898f83f 6772137: D3D: Dragging the scroll bar of a JScrollPane containing a JTree causes incorrect red Reviewed-by: campbell ! src/windows/native/sun/java2d/d3d/D3DBadHardware.h Changeset: bf5dd3128c6a Author: lana Date: 2008-12-08 19:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf5dd3128c6a Merge Changeset: 50c67678b0d1 Author: lana Date: 2009-01-06 16:24 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/50c67678b0d1 Merge ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: 37a9442e3203 Author: tbell Date: 2009-01-09 21:54 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/37a9442e3203 Merge Changeset: 5c39d920b488 Author: tbell Date: 2009-01-09 22:01 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5c39d920b488 Merge From maurizio.cimadamore at sun.com Tue Jan 13 13:51:59 2009 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Tue, 13 Jan 2009 13:51:59 +0000 Subject: hg: jdk7/tl/langtools: 4 new changesets Message-ID: <20090113135206.4AD4FD512@hg.openjdk.java.net> Changeset: 905e151a185a Author: mcimadamore Date: 2009-01-13 13:27 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/905e151a185a 6765045: Remove rawtypes warnings from langtools Summary: Removed all occurrences of rawtypes warnings from langtools Reviewed-by: jjg, bpatel ! make/build.properties ! src/share/classes/com/sun/source/util/Trees.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/Constants.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/javac/Main.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Pair.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javah/Gen.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/sun/tools/javap/FieldData.java ! src/share/classes/sun/tools/javap/JavapPrinter.java ! src/share/classes/sun/tools/javap/MethodData.java Changeset: d57378c34fdb Author: mcimadamore Date: 2009-01-13 13:28 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d57378c34fdb 6665356: Cast not allowed when both qualifying type and inner class are parameterized Summary: Fixed parser and cats conversion in order to allow cast between generic inner classes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/cast/6665356/T6665356.java + test/tools/javac/cast/6665356/T6665356.out + test/tools/javac/generics/rare/6665356/T6665356.java + test/tools/javac/generics/rare/6665356/T6665356.out Changeset: 09eb1acc9610 Author: mcimadamore Date: 2009-01-13 13:28 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/09eb1acc9610 6723444: javac fails to substitute type variables into a constructor's throws clause Summary: Added constructor's actual type info to NewClass AST node Reviewed-by: jjg Contributed-by: mark at twistedbanana.demon.co.uk ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/generics/6723444/T6723444.java + test/tools/javac/generics/6723444/T6723444.out Changeset: e157bd68dfc5 Author: mcimadamore Date: 2009-01-13 13:31 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e157bd68dfc5 6558559: Extra "unchecked" diagnostic Summary: Fixed Types.sideCast in order to suppress redundant unchecked warnings Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6558559/T6558559a.java + test/tools/javac/cast/6558559/T6558559b.java From xueming.shen at sun.com Tue Jan 13 17:28:28 2009 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Tue, 13 Jan 2009 17:28:28 +0000 Subject: hg: jdk7/tl/jdk: 6332094: "jar t" and "jar x" should use ZipFile, not ZipInputStream Message-ID: <20090113172841.E4D26D577@hg.openjdk.java.net> Changeset: 13d7e2477737 Author: sherman Date: 2009-01-13 09:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/13d7e2477737 6332094: "jar t" and "jar x" should use ZipFile, not ZipInputStream Summary: To use ZipFile for jar "t" and "x" to boost performance Reviewed-by: martin, alanb ! src/share/classes/sun/tools/jar/Main.java From christopher.hegarty at sun.com Wed Jan 14 17:24:36 2009 From: christopher.hegarty at sun.com (christopher.hegarty at sun.com) Date: Wed, 14 Jan 2009 17:24:36 +0000 Subject: hg: jdk7/tl/jdk: 6755782: It is not clear how DatagramSocket deals with broadcast enabling/disabling Message-ID: <20090114172458.6F58DD680@hg.openjdk.java.net> Changeset: 8c1c6e11204b Author: chegar Date: 2009-01-14 17:17 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c1c6e11204b 6755782: It is not clear how DatagramSocket deals with broadcast enabling/disabling Reviewed-by: jccollet ! src/share/classes/java/net/DatagramSocket.java From joe.darcy at sun.com Thu Jan 15 00:36:03 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 15 Jan 2009 00:36:03 +0000 Subject: hg: jdk7/tl/jdk: 6792545: Typo in java.util.Collection JavaDoc; ... Message-ID: <20090115003622.488A2D7D7@hg.openjdk.java.net> Changeset: 7f6969c09075 Author: darcy Date: 2009-01-14 16:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7f6969c09075 6792545: Typo in java.util.Collection JavaDoc 6655123: Incorrect ref to The Art of Computer Programming in doc for java.util.Random Summary: Fix a pair of typos. Reviewed-by: jjg ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/Random.java From jonathan.gibbons at sun.com Fri Jan 16 02:08:48 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 16 Jan 2009 02:08:48 +0000 Subject: hg: jdk7/tl/langtools: 6794520: MessageRetriever should be upgraded to use varargs Object... Message-ID: <20090116020850.70F42D9B4@hg.openjdk.java.net> Changeset: 42f9d392159d Author: jjg Date: 2009-01-15 18:06 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/42f9d392159d 6794520: MessageRetriever should be upgraded to use varargs Object... Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java From martinrb at google.com Fri Jan 16 02:13:05 2009 From: martinrb at google.com (Martin Buchholz) Date: Thu, 15 Jan 2009 18:13:05 -0800 Subject: Remove synchronization bottlenecks in Logger Message-ID: <1ccfd1c10901151813u5dc69cc8g9211019f9998b2e2@mail.gmail.com> Hi java.util.logging maintainers, (Will this get Serguei or Graham to come out of retirement?! Maybe not.) Description: The removal of unnecessary optimization below (replacing synchronized with j.u.c. or volatile replacements) made a big difference in one of our local applications with many concurrently logging threads. As well, making levelObject volatile slightly improves the thread-safety of Logger. Fix written by Jeremy Manson and reviewed by Bill Pugh (both of JSR-133 fame), and by myself. There are further concurrency improvements that can be made to this code, but we are not that ambitious. # HG changeset patch # User martin # Date 1232071338 28800 # Node ID 7ac6b44ba1709d554282cc16b5b8b2c613bc1079 # Parent 7f6969c090750e1d389a93c3a657b60426d3d593 6666666: Remove synchronization bottlenecks in Logger Reviewed-by: xxxxx Contributed-by: jeremymanson at google.com diff --git a/src/share/classes/java/util/logging/Logger.java b/src/share/classes/java/util/logging/Logger.java --- a/src/share/classes/java/util/logging/Logger.java +++ b/src/share/classes/java/util/logging/Logger.java @@ -27,6 +27,7 @@ package java.util.logging; import java.util.*; +import java.util.concurrent.CopyOnWriteArrayList; import java.security.*; import java.lang.ref.WeakReference; @@ -165,10 +166,11 @@ private static final int offValue = Level.OFF.intValue(); private LogManager manager; private String name; - private ArrayList handlers; + private final CopyOnWriteArrayList handlers = + new CopyOnWriteArrayList(); private String resourceBundleName; - private boolean useParentHandlers = true; - private Filter filter; + private volatile boolean useParentHandlers = true; + private volatile Filter filter; private boolean anonymous; private ResourceBundle catalog; // Cached resource bundle @@ -180,9 +182,9 @@ private static Object treeLock = new Object(); // We keep weak references from parents to children, but strong // references from children to parents. - private Logger parent; // our nearest parent. + private volatile Logger parent; // our nearest parent. private ArrayList> kids; // WeakReferences to loggers that have us as parent - private Level levelObject; + private volatile Level levelObject; private volatile int levelValue; // current effective level value /** @@ -438,7 +440,7 @@ * @exception SecurityException if a security manager exists and if * the caller does not have LoggingPermission("control"). */ - public synchronized void setFilter(Filter newFilter) throws SecurityException { + public void setFilter(Filter newFilter) throws SecurityException { checkAccess(); filter = newFilter; } @@ -448,7 +450,7 @@ * * @return a filter object (may be null) */ - public synchronized Filter getFilter() { + public Filter getFilter() { return filter; } @@ -465,10 +467,9 @@ if (record.getLevel().intValue() < levelValue || levelValue == offValue) { return; } - synchronized (this) { - if (filter != null && !filter.isLoggable(record)) { - return; - } + Filter theFilter = filter; + if (theFilter != null && !theFilter.isLoggable(record)) { + return; } // Post the LogRecord to all our Handlers, and then to @@ -1182,13 +1183,10 @@ * @exception SecurityException if a security manager exists and if * the caller does not have LoggingPermission("control"). */ - public synchronized void addHandler(Handler handler) throws SecurityException { + public void addHandler(Handler handler) throws SecurityException { // Check for null handler handler.getClass(); checkAccess(); - if (handlers == null) { - handlers = new ArrayList(); - } handlers.add(handler); } @@ -1201,12 +1199,9 @@ * @exception SecurityException if a security manager exists and if * the caller does not have LoggingPermission("control"). */ - public synchronized void removeHandler(Handler handler) throws SecurityException { + public void removeHandler(Handler handler) throws SecurityException { checkAccess(); if (handler == null) { - return; - } - if (handlers == null) { return; } handlers.remove(handler); @@ -1217,11 +1212,8 @@ *

* @return an array of all registered Handlers */ - public synchronized Handler[] getHandlers() { - if (handlers == null) { - return emptyHandlers; - } - return handlers.toArray(new Handler[handlers.size()]); + public Handler[] getHandlers() { + return handlers.toArray(emptyHandlers); } /** @@ -1235,7 +1227,7 @@ * @exception SecurityException if a security manager exists and if * the caller does not have LoggingPermission("control"). */ - public synchronized void setUseParentHandlers(boolean useParentHandlers) { + public void setUseParentHandlers(boolean useParentHandlers) { checkAccess(); this.useParentHandlers = useParentHandlers; } @@ -1246,7 +1238,7 @@ * * @return true if output is to be sent to the logger's parent */ - public synchronized boolean getUseParentHandlers() { + public boolean getUseParentHandlers() { return useParentHandlers; } @@ -1354,9 +1346,12 @@ * @return nearest existing parent Logger */ public Logger getParent() { - synchronized (treeLock) { - return parent; - } + // Note: this used to be synchronized on treeLock. However, this only + // provided memory semantics, as there was no guarantee that the caller + // would synchronize on treeLock (in fact, there is no way for external + // callers to so synchronize. Therefore, we have made parent volatile + // instead. + return parent; } /** From bhavesh.patel at sun.com Fri Jan 16 01:24:43 2009 From: bhavesh.patel at sun.com (bhavesh.patel at sun.com) Date: Fri, 16 Jan 2009 01:24:43 +0000 Subject: hg: jdk7/tl/langtools: 6786682: Javadoc HTML WCAG 2.0 accessibility issues in standard doclet - HTML tag should have lang attribute Message-ID: <20090116012445.33DEDD9AF@hg.openjdk.java.net> Changeset: d79ad96ce47c Author: bpatel Date: 2009-01-15 17:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d79ad96ce47c 6786682: Javadoc HTML WCAG 2.0 accessibility issues in standard doclet - HTML tag should have lang attribute Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java + test/com/sun/javadoc/testHtmlTag/TestHtmlTag.java + test/com/sun/javadoc/testHtmlTag/pkg1/C1.java + test/com/sun/javadoc/testHtmlTag/pkg2/C2.java From joe.darcy at sun.com Fri Jan 16 22:09:36 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 16 Jan 2009 22:09:36 +0000 Subject: hg: jdk7/tl/langtools: 6583626: Improve serialization support in javax.lang.model.type exception classes Message-ID: <20090116220940.4F455DB20@hg.openjdk.java.net> Changeset: 18c433be7aa7 Author: darcy Date: 2009-01-16 14:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/18c433be7aa7 6583626: Improve serialization support in javax.lang.model.type exception classes Reviewed-by: jjg ! src/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/share/classes/javax/lang/model/type/MirroredTypesException.java From Alan.Bateman at Sun.COM Sun Jan 18 18:05:06 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Sun, 18 Jan 2009 18:05:06 +0000 Subject: Remove synchronization bottlenecks in Logger In-Reply-To: <1ccfd1c10901151813u5dc69cc8g9211019f9998b2e2@mail.gmail.com> References: <1ccfd1c10901151813u5dc69cc8g9211019f9998b2e2@mail.gmail.com> Message-ID: <49736F52.6080704@sun.com> Martin Buchholz wrote: > Hi java.util.logging maintainers, > > : > I forwarded this to Swamy as he wasn't on core-libs-dev and so missed your mail. -Alan. From weijun.wang at sun.com Mon Jan 19 10:52:55 2009 From: weijun.wang at sun.com (weijun.wang at sun.com) Date: Mon, 19 Jan 2009 10:52:55 +0000 Subject: hg: jdk7/tl/jdk: 6793475: krb5.ini not found on some Windows Message-ID: <20090119105314.6715ADBC8@hg.openjdk.java.net> Changeset: 9260d9bd0843 Author: weijun Date: 2009-01-19 18:49 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9260d9bd0843 6793475: krb5.ini not found on some Windows Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/Config.java ! src/windows/native/sun/security/krb5/WindowsDirectory.c From jonathan.gibbons at sun.com Tue Jan 20 03:40:51 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 20 Jan 2009 03:40:51 +0000 Subject: hg: jdk7/tl/langtools: 6794959: add new switch -XDexpectKeys=key, key.... Message-ID: <20090120034055.CB0FDDBD6@hg.openjdk.java.net> Changeset: d0b33fe8e710 Author: jjg Date: 2009-01-19 19:36 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d0b33fe8e710 6794959: add new switch -XDexpectKeys=key,key.... Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/T6794959.java From maurizio.cimadamore at sun.com Tue Jan 20 18:00:21 2009 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Tue, 20 Jan 2009 18:00:21 +0000 Subject: hg: jdk7/tl/langtools: 2 new changesets Message-ID: <20090120180024.C24F2DC49@hg.openjdk.java.net> Changeset: 83c59a9d4b94 Author: mcimadamore Date: 2009-01-20 17:49 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/83c59a9d4b94 6795580: parser confused by square brackets in qualified generic cast Summary: Parser rejects cast with qualified generic array types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/cast/6795580/T6795580.java + test/tools/javac/cast/6795580/T6795580.out Changeset: 1ca2dc8584e1 Author: mcimadamore Date: 2009-01-20 17:49 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1ca2dc8584e1 6557199: Fails to reject bad override of generic method Summary: Javac does not correctly implement JLS3 8.4.5 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/rawOverride/6557199/T6557199.java + test/tools/javac/generics/rawOverride/6557199/T6557199.out From jonathan.gibbons at sun.com Tue Jan 20 23:20:09 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Tue, 20 Jan 2009 23:20:09 +0000 Subject: hg: jdk7/tl/langtools: 6794582: javadoc should read files using a FileManager Message-ID: <20090120232010.E379CDC98@hg.openjdk.java.net> Changeset: 1bf037016426 Author: jjg Date: 2009-01-20 15:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1bf037016426 6794582: javadoc should read files using a FileManager Reviewed-by: darcy, bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! src/share/classes/com/sun/tools/javadoc/SourcePositionImpl.java From mandy.chung at sun.com Wed Jan 21 00:19:27 2009 From: mandy.chung at sun.com (mandy.chung at sun.com) Date: Wed, 21 Jan 2009 00:19:27 +0000 Subject: hg: jdk7/tl/jdk: 3 new changesets Message-ID: <20090121002002.59213DCB1@hg.openjdk.java.net> Changeset: 1f751a9f7052 Author: mchung Date: 2009-01-20 13:02 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f751a9f7052 6793429: Use compiled properties instead of plain properties for resource file Summary: Rename the variables in Resources.gmk to make compiled properties more explicit Reviewed-by: naoto, yhuang ! make/com/sun/org/apache/xml/Makefile ! make/com/sun/rowset/Makefile ! make/common/internal/Resources.gmk ! make/sun/launcher/Makefile ! make/sun/rmi/oldtools/Makefile ! make/sun/rmi/registry/Makefile ! make/sun/rmi/rmic/Makefile ! make/sun/rmi/rmid/Makefile ! make/sun/serialver/Makefile Changeset: 42f8dea1b865 Author: mchung Date: 2009-01-20 13:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/42f8dea1b865 6769976: (fc) FileChannelImpl.isAMappedBufferField not used Summary: Remove the FileChannelImpl.isAMappedBufferField field Reviewed-by: alanb ! src/share/classes/sun/nio/ch/FileChannelImpl.java Changeset: 7fa0a7a3c080 Author: mchung Date: 2009-01-20 16:16 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7fa0a7a3c080 Merge From jonathan.gibbons at sun.com Wed Jan 21 02:25:36 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 21 Jan 2009 02:25:36 +0000 Subject: hg: jdk7/tl/langtools: 6795903: fix latent build warnings in langtools repository Message-ID: <20090121022537.E20D5DCC5@hg.openjdk.java.net> Changeset: b4b1f7732289 Author: jjg Date: 2009-01-20 18:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/b4b1f7732289 6795903: fix latent build warnings in langtools repository Reviewed-by: darcy ! make/build.properties ! src/share/classes/com/sun/tools/apt/comp/AnnotationProcessingError.java ! src/share/classes/com/sun/tools/apt/comp/Apt.java ! src/share/classes/com/sun/tools/apt/comp/UsageMessageNeededException.java ! src/share/classes/com/sun/tools/apt/main/JavaCompiler.java ! src/share/classes/com/sun/tools/apt/mirror/apt/RoundCompleteEventImpl.java ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/apt/mirror/type/TypeVariableImpl.java ! src/share/classes/com/sun/tools/classfile/Annotation.java ! src/share/classes/com/sun/tools/classfile/AttributeException.java ! src/share/classes/com/sun/tools/classfile/Code_attribute.java ! src/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/share/classes/com/sun/tools/classfile/ConstantPoolException.java ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/classfile/DescriptorException.java ! src/share/classes/com/sun/tools/classfile/StackMapTable_attribute.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletAbortException.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javah/Gen.java ! src/share/classes/com/sun/tools/javap/InternalError.java ! src/share/classes/sun/tools/javap/JavapPrinter.java From jonathan.gibbons at sun.com Wed Jan 21 16:24:45 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 21 Jan 2009 16:24:45 +0000 Subject: hg: jdk7/tl/langtools: 6795030: Files in langtools build can be compiled ignoring java.home settings Message-ID: <20090121162446.EC2FBDCD8@hg.openjdk.java.net> Changeset: d486ac6389d7 Author: jjg Date: 2009-01-21 08:21 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d486ac6389d7 6795030: Files in langtools build can be compiled ignoring java.home settings Reviewed-by: mcimadamore ! make/build.xml From jonathan.gibbons at sun.com Thu Jan 22 23:48:22 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Thu, 22 Jan 2009 23:48:22 +0000 Subject: hg: jdk7/tl/langtools: 6796965: dev-time wrapper script for javac broken Message-ID: <20090122234824.2F7F4DE54@hg.openjdk.java.net> Changeset: e6dafbf35355 Author: jjg Date: 2009-01-22 15:45 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e6dafbf35355 6796965: dev-time wrapper script for javac broken Reviewed-by: ksrini ! make/build.xml From xueming.shen at sun.com Fri Jan 23 04:46:35 2009 From: xueming.shen at sun.com (xueming.shen at sun.com) Date: Fri, 23 Jan 2009 04:46:35 +0000 Subject: hg: jdk7/tl/jdk: 6476425: (fmt)java.util.Formatter.print() throws IllegalArgumentException on large BigDecima Message-ID: <20090123044647.9C0DEDED5@hg.openjdk.java.net> Changeset: 63f8707112be Author: sherman Date: 2009-01-22 20:29 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63f8707112be 6476425: (fmt)java.util.Formatter.print() throws IllegalArgumentException on large BigDecima Summary: Correct the wrong calculation of "precision" in certain circumstances. Reviewed-by: darcy, alanb ! src/share/classes/java/util/Formatter.java ! test/java/util/Formatter/Basic-X.java ! test/java/util/Formatter/Basic.java ! test/java/util/Formatter/BasicBigDecimal.java ! test/java/util/Formatter/BasicBigInteger.java ! test/java/util/Formatter/BasicBoolean.java ! test/java/util/Formatter/BasicBooleanObject.java ! test/java/util/Formatter/BasicByte.java ! test/java/util/Formatter/BasicByteObject.java ! test/java/util/Formatter/BasicChar.java ! test/java/util/Formatter/BasicCharObject.java ! test/java/util/Formatter/BasicDateTime.java ! test/java/util/Formatter/BasicDouble.java ! test/java/util/Formatter/BasicDoubleObject.java ! test/java/util/Formatter/BasicFloat.java ! test/java/util/Formatter/BasicFloatObject.java ! test/java/util/Formatter/BasicInt.java ! test/java/util/Formatter/BasicIntObject.java ! test/java/util/Formatter/BasicLong.java ! test/java/util/Formatter/BasicLongObject.java ! test/java/util/Formatter/BasicShort.java ! test/java/util/Formatter/BasicShortObject.java ! test/java/util/Formatter/genBasic.sh From joe.darcy at sun.com Fri Jan 23 18:44:15 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 23 Jan 2009 18:44:15 +0000 Subject: hg: jdk7/tl/jdk: 6604864: Double.valueOf(String) does not specify behaviour for overflow and underflow Message-ID: <20090123184427.3B322E005@hg.openjdk.java.net> Changeset: cb641d17bbb3 Author: darcy Date: 2009-01-23 10:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb641d17bbb3 6604864: Double.valueOf(String) does not specify behaviour for overflow and underflow Reviewed-by: emcmanus ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java From jonathan.gibbons at sun.com Fri Jan 23 19:25:42 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Fri, 23 Jan 2009 19:25:42 +0000 Subject: hg: jdk7/tl/langtools: 6795365: NetBeans projects in langtools repository are not NB6.5-friendly Message-ID: <20090123192544.3BCE2E00A@hg.openjdk.java.net> Changeset: e3930187199c Author: jjg Date: 2009-01-23 11:23 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e3930187199c 6795365: NetBeans projects in langtools repository are not NB6.5-friendly Reviewed-by: mcimadamore ! make/README ! make/build.xml ! make/netbeans/README - make/netbeans/apt/README - make/netbeans/apt/build.xml - make/netbeans/apt/nbproject/project.xml - make/netbeans/common/shared.xml - make/netbeans/common/standard-context-menu-items-no-javadoc.ent - make/netbeans/common/standard-context-menu-items.ent - make/netbeans/common/standard-ide-actions-no-javadoc.ent - make/netbeans/common/standard-ide-actions.ent - make/netbeans/compiler/README - make/netbeans/compiler/build.xml - make/netbeans/compiler/nbproject/project.xml - make/netbeans/doclets/README - make/netbeans/doclets/build.xml - make/netbeans/doclets/nbproject/project.xml - make/netbeans/javadoc/README - make/netbeans/javadoc/build.xml - make/netbeans/javadoc/nbproject/project.xml - make/netbeans/javah/README - make/netbeans/javah/build.xml - make/netbeans/javah/nbproject/project.xml - make/netbeans/javap/README - make/netbeans/javap/build.xml - make/netbeans/javap/nbproject/project.xml + make/netbeans/langtools/build.xml + make/netbeans/langtools/nbproject/project.xml + make/netbeans/langtools/nbproject/standard-context-menu-items.ent + make/netbeans/langtools/nbproject/standard-ide-actions.ent + make/tools/SelectTool/SelectToolTask.java From tim.bell at sun.com Sat Jan 24 23:18:51 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Sat, 24 Jan 2009 23:18:51 +0000 Subject: hg: jdk7/tl/langtools: 6797463: 6557199 breaks the jax-ws workspace Message-ID: <20090124231853.5D997E085@hg.openjdk.java.net> Changeset: 3b2c55b7bd01 Author: tbell Date: 2009-01-24 11:07 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/3b2c55b7bd01 6797463: 6557199 breaks the jax-ws workspace Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java From tim.bell at sun.com Mon Jan 26 00:36:16 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 26 Jan 2009 00:36:16 +0000 Subject: hg: jdk7/tl: 2 new changesets Message-ID: <20090126003616.51F4AE11C@hg.openjdk.java.net> Changeset: a395e3aac474 Author: xdono Date: 2009-01-15 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/a395e3aac474 Added tag jdk7-b43 for changeset 848e684279d2 ! .hgtags Changeset: 99846f001ca2 Author: xdono Date: 2009-01-22 14:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/99846f001ca2 Added tag jdk7-b44 for changeset a395e3aac474 ! .hgtags From tim.bell at sun.com Mon Jan 26 00:38:32 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 26 Jan 2009 00:38:32 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20090126003833.F33C1E121@hg.openjdk.java.net> Changeset: 9803dac72540 Author: xdono Date: 2009-01-15 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/9803dac72540 Added tag jdk7-b43 for changeset 9cd740d48a48 ! .hgtags Changeset: 68814aa5b44b Author: xdono Date: 2009-01-22 14:41 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/68814aa5b44b Added tag jdk7-b44 for changeset 9803dac72540 ! .hgtags From tim.bell at sun.com Mon Jan 26 00:42:05 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 26 Jan 2009 00:42:05 +0000 Subject: hg: jdk7/tl/hotspot: 2 new changesets Message-ID: <20090126004209.0EFE4E126@hg.openjdk.java.net> Changeset: 809e899c638b Author: xdono Date: 2009-01-15 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/809e899c638b Added tag jdk7-b43 for changeset fc6a5ae3fef5 ! .hgtags Changeset: 945bf7540697 Author: xdono Date: 2009-01-22 14:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/945bf7540697 Added tag jdk7-b44 for changeset 809e899c638b ! .hgtags From tim.bell at sun.com Mon Jan 26 00:47:04 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 26 Jan 2009 00:47:04 +0000 Subject: hg: jdk7/tl/jaxp: 2 new changesets Message-ID: <20090126004707.4A5A8E12B@hg.openjdk.java.net> Changeset: b203df0741af Author: xdono Date: 2009-01-15 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/b203df0741af Added tag jdk7-b43 for changeset 96fe28d4a913 ! .hgtags Changeset: 0f113667880d Author: xdono Date: 2009-01-22 14:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/0f113667880d Added tag jdk7-b44 for changeset b203df0741af ! .hgtags From tim.bell at sun.com Mon Jan 26 00:49:23 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 26 Jan 2009 00:49:23 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20090126004926.36796E130@hg.openjdk.java.net> Changeset: 344485a03674 Author: xdono Date: 2009-01-15 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/344485a03674 Added tag jdk7-b43 for changeset 1ad2f51564db ! .hgtags Changeset: dea7753d7139 Author: xdono Date: 2009-01-22 14:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/dea7753d7139 Added tag jdk7-b44 for changeset 344485a03674 ! .hgtags From tim.bell at sun.com Mon Jan 26 00:52:13 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 26 Jan 2009 00:52:13 +0000 Subject: hg: jdk7/tl/jdk: 6 new changesets Message-ID: <20090126005322.18B76E135@hg.openjdk.java.net> Changeset: 8dcc06d43798 Author: xdono Date: 2009-01-15 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8dcc06d43798 Added tag jdk7-b43 for changeset 50c67678b0d1 ! .hgtags Changeset: 4dab1a24dca2 Author: tbell Date: 2009-01-16 10:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4dab1a24dca2 Merge Changeset: 6dce6ac0929e Author: tbell Date: 2009-01-14 21:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6dce6ac0929e 6754862: jdk/src/windows/bin/java_md.c: hardcoded reference to msvcr71.dll 6779412: VS2008 errors compiling jdk sources Summary: Update Makefiles to tolerate newer Visual Studio releases and runtimes. Reviewed-by: ohair ! make/com/sun/java/pack/Makefile ! make/common/Defs-windows.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! make/java/redist/Makefile ! src/share/bin/main.c ! src/windows/bin/java_md.c Changeset: d8eb2738db6b Author: xdono Date: 2009-01-20 09:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d8eb2738db6b Merge - src/share/classes/sun/nio/cs/IBM437.java - src/share/classes/sun/nio/cs/IBM737.java - src/share/classes/sun/nio/cs/IBM775.java - src/share/classes/sun/nio/cs/IBM850.java - src/share/classes/sun/nio/cs/IBM852.java - src/share/classes/sun/nio/cs/IBM855.java - src/share/classes/sun/nio/cs/IBM857.java - src/share/classes/sun/nio/cs/IBM858.java - src/share/classes/sun/nio/cs/IBM862.java - src/share/classes/sun/nio/cs/IBM866.java - src/share/classes/sun/nio/cs/IBM874.java - src/share/classes/sun/nio/cs/ISO_8859_13.java - src/share/classes/sun/nio/cs/ISO_8859_15.java - src/share/classes/sun/nio/cs/ISO_8859_2.java - src/share/classes/sun/nio/cs/ISO_8859_4.java - src/share/classes/sun/nio/cs/ISO_8859_5.java - src/share/classes/sun/nio/cs/ISO_8859_7.java - src/share/classes/sun/nio/cs/ISO_8859_9.java - src/share/classes/sun/nio/cs/KOI8_R.java - src/share/classes/sun/nio/cs/KOI8_U.java - src/share/classes/sun/nio/cs/MS1250.java - src/share/classes/sun/nio/cs/MS1251.java - src/share/classes/sun/nio/cs/MS1252.java - src/share/classes/sun/nio/cs/MS1253.java - src/share/classes/sun/nio/cs/MS1254.java - src/share/classes/sun/nio/cs/MS1257.java - src/share/classes/sun/nio/cs/ext/IBM037.java - src/share/classes/sun/nio/cs/ext/IBM1006.java - src/share/classes/sun/nio/cs/ext/IBM1025.java - src/share/classes/sun/nio/cs/ext/IBM1026.java - src/share/classes/sun/nio/cs/ext/IBM1046.java - src/share/classes/sun/nio/cs/ext/IBM1047.java - src/share/classes/sun/nio/cs/ext/IBM1097.java - src/share/classes/sun/nio/cs/ext/IBM1098.java - src/share/classes/sun/nio/cs/ext/IBM1112.java - src/share/classes/sun/nio/cs/ext/IBM1122.java - src/share/classes/sun/nio/cs/ext/IBM1123.java - src/share/classes/sun/nio/cs/ext/IBM1124.java - src/share/classes/sun/nio/cs/ext/IBM1140.java - src/share/classes/sun/nio/cs/ext/IBM1141.java - src/share/classes/sun/nio/cs/ext/IBM1142.java - src/share/classes/sun/nio/cs/ext/IBM1143.java - src/share/classes/sun/nio/cs/ext/IBM1144.java - src/share/classes/sun/nio/cs/ext/IBM1145.java - src/share/classes/sun/nio/cs/ext/IBM1146.java - src/share/classes/sun/nio/cs/ext/IBM1147.java - src/share/classes/sun/nio/cs/ext/IBM1148.java - src/share/classes/sun/nio/cs/ext/IBM1149.java - src/share/classes/sun/nio/cs/ext/IBM273.java - src/share/classes/sun/nio/cs/ext/IBM277.java - src/share/classes/sun/nio/cs/ext/IBM278.java - src/share/classes/sun/nio/cs/ext/IBM280.java - src/share/classes/sun/nio/cs/ext/IBM284.java - src/share/classes/sun/nio/cs/ext/IBM285.java - src/share/classes/sun/nio/cs/ext/IBM297.java - src/share/classes/sun/nio/cs/ext/IBM420.java - src/share/classes/sun/nio/cs/ext/IBM424.java - src/share/classes/sun/nio/cs/ext/IBM500.java - src/share/classes/sun/nio/cs/ext/IBM838.java - src/share/classes/sun/nio/cs/ext/IBM856.java - src/share/classes/sun/nio/cs/ext/IBM860.java - src/share/classes/sun/nio/cs/ext/IBM861.java - src/share/classes/sun/nio/cs/ext/IBM863.java - src/share/classes/sun/nio/cs/ext/IBM864.java - src/share/classes/sun/nio/cs/ext/IBM865.java - src/share/classes/sun/nio/cs/ext/IBM868.java - src/share/classes/sun/nio/cs/ext/IBM869.java - src/share/classes/sun/nio/cs/ext/IBM870.java - src/share/classes/sun/nio/cs/ext/IBM871.java - src/share/classes/sun/nio/cs/ext/IBM875.java - src/share/classes/sun/nio/cs/ext/IBM918.java - src/share/classes/sun/nio/cs/ext/IBM921.java - src/share/classes/sun/nio/cs/ext/IBM922.java - src/share/classes/sun/nio/cs/ext/ISO_8859_11.java - src/share/classes/sun/nio/cs/ext/ISO_8859_3.java - src/share/classes/sun/nio/cs/ext/ISO_8859_6.java - src/share/classes/sun/nio/cs/ext/ISO_8859_8.java - src/share/classes/sun/nio/cs/ext/MS1255.java - src/share/classes/sun/nio/cs/ext/MS1256.java - src/share/classes/sun/nio/cs/ext/MS1258.java - src/share/classes/sun/nio/cs/ext/MS874.java - src/share/classes/sun/nio/cs/ext/MacArabic.java - src/share/classes/sun/nio/cs/ext/MacCentralEurope.java - src/share/classes/sun/nio/cs/ext/MacCroatian.java - src/share/classes/sun/nio/cs/ext/MacCyrillic.java - src/share/classes/sun/nio/cs/ext/MacDingbat.java - src/share/classes/sun/nio/cs/ext/MacGreek.java - src/share/classes/sun/nio/cs/ext/MacHebrew.java - src/share/classes/sun/nio/cs/ext/MacIceland.java - src/share/classes/sun/nio/cs/ext/MacRoman.java - src/share/classes/sun/nio/cs/ext/MacRomania.java - src/share/classes/sun/nio/cs/ext/MacSymbol.java - src/share/classes/sun/nio/cs/ext/MacThai.java - src/share/classes/sun/nio/cs/ext/MacTurkish.java - src/share/classes/sun/nio/cs/ext/MacUkraine.java - src/share/classes/sun/nio/cs/ext/TIS_620.java Changeset: 527b426497a2 Author: xdono Date: 2009-01-22 14:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/527b426497a2 Added tag jdk7-b44 for changeset d8eb2738db6b ! .hgtags Changeset: 175b6adf65b3 Author: tbell Date: 2009-01-24 16:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/175b6adf65b3 Merge From tim.bell at sun.com Mon Jan 26 00:59:01 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Mon, 26 Jan 2009 00:59:01 +0000 Subject: hg: jdk7/tl/langtools: 4 new changesets Message-ID: <20090126005907.BE732E13A@hg.openjdk.java.net> Changeset: 05b47447cbcf Author: xdono Date: 2009-01-15 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/05b47447cbcf Added tag jdk7-b43 for changeset e2f8f6daee9d ! .hgtags Changeset: 28f0b10d6c1a Author: tbell Date: 2009-01-16 10:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/28f0b10d6c1a Merge Changeset: 30db5e0aaf83 Author: xdono Date: 2009-01-22 14:42 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/30db5e0aaf83 Added tag jdk7-b44 for changeset 28f0b10d6c1a ! .hgtags Changeset: 40fd14d94c3c Author: tbell Date: 2009-01-24 16:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/40fd14d94c3c Merge - make/netbeans/apt/README - make/netbeans/apt/build.xml - make/netbeans/apt/nbproject/project.xml - make/netbeans/common/shared.xml - make/netbeans/common/standard-context-menu-items-no-javadoc.ent - make/netbeans/common/standard-context-menu-items.ent - make/netbeans/common/standard-ide-actions-no-javadoc.ent - make/netbeans/common/standard-ide-actions.ent - make/netbeans/compiler/README - make/netbeans/compiler/build.xml - make/netbeans/compiler/nbproject/project.xml - make/netbeans/doclets/README - make/netbeans/doclets/build.xml - make/netbeans/doclets/nbproject/project.xml - make/netbeans/javadoc/README - make/netbeans/javadoc/build.xml - make/netbeans/javadoc/nbproject/project.xml - make/netbeans/javah/README - make/netbeans/javah/build.xml - make/netbeans/javah/nbproject/project.xml - make/netbeans/javap/README - make/netbeans/javap/build.xml - make/netbeans/javap/nbproject/project.xml From tim.bell at sun.com Tue Jan 27 00:39:34 2009 From: tim.bell at sun.com (tim.bell at sun.com) Date: Tue, 27 Jan 2009 00:39:34 +0000 Subject: hg: jdk7/tl/langtools: 6797871: Fix for 6797463 did not remove the jtreg tests, and it should have Message-ID: <20090127003938.50DC1E1EC@hg.openjdk.java.net> Changeset: 0f922ff6968f Author: tbell Date: 2009-01-26 15:14 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/0f922ff6968f 6797871: Fix for 6797463 did not remove the jtreg tests, and it should have Reviewed-by: jjg - test/tools/javac/generics/rawOverride/6557199/T6557199.java - test/tools/javac/generics/rawOverride/6557199/T6557199.out From joe.darcy at sun.com Tue Jan 27 03:52:20 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Tue, 27 Jan 2009 03:52:20 +0000 Subject: hg: jdk7/tl/jdk: 6601457: Move wrapper class tests from closed to open; ... Message-ID: <20090127035248.4AA83E1F3@hg.openjdk.java.net> Changeset: f3ad2ee4600b Author: darcy Date: 2009-01-26 19:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3ad2ee4600b 6601457: Move wrapper class tests from closed to open 6601458: Move java.math tests from closed to open 6740185: Move java/lang/annotations tests to open 6759433: Move Math and StrictMath regression tests from closed to open Summary: Move some more regression tests to the open Reviewed-by: jjg + test/java/lang/Boolean/Factory.java + test/java/lang/Boolean/GetBoolean.java + test/java/lang/Boolean/MakeBooleanComparable.java + test/java/lang/Boolean/ParseBoolean.java + test/java/lang/Byte/Decode.java + test/java/lang/Double/BitwiseConversion.java + test/java/lang/Double/Constants.java + test/java/lang/Double/Extrema.java + test/java/lang/Double/NaNInfinityParsing.java + test/java/lang/Double/ParseDouble.java + test/java/lang/Double/ParseHexFloatingPoint.java + test/java/lang/Double/ToHexString.java + test/java/lang/Float/BitwiseConversion.java + test/java/lang/Float/Constants.java + test/java/lang/Float/Extrema.java + test/java/lang/Float/NaNInfinityParsing.java + test/java/lang/Float/ParseFloat.java + test/java/lang/Integer/BitTwiddle.java + test/java/lang/Integer/Decode.java + test/java/lang/Integer/GetInteger.java + test/java/lang/Integer/ParsingTest.java + test/java/lang/Long/BitTwiddle.java + test/java/lang/Long/Decode.java + test/java/lang/Long/GetLong.java + test/java/lang/Long/ParsingTest.java + test/java/lang/Math/AbsPositiveZero.java + test/java/lang/Math/Atan2Tests.java + test/java/lang/Math/CubeRootTests.java + test/java/lang/Math/Expm1Tests.java + test/java/lang/Math/HyperbolicTests.java + test/java/lang/Math/HypotTests.java + test/java/lang/Math/IeeeRecommendedTests.java + test/java/lang/Math/Log10Tests.java + test/java/lang/Math/Log1pTests.java + test/java/lang/Math/MinMax.java + test/java/lang/Math/PowTests.java + test/java/lang/Math/Rint.java + test/java/lang/Math/TanTests.java + test/java/lang/Math/Tests.java + test/java/lang/Short/ByteSwap.java + test/java/lang/Short/Decode.java + test/java/lang/StrictMath/CubeRootTests.java + test/java/lang/StrictMath/Expm1Tests.java + test/java/lang/StrictMath/HyperbolicTests.java + test/java/lang/StrictMath/HypotTests.java + test/java/lang/StrictMath/Log10Tests.java + test/java/lang/StrictMath/Log1pTests.java + test/java/lang/StrictMath/Tests.java + test/java/lang/ToString.java + test/java/lang/annotation/AnnotationTypeMismatchException/FoundType.java + test/java/lang/annotation/Missing/A.java + test/java/lang/annotation/Missing/B.java + test/java/lang/annotation/Missing/C.java + test/java/lang/annotation/Missing/D.java + test/java/lang/annotation/Missing/Marker.java + test/java/lang/annotation/Missing/Missing.java + test/java/lang/annotation/Missing/MissingTest.java + test/java/lang/annotation/Missing/MissingWrapper.java + test/java/lang/annotation/PackageMain.java + test/java/lang/annotation/RecursiveAnnotation.java + test/java/lang/annotation/UnitTest.java + test/java/lang/annotation/loaderLeak/A.java + test/java/lang/annotation/loaderLeak/B.java + test/java/lang/annotation/loaderLeak/C.java + test/java/lang/annotation/loaderLeak/LoaderLeak.sh + test/java/lang/annotation/loaderLeak/Main.java + test/java/lang/annotation/package-info.java + test/java/math/BigDecimal/AddTests.java + test/java/math/BigDecimal/CompareToTests.java + test/java/math/BigDecimal/Constructor.java + test/java/math/BigDecimal/DivideTests.java + test/java/math/BigDecimal/FloatDoubleValueTests.java + test/java/math/BigDecimal/IntegralDivisionTests.java + test/java/math/BigDecimal/NegateTests.java + test/java/math/BigDecimal/PowTests.java + test/java/math/BigDecimal/RoundingTests.java + test/java/math/BigDecimal/ScaleByPowerOfTenTests.java + test/java/math/BigDecimal/SerializationTests.java + test/java/math/BigDecimal/StringConstructor.java + test/java/math/BigDecimal/StrippingZerosTest.java + test/java/math/BigDecimal/ToPlainStringTests.java + test/java/math/BigDecimal/ZeroScalingTests.java + test/java/math/BigInteger/BigIntegerTest.java + test/java/math/BigInteger/ModPow.java + test/java/math/BigInteger/ModPow65537.java + test/java/math/BigInteger/ModPowPowersof2.java + test/java/math/BigInteger/OperatorNpeTests.java + test/java/math/BigInteger/ProbablePrime.java + test/java/math/BigInteger/StringConstructor.java + test/java/math/BigInteger/UnicodeConstructor.java + test/java/math/RoundingMode/RoundingModeTests.java From jean-christophe.collet at sun.com Tue Jan 27 10:46:26 2009 From: jean-christophe.collet at sun.com (jean-christophe.collet at sun.com) Date: Tue, 27 Jan 2009 10:46:26 +0000 Subject: hg: jdk7/tl/jdk: 6790677: java.net.HttpCookie.parse(String) should ignore unrecognized attributes, RFC2965 Message-ID: <20090127104638.08BF8E20B@hg.openjdk.java.net> Changeset: 53d9259661c3 Author: jccollet Date: 2009-01-27 11:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/53d9259661c3 6790677: java.net.HttpCookie.parse(String) should ignore unrecognized attributes, RFC2965 Summary: Changed code not to throw an exception on unknown attributes Reviewed-by: chegar ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/TestHttpCookie.java From martinrb at google.com Tue Jan 27 23:13:31 2009 From: martinrb at google.com (martinrb at google.com) Date: Tue, 27 Jan 2009 23:13:31 +0000 Subject: hg: jdk7/tl/jdk: 6797480: Remove synchronization bottleneck in logger Message-ID: <20090127231400.3CDA8E2A5@hg.openjdk.java.net> Changeset: 6eac3829cb41 Author: martin Date: 2009-01-27 15:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6eac3829cb41 6797480: Remove synchronization bottleneck in logger Reviewed-by: swamyv Contributed-by: jeremymanson at google.com ! src/share/classes/java/util/logging/Logger.java From joe.darcy at sun.com Wed Jan 28 01:56:12 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Wed, 28 Jan 2009 01:56:12 +0000 Subject: hg: jdk7/tl/langtools: 6707027: langtools/test/tools/javac/processing/model/testgetallmember/Main.java fails Message-ID: <20090128015615.90B56E306@hg.openjdk.java.net> Changeset: edb8d7985cfd Author: darcy Date: 2009-01-27 17:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/edb8d7985cfd 6707027: langtools/test/tools/javac/processing/model/testgetallmember/Main.java fails Reviewed-by: jjg ! test/tools/javac/processing/model/testgetallmembers/Main.java From jonathan.gibbons at sun.com Wed Jan 28 02:41:11 2009 From: jonathan.gibbons at sun.com (jonathan.gibbons at sun.com) Date: Wed, 28 Jan 2009 02:41:11 +0000 Subject: hg: jdk7/tl/langtools: 6176978: current Javadoc's invocation and extension (Doclet) mechanisms are problematic Message-ID: <20090128024113.9CEA0E31B@hg.openjdk.java.net> Changeset: 9199b9092f73 Author: jjg Date: 2009-01-27 18:38 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9199b9092f73 6176978: current Javadoc's invocation and extension (Doclet) mechanisms are problematic Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java + test/tools/javadoc/6176978/T6176978.java + test/tools/javadoc/6176978/X.java From joe.darcy at sun.com Wed Jan 28 18:40:45 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Wed, 28 Jan 2009 18:40:45 +0000 Subject: hg: jdk7/tl/jdk: 6704655: Test test/java/lang/reflect/Generics/Probe.java fails under OpenJDK Message-ID: <20090128184104.9E425E361@hg.openjdk.java.net> Changeset: c2d2185a79dd Author: darcy Date: 2009-01-28 10:30 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2d2185a79dd 6704655: Test test/java/lang/reflect/Generics/Probe.java fails under OpenJDK Reviewed-by: ksrini ! test/java/lang/reflect/Generics/Probe.java From christos at zoulas.com Wed Jan 28 19:44:37 2009 From: christos at zoulas.com (Christos Zoulas) Date: Wed, 28 Jan 2009 14:44:37 -0500 Subject: [PATCH]: Portability fixes Message-ID: <20090128194437.38E005654E@rebar.astron.com> Hello, Here are some simple changes for your consideration: 1. passing possibly negative values to isdigit is undefined behavior: http://www.opengroup.org/onlinepubs/009695399/functions/isdigit.html 2. passing possibly negative values to isspace is undefined behavior: http://www.opengroup.org/onlinepubs/009695399/functions/isspace.html 3. last is possibly uninitialized. 4. recvfrom argument should be socklen_t not int: http://www.opengroup.org/onlinepubs/007908775/xns/recvfrom.html Thanks, christos diff -r fc30e7f4b9b3 src/solaris/native/java/lang/UNIXProcess_md.c --- a/src/solaris/native/java/lang/UNIXProcess_md.c Fri Jan 16 11:24:18 2009 -0500 +++ b/src/solaris/native/java/lang/UNIXProcess_md.c Mon Jan 22 16:25:36 2009 -0500 @@ -377,7 +377,7 @@ */ while ((dirp = readdir(dp)) != NULL) { int fd; - if (isdigit(dirp->d_name[0]) && + if (isdigit((unsigned char)dirp->d_name[0]) && (fd = strtol(dirp->d_name, NULL, 10)) >= from_fd + 2) close(fd); } diff -r fc30e7f4b9b3 src/solaris/native/java/net/Inet4AddressImpl.c --- a/src/solaris/native/java/net/Inet4AddressImpl.c Fri Jan 16 11:24:18 2009 -0500 +++ b/src/solaris/native/java/net/Inet4AddressImpl.c Mon Jan 22 16:25:36 2009 -0500 @@ -155,7 +155,7 @@ * Workaround for Solaris bug 4160367 - if a hostname contains a * white space then 0.0.0.0 is returned */ - if (isspace(hostname[0])) { + if (isspace((unsigned char)hostname[0])) { JNU_ThrowByName(env, JNU_JAVANETPKG "UnknownHostException", (char *)hostname); JNU_ReleaseStringPlatformChars(env, host, hostname); @@ -172,7 +172,7 @@ return NULL; } else { int i = 0; - struct addrinfo *itr, *last, *iterator = res; + struct addrinfo *itr, *last = NULL, *iterator = res; while (iterator != NULL) { int skip = 0; itr = resNew; @@ -603,7 +603,8 @@ ping4(JNIEnv *env, jint fd, struct sockaddr_in* him, jint timeout, struct sockaddr_in* netif, jint ttl) { jint size; - jint n, len, hlen1, icmplen; + jint n, hlen1, icmplen; + socklen_t len; char sendbuf[1500]; char recvbuf[1500]; struct icmp *icmp; From martinrb at google.com Wed Jan 28 20:16:56 2009 From: martinrb at google.com (Martin Buchholz) Date: Wed, 28 Jan 2009 12:16:56 -0800 Subject: [PATCH]: Portability fixes In-Reply-To: <20090128194437.38E005654E@rebar.astron.com> References: <20090128194437.38E005654E@rebar.astron.com> Message-ID: <1ccfd1c10901281216u19b542e9ifac638d3eabd142e@mail.gmail.com> Christos, thanks for the bug report. For low level code like this, it's almost always a mistake (my mistake, that is; I am the author) to use the locale-dependent functions like isdigit. Still, I am surprised to see a real failure with isdigit(negative char). I prefer the following fix for UNIXProcess_md.c: (and would be willing to submit it on Christos' behalf) (I'm not going to comment on the changes to AddressImpl.c, except to suggest considering ASCII-specific functions as well.) diff --git a/src/solaris/native/java/lang/UNIXProcess_md.c b/src/solaris/native/java/lang/UNIXProcess_md.c --- a/src/solaris/native/java/lang/UNIXProcess_md.c +++ b/src/solaris/native/java/lang/UNIXProcess_md.c @@ -260,6 +260,12 @@ } static int +isAsciiDigit(char c) +{ + return c >= '0' && c <= '9'; +} + +static int closeDescriptors(void) { DIR *dp; @@ -284,7 +290,7 @@ */ while ((dirp = readdir64(dp)) != NULL) { int fd; - if (isdigit(dirp->d_name[0]) && + if (isAsciiDigit(dirp->d_name[0]) && (fd = strtol(dirp->d_name, NULL, 10)) >= from_fd + 2) close(fd); } Martin On Wed, Jan 28, 2009 at 11:44, Christos Zoulas wrote: > Hello, > > Here are some simple changes for your consideration: > > 1. passing possibly negative values to isdigit is undefined behavior: > http://www.opengroup.org/onlinepubs/009695399/functions/isdigit.html > 2. passing possibly negative values to isspace is undefined behavior: > http://www.opengroup.org/onlinepubs/009695399/functions/isspace.html > 3. last is possibly uninitialized. > 4. recvfrom argument should be socklen_t not int: > http://www.opengroup.org/onlinepubs/007908775/xns/recvfrom.html > > Thanks, > > christos > > diff -r fc30e7f4b9b3 src/solaris/native/java/lang/UNIXProcess_md.c > --- a/src/solaris/native/java/lang/UNIXProcess_md.c Fri Jan 16 11:24:18 > 2009 -0500 > +++ b/src/solaris/native/java/lang/UNIXProcess_md.c Mon Jan 22 16:25:36 > 2009 -0500 > @@ -377,7 +377,7 @@ > */ > while ((dirp = readdir(dp)) != NULL) { > int fd; > - if (isdigit(dirp->d_name[0]) && > + if (isdigit((unsigned char)dirp->d_name[0]) && > (fd = strtol(dirp->d_name, NULL, 10)) >= from_fd + 2) > close(fd); > } > diff -r fc30e7f4b9b3 src/solaris/native/java/net/Inet4AddressImpl.c > --- a/src/solaris/native/java/net/Inet4AddressImpl.c Fri Jan 16 11:24:18 > 2009 -0500 > +++ b/src/solaris/native/java/net/Inet4AddressImpl.c Mon Jan 22 16:25:36 > 2009 -0500 > @@ -155,7 +155,7 @@ > * Workaround for Solaris bug 4160367 - if a hostname contains a > * white space then 0.0.0.0 is returned > */ > - if (isspace(hostname[0])) { > + if (isspace((unsigned char)hostname[0])) { > JNU_ThrowByName(env, JNU_JAVANETPKG "UnknownHostException", > (char *)hostname); > JNU_ReleaseStringPlatformChars(env, host, hostname); > @@ -172,7 +172,7 @@ > return NULL; > } else { > int i = 0; > - struct addrinfo *itr, *last, *iterator = res; > + struct addrinfo *itr, *last = NULL, *iterator = res; > while (iterator != NULL) { > int skip = 0; > itr = resNew; > @@ -603,7 +603,8 @@ > ping4(JNIEnv *env, jint fd, struct sockaddr_in* him, jint timeout, > struct sockaddr_in* netif, jint ttl) { > jint size; > - jint n, len, hlen1, icmplen; > + jint n, hlen1, icmplen; > + socklen_t len; > char sendbuf[1500]; > char recvbuf[1500]; > struct icmp *icmp; > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From christos at zoulas.com Wed Jan 28 20:42:36 2009 From: christos at zoulas.com (Christos Zoulas) Date: Wed, 28 Jan 2009 15:42:36 -0500 Subject: [PATCH]: Portability fixes In-Reply-To: <1ccfd1c10901281216u19b542e9ifac638d3eabd142e@mail.gmail.com> from Martin Buchholz (Jan 28, 12:16pm) Message-ID: <20090128204236.D85385654E@rebar.astron.com> On Jan 28, 12:16pm, martinrb at google.com (Martin Buchholz) wrote: -- Subject: Re: [PATCH]: Portability fixes | Christos, thanks for the bug report. | | For low level code like this, it's almost always a mistake | (my mistake, that is; I am the author) | to use the locale-dependent functions like isdigit. | Still, I am surprised to see a real failure with isdigit(negative char). Well, the reason the standard says it is "undefined" it is to support existing implementations that use arrays of bits to implement the isfoo() functions. Like: #define isfoo(a) (__ctype[(a)] & _FOO) A negative index there could lead to a possible core-dump depending on where __ctype[] happens to live, or treating as "foo" things that are not because the locations before the ctype array contain random values. All this is for implementations that have signed characters by default (most implementations). | I prefer the following fix for UNIXProcess_md.c: | (and would be willing to submit it on Christos' behalf) | | (I'm not going to comment on the changes to AddressImpl.c, | except to suggest considering ASCII-specific functions as well.) That change looks fine to me. Thanks for the quick reply. christos From joe.darcy at sun.com Wed Jan 28 20:52:18 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Wed, 28 Jan 2009 20:52:18 +0000 Subject: hg: jdk7/tl/jdk: 6719182: update legal notice in java/lang/instrument/package.html Message-ID: <20090128205232.52A28E366@hg.openjdk.java.net> Changeset: 1ebbc958f06a Author: darcy Date: 2009-01-28 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ebbc958f06a 6719182: update legal notice in java/lang/instrument/package.html Reviewed-by: jjh ! src/share/classes/java/lang/instrument/package.html From Alan.Bateman at Sun.COM Wed Jan 28 21:52:44 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Wed, 28 Jan 2009 21:52:44 +0000 Subject: [PATCH]: Portability fixes In-Reply-To: <1ccfd1c10901281216u19b542e9ifac638d3eabd142e@mail.gmail.com> References: <20090128194437.38E005654E@rebar.astron.com> <1ccfd1c10901281216u19b542e9ifac638d3eabd142e@mail.gmail.com> Message-ID: <4980D3AC.4070408@sun.com> Martin Buchholz wrote: > Christos, thanks for the bug report. > > For low level code like this, it's almost always a mistake > (my mistake, that is; I am the author) > to use the locale-dependent functions like isdigit. > Still, I am surprised to see a real failure with isdigit(negative char). > > I prefer the following fix for UNIXProcess_md.c: > (and would be willing to submit it on Christos' behalf) > > (I'm not going to comment on the changes to AddressImpl.c, > except to suggest considering ASCII-specific functions as well.) > > diff --git a/src/solaris/native/java/lang/UNIXProcess_md.c > b/src/solaris/native/java/lang/UNIXProcess_md.c > --- a/src/solaris/native/java/lang/UNIXProcess_md.c > +++ b/src/solaris/native/java/lang/UNIXProcess_md.c > @@ -260,6 +260,12 @@ > } > > static int > +isAsciiDigit(char c) > +{ > + return c >= '0' && c <= '9'; > +} > + > +static int > closeDescriptors(void) > { > DIR *dp; > @@ -284,7 +290,7 @@ > */ > while ((dirp = readdir64(dp)) != NULL) { > int fd; > - if (isdigit(dirp->d_name[0]) && > + if (isAsciiDigit(dirp->d_name[0]) && > (fd = strtol(dirp->d_name, NULL, 10)) >= from_fd + 2) > close(fd); > } > > > Martin This looks good to me too. I've created a bug to track this: 6798822: (process) Non-portable use of isdigit in src/solaris/native/java/lang/UNIXProcess_md.c We should forward the portability issues with the networking code to net-dev. -Alan. From martinrb at google.com Wed Jan 28 22:20:55 2009 From: martinrb at google.com (martinrb at google.com) Date: Wed, 28 Jan 2009 22:20:55 +0000 Subject: hg: jdk7/tl/jdk: 6798822: (process) Non-portable use of isdigit in src/solaris/native/java/lang/UNIXProcess_md.c Message-ID: <20090128222111.D745BE371@hg.openjdk.java.net> Changeset: 6607850bd7fc Author: martin Date: 2009-01-28 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6607850bd7fc 6798822: (process) Non-portable use of isdigit in src/solaris/native/java/lang/UNIXProcess_md.c Reviewed-by: alanb Contributed-by: christos at zoulas.com ! src/solaris/native/java/lang/UNIXProcess_md.c From martinrb at google.com Wed Jan 28 22:27:19 2009 From: martinrb at google.com (Martin Buchholz) Date: Wed, 28 Jan 2009 14:27:19 -0800 Subject: [PATCH]: Portability fixes In-Reply-To: <4980D3AC.4070408@sun.com> References: <20090128194437.38E005654E@rebar.astron.com> <1ccfd1c10901281216u19b542e9ifac638d3eabd142e@mail.gmail.com> <4980D3AC.4070408@sun.com> Message-ID: <1ccfd1c10901281427m69ad9b03m7902b87a7c30a83b@mail.gmail.com> I've pushed the fix for UNIXProcess into the tl forest. Thanks to Christos and Alan for making it happen. Let's aim for future changes as speedy as this one. Martin On Wed, Jan 28, 2009 at 13:52, Alan Bateman wrote: > Martin Buchholz wrote: > >> Christos, thanks for the bug report. >> >> For low level code like this, it's almost always a mistake >> (my mistake, that is; I am the author) >> to use the locale-dependent functions like isdigit. >> Still, I am surprised to see a real failure with isdigit(negative char). >> >> I prefer the following fix for UNIXProcess_md.c: >> (and would be willing to submit it on Christos' behalf) >> >> (I'm not going to comment on the changes to AddressImpl.c, >> except to suggest considering ASCII-specific functions as well.) >> >> diff --git a/src/solaris/native/java/lang/UNIXProcess_md.c >> b/src/solaris/native/java/lang/UNIXProcess_md.c >> --- a/src/solaris/native/java/lang/UNIXProcess_md.c >> +++ b/src/solaris/native/java/lang/UNIXProcess_md.c >> @@ -260,6 +260,12 @@ >> } >> static int >> +isAsciiDigit(char c) >> +{ >> + return c >= '0' && c <= '9'; >> +} >> + >> +static int >> closeDescriptors(void) >> { >> DIR *dp; >> @@ -284,7 +290,7 @@ >> */ >> while ((dirp = readdir64(dp)) != NULL) { >> int fd; >> - if (isdigit(dirp->d_name[0]) && >> + if (isAsciiDigit(dirp->d_name[0]) && >> (fd = strtol(dirp->d_name, NULL, 10)) >= from_fd + 2) >> close(fd); >> } >> >> >> Martin >> > This looks good to me too. I've created a bug to track this: > 6798822: (process) Non-portable use of isdigit in > src/solaris/native/java/lang/UNIXProcess_md.c > > We should forward the portability issues with the networking code to > net-dev. > > -Alan. > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From maurizio.cimadamore at sun.com Thu Jan 29 12:26:03 2009 From: maurizio.cimadamore at sun.com (maurizio.cimadamore at sun.com) Date: Thu, 29 Jan 2009 12:26:03 +0000 Subject: hg: jdk7/tl/langtools: 3 new changesets Message-ID: <20090129122608.85745E3A2@hg.openjdk.java.net> Changeset: 1aa81917016a Author: mcimadamore Date: 2009-01-29 12:17 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/1aa81917016a 6315770: javac inference allows creation of strange types: Integer & Runnable Summary: Javac does not apply glb correctly as per JLS3 15.12.2.8 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/inference/6315770/T6315770.java + test/tools/javac/generics/inference/6315770/T6315770.out Changeset: 4542977c959e Author: mcimadamore Date: 2009-01-29 12:18 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4542977c959e 6557182: Unchecked warning *and* inconvertible types Summary: Redundant warnings are generated when casting from intersection types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/cast/6557182/T6557182.java + test/tools/javac/cast/6557182/T6557182.out Changeset: 79f2f2c7d846 Author: mcimadamore Date: 2009-01-29 12:19 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/79f2f2c7d846 6729401: Compiler error when using F-bounded generics with free type variables Summary: Javac applies wrong substitution to recursive type-variable bounds Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/6729401/T6729401.java From joe.darcy at sun.com Thu Jan 29 17:08:48 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 29 Jan 2009 17:08:48 +0000 Subject: hg: jdk7/tl/jdk: 6239194: Object.hashCode() should reference System.identityHashCode() Message-ID: <20090129170921.42403E3C8@hg.openjdk.java.net> Changeset: 7241bd422542 Author: darcy Date: 2009-01-29 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7241bd422542 6239194: Object.hashCode() should reference System.identityHashCode() Reviewed-by: emcmanus ! src/share/classes/java/lang/Object.java From joe.darcy at sun.com Thu Jan 29 21:09:57 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Thu, 29 Jan 2009 21:09:57 +0000 Subject: hg: jdk7/tl/jdk: 6327048: Enum javadoc could link to JLS; ... Message-ID: <20090129211009.32523E3FB@hg.openjdk.java.net> Changeset: ff9ad99b63cc Author: darcy Date: 2009-01-29 13:04 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ff9ad99b63cc 6327048: Enum javadoc could link to JLS 6653154: Exception message for bad Enum.valueOf has spurious "class" Reviewed-by: emcmanus ! src/share/classes/java/lang/Enum.java ! src/share/classes/java/lang/annotation/Annotation.java + test/java/lang/Enum/ValueOf.java From joe.darcy at sun.com Fri Jan 30 20:44:30 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 30 Jan 2009 20:44:30 +0000 Subject: hg: jdk7/tl/jdk: 6799343: (fmt) java.util.Formatter uses plainlink instead of linkplain Message-ID: <20090130204442.28818E5BA@hg.openjdk.java.net> Changeset: 483e5c97d438 Author: darcy Date: 2009-01-30 12:40 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/483e5c97d438 6799343: (fmt) java.util.Formatter uses plainlink instead of linkplain Reviewed-by: alanb ! src/share/classes/java/util/Formatter.java From michael.mcmahon at sun.com Fri Jan 30 22:29:59 2009 From: michael.mcmahon at sun.com (michael.mcmahon at sun.com) Date: Fri, 30 Jan 2009 22:29:59 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20090130223023.3AA57E629@hg.openjdk.java.net> Changeset: d6881542bfef Author: michaelm Date: 2009-01-30 22:05 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d6881542bfef 4167874: URL-downloaded jar files can consume all available file descriptors Summary: added close method to URLClassLoader Reviewed-by: alanb ! src/share/classes/java/lang/RuntimePermission.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/sun/misc/URLClassPath.java + test/java/net/URLClassLoader/closetest/CloseTest.java + test/java/net/URLClassLoader/closetest/README + test/java/net/URLClassLoader/closetest/build.sh + test/java/net/URLClassLoader/closetest/serverRoot/Test.java + test/java/net/URLClassLoader/closetest/test1/com/foo/Resource1 + test/java/net/URLClassLoader/closetest/test1/com/foo/Resource2 + test/java/net/URLClassLoader/closetest/test1/com/foo/TestClass.java + test/java/net/URLClassLoader/closetest/test1/com/foo/TestClass1.java + test/java/net/URLClassLoader/closetest/test2/com/foo/Resource1 + test/java/net/URLClassLoader/closetest/test2/com/foo/Resource2 + test/java/net/URLClassLoader/closetest/test2/com/foo/TestClass.java + test/java/net/URLClassLoader/closetest/test2/com/foo/TestClass1.java Changeset: 0a05a2632a81 Author: michaelm Date: 2009-01-30 22:27 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0a05a2632a81 Merge From joe.darcy at sun.com Fri Jan 30 23:11:39 2009 From: joe.darcy at sun.com (joe.darcy at sun.com) Date: Fri, 30 Jan 2009 23:11:39 +0000 Subject: hg: jdk7/tl/jdk: 6799462: Minor typo (wrong word) in JavaDoc for InputStream.read(byte[] b) method Message-ID: <20090130231151.4C80DE634@hg.openjdk.java.net> Changeset: 948c504d6ef7 Author: darcy Date: 2009-01-30 15:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/948c504d6ef7 6799462: Minor typo (wrong word) in JavaDoc for InputStream.read(byte[] b) method Reviewed-by: sherman, martin ! src/share/classes/java/io/InputStream.java