Code review request for 6628737: Specification of wrapper class valueOf static factories should require caching
Mark Reinhold
mr at sun.com
Thu Jul 9 03:50:25 UTC 2009
Looks fine to me.
Minor formatting nit in each delta except the first:
> ...
>
> --- old/src/share/classes/java/lang/Character.java 2009-07-08
> 18:38:13.000000000 -0700
> +++ new/src/share/classes/java/lang/Character.java 2009-07-08
> 18:38:13.000000000 -0700
> @@ -2571,6 +2571,10 @@
> * significantly better space and time performance by caching
> * frequently requested values.
> *
> + * This method will always cache values in the range '\u0000'
> + * to '\u007f'", inclusive, and may cache other values outside
> + * of this range.
> + *
> * @param c a char value.
> * @return a <tt>Character</tt> instance representing <tt>c</tt>.
> * @since 1.5
I'm guessing, from the blank lines around this paragraph, that you want
it to be displayed as a separate paragraph. If that's the case then you
need to wrap it in <p> ... </p>.
- Mark
More information about the core-libs-dev
mailing list