Review request for 4917309 and 6864003
Mandy Chung
Mandy.Chung at Sun.COM
Fri Jul 24 16:08:27 UTC 2009
Alan Bateman wrote:
> Mandy,
>
> I see in ClassLoader#loadClass that you still allow
> findBootstrapClassOrNull to throw CNF. I assume this is needed until
> there is a promoted build with the updated
> JVM_FindClassFromBootLoader, after which you will go back to clean it
> up - do I have this right?
I leave the call to findBootstrapClassOrNull inside try-catch clause (1)
to work with the existing VM and (2) I think it's better to leave it
this way as opposed to do something like this:
if (parent == null) {
c = findBootstrapClassOrNull(name);
} else {
try {
c = parent.loadClass(name, false);
} catch (ClassNotFoundException e) {
// ClassNotFoundException thrown if class not found
// from the non-null parent class loader
}
}
So that's the final version and no need to clean up.
Mandy
More information about the core-libs-dev
mailing list