Miscellaneous improvements to "jar".

[Martin Buchholz]

Ulf,

Thanks for the review.

On Thu, Jun 25, 2009 at 06:20, Ulf Zibis <Ulf.Zibis at gmx.de> wrote:

> Martin,
>
> 1. typo in line 1188


Done.


>
> 2. Is it convention for javadoc to have 2 blanks after period?


This is not consistent in the JDK.  I do it myself, partially because I've
been trained by emacs.


>
> 3. I guess your change is targeted on performance. IMHO jar read/write
> itself should be improved:
>   http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6818737
>

Many things to improve... I'm not planning to work on that one myself.

Martin


>
> Ulf
>
>
> Am 25.06.2009 04:34, Martin Buchholz schrieb:
>
>> Hi jar team,
>>
>> I have a bunch of minor improvements to
>>  src/share/classes/sun/tools/jar/Main.java
>>
>> Toby and Xueming, please review.
>>
>> Warning: the index code has not been maintained for many years.
>>
>> Xueming, please file a bug.
>>
>> Synopsis: Miscellaneous improvements to "jar".
>> Description:
>> - Use standard jdk coding style for javadoc
>> - Don't create a temp file for jar index in STORED mode.
>> - Don't use synchronized collections.
>> - Fix javac warnings.
>> - Don't define new names for things like INDEX_NAME;
>>  use static import instead.
>> - more efficiently compare special file names in update mode.
>>  Update mode should be measurably faster.
>> - make CRC32OutputStream a nested class.
>>  refactor crc32.reset and updating entry into CRC32OutputStream.
>> - Fix apparently benign bug updating n in CRC32OutputStream.write(byte[],
>> int, int)
>>
>> Evaluation: Yep.
>>
>> http://cr.openjdk.java.net/~martin/jar-misc/<http://cr.openjdk.java.net/%7Emartin/jar-misc/><
>> http://cr.openjdk.java.net/%7Emartin/jar-misc/>
>>
>> Thanks,
>>
>> Martin
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20090625/0f45a983/attachment.html>