Miscellaneous improvements to "jar".

Martin Buchholz martinrb at google.com
Fri Jun 26 00:33:03 UTC 2009

On Thu, Jun 25, 2009 at 13:04, Xueming Shen <Xueming.Shen at sun.com> wrote:

>>  yes, it now solved the puzzle:-)
> (1)closeEntry() is not strictly necessary, either putNextEntry or close()
> will close the previous entry
> (2)you might want to go a little further to "encapsulate" the updateEntry
> into crc32os, pass the entry
> into the constructor and setup the value with a crc32os.close()...bad idea?

It's somewhat magical to have close to this,
and close is not currently called automatically anywhere.
explicit updateEntry is at least easy to understand.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20090625/3a5e7c6d/attachment.html>

More information about the core-libs-dev mailing list