Review request for 6810254 (v01)

[Mandy Chung]

On 03/11/09 13:01, Alan Bateman wrote:
> Mandy Chung wrote:
>> David, Alan,
>>
>> Thanks for your feedback.  I revise the fix per Alan's suggestion. I 
>> decide not to keep the fix to lazily initialize the shutdown hook 
>> only.  So java.io.Console, DeleteOnExitHook and 
>> java.lang.ApplicationShutdownHooks are only loaded when the app uses it.
>>
>> Webrev at:
>>   http://cr.openjdk.java.net/~mchung/6810254/webrev.01/
>>
>> Thanks
>> Mandy
> This looks a lot better. One suggestion is to reverse the order of the 
> parameters to registerShutdownHook so that the Runnable is last. That 
> would make it easier to read and also easier to see the hook slot which 
> is the fragile part to the solution.

Ok. Will change the parameter order.

> Minor nit is that the comment in Shutdown.java reads "The order in with 
> the hooks are added here is important ...". The registration order 
> doesn't matter now so this could be changed.

Right. Will update the comment.

Thanks
Mandy

> -Alan.
> 
>