[PATCH 1/1] Get rid of synchronization in java.util.logging.LogRecord constructor

[Dalibor Topic]

David M. Lloyd wrote:
> On 03/12/2009 05:41 PM, Mark Reinhold wrote:
>> You might want to have a look at the new contribution process [1].
>> Using that will increase the probability that someone will evaluate
>> your patch sooner rather than later.
>>
>> - Mark
>>
>> [1] http://openjdk.java.net/contribute
> 
> Consider my post to be step 2 of that process.  The patch itself is
> probably the most succinct way of expressing the proposed change (it
> only took a minute or two to write in any case).

That's understandable, but it's a lot easier to find interesting patches 
to review in a bug tracker, then to search for them among mailing list threads.

In other words, if you, say, look at this thread so far in your mail reader, 
you'd have a hard time figuring out whether someone has reviewed your change 
or not, without spending the time reading the thread. Since more people end 
up reading each e-mail then people end up writing each e-mail, it's useful 
to optimize processes towards avoiding having to read a lot of e-mail in 
order to figure out simple things.

So, please do add your patch to the bug tracker so that it doesn't get lost,
and so that others don't have to spend time reading threads full of polite 
requests to please add your patch to the bug tracker. ;)

> Anyone have comments on the change?

It seems that the change would break serialization, by changing the type
of a serialized field (in both classes) away from a primitive one. See
http://java.sun.com/javase/6/docs/platform/serialization/spec/version.html
for details.

Such comments are, obviously, better preserved in a bug tracker, then in 
a mailing list thread, but you knew I'd say that, right? ;)

cheers,
dalibor topic

-- 
*******************************************************************
Dalibor Topic                   Tel: (+49 40) 23 646 738
Java F/OSS Ambassador           AIM: robiladonaim
Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
Nagelsweg 55                    http://openjdk.java.net
D-20097 Hamburg                 mailto:Dalibor.Topic at sun.com
Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
Amtsgericht München: HRB 161028
Geschäftsführer: Thomas Schröder, Wolfgang Engels, Dr. Roland Bömer
Vorsitzender des Aufsichtsrates: Martin Häring