java-nio-charset-enhanced -- Milestone 4 is released
Martin Buchholz
martinrb at google.com
Sun Mar 29 20:43:23 UTC 2009
On Sun, Mar 29, 2009 at 12:49, Ulf Zibis <Ulf.Zibis at gmx.de> wrote:
> Am 29.03.2009 20:27, Martin Buchholz schrieb:
>>
>> On Fri, Mar 27, 2009 at 15:44, Ulf Zibis <Ulf.Zibis at gmx.de> wrote:
>>
>>>
>>> I also have coded such a test for full-scan comparision:
>>> See CharsetsTest + LegacyCharset (it retrieves the legacy charsets by
>>> reflection directly from rt.jar of the patched JDK) here:
>>>
>>> https://java-nio-charset-enhanced.dev.java.net/source/browse/java-nio-charset-enhanced/trunk/test/sun/nio/cs/
>>>
>>> It cost me several nights having all code points equal, faced to my
>>> special
>>> mixture of range-limited direct maps and full-range indirected map.
>>>
>>
>> It does look like you've written a lot of good tests.
>> It would be nice not to have an explicit list of charsets in
>> CharsetsTest.java.PARAMETERS.
>>
>
> The advantage of this list is, that I can disable charsets by
> line-commenting to speed up the test while debugging special cases.
See my posted mega-patch for how
you can provide a -Dcharset=XXXX flag to FindDecoderBugs.java.
I think that's a better solution for the debugging problem.
Of course I've had exactly the same problem.
>> The problem is more human. One would like to give credit for good ideas
>> or good analysis, but the only official way to give credit in a commit
>> message is
>> via a simple
>> Contributed-by: email-address
>> which raises legal doubts even when there is no copyrighted material.
>> I guess one can abuse the Summary: field to squeeze in thank-yous,
>> but it's pretty obvious that you are circumventing the process.
>>
>
> The last paragraph is difficult for me to understand in english. Could you
> please translate it?
Ist in allen Sprachen schwierig zu erklaeren.
Sag mal, mein Freund Ralf hat 'ne gute Idee.
Ich mach'n Patch darauss.
Ich mochte genau dass in meiner commit-message sagen, aber dass ist
derzeit verboten, weil das commit-message-format zu beschraenkt ist.
Insbesondere, Contributed-by: ist nicht geeignet, weil dann immer wieder
gefragt wird, "Hat Ralf das Contributor Agreement unterschrieben?",
und nur eine email-Addresse erlaubt ist.
Martin
More information about the core-libs-dev
mailing list