Request for approval: fix 4428022, System.out.println(0.001) outputs 0.0010

[Andrew John Hughes]

2009/5/28 Andrew Haley <aph at redhat.com>:
> Joseph D. Darcy wrote:
>> Andrew Haley wrote:
>>> Joseph D. Darcy wrote:
>>>
>>>> Alan Bateman wrote:
>>>>
>>>>> Andrew Haley wrote:
>>>>>
>>>>>> :
>>>>>> OK, here it is.  I put the test in java/lang/Double/ToString.java
>>>>>> rather than sun/misc/FloatingDecimal because the bug manifested
>>>>>> itself in Double.toString although the fix was in
>>>>>> FloatingDecimal.dtoa.
>>>>>>
>>>>> I agree that test/java/lang/Double is the best place for this. All
>>>>> looks good to me (except minor nit, "String argv[]" -> "String[]
>>>>> args").  Joe, are you okay with this?
>>>>>
>>>>> -Alan.
>>>>>
>>>> Yes; the changes look fine for both releases.
>>>
>>> To which openjdk7 repo do you want me to push this?
>>> My best guess is jdk7/jdk7-gate/jdk.
>>
>> Please push this through TL (tools and libraries):
>> ssh://hg.openjdk.java.net/jdk7/tl-gate/jdk
>
> Ta.  A request:
>
> I think that patch approvals had better start to include the repo.
> External contributors need this information, even if it's obvious
> from inside Sun.
>
> Thanks,
> Andrew.
>
>

I second that.  FWIW, I believe nothing ever gets pushed to the
jdk7-gate initially, it's used as part of the release engineering
process.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8