Review please: 6367077 : Purge LD_LIBRARY_PATH from the Unix launchers

Martin Buchholz martinrb at google.com
Wed Nov 11 00:21:48 UTC 2009


Thanks for doing this.  10-minute review looks good.

One minor comment:

You probably want to die if "sun.arch.data.model" is not either "32" or "64".

+    static final boolean is64Bit =
+            System.getProperty("sun.arch.data.model", "32").equals("64");
+    static final boolean is32Bit = !is64Bit;

Martin

On Tue, Nov 10, 2009 at 14:55, Kumar Srinivasan
<Kumar.Srinivasan at sun.com> wrote:
> Hello All,
>
> This is a long standing issue we have had with the java launcher, please
> review.
> http://cr.openjdk.java.net/~ksrini/6367077/webrev.00/
>
>
> Thanks
> Kumar
>



More information about the core-libs-dev mailing list