Need reviewer - java.template changes

[Rémi Forax]

Le 26/11/2009 19:18, Kelly O'Hair a écrit :
> Thanks.
>
> I don't quite understand the 'prefer the original' comment, all I'm 
> adding
> is a .template suffix, the basename is still there, nothing was taken 
> away.
>
> In the Makefiles and the ant scripts it makes life so much easier with
> this .template suffix. Maybe it's only something a 'build' person 
> would love. ;^)
>
> -kto

You're not alone.
I currently use a patched version of eclipse to be able to incrementally 
compile
the jdk with eclipse.
One reason is that because templates ends with ".java", they are recognized,
by eclipse as Java classes and eclipse behaves strangely when you try to 
refactor
some code let say in package java.dyn, it also try to refactor the templates
and fails.

Rémi

>
> Alan Bateman wrote:
>> Kelly O'Hair wrote:
>>> Need reviewer.
>>>
>>> 6903197: Some java template files need to be renamed to .java.template
>>> http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-6903197/webrev/
>> Looks okay to me (although I prefer the original names :-).  It would 
>> be good to send a heads-up to i18n-dev for the changes to generation 
>> of the locales.
>>
>> -Alan.