Review request for 6891707: Eliminate the java.io.FilePermission dependency on PolicyFile
Alan Bateman
Alan.Bateman at Sun.COM
Thu Oct 15 09:12:01 UTC 2009
Mandy Chung wrote:
> Alan, Sean,
>
> Can you review the fix for:
> 6891707: Eliminate the java.io.FilePermission dependency on PolicyFile
>
> Webrev:
> http://cr.openjdk.java.net/~mchung/6891707/webrev.00/
>
> FilePermission and PolicyFile are the two callers to the
> sun.security.provider.PolicyFile.canonPath method. Adding a new class
> for the canonPath method seems unnecessary. So the fix just
> duplicates the code in FilePermission class.
>
> Thanks
> Mandy
This looks okay to me. Minor comment is this is just a wrapper about
getCanonicalPath to avoid calling it with paths that are intended to
match all entries in the directory. It might be good to include this in
a comment in both places (and this would avoid needing to say that it
duplicated in FilePermission).
-Alan
More information about the core-libs-dev
mailing list