Review request #1: 6863566 (Java should support the freedesktop.org startup notification specification)

[Martin Buchholz]

(I'm the original author of ProcessEnvironment)

I agree with other nay-sayers that we really don't want to have
special treatment of magic environment variables.

It's no surprise that the launcher and process maintainers
resist the addition of AWT-specific code into their area.

Immutability of the process environment is generally
considered a feature, even though it is occasionally
annoying - just like the immutability of String.

The party line as of 7 years ago was that
environment variables were evil and shouldn't
be used at all - favor system properties instead.

Martin

On Thu, Oct 15, 2009 at 08:10, Michael McMahon <Michael.McMahon at sun.com> wrote:
> It doesn't seem right to filter out arbitrary environment variables
> like that (inside ProcessEnvironment). Sorry, I haven't been following this
> issue closely,
> but is it not possible to unset this variable somewhere else?
>
> - Michael.
>
> Alan Bateman wrote:
>>
>> Martin, Michael - have either of you looked at the filtering that they are
>> proposing to add to ProcessEnvironment?
>>
>>
>> Anthony Petrov wrote:
>>>
>>> Hello,
>>>
>>> Please review the next version of the fix contributed by Damjan
>>> Jovanovic:
>>>
>>> RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094
>>> There you can also find some latest comments regarding the fix.
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.1/
>>>
>>> Since the patch includes changes to the
>>> src/solaris/classes/java/lang/ProcessEnvironment.java, I'm
>>> CC'ing the Core Libs alias to review the changes in that file.
>>>
>>>
>>> From AWT perspective, the changes look good to me.
>>>
>>> --
>>> best regards,
>>> Anthony
>>
>
>