Code review request for 6990094 "ObjectInputStream cloneArray doesn't handle short[]"

Ulf Zibis Ulf.Zibis at gmx.de
Tue Dec 7 11:55:12 UTC 2010


Am 03.12.2010 17:06, schrieb Joe Darcy:
>
> [1] "There are two ways of constructing a software design. One way is to make it so simple that 
> there are obviously no deficiencies. And the other way is to make it so complicated that there are 
> no obvious deficiencies." C.A.R. Hoare]
>

I think, the reason for this bug is the unconventional order of the items in the if...else... sequence.
Why don't you order it like? :
Object
boolean
byte
char
short
int
long
float
double

(hopefully we soon have switch...case on instanceof and objects!)

-Ulf





More information about the core-libs-dev mailing list