review of simple pack200 fix
John Rose
john.r.rose at oracle.com
Thu Dec 16 00:43:16 UTC 2010
Reviewed, but the test case has an error; is it intentional?
The CODE_ATTRIBUTE_PFX already ends with a dot '.', but you add another dot onto it. This will cause the declaration to be ineffectual, but in a non-obvious way.
-- John
On Dec 15, 2010, at 2:45 PM, Kumar Srinivasan wrote:
> Hi,
>
> Could you please review this simple fix, it guards the switch value from a null.
>
> http://cr.openjdk.java.net/~ksrini/7007157/webrev.00/
>
> Thanks
> Kumar
>
>
>
More information about the core-libs-dev
mailing list