Sunbug 6934356: Vector.writeObject() synchronization risks serialization deadlock

[Neil Richards]

On 16 December 2010 16:24, Neil Richards <neil.richards at ngmr.net> wrote:
> On 16 December 2010 13:01, Alan Bateman <Alan.Bateman at oracle.com> wrote:
>> On the test case, it needs the GPL header. There are templates in the
>> repository and you'll also see tests contributed by RedHat and Google if
>> that helps.
>
> Ah, sorry. I'll work on getting the right words in there, and will
> attach a modified changeset as soon as I have it sorted.
>
>> Another thing to mention is that hard-coded timeouts are
>> problematic. In this case a 1s timeout might not be sufficient when on a
>> machine that is running many tests concurrently. One suggestion is to just
>> leave the threads deadlock and the test will timeout and fail if the bug
>> exists.
>
> So I'm happy to modify the test if the jtreg test harness deals with
> cleaning up hanging tests, reporting them as failures.

As trailed, please find attached a modified changeset, eliminating the
timeout from the testcase, and adding an appropriate header.

I've also added a second testcase, which demonstrates that Vector
serialization still works with the fix.

Please review this modified changeset, and let me know if anything
further is required for its acceptance.

Cheers,
Neil

--
Unless stated above:
IBM email: neil_richards at uk.ibm.com
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6934356.export
Type: application/octet-stream
Size: 11085 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20101221/6945e28f/6934356.export>