Review for CR 6728865 : Improved heuristics for Collections.disjoint() [updated]

Mike Duigou mike.duigou at oracle.com
Thu Dec 23 19:46:14 UTC 2010


I have updated the webrev with the javadoc changes (identical to below) and Ulf's suggested code changes:

http://cr.openjdk.java.net/~mduigou/6728865.3/webrev/

Mike

On Dec 23 2010, at 02:02 , Chris Hegarty wrote:

> Mike,
> 
> I'm happy with the latest wording, it looks much better.
> 
> -Chris.
> 
> On 23/12/2010 01:23, Mike Duigou wrote:
>> Here's another try that tries to use similar wording to Collection:
>>      *
>>      *<p>Care must also be exercised when using collections that have
>>      * restrictions on the elements that they may contain. Collection
>>      * implementations are allowed to throw exceptions for any operation
>>      * involving elements they deem ineligible. For absolute safety the
>>      * specified collections should contain only elements which are
>>      * eligible elements for both collections.
>> 
>> And for the throws:
>> 
>>      * @throws NullPointerException if either collection is {@code null}.
>>      * @throws NullPointerException if one collection contains a {@code null}
>>      * element and {@code null} is not an eligible element for the other collection.
>>      * (optional)
>>      * @throws ClassCastException if one collection contains an element that is
>>      * of a type which is ineligible for the other collection. (optional)
>> 




More information about the core-libs-dev mailing list