Review request for 6925868: Eliminate pack200's dependency on logging

Rémi Forax forax at univ-mlv.fr
Fri Feb 12 09:04:09 UTC 2010


Le 12/02/2010 09:59, Alan Bateman a écrit :
> Mandy Chung wrote:
>> Kumar or Alan,
>>
>> Can you please review the fix for:
>>   6925868: Eliminate pack200's dependency on logging
>>
>> Webrev at:
>>  http://cr.openjdk.java.net/~mchung/6925868/webrev.00/
>>
>> The change is trivial.  It replaces the use of 
>> java.util.logging.Logger with its own wrapper class to call 
>> PlatformLogger.
>>
>> Thanks
>> Mandy
> Looks OK to me.
>
> -Alan.

No ok for me,
Pack200Logger.warning(String) goes to an infinite loop,
it should be:

public void warning(String msg) {
   getLogger().warning(msg);
}

Rémi





More information about the core-libs-dev mailing list