Request for approval: Allow Java's ELF symtab reader to use separate debuginfo files

[Kelly O'Hair]

Andrew Haley wrote:
> On 12/09/2009 03:36 PM, Andrew Haley wrote:
>> This is https://bugzilla.redhat.com/show_bug.cgi?id=541548
>> The symptom is that jmap doesn't work because target libraries are stripped.
>> The fix is to allow the symtab reader to use the separate debuginfo files
>> that are available for all (AFAIK) GNU/Linux distributions.
> 
> This is now also https://bugs.openjdk.java.net/show_bug.cgi?id=100126
> 
> Webrev at http://cr.openjdk.java.net/~aph/100126-hotspot-webrev/
> 
> I have now checked several Linux distros, old and new, and although
> they keep their debuginfo files in different places, this patch works
> on all of them.
> 
> Is this OK?  And, if so, which repos should I push the patch to?
> 

I'm a little concerned about the impact this might have on hotspot
as it will eventually get delivered into a jdk6 release (I assume).
And jdk6 does builds on really old Linux systems, e.g.
"Red Hat Enterprise Advanced Server 2.1 update 2".
Can you think of anything that might be a problem with that?
Either at compile time or runtime?

I still am a bit uncomfortable with that 1K block of bytes we are adding,
but I'll resign from that debate, if this is the official way to do it.
How many of these 1K blocks are floating around the system? :^(

The change probably needs to go through one of the hotspot forests, maybe
hotspot-rt?

In the meantime, I will take this patch and apply it, and make sure
hotspot still builds with the jdk6 and jdk7 Linux systems we have.

-kto

> Thanks.
> Andrew.