Code review request for 6828204 NavigableSet.subSet() documentation refers to nonexistent parameters

Martin Buchholz martinrb at google.com
Mon Jan 11 22:24:25 UTC 2010


Approved!

Thanks for the fix.

Martin

On Mon, Jan 11, 2010 at 13:17, Joseph D. Darcy <Joe.Darcy at sun.com> wrote:
> Hello.
>
> Please review this simple typo fix for 6828204 "NavigableSet.subSet()
> documentation refers to nonexistent parameters":
>
> --- old/src/share/classes/java/util/NavigableMap.java    2010-01-11
> 13:13:28.000000000 -0800
> +++ new/src/share/classes/java/util/NavigableMap.java    2010-01-11
> 13:13:28.000000000 -0800
> @@ -298,7 +298,7 @@
>     * Returns a view of the portion of this map whose keys range from
>     * {@code fromKey} to {@code toKey}.  If {@code fromKey} and
>     * {@code toKey} are equal, the returned map is empty unless
> -     * {@code fromExclusive} and {@code toExclusive} are both true.  The
> +     * {@code fromInclusive} and {@code toInclusive} are both true.  The
>     * returned map is backed by this map, so changes in the returned map are
>     * reflected in this map, and vice-versa.  The returned map supports all
>     * optional map operations that this map supports.
> --- old/src/share/classes/java/util/NavigableSet.java    2010-01-11
> 13:13:29.000000000 -0800
> +++ new/src/share/classes/java/util/NavigableSet.java    2010-01-11
> 13:13:29.000000000 -0800
> @@ -192,7 +192,7 @@
>     * Returns a view of the portion of this set whose elements range from
>     * {@code fromElement} to {@code toElement}.  If {@code fromElement} and
>     * {@code toElement} are equal, the returned set is empty unless {@code
> -     * fromExclusive} and {@code toExclusive} are both true.  The returned
> set
> +     * fromInclusive} and {@code toInclusive} are both true.  The returned
> set
>     * is backed by this set, so changes in the returned set are reflected in
>     * this set, and vice-versa.  The returned set supports all optional set
>     * operations that this set supports.
>
> http://cr.openjdk.java.net/~darcy/6828204.0/
>
> Thanks,
>
> -Joe
>



More information about the core-libs-dev mailing list