Review request for 6961894: TEST_BUG: jdk_lang tests fail in samevm mode
Mandy Chung
mandy.chung at ORACLE.COM
Thu Jun 17 16:06:32 UTC 2010
Alan Bateman wrote:
> Mandy Chung wrote:
>> Another patch of test fixes - with these fixes, there are now 5
>> remaining tests in ProblemList.txt excluded for jdk_lang test target.
>>
>> 6961894: TEST_BUG: jdk_lang tests fail in samevm mode
>>
>> Webrev at:
>> http://cr.openjdk.java.net/~mchung/6961894/webrev.00/
>>
>> - Some tests are marked to run in othervm mode
>> - Some java/lang/management tests are cleaned up to restore the state
>> before it finishes.
>> - java/lang/reflect/Proxy and a few tests have its custom
>> classloader. Fix them to use the proper parent class loader.
>>
>> Thanks
>> Mandy
> This mostly look good to me.
>
> One comment on the M&M tests that still run in samevm mode, is that it
> might be nicer to restore the settings in a finally block. That will
> ensure they are restored in the event that the test fails.
Good suggestion. I'll make the change.
> That could work in
> test/java/lang/management/ThreadMXBean/{Enable,Disable}Test.java for
> example. Also in
> test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java.
>
> Thanks for removing
> sun/management/jmxremote/bootstrap/JvmstatCountersTest.java from the
> list - I didn't realize it was the problem list when fixing 6950927. I
> notice you've also removed a few java/util/ResourceBundle and
> java/util/Locale tests from the problem - is this list problem list
> maintenance?
Yes, some tests were fixed but the problem list was not updated.
Thanks
Mandy
More information about the core-libs-dev
mailing list