TEST_BUG: Tests in java/util/zip/ZipFile leave file open
Alan Bateman
Alan.Bateman at oracle.com
Thu Jun 17 18:34:09 UTC 2010
Xueming Shen wrote:
> These tests leave either ZipFile or io stream open after testing, fail
> in samevm mode, so are not in
> ProblemList.txt now. With the change they now all pass.
>
> http://cr.openjdk.java.net/~sherman/6962067/webrev
>
> Thanks,
> -Sherman
Good to see more tests coming off the "problem list".
In test/java/util/zip/Info.java would it be nicer to put a try/finally
around the usage of the ZipInputStream so that it closes even when the
test fails. Same thing in test/java/util/zip/Comment.java. In
ManyEntries.java it would also be nice to put a try/finally about the
usage of zos.
I notice you've changed the copyright date in 3 of the tests. I think
the deal is that we are supposed convert it to a range and keep the
original year (look at other files for examples). I think Kelly
mentioned he's going to cook up a script that will occasionally fix up
the second year, and save us needing to touch it.
-Alan.
More information about the core-libs-dev
mailing list