Codereview needed for #6929479
Alan Bateman
Alan.Bateman at Sun.COM
Thu Mar 11 15:34:43 UTC 2010
Xueming Shen wrote:
> Alan,
>
> webrev has been updated to use the sun.zip.disableMemoryMapping
>
> http://cr.openjdk.java.net/~sherman/6929479/webrev
>
> Please review.
>
> Thanks,
> Sherman
I agree it's a better name. In ZipFile it would be good to put a
comment at the initialization so that the reader understands what this
property is about. Minor nit in zip_util.c at L805 is that it looks like
the indenting it out by one. In any case, this will be a useful
debugging option for the next time that someone steps on their own feet.
-Alan
More information about the core-libs-dev
mailing list