review request for 6798511/6860431: Include functionality of Surrogate in Character

[Martin Buchholz]

On Sat, Mar 20, 2010 at 17:13, Ulf Zibis <Ulf.Zibis at gmx.de> wrote:
> Am 20.03.2010 01:13, schrieb Martin Buchholz:
> Don't you think we should add a hint to javadoc to inform the user about the
> implementation difference between isSupplementaryCodePoint and
> isValidCodePoint?

No.

> It's likely, the user would use isBMPCodePoint and isSupplementaryCodePoint
> as pair, not knowing about the performance problem.

I don't think it's a performance problem in the real world.

We don't usually put such performance information in the javadoc.

Can you demonstrate a performance advantage
of your implementation of isSupplementaryCodePoint
for BMP characters, when there is no call to
isBMPCodePoint?  (Such a demonstration typically
requires testing on a large variety of systems and JITs)

Martin