String.lastIndexOf confused by unpaired trailing surrogate

Ulf Zibis Ulf.Zibis at gmx.de
Sun Mar 21 10:24:49 UTC 2010


Am 21.03.2010 09:05, schrieb Martin Buchholz:
> On Sat, Mar 20, 2010 at 15:50, Ulf Zibis<Ulf.Zibis at gmx.de>  wrote:
>    
>> Why don't you outsource indexOfBMP, lastIndexOfBMP, or to be sincere IMO to
>> much source code + byte code overhead for a only once used 3-liner.
>>      
> I'm not sure I understand your intent.
>    

I think, we should not define a distinct method for this once-used 3-liner:
              for (; i < max-1; i++)
                  if (v[i] == high && v[i+1] == low)
                          return i - offset;

HotSpots resources should not be over-stressed to inline such things, 
having more reserves for more important things.


>    
>> I suspect if all the finals will have any benefit. Some time ago I too felt
>> in that trap, or am I wrong. Examine the disassambly.
>>      
> My use of "final" is almost always for software engineering reasons,
> not for performance reasons.
>    

Ah, ok, just a kind of coding style.

-Ulf





More information about the core-libs-dev mailing list