4813885: RFE: GZIPOutputStream should implement flush using Z_SYNC_FLUSH

Martin Buchholz martinrb at google.com
Wed May 19 04:35:16 UTC 2010


The Z_PARTIAL_FLUSH mini-controversy should not
hold up the commit of
4813885: RFE: GZIPOutputStream should implement flush using Z_SYNC_FLUSH

It looks good to me, except for two
unnecessary added blank lines

      * @exception IllegalArgumentException if size is <= 0
+
      */

     }

+
     /**
      * Creates a new output stream with a default buffer size.

Martin

On Wed, May 12, 2010 at 15:51, Xueming Shen <xueming.shen at oracle.com> wrote:
> Martin,
>
> Would you please help review the change for
>
> 4813885: RFE: GZIPOutputStream should implement flush using Z_SYNC_FLUSH
>
> http://cr.openjdk.java.net/~sherman/4813885/webrev
>
> It appears people want to have the same flush option in GZIPOutputStream as
> the
> one we provided in DeflaterOutputStream for #4206909 a while ago, the webrev
> for
> 4206909 is at
>
> http://cr.openjdk.java.net/~sherman/4206909/webrev
>
> Thanks,
> -Sherman
>



More information about the core-libs-dev mailing list