Please review java.util.jar.pack.* exceptions

Mike Duigou mike.duigou at oracle.com
Tue Nov 2 22:04:10 UTC 2010


- ClassReader.java: I think the change of the copyright date is incorrect. It should be "2001, 2005, 2010" or "2001, 2005-2010".

- In PackerImpl if the exception thrown is an IOException it is not re-thrown. By not initializing inFiles this code path would have been seen as "inFiles not initialized" at the inFiles.size() expression.

Mike


On Nov 2 2010, at 14:10 , Kumar Srinivasan wrote:

> Hi,
> 
> These are simple changes to the java.util.jar.pack:
>  * fixes JCK  failures, specifically throwing unexpected exceptions
>  * minor fixes to the ClassFormatException
>  * added a new test to catch the JCK type failures up-front, which is
>    bulk of the code changes.
> 
> http://cr.openjdk.java.net/~ksrini/6985763/webrev.00/
> 
> Thanks
> Kumar
> 




More information about the core-libs-dev mailing list