hg: jdk7/tl/langtools: 6900037: javac should warn if earlier -source is used and bootclasspath not set

[David Holmes]

Jon,

This change:

--- 
a/src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java 
Sun Oct 03 19:40:15 2010 +0100
+++ 
b/src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java 
Mon Nov 29 14:15:36 2010 -0800
@@ -170,6 +170,11 @@ public class JavacPathFileManager extend
}
return getClassLoader(lb.toArray(new URL[lb.size()]));
+ }
+
+ @Override
+ public boolean isDefaultBootClassPath() {
+ return searchPaths.isDefaultBootClassPath();
}

causes a build failure:

/java/embedded/ws/j2se-baseline/1.7.0/langtools/src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java:177: 
isDefaultBootClassPath() is not public in Paths; cannot be accessed from 
outside package
     [javac]         return searchPaths.isDefaultBootClassPath();
     [javac]                           ^
     [javac] 1 error

because it's a package-private method:

--- a/src/share/classes/com/sun/tools/javac/file/Paths.java Mon Jul 26 
14:25:56 2010 -0700
+++ b/src/share/classes/com/sun/tools/javac/file/Paths.java Mon Nov 29 
14:15:36 2010 -0800
@@ -114,6 +114,11 @@ public class Paths {
...
+
+ boolean isDefaultBootClassPath() {
+ lazy();
+ return isDefaultBootClassPath;
}

David
-----

jonathan.gibbons at oracle.com said the following on 11/30/10 08:16:
> Changeset: c44234f680da
> Author:    jjg
> Date:      2010-11-29 14:15 -0800
> URL:       http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c44234f680da
> 
> 6900037: javac should warn if earlier -source is used and bootclasspath not set
> Reviewed-by: darcy
> 
> ! src/share/classes/com/sun/tools/javac/code/Lint.java
> ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java
> ! src/share/classes/com/sun/tools/javac/file/Paths.java
> ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
> ! src/share/classes/com/sun/tools/javac/main/Main.java
> ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java
> ! src/share/classes/com/sun/tools/javac/resources/compiler.properties
> ! src/share/classes/com/sun/tools/javac/util/BaseFileManager.java
> ! test/tools/javac/6341866/T6341866.java
> ! test/tools/javac/ClassFileModifiers/MemberModifiers.java
> + test/tools/javac/T6900037.java
> + test/tools/javac/T6900037.out
> ! test/tools/javac/TryWithResources/PlainTry.java
> ! test/tools/javac/annotations/neg/Dep.java
> ! test/tools/javac/diags/examples/AnnotationsNotSupported.java
> ! test/tools/javac/diags/examples/AssertAsIdentifier.java
> ! test/tools/javac/diags/examples/DiamondNotSupported.java
> ! test/tools/javac/diags/examples/EnumAsIdentifier.java
> ! test/tools/javac/diags/examples/EnumsNotSupported.java
> ! test/tools/javac/diags/examples/Expected2.java
> ! test/tools/javac/diags/examples/ForeachNotSupported.java
> ! test/tools/javac/diags/examples/GenericsNotSupported.java
> ! test/tools/javac/diags/examples/MulticatchNotSupported.java
> ! test/tools/javac/diags/examples/NeitherConditionalSubtype.java
> + test/tools/javac/diags/examples/SourceNoBootclasspath.java
> ! test/tools/javac/diags/examples/StaticImportNotSupported.java
> ! test/tools/javac/diags/examples/StringSwitchNotSupported.java
> ! test/tools/javac/diags/examples/TryResourceNotSupported.java
> ! test/tools/javac/diags/examples/TryWithoutCatchOrFinally.java
> ! test/tools/javac/diags/examples/UnsupportedBinaryLiteral.java
> ! test/tools/javac/diags/examples/UnsupportedFpLit.java
> ! test/tools/javac/diags/examples/UnsupportedUnderscoreLiteral.java
> ! test/tools/javac/diags/examples/VarargsNotSupported.java
> ! test/tools/javac/enum/6384542/T6384542.java
> ! test/tools/javac/enum/6384542/T6384542a.java
> ! test/tools/javac/literals/BadBinaryLiterals.java
> ! test/tools/javac/literals/BadUnderscoreLiterals.java
> ! test/tools/javac/processing/warnings/TestSourceVersionWarnings.java
> ! test/tools/javac/varargs/warning/Warn1.java
>