From Alan.Bateman at oracle.com Fri Oct 1 11:03:29 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 01 Oct 2010 12:03:29 +0100 Subject: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1 In-Reply-To: <4CA50F3D.8090509@oracle.com> References: <4CA50F3D.8090509@oracle.com> Message-ID: <4CA5C001.6030906@oracle.com> Xueming Shen wrote: > : > > It still appears the memory/buffer handling code in Inflater.c can be > changed to improve > the performance in use cases similar to above mentioned scenario. The > proposed change > is to copy no more than the size of the "user's buffer". It's an > de-compression, so you can't > consume more bytes than you can write out in most cases. The attached > test case shows > the performance of gzip-ing the un-compressed rt.jar by using > different buffer size. Good find! It might be a bit clearer in the Z_OK/Z_NEED_DICT cases if you added a "consumed" variable, eg: case Z_OK: jint consumed = in_len - strm->avail_in; : That would make the update of the input off/len a bit clearer. Otherwise looks good to me. -Alan. From lance.andersen at oracle.com Fri Oct 1 18:37:29 2010 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Fri, 01 Oct 2010 18:37:29 +0000 Subject: hg: jdk7/tl/jdk: 6988993: Address Findbugs warnings for the use of String Constructor Message-ID: <20101001183739.48DA447E28@hg.openjdk.java.net> Changeset: 9a8022905f6a Author: lancea Date: 2010-10-01 14:36 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a8022905f6a 6988993: Address Findbugs warnings for the use of String Constructor Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/RowSetMetaDataImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/share/classes/javax/sql/rowset/serial/SerialStruct.java From alan.bateman at oracle.com Sat Oct 2 12:01:36 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 02 Oct 2010 12:01:36 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101002120155.E357F47E5D@hg.openjdk.java.net> Changeset: f439d8b1e84a Author: alanb Date: 2010-10-02 12:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f439d8b1e84a 6979526: (file) java/nio/file/FileStore/Basic.java fails if the same file system is mounted more than once Reviewed-by: kevinw, forax ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! src/solaris/classes/sun/nio/fs/SolarisFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! test/java/nio/file/FileStore/Basic.java Changeset: a6591c8b046d Author: alanb Date: 2010-10-02 12:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a6591c8b046d Merge From alan.bateman at oracle.com Mon Oct 4 07:49:54 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 04 Oct 2010 07:49:54 +0000 Subject: hg: jdk7/tl/langtools: 6907737: (file) FileVisitor and Files.walkFileTree issues Message-ID: <20101004074956.EFF0047EC1@hg.openjdk.java.net> Changeset: 232919708730 Author: alanb Date: 2010-10-03 19:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/232919708730 6907737: (file) FileVisitor and Files.walkFileTree issues Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java From alan.bateman at oracle.com Mon Oct 4 07:49:27 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 04 Oct 2010 07:49:27 +0000 Subject: hg: jdk7/tl/jdk: 6907737: (file) FileVisitor and Files.walkFileTree issues Message-ID: <20101004074936.CCEF447EBF@hg.openjdk.java.net> Changeset: 81b0c1e3d5a7 Author: alanb Date: 2010-10-03 19:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81b0c1e3d5a7 6907737: (file) FileVisitor and Files.walkFileTree issues Reviewed-by: sherman + src/share/classes/java/nio/file/FileSystemLoopException.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/FileVisitOption.java ! src/share/classes/java/nio/file/FileVisitor.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/SimpleFileVisitor.java ! src/share/sample/nio/file/Chmod.java ! src/share/sample/nio/file/Copy.java ! src/share/sample/nio/file/WatchDir.java + test/java/nio/file/Files/MaxDepth.java ! test/java/nio/file/Files/Misc.java ! test/java/nio/file/Files/PrintFileTree.java ! test/java/nio/file/Files/SkipSiblings.java ! test/java/nio/file/Files/TerminateWalk.java ! test/java/nio/file/Files/WalkWithSecurity.java ! test/java/nio/file/Files/walk_file_tree.sh ! test/java/nio/file/TestUtil.java From alan.bateman at oracle.com Mon Oct 4 13:26:06 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 04 Oct 2010 13:26:06 +0000 Subject: hg: jdk7/tl/jdk: 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol) Message-ID: <20101004132616.2E88047ECF@hg.openjdk.java.net> Changeset: b8af3bab5dbf Author: alanb Date: 2010-10-04 14:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8af3bab5dbf 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol) Reviewed-by: chegar, michaelm ! src/solaris/native/java/net/net_util_md.c ! test/java/nio/channels/AsynchronousServerSocketChannel/Basic.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java ! test/java/nio/channels/DatagramChannel/SocketOptionTests.java ! test/java/nio/channels/ServerSocketChannel/SocketOptionTests.java ! test/java/nio/channels/SocketChannel/SocketOptionTests.java From lance.andersen at oracle.com Mon Oct 4 18:08:57 2010 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Mon, 04 Oct 2010 18:08:57 +0000 Subject: hg: jdk7/tl/jdk: 6989139: Address JDBC Findbugs where Number type Constructor are used Message-ID: <20101004180908.1D93847EDA@hg.openjdk.java.net> Changeset: ffaf6a35b895 Author: lancea Date: 2010-10-04 13:04 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ffaf6a35b895 6989139: Address JDBC Findbugs where Number type Constructor are used Reviewed-by: ohair ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlWriter.java ! src/share/classes/com/sun/rowset/internal/XmlReaderContentHandler.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java ! src/share/classes/javax/sql/rowset/serial/SerialRef.java From alan.bateman at oracle.com Tue Oct 5 14:32:03 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 05 Oct 2010 14:32:03 +0000 Subject: hg: jdk7/tl/jdk: 6987116: (so) test/java/nio/channels/SocketChannel/VectorIO.java failed on Solaris 11 Message-ID: <20101005143223.393FB47F0C@hg.openjdk.java.net> Changeset: b468b20a98a8 Author: alanb Date: 2010-10-05 15:07 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b468b20a98a8 6987116: (so) test/java/nio/channels/SocketChannel/VectorIO.java failed on Solaris 11 Reviewed-by: forax ! test/java/nio/channels/SocketChannel/VectorIO.java From xueming.shen at oracle.com Tue Oct 5 18:04:06 2010 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 05 Oct 2010 11:04:06 -0700 Subject: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1 In-Reply-To: <4CA5C001.6030906@oracle.com> References: <4CA50F3D.8090509@oracle.com> <4CA5C001.6030906@oracle.com> Message-ID: <4CAB6896.2090904@oracle.com> Thanks! webrev has been updated as suggested. http://cr.openjdk.java.net/~sherman/6975829/webrev/ -Sherman On 10/01/2010 04:03 AM, Alan Bateman wrote: > Xueming Shen wrote: >> : >> >> It still appears the memory/buffer handling code in Inflater.c can be >> changed to improve >> the performance in use cases similar to above mentioned scenario. The >> proposed change >> is to copy no more than the size of the "user's buffer". It's an >> de-compression, so you can't >> consume more bytes than you can write out in most cases. The attached >> test case shows >> the performance of gzip-ing the un-compressed rt.jar by using >> different buffer size. > Good find! > > It might be a bit clearer in the Z_OK/Z_NEED_DICT cases if you added a > "consumed" variable, eg: > > case Z_OK: > jint consumed = in_len - strm->avail_in; > : > > That would make the update of the input off/len a bit clearer. > > Otherwise looks good to me. > > -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.gibbons at oracle.com Tue Oct 5 18:34:59 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 05 Oct 2010 18:34:59 +0000 Subject: hg: jdk7/tl/langtools: 6988836: A new JavacElements is created for each round of annotation processing Message-ID: <20101005183505.1C50B47F16@hg.openjdk.java.net> Changeset: 971c8132f5b2 Author: jjg Date: 2010-10-05 11:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/971c8132f5b2 6988836: A new JavacElements is created for each round of annotation processing Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/model/JavacTypes.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/environment/round/TestContext.java From Alan.Bateman at oracle.com Tue Oct 5 19:18:34 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 05 Oct 2010 20:18:34 +0100 Subject: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1 In-Reply-To: <4CAB6896.2090904@oracle.com> References: <4CA50F3D.8090509@oracle.com> <4CA5C001.6030906@oracle.com> <4CAB6896.2090904@oracle.com> Message-ID: <4CAB7A0A.8090500@oracle.com> Xueming Shen wrote: > Thanks! webrev has been updated as suggested. > > http://cr.openjdk.java.net/~sherman/6975829/webrev/ > > > -Sherman Looks fine. A minor comment is that you don't need to update this_off and it might be clear to just set the offset field to this_off + consumed. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: From xueming.shen at oracle.com Tue Oct 5 19:33:33 2010 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 05 Oct 2010 12:33:33 -0700 Subject: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1 In-Reply-To: <4CAB7A0A.8090500@oracle.com> References: <4CA50F3D.8090509@oracle.com> <4CA5C001.6030906@oracle.com> <4CAB6896.2090904@oracle.com> <4CAB7A0A.8090500@oracle.com> Message-ID: <4CAB7D8D.6000207@oracle.com> On 10/05/2010 12:18 PM, Alan Bateman wrote: > Xueming Shen wrote: >> Thanks! webrev has been updated as suggested. >> >> http://cr.openjdk.java.net/~sherman/6975829/webrev/ >> >> >> -Sherman > Looks fine. A minor comment is that you don't need to update this_off > and it might be clear to just set the offset field to this_off + consumed. > > -Alan. wow, good catch:-) Done. http://cr.openjdk.java.net/~sherman/6975829/webrev/ -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alan.Bateman at oracle.com Tue Oct 5 19:34:35 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 05 Oct 2010 20:34:35 +0100 Subject: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1 In-Reply-To: <4CAB7D8D.6000207@oracle.com> References: <4CA50F3D.8090509@oracle.com> <4CA5C001.6030906@oracle.com> <4CAB6896.2090904@oracle.com> <4CAB7A0A.8090500@oracle.com> <4CAB7D8D.6000207@oracle.com> Message-ID: <4CAB7DCB.5030108@oracle.com> Xueming Shen wrote: > : > wow, good catch:-) > Done. > > http://cr.openjdk.java.net/~sherman/6975829/webrev/ > Looks much better. Thumbs up form me. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: From Alan.Bateman at oracle.com Tue Oct 5 19:45:05 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 5 Oct 2010 12:45:05 -0700 (PDT) Subject: 6983520: java/io/pathNames/GeneralWin32.java fails with jdk7-b108 (win) Message-ID: <4CAB8041.6030809@oracle.com> There are couple of stability issues on Windows arising from the move to the VS2010 compiler a few builds okay. One them is that File's getCanonicalPath and a few others methods crash the VM when the dealing with an invalid drive. This turns out to be regression in the new C runtime library with the _wgetdcwd function. We're following this up with Microsoft but for now, we can workaround this by verifying that the drive is valid. The webrev with the proposed changes is here: http://cr.openjdk.java.net/~alanb/6983520/webrev/ Thanks, Alan. From xueming.shen at oracle.com Tue Oct 5 22:21:55 2010 From: xueming.shen at oracle.com (Xueming Shen) Date: Tue, 05 Oct 2010 15:21:55 -0700 Subject: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1 In-Reply-To: <4CAB7DCB.5030108@oracle.com> References: <4CA50F3D.8090509@oracle.com> <4CA5C001.6030906@oracle.com> <4CAB6896.2090904@oracle.com> <4CAB7A0A.8090500@oracle.com> <4CAB7D8D.6000207@oracle.com> <4CAB7DCB.5030108@oracle.com> Message-ID: <4CABA503.2070300@oracle.com> Alan, It appears we do have a regression test [1] in our repository to make sure that we do NOT do round-trip more than necessary for "short" input. While the change in http://cr.openjdk.java.net/~sherman/6975829/webrev .00 does not "break" anything, it does go to the inflater more than once for this corner case. I updated the webrev to add some "overhead" bytes. This "20 bytes" overhead probably will make some other corner cases less optimistic, but that would not be a regression. http://cr.openjdk.java.net/~sherman/6975829/webrev -Sherman [1] test/java/util/ZipFile/ShortRead.java On 10/05/2010 12:34 PM, Alan Bateman wrote: > Xueming Shen wrote: >> : >> wow, good catch:-) >> Done. >> >> http://cr.openjdk.java.net/~sherman/6975829/webrev/ >> > Looks much better. Thumbs up form me. > > -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: From jonathan.gibbons at oracle.com Wed Oct 6 00:37:11 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 06 Oct 2010 00:37:11 +0000 Subject: hg: jdk7/tl/langtools: 6893932: javah help screen lists -h and -? but does not accept them Message-ID: <20101006003713.20F3247F26@hg.openjdk.java.net> Changeset: 33603a5fa84d Author: jjg Date: 2010-10-05 17:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/33603a5fa84d 6893932: javah help screen lists -h and -? but does not accept them Reviewed-by: darcy ! src/share/classes/com/sun/tools/javah/JavahTask.java + test/tools/javah/TestHelpOpts.java From Alan.Bateman at oracle.com Wed Oct 6 13:19:06 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 06 Oct 2010 14:19:06 +0100 Subject: Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1 In-Reply-To: <4CABA503.2070300@oracle.com> References: <4CA50F3D.8090509@oracle.com> <4CA5C001.6030906@oracle.com> <4CAB6896.2090904@oracle.com> <4CAB7A0A.8090500@oracle.com> <4CAB7D8D.6000207@oracle.com> <4CAB7DCB.5030108@oracle.com> <4CABA503.2070300@oracle.com> Message-ID: <4CAC774A.6050402@oracle.com> Xueming Shen wrote: > Alan, > > It appears we do have a regression test [1] in our repository to make > sure that > we do NOT do round-trip more than necessary for "short" input. While > the change > in http://cr.openjdk.java.net/~sherman/6975829/webrev > .00 > does not > "break" > anything, it does go to the inflater more than once for this corner case. > > I updated the webrev to add some "overhead" bytes. This "20 bytes" > overhead > probably will make some other corner cases less optimistic, but that > would not > be a regression. > > http://cr.openjdk.java.net/~sherman/6975829/webrev > > > -Sherman > > [1] test/java/util/ZipFile/ShortRead.java Yep, the zip code always manages to bite whoever touches it. Is it worth writing a few more tests to make sure that we don't have any regression in other corner cases? Would be better to just initialize in_len to MIN(this_len, len + 20)? (and maybe define a constant for the size of the extra space?). -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: From lance.andersen at oracle.com Wed Oct 6 14:12:58 2010 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Wed, 06 Oct 2010 14:12:58 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101006141318.1FAD447F49@hg.openjdk.java.net> Changeset: 0f23a139e819 Author: lancea Date: 2010-10-06 10:09 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f23a139e819 6988310: SyncFactory.setLogger(Logger,Level) requires unspecified security permission Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: 6fd4928b82a2 Author: lancea Date: 2010-10-06 10:11 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6fd4928b82a2 6988317: RowSetProvider.newFactory() may throw unspecified exception Reviewed-by: darcy ! src/share/classes/javax/sql/rowset/RowSetProvider.java From Alan.Bateman at oracle.com Wed Oct 6 16:18:36 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 06 Oct 2010 17:18:36 +0100 Subject: 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol) Message-ID: <4CACA15C.9030204@oracle.com> The fix for 6981138 a few weeks ago added another test to test/java/lang/ProcessBuilder/Basic.java. That test is failing on Solaris because the asynchronous close of the stream connected to the child's stdout causes the reader thread to throw an IOException with an exception message that the test doesn't expect. In en.* locales, it assumes the exception message will be "Bad file descriptor" but it's actually "Bad file number" on Solaris. It's always fragile to have tests that look at the exception message and it is tempting to just remove these checks. However this test does go out of its way to catch any change in behavior so for now anyway, I just propose make it a bit less fussy. Thanks, -Alan. diff -r b468b20a98a8 test/java/lang/ProcessBuilder/Basic.java --- a/test/java/lang/ProcessBuilder/Basic.java Tue Oct 05 15:07:40 2010 +0100 +++ b/test/java/lang/ProcessBuilder/Basic.java Wed Oct 06 12:25:25 2010 +0100 @@ -1845,7 +1845,7 @@ public class Basic { catch (IOException e) { // e.printStackTrace(); if (EnglishUnix.is() && - ! (e.getMessage().matches(".*Bad file descriptor.*"))) + ! (e.getMessage().matches(".*Bad file.*"))) unexpected(e); } catch (Throwable t) { unexpected(t); }}}; From kelly.ohair at oracle.com Wed Oct 6 16:37:11 2010 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 6 Oct 2010 09:37:11 -0700 Subject: 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol) In-Reply-To: <4CACA15C.9030204@oracle.com> References: <4CACA15C.9030204@oracle.com> Message-ID: Looks ok to me. Maybe your comment should be added to the test? Might explain the code better. -kto On Oct 6, 2010, at 9:18 AM, Alan Bateman wrote: > > The fix for 6981138 a few weeks ago added another test to test/java/ > lang/ProcessBuilder/Basic.java. That test is failing on Solaris > because the asynchronous close of the stream connected to the > child's stdout causes the reader thread to throw an IOException with > an exception message that the test doesn't expect. In en.* locales, > it assumes the exception message will be "Bad file descriptor" but > it's actually "Bad file number" on Solaris. It's always fragile to > have tests that look at the exception message and it is tempting to > just remove these checks. However this test does go out of its way > to catch any change in behavior so for now anyway, I just propose > make it a bit less fussy. > > Thanks, > > -Alan. > > > diff -r b468b20a98a8 test/java/lang/ProcessBuilder/Basic.java > --- a/test/java/lang/ProcessBuilder/Basic.java Tue Oct 05 15:07:40 > 2010 +0100 > +++ b/test/java/lang/ProcessBuilder/Basic.java Wed Oct 06 12:25:25 > 2010 +0100 > @@ -1845,7 +1845,7 @@ public class Basic { > catch (IOException e) { > // e.printStackTrace(); > if (EnglishUnix.is() && > - ! (e.getMessage().matches(".*Bad > file descriptor.*"))) > + ! (e.getMessage().matches(".*Bad > file.*"))) > unexpected(e); > } > catch (Throwable t) { unexpected(t); }}}; From chris.hegarty at oracle.com Wed Oct 6 19:20:05 2010 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 06 Oct 2010 20:20:05 +0100 Subject: 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol) In-Reply-To: <4CACA15C.9030204@oracle.com> References: <4CACA15C.9030204@oracle.com> Message-ID: <4CACCBE5.3000003@oracle.com> Alan Bateman wrote: > > The fix for 6981138 a few weeks ago added another test to > test/java/lang/ProcessBuilder/Basic.java. That test is failing on > Solaris because the asynchronous close of the stream connected to the > child's stdout causes the reader thread to throw an IOException with an > exception message that the test doesn't expect. In en.* locales, it > assumes the exception message will be "Bad file descriptor" but it's > actually "Bad file number" on Solaris. It's always fragile to have tests > that look at the exception message and it is tempting to just remove > these checks. However this test does go out of its way to catch any > change in behavior so for now anyway, I just propose make it a bit less > fussy. As you say, it's not ideal to have tests that depend on the exception message, but for now this change looks fine. -Chris. > > Thanks, > > -Alan. > > > diff -r b468b20a98a8 test/java/lang/ProcessBuilder/Basic.java > --- a/test/java/lang/ProcessBuilder/Basic.java Tue Oct 05 15:07:40 2010 > +0100 > +++ b/test/java/lang/ProcessBuilder/Basic.java Wed Oct 06 12:25:25 2010 > +0100 > @@ -1845,7 +1845,7 @@ public class Basic { > catch (IOException e) { > // e.printStackTrace(); > if (EnglishUnix.is() && > - ! (e.getMessage().matches(".*Bad file > descriptor.*"))) > + ! (e.getMessage().matches(".*Bad > file.*"))) > unexpected(e); > } > catch (Throwable t) { unexpected(t); }}}; From Alan.Bateman at oracle.com Wed Oct 6 20:37:55 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 06 Oct 2010 21:37:55 +0100 Subject: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code Message-ID: <4CACDE23.5010003@oracle.com> This batch eliminates a bunch of compiler warnings from the native code: http://cr.openjdk.java.net/~alanb/6989466/webrev/ It also fixes an incorrect usage of memset found along the way. -Alan. From gnu_andrew at member.fsf.org Wed Oct 6 20:56:48 2010 From: gnu_andrew at member.fsf.org (Dr Andrew John Hughes) Date: Wed, 6 Oct 2010 21:56:48 +0100 Subject: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code In-Reply-To: <4CACDE23.5010003@oracle.com> References: <4CACDE23.5010003@oracle.com> Message-ID: On 6 October 2010 21:37, Alan Bateman wrote: > > This batch eliminates a bunch of compiler warnings from the native code: > ?http://cr.openjdk.java.net/~alanb/6989466/webrev/ > > It also fixes an incorrect usage of memset found along the way. > > -Alan. > This looks good from reading the patch. I'll give it a test build. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA? 7927 142C 2591 94EF D9D8 From mandy.chung at oracle.com Wed Oct 6 21:28:08 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 06 Oct 2010 14:28:08 -0700 Subject: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code In-Reply-To: <4CACDE23.5010003@oracle.com> References: <4CACDE23.5010003@oracle.com> Message-ID: <4CACE9E8.7030607@oracle.com> On 10/06/10 13:37, Alan Bateman wrote: > > This batch eliminates a bunch of compiler warnings from the native code: > http://cr.openjdk.java.net/~alanb/6989466/webrev/ > Looks good to me. I will defer to your build to verify if there is any remaining one. > It also fixes an incorrect usage of memset found along the way. > Coincidently, this problem was found today: 6989972: JDK_GetVersionInfo0 fails to zero structure Mandy From kelly.ohair at oracle.com Wed Oct 6 21:28:41 2010 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 6 Oct 2010 14:28:41 -0700 Subject: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code In-Reply-To: <4CACDE23.5010003@oracle.com> References: <4CACDE23.5010003@oracle.com> Message-ID: <7F7F3029-1D47-47F6-ADE1-F8CD289404A9@oracle.com> This looks ok to me. If it gets past a JPRT build on all platforms I think it's golden. Thank you. May your fortune cookies always be positive. ;^) -kto On Oct 6, 2010, at 1:37 PM, Alan Bateman wrote: > > This batch eliminates a bunch of compiler warnings from the native > code: > http://cr.openjdk.java.net/~alanb/6989466/webrev/ > > It also fixes an incorrect usage of memset found along the way. > > -Alan. From gnu_andrew at member.fsf.org Wed Oct 6 21:59:37 2010 From: gnu_andrew at member.fsf.org (Dr Andrew John Hughes) Date: Wed, 6 Oct 2010 22:59:37 +0100 Subject: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code In-Reply-To: References: <4CACDE23.5010003@oracle.com> Message-ID: On 6 October 2010 21:56, Dr Andrew John Hughes wrote: > On 6 October 2010 21:37, Alan Bateman wrote: >> >> This batch eliminates a bunch of compiler warnings from the native code: >> ?http://cr.openjdk.java.net/~alanb/6989466/webrev/ >> >> It also fixes an incorrect usage of memset found along the way. >> >> -Alan. >> > > This looks good from reading the patch. ?I'll give it a test build. > -- > Andrew :-) > > Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net) > Fingerprint: F8EF F1EA 401E 2E60 15FA? 7927 142C 2591 94EF D9D8 > It builds and there seem to be notably less warnings. The first I see now is: ../../../src/solaris/bin/java_md.c: In function 'LocateJRE': ../../../src/solaris/bin/java_md.c:871:19: warning: cast from pointer to integer of different size ../../../src/solaris/bin/java_md.c: In function 'ContinueInNewThread0': ../../../src/solaris/bin/java_md.c:1084:14: warning: cast from pointer to integer of different size and then some in the net code. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA? 7927 142C 2591 94EF D9D8 From kelly.ohair at oracle.com Wed Oct 6 22:02:20 2010 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Wed, 6 Oct 2010 15:02:20 -0700 Subject: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code In-Reply-To: <4CACE9E8.7030607@oracle.com> References: <4CACDE23.5010003@oracle.com> <4CACE9E8.7030607@oracle.com> Message-ID: <3211B428-01AB-48BC-8DC3-733EE2B566FF@oracle.com> On Oct 6, 2010, at 2:28 PM, Mandy Chung wrote: > On 10/06/10 13:37, Alan Bateman wrote: >> >> This batch eliminates a bunch of compiler warnings from the native >> code: >> http://cr.openjdk.java.net/~alanb/6989466/webrev/ >> > > Looks good to me. I will defer to your build to verify if there is > any remaining one. > >> It also fixes an incorrect usage of memset found along the way. >> > > Coincidently, this problem was found today: > 6989972: JDK_GetVersionInfo0 fails to zero structure Ah ha! Compiler warnings are your friends. ;^) -kto > > Mandy From joe.darcy at oracle.com Thu Oct 7 04:51:57 2010 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 07 Oct 2010 04:51:57 +0000 Subject: hg: jdk7/tl/jdk: 6917323: serializable classes in java.dyn do not specify serialVersionUIDs Message-ID: <20101007045206.E909F47F6F@hg.openjdk.java.net> Changeset: a6295291fab1 Author: darcy Date: 2010-10-06 21:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a6295291fab1 6917323: serializable classes in java.dyn do not specify serialVersionUIDs Reviewed-by: jrose ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/LinkagePermission.java ! src/share/classes/java/dyn/NoAccessException.java ! src/share/classes/java/dyn/WrongMethodTypeException.java ! src/share/classes/java/lang/LinkageError.java From Alan.Bateman at oracle.com Thu Oct 7 08:28:33 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 07 Oct 2010 09:28:33 +0100 Subject: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code In-Reply-To: References: <4CACDE23.5010003@oracle.com> Message-ID: <4CAD84B1.5070904@oracle.com> Dr Andrew John Hughes wrote: > : > It builds and there seem to be notably less warnings. The first I see now is: > > ../../../src/solaris/bin/java_md.c: In function 'LocateJRE': > ../../../src/solaris/bin/java_md.c:871:19: warning: cast from pointer > to integer of different size > ../../../src/solaris/bin/java_md.c: In function 'ContinueInNewThread0': > ../../../src/solaris/bin/java_md.c:1084:14: warning: cast from pointer > to integer of different size > > and then some in the net code. > Thanks for trying the patch. Yes, there are lots of other warnings that need to be squashed. Kelly has created several bugs: 6989690 for the net code, 6989117 for flibm, 6989471 for zip code and many more. This does mean that the warnings will be fixed over several change-sets. Once they are eliminated then we maybe we can turn on -Werror so that they don't creep in again. -Alan From alan.bateman at oracle.com Thu Oct 7 09:36:10 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 07 Oct 2010 09:36:10 +0000 Subject: hg: jdk7/tl/jdk: 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol) Message-ID: <20101007093634.0CA3E47F7C@hg.openjdk.java.net> Changeset: a2b1ef1294c5 Author: alanb Date: 2010-10-07 10:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a2b1ef1294c5 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol) Reviewed-by: ohair, chegar ! test/java/lang/ProcessBuilder/Basic.java From alan.bateman at oracle.com Thu Oct 7 14:51:07 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 07 Oct 2010 14:51:07 +0000 Subject: hg: jdk7/tl/jdk: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code Message-ID: <20101007145116.BA11247F8D@hg.openjdk.java.net> Changeset: 871cffb21423 Author: alanb Date: 2010-10-07 14:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/871cffb21423 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code Reviewed-by: andrew, mchung, ohair ! src/share/native/common/jdk_util.c ! src/share/native/common/jni_util.c ! src/share/native/java/lang/Class.c ! src/share/native/java/lang/ClassLoader.c ! src/share/native/java/lang/System.c ! src/share/native/java/lang/fdlibm/include/fdlibm.h ! src/share/native/java/lang/reflect/Proxy.c ! src/share/native/java/nio/Bits.c ! src/share/native/sun/management/Flag.c ! src/share/native/sun/misc/VM.c ! src/share/native/sun/misc/VMSupport.c ! src/solaris/native/java/io/UnixFileSystem_md.c ! src/solaris/native/java/io/canonicalize_md.c ! src/solaris/native/java/lang/java_props_md.c ! src/solaris/native/sun/net/sdp/SdpSupport.c ! src/solaris/native/sun/nio/ch/Net.c ! src/solaris/native/sun/nio/ch/SctpNet.c ! src/solaris/native/sun/nio/ch/UnixAsynchronousSocketChannelImpl.c ! src/windows/native/common/jni_util_md.c ! src/windows/native/java/lang/java_props_md.c ! src/windows/native/java/util/TimeZone_md.c ! src/windows/native/sun/nio/ch/ServerSocketChannelImpl.c ! src/windows/native/sun/nio/ch/WindowsSelectorImpl.c From Alan.Bateman at oracle.com Thu Oct 7 18:20:40 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 07 Oct 2010 19:20:40 +0100 Subject: 6989116: (verifier) compiler warning messages Message-ID: <4CAE0F78.6000602@oracle.com> Another small patch to address a few compiler warnings, this time with the old type inference verifier (libverify) when doing debug builds. This is debug code that isn't compiled in when doing product builds. -Alan. diff --git a/src/share/native/common/check_code.c b/src/share/native/common/check_code.c --- a/src/share/native/common/check_code.c +++ b/src/share/native/common/check_code.c @@ -2940,7 +2940,7 @@ merge_into_successors(context_type *cont if (verify_verbose) { jio_fprintf(stdout, " ["); for (i = handler_info_length; --i >= 0; handler_info++) - if (handler_info->start <= inumber && handler_info->end > inumber) + if (handler_info->start <= (int)inumber && handler_info->end > (int)inumber) jio_fprintf(stdout, "%d* ", handler_info->handler); for (i = 0; i < successors_count; i++) jio_fprintf(stdout, "%d ", successors[i]); @@ -3011,7 +3011,8 @@ merge_into_one_successor(context_type *c instruction_data_type *this_idata = &idata[to_inumber]; register_info_type old_reg_info; stack_info_type old_stack_info; - flag_type old_and_flags, old_or_flags; + flag_type old_and_flags = 0; + flag_type old_or_flags = 0; #endif #ifdef DEBUG From xueming.shen at oracle.com Thu Oct 7 18:36:46 2010 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Thu, 07 Oct 2010 18:36:46 +0000 Subject: hg: jdk7/tl/jdk: 6975829: Perf. of gzip in existing JDKs is too slower than in 1.3.1 Message-ID: <20101007183655.6D0A447F98@hg.openjdk.java.net> Changeset: efa8f714fffb Author: sherman Date: 2010-10-07 11:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/efa8f714fffb 6975829: Perf. of gzip in existing JDKs is too slower than in 1.3.1 Summary: Improved memory/buffer handling in Inflater.c Reviewed-by: alanb ! src/share/native/java/util/zip/Inflater.c From kelly.ohair at oracle.com Thu Oct 7 19:02:17 2010 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 7 Oct 2010 12:02:17 -0700 Subject: 6989116: (verifier) compiler warning messages In-Reply-To: <4CAE0F78.6000602@oracle.com> References: <4CAE0F78.6000602@oracle.com> Message-ID: Looks fine. -kto On Oct 7, 2010, at 11:20 AM, Alan Bateman wrote: > > Another small patch to address a few compiler warnings, this time > with the old type inference verifier (libverify) when doing debug > builds. This is debug code that isn't compiled in when doing product > builds. > > -Alan. > > > diff --git a/src/share/native/common/check_code.c b/src/share/native/ > common/check_code.c > --- a/src/share/native/common/check_code.c > +++ b/src/share/native/common/check_code.c > @@ -2940,7 +2940,7 @@ merge_into_successors(context_type *cont > if (verify_verbose) { > jio_fprintf(stdout, " ["); > for (i = handler_info_length; --i >= 0; handler_info++) > - if (handler_info->start <= inumber && handler_info->end > > inumber) > + if (handler_info->start <= (int)inumber && handler_info- > >end > (int)inumber) > jio_fprintf(stdout, "%d* ", handler_info->handler); > for (i = 0; i < successors_count; i++) > jio_fprintf(stdout, "%d ", successors[i]); > @@ -3011,7 +3011,8 @@ merge_into_one_successor(context_type *c > instruction_data_type *this_idata = &idata[to_inumber]; > register_info_type old_reg_info; > stack_info_type old_stack_info; > - flag_type old_and_flags, old_or_flags; > + flag_type old_and_flags = 0; > + flag_type old_or_flags = 0; > #endif > #ifdef DEBUG > From xueming.shen at oracle.com Thu Oct 7 20:36:10 2010 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 07 Oct 2010 13:36:10 -0700 Subject: Code Review Request for 6977738 In-Reply-To: <4C92A899.8000407@oracle.com> References: <4C92A899.8000407@oracle.com> Message-ID: <4CAE2F3A.5070704@oracle.com> Changes in ZipFile.java, Properties.java and XMLUtils.java look fine. -Sherman On 09/16/2010 04:30 PM, Mandy Chung wrote: > > > Fix 6977738: Deadlock between java.lang.ClassLoader and > java.util.Properties > > Webrev at: > http://cr.openjdk.java.net/~mchung/6977738/webrev.00/ > > ClassLoader.getResource locking the system properties object is > deadlock prone. For example, the > sun.misc.Launcher.getBootstrapClassPath() > method is a synchronized method. A thread calling > ClassLoader.getResource method attempts to synchronize on > the system properties object while holding sun.misc.Launcher.class. > It will deadlock if there is another thread is holding the monitor > lock of the system properties object (e.g. calls the Properties.save() > method) while it attempts to load a resource file. In addition, > ClassLoader.getResource may invoke the ZipFile initialization that > also needs to get the system property. > > This fix caches the system properties at initialization so that > the ZipFile and Launcher will read the system property from the > private Properties object. In addition, I make some minor > changes in Properties.save and storeToXML method to confine the > synchronization needed and also have the DownloadManager to > maintain its bootclasspath. > > Thanks > Mandy > From jonathan.gibbons at oracle.com Thu Oct 7 22:27:34 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 07 Oct 2010 22:27:34 +0000 Subject: hg: jdk7/tl/langtools: 6990379: two examples fail under CheckExamples on Windows Message-ID: <20101007222736.A896D47FA1@hg.openjdk.java.net> Changeset: c8b4a1e76089 Author: jjg Date: 2010-10-07 15:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c8b4a1e76089 6990379: two examples fail under CheckExamples on Windows Reviewed-by: darcy ! test/tools/javac/diags/CheckExamples.java ! test/tools/javac/diags/FileManager.java From alan.bateman at oracle.com Fri Oct 8 09:37:42 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 08 Oct 2010 09:37:42 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101008093820.6A7C747FC8@hg.openjdk.java.net> Changeset: fd20568bebff Author: alanb Date: 2010-10-08 10:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd20568bebff 6989116: (verifier) compiler warning messages Reviewed-by: kamg, ohair ! src/share/native/common/check_code.c Changeset: d122e96be7d2 Author: alanb Date: 2010-10-08 10:37 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d122e96be7d2 Merge From iaroslavski at mail.ru Fri Oct 8 10:31:51 2010 From: iaroslavski at mail.ru (Vladimir Iaroslavski) Date: Fri, 08 Oct 2010 14:31:51 +0400 Subject: Update of Dual-Pivot Quicksort, Sorting and Arrays classes In-Reply-To: <4C62A7CA.7030605@mail.ru> References: <4C62A7CA.7030605@mail.ru> Message-ID: <4CAEF317.8080901@mail.ru> Hello! I've updated Dual-Pivot Quicksort, Sorting and Arrays classes, please review. http://cr.openjdk.java.net/~alanb/6976036/webrev In compare with previous version (JDK 7 vs. JDK 6) the ratio is: 52.14% for client and 41.62% for server VM (was 57.22% and 46.18%). Summary of changes: 1. Range check was moved from DualPivotQuicksort to Arrays class. 2. Pair insertion sort is used for sorting small arrays instead of traditional. 3. Added new test in Sorting class: compare with insertion sort on small arrays. 4. Minor cosmetic changes. Thank you, Vladimir From kelly.ohair at oracle.com Fri Oct 8 18:33:13 2010 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 8 Oct 2010 11:33:13 -0700 Subject: Windows VS2010 Message-ID: <2C3A7753-18DD-442C-8E3F-9C3D438FE089@oracle.com> Anyone seen this failure before... The very latest jdk7/tl/jdk repo.... I'm testing Windows XP & VS2010 builds: Created ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/ zip.lcf C:/PROGRA~1/MICROS~2.0/VC/Bin/link -dll -out:../../../build/windows- i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll \ -map:../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/ zip.map \ -nologo /opt:REF /incremental:no /manifest /debug /LIBPATH:C:/DXSDK/ Lib @../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/ zip.lcf \ -export:ZIP_Open -export:ZIP_Close -export:ZIP_FindEntry - export:ZIP_ReadEntry -export:ZIP_GetNextEntry ../../../build/windows- i586/lib/java.lib ../../../build/windows-i586/lib/jvm.lib ../../../ build/windows-i586/lib/java.lib advapi32.lib Creating library ../../../build/windows-i586/tmp/sun/java.util.zip/ zip/obj_gO/zip.lib and object ../../../build/windows-i586/tmp/sun/ java.util.zip/zip/obj_gO/zip.exp Inflater.obj : error LNK2019: unresolved external symbol _MIN referenced in function _Java_java_util_zip_Inflater_inflateBytes at 28 ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll : fatal error LNK1120: 1 unresolved externals C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: *** [../../../ build/windows-i586/bin/zip.dll] Error 1120 C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: Leaving directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java/zip' C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: *** [all] Error 1 C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: Leaving directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java' gnumake.exe[1]: *** [all] Error 1 gnumake.exe[1]: Leaving directory `C:/temp/jprt/P2/B/180435.jprtadm/ source/make' C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [fastdebug] Error 2 -kto From xueming.shen at oracle.com Fri Oct 8 18:41:02 2010 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 08 Oct 2010 11:41:02 -0700 Subject: Windows VS2010 In-Reply-To: <2C3A7753-18DD-442C-8E3F-9C3D438FE089@oracle.com> References: <2C3A7753-18DD-442C-8E3F-9C3D438FE089@oracle.com> Message-ID: <4CAF65BE.3090608@oracle.com> CR 6990639 Created, P3 java/classes_util Fix for #6975829 breaks solaris build. A fix is on the way. Sherman On 10/08/2010 11:33 AM, Kelly O'Hair wrote: > > Anyone seen this failure before... The very latest jdk7/tl/jdk repo.... > > I'm testing Windows XP & VS2010 builds: > > Created > ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.lcf > C:/PROGRA~1/MICROS~2.0/VC/Bin/link -dll > -out:../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll > \ > > -map:../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.map > \ > -nologo /opt:REF /incremental:no /manifest /debug > /LIBPATH:C:/DXSDK/Lib > @../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.lcf \ > -export:ZIP_Open -export:ZIP_Close -export:ZIP_FindEntry > -export:ZIP_ReadEntry -export:ZIP_GetNextEntry > ../../../build/windows-i586/lib/java.lib > ../../../build/windows-i586/lib/jvm.lib > ../../../build/windows-i586/lib/java.lib advapi32.lib > Creating library > ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.lib > and object > ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.exp > Inflater.obj : error LNK2019: unresolved external symbol _MIN > referenced in function _Java_java_util_zip_Inflater_inflateBytes at 28 > ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll : > fatal error LNK1120: 1 unresolved externals > C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: *** > [../../../build/windows-i586/bin/zip.dll] Error 1120 > C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: Leaving directory > `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java/zip' > C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: *** [all] Error 1 > C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: Leaving directory > `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java' > gnumake.exe[1]: *** [all] Error 1 > gnumake.exe[1]: Leaving directory > `C:/temp/jprt/P2/B/180435.jprtadm/source/make' > C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [fastdebug] Error 2 > > -kto > From xueming.shen at oracle.com Fri Oct 8 18:45:53 2010 From: xueming.shen at oracle.com (Xueming Shen) Date: Fri, 08 Oct 2010 11:45:53 -0700 Subject: Windows VS2010 In-Reply-To: <4CAF65BE.3090608@oracle.com> References: <2C3A7753-18DD-442C-8E3F-9C3D438FE089@oracle.com> <4CAF65BE.3090608@oracle.com> Message-ID: <4CAF66E1.7090100@oracle.com> Kelly, Alan might be off-line now. Can you help review the change? The change is to define our own MIN2. http://cr.openjdk.java.net/~sherman/6990639/webrev/ Verified via jprt hotspotwest just know. There was a failure on windows-x64, but it does not appear to be related. Alan said it might be 2D (lcms) related. -Sherman On 10/08/2010 11:41 AM, Xueming Shen wrote: > CR 6990639 Created, P3 java/classes_util Fix for #6975829 breaks > solaris build. > > A fix is on the way. > > Sherman > > On 10/08/2010 11:33 AM, Kelly O'Hair wrote: >> >> Anyone seen this failure before... The very latest jdk7/tl/jdk repo.... >> >> I'm testing Windows XP & VS2010 builds: >> >> Created >> ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.lcf >> C:/PROGRA~1/MICROS~2.0/VC/Bin/link -dll >> -out:../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll >> \ >> >> -map:../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.map >> \ >> -nologo /opt:REF /incremental:no /manifest /debug >> /LIBPATH:C:/DXSDK/Lib >> @../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.lcf \ >> -export:ZIP_Open -export:ZIP_Close -export:ZIP_FindEntry >> -export:ZIP_ReadEntry -export:ZIP_GetNextEntry >> ../../../build/windows-i586/lib/java.lib >> ../../../build/windows-i586/lib/jvm.lib >> ../../../build/windows-i586/lib/java.lib advapi32.lib >> Creating library >> ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.lib >> and object >> ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.exp >> Inflater.obj : error LNK2019: unresolved external symbol _MIN >> referenced in function _Java_java_util_zip_Inflater_inflateBytes at 28 >> ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll >> : fatal error LNK1120: 1 unresolved externals >> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: *** >> [../../../build/windows-i586/bin/zip.dll] Error 1120 >> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: Leaving >> directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java/zip' >> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: *** [all] Error 1 >> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: Leaving >> directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java' >> gnumake.exe[1]: *** [all] Error 1 >> gnumake.exe[1]: Leaving directory >> `C:/temp/jprt/P2/B/180435.jprtadm/source/make' >> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [fastdebug] >> Error 2 >> >> -kto >> > From kelly.ohair at oracle.com Fri Oct 8 19:05:37 2010 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Fri, 8 Oct 2010 12:05:37 -0700 Subject: Windows VS2010 In-Reply-To: <4CAF66E1.7090100@oracle.com> References: <2C3A7753-18DD-442C-8E3F-9C3D438FE089@oracle.com> <4CAF65BE.3090608@oracle.com> <4CAF66E1.7090100@oracle.com> Message-ID: Looks fine to me. -kto On Oct 8, 2010, at 11:45 AM, Xueming Shen wrote: > Kelly, > > Alan might be off-line now. Can you help review the change? > > The change is to define our own MIN2. > > http://cr.openjdk.java.net/~sherman/6990639/webrev/ > > Verified via jprt hotspotwest just know. There was a failure on > windows-x64, > but it does not appear to be related. Alan said it might be 2D > (lcms) related. > > -Sherman > > > On 10/08/2010 11:41 AM, Xueming Shen wrote: >> CR 6990639 Created, P3 java/classes_util Fix for #6975829 breaks >> solaris build. >> >> A fix is on the way. >> >> Sherman >> >> On 10/08/2010 11:33 AM, Kelly O'Hair wrote: >>> >>> Anyone seen this failure before... The very latest jdk7/tl/jdk >>> repo.... >>> >>> I'm testing Windows XP & VS2010 builds: >>> >>> Created ../../../build/windows-i586/tmp/sun/java.util.zip/zip/ >>> obj_gO/zip.lcf >>> C:/PROGRA~1/MICROS~2.0/VC/Bin/link -dll -out:../../../build/ >>> windows-i586/tmp/sun/java.util.zip/zip/obj_gO/zip.dll \ >>> -map:../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/ >>> zip.map \ >>> -nologo /opt:REF /incremental:no /manifest /debug /LIBPATH:C:/ >>> DXSDK/Lib @../../../build/windows-i586/tmp/sun/java.util.zip/zip/ >>> obj_gO/zip.lcf \ >>> -export:ZIP_Open -export:ZIP_Close -export:ZIP_FindEntry - >>> export:ZIP_ReadEntry -export:ZIP_GetNextEntry ../../../build/ >>> windows-i586/lib/java.lib ../../../build/windows-i586/lib/ >>> jvm.lib ../../../build/windows-i586/lib/java.lib advapi32.lib >>> Creating library ../../../build/windows-i586/tmp/sun/ >>> java.util.zip/zip/obj_gO/zip.lib and object ../../../build/windows- >>> i586/tmp/sun/java.util.zip/zip/obj_gO/zip.exp >>> Inflater.obj : error LNK2019: unresolved external symbol _MIN >>> referenced in function _Java_java_util_zip_Inflater_inflateBytes at 28 >>> ../../../build/windows-i586/tmp/sun/java.util.zip/zip/obj_gO/ >>> zip.dll : fatal error LNK1120: 1 unresolved externals >>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: *** [../../../ >>> build/windows-i586/bin/zip.dll] Error 1120 >>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[3]: Leaving >>> directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java/zip' >>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: *** [all] >>> Error 1 >>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe[2]: Leaving >>> directory `C:/temp/jprt/P2/B/180435.jprtadm/source/make/java' >>> gnumake.exe[1]: *** [all] Error 1 >>> gnumake.exe[1]: Leaving directory `C:/temp/jprt/P2/B/ >>> 180435.jprtadm/source/make' >>> C:\jprt\slashjava\devtools\win32\bin\gnumake.exe: *** [fastdebug] >>> Error 2 >>> >>> -kto >>> >> > From Alan.Bateman at oracle.com Fri Oct 8 19:08:29 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 08 Oct 2010 20:08:29 +0100 Subject: Windows VS2010 In-Reply-To: <4CAF66E1.7090100@oracle.com> References: <2C3A7753-18DD-442C-8E3F-9C3D438FE089@oracle.com> <4CAF65BE.3090608@oracle.com> <4CAF66E1.7090100@oracle.com> Message-ID: <4CAF6C2D.3030302@oracle.com> Xueming Shen wrote: > Kelly, > > Alan might be off-line now. Can you help review the change? > > The change is to define our own MIN2. > > http://cr.openjdk.java.net/~sherman/6990639/webrev/ > > Verified via jprt hotspotwest just know. There was a failure on > windows-x64, > but it does not appear to be related. Alan said it might be 2D (lcms) > related. Looks fine to me. The lcms build failure is fixed in the 2d repo [1] but it's in tl/jdk7/jdk yet. -Alan [1] http://hg.openjdk.java.net/jdk7/2d/jdk/rev/160f7ffc3d14 From xueming.shen at oracle.com Fri Oct 8 19:22:41 2010 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 08 Oct 2010 19:22:41 +0000 Subject: hg: jdk7/tl/jdk: 6990639: Fix for #6975829 breaks build Message-ID: <20101008192251.88BD347FE4@hg.openjdk.java.net> Changeset: 63162f0e2609 Author: sherman Date: 2010-10-08 12:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63162f0e2609 6990639: Fix for #6975829 breaks build Summary: define MIN2 micro Reviewed-by: alanb ! src/share/native/java/util/zip/Inflater.c From alan.bateman at oracle.com Mon Oct 11 08:18:47 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 11 Oct 2010 08:18:47 +0000 Subject: hg: jdk7/tl/jdk: 6987154: HTML link to serialization guide is broken Message-ID: <20101011081857.D7D9A47062@hg.openjdk.java.net> Changeset: f0888585b6ff Author: alanb Date: 2010-10-11 09:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f0888585b6ff 6987154: HTML link to serialization guide is broken Reviewed-by: skannan ! src/share/classes/java/io/package.html From chris.hegarty at oracle.com Mon Oct 11 13:23:40 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 11 Oct 2010 13:23:40 +0000 Subject: hg: jdk7/tl/jdk: 26 new changesets Message-ID: <20101011132753.C1A614706F@hg.openjdk.java.net> Changeset: 0e3daaccfbdf Author: xuelei Date: 2010-06-12 00:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0e3daaccfbdf 6914943: Implement final TLS renegotiation fix Summary: RFC 5746 implementation Reviewed-by: wetmore, weijun ! src/share/classes/sun/security/ssl/Alerts.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/CipherSuiteList.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/OutputRecord.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/sslecc/CipherTest.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/InvalidateServerSessionRenegotiate.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/JSSERenegotiate.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/CheckStatus.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/ConnectionTest.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/NoAuthClientAuth.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/TestAllSuites.java ! test/sun/security/ssl/sanity/ciphersuites/CheckCipherSuites.java ! test/sun/security/ssl/sanity/interop/CipherTest.java Changeset: 5d7925b886b9 Author: asaha Date: 2010-06-13 07:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5d7925b886b9 Merge Changeset: 34080da7fab2 Author: asaha Date: 2010-06-15 08:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/34080da7fab2 Merge Changeset: 2bad540d9b5b Author: weijun Date: 2010-06-17 12:59 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2bad540d9b5b 6957564: Disclosure of DNS server IP address Reviewed-by: xuelei, chegar ! src/share/classes/com/sun/jndi/dns/DnsContextFactory.java Changeset: bdc6a3dc3e57 Author: weijun Date: 2010-06-17 12:59 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bdc6a3dc3e57 6958060: Malformed AP-REQ crashes acceptor side Reviewed-by: valeriep, xuelei ! src/share/classes/sun/security/jgss/krb5/InitialToken.java Changeset: b9d3a1a8b682 Author: bae Date: 2010-06-18 13:18 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b9d3a1a8b682 6925710: IndexColorModel.finalize can be made to double free Reviewed-by: igor, prr, hawtin ! src/share/classes/java/awt/image/IndexColorModel.java ! src/share/classes/sun/awt/image/BufImgSurfaceData.java ! src/share/native/sun/awt/image/BufImgSurfaceData.c Changeset: 9ed7ae1e911c Author: rupashka Date: 2010-06-21 16:47 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9ed7ae1e911c 6938813: Swing mutable statics Reviewed-by: peterz, alexp ! src/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/share/classes/javax/swing/text/html/parser/DTD.java ! src/share/classes/javax/swing/text/html/parser/ParserDelegator.java + test/javax/swing/Security/6938813/bug6938813.java Changeset: e06652744211 Author: asaha Date: 2010-06-24 10:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e06652744211 Merge - make/com/sun/inputmethods/Makefile - make/com/sun/inputmethods/indicim/Makefile - make/com/sun/inputmethods/thaiim/Makefile - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/indicim/DevanagariTables.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethod.java - src/share/classes/com/sun/inputmethods/internal/indicim/IndicInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/indicim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_de.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_es.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_fr.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_it.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ja.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_ko.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_sv.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_CN.properties - src/share/classes/com/sun/inputmethods/internal/indicim/resources/DisplayNames_zh_TW.properties - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethod.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodDescriptor.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiInputMethodImpl.java - src/share/classes/com/sun/inputmethods/internal/thaiim/ThaiRules.java - src/share/classes/com/sun/inputmethods/internal/thaiim/java.awt.im.spi.InputMethodDescriptor - src/share/classes/com/sun/inputmethods/internal/thaiim/resources/DisplayNames.properties - src/share/classes/javax/swing/text/html/parser/html32.bdtd - test/java/nio/channels/ServerSocketChannel/AcceptAddress.java Changeset: 505befdee800 Author: asaha Date: 2010-06-28 13:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/505befdee800 Merge Changeset: 5f50e564faa4 Author: bae Date: 2010-06-30 11:32 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5f50e564faa4 6963023: ZDI-CAN-809: Sun JRE JPEGImageWriter.writeImage Remote Code Execution Vulnerability Reviewed-by: prr ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c Changeset: de8991ef7b1b Author: chegar Date: 2010-06-30 16:08 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/de8991ef7b1b 6926623: Thread clone issues Reviewed-by: hawtin ! src/share/classes/java/lang/Thread.java Changeset: b2e9e8d1805c Author: chegar Date: 2010-06-30 16:24 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b2e9e8d1805c Merge Changeset: 32cac17b629e Author: bae Date: 2010-07-01 12:04 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/32cac17b629e 6963489: ZDI-CAN-803: Sun JRE ICC Profile Device Information Tag Remote Code Execution Vulnerability Reviewed-by: prr ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmsxform.c Changeset: 0dbecf98ed6d Author: asaha Date: 2010-07-01 08:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0dbecf98ed6d Merge - test/java/nio/charset/coders/Surrogate.java Changeset: f56ef0d441b0 Author: asaha Date: 2010-07-08 08:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f56ef0d441b0 Merge Changeset: 814604212cc1 Author: asaha Date: 2010-07-16 09:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/814604212cc1 Merge - test/tools/launcher/Makefile.SolarisRunpath - test/tools/launcher/lib/i386/lib32/lib32/liblibrary.so - test/tools/launcher/lib/i386/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib32/liblibrary.so - test/tools/launcher/lib/sparc/lib64/lib64/liblibrary.so - test/tools/launcher/lib/sparc/lib64/liblibrary.so Changeset: e860d935e6e7 Author: michaelm Date: 2010-07-22 16:33 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e860d935e6e7 6952603: NetworkInterface reveals local network address to untrusted code Reviewed-by: chegar ! src/share/classes/java/net/NetworkInterface.java Changeset: e857e8316bf1 Author: michaelm Date: 2010-07-22 17:26 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e857e8316bf1 6952017: HttpURLConnection chunked encoding issue (Http request splitting) Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 9fa1f8b38b6f Author: chegar Date: 2010-08-11 09:32 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9fa1f8b38b6f 6974093: Thread.clone should NOT invoke addUnstarted on started threads Reviewed-by: dholmes, coffeys ! src/share/classes/java/lang/Thread.java Changeset: f5ed38dc8d36 Author: michaelm Date: 2010-09-16 08:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f5ed38dc8d36 6981426: limit use of TRACE method in HttpURLConnection Reviewed-by: chegar ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/NetPermission.java Changeset: e0806d924a42 Author: michaelm Date: 2010-09-16 09:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0806d924a42 6980004: limit HTTP request cookie headers in HttpURLConnection 6961084: limit setting of some request headers in HttpURLConnection Reviewed-by: chegar ! src/share/classes/sun/net/www/MessageHeader.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 11a08845b979 Author: michaelm Date: 2010-09-23 03:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/11a08845b979 6986400: Change Cookie to Cookie2 in 6980004 fix Summary: fix error in previous fix for 6980004 Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 0f510337dadb Author: alexp Date: 2010-10-01 18:39 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f510337dadb 6622002: UIDefault.ProxyLazyValue has unsafe reflection usage Reviewed-by: malenkov ! src/share/classes/javax/swing/UIDefaults.java + test/javax/swing/UIDefaults/6622002/bug6622002.java Changeset: 33cc629889bd Author: chegar Date: 2010-10-08 11:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/33cc629889bd Merge ! src/share/classes/com/sun/jndi/dns/DnsContextFactory.java ! src/share/classes/java/lang/Thread.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/native/sun/awt/image/BufImgSurfaceData.c ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! src/share/native/sun/java2d/cmm/lcms/cmsxform.c Changeset: a50828844ccc Author: chegar Date: 2010-10-08 11:28 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a50828844ccc Merge Changeset: 78bbe8fce2d4 Author: chegar Date: 2010-10-11 10:55 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/78bbe8fce2d4 Merge From jonathan.gibbons at oracle.com Mon Oct 11 17:20:32 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 11 Oct 2010 17:20:32 +0000 Subject: hg: jdk7/tl/langtools: 6990390: javah -help produces help screen with extraneous output Message-ID: <20101011172036.BABE647078@hg.openjdk.java.net> Changeset: 5b5d965900b8 Author: jjg Date: 2010-10-11 10:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5b5d965900b8 6990390: javah -help produces help screen with extraneous output Reviewed-by: darcy ! src/share/classes/com/sun/tools/javah/resources/l10n.properties ! test/tools/javah/TestHelpOpts.java From mandy.chung at oracle.com Tue Oct 12 03:29:40 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 12 Oct 2010 03:29:40 +0000 Subject: hg: jdk7/tl/jdk: 6977738: Deadlock between java.lang.ClassLoader and java.util.Properties Message-ID: <20101012033004.CBC1B4708D@hg.openjdk.java.net> Changeset: b444f86c4abe Author: mchung Date: 2010-10-11 20:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b444f86c4abe 6977738: Deadlock between java.lang.ClassLoader and java.util.Properties Reviewed-by: alanb, sherman, darcy, igor ! make/java/java/FILES_java.gmk ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/util/Properties.java ! src/share/classes/java/util/XMLUtils.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/sun/jkernel/DownloadManager.java ! src/share/classes/sun/misc/BootClassLoaderHook.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/VM.java + test/java/lang/ClassLoader/deadlock/GetResource.java ! test/sun/misc/BootClassLoaderHook/TestHook.java From xueming.shen at oracle.com Tue Oct 12 05:37:52 2010 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 12 Oct 2010 05:37:52 +0000 Subject: hg: jdk7/tl/jdk: 6984046: java/jar jar/pack source needs vendor rebranding changes (jdk7 only) Message-ID: <20101012053802.4CD1647092@hg.openjdk.java.net> Changeset: 33cf668cc160 Author: sherman Date: 2010-10-11 22:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/33cf668cc160 6984046: java/jar jar/pack source needs vendor rebranding changes (jdk7 only) Summary: updated to use appropriate vendor name Reviewed-by: ohair, dholmes ! src/share/classes/sun/tools/jar/CommandLine.java ! test/tools/jar/UpdateManifest.java From alan.bateman at oracle.com Tue Oct 12 08:41:05 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 12 Oct 2010 08:41:05 +0000 Subject: hg: jdk7/tl/jdk: 6728842: File.setReadOnly does not make a directory read-only (win); ... Message-ID: <20101012084114.96D1447099@hg.openjdk.java.net> Changeset: b614af87d00f Author: alanb Date: 2010-10-12 08:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b614af87d00f 6728842: File.setReadOnly does not make a directory read-only (win) 6464744: java/io/File/SetAccess.java ignores sticky bit Reviewed-by: forax ! src/windows/native/java/io/WinNTFileSystem_md.c ! test/java/io/File/SetAccess.java ! test/java/io/File/SetReadOnly.java From alan.bateman at oracle.com Tue Oct 12 09:31:23 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 12 Oct 2010 09:31:23 +0000 Subject: hg: jdk7/tl/jdk: 6983520: java/io/pathNames/GeneralWin32.java fails with jdk7-b108 (win) Message-ID: <20101012093207.586B44709D@hg.openjdk.java.net> Changeset: 1d94b33a8f59 Author: alanb Date: 2010-10-12 09:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d94b33a8f59 6983520: java/io/pathNames/GeneralWin32.java fails with jdk7-b108 (win) Reviewed-by: sherman ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/io/io_util_md.h ! test/java/io/pathNames/GeneralWin32.java From chris.hegarty at oracle.com Tue Oct 12 10:48:17 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 12 Oct 2010 10:48:17 +0000 Subject: hg: jdk7/tl/jdk: 6989690: java/net native code compiler warnings Message-ID: <20101012104836.483C7470A2@hg.openjdk.java.net> Changeset: 4dbd83eb0250 Author: chegar Date: 2010-10-12 11:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4dbd83eb0250 6989690: java/net native code compiler warnings Reviewed-by: alanb ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/sun/net/spi/DefaultProxySelector.c From chris.hegarty at oracle.com Tue Oct 12 16:02:06 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 12 Oct 2010 16:02:06 +0000 Subject: hg: jdk7/tl/jdk: 6991300: MimeTable is unsafe Message-ID: <20101012160215.C48FA470B0@hg.openjdk.java.net> Changeset: a4fd754f895d Author: chegar Date: 2010-10-12 17:01 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a4fd754f895d 6991300: MimeTable is unsafe Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/www/MimeTable.java From kumar.x.srinivasan at oracle.com Tue Oct 12 19:21:07 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Tue, 12 Oct 2010 19:21:07 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101012192126.AF0C3470B9@hg.openjdk.java.net> Changeset: df896f3e6651 Author: ksrini Date: 2010-10-07 14:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df896f3e6651 6894719: (launcher)The option -no-jre-restrict-search is expected when -jre-no-restrict-search is documented. Reviewed-by: darcy ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/launcher/resources/launcher_de.properties ! src/share/classes/sun/launcher/resources/launcher_es.properties ! src/share/classes/sun/launcher/resources/launcher_fr.properties ! src/share/classes/sun/launcher/resources/launcher_it.properties ! src/share/classes/sun/launcher/resources/launcher_ja.properties ! src/share/classes/sun/launcher/resources/launcher_ko.properties ! src/share/classes/sun/launcher/resources/launcher_sv.properties ! src/share/classes/sun/launcher/resources/launcher_zh_CN.properties ! src/share/classes/sun/launcher/resources/launcher_zh_TW.properties ! test/tools/launcher/Arrrghs.java Changeset: 5eb6755dde8e Author: ksrini Date: 2010-10-12 12:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5eb6755dde8e Merge From jonathan.gibbons at oracle.com Tue Oct 12 19:55:16 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 12 Oct 2010 19:55:16 +0000 Subject: hg: jdk7/tl/langtools: 6989457: javadoc test file test/tools/javadoc/T4994049/FileWithTabs.java probably does not Message-ID: <20101012195519.A1ACF470BC@hg.openjdk.java.net> Changeset: 68cf07910d74 Author: jjg Date: 2010-10-12 12:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/68cf07910d74 6989457: javadoc test file test/tools/javadoc/T4994049/FileWithTabs.java probably does not Reviewed-by: mcimadamore ! test/tools/javadoc/T4994049/FileWithTabs.java ! test/tools/javadoc/T4994049/T4994049.java From jonathan.gibbons at oracle.com Tue Oct 12 20:15:13 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 12 Oct 2010 20:15:13 +0000 Subject: hg: jdk7/tl/langtools: 6988407: javac crashes running processor on errant code; it used to print error message Message-ID: <20101012201515.8150E470BD@hg.openjdk.java.net> Changeset: 14a707f8ce84 Author: jjg Date: 2010-10-12 13:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/14a707f8ce84 6988407: javac crashes running processor on errant code; it used to print error message Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! test/tools/javac/api/6406133/Erroneous.java + test/tools/javac/processing/errors/TestParseErrors/ParseErrors.java + test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.java + test/tools/javac/processing/errors/TestParseErrors/TestParseErrors.out From jonathan.gibbons at oracle.com Tue Oct 12 20:19:13 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 12 Oct 2010 20:19:13 +0000 Subject: hg: jdk7/tl/langtools: 4942232: missing param class processes without error Message-ID: <20101012201915.6A819470BE@hg.openjdk.java.net> Changeset: a1d31ab7b525 Author: jjg Date: 2010-10-12 13:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a1d31ab7b525 4942232: missing param class processes without error Reviewed-by: darcy ! src/share/classes/com/sun/tools/javah/JNI.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Mangle.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/com/sun/tools/javah/resources/l10n.properties + test/tools/javah/4942232/ParamClassTest.java + test/tools/javah/4942232/Test.java From jonathan.gibbons at oracle.com Tue Oct 12 21:22:24 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 12 Oct 2010 21:22:24 +0000 Subject: hg: jdk7/tl/langtools: 6990133: AnnotationProxyMaker.ValueVisitor$1 contains non-transient non-serializable field Message-ID: <20101012212226.A1C65470C2@hg.openjdk.java.net> Changeset: ea92d1e275b6 Author: jjg Date: 2010-10-12 14:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ea92d1e275b6 6990133: AnnotationProxyMaker.ValueVisitor$1 contains non-transient non-serializable field Reviewed-by: darcy ! src/share/classes/com/sun/tools/apt/mirror/declaration/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java From jonathan.gibbons at oracle.com Tue Oct 12 21:48:38 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 12 Oct 2010 21:48:38 +0000 Subject: hg: jdk7/tl/langtools: 6908476: test/tools/javac/T6705935.java fails if non-zip files found on platform class path Message-ID: <20101012214840.59B64470C4@hg.openjdk.java.net> Changeset: ee366cc698c0 Author: jjg Date: 2010-10-12 14:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ee366cc698c0 6908476: test/tools/javac/T6705935.java fails if non-zip files found on platform class path Reviewed-by: darcy ! test/tools/javac/T6705935.java From valerie.peng at oracle.com Wed Oct 13 00:09:01 2010 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Wed, 13 Oct 2010 00:09:01 +0000 Subject: hg: jdk7/tl/jdk: 6887853: javadoc for java.lang.Classloader should be more clear Message-ID: <20101013000911.592CB470CB@hg.openjdk.java.net> Changeset: 1b430727f00d Author: valeriep Date: 2010-10-12 17:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1b430727f00d 6887853: javadoc for java.lang.Classloader should be more clear Summary: Updated the relevant javadoc description of java.lang.ClassLoader class w/ additional clarification. Reviewed-by: mullan ! src/share/classes/java/lang/ClassLoader.java From fweimer at bfk.de Wed Oct 13 15:38:12 2010 From: fweimer at bfk.de (Florian Weimer) Date: Wed, 13 Oct 2010 15:38:12 +0000 Subject: Documentation bug in Class#isAssignableFrom(Class) Message-ID: <82mxqidrx7.fsf@mid.bfk.de> I believe the specification in OpenJDK 6 needs an update. It references section 5.1.4 in the second edition, and this section is gone from the third edition. Superficially, it may appear that 5.1.5 is the correct replacement, but this is not the case because widening reference conversions in that version of the text apply to "any type", including primitive types. (The generic twist to the subtyping relation should not matter here because Class objects always refer to erased types.) Therefore, I suggest that someone from Oracle copies (and thus relicenses) the second edition text into the Class documentation. This should adequately match the behavior of the method. -- Florian Weimer BFK edv-consulting GmbH http://www.bfk.de/ Kriegsstra?e 100 tel: +49-721-96201-1 D-76133 Karlsruhe fax: +49-721-96201-99 From lana.steuck at oracle.com Thu Oct 14 16:08:25 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 14 Oct 2010 16:08:25 +0000 Subject: hg: jdk7/tl: 4 new changesets Message-ID: <20101014160825.AB7364713E@hg.openjdk.java.net> Changeset: c1df968c4527 Author: cl Date: 2010-10-01 15:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/c1df968c4527 Added tag jdk7-b112 for changeset b852103caf73 ! .hgtags Changeset: aaf7fab2e8e4 Author: cl Date: 2010-10-07 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/aaf7fab2e8e4 Added tag jdk7-b113 for changeset c1df968c4527 ! .hgtags Changeset: db9fe730f305 Author: lana Date: 2010-10-04 14:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/db9fe730f305 Merge Changeset: 27985a5c6e52 Author: lana Date: 2010-10-12 12:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/27985a5c6e52 Merge From lana.steuck at oracle.com Thu Oct 14 16:08:30 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 14 Oct 2010 16:08:30 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20101014160833.C59624713F@hg.openjdk.java.net> Changeset: a89a6c5be9d1 Author: cl Date: 2010-10-01 15:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a89a6c5be9d1 Added tag jdk7-b112 for changeset cc67fdc4fee9 ! .hgtags Changeset: 88fddb73c5c4 Author: cl Date: 2010-10-07 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/88fddb73c5c4 Added tag jdk7-b113 for changeset a89a6c5be9d1 ! .hgtags From lana.steuck at oracle.com Thu Oct 14 16:09:23 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 14 Oct 2010 16:09:23 +0000 Subject: hg: jdk7/tl/hotspot: 67 new changesets Message-ID: <20101014161122.C46A947140@hg.openjdk.java.net> Changeset: f8c5d1bdaad4 Author: ptisnovs Date: 2010-08-19 14:23 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f8c5d1bdaad4 6885308: The incorrect -XX:StackRedPages, -XX:StackShadowPages, -XX:StackYellowPages could cause VM crash Summary: Test minimal stack sizes given (also fixed linux compilation error) Reviewed-by: never, phh, coleenp ! src/share/vm/memory/allocation.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: ebfb7c68865e Author: dcubed Date: 2010-08-23 08:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ebfb7c68865e Merge ! src/share/vm/memory/allocation.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 4b29a725c43c Author: jrose Date: 2010-08-20 23:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4b29a725c43c 6912064: type profiles need to be exploited more for dynamic language support Reviewed-by: kvn ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/runtime/globals.hpp Changeset: 53dbe853fb3a Author: kvn Date: 2010-08-23 09:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/53dbe853fb3a 6896381: CTW fails share/vm/ci/bcEscapeAnalyzer.cpp:99, assert(_stack_height < _max_stack,"stack overflow") Summary: Check constant Tag type instead of calling get_constant(). Reviewed-by: never ! src/share/vm/ci/bcEscapeAnalyzer.cpp Changeset: 3e8fbc61cee8 Author: twisti Date: 2010-08-25 05:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3e8fbc61cee8 6978355: renaming for 6961697 Summary: This is the renaming part of 6961697 to keep the actual changes small for review. Reviewed-by: kvn, never ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/c1/Runtime1.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/code/PCDesc.java ! agent/src/share/classes/sun/jvm/hotspot/ui/FindInCodeCachePanel.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PointerFinder.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/PointerLocation.java ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/codeBuffer_sparc.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/jniFastGetField_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/jniFastGetField_x86_32.cpp ! src/cpu/x86/vm/jniFastGetField_x86_64.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/libjvm_db.c ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/windows_x86_32.ad ! src/os_cpu/windows_x86/vm/windows_x86_64.ad ! src/share/vm/adlc/output_c.cpp ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/exceptionHandlerTable.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/pcDesc.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/scopeDesc.cpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/icache.cpp ! src/share/vm/runtime/rframe.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b4099f5786da Author: never Date: 2010-08-25 10:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b4099f5786da Merge ! src/share/vm/runtime/globals.hpp Changeset: c7004d700b49 Author: dholmes Date: 2010-08-25 21:29 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/c7004d700b49 6978641: Fix for 6929067 introduces additional overhead in thread creation/termination paths Summary: Disable stack bounds checks in product mode other than for the initial thread Reviewed-by: coleenp, jcoomes, aph ! src/os/linux/vm/os_linux.cpp Changeset: 2528b5bd749c Author: kamg Date: 2010-08-27 15:05 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2528b5bd749c 6980262: Memory leak when exception is thrown in static initializer Summary: Use resource memory instead of c-heap for the exception message Reviewed-by: phh, jmasa ! src/share/vm/oops/instanceKlass.cpp Changeset: 8397081c7ac1 Author: dcubed Date: 2010-08-27 21:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8397081c7ac1 Merge Changeset: bba76f745fe6 Author: ysr Date: 2010-08-23 17:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/bba76f745fe6 6910183: CMS: assert(_index < capacity(),"_index out of bounds") Summary: Weakened a too-strong, off-by-one assert; added code to keep track of and report any overflows at appropriate level of verbosity. Reviewed-by: jcoomes, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp Changeset: e967bad2a9ab Author: tonyp Date: 2010-08-25 08:44 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/e967bad2a9ab 6941275: G1: The MemoryPools are incorrectly supported for G1 Summary: The way we were caluclating the max value meant that it might fluctuate during the run and this broke some assumptions inside the MBeans framework. This change sets the max value of each pool to -1, which means undefined according to the spec. Reviewed-by: mchung, johnc ! src/share/vm/services/g1MemoryPool.cpp ! src/share/vm/services/g1MemoryPool.hpp Changeset: 8e5955ddf8e4 Author: jcoomes Date: 2010-08-25 14:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8e5955ddf8e4 6978300: G1: debug builds crash if ParallelGCThreads==0 Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: 21c29458b334 Author: kevinw Date: 2010-08-27 16:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/21c29458b334 6980392: TEST_BUG: gc/6581734/Test6581734.java has typo Summary: simple correction in testcase Reviewed-by: mchung ! test/gc/6581734/Test6581734.java Changeset: 1c63587d925b Author: tonyp Date: 2010-08-27 13:34 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1c63587d925b 6980206: G1: assert(has_undefined_max_size, "Undefined max size"); Summary: An assert in the management.cpp is too strong and assumes the max size is always defined on memory pools, even when we don't need to use it. Reviewed-by: mchung, johnc ! src/share/vm/services/management.cpp Changeset: af586a7893cf Author: tonyp Date: 2010-08-27 10:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/af586a7893cf Merge Changeset: 75107ee8712f Author: tonyp Date: 2010-08-30 13:00 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/75107ee8712f Merge Changeset: f208bf19192d Author: tonyp Date: 2010-08-30 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f208bf19192d Merge Changeset: 14b92b91f460 Author: kvn Date: 2010-08-26 11:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/14b92b91f460 6976400: "Meet Not Symmetric" Summary: Use NULL as klass for TypeAryPtr::RANGE. Add klass verification into TypeAryPtr ctor. Reviewed-by: never ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: 0878d7bae69f Author: twisti Date: 2010-08-27 01:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/0878d7bae69f 6961697: move nmethod constants section before instruction section Summary: This is a preparation for 6961690. Reviewed-by: kvn, never ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/relocInfo.hpp Changeset: d6f45b55c972 Author: never Date: 2010-08-27 17:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d6f45b55c972 4809552: Optimize Arrays.fill(...) Reviewed-by: kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 14197af1010e Author: never Date: 2010-08-27 17:35 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/14197af1010e Merge ! src/share/vm/includeDB_compiler2 ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp Changeset: 114e6b93e9e1 Author: kvn Date: 2010-08-30 11:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/114e6b93e9e1 6980978: assert(mt == t->xmeet(this)) failed: meet not commutative Summary: Fix code in TypeAryPtr::xmeet() for constant array. Reviewed-by: never ! src/share/vm/opto/type.cpp Changeset: 02f0a9b6f654 Author: never Date: 2010-08-30 17:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/02f0a9b6f654 6969586: OptimizeStringConcat: SIGSEGV in LoadNode::Value() Reviewed-by: kvn ! src/share/vm/opto/memnode.cpp Changeset: dee553c74493 Author: never Date: 2010-09-01 00:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/dee553c74493 Merge Changeset: 6ee479178066 Author: ikrylov Date: 2010-08-31 03:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6ee479178066 6979444: add command line option to print command line flags descriptions Summary: Implementation of a nonproduct boolean flag XX:PrintFlagsWithComments Reviewed-by: kamg, dholmes, dsamersoff ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/macros.hpp Changeset: 1ab9e2cbfa0e Author: kamg Date: 2010-09-03 14:47 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/1ab9e2cbfa0e 6870851: Bad frame_chop in StackMapTable crashes JVM Summary: Must check locals for null when processing chop frame Reviewed-by: dholmes, dcubed ! src/share/vm/classfile/stackMapTable.cpp Changeset: 40d7b43b6fe0 Author: kamg Date: 2010-09-07 11:38 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/40d7b43b6fe0 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 07551f490c76 Author: kamg Date: 2010-09-07 11:50 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/07551f490c76 6982851: Add b107 machine classifications to jprt.properties file. Summary: See synopsis Reviewed-by: ohair ! make/jprt.properties Changeset: 40b1534a1dab Author: trims Date: 2010-09-08 18:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/40b1534a1dab Merge Changeset: 93193e632121 Author: trims Date: 2010-09-08 18:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/93193e632121 6983320: Fork HS19 to HS20 - renumber Major and build numbers of JVM Summary: Update the Major and Build numbers for HS20 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ea175c1b79ce Author: dcubed Date: 2010-09-08 08:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ea175c1b79ce 6561870: 3/3 Long javac compile lines fail due to command line length issues (agent compiles?) Summary: Use javac's @filename construct to avoid long compile lines Reviewed-by: ohair, twisti, never Contributed-by: doko at ubuntu.com ! make/linux/makefiles/sa.make ! make/solaris/makefiles/sa.make Changeset: 30f67acf635d Author: thurka Date: 2010-09-11 08:18 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/30f67acf635d 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME Summary: Emit a fake frame that makes it look like the thread is in the OutOfMemoryError zero-parameter constructor Reviewed-by: dcubed ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/heapDumper.hpp ! src/share/vm/utilities/debug.cpp Changeset: 8a8a7a014a12 Author: kamg Date: 2010-09-13 07:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/8a8a7a014a12 Merge Changeset: 179464550c7d Author: ysr Date: 2010-09-10 17:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/179464550c7d 6983930: CMS: Various small cleanups ca September 2010 Summary: Fixed comment/documentation typos; converted some guarantee()s to assert()s. Reviewed-by: jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp ! src/share/vm/runtime/globals.hpp Changeset: eeade8e89248 Author: ysr Date: 2010-09-11 11:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/eeade8e89248 Merge ! src/share/vm/runtime/globals.hpp Changeset: 6eddcbe17c83 Author: johnc Date: 2010-09-13 10:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6eddcbe17c83 6981746: G1: SEGV with -XX:+TraceGen0Time Summary: Pass correct value for length to NumberSeq constructor. Guard dereferences of "body_summary" pointer with a NULL check. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: 432d823638f7 Author: jcoomes Date: 2010-09-15 10:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/432d823638f7 6985022: update make/jprt.properties for new jdk7 tools Reviewed-by: ohair, kvn ! make/jprt.properties Changeset: 97fbf5beff7b Author: johnc Date: 2010-09-16 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/97fbf5beff7b Merge Changeset: f353275af40e Author: never Date: 2010-09-02 11:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f353275af40e 6981773: incorrect fill value with OptimizeFill Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/stubGenerator_sparc.cpp Changeset: d5d065957597 Author: iveresov Date: 2010-09-03 17:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d5d065957597 6953144: Tiered compilation Summary: Infrastructure for tiered compilation support (interpreter + c1 + c2) for 32 and 64 bit. Simple tiered policy implementation. Reviewed-by: kvn, never, phh, twisti ! make/linux/Makefile ! make/solaris/Makefile + make/solaris/makefiles/reorder_TIERED_sparcv9 ! make/windows/build.make ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/c1_globals_sparc.hpp ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.hpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/c1_globals_x86.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_CodeStubs.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_Compiler.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_Instruction.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciMethodData.cpp ! src/share/vm/ci/ciMethodData.hpp ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/includeDB_compiler1 ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/invocationCounter.cpp ! src/share/vm/interpreter/invocationCounter.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodDataOop.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/dtraceJSDT.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/safepoint.hpp + src/share/vm/runtime/simpleThresholdPolicy.cpp + src/share/vm/runtime/simpleThresholdPolicy.hpp + src/share/vm/runtime/simpleThresholdPolicy.inline.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/utilities/accessFlags.hpp ! src/share/vm/utilities/globalDefinitions.hpp ! src/share/vm/utilities/macros.hpp Changeset: ac4f710073ed Author: iveresov Date: 2010-09-07 14:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/ac4f710073ed 6982921: assert(_entry_bci != InvocationEntryBci) failed: wrong kind of nmethod Summary: Assertion fails during print compilation because nmethod::print_on() calls osr_entry_bci() without checking that the method is an osr method. The fix adds an appropriate check. Reviewed-by: never, twisti ! src/share/vm/code/nmethod.cpp Changeset: 5e4f03302987 Author: never Date: 2010-09-07 11:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5e4f03302987 6982533: Crash in ~StubRoutines::jbyte_fill with AggressiveOpts enabled Reviewed-by: kvn ! src/share/vm/opto/loopTransform.cpp Changeset: f9883ee8ce39 Author: never Date: 2010-09-08 20:28 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/f9883ee8ce39 6965815: OptimizeStringConcat: assert(!q->is_MergeMem()) failed with specjbb2000 Reviewed-by: kvn ! src/share/vm/opto/graphKit.cpp Changeset: 84713fd87632 Author: twisti Date: 2010-09-08 04:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/84713fd87632 6983073: fix compiler error with GCC 4.4 or newer on SPARC Reviewed-by: twisti Contributed-by: Matthias Klose ! src/cpu/sparc/vm/frame_sparc.hpp Changeset: 33a54060190d Author: twisti Date: 2010-09-09 01:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/33a54060190d Merge Changeset: a83b0246bb77 Author: twisti Date: 2010-09-09 05:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a83b0246bb77 6934483: GCC 4.5 errors "suggest parentheses around something..." when compiling with -Werror and -Wall Summary: These are minor changes fixing compile failure when -Wall -Werror flags are used under gcc 4.5. Reviewed-by: twisti, kvn, rasbold Contributed-by: Pavel Tisnovsky ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 7f9553bedfd5 Author: iveresov Date: 2010-09-11 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/7f9553bedfd5 6984056: C1: incorrect code for integer constant addition on x64 Summary: Fix add/sub of constants to ints on x64 Reviewed-by: kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 3a294e483abc Author: iveresov Date: 2010-09-13 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3a294e483abc 6919069: client compiler needs to capture more profile information for tiered work Summary: Added profiling of instanceof and aastore. Reviewed-by: kvn, jrose, never ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.hpp Changeset: d20603ee9e10 Author: kvn Date: 2010-09-13 16:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d20603ee9e10 6984346: Remove development code in type.hpp Summary: Remove code which use UseNewCode in type.hpp Reviewed-by: never ! src/share/vm/opto/type.hpp Changeset: d257356e35f0 Author: jrose Date: 2010-09-13 23:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/d257356e35f0 6939224: MethodHandle.invokeGeneric needs to perform the correct set of conversions Reviewed-by: never ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 065dd1ca3ab6 Author: never Date: 2010-09-14 14:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/065dd1ca3ab6 6982370: SIGBUS in jbyte_fill Reviewed-by: kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp + test/compiler/6982370/Test6982370.java Changeset: a8b66e00933b Author: kvn Date: 2010-09-14 17:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a8b66e00933b 6984368: Large default heap size does not allow to use zero based compressed oops Summary: take into account HeapBaseMinAddress and round down MaxPermSize Reviewed-by: never ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 18c378513575 Author: kvn Date: 2010-09-16 16:48 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/18c378513575 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/macros.hpp Changeset: 883a82d6d41d Author: acorn Date: 2010-09-10 12:36 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/883a82d6d41d 6942092: Loader-constraint test is failing Summary: Fix test string compare to match source update Reviewed-by: dcubed, phh ! test/runtime/6626217/Test6626217.sh Changeset: 6cde0ed1b568 Author: acorn Date: 2010-09-14 10:15 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/6cde0ed1b568 Merge Changeset: 4094f07967ca Author: kamg Date: 2010-09-15 16:28 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/4094f07967ca 6974813: JVM needs to use demand loading for its DTrace probes Summary: Pass -xlazyload to the 'dtrace -G' invocation Reviewed-by: phh, ysr ! make/solaris/makefiles/dtrace.make Changeset: 728a287f6c20 Author: zgu Date: 2010-09-17 09:45 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/728a287f6c20 6981753: Rebrand vm vendor property settings Summary: Uses JDK_Version to determinate to set vm vendor to "Oracle Corporation" for JDK7 and later. Reviewed-by: kamg, ohair, coleenp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/vm_version.cpp Changeset: 51640ecd89f8 Author: zgu Date: 2010-09-17 09:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/51640ecd89f8 Merge Changeset: 3babdb042f25 Author: kamg Date: 2010-09-17 19:45 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/3babdb042f25 Merge Changeset: 60f88489896f Author: kamg Date: 2010-09-20 15:38 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/60f88489896f 6975210: java.lang.VerifyError in some of JCK tests Summary: Naked oop in verificationType::is_reference_assignable_from() Reviewed-by: never, kvn, coleenp ! src/share/vm/classfile/verificationType.cpp Changeset: 2966dab85b3e Author: dcubed Date: 2010-09-21 06:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/2966dab85b3e 6985848: 3/4 fix for 6561870 causes sa-jdi.jar to be rebuilt every time Summary: Refine fix for 6561870 to only rebuild sa-jdi.jar when needed Reviewed-by: never, ohair, coleenp ! make/linux/makefiles/sa.make ! make/solaris/makefiles/sa.make Changeset: a25394352030 Author: kamg Date: 2010-09-22 12:54 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/a25394352030 Merge ! src/share/vm/runtime/arguments.cpp Changeset: 9bdbd693dbaa Author: trims Date: 2010-09-24 00:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/9bdbd693dbaa Merge Changeset: b2045e0af26e Author: trims Date: 2010-09-24 00:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/b2045e0af26e 6987149: Fix incorrect Oracle copyright header in make/templates files Summary: Minor fix to first line of template copyright files Reviewed-by: ohair ! make/templates/bsd-header ! make/templates/gpl-cp-header ! make/templates/gpl-header Changeset: 5511edd5d719 Author: iveresov Date: 2010-09-30 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/5511edd5d719 6988779: c1_LIRAssembler_x86.cpp crashes VS2010 compiler Summary: The workaround changes the scope of the variable Reviewed-by: phh, ysr, kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: beef35b96b81 Author: cl Date: 2010-10-01 15:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/beef35b96b81 Added tag jdk7-b112 for changeset 5511edd5d719 ! .hgtags Changeset: 68d6141ea19d Author: cl Date: 2010-10-07 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/hotspot/rev/68d6141ea19d Added tag jdk7-b113 for changeset beef35b96b81 ! .hgtags From kumar.x.srinivasan at oracle.com Thu Oct 14 16:40:26 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 14 Oct 2010 16:40:26 +0000 Subject: hg: jdk7/tl/jdk: 6991164: pack source needs vendor rebranding changes (jdk7 only) Message-ID: <20101014164045.8253747142@hg.openjdk.java.net> Changeset: 5cd4f89b8339 Author: ksrini Date: 2010-10-14 09:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5cd4f89b8339 6991164: pack source needs vendor rebranding changes (jdk7 only) Reviewed-by: ohair, jrose ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! test/tools/pack200/PackageVersionTest.java From lana.steuck at oracle.com Thu Oct 14 18:10:54 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 14 Oct 2010 18:10:54 +0000 Subject: hg: jdk7/tl/jaxp: 2 new changesets Message-ID: <20101014181054.4F66B47147@hg.openjdk.java.net> Changeset: bc0c84ce54c3 Author: cl Date: 2010-10-01 15:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/bc0c84ce54c3 Added tag jdk7-b112 for changeset 1b0525424288 ! .hgtags Changeset: d57197d22c2b Author: cl Date: 2010-10-07 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/d57197d22c2b Added tag jdk7-b113 for changeset bc0c84ce54c3 ! .hgtags From lana.steuck at oracle.com Thu Oct 14 18:10:59 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 14 Oct 2010 18:10:59 +0000 Subject: hg: jdk7/tl/jaxws: 2 new changesets Message-ID: <20101014181059.55F3647148@hg.openjdk.java.net> Changeset: d35c94fd2236 Author: cl Date: 2010-10-01 15:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d35c94fd2236 Added tag jdk7-b112 for changeset 8e0f0054817f ! .hgtags Changeset: 400f494c81c5 Author: cl Date: 2010-10-07 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/400f494c81c5 Added tag jdk7-b113 for changeset d35c94fd2236 ! .hgtags From lana.steuck at oracle.com Thu Oct 14 18:12:31 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 14 Oct 2010 18:12:31 +0000 Subject: hg: jdk7/tl/jdk: 40 new changesets Message-ID: <20101014181907.700C347149@hg.openjdk.java.net> Changeset: 61d3b9fbb26b Author: cl Date: 2010-10-01 15:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/61d3b9fbb26b Added tag jdk7-b112 for changeset b53f226b1d91 ! .hgtags Changeset: 621be994f8d9 Author: cl Date: 2010-10-07 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/621be994f8d9 Added tag jdk7-b113 for changeset 61d3b9fbb26b ! .hgtags Changeset: ad17cf689258 Author: bae Date: 2010-09-29 10:44 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ad17cf689258 6735275: java.awt.image.SampleModel.getSamples() methods not allways throw ArrayIndexOutOfBoundsException Reviewed-by: igor, prr ! src/share/classes/java/awt/image/SampleModel.java + test/java/awt/image/GetSamplesTest.java Changeset: 160f7ffc3d14 Author: bae Date: 2010-10-02 12:41 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/160f7ffc3d14 6988213: lcms build failure on windows-amd64 Reviewed-by: igor, prr ! make/sun/cmm/lcms/Makefile Changeset: d0cfe52db29e Author: lana Date: 2010-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d0cfe52db29e Merge Changeset: d32203d5a47c Author: ant Date: 2010-09-27 16:11 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d32203d5a47c 6505819: Provide traverseIn method for sun.awt.EmbeddedFrame Reviewed-by: dcherepanov, art ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/share/classes/sun/awt/EmbeddedFrame.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFrame.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java Changeset: d21c9804c512 Author: ant Date: 2010-09-27 17:38 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d21c9804c512 6886678: Clicking on parent JFrame's client area does not switch focus from JWindow to JFrame on Windows Reviewed-by: dcherepanov, art ! src/windows/native/sun/windows/awt_Component.cpp + test/java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java Changeset: 40fa33254fc6 Author: art Date: 2010-09-28 14:57 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/40fa33254fc6 6987896: Modal dialogs resumes the calling thread before it's hidden Reviewed-by: anthony ! src/share/classes/java/awt/Dialog.java Changeset: 6994facc6a8b Author: omajid Date: 2010-09-28 10:16 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6994facc6a8b 6987945: XDecoratedPeer shouldn't allow to resize a frame to zero size Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java Changeset: a601a6711ef8 Author: lana Date: 2010-09-28 00:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a601a6711ef8 Merge - src/share/classes/com/sun/media/sound/MidiDeviceReceiver.java - src/share/native/sun/java2d/cmm/lcms/cmscam97.c - src/share/native/sun/java2d/cmm/lcms/cmsmatsh.c - src/share/native/sun/java2d/cmm/lcms/icc34.h - src/share/native/sun/java2d/cmm/lcms/lcms.h - src/solaris/classes/sun/net/spi/SdpProvider.java - src/solaris/native/sun/net/spi/SdpProvider.c - test/java/util/Locale/data/deflocale.exe - test/java/util/Locale/data/deflocale.jds3 - test/java/util/Locale/data/deflocale.rhel4 - test/java/util/Locale/data/deflocale.winvista - test/java/util/Locale/data/deflocale.winxp - test/tools/launcher/VerifyExceptions.java Changeset: 8936ad6b154e Author: lana Date: 2010-09-28 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8936ad6b154e Merge Changeset: 3caf15616f46 Author: dav Date: 2010-09-30 14:50 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3caf15616f46 6694729: obsolete link in ActionEvent javadoc Reviewed-by: art ! src/share/classes/java/awt/event/ActionEvent.java Changeset: 8afd49c55619 Author: art Date: 2010-09-30 21:06 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8afd49c55619 6860270: JVM crash is occuring when verifying whether Browse action is supported on WinVista 64 bit Reviewed-by: anthony, uta ! src/windows/native/sun/windows/awt_Desktop.cpp Changeset: b0d1ef182650 Author: dav Date: 2010-10-01 15:10 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b0d1ef182650 6829267: Regression test java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Enable.java fails in RHEL5 Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/windows/native/sun/windows/awt_DesktopProperties.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h ! test/java/awt/Toolkit/ToolkitPropertyTest/ToolkitPropertyTest_Enable.java Changeset: 70a73fc061d9 Author: dav Date: 2010-10-04 11:40 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/70a73fc061d9 6847155: test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java fails Reviewed-by: denis ! test/java/awt/Mouse/MouseModifiersUnitTest/MouseModifiersUnitTest_Extra.java Changeset: a014255d826c Author: anthony Date: 2010-10-04 16:12 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a014255d826c 6987233: FileDialog.getDirectory() should add a trainling slash when GTK FileDialog is used Summary: Add the trailing slash if it's absent Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java Changeset: d147113a36fd Author: anthony Date: 2010-10-04 16:21 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d147113a36fd 6982279: java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java failed due to NPE Summary: Rely on the WWindowPeer.getTranslucentGraphics()'s return value Reviewed-by: art, dcherepanov ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: 63b6059eebd0 Author: lana Date: 2010-10-04 14:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63b6059eebd0 Merge Changeset: e2050786c3ce Author: alexp Date: 2010-09-17 22:50 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2050786c3ce 6982661: Complete JLayer component Reviewed-by: malenkov ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/plaf/LayerUI.java Changeset: a463040967f2 Author: alexp Date: 2010-09-17 23:00 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a463040967f2 6606019: NPE and IAE are interchanged in specification for GroupLayout.Group class Reviewed-by: rupashka ! src/share/classes/javax/swing/GroupLayout.java Changeset: cdd64925de04 Author: alexp Date: 2010-09-17 23:09 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cdd64925de04 6632953: MetalComboBoxUI.getBaseline(JComponent, int, int) throws IAE for valid width/height Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/metal/MetalComboBoxUI.java + test/javax/swing/JComboBox/6632953/bug6632953.java Changeset: a8ec7a461254 Author: alexp Date: 2010-09-17 23:16 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8ec7a461254 6576054: NullPointerException when closing tooltip by pressing esc Reviewed-by: rupashka ! src/share/classes/javax/swing/ToolTipManager.java Changeset: e753db9c4416 Author: alexp Date: 2010-09-17 23:21 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e753db9c4416 4330950: Lost newly entered data in the cell when resizing column width Reviewed-by: peterz ! src/share/classes/javax/swing/JTable.java Changeset: 76b39a4964fa Author: alexp Date: 2010-09-17 23:34 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76b39a4964fa 6542335: different behavior on knob of scroll bar between 1.4.2 and 5.0 Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java + test/javax/swing/JScrollBar/6542335/bug6542335.java Changeset: 002495e6aecb Author: peterz Date: 2010-09-21 10:03 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/002495e6aecb 6960126: With GTK L&F JDesktopPane substitutes set desktop manager Reviewed-by: malenkov ! src/share/classes/javax/swing/JDesktopPane.java Changeset: c650dd9e6be2 Author: peterz Date: 2010-09-21 10:04 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c650dd9e6be2 6978052: No appropriate CCC request for listed JDK 7 changes in javax.swing.plaf.synth package (b84) Reviewed-by: malenkov ! src/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java Changeset: 39351e11b8f9 Author: naoto Date: 2010-09-23 20:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/39351e11b8f9 6986612: pit jdk7 b112: java.util.Locale getDisplayVariant() sqe test getDisplayVariantTests.java fails Reviewed-by: dougfelt Contributed-by: Yoshito Umaoka ! src/share/classes/java/util/Locale.java ! src/share/classes/sun/util/locale/BaseLocale.java Changeset: b57ca6031a35 Author: lana Date: 2010-09-26 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b57ca6031a35 Merge - src/share/native/sun/java2d/cmm/lcms/cmscam97.c - src/share/native/sun/java2d/cmm/lcms/cmsmatsh.c - src/share/native/sun/java2d/cmm/lcms/icc34.h - src/share/native/sun/java2d/cmm/lcms/lcms.h - src/solaris/classes/sun/net/spi/SdpProvider.java - src/solaris/native/sun/net/spi/SdpProvider.c - test/tools/launcher/VerifyExceptions.java Changeset: 278c8daa3075 Author: malenkov Date: 2010-09-27 13:38 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/278c8daa3075 6976577: JCK7 api/java_beans/EventSetDescriptor/descriptions.html#Ctor1 fails since jdk7 b102 Reviewed-by: peterz ! src/share/classes/java/beans/EventSetDescriptor.java ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/MethodDescriptor.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/6976577/Test6976577.java + test/java/beans/Introspector/6976577/test/Accessor.java Changeset: bbadb9484f53 Author: omajid Date: 2010-09-27 11:30 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbadb9484f53 6986968: Crash on XIM server restart Summary: Free XIM data structures on DestroyXIMCallback Reviewed-by: naoto ! src/solaris/native/sun/awt/awt_InputMethod.c Changeset: 0ca4ae74cf44 Author: malenkov Date: 2010-09-27 21:07 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0ca4ae74cf44 6986450: javax/swing/JTable/Test6888156.java test is failing against jdk7 just on windows Reviewed-by: alexp ! test/javax/swing/JTable/Test6888156.java Changeset: 75a0f7b47024 Author: naoto Date: 2010-09-28 10:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75a0f7b47024 6915621: (rb) ResourceBundle.getBundle() deadlock when called inside a synchronized thread Reviewed-by: okutsu ! src/share/classes/java/util/ResourceBundle.java Changeset: 990bbd005f28 Author: malenkov Date: 2010-09-30 20:21 +0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/990bbd005f28 6982753: javax/swing/JTextArea/6940863/bug6940863.java should be modified Reviewed-by: alexp ! test/javax/swing/JTextArea/6940863/bug6940863.java Changeset: 76edcef04379 Author: okutsu Date: 2010-10-04 13:05 +0900 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/76edcef04379 6955776: (tz) Windows-only: tzmappings needs update for KB981793 6929185: (tz) Windows-only: tzmappings needs update for KB979306 Reviewed-by: peytoia ! src/windows/lib/tzmappings Changeset: b210ae2a8e74 Author: lana Date: 2010-10-04 14:38 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b210ae2a8e74 Merge Changeset: d5fc514976fa Author: lana Date: 2010-10-04 14:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d5fc514976fa Merge - make/common/Rules-SCCS.gmk - test/sun/net/www/http/ChunkedInputStream/ChunkedCharEncoding.sh Changeset: 4a513df0df12 Author: sherman Date: 2010-10-08 21:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4a513df0df12 6990846: Demo: NIO.2 filesystem provider for zip/jar archives Summary: The first drop of the zip filesystem provider, as a separate demo Reviewed-by: alanb ! make/mkdemo/Makefile + make/mkdemo/nio/Makefile + make/mkdemo/nio/zipfs/Makefile + src/share/demo/nio/zipfs/Demo.java + src/share/demo/nio/zipfs/META-INF/services/java.nio.file.spi.FileSystemProvider + src/share/demo/nio/zipfs/README.txt + src/share/demo/nio/zipfs/com/sun/nio/zipfs/JarFileSystemProvider.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipCoder.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipConstants.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipDirectoryStream.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributeView.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributes.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileStore.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystem.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystemProvider.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipInfo.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipPath.java + src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipUtils.java + test/demo/zipfs/Basic.java + test/demo/zipfs/PathOps.java + test/demo/zipfs/ZipFSTester.java + test/demo/zipfs/basic.sh Changeset: e250cef36ea0 Author: lana Date: 2010-10-12 12:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e250cef36ea0 Merge - make/common/Rules-SCCS.gmk - test/sun/net/www/http/ChunkedInputStream/ChunkedCharEncoding.sh Changeset: 2278f3ff5f95 Author: lana Date: 2010-10-13 17:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2278f3ff5f95 Merge Changeset: 078723d34a6c Author: lana Date: 2010-10-14 11:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/078723d34a6c Merge From lana.steuck at oracle.com Thu Oct 14 18:20:44 2010 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 14 Oct 2010 18:20:44 +0000 Subject: hg: jdk7/tl/langtools: 5 new changesets Message-ID: <20101014182056.594024714A@hg.openjdk.java.net> Changeset: 6dbd2d869b05 Author: cl Date: 2010-10-01 15:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6dbd2d869b05 Added tag jdk7-b112 for changeset fd2579b80b83 ! .hgtags Changeset: cd3235a96b6c Author: cl Date: 2010-10-07 15:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/cd3235a96b6c Added tag jdk7-b113 for changeset 6dbd2d869b05 ! .hgtags Changeset: 2c321dcb1edc Author: lana Date: 2010-10-04 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2c321dcb1edc Merge - test/tools/javac/processing/Xprint.java Changeset: e4e7408cdc5b Author: lana Date: 2010-10-12 12:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e4e7408cdc5b Merge - test/tools/javac/processing/Xprint.java Changeset: 9bfb0e6fd526 Author: lana Date: 2010-10-13 17:52 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/9bfb0e6fd526 Merge From valerie.peng at oracle.com Fri Oct 15 01:04:44 2010 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Fri, 15 Oct 2010 01:04:44 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101015010505.BA0664715F@hg.openjdk.java.net> Changeset: 96d78263fdf7 Author: valeriep Date: 2010-10-14 17:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/96d78263fdf7 6988081: Use GetPrimitiveArrayCritical instead GetByteArray to Reduce allocation in some sunpkcs jni wrappers Summary: Changed to use GetPrimitiveArrayCritical for encryption and decryption. Reviewed-by: vinnie ! src/share/native/sun/security/pkcs11/wrapper/p11_crypt.c Changeset: 6b4e02e3be8e Author: valeriep Date: 2010-10-14 18:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6b4e02e3be8e 6850402: Deadlock on sun.security.jca.ProviderConfig starting from jdk7-b55 Summary: Reduced the scope of locking Reviewed-by: vinnie ! src/share/classes/sun/security/jca/Providers.java From alan.bateman at oracle.com Fri Oct 15 11:15:22 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 15 Oct 2010 11:15:22 +0000 Subject: hg: jdk7/tl/jdk: 6976036: Dual-pivot quicksort update (10/2010 tune-up) Message-ID: <20101015111539.14D7E47187@hg.openjdk.java.net> Changeset: 4cf17a89ead9 Author: alanb Date: 2010-10-15 12:10 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4cf17a89ead9 6976036: Dual-pivot quicksort update (10/2010 tune-up) Reviewed-by: alanb Contributed-by: vladimir.yaroslavskiy at oracle.com ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java From alan.bateman at oracle.com Fri Oct 15 14:21:51 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 15 Oct 2010 14:21:51 +0000 Subject: hg: jdk7/tl/jdk: 6743526: (bf) -XX:MaxDirectMemorySize= limits memory usage rather than total capacity as intended Message-ID: <20101015142201.1BF9247190@hg.openjdk.java.net> Changeset: f24699d8c892 Author: alanb Date: 2010-10-15 15:09 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f24699d8c892 6743526: (bf) -XX:MaxDirectMemorySize= limits memory usage rather than total capacity as intended Reviewed-by: chegar ! src/share/classes/java/nio/Bits.java + test/java/nio/Buffer/LimitDirectMemory.java + test/java/nio/Buffer/LimitDirectMemory.sh From sean.mullan at oracle.com Fri Oct 15 14:59:26 2010 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Fri, 15 Oct 2010 14:59:26 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101015145944.C9B2D47192@hg.openjdk.java.net> Changeset: 0fc51ca3467d Author: mullan Date: 2010-10-15 10:55 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0fc51ca3467d 6954275: XML signatures with reference data larger 16KB and cacheRef on fails to validate Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/UnsyncByteArrayOutputStream.java + test/com/sun/org/apache/xml/internal/security/utils/UnsyncByteArrayOutputStream/BufferOverflowTest.java Changeset: bca7bd9ebf10 Author: mullan Date: 2010-10-15 10:59 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bca7bd9ebf10 Merge From kumar.x.srinivasan at oracle.com Fri Oct 15 20:52:44 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 15 Oct 2010 20:52:44 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101015205303.47DED4719F@hg.openjdk.java.net> Changeset: 7eae3422704f Author: ksrini Date: 2010-10-14 14:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7eae3422704f 6982312: (pack200) pack200 fails with the jdk7 class files Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java + test/tools/pack200/AttributeTests.java + test/tools/pack200/dyn.jar Changeset: 56b9bc2a0752 Author: ksrini Date: 2010-10-14 14:55 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/56b9bc2a0752 6746111: Improve pack200 error message Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! test/tools/pack200/AttributeTests.java + test/tools/pack200/badattr.jar From alan.bateman at oracle.com Mon Oct 18 09:32:33 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 18 Oct 2010 09:32:33 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101018093307.9751547228@hg.openjdk.java.net> Changeset: b79600ecf0e4 Author: alanb Date: 2010-10-18 10:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b79600ecf0e4 4837564: (bf) Please make DirectByteBuffer performance enhancements Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/share/classes/sun/misc/VM.java ! test/java/nio/Buffer/LimitDirectMemory.sh Changeset: c64772f0492f Author: alanb Date: 2010-10-18 10:31 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c64772f0492f Merge From sean.mullan at oracle.com Mon Oct 18 13:06:25 2010 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 18 Oct 2010 13:06:25 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101018130644.E085847231@hg.openjdk.java.net> Changeset: 0f5bab573e01 Author: mullan Date: 2010-10-18 09:00 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f5bab573e01 6988599: CertificateRevokedException specifies name of authority but interacts with authority instance Reviewed-by: vinnie ! src/share/classes/java/security/cert/CertificateRevokedException.java Changeset: 537cf89b2f74 Author: mullan Date: 2010-10-18 09:05 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/537cf89b2f74 Merge From chris.hegarty at oracle.com Mon Oct 18 15:52:15 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 18 Oct 2010 15:52:15 +0000 Subject: hg: jdk7/tl/jdk: 6992545: FindBugs scan - Malicious code vulnerability Warnings in com.sun.net.httpserver.HttpsParameters.* Message-ID: <20101018155224.AA31147238@hg.openjdk.java.net> Changeset: 5193b0c2baf0 Author: chegar Date: 2010-10-18 16:51 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5193b0c2baf0 6992545: FindBugs scan - Malicious code vulnerability Warnings in com.sun.net.httpserver.HttpsParameters.* Reviewed-by: alanb ! src/share/classes/com/sun/net/httpserver/BasicAuthenticator.java ! src/share/classes/com/sun/net/httpserver/Filter.java ! src/share/classes/com/sun/net/httpserver/Headers.java ! src/share/classes/com/sun/net/httpserver/HttpsParameters.java From sean.coffey at oracle.com Mon Oct 18 17:01:42 2010 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Mon, 18 Oct 2010 17:01:42 +0000 Subject: hg: jdk7/tl/jdk: 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace Message-ID: <20101018170151.DD13F4723D@hg.openjdk.java.net> Changeset: 426e5f2dbea3 Author: coffeys Date: 2010-10-18 18:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/426e5f2dbea3 6974104: TEST: sun/nio/ch/6645197.java should be fixed in 1.5.0u25b05 and jdk6 workspace Reviewed-by: alanb + test/java/nio/channels/Selector/TemporarySelector.java From maurizio.cimadamore at oracle.com Mon Oct 18 18:17:10 2010 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Mon, 18 Oct 2010 18:17:10 +0000 Subject: hg: jdk7/tl/langtools: 6991980: polymorphic signature calls don't share the same CP entries Message-ID: <20101018181712.58FD047240@hg.openjdk.java.net> Changeset: 493ecc8111ba Author: mcimadamore Date: 2010-10-18 19:14 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/493ecc8111ba 6991980: polymorphic signature calls don't share the same CP entries Summary: wrong use of attr env in Infer.java prevents sharing of CP entries for PS calls Reviewed-by: darcy, jrose ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/meth/TestCP.java From mandy.chung at oracle.com Mon Oct 18 22:41:43 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 18 Oct 2010 15:41:43 -0700 Subject: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError Message-ID: <4CBCCD27.5070806@oracle.com> Please review the fix for: 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError with minCap=Integer.MIN_VALUE Webrev at: http://cr.openjdk.java.net/~mchung/6992121/webrev.00/ This is a regression caused by the changes for 6933217 (Huge arrays handled poorly in core libraries). The ensureCapacity() method in the StringBuffer, StringBuilder, ArrayList, and Vector classes are a public API that accepts negative numbers. The following overflow-conscious code: if (minimumCapacity - value.length> 0) considers negative minimumCapacity as overflow case where OutOfMemoryError will be thrown. So the implementation of the public ensureCapacity() methods need to check if the input argument is positive before doing the above overflow-conscious check. Thanks Mandy From David.Holmes at oracle.com Mon Oct 18 23:54:10 2010 From: David.Holmes at oracle.com (David Holmes) Date: Tue, 19 Oct 2010 09:54:10 +1000 Subject: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError In-Reply-To: <4CBCCD27.5070806@oracle.com> References: <4CBCCD27.5070806@oracle.com> Message-ID: <4CBCDE22.4020505@oracle.com> Hi Mandy, The functional changes seem ok. However the ArrayList test is not right because it checks the size not the capacity. The same with the Vector test, though at least with Vector you can check capacity(). I find it odd that ArrayList has a very well defined notion of capacity yet no method to query that capacity. David Mandy Chung said the following on 10/19/10 08:41: > Please review the fix for: > > 6992121: StringBuilder.ensureCapacity(int minCap) throws > OutOfMemoryError with minCap=Integer.MIN_VALUE > > Webrev at: > http://cr.openjdk.java.net/~mchung/6992121/webrev.00/ > > This is a regression caused by the changes for 6933217 (Huge arrays > handled poorly in core libraries). The ensureCapacity() method in the > StringBuffer, StringBuilder, ArrayList, and Vector classes are a public > API that accepts negative numbers. The following overflow-conscious code: > > if (minimumCapacity - value.length> 0) > > considers negative minimumCapacity as overflow case where > OutOfMemoryError will be thrown. So the implementation of the public > ensureCapacity() methods need to check if the input argument is positive > before doing the above overflow-conscious check. > > Thanks > Mandy From mandy.chung at oracle.com Tue Oct 19 04:07:52 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 18 Oct 2010 21:07:52 -0700 Subject: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError In-Reply-To: <4CBCDE22.4020505@oracle.com> References: <4CBCCD27.5070806@oracle.com> <4CBCDE22.4020505@oracle.com> Message-ID: <4CBD1998.2030409@oracle.com> On 10/18/10 4:54 PM, David Holmes wrote: > Hi Mandy, > > The functional changes seem ok. However the ArrayList test is not > right because it checks the size not the capacity. The same with the > Vector test, though at least with Vector you can check capacity(). > I missed the Vector.capacity() method. Thanks. I updated the test. http://cr.openjdk.java.net/~mchung/6992121/webrev.01/ > I find it odd that ArrayList has a very well defined notion of > capacity yet no method to query that capacity. > True. I don't have the history but wonder if this is intentional. Mandy > David > > Mandy Chung said the following on 10/19/10 08:41: >> Please review the fix for: >> >> 6992121: StringBuilder.ensureCapacity(int minCap) throws >> OutOfMemoryError with minCap=Integer.MIN_VALUE >> >> Webrev at: >> http://cr.openjdk.java.net/~mchung/6992121/webrev.00/ >> >> This is a regression caused by the changes for 6933217 (Huge arrays >> handled poorly in core libraries). The ensureCapacity() method in >> the StringBuffer, StringBuilder, ArrayList, and Vector classes are a >> public API that accepts negative numbers. The following >> overflow-conscious code: >> >> if (minimumCapacity - value.length> 0) >> >> considers negative minimumCapacity as overflow case where >> OutOfMemoryError will be thrown. So the implementation of the public >> ensureCapacity() methods need to check if the input argument is >> positive before doing the above overflow-conscious check. >> >> Thanks >> Mandy From David.Holmes at oracle.com Tue Oct 19 04:24:45 2010 From: David.Holmes at oracle.com (David Holmes) Date: Tue, 19 Oct 2010 14:24:45 +1000 Subject: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError In-Reply-To: <4CBD1998.2030409@oracle.com> References: <4CBCCD27.5070806@oracle.com> <4CBCDE22.4020505@oracle.com> <4CBD1998.2030409@oracle.com> Message-ID: <4CBD1D8D.3070307@oracle.com> Hi Mandy, Given you can't actually test ArrayList I would drop it altogether and move the test to java/util/vector/TestEnsureCapacity David Mandy Chung said the following on 10/19/10 14:07: > On 10/18/10 4:54 PM, David Holmes wrote: >> Hi Mandy, >> >> The functional changes seem ok. However the ArrayList test is not >> right because it checks the size not the capacity. The same with the >> Vector test, though at least with Vector you can check capacity(). >> > > I missed the Vector.capacity() method. Thanks. I updated the test. > http://cr.openjdk.java.net/~mchung/6992121/webrev.01/ >> I find it odd that ArrayList has a very well defined notion of >> capacity yet no method to query that capacity. >> > > True. I don't have the history but wonder if this is intentional. > > Mandy > >> David >> >> Mandy Chung said the following on 10/19/10 08:41: >>> Please review the fix for: >>> >>> 6992121: StringBuilder.ensureCapacity(int minCap) throws >>> OutOfMemoryError with minCap=Integer.MIN_VALUE >>> >>> Webrev at: >>> http://cr.openjdk.java.net/~mchung/6992121/webrev.00/ >>> >>> This is a regression caused by the changes for 6933217 (Huge arrays >>> handled poorly in core libraries). The ensureCapacity() method in >>> the StringBuffer, StringBuilder, ArrayList, and Vector classes are a >>> public API that accepts negative numbers. The following >>> overflow-conscious code: >>> >>> if (minimumCapacity - value.length> 0) >>> >>> considers negative minimumCapacity as overflow case where >>> OutOfMemoryError will be thrown. So the implementation of the public >>> ensureCapacity() methods need to check if the input argument is >>> positive before doing the above overflow-conscious check. >>> >>> Thanks >>> Mandy > From mandy.chung at oracle.com Tue Oct 19 05:05:54 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 18 Oct 2010 22:05:54 -0700 Subject: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError In-Reply-To: <4CBD1D8D.3070307@oracle.com> References: <4CBCCD27.5070806@oracle.com> <4CBCDE22.4020505@oracle.com> <4CBD1998.2030409@oracle.com> <4CBD1D8D.3070307@oracle.com> Message-ID: <4CBD2732.8060601@oracle.com> On 10/18/10 9:24 PM, David Holmes wrote: > Hi Mandy, > > Given you can't actually test ArrayList I would drop it altogether and > move the test to java/util/vector/TestEnsureCapacity But it tests ArrayList.ensureCapacity(Integer.MIN_VALUE) which should not throw any exception (the regression throws OutOfMemoryError). I can move it to java/util/vector/TestEnsureCapacity. Thanks Mandy > > David > > Mandy Chung said the following on 10/19/10 14:07: >> On 10/18/10 4:54 PM, David Holmes wrote: >>> Hi Mandy, >>> >>> The functional changes seem ok. However the ArrayList test is not >>> right because it checks the size not the capacity. The same with the >>> Vector test, though at least with Vector you can check capacity(). >>> >> >> I missed the Vector.capacity() method. Thanks. I updated the test. >> http://cr.openjdk.java.net/~mchung/6992121/webrev.01/ >>> I find it odd that ArrayList has a very well defined notion of >>> capacity yet no method to query that capacity. >>> >> >> True. I don't have the history but wonder if this is intentional. >> >> Mandy >> >>> David >>> >>> Mandy Chung said the following on 10/19/10 08:41: >>>> Please review the fix for: >>>> >>>> 6992121: StringBuilder.ensureCapacity(int minCap) throws >>>> OutOfMemoryError with minCap=Integer.MIN_VALUE >>>> >>>> Webrev at: >>>> http://cr.openjdk.java.net/~mchung/6992121/webrev.00/ >>>> >>>> This is a regression caused by the changes for 6933217 (Huge arrays >>>> handled poorly in core libraries). The ensureCapacity() method in >>>> the StringBuffer, StringBuilder, ArrayList, and Vector classes are >>>> a public API that accepts negative numbers. The following >>>> overflow-conscious code: >>>> >>>> if (minimumCapacity - value.length> 0) >>>> >>>> considers negative minimumCapacity as overflow case where >>>> OutOfMemoryError will be thrown. So the implementation of the >>>> public ensureCapacity() methods need to check if the input argument >>>> is positive before doing the above overflow-conscious check. >>>> >>>> Thanks >>>> Mandy >> From sundararajan.a at sun.com Tue Oct 19 06:18:37 2010 From: sundararajan.a at sun.com (sundararajan.a at sun.com) Date: Tue, 19 Oct 2010 06:18:37 +0000 Subject: hg: jdk7/tl/langtools: 6551367: javadoc throws ClassCastException when an @link tries to reference constructor. Message-ID: <20101019061839.4E45D47271@hg.openjdk.java.net> Changeset: 5286a99de2e6 Author: sundar Date: 2010-10-19 11:47 +0530 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/5286a99de2e6 6551367: javadoc throws ClassCastException when an @link tries to reference constructor. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java + test/tools/javadoc/T6551367.java From David.Holmes at oracle.com Tue Oct 19 06:28:59 2010 From: David.Holmes at oracle.com (David Holmes) Date: Tue, 19 Oct 2010 16:28:59 +1000 Subject: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError In-Reply-To: <4CBD2732.8060601@oracle.com> References: <4CBCCD27.5070806@oracle.com> <4CBCDE22.4020505@oracle.com> <4CBD1998.2030409@oracle.com> <4CBD1D8D.3070307@oracle.com> <4CBD2732.8060601@oracle.com> Message-ID: <4CBD3AAB.2020208@oracle.com> Mandy Chung said the following on 10/19/10 15:05: > On 10/18/10 9:24 PM, David Holmes wrote: >> Hi Mandy, >> >> Given you can't actually test ArrayList I would drop it altogether and >> move the test to java/util/vector/TestEnsureCapacity > > But it tests ArrayList.ensureCapacity(Integer.MIN_VALUE) which should > not throw any exception (the regression throws OutOfMemoryError). Oh ok. I hadn't picked up on that part. Just leave it then. David I can > move it to java/util/vector/TestEnsureCapacity. > > Thanks > Mandy > >> >> David >> >> Mandy Chung said the following on 10/19/10 14:07: >>> On 10/18/10 4:54 PM, David Holmes wrote: >>>> Hi Mandy, >>>> >>>> The functional changes seem ok. However the ArrayList test is not >>>> right because it checks the size not the capacity. The same with the >>>> Vector test, though at least with Vector you can check capacity(). >>>> >>> >>> I missed the Vector.capacity() method. Thanks. I updated the test. >>> http://cr.openjdk.java.net/~mchung/6992121/webrev.01/ >>>> I find it odd that ArrayList has a very well defined notion of >>>> capacity yet no method to query that capacity. >>>> >>> >>> True. I don't have the history but wonder if this is intentional. >>> >>> Mandy >>> >>>> David >>>> >>>> Mandy Chung said the following on 10/19/10 08:41: >>>>> Please review the fix for: >>>>> >>>>> 6992121: StringBuilder.ensureCapacity(int minCap) throws >>>>> OutOfMemoryError with minCap=Integer.MIN_VALUE >>>>> >>>>> Webrev at: >>>>> http://cr.openjdk.java.net/~mchung/6992121/webrev.00/ >>>>> >>>>> This is a regression caused by the changes for 6933217 (Huge arrays >>>>> handled poorly in core libraries). The ensureCapacity() method in >>>>> the StringBuffer, StringBuilder, ArrayList, and Vector classes are >>>>> a public API that accepts negative numbers. The following >>>>> overflow-conscious code: >>>>> >>>>> if (minimumCapacity - value.length> 0) >>>>> >>>>> considers negative minimumCapacity as overflow case where >>>>> OutOfMemoryError will be thrown. So the implementation of the >>>>> public ensureCapacity() methods need to check if the input argument >>>>> is positive before doing the above overflow-conscious check. >>>>> >>>>> Thanks >>>>> Mandy >>> > From Alan.Bateman at oracle.com Tue Oct 19 11:09:07 2010 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 19 Oct 2010 12:09:07 +0100 Subject: Code review request for 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError In-Reply-To: <4CBD1998.2030409@oracle.com> References: <4CBCCD27.5070806@oracle.com> <4CBCDE22.4020505@oracle.com> <4CBD1998.2030409@oracle.com> Message-ID: <4CBD7C53.6030803@oracle.com> Mandy Chung wrote: > : > I missed the Vector.capacity() method. Thanks. I updated the test. > http://cr.openjdk.java.net/~mchung/6992121/webrev.01/ If you want another reviewer, then the fix looks good to me. Minor nit, but it might be better to name the tests EnsureCapacity rather than TestEnsureCapacity, just to keep the naming convention locally consistent. -Alan. From mandy.chung at oracle.com Tue Oct 19 16:49:24 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 19 Oct 2010 16:49:24 +0000 Subject: hg: jdk7/tl/jdk: 6992968: test/java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh should not hang Message-ID: <20101019164951.29CE64728F@hg.openjdk.java.net> Changeset: 617ada000804 Author: mchung Date: 2010-10-19 09:49 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/617ada000804 6992968: test/java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh should not hang Reviewed-by: alanb, dholmes ! test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java ! test/java/lang/management/MemoryMXBean/CollectionUsageThresholdConcMarkSweepGC.sh From mandy.chung at oracle.com Tue Oct 19 17:02:57 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 19 Oct 2010 17:02:57 +0000 Subject: hg: jdk7/tl/jdk: 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError with minCap=Integer.MIN_VALUE Message-ID: <20101019170307.016B247290@hg.openjdk.java.net> Changeset: c6320457db65 Author: mchung Date: 2010-10-19 10:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c6320457db65 6992121: StringBuilder.ensureCapacity(int minCap) throws OutOfMemoryError with minCap=Integer.MIN_VALUE Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/Vector.java + test/java/lang/StringBuilder/EnsureCapacity.java + test/java/util/ArrayList/EnsureCapacity.java From jonathan.gibbons at oracle.com Tue Oct 19 22:03:04 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 19 Oct 2010 22:03:04 +0000 Subject: hg: jdk7/tl/langtools: 6987760: remove 308 support from JDK7 Message-ID: <20101019220307.0BA2F4729B@hg.openjdk.java.net> Changeset: 4851ff2ffc10 Author: jjg Date: 2010-10-19 15:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/4851ff2ffc10 6987760: remove 308 support from JDK7 Reviewed-by: darcy, mcimadamore - src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java ! src/share/classes/com/sun/source/tree/MethodTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/tree/TypeParameterTree.java - src/share/classes/com/sun/source/util/AbstractTypeProcessor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java - test/tools/javac/T6985181.java ! test/tools/javac/annotations/6881115/T6881115.java ! test/tools/javac/annotations/6881115/T6881115.out - test/tools/javac/diags/examples/TypeAnnotationsNotSupported.java ! test/tools/javac/processing/model/element/TestAnonClassNames.java ! test/tools/javac/tree/TreePosTest.java - test/tools/javac/treeannotests/AnnoTreeTests.java - test/tools/javac/typeAnnotations/6967002/T6967002.java - test/tools/javac/typeAnnotations/6967002/T6967002.out - test/tools/javac/typeAnnotations/InnerClass.java - test/tools/javac/typeAnnotations/MultipleTargets.java - test/tools/javac/typeAnnotations/TypeParameterTarget.java - test/tools/javac/typeAnnotations/TypeUseTarget.java - test/tools/javac/typeAnnotations/attribution/Scopes.java - test/tools/javac/typeAnnotations/classfile/DeadCode.java - test/tools/javac/typeAnnotations/failures/AnnotationVersion.java - test/tools/javac/typeAnnotations/failures/AnnotationVersion.out - test/tools/javac/typeAnnotations/failures/IncompleteArray.java - test/tools/javac/typeAnnotations/failures/IncompleteArray.out - test/tools/javac/typeAnnotations/failures/IncompleteVararg.java - test/tools/javac/typeAnnotations/failures/IncompleteVararg.out - test/tools/javac/typeAnnotations/failures/IndexArray.java - test/tools/javac/typeAnnotations/failures/IndexArray.out - test/tools/javac/typeAnnotations/failures/LintCast.java - test/tools/javac/typeAnnotations/failures/LintCast.out - test/tools/javac/typeAnnotations/failures/OldArray.java - test/tools/javac/typeAnnotations/failures/Scopes.java - test/tools/javac/typeAnnotations/failures/Scopes.out - test/tools/javac/typeAnnotations/failures/StaticFields.java - test/tools/javac/typeAnnotations/failures/StaticFields.out - test/tools/javac/typeAnnotations/failures/StaticMethods.java - test/tools/javac/typeAnnotations/failures/StaticMethods.out - test/tools/javac/typeAnnotations/failures/VoidGenericMethod.java - test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out - test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java - test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out - test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.java - test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.out - test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java - test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out - test/tools/javac/typeAnnotations/failures/target/Constructor.java - test/tools/javac/typeAnnotations/failures/target/Constructor.out - test/tools/javac/typeAnnotations/failures/target/IncompleteArray.java - test/tools/javac/typeAnnotations/failures/target/IncompleteArray.out - test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.java - test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.out - test/tools/javac/typeAnnotations/failures/target/NotTypeUse.java - test/tools/javac/typeAnnotations/failures/target/NotTypeUse.out - test/tools/javac/typeAnnotations/failures/target/VoidMethod.java - test/tools/javac/typeAnnotations/failures/target/VoidMethod.out ! test/tools/javac/typeAnnotations/newlocations/BasicTest.java + test/tools/javac/typeAnnotations/newlocations/BasicTest.out - test/tools/javac/typeAnnotations/newlocations/ClassExtends.java - test/tools/javac/typeAnnotations/newlocations/ClassLiterals.java - test/tools/javac/typeAnnotations/newlocations/ClassParameters.java - test/tools/javac/typeAnnotations/newlocations/ConstructorTypeArgs.java - test/tools/javac/typeAnnotations/newlocations/Expressions.java - test/tools/javac/typeAnnotations/newlocations/Fields.java - test/tools/javac/typeAnnotations/newlocations/LocalVariables.java - test/tools/javac/typeAnnotations/newlocations/MethodReturnType.java - test/tools/javac/typeAnnotations/newlocations/MethodTypeArgs.java - test/tools/javac/typeAnnotations/newlocations/MethodTypeParameters.java - test/tools/javac/typeAnnotations/newlocations/Parameters.java - test/tools/javac/typeAnnotations/newlocations/Receivers.java - test/tools/javac/typeAnnotations/newlocations/Throws.java - test/tools/javac/typeAnnotations/newlocations/TypeCasts.java - test/tools/javac/typeAnnotations/newlocations/TypeParameters.java - test/tools/javac/typeAnnotations/newlocations/Wildcards.java - test/tools/javap/typeAnnotations/ArrayClassLiterals.java - test/tools/javap/typeAnnotations/ArrayClassLiterals2.java - test/tools/javap/typeAnnotations/ClassLiterals.java - test/tools/javap/typeAnnotations/JSR175Annotations.java - test/tools/javap/typeAnnotations/NewArray.java - test/tools/javap/typeAnnotations/Presence.java - test/tools/javap/typeAnnotations/PresenceInner.java - test/tools/javap/typeAnnotations/T6855990.java - test/tools/javap/typeAnnotations/Visibility.java From David.Holmes at oracle.com Thu Oct 21 04:40:18 2010 From: David.Holmes at oracle.com (David Holmes) Date: Thu, 21 Oct 2010 14:40:18 +1000 Subject: Use of OPENWIN_HOME on linux Message-ID: <4CBFC432.1000206@oracle.com> It used to be in JDK6 that you could use ALT_OPENWIN_HOME to override the default OPENWIN_HOME settings in the makefiles for the j2se workspace. But now in JDK7 this has gone and the value is hardwired in Defs-linux.gmk: override OPENWIN_HOME =/usr/X11R6/ Can someone tell me why this change was made? It seems to go against the normal policy of using the ALT_* variables to customize settings. This value needs to be overridden externally when doing cross-compilation. Thanks, David From chris.hegarty at oracle.com Thu Oct 21 08:46:01 2010 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 21 Oct 2010 09:46:01 +0100 Subject: Use of OPENWIN_HOME on linux In-Reply-To: <4CBFC432.1000206@oracle.com> References: <4CBFC432.1000206@oracle.com> Message-ID: <4CBFFDC9.7010109@oracle.com> David, Looking at the history of Defs-linux.gmk you can see that (ALT_)OPENWIN_HOME was added for CR 2154143, in JDK6u10. This CR is also marked as fixed in JDK7 b65 ( my guess would be as part of the forward port of the client 6u10 stuff ). I'm not sure why the ALT_OPENWIN_HOME support was never forward ported. I've cc'ed the relevant RE's, they should be able to give a better reasoning. -Chris. On 21/10/2010 05:40, David Holmes wrote: > It used to be in JDK6 that you could use ALT_OPENWIN_HOME to override > the default OPENWIN_HOME settings in the makefiles for the j2se > workspace. But now in JDK7 this has gone and the value is hardwired in > Defs-linux.gmk: > > override OPENWIN_HOME =/usr/X11R6/ > > Can someone tell me why this change was made? It seems to go against the > normal policy of using the ALT_* variables to customize settings. > > This value needs to be overridden externally when doing cross-compilation. > > Thanks, > David From David.Holmes at oracle.com Thu Oct 21 08:55:16 2010 From: David.Holmes at oracle.com (David Holmes) Date: Thu, 21 Oct 2010 18:55:16 +1000 Subject: Use of OPENWIN_HOME on linux In-Reply-To: <4CBFFDC9.7010109@oracle.com> References: <4CBFC432.1000206@oracle.com> <4CBFFDC9.7010109@oracle.com> Message-ID: <4CBFFFF4.2060309@oracle.com> Thanks Chris. I had just this minute come to the realization that the JDK6 code is the code that changed, while JDK7 has the original code. Those CRs are somewhat lacking in detail, but cross-compilation is exactly why this needs to be settable. I'm working on the SE-Embedded merge with JDK7, so I can make the change as part of that work, to support cross-compilation. Just wanted to get a better understanding of why things were the way they are before I started making changes. Cheers, David Chris Hegarty said the following on 10/21/10 18:46: > David, > > Looking at the history of Defs-linux.gmk you can see that > (ALT_)OPENWIN_HOME was added for CR 2154143, in JDK6u10. This CR is also > marked as fixed in JDK7 b65 ( my guess would be as part of the forward > port of the client 6u10 stuff ). I'm not sure why the ALT_OPENWIN_HOME > support was never forward ported. I've cc'ed the relevant RE's, they > should be able to give a better reasoning. > > -Chris. > > On 21/10/2010 05:40, David Holmes wrote: >> It used to be in JDK6 that you could use ALT_OPENWIN_HOME to override >> the default OPENWIN_HOME settings in the makefiles for the j2se >> workspace. But now in JDK7 this has gone and the value is hardwired in >> Defs-linux.gmk: >> >> override OPENWIN_HOME =/usr/X11R6/ >> >> Can someone tell me why this change was made? It seems to go against the >> normal policy of using the ALT_* variables to customize settings. >> >> This value needs to be overridden externally when doing >> cross-compilation. >> >> Thanks, >> David From anthony.petrov at oracle.com Thu Oct 21 09:10:51 2010 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 21 Oct 2010 13:10:51 +0400 Subject: Use of OPENWIN_HOME on linux In-Reply-To: <4CBFC432.1000206@oracle.com> References: <4CBFC432.1000206@oracle.com> Message-ID: <4CC0039B.3030707@oracle.com> Hi David, According to the SCCS history, the ALT_OPENWIN_HOME has been introduced with CR 2154143 (which is a 6u10 SubCR of 6613871). The CR is marked as delivered to 7b65 as well, however the ALT_OPENWIN_HOME changes in make/common/shared/Defs-linux.gmk have been lost for some reason. I think we should ask Andy (CC'ed) because he's the RE for that fix in 7. -- best regards, Anthony On 10/21/2010 8:40 AM, David Holmes wrote: > It used to be in JDK6 that you could use ALT_OPENWIN_HOME to override > the default OPENWIN_HOME settings in the makefiles for the j2se > workspace. But now in JDK7 this has gone and the value is hardwired in > Defs-linux.gmk: > > override OPENWIN_HOME =/usr/X11R6/ > > Can someone tell me why this change was made? It seems to go against the > normal policy of using the ALT_* variables to customize settings. > > This value needs to be overridden externally when doing cross-compilation. > > Thanks, > David From alan.bateman at oracle.com Thu Oct 21 13:41:11 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 21 Oct 2010 13:41:11 +0000 Subject: hg: jdk7/tl/jdk: 6993267: TEST_BUG: java/nio/file/Path/InterruptCopy.java fails intermittently (win) Message-ID: <20101021134122.0D79F47310@hg.openjdk.java.net> Changeset: d9057727e2fa Author: alanb Date: 2010-10-21 14:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9057727e2fa 6993267: TEST_BUG: java/nio/file/Path/InterruptCopy.java fails intermittently (win) Reviewed-by: forax ! test/java/nio/file/Path/InterruptCopy.java From chris.hegarty at oracle.com Thu Oct 21 15:52:05 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 21 Oct 2010 15:52:05 +0000 Subject: hg: jdk7/tl/jdk: 2 new changesets Message-ID: <20101021155223.E601647316@hg.openjdk.java.net> Changeset: 70bf328b7c65 Author: chegar Date: 2010-10-21 16:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/70bf328b7c65 6993490: SocketTimeoutException on HTTP keep-alive connections Reviewed-by: michaelm ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/www/protocol/ftp/FtpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! test/sun/net/www/http/HttpClient/B6726695.java ! test/sun/net/www/http/KeepAliveCache/B5045306.java ! test/sun/net/www/protocol/http/ChunkedErrorStream.java Changeset: 19cbbf152335 Author: chegar Date: 2010-10-21 16:51 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/19cbbf152335 6992859: InetAddressCachePolicy.setIfNotSet() fails Reviewed-by: michaelm ! src/share/classes/sun/net/InetAddressCachePolicy.java From chris.hegarty at oracle.com Fri Oct 22 08:20:57 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 22 Oct 2010 08:20:57 +0000 Subject: hg: jdk7/tl/jdk: 6947677: InetAddress.isReachable() throws "java.net.SocketException:Invalid argument" on Linux if run as root Message-ID: <20101022082107.781334734A@hg.openjdk.java.net> Changeset: 549257d35662 Author: chegar Date: 2010-10-22 09:20 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/549257d35662 6947677: InetAddress.isReachable() throws "java.net.SocketException:Invalid argument" on Linux if run as root Reviewed-by: alanb ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c From alan.bateman at oracle.com Fri Oct 22 16:41:42 2010 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 22 Oct 2010 16:41:42 +0000 Subject: hg: jdk7/tl/jdk: 6816049: (bf) MappedByteBuffer.force() method does not flush data correctly Message-ID: <20101022164151.CC2EC47360@hg.openjdk.java.net> Changeset: 3740c2da7cc5 Author: alanb Date: 2010-10-22 17:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3740c2da7cc5 6816049: (bf) MappedByteBuffer.force() method does not flush data correctly Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/share/classes/java/nio/MappedByteBuffer.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/share/classes/sun/nio/ch/FileDispatcher.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/classes/sun/nio/ch/FileDispatcherImpl.java ! src/solaris/native/java/nio/MappedByteBuffer.c ! src/windows/classes/sun/nio/ch/FileDispatcherImpl.java ! src/windows/native/java/nio/MappedByteBuffer.c ! src/windows/native/sun/nio/ch/FileDispatcherImpl.c ! test/java/nio/MappedByteBuffer/Basic.java From mandy.chung at oracle.com Fri Oct 22 18:23:11 2010 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Fri, 22 Oct 2010 18:23:11 +0000 Subject: hg: jdk7/tl/jdk: 6985460: PlatformLogger throws ArrayStoreException when j.u.logging is initialized Message-ID: <20101022182321.529F047366@hg.openjdk.java.net> Changeset: 0fd9c87a9b7b Author: mchung Date: 2010-10-22 11:22 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0fd9c87a9b7b 6985460: PlatformLogger throws ArrayStoreException when j.u.logging is initialized Reviewed-by: dholmes ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/util/logging/PlatformLogger.java ! test/sun/util/logging/PlatformLoggerTest.java + test/sun/util/logging/SourceClassName.java From chris.hegarty at oracle.com Fri Oct 22 19:28:56 2010 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 22 Oct 2010 19:28:56 +0000 Subject: hg: jdk7/tl/jdk: 6994079: PlainSocketImpl should close the socket if it fails Message-ID: <20101022192905.E971047371@hg.openjdk.java.net> Changeset: 0b07344d5526 Author: chegar Date: 2010-10-22 20:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b07344d5526 6994079: PlainSocketImpl should close the socket if it fails Reviewed-by: alanb ! src/share/classes/java/net/AbstractPlainSocketImpl.java From jonathan.gibbons at oracle.com Fri Oct 22 21:05:14 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 22 Oct 2010 21:05:14 +0000 Subject: hg: jdk7/tl/langtools: 6993301: catch parameters do not have correct kind (i.e. ElementKind.EXCEPTION_PARAMETER) Message-ID: <20101022210516.1128347376@hg.openjdk.java.net> Changeset: 01eabcd240e9 Author: jjg Date: 2010-10-22 14:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/01eabcd240e9 6993301: catch parameters do not have correct kind (i.e. ElementKind.EXCEPTION_PARAMETER) Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/T6993301.java From kumar.x.srinivasan at oracle.com Mon Oct 25 17:39:57 2010 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 25 Oct 2010 17:39:57 +0000 Subject: hg: jdk7/tl/jdk: 6989469: (launcher) compiler warnings in jli native code Message-ID: <20101025174020.EDD2D4740B@hg.openjdk.java.net> Changeset: defd25291e27 Author: ksrini Date: 2010-10-25 10:34 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/defd25291e27 6989469: (launcher) compiler warnings in jli native code Reviewed-by: darcy, ohair, sherman ! src/share/bin/java.c ! src/share/bin/parse_manifest.c ! src/share/bin/wildcard.c ! src/share/native/java/util/zip/zlib-1.2.3/zcrc32.c ! src/solaris/bin/java_md.c ! src/solaris/bin/jexec.c ! src/windows/bin/java_md.c From jonathan.gibbons at oracle.com Tue Oct 26 21:30:22 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 26 Oct 2010 21:30:22 +0000 Subject: hg: jdk7/tl/langtools: 6949587: rename "DisjointType" to "DisjunctType" Message-ID: <20101026213024.AC7A547455@hg.openjdk.java.net> Changeset: 7755f47542a0 Author: jjg Date: 2010-10-26 14:29 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7755f47542a0 6949587: rename "DisjointType" to "DisjunctType" Reviewed-by: mcimadamore - src/share/classes/com/sun/source/tree/DisjointTypeTree.java + src/share/classes/com/sun/source/tree/DisjunctiveTypeTree.java ! src/share/classes/com/sun/source/tree/Tree.java ! src/share/classes/com/sun/source/tree/TreeVisitor.java ! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java From keith.mcguigan at oracle.com Wed Oct 27 23:45:47 2010 From: keith.mcguigan at oracle.com (keith.mcguigan at oracle.com) Date: Wed, 27 Oct 2010 23:45:47 +0000 Subject: hg: jdk7/tl/jdk: 6541462: outdated specification for CCC 6339875 Message-ID: <20101027234557.27E1547491@hg.openjdk.java.net> Changeset: 613f1b310cdb Author: kamg Date: 2010-10-26 18:41 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/613f1b310cdb 6541462: outdated specification for CCC 6339875 Summary: Add documentation to java.lang.ClassLoader.defineClass() Reviewed-by: dcubed, darcy ! src/share/classes/java/lang/ClassLoader.java From weijun.wang at oracle.com Thu Oct 28 13:26:36 2010 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 28 Oct 2010 13:26:36 +0000 Subject: hg: jdk7/tl/jdk: 6950546: "ktab -d name etype" to "ktab -d name [-e etype] [kvno | all | old]"; ... Message-ID: <20101028132646.32F0C474BD@hg.openjdk.java.net> Changeset: dfce5a0cc460 Author: weijun Date: 2010-10-28 21:14 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dfce5a0cc460 6950546: "ktab -d name etype" to "ktab -d name [-e etype] [kvno | all | old]" 6984764: kerberos fails if service side keytab is generated using JDK ktab Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! src/windows/classes/sun/security/krb5/internal/tools/Ktab.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/tools/KtabCheck.java + test/sun/security/krb5/tools/ktcheck.sh + test/sun/security/krb5/tools/onlythree.conf From abhi.saha at oracle.com Thu Oct 28 05:06:35 2010 From: abhi.saha at oracle.com (abhi.saha at oracle.com) Date: Thu, 28 Oct 2010 05:06:35 +0000 Subject: hg: jdk7/tl/corba: 2 new changesets Message-ID: <20101028050636.943FE474A3@hg.openjdk.java.net> Changeset: b2fff4b7e8cd Author: skoppar Date: 2010-09-24 22:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/b2fff4b7e8cd 6891766: Vulnerabilities in use of reflection in CORBA Reviewed-by: hawtin - src/share/classes/com/sun/corba/se/impl/io/IIOPInputStream.java ! src/share/classes/com/sun/corba/se/impl/io/ValueHandlerImpl.java ! src/share/classes/com/sun/corba/se/impl/orb/PrefixParserAction.java ! src/share/classes/com/sun/corba/se/impl/orbutil/ObjectUtility.java ! src/share/classes/com/sun/corba/se/impl/transport/SocketOrChannelAcceptorImpl.java ! src/share/classes/com/sun/corba/se/spi/orb/OperationFactory.java ! src/share/classes/com/sun/corba/se/spi/orb/ParserImplBase.java Changeset: f3090f80102d Author: asaha Date: 2010-10-26 13:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/f3090f80102d Merge From abhi.saha at oracle.com Thu Oct 28 05:12:45 2010 From: abhi.saha at oracle.com (abhi.saha at oracle.com) Date: Thu, 28 Oct 2010 05:12:45 +0000 Subject: hg: jdk7/tl/jdk: 7 new changesets Message-ID: <20101028051352.1244C474A4@hg.openjdk.java.net> Changeset: 69646b4db21d Author: skoppar Date: 2010-09-28 01:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/69646b4db21d 6559775: Race allows defaultReadObject to be invoked instead of readFields during deserialization Reviewed-by: hawtin ! make/java/java/FILES_java.gmk ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/java/io/ObjectOutputStream.java + src/share/classes/java/io/SerialCallbackContext.java + test/java/io/Serializable/6559775/README + test/java/io/Serializable/6559775/SerialRace.java + test/java/io/Serializable/6559775/SerialVictim.java + test/java/io/Serializable/6559775/Test6559775.sh Changeset: 2070c497e241 Author: skoppar Date: 2010-09-28 01:13 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2070c497e241 6966692: defaultReadObject can set a field multiple times Reviewed-by: hawtin ! src/share/classes/java/io/ObjectStreamClass.java + test/java/io/Serializable/6966692/Attack.java + test/java/io/Serializable/6966692/README + test/java/io/Serializable/6966692/Test6966692.sh + test/java/io/Serializable/6966692/Victim.java Changeset: 7f4006dec750 Author: asaha Date: 2010-10-11 16:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7f4006dec750 Merge - make/common/Rules-SCCS.gmk ! make/java/java/FILES_java.gmk - src/linux/doc/man/ja/kinit.1 - src/linux/doc/man/ja/klist.1 - src/linux/doc/man/ja/ktab.1 - src/share/classes/com/sun/media/sound/MidiDeviceReceiver.java - src/share/classes/sun/java2d/pisces/PiscesMath.java - src/share/classes/sun/java2d/pisces/Transform4.java - src/share/native/sun/java2d/cmm/lcms/cmscam97.c - src/share/native/sun/java2d/cmm/lcms/cmsmatsh.c - src/share/native/sun/java2d/cmm/lcms/icc34.h - src/share/native/sun/java2d/cmm/lcms/lcms.h - src/solaris/classes/sun/net/spi/SdpProvider.java - src/solaris/native/sun/net/spi/SdpProvider.c - test/java/net/Socket/AccurateTimeout.java - test/java/util/Locale/data/deflocale.exe - test/java/util/Locale/data/deflocale.jds3 - test/java/util/Locale/data/deflocale.rhel4 - test/java/util/Locale/data/deflocale.winvista - test/java/util/Locale/data/deflocale.winxp - test/sun/net/www/http/ChunkedInputStream/ChunkedCharEncoding.sh - test/tools/launcher/VerifyExceptions.java - test/tools/pack200/Pack200Simple.sh - test/tools/pack200/SegmentLimit.java Changeset: 96c75aec5545 Author: asaha Date: 2010-10-27 13:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/96c75aec5545 Merge ! make/java/java/FILES_java.gmk - test/java/io/Serializable/6559775/README - test/java/io/Serializable/6559775/SerialRace.java - test/java/io/Serializable/6559775/SerialVictim.java - test/java/io/Serializable/6559775/Test6559775.sh - test/java/io/Serializable/6966692/Attack.java - test/java/io/Serializable/6966692/README - test/java/io/Serializable/6966692/Test6966692.sh - test/java/io/Serializable/6966692/Victim.java Changeset: 82eb9c5fa896 Author: asaha Date: 2010-10-27 13:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/82eb9c5fa896 6993206: Removing non-functional tests. Reviewed-by: mchung - test/java/io/Serializable/6559775/README - test/java/io/Serializable/6559775/SerialRace.java - test/java/io/Serializable/6559775/SerialVictim.java - test/java/io/Serializable/6559775/Test6559775.sh - test/java/io/Serializable/6966692/Attack.java - test/java/io/Serializable/6966692/README - test/java/io/Serializable/6966692/Test6966692.sh - test/java/io/Serializable/6966692/Victim.java Changeset: 72e09416a65d Author: asaha Date: 2010-10-27 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/72e09416a65d Merge Changeset: 4f91da528c68 Author: asaha Date: 2010-10-27 22:10 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4f91da528c68 Merge From jonathan.gibbons at oracle.com Thu Oct 28 17:19:19 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 28 Oct 2010 17:19:19 +0000 Subject: hg: jdk7/tl/langtools: 6460352: Reintroduce Scope.dble Message-ID: <20101028171921.A6217474CC@hg.openjdk.java.net> Changeset: 601160d857ef Author: jjg Date: 2010-10-28 10:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/601160d857ef 6460352: Reintroduce Scope.dble Reviewed-by: mcimadamore, jjg Contributed-by: per.bothner at oracle.com ! src/share/classes/com/sun/tools/javac/code/Scope.java From jonathan.gibbons at oracle.com Fri Oct 29 01:59:02 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 29 Oct 2010 01:59:02 +0000 Subject: hg: jdk7/tl/langtools: 6994946: option to specify only syntax errors as unrecoverable Message-ID: <20101029015904.5C662474F4@hg.openjdk.java.net> Changeset: 2974d3800eb1 Author: jjg Date: 2010-10-28 18:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2974d3800eb1 6994946: option to specify only syntax errors as unrecoverable Reviewed-by: darcy, mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java + test/tools/javac/processing/6994946/SemanticErrorTest.1.out + test/tools/javac/processing/6994946/SemanticErrorTest.2.out + test/tools/javac/processing/6994946/SemanticErrorTest.java + test/tools/javac/processing/6994946/SyntaxErrorTest.java + test/tools/javac/processing/6994946/SyntaxErrorTest.out + test/tools/javac/processing/6994946/TestProcessor.java From jonathan.gibbons at oracle.com Fri Oct 29 19:48:16 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 29 Oct 2010 19:48:16 +0000 Subject: hg: jdk7/tl/langtools: 6993304: JavacTrees.getAttrContext not updated to Tree.Kind.{ANNOTATION_TYPE, ENUM, INTERFACE} Message-ID: <20101029194818.B02E647520@hg.openjdk.java.net> Changeset: 460b2f588d0d Author: jjg Date: 2010-10-29 12:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/460b2f588d0d 6993304: JavacTrees.getAttrContext not updated to Tree.Kind.{ANNOTATION_TYPE,ENUM,INTERFACE} Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java From jonathan.gibbons at oracle.com Fri Oct 29 20:13:20 2010 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 29 Oct 2010 20:13:20 +0000 Subject: hg: jdk7/tl/langtools: 6994608: javah no longer accepts parameter files as input Message-ID: <20101029201322.916D347529@hg.openjdk.java.net> Changeset: 895bea45a3e8 Author: jjg Date: 2010-10-29 13:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/895bea45a3e8 6994608: javah no longer accepts parameter files as input Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/resources/l10n.properties + test/tools/javah/T6994608.java From mandy.chung at oracle.com Fri Oct 29 21:38:46 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 29 Oct 2010 14:38:46 -0700 Subject: Code Review Request for 6994413: JDK_GetVersionInfo0 only expects a two digit build number In-Reply-To: <4CC4D236.2070007@oracle.com> References: <4CC4D236.2070007@oracle.com> Message-ID: <4CCB3EE6.20306@oracle.com> Hi David, I have a fix for: 6994413 JDK_GetVersionInfo0 only expects a two digit build number Webrev at: http://cr.openjdk.java.net/~mchung/6994413/webrev.00/ Can you please review it? Thanks Mandy On 10/24/10 5:41 PM, David Holmes wrote: > FYI I just filed: > > 6994413 JDK_GetVersionInfo0 only expects a two digit build number > > Since b100 we've lost the build number from the version string made > available to the VM. The above is filed under java->java->build but > that may not be the right place. > > Cheers, > David Holmes From eamonn.mcmanus at oracle.com Fri Oct 29 10:36:04 2010 From: eamonn.mcmanus at oracle.com (eamonn.mcmanus at oracle.com) Date: Fri, 29 Oct 2010 10:36:04 +0000 Subject: hg: jdk7/tl/jdk: 6984037: jmx/management rebranding vendor changes needed Message-ID: <20101029103626.6225247508@hg.openjdk.java.net> Changeset: 7fee717f4707 Author: emcmanus Date: 2010-10-29 12:35 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7fee717f4707 6984037: jmx/management rebranding vendor changes needed Reviewed-by: ohair ! make/netbeans/jmx/build.properties ! src/share/classes/com/sun/jmx/defaults/ServiceName.java ! src/share/classes/com/sun/jmx/snmp/ServiceName.java ! src/share/classes/com/sun/management/package.html ! src/share/classes/javax/management/ObjectName.java ! src/share/classes/javax/management/build.xml ! src/share/classes/javax/management/modelmbean/ModelMBeanNotificationInfo.java From David.Holmes at oracle.com Sat Oct 30 02:28:04 2010 From: David.Holmes at oracle.com (David Holmes) Date: Sat, 30 Oct 2010 12:28:04 +1000 Subject: Code Review Request for 6994413: JDK_GetVersionInfo0 only expects a two digit build number In-Reply-To: <4CCB3EE6.20306@oracle.com> References: <4CC4D236.2070007@oracle.com> <4CCB3EE6.20306@oracle.com> Message-ID: <4CCB82B4.5080201@oracle.com> Hi Mandy, Mandy Chung said the following on 10/30/10 07:38: > I have a fix for: > 6994413 JDK_GetVersionInfo0 only expects a two digit build number > > Webrev at: > http://cr.openjdk.java.net/~mchung/6994413/webrev.00/ If the build "number" consists of just 'b' then you'll end up doing atoi on an empty string - will that have the right effect? Otherwise change looks ok, but I didn't review the test case (which doesn't seem directly related to this fixc anyway). David > Can you please review it? > > Thanks > Mandy > > On 10/24/10 5:41 PM, David Holmes wrote: >> FYI I just filed: >> >> 6994413 JDK_GetVersionInfo0 only expects a two digit build number >> >> Since b100 we've lost the build number from the version string made >> available to the VM. The above is filed under java->java->build but >> that may not be the right place. >> >> Cheers, >> David Holmes > From mandy.chung at oracle.com Sat Oct 30 02:44:23 2010 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 29 Oct 2010 19:44:23 -0700 Subject: Code Review Request for 6994413: JDK_GetVersionInfo0 only expects a two digit build number In-Reply-To: <4CCB82B4.5080201@oracle.com> References: <4CC4D236.2070007@oracle.com> <4CCB3EE6.20306@oracle.com> <4CCB82B4.5080201@oracle.com> Message-ID: <4CCB8687.4000100@oracle.com> On 10/29/10 7:28 PM, David Holmes wrote: > Hi Mandy, > > Mandy Chung said the following on 10/30/10 07:38: >> I have a fix for: >> 6994413 JDK_GetVersionInfo0 only expects a two digit build number >> >> Webrev at: >> http://cr.openjdk.java.net/~mchung/6994413/webrev.00/ > > If the build "number" consists of just 'b' then you'll end up doing > atoi on an empty string - will that have the right effect? > Good catch. line 60 should check that it has to contain at least 2 characters (as the behavior of atoi in the case of error is undefined): line 60 if (jdk_build_string[0] == 'b' && len >= 2) { > Otherwise change looks ok, but I didn't review the test case (which > doesn't seem directly related to this fixc anyway). > This test fails with the current jdk 7 build but passes with this fix. sun.misc.Version.* methods provide access to the jdk_version_info and jvm_version_info. i.e. the jdkBuildNumber() method basically returns the build number from the jdk_version_info. Rather than testing just the jdk build number, I have the test to verify the entire version string (as well as the jvm version). Thanks Mandy > David > >> Can you please review it? >> >> Thanks >> Mandy >> >> On 10/24/10 5:41 PM, David Holmes wrote: >>> FYI I just filed: >>> >>> 6994413 JDK_GetVersionInfo0 only expects a two digit build number >>> >>> Since b100 we've lost the build number from the version string made >>> available to the VM. The above is filed under java->java->build but >>> that may not be the right place. >>> >>> Cheers, >>> David Holmes >> From David.Holmes at oracle.com Sat Oct 30 03:24:31 2010 From: David.Holmes at oracle.com (David Holmes) Date: Sat, 30 Oct 2010 13:24:31 +1000 Subject: Code Review Request for 6994413: JDK_GetVersionInfo0 only expects a two digit build number In-Reply-To: <4CCB8687.4000100@oracle.com> References: <4CC4D236.2070007@oracle.com> <4CCB3EE6.20306@oracle.com> <4CCB82B4.5080201@oracle.com> <4CCB8687.4000100@oracle.com> Message-ID: <4CCB8FEF.6010104@oracle.com> By the way, shouldn't we use isdigit rather than: if (jdk_build_string[i] >= '0' && jdk_build_string[i] <= '9') { David ----- Mandy Chung said the following on 10/30/10 12:44: > On 10/29/10 7:28 PM, David Holmes wrote: >> Hi Mandy, >> >> Mandy Chung said the following on 10/30/10 07:38: >>> I have a fix for: >>> 6994413 JDK_GetVersionInfo0 only expects a two digit build number >>> >>> Webrev at: >>> http://cr.openjdk.java.net/~mchung/6994413/webrev.00/ >> >> If the build "number" consists of just 'b' then you'll end up doing >> atoi on an empty string - will that have the right effect? >> > Good catch. line 60 should check that it has to contain at least 2 > characters (as the behavior of atoi in the case of error is undefined): > > line 60 if (jdk_build_string[0] == 'b' && len >= 2) { > >> Otherwise change looks ok, but I didn't review the test case (which >> doesn't seem directly related to this fixc anyway). >> > > This test fails with the current jdk 7 build but passes with this fix. > sun.misc.Version.* methods provide access to the jdk_version_info and > jvm_version_info. i.e. the jdkBuildNumber() method basically returns > the build number from the jdk_version_info. Rather than testing just > the jdk build number, I have the test to verify the entire version > string (as well as the jvm version). > > Thanks > Mandy >> David >> >>> Can you please review it? >>> >>> Thanks >>> Mandy >>> >>> On 10/24/10 5:41 PM, David Holmes wrote: >>>> FYI I just filed: >>>> >>>> 6994413 JDK_GetVersionInfo0 only expects a two digit build number >>>> >>>> Since b100 we've lost the build number from the version string made >>>> available to the VM. The above is filed under java->java->build but >>>> that may not be the right place. >>>> >>>> Cheers, >>>> David Holmes >>> > From xuelei.fan at oracle.com Sat Oct 30 10:47:40 2010 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Sat, 30 Oct 2010 10:47:40 +0000 Subject: hg: jdk7/tl/jdk: 4873188: Support TLS 1.1 Message-ID: <20101030104801.8CCF647548@hg.openjdk.java.net> Changeset: 93cd7e89adb8 Author: xuelei Date: 2010-10-30 18:39 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/93cd7e89adb8 4873188: Support TLS 1.1 Reviewed-by: wetmore, weijun ! src/share/classes/javax/net/ssl/SSLSocketFactory.java ! src/share/classes/sun/security/internal/spec/TlsKeyMaterialParameterSpec.java ! src/share/classes/sun/security/internal/spec/TlsMasterSecretParameterSpec.java ! src/share/classes/sun/security/ssl/CipherBox.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/Debug.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/KerberosClientKeyExchange.java ! src/share/classes/sun/security/ssl/MAC.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/ProtocolVersion.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java ! src/share/classes/sun/security/ssl/Record.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/SunJSSE.java ! src/share/classes/sun/security/ssl/krb5/KerberosClientKeyExchangeImpl.java ! src/share/classes/sun/security/ssl/krb5/KerberosPreMasterSecret.java ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/sslecc/CipherTest.java + test/sun/security/ssl/javax/net/ssl/TLSv11/EmptyCertificateAuthorities.java + test/sun/security/ssl/javax/net/ssl/TLSv11/ExportableBlockCipher.java + test/sun/security/ssl/javax/net/ssl/TLSv11/ExportableStreamCipher.java + test/sun/security/ssl/javax/net/ssl/TLSv11/GenericBlockCipher.java + test/sun/security/ssl/javax/net/ssl/TLSv11/GenericStreamCipher.java ! test/sun/security/ssl/sanity/interop/CipherTest.java