Code Review Request for # 6975829 : Perf. of gzip in existing JDKs is too slower than in 1.3.1
Xueming Shen
xueming.shen at oracle.com
Tue Oct 5 19:33:33 UTC 2010
On 10/05/2010 12:18 PM, Alan Bateman wrote:
> Xueming Shen wrote:
>> Thanks! webrev has been updated as suggested.
>>
>> http://cr.openjdk.java.net/~sherman/6975829/webrev/
>> <http://cr.openjdk.java.net/%7Esherman/6975829/webrev/>
>>
>> -Sherman
> Looks fine. A minor comment is that you don't need to update this_off
> and it might be clear to just set the offset field to this_off + consumed.
>
> -Alan.
wow, good catch:-)
Done.
http://cr.openjdk.java.net/~sherman/6975829/webrev/
<http://cr.openjdk.java.net/%7Esherman/6975829/webrev/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/core-libs-dev/attachments/20101005/f92a73de/attachment.html>
More information about the core-libs-dev
mailing list